[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

haowei added a comment. There are also cases that this clang type-limit check will warn when checking if a enum type is larger than 0. For example, we are seeing warnings on ICU source code (https://github.com/unicode-org/icu/blob/8d5a97ae0f49f6974372736ca67db15c37522f6f/icu4c/source/i18n/displ

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets '/winsysroot' flag when building Windows

[PATCH] D141808: [Driver] Add --vfsoverlay flag

haowei added a comment. I am seeing test failures on pre submit Windows builder after this change was landed: See https://buildkite.com/llvm-project/premerge-checks/builds/135752#01864d34-9024-4c13-9137-88b6f41ec695 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac835ecb5fea: [Fuchsia] Set /winsysroot in Windows runtimes linker flags (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144595: [WIP] Experimenting building Windows runtimes when cross compiling LLVM toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: kristof.beyls. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a working in progress pat

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When using compiler caching program li

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe38cdc5933b0: Disable compiler launcher on external projects and multi stage clang (authored by haowei). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

haowei created this revision. haowei added reviewers: phosek, mcgrathr. Herald added subscribers: abrachet, mstorsjo. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds 'llvm-strings' to Fuch

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb398898dad9: [Fuchsia] Add llvm-strings to Fuchsia clang build. (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

haowei added a comment. In D152318#4402234 , @mstorsjo wrote: > FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. > While it does match a GNU binutils tool, I'm kinda curious where it is needed. llvm-strings exists in the `output

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482644. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c llvm/include/llvm/Su

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added a comment. I changed some comments and add more details. If there is no objection, can I get an approval on this change so I can land it? It will unblock our development on Windows cross compilation support. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1933-

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482658. haowei added a comment. Rebased the change to solve the merge conflicts on the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/In

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c llvm/include/llvm/Su

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa903ecb4a26d: [vfs] Allow root paths relative to the vfsoverlay YAML file (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added a comment. In D137473#3993584 , @bnbarham wrote: > LGTM. If you could put up a PR after to fix the use of > `sys::fs::make_absolute` that would be appreciated 🙇. Thanks, I will start working on the fix. Repository: rG LLVM Github Monore

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei created this revision. Herald added subscribers: xazax.hun, mgorny. This patch adds a new Static Analyzer checker for the correct use of handle in Magenta kernel. The concept of handle is very similar to file descriptor in Unix. This checker checks leaks, use after release and double re

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei updated this revision to Diff 107201. haowei added a comment. Thanks for reviewing this patch. I have modified the checker according NoQ's suggestions and refactored some long functions. > We're trying to use this CallDescription thing for this purpose recently. I took a look at CallDesc

[PATCH] D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei created this revision. Herald added subscribers: xazax.hun, mgorny. This patch supersedes https://reviews.llvm.org/D34724. We have finished the checker but it is too big to be submitted as a single commit. So we split it into several pieces to help with the review process. This patch incl

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei abandoned this revision. haowei added a comment. Superseded by https://reviews.llvm.org/D35968 https://reviews.llvm.org/D34724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33263: [scan-build] Patch to scan-build tool to support "--target=" flag

haowei created this revision. The scan-build script provided by clang can be used to detect defects in code in the compile time. However, we discovered that the "--target=" flag in clang is not properly handled by this script, which results in failures when analyzing projects that have used thi

[PATCH] D33263: [scan-build] Patch to scan-build tool to support "--target=" flag

haowei added a comment. In https://reviews.llvm.org/D33263#756900, @zaks.anna wrote: > Looks good. Thank you! > Do you have commit access or should we commit? I don't have commit access, so could you commit this patch? Thanks. https://reviews.llvm.org/D33263

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. We are seeing test failures in our builders with message after your patch. Could you take a look and fix this unit test please? FAIL: Clang :: Driver/debug-pass-structure.c (6773 of 27894) TEST 'Clang :: Driver/debug-pass-structure.c' FAILED

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. In D99599#2726252 , @evgeny777 wrote: > @haowei What are LLVM configuration options? Also please send output from > > /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager > -fdebug-pass-structure -O0 -S -emit-llvm

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. Output from `clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1`: Pass Arguments: -tti -targetlibinfo Target Transform Information Target Library Information

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei updated this revision to Diff 343780. haowei added a comment. Rebase the change to resolve presubmit errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100139/new/ https://reviews.llvm.org/D100139 Files: clang/cmake/caches/Fuchsia-stag

[PATCH] D99810: [ifs][elfabi] Merge llvm-elfabi tool into llvm-ifs

haowei marked 3 inline comments as done. haowei added a comment. I will try to split this change. Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:26 const bool WriteBin = !Args.getLastArg(options::OPT_emit_merged_ifs); - CmdArgs.push_back(WriteBin ? "write-bin" :

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei created this revision. haowei added reviewers: phosek, plotfi, compnerd, mcgrathr. Herald added subscribers: hiraditya, mgorny. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change merges llvm-elfabi a

[PATCH] D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36023: [analyzer] Add array support for MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36024: [analyzer] Improved bug reporting in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D93868: [analyzer] Update Fuchsia checker to catch when releasing unowned handles.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8deaec122ec6: [analyzer] Update Fuchsia checker to catch releasing unowned handles. (authored by Daniel Hwang , committed by haowei). Herald added a project: clang. Herald added a subscr

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei commandeered this revision. haowei added a reviewer: leonardchan. haowei added a comment. Herald added a subscriber: abrachet. I am commandeering this work as original author stopped working this project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377389. haowei edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basi

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377726. haowei marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/D

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; -

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378052. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cla

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei added a comment. I added unit test for macros. I am still working on adding error checks on `--ffuchsia-api-level` flags but the rest is pretty much done. Comment at: clang/test/Frontend/attr-availability-fuchsia.c:4 +// +// It should also be exposed to non-fuchsia plat

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378324. haowei added a comment. Added unit test when "-ffuchsia-api-level" is supplied with a non integer value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files:

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378780. haowei added a comment. Fix test failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378784. haowei added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG1131b1eb3509: [clang][Fuchsia] Support availability attr on Fuchsia (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://

[PATCH] D112271: [clang][Fuchsia] Add additional unit test for availability attr

haowei created this revision. haowei added reviewers: phosek, leonardchan, gulfem. Herald added a subscriber: abrachet. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds additional unit tests for availability attribute

[PATCH] D112271: [clang][Fuchsia] Add additional unit test for availability attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG07bed3ae52b0: [clang][Fuchsia] Add additional unit test for availability attr (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112271/new/

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei created this revision. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fallback-style is a frequently used flag in clang_format, however, it was not supported by clang-format-diff.py script. This change adds this flag. Repo

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei updated this revision to Diff 371749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109550/new/ https://reviews.llvm.org/D109550 Files: clang/tools/clang-format/clang-format-diff.py Index: clang/tools/clang-format/clang-format-diff.py ===

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/tools/clang-format/clang-format-diff.py:62 + parser.add_argument('-fallback-style', + dest='fallback_style', + help='The name of the predefined styl

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. haowei marked an inline comment as done. Closed by commit rG38a5bd4115af: [clang_format] Add fallback-style flag to clang-format-diff.py (authored by haowei). Reposito

<    1   2