Author: hokein
Date: Wed Sep 21 08:18:19 2016
New Revision: 282070
URL: http://llvm.org/viewvc/llvm-project?rev=282070&view=rev
Log:
[clang-move] A prototype tool for moving class definition to new file.
Summary:
This patch introduces a new tool which moves a specific class definition
from files
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282070: [clang-move] A prototype tool for moving class
definition to new file. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24243?vs=72031&id=72033#toc
Repository:
rL LLVM
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: hokein
Date: Wed Sep 21 10:19:04 2016
New Revision: 282074
URL: http://llvm.org/viewvc/llvm-project?rev=282074&view=rev
Log:
Fix compiler warnings.
Modified:
clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMo
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D24821
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNarrowi
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:290
@@ +289,3 @@
+ // namespace.
+ // Note that the matcher does not exlude calls to out-of-line static method
+ // definitions, so we need to exclude them in the callback handler.
s
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D24828
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
=
Author: hokein
Date: Thu Sep 22 09:36:43 2016
New Revision: 282158
URL: http://llvm.org/viewvc/llvm-project?rev=282158&view=rev
Log:
[clang-tidy] Add doc for `explain-config` option.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
clang-tools-extra/trunk/docs/clang-tid
hokein added a comment.
The interfaces look good to me roughly.
Comment at: migrate-tool/MigrationEnvironment.h:22
@@ +21,3 @@
+// RefactoringManager, and AffectedFilesFinder.
+class MigrationEnvironment {
+public:
`MigrationContext` might be better?
==
hokein updated this revision to Diff 72265.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments.
https://reviews.llvm.org/D24828
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveT
Author: hokein
Date: Fri Sep 23 08:28:38 2016
New Revision: 282247
URL: http://llvm.org/viewvc/llvm-project?rev=282247&view=rev
Log:
[clang-move] The new.cc file should include new_header.h instead of old_header.h
Summary:
Previously, all #includes (includeing old_header.h) in old.cc will be copi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282247: [clang-move] The new.cc file should include
new_header.h instead of old_header.h (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24828?vs=72265&id=72270#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282415: [ASTMatcher] Add isStaticStorageClass matcher for
varDecl and functionDecl. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24821?vs=72141&id=72502#toc
Repository:
rL
Author: hokein
Date: Mon Sep 26 11:01:52 2016
New Revision: 282415
URL: http://llvm.org/viewvc/llvm-project?rev=282415&view=rev
Log:
[ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.
Reviewers: klimek
Subscribers: cfe-commits, klimek
Differential Revision: https://revi
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D24922
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/I
hokein added inline comments.
Comment at: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h:3391
@@ +3390,3 @@
+/// \brief Matches variable/function declarations that have static storage
class
+/// (with "static" key word) written in the source.
+///
aaron.ballma
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D24928
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchers
hokein accepted this revision.
hokein added a comment.
LGTM.
https://reviews.llvm.org/D24862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 72608.
hokein added a comment.
Address review comments
https://reviews.llvm.org/D24928
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
Index: unittests/ASTMatchers/AST
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL282474: [ASTMatcher] Clarify isStaticStorageClass and
hasStaticStorageDuration… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24928?vs
Author: hokein
Date: Tue Sep 27 02:53:20 2016
New Revision: 282474
URL: http://llvm.org/viewvc/llvm-project?rev=282474&view=rev
Log:
[ASTMatcher] Clarify isStaticStorageClass and hasStaticStorageDuration
documents.
Reviewers: aaron.ballman
Subscribers: klimek, cfe-commits
Differential Revision
Author: hokein
Date: Tue Sep 27 02:58:52 2016
New Revision: 282476
URL: http://llvm.org/viewvc/llvm-project?rev=282476&view=rev
Log:
[clang-tidy] Use isStaticStorageClass ast matcher.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp
Modi
Author: hokein
Date: Tue Sep 27 03:01:04 2016
New Revision: 282477
URL: http://llvm.org/viewvc/llvm-project?rev=282477&view=rev
Log:
[clang-move] Use isStaticStorageClass matcher.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
Modified: clang-tools-extra/trunk/clang-move/ClangMov
hokein updated this revision to Diff 72613.
hokein added a comment.
Rebase to master
https://reviews.llvm.org/D24922
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/Inputs/test.cpp
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:62
@@ +61,3 @@
+ return MakeAbsolutePath(SourceManager, FileEntry->getName()) ==
+ AbsoluteFilePath;
+}
ioeric wrote:
> To generalize the function, maybe also remove dots in `AbsoluteFileP
hokein updated this revision to Diff 72619.
hokein marked 8 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D24922
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_
Author: hokein
Date: Tue Sep 27 05:43:38 2016
New Revision: 282480
URL: http://llvm.org/viewvc/llvm-project?rev=282480&view=rev
Log:
[include-fixer] Add customized editor settings documents.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D24719
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282480: [include-fixer] Add customized editor settings
documents. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24719?vs=71792&id=72623#toc
Repository:
rL LLVM
https://rev
hokein created this revision.
hokein added reviewers: klimek, djasper, ioeric.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The FilePath of the Replacement constructed from a SourceManager can be
an absolute file path or a file path relative to the build directory (It
hokein abandoned this revision.
hokein added a comment.
As discussed offline with klimek, we should change to the correct working
directory before applying the replacements. So abandon this.
https://reviews.llvm.org/D25006
___
cfe-commits mailing l
hokein created this revision.
hokein added reviewers: klimek, bkramer.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Provide a way allowing clang clients to get the common build directory
from the compilation database.
https://reviews.llvm.org/D25027
Files:
include
hokein updated this revision to Diff 72963.
hokein added a comment.
Correct the implementation of FixedCompilationDatabase::getCommonRoot.
https://reviews.llvm.org/D25027
Files:
include/clang/Tooling/CompilationDatabase.h
include/clang/Tooling/JSONCompilationDatabase.h
lib/Tooling/CommonO
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25226
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25227
Files:
clang-move/ClangMove.cpp
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
==
hokein updated this revision to Diff 73426.
hokein marked 3 inline comments as done.
hokein added a comment.
Herald added subscribers: mgorny, beanz.
Add clang-move tool in test/CMakeLists.
https://reviews.llvm.org/D24922
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/t
Author: hokein
Date: Tue Oct 4 04:05:31 2016
New Revision: 283202
URL: http://llvm.org/viewvc/llvm-project?rev=283202&view=rev
Log:
[clang-move] Make it support both relative and absolute file path arguments.
Reviewers: ioeric
Subscribers: beanz, mgorny, cfe-commits
Differential Revision: http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283202: [clang-move] Make it support both relative and
absolute file path arguments. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24922?vs=73426&id=73433#toc
Repository:
r
Author: hokein
Date: Tue Oct 4 04:49:20 2016
New Revision: 283205
URL: http://llvm.org/viewvc/llvm-project?rev=283205&view=rev
Log:
Fix windows builtbot error.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp
URL:
http://
hokein added a comment.
Looks almost fine, a few code-style comments.
> ASTUtils.h:11
> +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H
> +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H
> +#include "clang/AST/AST.h"
A blank line between define guard and include.
> ASTUtils.h:17
>
Author: hokein
Date: Tue Oct 4 05:35:53 2016
New Revision: 283210
URL: http://llvm.org/viewvc/llvm-project?rev=283210&view=rev
Log:
[change-namespace] Fix a misplaced case when there is no trailing newline
character at the end of the file.
Reviewers: ioeric
Subscribers: cfe-commits
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283210: [change-namespace] Fix a misplaced case when there
is no trailing newline… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25226?vs=73420&id=73447#toc
Repository:
rL
Author: hokein
Date: Tue Oct 4 05:40:52 2016
New Revision: 283211
URL: http://llvm.org/viewvc/llvm-project?rev=283211&view=rev
Log:
Fix a documentation warning.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.h
Modified: clang-tools-extra/trunk/clang-move/ClangMove.h
URL:
http://llv
hokein added inline comments.
> ChangeNamespace.cpp:176
> +// \param DeclName A fully qualified name, "::a::b::X" or "a::b::X".
> +// \param NsName A fully qualified name, "::a::b" or "a::b".
> std::string getShortestQualifiedNameInNamespace(llvm::StringRef DeclName,
Mightbe add a small doc say
hokein added inline comments.
> ioeric wrote in ClangMove.cpp:343
> Looks like `GetFullRange` is called twice on the same Decl: one for creating
> insertion replacement and one for deletion replacement. This seems to be a
> duplicate.
Good point. Yeah, currently the `GetFullRange` is called tw
hokein updated this revision to Diff 73463.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D25227
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTe
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
> ioeric wrote in ChangeNamespace.cpp:187
> Note that `str()` is called on `(NsName + "::")` instead of `consume_front`.
> But you are right, we can put the check into the while loop.
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25244
Files:
clang-tidy/google/NonConstReferences.cpp
clang-tidy/google/NonConstReferences.h
docs/clang-tidy/checks/google-runtime-references.rst
test/cl
Author: hokein
Date: Wed Oct 5 05:04:13 2016
New Revision: 283306
URL: http://llvm.org/viewvc/llvm-project?rev=283306&view=rev
Log:
Overhaul clang-include-fixer.el
General overhaul to fix many coding bugs, simplify the code, and improve
readability.
* Clarify documentation strings of user opti
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
cleanup the remaining empty namespace after moving out the
class defintitions.
https://reviews.llvm.org/D25282
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/Clan
Author: hokein
Date: Wed Oct 5 12:00:40 2016
New Revision: 283338
URL: http://llvm.org/viewvc/llvm-project?rev=283338&view=rev
Log:
[change-namespace] Pass Style to ChangeNamespaceTool.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-tools-ex
Author: hokein
Date: Thu Oct 6 03:29:32 2016
New Revision: 283424
URL: http://llvm.org/viewvc/llvm-project?rev=283424&view=rev
Log:
[clang-move] Cleanup around replacements.
Summary:
cleanup the remaining empty namespace after moving out the
class defintitions.
Reviewers: ioeric
Subscribers: c
Author: hokein
Date: Thu Oct 6 03:59:24 2016
New Revision: 283425
URL: http://llvm.org/viewvc/llvm-project?rev=283425&view=rev
Log:
[clang-move] Move comments which are associated with the moved class.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25309
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283424: [clang-move] Cleanup around replacements. (authored
by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25282?vs=73663&id=73786#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283425: [clang-move] Move comments which are associated with
the moved class. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25227?vs=73463&id=73785#toc
Repository:
rL LLVM
hokein added inline comments.
> ioeric wrote in ClangMove.cpp:316
> What would happen if `InMovedClassNames == false`?
"InMovedClassNames" should not be false in the matcher. Added an assert.
https://reviews.llvm.org/D25309
___
cfe-commits mailing
hokein updated this revision to Diff 73819.
hokein marked 7 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D25309
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_
hokein updated this revision to Diff 73888.
hokein marked 3 inline comments as done.
hokein added a comment.
Update.
https://reviews.llvm.org/D25309
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_template.json
t
Author: hokein
Date: Fri Oct 7 03:29:20 2016
New Revision: 283526
URL: http://llvm.org/viewvc/llvm-project?rev=283526&view=rev
Log:
[clang-move] Support moving multiple classes in one run.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25309
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283526: [clang-move] Support moving multiple classes in one
run. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25309?vs=73888&id=73890#toc
Repository:
rL LLVM
https://revi
Author: hokein
Date: Fri Oct 7 04:23:28 2016
New Revision: 283534
URL: http://llvm.org/viewvc/llvm-project?rev=283534&view=rev
Log:
Fix buildbot error.
The error maybe caused by the mixed environment of the two lint tests.
Cleanup the environment before running each test.
Modified:
clang-to
Author: hokein
Date: Fri Oct 7 05:59:03 2016
New Revision: 283538
URL: http://llvm.org/viewvc/llvm-project?rev=283538&view=rev
Log:
Revert "fix buildbot error" since it is not right fix.
Modified:
clang-tools-extra/trunk/test/clang-move/move-class.cpp
clang-tools-extra/trunk/test/clang-m
Author: hokein
Date: Fri Oct 7 07:35:37 2016
New Revision: 283545
URL: http://llvm.org/viewvc/llvm-project?rev=283545&view=rev
Log:
[clang-move] Simplify lint tests
No need to use compilation database.
Removed:
clang-tools-extra/trunk/test/clang-move/Inputs/database_template.json
Modified:
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
- When moving an outermost enclosing class, all its nested classes should also
be moved together.
- Add a test for not moving nested class.
https://reviews.llvm.org/D25369
Files:
clang-move
hokein added a comment.
friendly ping. Aaron, could you take a look on this patch?
https://reviews.llvm.org/D25244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 73976.
hokein marked 2 inline comments as done.
hokein added a comment.
support moving static member of nested class when moving its enclosing class.
https://reviews.llvm.org/D25369
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/multiple_class_te
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:27
+AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass,
+ ast_matchers::internal::Matcher, InnerMatcher) {
ioeric wrote:
> I'm not sure if we really need to limit this to the `o
Author: hokein
Date: Mon Oct 10 09:21:55 2016
New Revision: 283754
URL: http://llvm.org/viewvc/llvm-project?rev=283754&view=rev
Log:
[include-fixer] query-mode should be false by default.
Makes it consistent with documentations.
Modified:
clang-tools-extra/trunk/include-fixer/tool/clang-incl
hokein updated this revision to Diff 74138.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D25244
Files:
clang-tidy/google/NonConstReferences.cpp
clang-tidy/google/NonConstReferences.h
docs/clang-tidy/checks/google-runtim
hokein created this revision.
hokein added a subscriber: cfe-commits.
- Fix a false postive when an using class is used in an explicit template
instantiation.
- Fix a false postive when an using template class is used as template argument.
https://reviews.llvm.org/D25437
Files:
clang-tidy/mi
Author: hokein
Date: Mon Oct 10 11:38:11 2016
New Revision: 283777
URL: http://llvm.org/viewvc/llvm-project?rev=283777&view=rev
Log:
[clang-tidy] Add a whitelist option in google-runtime-references.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.or
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one more nit.
Comment at: clang-tidy/utils/ASTUtils.h:25
+
+#endif
missing a trailing comment `// LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H`
hokein updated this revision to Diff 74221.
hokein added a comment.
Add FIXME.
https://reviews.llvm.org/D25437
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein added inline comments.
Comment at: test/clang-tidy/misc-unused-using-decls.cpp:191
+// n::N is using in the explicit template instantiations.
+template void h(n::M* t);
aaron.ballman wrote:
> Can you add a test using a non-type template argument, like an i
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:387
+ Token Tok;
+ while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {
+ }
Maybe we can use `findLocationAfterToken` here?
https://reviews.llvm.org/D25397
hokein added inline comments.
Comment at:
test/clang-tidy/cppcoreguidelines-pro-type-member-init-literal-initializers.cpp:1
+// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-member-init %t --
-config="{CheckOptions: [{key:
"cppcoreguidelines-pro-type-member-init.Literal
hokein updated this revision to Diff 74239.
hokein added a comment.
Add a non-type template argument test.
https://reviews.llvm.org/D25437
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
Author: hokein
Date: Tue Oct 11 08:50:34 2016
New Revision: 283879
URL: http://llvm.org/viewvc/llvm-project?rev=283879&view=rev
Log:
[clang-tidy] Fix template agrument false positives in unused-using-decls.
Summary:
* Fix a false postive when an using class is used in an explicit template
instan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283879: [clang-tidy] Fix template agrument false positives
in unused-using-decls. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25437?vs=74239&id=74254#toc
Repository:
rL L
Author: hokein
Date: Wed Oct 12 02:59:54 2016
New Revision: 283981
URL: http://llvm.org/viewvc/llvm-project?rev=283981&view=rev
Log:
[ClangTidy] Add UsingInserter and NamespaceAliaser
Summary: This adds helper classes to add using declaractions and namespace
aliases to function bodies. These hel
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283981: [ClangTidy] Add UsingInserter and NamespaceAliaser
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24997?vs=74311&id=74338#toc
Repository:
rL LLVM
https://reviews.ll
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: change-namespace/ChangeNamespace.cpp:387
+ Token Tok;
+ while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {
+ }
i
Author: hokein
Date: Wed Oct 12 03:19:44 2016
New Revision: 283985
URL: http://llvm.org/viewvc/llvm-project?rev=283985&view=rev
Log:
Revert "[ClangTidy] Add UsingInserter and NamespaceAliaser"
This reverts commit r283981. This patch breaks the buildbot.
Removed:
clang-tools-extra/trunk/clang
hokein added a comment.
@jbangert, your patch broke the buildbot, and I reverted it in r283985. You
need to add the new source files to the CMakefile. (I saw other compilation
errors after I updated the cmake files, Could you take a look on it? )
Repository:
rL LLVM
https://reviews.llvm.org
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added subscribers: bkramer, cfe-commits.
Herald added subscribers: mgorny, beanz.
This patch is kind of reverting r283202 (but keep the updated lint test),
because it leads to a few annoying problems by comparing absolute file p
hokein updated this revision to Diff 74375.
hokein added a comment.
Update the patch based on offline discussion.
https://reviews.llvm.org/D25508
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/move-class.cpp
Index: test/clang-move/move-clas
hokein updated this revision to Diff 74382.
hokein added a comment.
Update.
https://reviews.llvm.org/D25508
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/move-class.cpp
Index: test/clang-move/move-class.cpp
=
Author: hokein
Date: Wed Oct 12 10:50:30 2016
New Revision: 284020
URL: http://llvm.org/viewvc/llvm-project?rev=284020&view=rev
Log:
[clang-move] Compare with real paths of symlinks
Summary: MakeAbsolutePath does wrong things with symlinks previously. When
comparing with a symlink, we need to co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284020: [clang-move] Compare with real paths of symlinks
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25508?vs=74382&id=74391#toc
Repository:
rL LLVM
https://reviews.llvm
Author: hokein
Date: Thu Oct 13 03:48:42 2016
New Revision: 284109
URL: http://llvm.org/viewvc/llvm-project?rev=284109&view=rev
Log:
Recommit r283538 "[clang-move] Support moving multiple classes in one run."
Added:
clang-tools-extra/trunk/test/clang-move/Inputs/multiple_class_test.cpp
cl
hokein updated this revision to Diff 74490.
hokein added a comment.
Rebase to master.
https://reviews.llvm.org/D25369
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/multiple_class_test.cpp
test/clang-move/Inputs/multiple_class_test.h
test/clang-move/move-multiple-classes.cpp
In
Author: hokein
Date: Thu Oct 13 05:31:00 2016
New Revision: 284111
URL: http://llvm.org/viewvc/llvm-project?rev=284111&view=rev
Log:
[clang-move] Better support enclosing class.
Summary:
* When moving an outermost enclosing class, all its nested classes should also
be moved together.
* Add a te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284111: [clang-move] Better support enclosing class.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25369?vs=74490&id=74492#toc
Repository:
rL LLVM
https://reviews.llvm.org
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25598
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/test.cpp
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
Index: test/clang-move/move
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25600
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
Index: unittests/ASTMa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284221: [clang-move] Matching static class member more
correctly. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25598?vs=74633&id=74650#toc
Repository:
rL LLVM
https://rev
Author: hokein
Date: Fri Oct 14 05:07:58 2016
New Revision: 284221
URL: http://llvm.org/viewvc/llvm-project?rev=284221&view=rev
Log:
[clang-move] Matching static class member more correctly.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25598
Modif
401 - 500 of 3085 matches
Mail list logo
