[PATCH] D28365: [Driver] Updated for Visual Studio 2017

2017-02-02 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood updated this revision to Diff 86900. hamzasood added a comment. In https://reviews.llvm.org/D28365#665183, @rnk wrote: > I had to revert this because it doesn't pass tests on Linux. Can you look > into that and resubmit after fixing those test failures? Really sorry about that, I stu

[PATCH] D35729: [Frontend] - Mark some ASTUnit methods as const

2017-07-21 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood created this revision. While using the libtooling API, I ran into problems when using a const ASTUnit. There were a few functions I needed to use that don't seem to modify anything, but they weren't marked as const so I couldn't use them. This patch marks those methods (and a few othe

[PATCH] D35729: [Frontend] - Mark some ASTUnit methods as const

2017-07-22 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood added a comment. Could someone commit this for me? I don't have access. https://reviews.llvm.org/D35729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

2017-02-13 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood added a comment. In https://reviews.llvm.org/D28365#665408, @rnk wrote: > Doesn't your fix mean that the tests will fail on a Windows machine that > doesn't have VS because LLVM was built with mingw? Usually in these > situations we provide some way to provide a fake toolchain. I'm

<    1   2