r313944 - [Analyzer] Log when auto-synthesized body is used.

2017-09-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 21 17:37:12 2017 New Revision: 313944 URL: http://llvm.org/viewvc/llvm-project?rev=313944&view=rev Log: [Analyzer] Log when auto-synthesized body is used. Differential Revision: https://reviews.llvm.org/D37910 Modified: cfe/trunk/lib/StaticAnalyzer/Core

r313949 - [Analyzer] Refactor analyzer testing scripts.

2017-09-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 21 18:41:16 2017 New Revision: 313949 URL: http://llvm.org/viewvc/llvm-project?rev=313949&view=rev Log: [Analyzer] Refactor analyzer testing scripts. - Exporting needed function for future reuse. - Idiomatic python: using with `file as f` instead of `try/f

r313950 - [Analyzer] Static analyzer script for updating reference results

2017-09-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Sep 21 18:43:12 2017 New Revision: 313950 URL: http://llvm.org/viewvc/llvm-project?rev=313950&view=rev Log: [Analyzer] Static analyzer script for updating reference results The script updates reference results from the previous run, and stages them. Differentia

r314042 - [Analyzer] Fix minor errors in python scripts.

2017-09-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 22 15:58:46 2017 New Revision: 314042 URL: http://llvm.org/viewvc/llvm-project?rev=314042&view=rev Log: [Analyzer] Fix minor errors in python scripts. Modified: cfe/trunk/utils/analyzer/SATestBuild.py cfe/trunk/utils/analyzer/SATestUpdateDiffs.py Mo

r369020 - Test commit #2.

2019-08-15 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Aug 15 10:17:21 2019 New Revision: 369020 URL: http://llvm.org/viewvc/llvm-project?rev=369020&view=rev Log: Test commit #2. Modified: cfe/trunk/www/index.html Modified: cfe/trunk/www/index.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www/index.h

r349863 - Revert "Revert "[driver] [analyzer] Fix a backward compatibility issue after r348038.""

2018-12-20 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Dec 20 16:26:19 2018 New Revision: 349863 URL: http://llvm.org/viewvc/llvm-project?rev=349863&view=rev Log: Revert "Revert "[driver] [analyzer] Fix a backward compatibility issue after r348038."" This reverts commit 144927939587b790c0536f4ff08245043fc8d733. Fi

r349875 - [analyzer] Fix a bug in RetainCountDiagnostics while printing a note on mismatched summary in inlined functions

2018-12-20 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Dec 20 18:16:23 2018 New Revision: 349875 URL: http://llvm.org/viewvc/llvm-project?rev=349875&view=rev Log: [analyzer] Fix a bug in RetainCountDiagnostics while printing a note on mismatched summary in inlined functions Previously, we were not printing a note a

r349876 - [analyzer] Perform escaping in RetainCountChecker on type mismatch even for inlined functions

2018-12-20 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Dec 20 18:16:36 2018 New Revision: 349876 URL: http://llvm.org/viewvc/llvm-project?rev=349876&view=rev Log: [analyzer] Perform escaping in RetainCountChecker on type mismatch even for inlined functions The fix done in D55465 did not previously apply when the fu

r349938 - [analyzer] Correct the summary violation diagnostics for the retain count checker

2018-12-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Dec 21 11:13:28 2018 New Revision: 349938 URL: http://llvm.org/viewvc/llvm-project?rev=349938&view=rev Log: [analyzer] Correct the summary violation diagnostics for the retain count checker It should be in the past tense. Modified: cfe/trunk/lib/StaticAna

r349939 - Revert "Revert rL349876 from cfe/trunk: [analyzer] Perform escaping in RetainCountChecker on type mismatch even for inlined functions"

2018-12-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Dec 21 11:13:40 2018 New Revision: 349939 URL: http://llvm.org/viewvc/llvm-project?rev=349939&view=rev Log: Revert "Revert rL349876 from cfe/trunk: [analyzer] Perform escaping in RetainCountChecker on type mismatch even for inlined functions" This reverts commi

r349943 - [analyzer] Tests quickfix.

2018-12-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Dec 21 11:40:44 2018 New Revision: 349943 URL: http://llvm.org/viewvc/llvm-project?rev=349943&view=rev Log: [analyzer] Tests quickfix. Modified: cfe/trunk/test/Analysis/osobject-retain-release.cpp Modified: cfe/trunk/test/Analysis/osobject-retain-release.cp

r350057 - [analyzer] [NFC] Clean up the mess of constructing argument effects in RetainCountChecker

2018-12-24 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Dec 24 10:45:18 2018 New Revision: 350057 URL: http://llvm.org/viewvc/llvm-project?rev=350057&view=rev Log: [analyzer] [NFC] Clean up the mess of constructing argument effects in RetainCountChecker Previously, argument effects were stored in a method variable,

r350858 - [analyzer] [NFC] Track object type with ArgEffect in RetainCountChecker.

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:13:59 2019 New Revision: 350858 URL: http://llvm.org/viewvc/llvm-project?rev=350858&view=rev Log: [analyzer] [NFC] Track object type with ArgEffect in RetainCountChecker. This would be needed in the future. https://reviews.llvm.org/D56040 Modified:

r350857 - [analyzer] [NFC] Move ObjKind into a separate top-level enum in RetainSummaryManager.

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:13:46 2019 New Revision: 350857 URL: http://llvm.org/viewvc/llvm-project?rev=350857&view=rev Log: [analyzer] [NFC] Move ObjKind into a separate top-level enum in RetainSummaryManager. Allows using it in future outside of RetEffect. Differential Revis

r350859 - [analyzer] [RetainCountChecker] [NFC] Remove redundant enum items *Msg, as the object type is already communicated by a separate field

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:14:12 2019 New Revision: 350859 URL: http://llvm.org/viewvc/llvm-project?rev=350859&view=rev Log: [analyzer] [RetainCountChecker] [NFC] Remove redundant enum items *Msg, as the object type is already communicated by a separate field Differential Revis

r350861 - [analyzer] [RetainCountChecker] Remove redundant enum UnarySummaryKind

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:14:38 2019 New Revision: 350861 URL: http://llvm.org/viewvc/llvm-project?rev=350861&view=rev Log: [analyzer] [RetainCountChecker] Remove redundant enum UnarySummaryKind Differential Revision: https://reviews.llvm.org/D56072 Modified: cfe/trunk/inc

r350862 - [analyzer] [RetainCountChecker] [NFC] Refactor the way attributes are handled

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:14:51 2019 New Revision: 350862 URL: http://llvm.org/viewvc/llvm-project?rev=350862&view=rev Log: [analyzer] [RetainCountChecker] [NFC] Refactor the way attributes are handled Make sure all checks for attributes go through a centralized function, which

r350863 - [analyzer] [RetainCountChecker] [NFC] Another minor cleanup

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:15:04 2019 New Revision: 350863 URL: http://llvm.org/viewvc/llvm-project?rev=350863&view=rev Log: [analyzer] [RetainCountChecker] [NFC] Another minor cleanup Differential Revision: https://reviews.llvm.org/D56224 Modified: cfe/trunk/include/clang/

r350860 - [analyzer] [RetainCountChecker] Remove obsolete "MakeCollectable" enum value

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:14:25 2019 New Revision: 350860 URL: http://llvm.org/viewvc/llvm-project?rev=350860&view=rev Log: [analyzer] [RetainCountChecker] Remove obsolete "MakeCollectable" enum value Differential Revision: https://reviews.llvm.org/D56071 Modified: cfe/tru

r350865 - [analyzer] [NFC] Reduce redundancy in RetainSummaryManager by using a function

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:15:30 2019 New Revision: 350865 URL: http://llvm.org/viewvc/llvm-project?rev=350865&view=rev Log: [analyzer] [NFC] Reduce redundancy in RetainSummaryManager by using a function Differential Revision: https://reviews.llvm.org/D56282 Modified: cfe/t

r350864 - [analyzer] [RetainCountChecker] [NFC] Remove SummaryLog

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:15:17 2019 New Revision: 350864 URL: http://llvm.org/viewvc/llvm-project?rev=350864&view=rev Log: [analyzer] [RetainCountChecker] [NFC] Remove SummaryLog The complicated machinery for passing the summary log around is actually only used for one thing!

r350866 - [analyzer] [NFC] Reverse the argument order for "diff" in tests

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:15:44 2019 New Revision: 350866 URL: http://llvm.org/viewvc/llvm-project?rev=350866&view=rev Log: [analyzer] [NFC] Reverse the argument order for "diff" in tests The current argument order has "expected" and "actual" the wrong way around, so that the d

r350868 - [analyzer] [NFC] [RetainCountChecker] Remove dead unused map

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:16:10 2019 New Revision: 350868 URL: http://llvm.org/viewvc/llvm-project?rev=350868&view=rev Log: [analyzer] [NFC] [RetainCountChecker] Remove dead unused map Differential Revision: https://reviews.llvm.org/D56402 Modified: cfe/trunk/lib/StaticAn

r350869 - [analyzer] Update the category name for RetainCountChecker reports

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:16:25 2019 New Revision: 350869 URL: http://llvm.org/viewvc/llvm-project?rev=350869&view=rev Log: [analyzer] Update the category name for RetainCountChecker reports ..now that it includes OSObjects rdar://46509986 Differential Revision: https://revie

r350870 - [analyzer] [hotfix] Fix the tests

2019-01-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jan 10 10:28:10 2019 New Revision: 350870 URL: http://llvm.org/viewvc/llvm-project?rev=350870&view=rev Log: [analyzer] [hotfix] Fix the tests The error must have crept during the cherry-pick. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountCheck

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

2018-04-12 Thread George Karpenkov via cfe-commits
Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file: instead of changing the run lines to use -mllvm you have removed them. Was there a reason for the remo

r335666 - [analyzer] Do not run visitors until the fixpoint, run only once.

2018-06-26 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jun 26 14:12:08 2018 New Revision: 335666 URL: http://llvm.org/viewvc/llvm-project?rev=335666&view=rev Log: [analyzer] Do not run visitors until the fixpoint, run only once. In the current implementation, we run visitors until the fixed point is reached. That is

r335683 - [analyzer] Minor cleanups for BugReporter, expose a getter for AnalyzerOptions.

2018-06-26 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jun 26 16:10:05 2018 New Revision: 335683 URL: http://llvm.org/viewvc/llvm-project?rev=335683&view=rev Log: [analyzer] Minor cleanups for BugReporter, expose a getter for AnalyzerOptions. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugR

r335685 - [analyzer] [tests] Include statistics in tests.

2018-06-26 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jun 26 16:17:35 2018 New Revision: 335685 URL: http://llvm.org/viewvc/llvm-project?rev=335685&view=rev Log: [analyzer] [tests] Include statistics in tests. Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/utils/analyzer/SATestBuild.py U

r335700 - [analyzer] [NFC] Add -verify to malloc checker test

2018-06-26 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jun 26 18:51:36 2018 New Revision: 335700 URL: http://llvm.org/viewvc/llvm-project?rev=335700&view=rev Log: [analyzer] [NFC] Add -verify to malloc checker test Differential Revision: https://reviews.llvm.org/D48514 Modified: cfe/trunk/test/Analysis/malloc-p

r335701 - [analyzer] [NFC] A convenient getter for getting a current stack frame

2018-06-26 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jun 26 18:51:55 2018 New Revision: 335701 URL: http://llvm.org/viewvc/llvm-project?rev=335701&view=rev Log: [analyzer] [NFC] A convenient getter for getting a current stack frame Differential Revision: https://reviews.llvm.org/D44756 Modified: cfe/trunk/inc

r336023 - [analyzer] [tests] Allow the tested project to specify it's own analyzer wrapper

2018-06-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jun 29 15:05:32 2018 New Revision: 336023 URL: http://llvm.org/viewvc/llvm-project?rev=336023&view=rev Log: [analyzer] [tests] Allow the tested project to specify it's own analyzer wrapper Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trun

r336022 - [analyzer] [tests] Fix 80 column violation in SATestBuild.py

2018-06-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jun 29 15:05:13 2018 New Revision: 336022 URL: http://llvm.org/viewvc/llvm-project?rev=336022&view=rev Log: [analyzer] [tests] Fix 80 column violation in SATestBuild.py Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/utils/analyzer/SAT

r336124 - [analyzer] [tests] Pass clang executable path to prefix-less executor scripts.

2018-07-02 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 2 10:10:40 2018 New Revision: 336124 URL: http://llvm.org/viewvc/llvm-project?rev=336124&view=rev Log: [analyzer] [tests] Pass clang executable path to prefix-less executor scripts. Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/

r336468 - [ASTMatchers] A matcher for Objective-C @autoreleasepool

2018-07-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jul 6 14:36:04 2018 New Revision: 336468 URL: http://llvm.org/viewvc/llvm-project?rev=336468&view=rev Log: [ASTMatchers] A matcher for Objective-C @autoreleasepool Differential Revision: https://reviews.llvm.org/D48910 Modified: cfe/trunk/docs/LibASTMatche

r336753 - [analyzer] Pass through all arguments from the registerChecker() to the checker constructor

2018-07-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jul 10 18:23:27 2018 New Revision: 336753 URL: http://llvm.org/viewvc/llvm-project?rev=336753&view=rev Log: [analyzer] Pass through all arguments from the registerChecker() to the checker constructor A lot of checkers could be cleaned up in a similar way Diffe

r336755 - [analyzer] Partial revert of https://reviews.llvm.org/D49050

2018-07-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jul 10 18:58:08 2018 New Revision: 336755 URL: http://llvm.org/viewvc/llvm-project?rev=336755&view=rev Log: [analyzer] Partial revert of https://reviews.llvm.org/D49050 Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp Modified: cfe

r336756 - [analyzer] Fix bots by changing the analyzer-config tests.

2018-07-10 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jul 10 19:01:18 2018 New Revision: 336756 URL: http://llvm.org/viewvc/llvm-project?rev=336756&view=rev Log: [analyzer] Fix bots by changing the analyzer-config tests. To be investigated. Modified: cfe/trunk/test/Analysis/analyzer-config.c cfe/trunk/test

r337209 - [ASTMatchers] Introduce Objective-C matchers `hasReceiver` and `isInstanceMessage` for ObjCMessageExpr

2018-07-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 16 13:22:12 2018 New Revision: 337209 URL: http://llvm.org/viewvc/llvm-project?rev=337209&view=rev Log: [ASTMatchers] Introduce Objective-C matchers `hasReceiver` and `isInstanceMessage` for ObjCMessageExpr Differential Revision: https://reviews.llvm.org/D4

r337211 - [analyzer] Provide a symmetric method for generating a PathDiagnosticLocation from Decl

2018-07-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 16 13:32:32 2018 New Revision: 337211 URL: http://llvm.org/viewvc/llvm-project?rev=337211&view=rev Log: [analyzer] Provide a symmetric method for generating a PathDiagnosticLocation from Decl Differential Revision: https://reviews.llvm.org/D49166 Modified:

r337212 - [analyzer] Fix GCDAntipatternChecker to only fire when the semaphore is initialized to zero

2018-07-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 16 13:32:57 2018 New Revision: 337212 URL: http://llvm.org/viewvc/llvm-project?rev=337212&view=rev Log: [analyzer] Fix GCDAntipatternChecker to only fire when the semaphore is initialized to zero Initializing a semaphore with a different constant most likel

r337213 - [analyzer] Bugfix for an overly eager suppression for null pointer return from macros.

2018-07-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 16 13:33:25 2018 New Revision: 337213 URL: http://llvm.org/viewvc/llvm-project?rev=337213&view=rev Log: [analyzer] Bugfix for an overly eager suppression for null pointer return from macros. Only suppress those cases where the null which came from the macro

r337214 - [ASTMatchers] Quickfix for tests.

2018-07-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Jul 16 13:42:37 2018 New Revision: 337214 URL: http://llvm.org/viewvc/llvm-project?rev=337214&view=rev Log: [ASTMatchers] Quickfix for tests. Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Modified: cfe/trunk/unittests/ASTMatchers/AS

r319697 - [analyzer] [NFC] remove duplicated function

2017-12-04 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Dec 4 13:00:05 2017 New Revision: 319697 URL: http://llvm.org/viewvc/llvm-project?rev=319697&view=rev Log: [analyzer] [NFC] remove duplicated function Two copies of getSymLERange in RangeConstraintManager are virtually identical, which is clearly bad. This patc

r319834 - [analyzer] do not crash on cases where an array subscript is an rvalue

2017-12-05 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Dec 5 13:19:59 2017 New Revision: 319834 URL: http://llvm.org/viewvc/llvm-project?rev=319834&view=rev Log: [analyzer] do not crash on cases where an array subscript is an rvalue Array subscript is almost always an lvalue, except for a few cases where it is not,

r310733 - Add -fsanitize=fuzzer-no-link flag to the driver.

2017-08-11 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Aug 11 10:22:58 2017 New Revision: 310733 URL: http://llvm.org/viewvc/llvm-project?rev=310733&view=rev Log: Add -fsanitize=fuzzer-no-link flag to the driver. The flag will perform instrumentation necessary to the fuzzing, but will NOT link libLLVMFuzzer.a librar

r311406 - Moving libFuzzer to compiler-rt: required updates to the Clang driver.

2017-08-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Aug 21 16:25:19 2017 New Revision: 311406 URL: http://llvm.org/viewvc/llvm-project?rev=311406&view=rev Log: Moving libFuzzer to compiler-rt: required updates to the Clang driver. Differential Revision: https://reviews.llvm.org/D36909 Modified: cfe/trunk/lib

r311412 - Fixed driver tests for -fsanitize=fuzzer.

2017-08-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Aug 21 17:04:05 2017 New Revision: 311412 URL: http://llvm.org/viewvc/llvm-project?rev=311412&view=rev Log: Fixed driver tests for -fsanitize=fuzzer. Modified: cfe/trunk/test/Driver/fuzzer.c Modified: cfe/trunk/test/Driver/fuzzer.c URL: http://llvm.org/vie

r311422 - Test fix: only add shared libraries to rpath.

2017-08-21 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Aug 21 19:10:53 2017 New Revision: 311422 URL: http://llvm.org/viewvc/llvm-project?rev=311422&view=rev Log: Test fix: only add shared libraries to rpath. Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.c

r311514 - Remove LLVMFuzzer from list of bundled libraries for Fuchsia

2017-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Aug 22 17:09:33 2017 New Revision: 311514 URL: http://llvm.org/viewvc/llvm-project?rev=311514&view=rev Log: Remove LLVMFuzzer from list of bundled libraries for Fuchsia As of now, libFuzzer is located in compiler-rt and is bundled with Clang's toolchain by defau

r311516 - Update Clang fuzzers to use libFuzzer bundled with the toolchain.

2017-08-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Aug 22 17:42:22 2017 New Revision: 311516 URL: http://llvm.org/viewvc/llvm-project?rev=311516&view=rev Log: Update Clang fuzzers to use libFuzzer bundled with the toolchain. Differential Revision: https://reviews.llvm.org/D37043 Modified: cfe/trunk/tools/cl

r311621 - Fix ClangFormatFuzzer.

2017-08-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Aug 23 17:30:28 2017 New Revision: 311621 URL: http://llvm.org/viewvc/llvm-project?rev=311621&view=rev Log: Fix ClangFormatFuzzer. Modified: cfe/trunk/tools/clang-format/fuzzer/ClangFormatFuzzer.cpp Modified: cfe/trunk/tools/clang-format/fuzzer/ClangFormatF

r328281 - [analyzer] Extend GCDAntipatternChecker to match group_enter/group_leave pattern

2018-03-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Mar 22 17:16:02 2018 New Revision: 328281 URL: http://llvm.org/viewvc/llvm-project?rev=328281&view=rev Log: [analyzer] Extend GCDAntipatternChecker to match group_enter/group_leave pattern rdar://38480416 Differential Revision: https://reviews.llvm.org/D44653

r328280 - [analyzer] [NFC] Move worklist implementation to WorkList.cpp

2018-03-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Mar 22 17:16:01 2018 New Revision: 328280 URL: http://llvm.org/viewvc/llvm-project?rev=328280&view=rev Log: [analyzer] [NFC] Move worklist implementation to WorkList.cpp Current location is very confusing, especially because there is already WorkList.h, and othe

r328282 - [analyzer] Trust _Nonnull annotations for system framework

2018-03-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Mar 22 17:16:03 2018 New Revision: 328282 URL: http://llvm.org/viewvc/llvm-project?rev=328282&view=rev Log: [analyzer] Trust _Nonnull annotations for system framework Changes the analyzer to believe that methods annotated with _Nonnull from system frameworks ind

r328406 - [analyzer] Do not crash in CallEvent.getReturnType()

2018-03-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Mar 23 18:53:12 2018 New Revision: 328406 URL: http://llvm.org/viewvc/llvm-project?rev=328406&view=rev Log: [analyzer] Do not crash in CallEvent.getReturnType() When the call expression is not available. Added: cfe/trunk/test/Analysis/Inputs/system-header-s

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

2018-03-26 Thread George Karpenkov via cfe-commits
ng::ToolInvocation::runInvocation > clang::tooling::ToolInvocation::run > > Could you fix or revert the patch? > > > On Fri, Mar 23, 2018 at 1:18 AM George Karpenkov via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: george.karpenkov > Date: Th

r328746 - [ASTMatchers] Extend hasParameter and hasAnyParameter matches to handle Objective-C methods

2018-03-28 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Mar 28 17:51:11 2018 New Revision: 328746 URL: http://llvm.org/viewvc/llvm-project?rev=328746&view=rev Log: [ASTMatchers] Extend hasParameter and hasAnyParameter matches to handle Objective-C methods Differential Revision: https://reviews.llvm.org/D44707 Modif

r328747 - [ASTMatchers] Introduce a matcher for matching any given Objective-C selector

2018-03-28 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Mar 28 17:51:12 2018 New Revision: 328747 URL: http://llvm.org/viewvc/llvm-project?rev=328747&view=rev Log: [ASTMatchers] Introduce a matcher for matching any given Objective-C selector Incudes a tiny related refactoring. Differential Revision: https://reviews.

r328749 - [ast] Do not auto-initialize Objective-C for-loop variables in Objective-C++ in templatized code under ARC

2018-03-28 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Mar 28 17:56:24 2018 New Revision: 328749 URL: http://llvm.org/viewvc/llvm-project?rev=328749&view=rev Log: [ast] Do not auto-initialize Objective-C for-loop variables in Objective-C++ in templatized code under ARC The AST for the fragment ``` @interface I @en

r328750 - [astmatchers] Move a matcher out of internal namespace: blind debugging of MSVC issues

2018-03-28 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Mar 28 18:15:05 2018 New Revision: 328750 URL: http://llvm.org/viewvc/llvm-project?rev=328750&view=rev Log: [astmatchers] Move a matcher out of internal namespace: blind debugging of MSVC issues Modified: cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp M

r328752 - [analyzer] [testing] Be less verbose by default in integration testing.

2018-03-28 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Mar 28 18:23:54 2018 New Revision: 328752 URL: http://llvm.org/viewvc/llvm-project?rev=328752&view=rev Log: [analyzer] [testing] Be less verbose by default in integration testing. Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/utils/a

r328754 - [astmatchers] Fix linking issue

2018-03-28 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Mar 28 19:47:28 2018 New Revision: 328754 URL: http://llvm.org/viewvc/llvm-project?rev=328754&view=rev Log: [astmatchers] Fix linking issue Modified: cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Modified: cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.c

r328827 - [analyzer] Path-insensitive checker for writes into an auto-releasing pointer

2018-03-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Mar 29 13:55:34 2018 New Revision: 328827 URL: http://llvm.org/viewvc/llvm-project?rev=328827&view=rev Log: [analyzer] Path-insensitive checker for writes into an auto-releasing pointer from the wrong auto-releasing pool, as such writes may crash. rdar://253011

r328835 - [analyzer] Better pretty-printing of regions in exploded graph

2018-03-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Mar 29 15:07:58 2018 New Revision: 328835 URL: http://llvm.org/viewvc/llvm-project?rev=328835&view=rev Log: [analyzer] Better pretty-printing of regions in exploded graph Differential Revision: https://reviews.llvm.org/D45010 Modified: cfe/trunk/lib/StaticA

r328837 - [analyzer] Fix target triple for autorelease-write-checker test

2018-03-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Mar 29 15:28:04 2018 New Revision: 328837 URL: http://llvm.org/viewvc/llvm-project?rev=328837&view=rev Log: [analyzer] Fix target triple for autorelease-write-checker test Modified: cfe/trunk/test/Analysis/autoreleasewritechecker_test.m Modified: cfe/trunk/

r328912 - [analyzer] Fix assertion crash in CStringChecker

2018-03-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Mar 30 18:20:08 2018 New Revision: 328912 URL: http://llvm.org/viewvc/llvm-project?rev=328912&view=rev Log: [analyzer] Fix assertion crash in CStringChecker An offset might be unknown. rdar://39054939 Differential Revision: https://reviews.llvm.org/D45115 Mod

r328910 - [analyzer] Fix liveness calculation for C++17 structured bindings

2018-03-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Mar 30 18:20:06 2018 New Revision: 328910 URL: http://llvm.org/viewvc/llvm-project?rev=328910&view=rev Log: [analyzer] Fix liveness calculation for C++17 structured bindings C++ structured bindings for non-tuple-types are defined in a peculiar way, where the res

r328911 - [analyzer] Cache offset computation for MemRegion

2018-03-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Mar 30 18:20:07 2018 New Revision: 328911 URL: http://llvm.org/viewvc/llvm-project?rev=328911&view=rev Log: [analyzer] Cache offset computation for MemRegion Achieves almost a 200% speedup on the example where the performance of visitors was problematic. Perfor

r328913 - [analyzer] Hopefully fix the ARM buildbot.

2018-03-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Mar 30 19:17:15 2018 New Revision: 328913 URL: http://llvm.org/viewvc/llvm-project?rev=328913&view=rev Log: [analyzer] Hopefully fix the ARM buildbot. Modified: cfe/trunk/test/Analysis/bstring.c cfe/trunk/test/Analysis/string.c Modified: cfe/trunk/test/

r329444 - [analyzer] Remove an unused variable

2018-04-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Apr 6 12:03:43 2018 New Revision: 329444 URL: http://llvm.org/viewvc/llvm-project?rev=329444&view=rev Log: [analyzer] Remove an unused variable Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp URL: http

r329445 - Revert "[analyzer] Remove an unused variable"

2018-04-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Apr 6 12:14:05 2018 New Revision: 329445 URL: http://llvm.org/viewvc/llvm-project?rev=329445&view=rev Log: Revert "[analyzer] Remove an unused variable" This reverts commit 2fa3e3edc4ed6547cc4ce46a8c79d1891a5b3b36. Removed the wrong variable. Modified: cf

Re: r329445 - Revert "[analyzer] Remove an unused variable"

2018-04-09 Thread George Karpenkov via cfe-commits
On Fri, Apr 6, 2018 at 12:16 PM George Karpenkov via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: george.karpenkov > Date: Fri Apr 6 12:14:05 2018 > New Revision: 329445 > > URL: http://llvm.org/viewvc/llvm-project?rev=329445&view=rev > <ht

r316617 - [Analyzer] Give more descriptive name to BdyFrm field.

2017-10-25 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 25 14:49:41 2017 New Revision: 316617 URL: http://llvm.org/viewvc/llvm-project?rev=316617&view=rev Log: [Analyzer] Give more descriptive name to BdyFrm field. Discussion at: https://reviews.llvm.org/D39220 Modified: cfe/trunk/include/clang/Analysis/Anal

r316618 - [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests

2017-10-25 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 25 14:49:46 2017 New Revision: 316618 URL: http://llvm.org/viewvc/llvm-project?rev=316618&view=rev Log: [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests Contrary to the deleted comment, in most cases CmpRuns.py produce

r316632 - [Analyzer] [Tests] Consistently use exit codes. Use code=42 to signify different results

2017-10-25 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Oct 25 18:13:22 2017 New Revision: 316632 URL: http://llvm.org/viewvc/llvm-project?rev=316632&view=rev Log: [Analyzer] [Tests] Consistently use exit codes. Use code=42 to signify different results Modified: cfe/trunk/utils/analyzer/SATestBuild.py cfe/tr

r316687 - [Analyzer] [Tests] Write analyzers crashes to stdout, and not to a separate file

2017-10-26 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Oct 26 12:00:22 2017 New Revision: 316687 URL: http://llvm.org/viewvc/llvm-project?rev=316687&view=rev Log: [Analyzer] [Tests] Write analyzers crashes to stdout, and not to a separate file With this change it would be sufficient to look at CI console to see the

r316806 - [Analyzer] [Tests] Dump the output of scan-build to stdout on failure.

2017-10-27 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Oct 27 15:39:54 2017 New Revision: 316806 URL: http://llvm.org/viewvc/llvm-project?rev=316806&view=rev Log: [Analyzer] [Tests] Dump the output of scan-build to stdout on failure. Eliminates extra lookup step during debugging. Modified: cfe/trunk/utils/analy

r316808 - [Analyzer] [Tests] Fixing typo from the previous commit.

2017-10-27 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Oct 27 15:52:36 2017 New Revision: 316808 URL: http://llvm.org/viewvc/llvm-project?rev=316808&view=rev Log: [Analyzer] [Tests] Fixing typo from the previous commit. Can not open a non-existent file with r+. Modified: cfe/trunk/utils/analyzer/SATestBuild.py

Re: [PATCH] D39208: [Analyzer] Do not use static storage to for implementations created in BodyFarm.cpp

2017-10-30 Thread George Karpenkov via cfe-commits
> On Oct 30, 2017, at 8:40 AM, David Blaikie wrote: > > > > On Mon, Oct 23, 2017 at 5:01 PM George Karpenkov via Phabricator via > cfe-commits mailto:cfe-commits@lists.llvm.org>> > wrote: > george.karpenkov added a comment. > > @dcoughlin the context I was thinking about is that if everyon

r316948 - [analyzer] [tests] Remove empty folders in reference results, do not store diffs.txt

2017-10-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 30 12:40:33 2017 New Revision: 316948 URL: http://llvm.org/viewvc/llvm-project?rev=316948&view=rev Log: [analyzer] [tests] Remove empty folders in reference results, do not store diffs.txt Storing diffs.txt is now redundant, as we simply dump the CmpRuns ou

r316963 - [analyzer] Use the same filename for the header and the implementation of BugReporterVisitor

2017-10-30 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Oct 30 15:31:57 2017 New Revision: 316963 URL: http://llvm.org/viewvc/llvm-project?rev=316963&view=rev Log: [analyzer] Use the same filename for the header and the implementation of BugReporterVisitor Differential Revision: https://reviews.llvm.org/D37935 Adde

r317065 - [Analyzer] Use value storage for BodyFarm

2017-10-31 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 31 18:36:01 2017 New Revision: 317065 URL: http://llvm.org/viewvc/llvm-project?rev=317065&view=rev Log: [Analyzer] Use value storage for BodyFarm Differential Revision: https://reviews.llvm.org/D39428 Modified: cfe/trunk/include/clang/Analysis/AnalysisD

r317070 - [analyzer] Removing unused stored field.

2017-10-31 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Oct 31 19:29:04 2017 New Revision: 317070 URL: http://llvm.org/viewvc/llvm-project?rev=317070&view=rev Log: [analyzer] Removing unused stored field. Modified: cfe/trunk/include/clang/Analysis/AnalysisDeclContext.h cfe/trunk/lib/Analysis/AnalysisDeclConte

r317293 - [analyzer] do not crash on libcxx03 call_once implementation

2017-11-02 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Nov 2 17:36:03 2017 New Revision: 317293 URL: http://llvm.org/viewvc/llvm-project?rev=317293&view=rev Log: [analyzer] do not crash on libcxx03 call_once implementation Addresses https://bugs.llvm.org/show_bug.cgi?id=35075, rdar://35230961 Differential Revision

r317294 - [analyzer] [NFC] very minor ExprEngineC refactoring

2017-11-02 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Nov 2 17:41:29 2017 New Revision: 317294 URL: http://llvm.org/viewvc/llvm-project?rev=317294&view=rev Log: [analyzer] [NFC] very minor ExprEngineC refactoring Differential Revision: https://reviews.llvm.org/D39577 Modified: cfe/trunk/lib/StaticAnalyzer/Cor

r317537 - [analyzer] [NFC] Remove unused typedef from SVals.h

2017-11-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Nov 6 18:02:10 2017 New Revision: 317537 URL: http://llvm.org/viewvc/llvm-project?rev=317537&view=rev Log: [analyzer] [NFC] Remove unused typedef from SVals.h Differential Revision: https://reviews.llvm.org/D39620 Modified: cfe/trunk/include/clang/StaticAn

r317820 - [analyzer] assume bitwise arithmetic axioms

2017-11-09 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Nov 9 11:06:22 2017 New Revision: 317820 URL: http://llvm.org/viewvc/llvm-project?rev=317820&view=rev Log: [analyzer] assume bitwise arithmetic axioms Patches the solver to assume that bitwise OR of an unsigned value with a constant always produces a value larg

r317839 - [analyzer] do not crash when trying to convert an APSInt to an unexpected type

2017-11-09 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Nov 9 13:49:38 2017 New Revision: 317839 URL: http://llvm.org/viewvc/llvm-project?rev=317839&view=rev Log: [analyzer] do not crash when trying to convert an APSInt to an unexpected type This is the issue breaking the postgresql bot, purely by chance exposed thr

r317849 - [analyzer] [NFC] Minor ExprEngineC refactoring

2017-11-09 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Nov 9 15:33:37 2017 New Revision: 317849 URL: http://llvm.org/viewvc/llvm-project?rev=317849&view=rev Log: [analyzer] [NFC] Minor ExprEngineC refactoring Move a repeated block of code into a function. Differential Revision: https://reviews.llvm.org/D39584 Mod

r306733 - [libFuzzer] Do not link in libFuzzer with -fsanitize=fuzzer when producing a shared object

2017-06-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jun 29 12:52:33 2017 New Revision: 306733 URL: http://llvm.org/viewvc/llvm-project?rev=306733&view=rev Log: [libFuzzer] Do not link in libFuzzer with -fsanitize=fuzzer when producing a shared object https://reviews.llvm.org/D34791 Modified: cfe/trunk/lib/D

r306734 - [libFuzzer] Add Fuzzer to the list of sanitizers which support coverage.

2017-06-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Jun 29 12:58:20 2017 New Revision: 306734 URL: http://llvm.org/viewvc/llvm-project?rev=306734&view=rev Log: [libFuzzer] Add Fuzzer to the list of sanitizers which support coverage. Without this change, additional coverage flags specified after -fsanitize=fuzzer

r322612 - [analyzer] support a mode to only show relevant lines in HTML diagnostics

2018-01-16 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jan 16 18:59:11 2018 New Revision: 322612 URL: http://llvm.org/viewvc/llvm-project?rev=322612&view=rev Log: [analyzer] support a mode to only show relevant lines in HTML diagnostics HTML diagnostics can be an overwhelming blob of pages of code. This patch adds a

r322750 - [analyzer] Better UI in html reports for displaying shortcuts help

2018-01-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Jan 17 12:06:26 2018 New Revision: 322750 URL: http://llvm.org/viewvc/llvm-project?rev=322750&view=rev Log: [analyzer] Better UI in html reports for displaying shortcuts help Make the help window accessible, but don't show by default. Use a different CSS class f

r322752 - [analyzer] Make isSubRegionOf reflexive

2018-01-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Jan 17 12:27:26 2018 New Revision: 322752 URL: http://llvm.org/viewvc/llvm-project?rev=322752&view=rev Log: [analyzer] Make isSubRegionOf reflexive All usages of isSubRegionOf separately check for reflexive case, and in any case, set theory tells us that each se

r322753 - [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently

2018-01-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Jan 17 12:27:29 2018 New Revision: 322753 URL: http://llvm.org/viewvc/llvm-project?rev=322753&view=rev Log: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently In most cases using `N->getState()->getSVal(E, N->

r322809 - [analyzer] a few helper methods for getting and comparing symbolic values

2018-01-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Jan 17 19:18:36 2018 New Revision: 322809 URL: http://llvm.org/viewvc/llvm-project?rev=322809&view=rev Log: [analyzer] a few helper methods for getting and comparing symbolic values API calls should express intent, and that's a motivation behind this patch. Dif

r323244 - [html] [NFC] Use raw strings to dump the style table.

2018-01-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jan 23 11:28:43 2018 New Revision: 323244 URL: http://llvm.org/viewvc/llvm-project?rev=323244&view=rev Log: [html] [NFC] Use raw strings to dump the style table. Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp

r323245 - [analyzer] Show full analyzer invocation for reproducibility in HTML reports

2018-01-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jan 23 11:28:52 2018 New Revision: 323245 URL: http://llvm.org/viewvc/llvm-project?rev=323245&view=rev Log: [analyzer] Show full analyzer invocation for reproducibility in HTML reports Analyzing problems which appear in scan-build results can be very difficult,

r323251 - [analyzer] Mark lines as relevant even if they weren't executed but have a label attached

2018-01-23 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Jan 23 12:01:31 2018 New Revision: 323251 URL: http://llvm.org/viewvc/llvm-project?rev=323251&view=rev Log: [analyzer] Mark lines as relevant even if they weren't executed but have a label attached Differential Revision: https://reviews.llvm.org/D42320 Added:

<    1   2   3   4   5   >