[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 394748. OikawaKirie added a comment. Fix `YAML:1:293: error: Unrecognized escape code` error by replacing lit substitution pattern `%S` to `%/S`. Fix `cp` problems by removing the file copy operations. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. It seems this patch has nothing to do with the failure in the Linux build. I think it is now ready to land. Thanks a lot for your suggestions during the revision. Could you please commit this patch on my behalf? Thanks. Ella Ma CHANGES SINCE LAST ACTION https://

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. I do not know how this error happens. Maybe we can currently revert this patch an have another try in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. Could you please revert this on my behalf? I currently have no idea to fix this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669 _

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. It seems that it is not this patch that triggers the problem, which is similar to D75665 . IMO it is the problem of on-demand-parsing, but I do not have a Mac M1 device to reproduce this bug. Maybe we can

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. In D102669#3199270 , @steakhal wrote: > We shouldn't skip mac targets. I CC ASTImporter folks, they probably have an > M1 . I am not intended to ignore this problem triggered on M1

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. In D102669#3206089 , @steakhal wrote: > Prior to this patch, it worked on M1 ; after > landing it broke something, so we clearly shouldn't land this. I do not think it is this patch that breaks t

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. I have confirmed that this problem is not due to this patch. Besides, on Mac, both m1 and intel, the on-demand-parsing as well as loading an AST file generated via driver argument `-emit-ast` will also trigger this problem. However, when loading an AST file generated

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

OikawaKirie created this revision. OikawaKirie added reviewers: kbobyrev, sammccall, labath. OikawaKirie added a project: clang. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. OikawaKirie requested review of this revision. Herald added

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

OikawaKirie added a comment. @sammccall ping. Updated as you mentioned in D97265#2581653 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97265/new/ https://reviews.llvm.org/D97265 ___ cfe-commits mail

[PATCH] D98918: [clang][lit] Allow test cases to use the compiler that are used to compile Clang

OikawaKirie created this revision. OikawaKirie added reviewers: thakis, steakhal. OikawaKirie added a project: clang. OikawaKirie requested review of this revision. Herald added a subscriber: cfe-commits. Required by D83660 . Test cases may want to use the host co

[PATCH] D98918: [clang][lit] Allow test cases to use the compiler that are used to compile Clang

OikawaKirie added a comment. In D98918#2636735 , @steakhal wrote: > > Oh, wait a minute. The `config.host_cxx` was already there. > Where is the symmetry :D It looks much better now, thanks. Sounds not bad if it matters to you :P > Regarding D83660 <

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie updated this revision to Diff 333708. OikawaKirie added a comment. In D83660#2597025 , @steakhal wrote: > I'm somewhat bothered that this patch is not landed yet. :| > > I made a **crude** mock to trigger the bug using `LD_PRELOAD`. F15707493:

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. In D83660#2661369 , @martong wrote: >> BTW, I was obstructed by the z3 requirement in the regression test case when >> I tried to understand your test case. Even though I set the variables >> LLVM_Z3_INSTALL_DIR and LLVM_ENAB

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

OikawaKirie added a comment. In D92634#2476161 , @danielmarjamaki wrote: >> Besides, the return value should be the exact value computed from the two >> integers, even unknown, rather than undefined. As the developers may >> overflow an integer on purpo

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

OikawaKirie added a comment. In D92634#2477342 , @danielmarjamaki wrote: >> However, the mainstream compilers like GCC and Clang implement this as the >> overflowed value, and some programmers also use this feature to do some >> tricky things. > > hmm..

<    1   2