https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/114042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/114830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/114981
>From 1bf3932e901177518632eeaa05b21a05f3d43880 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Mon, 4 Nov 2024 19:52:37 +
Subject: [PATCH] Nominate Saleem and myself as maintainers for API Notes
---
clan
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/114981
Saleem has upstreamed a large chunk of API Notes infrastructure from the Apple
fork, and over the past year I've upstreamed the remaining part of API Notes,
added new annotations and improved C++ language sup
@@ -132,6 +132,14 @@ Compiler options
| jan_svoboda\@apple.com (email), jansvoboda11 (Phabricator), jansvoboda11
(GitHub)
+API Notes
+
+| Egor Zhdan
+| e_zhdan\@apple.com (email), egorzhdan (GitHub), egor.zhdan (Discourse)
+
+| Saleem Abdulrasool
+| compnerd\
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/114981
>From 1bf3932e901177518632eeaa05b21a05f3d43880 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Mon, 4 Nov 2024 19:52:37 +
Subject: [PATCH 1/2] Nominate Saleem and myself as maintainers for API Notes
---
https://github.com/egorzhdan approved this pull request.
https://github.com/llvm/llvm-project/pull/110768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/115336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/115336
This fixes an issue where overriding
`clang::ConstTemplateArgumentVisitor::VisitTemplateArgument` in an
implementation visitor class did not have the desired effect: the overload was
not invoked when one of
https://github.com/egorzhdan approved this pull request.
This seems totally reasonable.
https://github.com/llvm/llvm-project/pull/115482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -542,6 +542,9 @@ class FunctionInfo : public CommonEntityInfo {
/// The result type of this function, as a C type.
std::string ResultType;
+ /// Swift name of this entity.
+ std::string SwiftReturnOwnership;
egorzhdan wrote:
I think it's fine to repr
@@ -600,6 +603,13 @@ class FunctionInfo : public CommonEntityInfo {
friend bool operator==(const FunctionInfo &, const FunctionInfo &);
+ FunctionInfo &operator|=(const FunctionInfo &RHS) {
egorzhdan wrote:
This function needs to invoke the overload from
https://github.com/egorzhdan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/117194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3,6 +3,12 @@ Name: SwiftImportAs
Tags:
- Name: ImmortalRefType
SwiftImportAs: reference
+ Methods:
+- Name: methodReturningFrt__
+- Name: methodReturningFrt_returns_unretained
+ SwiftReturnOwnership: 'returns_unretained'
+- Name: methodReturningFrt_retur
@@ -3,6 +3,12 @@ Name: SwiftImportAs
Tags:
- Name: ImmortalRefType
SwiftImportAs: reference
+ Methods:
+- Name: methodReturningFrt__
+- Name: methodReturningFrt_returns_unretained
+ SwiftReturnOwnership: 'returns_unretained'
+- Name: methodReturningFrt_retur
@@ -511,6 +511,10 @@ static void ProcessAPINotes(Sema &S, FunctionOrMethod
AnyFunc,
AnyTypeChanged = true;
}
+ // returns_(un)retained
+ if (!Info.SwiftReturnOwnership.empty())
+D->addAttr(SwiftAttrAttr::Create(S.Context, Info.SwiftReturnOwnership));
---
@@ -600,6 +603,15 @@ class FunctionInfo : public CommonEntityInfo {
friend bool operator==(const FunctionInfo &, const FunctionInfo &);
+ FunctionInfo &operator|=(const FunctionInfo &RHS) {
egorzhdan wrote:
Are we using this function somewhere? I can't se
https://github.com/egorzhdan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -36,3 +42,29 @@
// CHECK-ESCAPABLE: Dumping EscapableType:
// CHECK-ESCAPABLE-NEXT: CXXRecordDecl {{.+}} imported in SwiftImportAs {{.+}}
struct EscapableType
// CHECK-ESCAPABLE: SwiftAttrAttr {{.+}} "Escapable"
+
+//CHECK-FUNCTION-RETURNING-FRT: Dumping functionReturningFr
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan commented:
Please remember to increment the APINotes serialization version since the
format is changing in this patch.
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
@@ -24,7 +24,7 @@ const uint16_t VERSION_MAJOR = 0;
/// API notes file minor version number.
///
/// When the format changes IN ANY WAY, this number should be incremented.
-const uint16_t VERSION_MINOR = 33; // SwiftEscapable
+const uint16_t VERSION_MINOR = 34; // SwiftEscapabl
@@ -19493,7 +19493,11 @@ void Sema::ActOnFields(Scope *S, SourceLocation
RecLoc, Decl *EnclosingDecl,
CDecl->setIvarRBraceLoc(RBrac);
}
}
- ProcessAPINotes(Record);
+
+ // If this is a class template instantiation, its API Notes attributes were
+ // added to the
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/122516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/122516
>From 689b28a653eeed50a04a2fbd9286831ddfa1018b Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Fri, 10 Jan 2025 19:41:02 +
Subject: [PATCH] [APINotes] Avoid duplicated attributes for class template
instan
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/122516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan approved this pull request.
I'm not an expert in the area, but this change LGTM.
https://github.com/llvm/llvm-project/pull/126683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
301 - 328 of 328 matches
Mail list logo
