[PATCH] D29812: Update template-id-expr.cpp test to work when compiler defaults to non-C++03 standard

dyung added a comment. ping https://reviews.llvm.org/D29812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29812: Update template-id-expr.cpp test to work when compiler defaults to non-C++03 standard

dyung closed this revision. dyung added a comment. I forgot to add a reference to this in the commit message, so I'm closing this manually. This change was submitted with commit r296066. https://reviews.llvm.org/D29812 ___ cfe-commits mailing list

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

dyung created this revision. dyung added a reviewer: kkwli0. dyung added a subscriber: cfe-commits. This test as originally written fails when run with a compiler that defaults to a different C++ standard. This patch fixes up the test and adds testing it explicitly using c++98 and c++11. The cha

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

This revision was automatically updated to reflect the committed changes. Closed by commit rL289075: Fixing test to work when the compiler defaults to a different C++ standard… (authored by dyung). Changed prior to commit: https://reviews.llvm.org/D27488?vs=80496&id=80776#toc Repository: rL

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. Hi, our internal release build bots are showing failures in two clang-tidy tests that I bisected back to your commit, clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, both are exhi

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. In D120254#3342570 , @svenvh wrote: > In D120254#3342551 , @dyung wrote: > >> Hi, our internal release build bots are showing failures in two clang-tidy >> tests that I bisected back to you

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. If it helps, this is the cmake command I am using to build using gcc on linux: CMake command: -G Ninja -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_VERSION_SUFFIX= -DLLVM_BUILD_RUNTIME=ON -DLLVM_TOOL_LLD_BUILD=OFF "-DLLVM_LIT_ARGS=--verbose -j80 --no-progress-bar --max-tests 10"

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

dyung added a comment. And the PS4 build bots: https://lab.llvm.org/buildbot/#/builders/139/builds/18001 https://lab.llvm.org/buildbot/#/builders/216/builds/801 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D12

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

dyung added a comment. Thanks for fixing the problem with the original commit, but in the future, if you make follow-up commits, can you change the commit message to reflect what the commit contains? Having three different commits with the exact same commit message can be very confusing. Repo

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

dyung added a comment. This change seems to be causing many bots to fail when running the clang :: Preprocessor/init.c test, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/18081 https://lab.llvm.org/buildbot/#/builders/216/builds/881 https://lab.llvm.org/buildbot/#/buil

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

dyung added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + jubnzv wrote: > probinson wrote: > > probinson wrote: > > > TWea

[PATCH] D99556: Add support to -Wa,--version in clang

dyung added a comment. It also fails with the PS4 triple because we default to an external assembler that isn't present: https://lab.llvm.org/buildbot/#/builders/139/builds/2161/steps/6/logs/FAIL__Clang__as-version_s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

dyung added a comment. This appears to be failing on the PS4 linux bot likely due to the PS4 target has exceptions disabled by default. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/2441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/ https://reviews.llvm.org/D94829 ___ cfe

[PATCH] D94829: [NFC] Add -std=c11 to attr-availability.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe68c9222b85: [NFC] Add -std=c11 to attr-availability.c (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94829/new/ https://reviews.llvm.o

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

dyung added a comment. In D106809#2994067 , @saiislam wrote: > In D106809#2993666 , @kwk wrote: > >> @saiislam please have a look into why this happens. Is the >> `-debug-only=CodeObjectCompatibility` maybe a lef

<    1   2   3