Author: David Goldman
Date: 2021-03-01T12:37:31-05:00
New Revision: 5a2141e3a08ccaacbdb8faf64a47347531b015e0
URL:
https://github.com/llvm/llvm-project/commit/5a2141e3a08ccaacbdb8faf64a47347531b015e0
DIFF:
https://github.com/llvm/llvm-project/commit/5a2141e3a08ccaacbdb8faf64a47347531b015e0.diff
Author: David Goldman
Date: 2023-01-09T09:48:29-05:00
New Revision: 814c0bb31660b2441c9a9a6eeaafc2e33c416842
URL:
https://github.com/llvm/llvm-project/commit/814c0bb31660b2441c9a9a6eeaafc2e33c416842
DIFF:
https://github.com/llvm/llvm-project/commit/814c0bb31660b2441c9a9a6eeaafc2e33c416842.diff
Author: David Goldman
Date: 2023-01-09T09:48:30-05:00
New Revision: 042dd99484d6f393cc8a365def250e9d74c24d37
URL:
https://github.com/llvm/llvm-project/commit/042dd99484d6f393cc8a365def250e9d74c24d37
DIFF:
https://github.com/llvm/llvm-project/commit/042dd99484d6f393cc8a365def250e9d74c24d37.diff
Author: David Goldman
Date: 2022-11-16T11:09:06-08:00
New Revision: 2d5c4b8f6e040eef33d4f49820868a81c4c9f1e9
URL:
https://github.com/llvm/llvm-project/commit/2d5c4b8f6e040eef33d4f49820868a81c4c9f1e9
DIFF:
https://github.com/llvm/llvm-project/commit/2d5c4b8f6e040eef33d4f49820868a81c4c9f1e9.diff
Author: David Goldman
Date: 2022-06-15T15:02:37-04:00
New Revision: bc1f24332af3dedccb84a975e57adca495ea016d
URL:
https://github.com/llvm/llvm-project/commit/bc1f24332af3dedccb84a975e57adca495ea016d
DIFF:
https://github.com/llvm/llvm-project/commit/bc1f24332af3dedccb84a975e57adca495ea016d.diff
Author: David Goldman
Date: 2022-05-31T11:14:51-04:00
New Revision: ae67984ca6d89c7ccdbdca258cd05c151d8b6431
URL:
https://github.com/llvm/llvm-project/commit/ae67984ca6d89c7ccdbdca258cd05c151d8b6431
DIFF:
https://github.com/llvm/llvm-project/commit/ae67984ca6d89c7ccdbdca258cd05c151d8b6431.diff
Author: David Goldman
Date: 2022-05-31T11:34:35-04:00
New Revision: c797952d4f012275b2e23f5ffcab1f39eacd184d
URL:
https://github.com/llvm/llvm-project/commit/c797952d4f012275b2e23f5ffcab1f39eacd184d
DIFF:
https://github.com/llvm/llvm-project/commit/c797952d4f012275b2e23f5ffcab1f39eacd184d.diff
Author: David Goldman
Date: 2023-08-09T15:51:02-04:00
New Revision: 9fe632ba18f1398aa9e6fd531a2ed98fd79eba40
URL:
https://github.com/llvm/llvm-project/commit/9fe632ba18f1398aa9e6fd531a2ed98fd79eba40
DIFF:
https://github.com/llvm/llvm-project/commit/9fe632ba18f1398aa9e6fd531a2ed98fd79eba40.diff
Author: David Goldman
Date: 2020-02-19T11:45:58-05:00
New Revision: f50fe5eb6d2ec0adb5b2fd91a4023fc1573e061f
URL:
https://github.com/llvm/llvm-project/commit/f50fe5eb6d2ec0adb5b2fd91a4023fc1573e061f
DIFF:
https://github.com/llvm/llvm-project/commit/f50fe5eb6d2ec0adb5b2fd91a4023fc1573e061f.diff
Author: David Goldman
Date: 2020-02-19T16:58:22-05:00
New Revision: 7d91633a2b9b1f563dc14c632cc0c461c3651f76
URL:
https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76
DIFF:
https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76.diff
Author: David Goldman
Date: 2020-02-19T17:15:11-05:00
New Revision: 4960eb4a1bdd6f469d5ad6d5049609cf97a982f3
URL:
https://github.com/llvm/llvm-project/commit/4960eb4a1bdd6f469d5ad6d5049609cf97a982f3
DIFF:
https://github.com/llvm/llvm-project/commit/4960eb4a1bdd6f469d5ad6d5049609cf97a982f3.diff
Author: David Goldman
Date: 2020-02-10T14:02:02-05:00
New Revision: 6ff0228c6df37e052fa6e8e3927e83b289402cf6
URL:
https://github.com/llvm/llvm-project/commit/6ff0228c6df37e052fa6e8e3927e83b289402cf6
DIFF:
https://github.com/llvm/llvm-project/commit/6ff0228c6df37e052fa6e8e3927e83b289402cf6.diff
Author: David Goldman
Date: 2020-01-27T10:58:20-05:00
New Revision: 60249c2c3b9e268af6ade0a4be3c883d7d567940
URL:
https://github.com/llvm/llvm-project/commit/60249c2c3b9e268af6ade0a4be3c883d7d567940
DIFF:
https://github.com/llvm/llvm-project/commit/60249c2c3b9e268af6ade0a4be3c883d7d567940.diff
Author: David Goldman
Date: 2023-06-26T14:43:37-04:00
New Revision: 1b66840f71030f5d5934e99398a59c3485ba111e
URL:
https://github.com/llvm/llvm-project/commit/1b66840f71030f5d5934e99398a59c3485ba111e
DIFF:
https://github.com/llvm/llvm-project/commit/1b66840f71030f5d5934e99398a59c3485ba111e.diff
Author: David Goldman
Date: 2023-06-27T16:25:40-04:00
New Revision: a42ce094d90341f88a845740b2e5783060f23e3e
URL:
https://github.com/llvm/llvm-project/commit/a42ce094d90341f88a845740b2e5783060f23e3e
DIFF:
https://github.com/llvm/llvm-project/commit/a42ce094d90341f88a845740b2e5783060f23e3e.diff
Author: David Goldman
Date: 2022-12-06T13:47:07-05:00
New Revision: 51f1ae52b0c92a9783e7df328d05b1f95dca74d1
URL:
https://github.com/llvm/llvm-project/commit/51f1ae52b0c92a9783e7df328d05b1f95dca74d1
DIFF:
https://github.com/llvm/llvm-project/commit/51f1ae52b0c92a9783e7df328d05b1f95dca74d1.diff
Author: David Goldman
Date: 2022-12-06T13:47:07-05:00
New Revision: fc46d6e67fab06d54c8948ebf959d62984116bc3
URL:
https://github.com/llvm/llvm-project/commit/fc46d6e67fab06d54c8948ebf959d62984116bc3
DIFF:
https://github.com/llvm/llvm-project/commit/fc46d6e67fab06d54c8948ebf959d62984116bc3.diff
https://github.com/DavidGoldman created
https://github.com/llvm/llvm-project/pull/81775
Add support for renaming Objective-C properties. These are special since a
single property decl could generate 3 different decls - a getter method, a
setter method, and an instance variable. In addition, su
https://github.com/DavidGoldman closed
https://github.com/llvm/llvm-project/pull/76466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/81775
>From 7a3859fc5f5f52fb283fd0b2feda57521ca88240 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Fri, 26 Jan 2024 15:50:11 -0500
Subject: [PATCH] Add support for ObjC property renaming + implicit property
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/81775
>From 7a3859fc5f5f52fb283fd0b2feda57521ca88240 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Fri, 26 Jan 2024 15:50:11 -0500
Subject: [PATCH 1/2] Add support for ObjC property renaming + implicit
prope
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/81775
>From 7a3859fc5f5f52fb283fd0b2feda57521ca88240 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Fri, 26 Jan 2024 15:50:11 -0500
Subject: [PATCH 1/3] Add support for ObjC property renaming + implicit
prope
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/81775
>From 7a3859fc5f5f52fb283fd0b2feda57521ca88240 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Fri, 26 Jan 2024 15:50:11 -0500
Subject: [PATCH 1/4] Add support for ObjC property renaming + implicit
prope
https://github.com/DavidGoldman created
https://github.com/llvm/llvm-project/pull/82396
Use the legacy non-ObjC rename logic when dealing with selectors that have zero
or one arguments. In addition, make sure we don't add an extra `:` during the
rename.
Add a few more tests to verify this wor
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/82396
>From 8a9c09575ed143e762faa7abf48285ed6b4b0335 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Tue, 20 Feb 2024 13:14:26 -0500
Subject: [PATCH 1/2] [clangd] Fix renaming single argument ObjC methods
Add
@@ -811,8 +811,14 @@ renameWithinFile(ParsedAST &AST, const NamedDecl
&RenameDecl,
continue;
Locs.push_back(RenameLoc);
}
- if (const auto *MD = dyn_cast(&RenameDecl))
-return renameObjCMethodWithinFile(AST, MD, NewName, std::move(Locs));
+ if (const auto *MD
https://github.com/DavidGoldman approved this pull request.
https://github.com/llvm/llvm-project/pull/88446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Goldman
Date: 2022-02-18T15:24:00-05:00
New Revision: 805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1
URL:
https://github.com/llvm/llvm-project/commit/805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1
DIFF:
https://github.com/llvm/llvm-project/commit/805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1.diff
Author: David Goldman
Date: 2022-02-18T15:24:00-05:00
New Revision: 54a962bbfee86d5af90d5fdd39b4ff4ec8030f12
URL:
https://github.com/llvm/llvm-project/commit/54a962bbfee86d5af90d5fdd39b4ff4ec8030f12
DIFF:
https://github.com/llvm/llvm-project/commit/54a962bbfee86d5af90d5fdd39b4ff4ec8030f12.diff
Author: David Goldman
Date: 2021-04-27T10:07:41-04:00
New Revision: 53e1cb88f28052fa849f28ff164d61e06a3dcfd2
URL:
https://github.com/llvm/llvm-project/commit/53e1cb88f28052fa849f28ff164d61e06a3dcfd2
DIFF:
https://github.com/llvm/llvm-project/commit/53e1cb88f28052fa849f28ff164d61e06a3dcfd2.diff
Author: David Goldman
Date: 2021-04-27T10:20:35-04:00
New Revision: c20e4fbfa6d154616c2dd41e828a02facd000d71
URL:
https://github.com/llvm/llvm-project/commit/c20e4fbfa6d154616c2dd41e828a02facd000d71
DIFF:
https://github.com/llvm/llvm-project/commit/c20e4fbfa6d154616c2dd41e828a02facd000d71.diff
Author: David Goldman
Date: 2021-04-28T10:06:27-04:00
New Revision: 39866d249a21fc3c05942a1a4fbbd88acc4660bc
URL:
https://github.com/llvm/llvm-project/commit/39866d249a21fc3c05942a1a4fbbd88acc4660bc
DIFF:
https://github.com/llvm/llvm-project/commit/39866d249a21fc3c05942a1a4fbbd88acc4660bc.diff
Author: David Goldman
Date: 2021-05-06T11:41:49-04:00
New Revision: 159dd447fe98f558879343d660b5bfe90779609f
URL:
https://github.com/llvm/llvm-project/commit/159dd447fe98f558879343d660b5bfe90779609f
DIFF:
https://github.com/llvm/llvm-project/commit/159dd447fe98f558879343d660b5bfe90779609f.diff
Author: David Goldman
Date: 2022-01-04T15:57:58-05:00
New Revision: dd72ae3dcc6895f95e1203b40aabcb069c76a0ab
URL:
https://github.com/llvm/llvm-project/commit/dd72ae3dcc6895f95e1203b40aabcb069c76a0ab
DIFF:
https://github.com/llvm/llvm-project/commit/dd72ae3dcc6895f95e1203b40aabcb069c76a0ab.diff
Author: David Goldman
Date: 2022-01-06T10:55:02-05:00
New Revision: f558acf49201a843df3f0d3dd7e77bb5ea91568c
URL:
https://github.com/llvm/llvm-project/commit/f558acf49201a843df3f0d3dd7e77bb5ea91568c
DIFF:
https://github.com/llvm/llvm-project/commit/f558acf49201a843df3f0d3dd7e77bb5ea91568c.diff
Author: David Goldman
Date: 2022-01-10T12:25:53-05:00
New Revision: 0cf7e61a42c7a08b0332204f1b60aa9fd1562089
URL:
https://github.com/llvm/llvm-project/commit/0cf7e61a42c7a08b0332204f1b60aa9fd1562089
DIFF:
https://github.com/llvm/llvm-project/commit/0cf7e61a42c7a08b0332204f1b60aa9fd1562089.diff
Author: David Goldman
Date: 2021-09-03T11:38:27-04:00
New Revision: 2982bd9e9b58ea17bc047ffb9b28df6f92531287
URL:
https://github.com/llvm/llvm-project/commit/2982bd9e9b58ea17bc047ffb9b28df6f92531287
DIFF:
https://github.com/llvm/llvm-project/commit/2982bd9e9b58ea17bc047ffb9b28df6f92531287.diff
Author: David Goldman
Date: 2021-09-14T09:53:42-04:00
New Revision: 8401713b3ef1456a603874d96a99b2d5953df49c
URL:
https://github.com/llvm/llvm-project/commit/8401713b3ef1456a603874d96a99b2d5953df49c
DIFF:
https://github.com/llvm/llvm-project/commit/8401713b3ef1456a603874d96a99b2d5953df49c.diff
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/127109
>From d335931b8923005d2ffc580c5195b7fa997f3649 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Thu, 13 Feb 2025 13:51:05 -0500
Subject: [PATCH 1/3] [clangd] Update XRefs to support overriden ObjC methods
https://github.com/DavidGoldman requested changes to this pull request.
Thanks for the fix! Looks good besides some minor nits.
https://github.com/llvm/llvm-project/pull/82061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/DavidGoldman edited
https://github.com/llvm/llvm-project/pull/82061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -35,6 +35,56 @@ struct RenameOptions {
bool RenameVirtual = true;
};
+/// A name of a symbol that should be renamed.
+///
+/// Symbol's name can be composed of multiple strings. For example, Objective-C
+/// methods can contain multiple argument labels:
+///
+/// \code
+/
@@ -605,12 +607,12 @@ findAllSelectorPieces(llvm::ArrayRef
Tokens,
auto PieceCount = SelectorPieces.size();
if (PieceCount < NumArgs &&
isMatchingSelectorName(Tok, Tokens[Index + 1], SM,
- Sel.getNameForSlot(PieceCount))) {
https://github.com/DavidGoldman closed
https://github.com/llvm/llvm-project/pull/82061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/127109
>From d335931b8923005d2ffc580c5195b7fa997f3649 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Thu, 13 Feb 2025 13:51:05 -0500
Subject: [PATCH 1/5] [clangd] Update XRefs to support overriden ObjC methods
DavidGoldman wrote:
> i am not sure if it does, e.g.
> https://github.com/llvm/llvm-project/blob/main/clang/lib/AST/DeclObjC.cpp#L1268-L1273
> stops at the first overridden method.
>
> maybe you can add some unittests for this as well ?
Done, you're right, so fixed that as well.
> i think us
@@ -430,6 +439,22 @@ locateASTReferent(SourceLocation CurLoc, const
syntax::Token *TouchedIdentifier,
continue;
}
}
+// Special case: - (void)^method; should jump to all overrides. Note that
an
+// Objective-C method can override a parent class or pr
@@ -430,6 +439,27 @@ locateASTReferent(SourceLocation CurLoc, const
syntax::Token *TouchedIdentifier,
continue;
}
}
+// Special case: - (void)^method {} should jump to overrides, but the decl
+// shouldn't, only the definition. Note that an Objective-
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/127109
>From d335931b8923005d2ffc580c5195b7fa997f3649 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Thu, 13 Feb 2025 13:51:05 -0500
Subject: [PATCH 1/7] [clangd] Update XRefs to support overriden ObjC methods
https://github.com/DavidGoldman closed
https://github.com/llvm/llvm-project/pull/127109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/127109
>From d335931b8923005d2ffc580c5195b7fa997f3649 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Thu, 13 Feb 2025 13:51:05 -0500
Subject: [PATCH 1/2] [clangd] Update XRefs to support overriden ObjC methods
https://github.com/DavidGoldman created
https://github.com/llvm/llvm-project/pull/127109
- Support finding implementors of a protocol and discovering subclasses for
ObjC interfaces via the implementations call
- Add tests
>From d335931b8923005d2ffc580c5195b7fa997f3649 Mon Sep 17 00:00:00 2001
@@ -1438,6 +1461,15 @@ ReferencesResult findReferences(ParsedAST &AST, Position
Pos, uint32_t Limit,
getOverriddenMethods(CMD, OverriddenMethods);
}
}
+// Special case: Objective-C methods can override a parent class or
+// protoco
@@ -1283,6 +1295,17 @@ std::vector findImplementations(ParsedAST
&AST, Position Pos,
} else if (const auto *RD = dyn_cast(ND)) {
IDs.insert(getSymbolID(RD));
QueryKind = RelationKind::BaseOf;
+} else if (const auto *OMD = dyn_cast(ND)) {
+ IDs.insert(g
@@ -430,6 +430,18 @@ locateASTReferent(SourceLocation CurLoc, const
syntax::Token *TouchedIdentifier,
continue;
}
}
+// Special case: an Objective-C method can override a parent class or
+// protocol.
DavidGoldman wrote:
I was thinki
https://github.com/DavidGoldman updated
https://github.com/llvm/llvm-project/pull/127109
>From d335931b8923005d2ffc580c5195b7fa997f3649 Mon Sep 17 00:00:00 2001
From: David Goldman
Date: Thu, 13 Feb 2025 13:51:05 -0500
Subject: [PATCH 1/4] [clangd] Update XRefs to support overriden ObjC methods
DavidGoldman wrote:
> can you also add some tests to `SymbolCollectorTests.cpp` to make sure we
> capture `overriddenby` relationships relevant to your use cases?
>
> index tests in `XRefsTests.cpp` uses rather dynamic-index hence can have
> different characteristics then you'd get for the sta
101 - 157 of 157 matches
Mail list logo