[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

delcypher marked an inline comment as done. delcypher added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:408 default: return getOS(); } arphaman wrote: > It might be cleaner to do a check for `isOSDarwin` here, as that will help > with

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1971823ecb9e: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on… (authored by delcypher). Repository: rG LLVM Github Mon

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher created this revision. delcypher added reviewers: arphaman, rapidsna, fcloutier, NoQ. delcypher requested review of this revision. Herald added a project: clang. The warning is currently disabled by default but can be enabled with `-Wstrict-calls-without-prototype`. Enabling it by defaul

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher updated this revision to Diff 397431. delcypher added a comment. Add another test case for function definitions without prototypes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116635/new/ https://reviews.llvm.org/D116635 Files: clang

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + @NoQ Any ideas about this? It seems kind of weird that when merging `not_a_prototype3` prototype with the K&R style definition of `not_a_pro

[PATCH] D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default

delcypher created this revision. delcypher added reviewers: arphaman, rapidsna, fcloutier, NoQ. delcypher requested review of this revision. Herald added a project: clang. This patch enables the `-Wstrict-calls-without-prototype` warning by default and fixes the existing clang test suite to pass.

[PATCH] D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default

delcypher added a comment. This change depends on https://reviews.llvm.org/D116635. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116636/new/ https://reviews.llvm.org/D116636 ___ cfe-commits mailing list

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added a comment. Patch https://reviews.llvm.org/D116636 demonstrates the changes needed if the warning was enabled by default: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116635/new/ https://reviews.llvm.org/D116635 __

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + delcypher wrote: > @NoQ Any ideas about this? It seems kind of weird that when merging > `not_a_prototype3` prototype with the K&R style defi

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5530 + "calling function %0 with arguments when function has no prototype">, InGroup< + DiagGroup<"strict-calls-without-prototype">>, DefaultIgnore; def warn_missing_variable_declara

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + delcypher wrote: > delcypher wrote: > > @NoQ Any ideas about this? It seems kind of weird that when merging > > `not_a_prototype3` prototype

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + NoQ wrote: > delcypher wrote: > > delcypher wrote: > > > delcypher wrote: > > > > @NoQ Any ideas about this? It seems kind of weird that when

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no prototype">, InGroup< + DiagGroup<"strict-calls-without-prototype"

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no prototype">, InGroup< + DiagGroup<"strict-calls-without-prototype"

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + aaron.ballman wrote: > delcypher wrote: > > NoQ wrote: > > > delcypher wrote: > > > > delcypher wrote: > > > > > delcypher wrote: > > > > > > @

[PATCH] D100086: Include `llvm-config` and `not` in AppleClang toolchains.

delcypher created this revision. delcypher added reviewers: JDevlieghere, arphaman. Herald added a subscriber: mgorny. delcypher requested review of this revision. Herald added a project: clang. The motivation here is so that we can configure and run compiler-rt tests from a standalone build again

[PATCH] D100086: Include `llvm-config` and `not` in AppleClang toolchains.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73cbc7f60ed9: Include `llvm-config` and `not` in AppleClang toolchains. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D100087: Include `count` in AppleClang toolchains.

delcypher created this revision. delcypher added reviewers: arphaman, JDevlieghere. Herald added a subscriber: mgorny. delcypher requested review of this revision. Herald added a project: clang. The motivation here is so we can run the compiler-rt tests from a standalone build against AppleClang.

[PATCH] D100087: Include `count` in AppleClang toolchains.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf66e05a720f7: Include `count` in AppleClang toolchains. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100087/new/ https://reviews.l

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

delcypher created this revision. delcypher added reviewers: steven_wu, arphaman, dexonsmith. Herald added subscribers: yaxunl, mgorny. delcypher requested review of this revision. Herald added a project: clang. Originally done for rdar://problem/57155465. rdar://76602859 Repository: rG LLVM G

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c0bc69490a5: Ship `llvm-cxxfilt` in the toolchain. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

<    1   2