https://github.com/carlosgalvezp approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/147142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/carlosgalvezp approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/148549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlosgalvezp wrote:
Check makes sense to me! As a first iteration it's fine without autofix but I
can imagine it will be hard for a codebase to enable this check given the large
amount of things to fix. Maybe users can specify a mapping of wanted types via
an option?
https://github.com/llvm/
carlosgalvezp wrote:
misc-use-constexpr? :)
https://github.com/llvm/llvm-project/pull/146553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlosgalvezp wrote:
I'm ok with modernize-use-constexpr as well!
https://github.com/llvm/llvm-project/pull/146553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -87,3 +87,25 @@ void okay() {
for(int ii : a) ; // OK, pointer arithmetic generated by compiler
}
+
+namespace issue126424 {
carlosgalvezp wrote:
Nit: typically we can it "gh126424".
https://github.com/llvm/llvm-project/pull/127394
___
https://github.com/carlosgalvezp edited
https://github.com/llvm/llvm-project/pull/127394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlosgalvezp wrote:
I agree that a new module seems unnecessary, do we know that it will contain
more checks in the future? If not moving to llvm or plugins would perhaps be
more suitable.
https://github.com/llvm/llvm-project/pull/149148
___
cfe-com
https://github.com/carlosgalvezp approved this pull request.
LGTM, but please rebase onto latest trunk and address/resolve pending comments.
https://github.com/llvm/llvm-project/pull/144213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/carlosgalvezp approved this pull request.
LGTM!
Not sure if possible but a less aggressive option would be to have a "-l" flag
like "make" has, which uses as many threads as requested while keeping track on
the load of the system and adjusting accordingly.
https://github.co
601 - 610 of 610 matches
Mail list logo