[PATCH] D147673: [Clang] Improve designated inits diagnostic location

void marked an inline comment as done. void added inline comments. Comment at: clang/test/SemaCXX/cxx2b-designated-initializers.cpp:13 + const S result { // expected-error {{field designator (null) does not refer to any field in type 'const S'}} +.a = x + }; --

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cbf5127d585: [Clang] Improve designated inits diagnostic location (authored by void). Changed prior to commit: https://reviews.llvm.org/D147673?v

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

void added a comment. In D147580#4250232 , @shafik wrote: > I guess I should have waited till I saw: https://reviews.llvm.org/D147673 Yeah, sorry about that. I realized that I still needed to add the testcase before continuing. :-) Repository: rG LL

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 511772. void added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Fix compilation issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.o

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void created this revision. void added reviewers: kees, nickdesaulniers. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a reviewer: aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a su

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added a comment. Note: This is a work-in-progress, so there's no need for a formal review, though any suggestions will definitely be appreciated. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 524541. void added a comment. Herald added a subscriber: ormris. Add bounds checking for the "ArrayBounds" saniziter kind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void added a comment. In D143300#4108500 , @haowei wrote: > FYI, this patch looks like was pushed into a new "Main" branch instead of the > actual "main" branch.: > > commit f85a9a6452e8f49f9768d66a86434a88a5891614 (origin/Main) > Author: Bill Wendli

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3c07db5f58e9: [Clang] Refactor "Designators" into a unified implementation [NFC] (authored by void). Repository: rG LLV

[PATCH] D144136: Add a "remark" to report on array accesses

void created this revision. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This will report a ton of information. It's basically only good for piping to a file and using Perl to gather any useful informati

[PATCH] D144136: Add a "remark" to report on array accesses

void added a comment. In D144136#4131825 , @aaron.ballman wrote: > I'd like to understand what the overhead is for this. How much overhead does > this add when the remark is disabled? How much overhead does this add when > the remark is enabled? > >> T

[PATCH] D144136: Add a "remark" to report on array accesses

void added a comment. In D144136#4137143 , @kees wrote: > Here's a test-case. I'd expect 6 remarks from building this: > > /* Build with -Wall -O2 -fstrict-flex-arrays=3 -fsanitize=bounds > -Rarray-bounds */ > #include > #include > #include >

[PATCH] D144136: Add a "remark" to report on array accesses

void updated this revision to Diff 499321. void added a comment. Report when there's a non-constant access: array_access_report.c:32:17: remark: accessing fixed sized array 'int[16]' by 'index' [-Rarray-bounds] report_size(p->array, index); ^ Repository: rG LLVM Github Monor

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 519605. void marked an inline comment as done. void added a comment. Use "Expected" for the SourceRange imports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files:

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 521406. void added a comment. Use strings for the attribute argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td clang/

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 514395. void added a comment. Reformat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/XRefs

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added a comment. In D148381#4274857 , @nickdesaulniers wrote: > Cool! > > How about some codegen tests? I'll add those to the next iteration. :-) > This looks a lot like the EuroLLVM keynote: > https://llvm.swoogo.com/2023eurollvm/agenda (Thursda

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:951-952 +if (auto *ME = dyn_cast(CE->getSubExpr())) { + if (ME->isFlexibleArrayMemberLike(CGF.getContext(), +StrictFlexArraysLevel, true)) { +if (auto *MD

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 514451. void added a comment. Herald added a subscriber: jdoerfert. Fix failing testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Ba

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 514730. void marked an inline comment as done. void added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 Files: clang-tools-extra/clangd/FindT

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb51a03e1bbe7: [Clang][NFC] Rename methods/vars to reflect their real usage (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 517700. void added a comment. Add the ability to specify a "path" to the element count if it resides within a sub-structure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 517704. void added a comment. Fix ICE when the FD isn't found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td clang/include

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added a comment. This is a precursor to specifying the field with the designated initializer syntax. Therefore, it may be a bit cumbersome. The code in `CGExpr.cpp` is decidedly gross. I would appreciate any advice on how to de-grossify it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 517734. void added a comment. Use the new memory location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void marked an inline comment as done. void added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4170 +private: + mutable SmallVector CountFieldRanges; +public: nickdesaulniers wrote: > `mutable`...my least favorite keyword in C++. I

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518013. void marked an inline comment as done. void added a comment. Fix the way the source ranges are imported via the ASTImporter. Do other minor fixes according to feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518106. void added a comment. Change sanitizer scope because instructions may be created. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Ba

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518546. void added a comment. Improve error message to use the unknown field's name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/A

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 403815. void added a comment. WIP: Updated to make selecing registers to zero out more generic. Combined a few tests into one, and made the logic emitting the "xors" a bit nicer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 403906. void added a comment. WIP: Modify the zeroing of GPRs to be less gross. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.t

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404236. void added a comment. Move the zeroing of registers to before the pop instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. Hey, y'all! I've finished the initial part of this feature. I compiled a Linux kernel with it, and it booted via qemu. Please give it a go and let me know what you think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404326. void added a comment. Don't zero out all sub and super registers that are callee-saved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/cl

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404336. void added a comment. Make this only for x86. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404754. void added a comment. Generate the "isGeneralPurposeRegister" and "isFixedRegister" predicates from the .td file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void marked 2 inline comments as done. void added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1182 + + if (!F.hasFnAttribute("zero-call-used-regs") || + // No need to zero call regs in main(). craig.topper wrote: > Should the fron

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404761. void added a comment. Remove "zero-call-used-regs" attribute in front-end if it's "main". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404763. void added a comment. Remove attribute from "main" function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/i

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void marked 3 inline comments as done. void added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:232-240 + /// Returns true if a register can be used as an argument to a function. + bool isArgumentRegister(const MachineFunction &MF, MCRegister Reg)

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405117. void added a comment. - Don't use "llvm::for_each" or "auto" as much. - Don't zero out registers that are restored before exit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llv

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405119. void marked 5 inline comments as done. void added a comment. Remove debugging instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1269 + const TargetFrameLowering &TFI = *MF.getSubtarget().getFrameLowering(); + for (auto RestoreBlock : RestoreBlocks) +TFI.emitZeroCallUsedRegs(RegsToZero, *RestoreBlock);

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3288485 , @nickdesaulniers wrote: > Hey! Looks like Diff 404763 for an x86 defconfig plus > CONFIG_ZERO_CALL_USED_REGS=y starts booting! Looks like it panics though > trying to launch `init`(pid 1) though. > > [0.

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405137. void added a comment. Remove dead assign. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3289073 , @nickdesaulniers wrote: > Diff 405119 still kernel panics for me. This is building the linux-next tree. > > $ qemu-system-x86_64 --version > QEMU emulator version 6.2.0 (Debian 1:6.2+dfsg-1) Okay. I can rep

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void created this revision. Herald added subscribers: dang, jdoerfert, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Build the unit tests with (in the build

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void updated this revision to Diff 413260. void added a comment. Update with coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST

[PATCH] D121063: [AST] Make the last element in the linked list null

void created this revision. void added reviewers: erichkeane, aaron.ballman, urnathan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last element in a linked list should point to null, so that we can

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void updated this revision to Diff 413343. void added a comment. Fix assert from use of null pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files: clang/include/clang/AST/Decl.h clang/includ

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void updated this revision to Diff 413383. void added a comment. Don't warn on multiple attributes. Instead, use the last one to indicate whether to randomize the layout or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://rev

[PATCH] D121063: [AST] Make the last element in the linked list null

void added a subscriber: urnathan. void added a comment. In D121063#3363852 , @erichkeane wrote: > I suspect this works because we never really treated this as a LL, just as a > pair of iterators. Two things: > > 1- Can you produce some situation where

[PATCH] D121063: [AST] Make the last element in the linked list null

void added a comment. In D121063#3364780 , @void wrote: > In D121063#3363852 , @erichkeane > wrote: > >> I suspect this works because we never really treated this as a LL, just as a >> pair of iterators. Two th

[PATCH] D121063: [AST] Make the last element in the linked list null

void added a comment. In D121063#3364815 , @erichkeane wrote: > In D121063#3364810 , @void wrote: > >> In D121063#3364780 , @void wrote: >> >>> In D121063#3363852

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void updated this revision to Diff 413662. void added a comment. Don't call little-used function in DeclContext to re-link the record decls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files: clang/

[PATCH] D121063: [AST] Make the last element in the linked list null

void abandoned this revision. void added a comment. In D121063#3364872 , @erichkeane wrote: > In D121063#3364833 , @void wrote: > >> In D121063#3364815 , @erichkeane >>

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void added a comment. Friendly ping to reviewers. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ https://reviews.llvm.org/D114848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820 +// semantic analysis passes. +while (isa(Ex)) + Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr()); + nickdesaulniers wrote: > Q: are there any unary operators th

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void updated this revision to Diff 392281. void added a comment. Simplify the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ https://reviews.llvm.org/D114848 Files: clang/lib/Analysis/UninitializedValues.cpp clang/test/Analysi

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4582a689c2c: [Analysis] Ignore casts and unary ops for uninitialized values (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ h

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

void accepted this revision. void added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/LanguageExtensions.rst:1474 +When using tied-outputs (ie. outputs that are inputs and outputs, not just +outputs) with the `+r` constraint, there is

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] = MayUninitialized; -

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

void accepted this revision. void added a comment. This revision is now accepted and ready to land. Approved with one change. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3034616 , @nickdesaulniers wrote: > We'll probably need to investigate code gen a little. > > A mainline linux kernel defconfig built with `CONFIG_ZERO_CALL_USED_REGS=y` > enabled doesn't boot, for example. I consider t

<    1   2   3   4   5   6