[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

2020-12-30 Thread Atmn Patel via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6f1503d59854: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel, committed by adpatel6). Changed prior to commit: https://reviews.llvm.org/D86844?vs=31359

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-30 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel created this revision. atmnpatel added a reviewer: MaskRay. Herald added a subscriber: pengfei. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-with-thin-lto-ubuntu, clang-with-lto-ubuntu, clang-x86_64-debian-new-

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-30 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel added a comment. I can't say that I know with any certainty, I'm too inexperienced. This failure was missed by me locally, the pre-merge bot, and by most of the buildbots other than the ones I mentioned above. I have no idea under what configuration of CMake options will clang not emi

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 314193. atmnpatel added a comment. Ah I see, I was never able to find clear documentation on what exactly the -cc1 flag does other than the conceptual description. This should fix it right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

2020-12-31 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel added a comment. In D86844#2475552 , @xbolva00 wrote: > Do you plan to implement gcc’s option in Clang as followup? I was not planning on it but I can if no one is planning on it and doesn't mind waiting a bit. Also, clang/test/Misc/loop-opt-s

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 314195. atmnpatel added a comment. Better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952 Files: clang/test/Misc/loop-opt-setup.c Index: clang/test/Misc/loop-opt

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Atmn Patel via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a65b8c739a0: [Clang][Misc] Change run line in fragile test (authored by adpatel6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

2021-01-07 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel added a comment. In D86844#2484568 , @fhahn wrote: > In D86844#2481922 , @xbolva00 wrote: > >> int a, b; >> >> int f(void) { >> while (1) { >> if (a != b) return 1; >> } >>

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

2021-01-07 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel added a comment. I'm happy to add a patch amending this, the reason it wasn't done that way was because at the time and even now, out of icc/clang/msvc/gcc, gcc seems to be the only one that happily removed such loops in C++ (https://godbolt.org/z/W9vj99), and I didn't have a particul

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

2021-01-08 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel accepted this revision. atmnpatel added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94327/new/ https://reviews.llvm.org/D94327 __

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

2021-01-09 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel created this revision. atmnpatel added reviewers: fhahn, jdoerfert, xbolva00. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang does not emit the `mustprogress` loop or function attribute for loops with no

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

2021-01-09 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 315639. atmnpatel added a comment. `while(1)` case was mishandled for C++11 onwards, fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94366/new/ https://reviews.llvm.org/D94366 Files: clang/lib/Cod

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

2021-01-09 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel created this revision. atmnpatel added reviewers: fhahn, jdoerfert, xbolva00. Herald added subscribers: dexonsmith, dang. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following D94366

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

2021-01-09 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 315641. atmnpatel added a comment. Update CommandLineReference.rst to also include `-fno-finite-loops` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 Files: clang/

<    1   2