[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2021-01-07 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cdb6c56edf: [flang][driver] Add support for `-c` and `-emit-obj` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D93

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-07 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In D94169#2484968 , @andreil99 wrote: > I'm fine with having this text in the ClangCommandLineReference.rst only, and > removing it from `clang -help`. > > However, reverting the patch would not do, as ClangCommandLineReference

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-08 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Thank you all for your input. Let me summarize. **SUGGESTION 1** Tweak the wording to clarify that it is Clang-specific. That's a good compromise IMO. It highlights that the described semantics apply to Clang only. And I'm not aware of any other way to achieve this r

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-11 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski updated this revision to Diff 315765. awarzynski added a comment. Implement SUGGESTION 1 I haven't updated the patch description yet - I'd rather keep it as is while the actual direction for this patch is being discussed. Also, I regenerated ClangCommandLineReference.rst and discover

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-12 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski updated this revision to Diff 316074. awarzynski added a comment. Use `DocBrief`, as suggested by @richard.barton.arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94169/new/ https://reviews.llvm.org/D94169 Files: clang/docs/ClangCom

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the installed CMake modules

2021-01-12 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski created this revision. Herald added subscribers: rriddle, mgorny. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, stephenneuendorffer. Herald added a project: clang. This makes sure that AddClang.cmake is installed alongside other Clang CMake modules

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-12 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Thank you for the reviewing @andreil99 ! Comment at: clang/include/clang/Driver/Options.td:652 Flags<[CC1Option,CC1AsOption]>, MetaVarName<"">, -HelpText<"Add directory to include search path. If there are multiple -I " - "option

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-13 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcbea6737d513: [clang][driver] Restore the original help text for `-I` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D94169?vs=316074&id=316342#toc Repository: rG LLVM Gi

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-13 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. I have now merged this into `main`. I updated the commit message based on the discussion here, but kept the original **SUMMARY** above (just in case people are confused by the inconsistency). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D93453: [flang][driver] Add support for `-I`

2021-01-18 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you @FarisRehman , LGTM! I believe that you addressed all PR comments. As requested, there are tests for: - `#include` - `INCLUDE` - `USE` Your tests also demonstrate that the o

[PATCH] D93453: [flang][driver] Add support for `-I`

2021-01-19 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87dfd5e012e1: [flang][driver] Add support for `-I` in the new driver (authored by FarisRehman, committed by awarzynski). Changed prior to commit:

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the CMake modules that are installed

2021-01-20 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Ping. Would anyone be able to take a look? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94533/new/ https://reviews.llvm.org/D94533 ___ cfe-commits mailing list cf

<    2   3   4   5   6   7