[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 409401. awarzynski added a comment. Rebase on top of `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td flang/

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. A believe that all of Kiran's comments have been addressed and pre-merge CI is also passing now (that was one of the concerns). Kiran has not accepted this yet, but he will be away for a few weeks. I will merge this as is to unblock further work. I more than happy to

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe993b20c049d: [flang][driver] Add support for `-emit-llvm` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://revie

[PATCH] D122008: [flang][driver] Add support for generating executables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97a32d3e43fe: [flang][driver] Add support for generating executables (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, Leporacanthicus, unterumarmung, ekieri. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subsc

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, Leporacanthicus, unterumarmung, ekieri, schweitz, jeanPerier, peixin, shraiysh. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3989 Group; -def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, NoXarchOption]>, +def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option,FlangOp

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski marked 8 inline comments as done. awarzynski added a comment. Thanks for the review @rovka! Comment at: flang/lib/Frontend/FrontendActions.cpp:86 + + // ... otherwise, generate an MLIR module from the input Fortran source bool res = RunPrescan() && RunParse() &&

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski updated this revision to Diff 426678. awarzynski marked 2 inline comments as done. awarzynski added a comment. Add an assert, make some editorial changes in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124667/new/ https://revie

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 426739. awarzynski added a comment. Add a test, restore white-space in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files: clang/include/clang/Driv

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 426747. awarzynski added a comment. Fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski updated this revision to Diff 427032. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124667/new/ https://reviews.llvm.org/D124667 Files: clang/include/clang/Driver/Types.h clang/lib/D

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427036. awarzynski added a comment. Fix typos as per comments from @rovka, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files: clang/include/clang/Dri

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski marked 4 inline comments as done. awarzynski added inline comments. Comment at: flang/test/Driver/fno-integrated-as.f90:18 +! DEFAULT-LABEL: "-fc1" +! DEFAULT-SAME: "-o" "fno-integrated-as.o" "{{.*}}fno-integrated-as.f90" rovka wrote: > Nit (here and a

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f3b7f89a4c: [flang][driver] Add support for consuming LLVM IR/BC files (authored by awarzynski). Changed prior to commit: https://reviews.llvm.o

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427333. awarzynski marked an inline comment as done. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files: cla

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427367. awarzynski added a comment. Mark the tests as unsupported on Windows Pre-merge testing is failing on Windows. Here is the error message: flang-new: error: there is no external assembler that can be used on this platform I will update the commi

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski added a comment. Pre-merge CI is 🍏 . If there are no new comments, I'd like to merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669

[PATCH] D124669: [flang][driver] Add support for -save-temps

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65afce731c2: [flang][driver] Add support for -save-temps (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D124669?vs=427367&id=427561#toc Repository: rG LLVM Github Monore

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski added a comment. Makes sense, thanks for working on this! Some minor comments below and inline. From your summary: > This is done by using clang tablegen What do you mean by "clang tablegen"? Is it Clang's clang_tablegen

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski created this revision. awarzynski added a reviewer: tarunprabhu. Herald added a reviewer: sscalpone. Herald added a project: All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The updated name better reflects

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. The change in ClangOptionDocEmitter.cpp is required for Flang as it heavily relies on these "include" flags defined in Options.td

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski added a comment. In D130078#3667188 , @MaskRay wrote: > `forwardOptions` will be better if you are renaming it anyway. I'd rather create a separate patch and update all other methods to follow LLVM's style. Any idea why the style is not follo

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

awarzynski added a comment. What about similar code in LLVM ? Comment at: clang/cmake/modules/CMakeLists.txt:35 # via CMAKE_MODULE_PATH, place API m

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski added a comment. LGTM, thanks! (feel free to address my [nit] when merging or ignore altogether) Comment at: flang/docs/CMakeLists.txt:128 + set(CLANG_TABLEGEN_EXE clang-tblgen) + gen_rst_file_from_td(FlangCommandLineReference.rst -gen-opt-docs ../incl

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski added a comment. In D130078#3673288 , @MaskRay wrote: > In D130078#3669072 , @awarzynski > wrote: > >> In D130078#3667188 , @MaskRay >> wrote: >> >>> `forward

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski updated this revision to Diff 447250. awarzynski added a comment. Change from CamelCase to camelCase in Flang.h so that the function names adhere to LLVM's coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/ https://

[PATCH] D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin

awarzynski created this revision. awarzynski added reviewers: rovka, rouson, MaskRay, h-vetinari, schweitz, kiranchandramohan. Herald added a reviewer: sscalpone. Herald added subscribers: StephenFan, mehdi_amini. Herald added projects: Flang, All. awarzynski requested review of this revision. Her

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski created this revision. awarzynski added reviewers: rovka, jeanPerier, peixin, kiranktp, Leporacanthicus, dpalermo, ekieri, schweitz, shraiysh, h-vetinari, rouson. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: clementval. Herald added pro

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3519297 , @DavidSpickett wrote: > Can we expect the current `flang-new`, soon to be `flang` to also cope with > these tests (I have no expectations myself here, fine if not) or should we > move the bots to use `fl

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3519403 , @DavidSpickett wrote: > Sounds good to me. https://reviews.llvm.org/D125796 for the bot side, let me > know if/when the first half of the change goes in. https://reviews.llvm.org/D125832 for "patch 1".

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 430379. awarzynski added a comment. Rename `flang-to-gfortran` as `flang-to-external-fc` I will also make this change depend on https://reviews.llvm.org/D125832 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 430604. awarzynski added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/To

[PATCH] D125957: [flang][driver] Make driver accept `-module-dir`

awarzynski created this revision. awarzynski added a reviewer: rovka. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. `-module-dir` is Flang's equiv

[PATCH] D125957: [flang][driver] Make driver accept `-module-dir`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf82062550374: [flang][driver] Make driver accept `-module-dir` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125957/new/ ht

[PATCH] D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGe601b2a15427: [flang][driver] Add support for generating executables on MacOSX/Darwin (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D125628?vs=429528&id=430679#toc Reposit

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Summary updated :) In D125788#3524338 , @kiranchandramohan wrote: > I think it is a driver flag `-flang-experimental-exec`. I was only requesting > the add this information to the patch summary. If you feel it should be > p

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar created this revision. andwar added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the basic parsing and semantic analysis of `#pragma omp declare variant`: * registers '#pragma om

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

andwar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9998 + // GLD1* instructions perform an implicit zero-extend, which makes them // perfect candidates for combining. Could you replace `GLD1*` with `Load`? I believe th

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. We forgot to update the signature and definition of `OptTable::findByPrefix`: https://github.com/llvm/llvm-project/blob/257b29715bb27b7d9f6c3c40c481b6a4af0b37e5/llvm/include/llvm/Option/OptTable.h#L154-L155. That's required after updating the definition of `OptTable::

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski created this revision. Herald added subscribers: cfe-commits, dang, mgorny. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. awarzynski requested review of this revision. Currently Flang uses TextDiagnostic, TextDiagnosticPrinter &

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

awarzynski created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. awarzynski requested review of this revision. As per the documentation, the 2nd argument in printDiagnosticMessage should be a bool that specifies whether the underlying message is a continuati

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

awarzynski added a comment. Thanks for reviewing @sanwou01 ! No new comments, so I'll submit as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87816/new/ https://reviews.llvm.org/D87816 ___ cfe-commit

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

This revision was automatically updated to reflect the committed changes. Closed by commit rG4eae6fc95f95: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

awarzynski added a comment. @CarolineConcatto , thank you for this patch! It implements some really important functionality and IMO the overall structure is solid. I've left quite a few comments, but mostly nits and suggestions for more detailed comments. There's a few, but it's a relatively bi

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 293780. awarzynski marked 17 inline comments as done. awarzynski added a comment. Move code from Fortran to Fortran::frontend namespace, address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Thank you for reviewing! I think that I've addressed all your comments.. Please see the updated patch. Comment at: clang/include/clang/Driver/Options.td:874 +defm color_diagnostics : OptInFFlag<"color-diagnostics", "Enable", "Disable", " colors in

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. In D87774#2287927 , @sameeranjoshi wrote: > Thanks for working on it. > Few comments inline: > > 1. For an out-of-tree build, I see `check-flang` target failing with > > /unittests/Frontend/CompilerInstanceTest.cpp:17:10: fat

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. @sameeranjoshi Regarding ``, please see https://reviews.llvm.org/D88219. Sadly we missed that when adding that test, sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294023. awarzynski added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 Files: clang/include/clang/Driver/Options.td flang/in

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski marked 4 inline comments as done. awarzynski added a comment. In D87774#2293283 , @sameeranjoshi wrote: > Do you know if there are any bots configured to handle out-of-tree changes? > That might be helpful to avoid configuration differences and

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294740. awarzynski marked an inline comment as done. awarzynski added a comment. Address the remaining PR comments, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @CarolineConcatto - thank you for working on this! @all, thank you for your reviews, this is much appreciated! While Carol is away, I'll try my best to address all the outstanding comments. I will also update the patch accordingly. I've identified a few small issues

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

andwar updated this revision to Diff 288018. andwar added a comment. - Canonicalised FLANG_BUILD_NEW_DRIVER in flang/test/CMakeLists.txt and updated the LIT config scripts accordingly - Implemented proper handling of `-emit-obj` (via diagnostics) in CompilerInvocation.cpp - Removed members from

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @andwar is my Phabricator alter-ego. Apologies for the confusion - I had my Arcanist misconfigured. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 _

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 288424. awarzynski added a comment. Added support for out-of-tree builds. It requires -DCLANG_DIR=/lib/cmake/clang when configuring CMake. That's on top of LLVM_DIR and MLIR_DIR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski commandeered this revision. awarzynski added a reviewer: CarolineConcatto. awarzynski added a comment. @sameeranjoshi Thanks for testing out-of-tree builds. We were missing some minor changes in CMake. I have now uploaded these. Out-of-tree will require `-DCLANG_DIR` when configuring

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 289111. awarzynski marked an inline comment as done. awarzynski added a comment. Update README.md with instructions for building `flang-new` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://r

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290337. awarzynski marked 2 inline comments as done. awarzynski added a comment. - Adddressed comments from @richard.barton.arm - Added FC1Option to ClangFlags (and made other related changes) - Added missing code to check return codes from subcommands (fla

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. In D86089#2256139 , @richard.barton.arm wrote: > Another random thought that just came to me: what does the new driver do when > you invoke it with no input files or options? I could imagine a few sensible > outcomes (error:

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290435. awarzynski added a comment. Add missing update in lit.cfg.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 Files: clang/include/clang/Driver/Driver.h c

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 291068. awarzynski marked 2 inline comments as done. awarzynski added a comment. Address final comments I also took the liberty and made the following changes in CMake scripts: - replaced add_library wiht add_flang_library - replaced add_executable with a

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski created this revision. Herald added subscribers: dang, mgorny. Herald added a reviewer: sscalpone. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92854

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

awarzynski created this revision. Herald added subscribers: usaxena95, kadircet. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This is just a small change in the Flang tool within libclangDriver. Currently it pass

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

awarzynski added a comment. In D93027#2445718 , @sameeranjoshi wrote: > Thanks for extracting it from D92854 . > I think the tests in D92854 were failing > for the same reason. > LGTM. T

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski marked 4 inline comments as done. awarzynski added a comment. Thank you for your reviews! I'll submit an updated patch shortly. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:43-44 } else if (isa(JA) || isa(JA)) { -CmdArgs.push_back("-triple"); -CmdArgs

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG764690b8a883: [clang] Remove `-triple` from the invocations of `flang-new -fc1` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHA

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 310952. awarzynski added a comment. Update according to PR comments - extracted the `-triple` related part into https://reviews.llvm.org/D93027 - made sure that `flang-new` and `flang-new -fc1` return error when semantic checks fail - fixed typos Reposi

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 311231. awarzynski added a comment. Fine-tune the output for consistency with `flang`/`f18` This is just a minor change to make sure that: - `flang-new -fc1 -fsyntax-only`, and - `f18 -fparse-only` are as similar as possible. Repository: rG LLVM Gith

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a frontend action for emitting object files. While Flang does

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski added a comment. @dang , I would appreciate if you could take a look at the diff in Options.td - you introduced the most recent changes there: https://reviews.llvm.org/D82574. I got a bit confused with the nested `let` statements there. I couldn't find a better way of marking `-emit-

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:87 + defaultKinds, features, ci.allCookedSources()}; + semanticsContext.set_moduleDirectory("."s); + Fortran::semantics::Semantics semantics{ CarolineConcatto wrote: > Jus

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 311925. awarzynski added a comment. Address comment from @CarolineConcatto + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 Files: clang/include/clang/Driv

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 312400. awarzynski added a comment. Rebased on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 Files: clang/include/clang/Driver/Options.td flang/inc

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski marked an inline comment as done. awarzynski added a comment. @clementval & @SouraVX - thank you for your comments! I will upload an updated version shortly. Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard outpu

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski updated this revision to Diff 312457. awarzynski added a comment. Address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added a comment. @FarisRehman, thank you for working on this! This looks really good and I think that it's almost ready. I did leave a few comments, but most are a matter of style and should be easy to address. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:70-7

[PATCH] D93453: [flang][driver] Add support for `-I`

awarzynski added a comment. Hi @FarisRehman ! Thank you for working on this! Could you add tests? Comment at: clang/lib/Driver/ToolChains/Flang.cpp:75 + Args.AddAllArgs(CmdArgs, options::OPT_I); + This would ideally go to a dedicated method for parsing prepr

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 312547. awarzynski added a comment. Tidy-up include paths This was pointed out by @CarolineConcatto offline, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D928

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d246cb19db9: [flang][driver] Add support for `-fsyntax-only` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added a comment. @FarisRehman , thank you for updating this! I have two high-level comments: 1. In your summary: > Change the way the driver handles end-of-line characters in macro definitions. That's a a bit misleading - which driver do you mean? You're not changing the behavior of

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. @CarolineConcatto thank you again for working on this! The structure is good, but IMHO this patch could be polished a bit more. Overall: - could you make sure that this patch does not change the output from `clang -help`? - doxygen comments are consistent - unittests

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. LGTM, thanks for working on this! As this is a fairly large change, could you wait for one more reviewer to approve? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 ___

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d51d37e0628: [flang] Introduce DiagnosticConsumer classes in libflangFrontend (authored by awarzynski). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. @reviewers A note regarding the changes in Clang. This patch introduces a Flang option (`-test-io`), that should not be available/visible in Clang. AFAIK, there's no precedent of that, hence `options::NoClangOption` is introduced. This is discussed in more detail her

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski updated this revision to Diff 298407. awarzynski added a comment. Address PR comments, clang-format, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 Files: clang/include/clang/Driver/Opt

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski commandeered this revision. awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski. awarzynski added a comment. Thank you for reviewing @SouraVX! I'm just about to submit an updated patch with the requested changes. @CarolineConcatto has recently moved to a differen

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. I've added more reviewers for the Clang side of this patch. I choose people who most recently changed the functions/files that this patch modifies. Any input much appreciated! For more context regarding Clang changes: http://lists.llvm.org/pipermail/cfe-dev/2020-Octo

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski updated this revision to Diff 298635. awarzynski added a comment. Rebase + refector the unit test This is re-based on top of the latest version of D87989 . The unit test is update for consistency with D87989 . Reposit

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski commandeered this revision. awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski. awarzynski added a comment. Since @CarolineConcatto has recently moved to a different project, I am assigning this to myself and will be responding to the future review comments. Tha

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski updated this revision to Diff 299033. awarzynski added a comment. Simplify the API for creating output files The originally implemented API was overly complicated and not yet required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299092. awarzynski marked 3 inline comments as done. awarzynski added a comment. Address PR comments, make clearer separation between option types, simplify/fix tests Based on the feedback, I've made a clearer separation between the parser and the fronten

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInstance.h:85 + /// Return parsing to be used by Actions. + Fortran::parser::Parsing &GetParsing() const { return *parsing_; } + sameeranjoshi wrote: > If I am correct this seems

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299100. awarzynski added a comment. Apply fix to unit test that got lost in the previous patch, simplify C input file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski created this revision. Herald added subscribers: cfe-commits, dexonsmith, dang. Herald added a project: clang. awarzynski requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. As discussed in [1], ClangFlags::DriverOption is currentl

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

awarzynski added a comment. Hi @oneraynyday ! This looks very interesting - thanks for uploading! I've only quickly skimmed through. Two high level points: - Have you considered sending an RFC to cfe-dev regarding this tool? I think that it would be a great way of attracting peoples attention.

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Thank you all for you comments! Please find my replies below. I've picked 4 main points raised here. 1 - In D89799#2342677 , @rnk wrote: > This seems like pretty corner case functionality. Do we really need this > diagnostic

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5906cffd04: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O (authored by CarolineConcatto, committed by awarzynski). C

<    1   2   3   4   5   6   7   >