andreybokhanko added a comment.
@tra, @rnk, @rjmccall, thanks for the review!
Yours,
Andrey
Repository:
rL LLVM
http://reviews.llvm.org/D15686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
andreybokhanko added a comment.
@rafael, thank you!
In http://reviews.llvm.org/D16138#325739, @rafael wrote:
> LGTM, but could you change the default in a followup commit? TargetInfo
> should really be setting it to "" since it is far more common than "_".
Sure, will do.
Yours,
Andrey
http
Author: asbokhan
Date: Thu Jan 14 04:59:36 2016
New Revision: 257756
URL: http://llvm.org/viewvc/llvm-project?rev=257756&view=rev
Log:
Correct setting of UserLabelPrefix for MCU target.
Differential Revision: http://reviews.llvm.org/D16138
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/tr
Author: asbokhan
Date: Thu Jan 14 05:53:50 2016
New Revision: 257757
URL: http://llvm.org/viewvc/llvm-project?rev=257757&view=rev
Log:
Fix for armv7-a15 and thumbv7-a15 buildbot fails.
Modified:
cfe/trunk/test/CodeGenCXX/duplicate-mangled-name.cpp
Modified: cfe/trunk/test/CodeGenCXX/duplicat
Renato,
Thanks! -- I committed a fix already:
http://llvm.org/viewvc/llvm-project?view=revision&revision=257757
Yours,
Andrey
On Thu, Jan 14, 2016 at 2:57 PM, Renato Golin wrote:
> On 14 January 2016 at 10:41, Andrey Bokhanko via cfe-commits
> wrote:
>> Author: asbokhan
>
andreybokhanko created this revision.
andreybokhanko added reviewers: rafael, rjmccall.
andreybokhanko added subscribers: cfe-commits, rafael.
@rafael proposed (http://reviews.llvm.org/D16138#325739) to change
UserLablePrefix's default from "_" to "", as latter value happens much more
often. Thi
andreybokhanko added a comment.
@rafael, all these changes are driven by tests.
It seems you mean OS targeting, which is handled in other TargetInfo classes
(LinuxTargetInfo in Linux case).
Comment at: lib/Basic/Targets.cpp:801
@@ -818,2 +800,3 @@
LongDoubleFormat = &llvm
Author: asbokhan
Date: Fri Jan 22 09:24:34 2016
New Revision: 258504
URL: http://llvm.org/viewvc/llvm-project?rev=258504&view=rev
Log:
Change of UserLabelPrefix default value from "_" to ""
Differential Revision: http://reviews.llvm.org/D16295
Modified:
cfe/trunk/lib/Basic/TargetInfo.cpp
andreybokhanko added a comment.
Rafael, thanks for the review!
In http://reviews.llvm.org/D16295#329929, @rafael wrote:
> I am pretty sure the cases in init.c are wrong as the assembly itself
> doesn't use a '_'.
>
> Having said that, it is probably a good thing to do this in two steps.
> So t
is change with r258894, as it breaks (at least) sparc-rtems.
> Clearly this area of the code was not sufficiently covered by the testsuite.
>
> On Fri, Jan 22, 2016 at 10:24 AM, Andrey Bokhanko via cfe-commits
> wrote:
>>
>> Author: asbokhan
>> Date: Fri Jan 22 09:24
andreybokhanko created this revision.
andreybokhanko added reviewers: rnk, mkuper, rafael.
andreybokhanko added a subscriber: cfe-commits.
Correct setting of WIntType for MCU target
http://reviews.llvm.org/D16626
Files:
lib/Basic/Targets.cpp
test/Preprocessor/elfiamcu-predefines.c
Index: li
or specifically to accommodate this test.
>>
>> Perhaps you might want to add tests for sparc-rterms target as well?
>>
>> Yours,
>> Andrey
>>
>>
>> On Wed, Jan 27, 2016 at 4:10 AM, James Y Knight
>> wrote:
>> > I reverted this change with
andreybokhanko created this revision.
andreybokhanko added reviewers: ddunbar, rnk, mkuper.
andreybokhanko added a subscriber: cfe-commits.
This patch excludes incorrect include headers paths for MCU target.
http://reviews.llvm.org/D14954
Files:
lib/Frontend/InitHeaderSearch.cpp
test/Driver/
Author: asbokhan
Date: Fri Nov 27 06:18:22 2015
New Revision: 254195
URL: http://llvm.org/viewvc/llvm-project?rev=254195&view=rev
Log:
[x86] Exclusion of incorrect include headers paths for MCU target
Exclusion of /usr/include and /usr/local/include headers paths for MCU target.
Differential Rev
> Feel free to commit the header change, it looks fine.
>
> On Fri, Nov 27, 2015 at 5:57 AM, Hal Finkel via cfe-commits
> wrote:
>>
>> Hi Andrey,
>>
>> This commit does not seem to match the description. What is it doing?
>>
>> Thanks again,
>> Ha
Author: asbokhan
Date: Wed Dec 16 07:27:38 2015
New Revision: 255766
URL: http://llvm.org/viewvc/llvm-project?rev=255766&view=rev
Log:
[x86] Exclusion of incorrect include headers paths for MCU target
Exclusion of /usr/include and /usr/local/include headers paths for MCU target.
Differential Rev
commits
>> wrote:
>>>
>>> Hi Andrey,
>>>
>>> This commit does not seem to match the description. What is it doing?
>>>
>>> Thanks again,
>>> Hal
>>>
>>> - Original Message -
>>> > From: &quo
andreybokhanko created this revision.
andreybokhanko added reviewers: rjmccall, tra.
andreybokhanko added a subscriber: cfe-commits.
This patch fixes incorrect behavior described in PR25910.
It is essentially the same stuff as in http://reviews.llvm.org/D11297, just for
variables, not functions.
andreybokhanko added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1235-1236
@@ -1235,8 +1234,4 @@
// different type.
-// FIXME: Support for variables is not implemented yet.
-if (isa(D.getDecl()))
- GV = cast(GetAddrOfGlobal(D,
/*IsForDefinition=*/
101 - 119 of 119 matches
Mail list logo
