[PATCH] D35652: [clang] Fix handling of "%zd" format specifier in scanf

alexshap updated this revision to Diff 107569. alexshap added a comment. Address comments Repository: rL LLVM https://reviews.llvm.org/D35652 Files: lib/Analysis/ScanfFormatString.cpp test/Sema/format-strings-fixit-ssize_t.c test/Sema/format-strings-scanf.c Index: test/Sema/format-str

[PATCH] D35652: [clang] Fix handling of "%zd" format specifier in scanf

This revision was automatically updated to reflect the committed changes. Closed by commit rL308662: [clang] Fix handling of "%zd" in scanf (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D35652?vs=107569&id=107574#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

This revision was automatically updated to reflect the committed changes. Closed by commit rL308678: [clang-tools-extra] Add support for plain C structs in clang-reorder-fields (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D35329?vs=107143&id=107588#toc Repository:

[PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

alexshap created this revision. This diff removes the second argument of the method MachOObjectFile::exports which was recently introduced in r308690. In all in-tree uses this argument is equal to "this", additionally without this argument the interface seems to be cleaner. Test plan: make check

[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

alexshap added inline comments. Comment at: test/clang-reorder-fields/FieldDependencyWarning.cpp:3 + +#include + tests should not depend on STL (for good examples see how things are done in clang-tidy tests), so simply remove this include and define a small cla

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

alexshap created this revision. alexshap added reviewers: NoQ, dcoughlin. Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun. The check (inside StackHintGeneratorForSymbol::getMessage) if (!N) return getMessageForSymbolNotFound() is moved to the beginning of the functio

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

alexshap added a comment. no, i have not seen any crashes related to this particular case, but i've been working on a fix for a separate issue (a bit more involved) (not far from here) (I will send a diff for review soon) and decided to clean it up as well. Repository: rL LLVM https://revi

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL323146: [analyzer] Protect against dereferencing a null pointer (authored by alexshap, committed by ). Changed prior to commit: https://reviews.llvm.org/D42388?vs=130935&id=130946#toc Repository: rL

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap created this revision. alexshap added reviewers: NoQ, dcoughlin. Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun. Do not attempt to get the pointee of void* while generating a bug report (otherwise it will trigger an assert inside RegionStoreManager::getBinding asse

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap updated this revision to Diff 130967. alexshap added a comment. indents Repository: rL LLVM https://reviews.llvm.org/D42396 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c ==

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap updated this revision to Diff 130979. Repository: rL LLVM https://reviews.llvm.org/D42396 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap added a comment. Herald added a reviewer: george.karpenkov. switched to checking (*I)->getType() Repository: rL LLVM https://reviews.llvm.org/D42396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

This revision was automatically updated to reflect the committed changes. Closed by commit rL323382: [analyzer] Do not attempt to get the pointee of void* (authored by alexshap, committed by ). Changed prior to commit: https://reviews.llvm.org/D42396?vs=130979&id=131352#toc Repository: rL LL

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

alexshap added inline comments. Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59 + /// \brief Returns the path of the file containing this atomic change. + std::string getFilePath() const { return FilePath; } + i assume i might be missing smth -

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

alexshap added inline comments. Comment at: lib/Tooling/Refactoring/AtomicChange.cpp:35 +RemovedHeaders(E.getRemovedHeaders()) { +std::copy(E.getReplacements().begin(), E.getReplacements().end(), + std::back_inserter(Replaces)); if i am n

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

alexshap added inline comments. Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59 + /// \brief Returns the path of the file containing this atomic change. + std::string getFilePath() const { return FilePath; } + ioeric wrote: > alexshap wrote: > >

[PATCH] D28218: Small optimizations for SourceManager::getFileID()

alexshap added inline comments. Comment at: lib/Basic/SourceManager.cpp:843 if (E.getOffset() <= SLocOffset) { FileID Res = FileID::get(-int(I) - 2); not particularly important (and unrelated to your changes) - nit - s /C-style cast / static_cast /

[PATCH] D27669: [clang-move] Use appendArgumentsAdjuster for adding extra arguments

alexshap created this revision. alexshap added reviewers: hokein, klimek. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. 1. Remove some boilerplate plate code for appending -fparse-all-comments to the list of arguments. 2. Run clang-format -i a

[PATCH] D27669: [clang-move] Use appendArgumentsAdjuster for adding extra arguments

alexshap added inline comments. Comment at: clang-move/tool/ClangMoveMain.cpp:109 OptionsParser.getSourcePathList()); + // Add "-fparse-all-comments" compile option to make clang parse all comments + Tool.appendArgumentsAdjuster(tooling::getInse

[PATCH] D27669: [clang-move] Use appendArgumentsAdjuster for adding extra arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL289464: [clang-move] Use appendArgumentsAdjuster for adding extra arguments (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D27669?vs=81052&id=81124#toc Repository: rL LLVM

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

alexshap created this revision. alexshap created this object with visibility "All Users". This diff replaces getTypeSize(CondE->getType())) with getIntWidth(CondE->getType())). These calls are not equivalent for bool https://clang.llvm.org/doxygen/ASTContext_8cpp_source.html#l08444 and the anal

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

alexshap added a comment. Thanks, i do. Repository: rL LLVM https://reviews.llvm.org/D32328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

This revision was automatically updated to reflect the committed changes. Closed by commit rL300936: [analyzer] Fix assert in ExprEngine::processSwitch (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D32328?vs=96060&id=96070#toc Repository: rL LLVM https://reviews.

[PATCH] D33061: [tooling] RefactoringCallbacks code cleanup

alexshap created this revision. alexshap created this object with visibility "All Users". 1. Add missing "explicit" for single argument constructors 2. Add missing std::move in ReplaceNodeWithTemplate constructor and switch to pass-by-value idiom Test plan: make check-clang Repository: rL LL

[PATCH] D33061: [tooling] RefactoringCallbacks code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rL302855: [tooling] RefactoringCallbacks code cleanup (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D33061?vs=98509&id=98704#toc Repository: rL LLVM https://reviews.llvm.or

<    1   2   3   4