r256012 - Add a defensive check for a nullptr.

2015-12-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Dec 18 13:44:31 2015 New Revision: 256012 URL: http://llvm.org/viewvc/llvm-project?rev=256012&view=rev Log: Add a defensive check for a nullptr. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/view

Re: r256023 - Fix an unused variable warning from r256012.

2015-12-18 Thread Adrian Prantl via cfe-commits
Thanks, Chad! -- adrian > On Dec 18, 2015, at 12:08 PM, Chad Rosier via cfe-commits > wrote: > > Author: mcrosier > Date: Fri Dec 18 14:08:40 2015 > New Revision: 256023 > > URL: http://llvm.org/viewvc/llvm-project?rev=256023&view=rev > Log: > Fix an unused variable warning from r256012. > >

r256287 - Document that we recommend to turn off -gmodules when building a static

2015-12-22 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Dec 22 16:37:22 2015 New Revision: 256287 URL: http://llvm.org/viewvc/llvm-project?rev=256287&view=rev Log: Document that we recommend to turn off -gmodules when building a static library for distribution to other machines on the clang man page. Modified: cfe/trunk/do

[clang] Fix #pragma (packed, n) not emitting the alignment in debug info (PR #94673)

2024-06-06 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/95164 rdar://110925733 >From bdc0c661ca59ce1cddbc1615a3e640d2943c9c28 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 11 Jun 2024 11:04:00 -0700 Subject: [PATCH] Bump the DWARF version number to 5 on Dar

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/95164 >From 112f03d9d014cda3c89afd4845c0c78289058d11 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 11 Jun 2024 11:04:00 -0700 Subject: [PATCH] Bump the DWARF version number to 5 on Darwin. The default

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-12 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/95164 >From 67dd473d7d1e23177caad0cd722eeb341cf63ebc Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 11 Jun 2024 11:04:00 -0700 Subject: [PATCH] Bump the DWARF version number to 5 on Darwin. The default

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-12 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-12 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: Thanks! https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0f53a59 - Fix typos in comment

2024-06-13 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2024-06-13T09:52:39-07:00 New Revision: 0f53a59fa6b4a7828cf6dbabb0056a379cdc4d0a URL: https://github.com/llvm/llvm-project/commit/0f53a59fa6b4a7828cf6dbabb0056a379cdc4d0a DIFF: https://github.com/llvm/llvm-project/commit/0f53a59fa6b4a7828cf6dbabb0056a379cdc4d0a.diff

[clang] 8f57f68 - Bump the DWARF version number to 5 on Darwin. (#95164)

2024-06-13 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2024-06-13T09:52:11-07:00 New Revision: 8f57f6895724f858c9db924200524fad86cc4f11 URL: https://github.com/llvm/llvm-project/commit/8f57f6895724f858c9db924200524fad86cc4f11 DIFF: https://github.com/llvm/llvm-project/commit/8f57f6895724f858c9db924200524fad86cc4f11.diff

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-13 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: Relanded in 8f57f6895724f858c9db924200524fad86cc4f11 https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] Change handling of structured bindings of bitfields (PR #94632)

2024-06-14 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-04 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: > But also, changes in Clang that break lldb do not necessarily mean that a PR > is not ready to land. There are conforming changes that can be made to Clang > which lldb needs to react to as a downstream consumer of Clang as a library > rather than a PR author needing to

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-04 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: > A revert is not appropriate when: > lldb tests fail because AST printing has changed in Clang and the printed > output is valid Following the logic in this argument, would you also say it's appropriate for someone to commit an LLVM patch that changes how textual LLVM IR

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-04-29 Thread Adrian Prantl via cfe-commits
@@ -27,6 +27,9 @@ namespace llvm { } } +// Prefix for __builtin_verbose_trap. +#define CLANG_VERBOSE_TRAP_PREFIX "__llvm_verbose_trap" adrian-prantl wrote: Does this have to be a macro or could it be a C++ constant? https://github.com/llvm/llvm-project/pul

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-05-02 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-05-02 Thread Adrian Prantl via cfe-commits
@@ -29,7 +29,9 @@ #include "llvm/IR/DebugInfo.h" #include "llvm/IR/ValueHandle.h" #include "llvm/Support/Allocator.h" +#include adrian-prantl wrote: This seems to not belong to this commit? https://github.com/llvm/llvm-project/pull/79230

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-05-02 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-05-02 Thread Adrian Prantl via cfe-commits
@@ -172,6 +172,27 @@ static bool checkArgCount(Sema &S, CallExpr *Call, unsigned DesiredArgCount) { << /*is non object*/ 0 << Call->getArg(1)->getSourceRange(); } +static bool checkBuiltinVerboseTrap(CallExpr *Call, Sema &S) { + bool HasError = false; + + for (int

[clang] [clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions (PR #90717)

2024-05-02 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Unify interface for accessing template arguments as written for class/variable template specializations (PR #81642)

2024-05-07 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: This broke several tests in the LLDB testsuite, I'm going to have to revert this. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/3480/ https://github.com/llvm/llvm-project/pull/81642 ___ cfe-commits mailing li

[clang] 2e4abfa - Revert "[Sema] Fix warnings"

2024-05-07 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2024-05-07T13:03:14-07:00 New Revision: 2e4abfae57f81e2bb23fc654d6edbaeae51ae10a URL: https://github.com/llvm/llvm-project/commit/2e4abfae57f81e2bb23fc654d6edbaeae51ae10a DIFF: https://github.com/llvm/llvm-project/commit/2e4abfae57f81e2bb23fc654d6edbaeae51ae10a.diff

[clang] [clang-tools-extra] Reapply "[Clang] Unify interface for accessing template arguments as written for class/variable template specializations (#81642)" (PR #91393)

2024-05-07 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: How did you address the LLDB test failures? https://github.com/llvm/llvm-project/pull/91393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-05-08 Thread Adrian Prantl via cfe-commits
@@ -6178,10 +6178,16 @@ The current supported opcode vocabulary is limited: the last entry from the second last entry and appends the result to the expression stack. - ``DW_OP_plus_uconst, 93`` adds ``93`` to the working expression. -- ``DW_OP_LLVM_fragment, 16, 8`` specifi

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-05-08 Thread Adrian Prantl via cfe-commits
@@ -6178,10 +6178,16 @@ The current supported opcode vocabulary is limited: the last entry from the second last entry and appends the result to the expression stack. - ``DW_OP_plus_uconst, 93`` adds ``93`` to the working expression. -- ``DW_OP_LLVM_fragment, 16, 8`` specifi

[clang] [clang-tools-extra] Reapply "[Clang] Unify interface for accessing template arguments as written for class/variable template specializations (#81642)" (PR #91393)

2024-05-08 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: Interesting. I though that the check-lldb target would clean the module cache before each run? https://github.com/llvm/llvm-project/blob/fcfc15b7052a311b7a045e2c6bd26fb5d0b7122c/lldb/test/CMakeLists.txt#L56 https://github.com/llvm/llvm-project/blob/fcfc15b7052a311b7a045e2c6

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-05-09 Thread Adrian Prantl via cfe-commits
@@ -6178,10 +6178,16 @@ The current supported opcode vocabulary is limited: the last entry from the second last entry and appends the result to the expression stack. - ``DW_OP_plus_uconst, 93`` adds ``93`` to the working expression. -- ``DW_OP_LLVM_fragment, 16, 8`` specifi

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-05-14 Thread Adrian Prantl via cfe-commits
@@ -6178,10 +6178,16 @@ The current supported opcode vocabulary is limited: the last entry from the second last entry and appends the result to the expression stack. - ``DW_OP_plus_uconst, 93`` adds ``93`` to the working expression. -- ``DW_OP_LLVM_fragment, 16, 8`` specifi

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-05-14 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/85665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-05-15 Thread Adrian Prantl via cfe-commits
@@ -6178,10 +6178,16 @@ The current supported opcode vocabulary is limited: the last entry from the second last entry and appends the result to the expression stack. - ``DW_OP_plus_uconst, 93`` adds ``93`` to the working expression. -- ``DW_OP_LLVM_fragment, 16, 8`` specifi

[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-08-06 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. So this patch makes structured bindings not artificial, so they aren't hidden in debuggers by default. That sounds right to me. https://github.com/llvm/llvm-project/pull/100355 ___ cfe-commi

[clang] 2cd9a86 - Don't append the working directory to absolute paths

2022-02-25 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2022-02-25T13:03:59-08:00 New Revision: 2cd9a86da54f8be4eb2aff3e766b125cbdeb023f URL: https://github.com/llvm/llvm-project/commit/2cd9a86da54f8be4eb2aff3e766b125cbdeb023f DIFF: https://github.com/llvm/llvm-project/commit/2cd9a86da54f8be4eb2aff3e766b125cbdeb023f.diff

[clang] bc7aeea - Revert "Don't append the working directory to absolute paths"

2022-02-25 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2022-02-25T17:00:10-08:00 New Revision: bc7aeea8542d48111f8cc923451b7c53347c75b5 URL: https://github.com/llvm/llvm-project/commit/bc7aeea8542d48111f8cc923451b7c53347c75b5 DIFF: https://github.com/llvm/llvm-project/commit/bc7aeea8542d48111f8cc923451b7c53347c75b5.diff

[clang] 6c3a107 - Mark Basic/TargetCXXABI.def as textual in the module map.

2021-05-04 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2021-05-04T12:52:52-07:00 New Revision: 6c3a10760da3707186d5204bd9283e99344fa90f URL: https://github.com/llvm/llvm-project/commit/6c3a10760da3707186d5204bd9283e99344fa90f DIFF: https://github.com/llvm/llvm-project/commit/6c3a10760da3707186d5204bd9283e99344fa90f.diff

[clang] eb200e5 - Emit the C++ dialect in -gmodules .pcm files.

2022-01-10 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2022-01-10T16:13:40-08:00 New Revision: eb200e584ece7ca8c1f8cac59ca5418956ccf1e4 URL: https://github.com/llvm/llvm-project/commit/eb200e584ece7ca8c1f8cac59ca5418956ccf1e4 DIFF: https://github.com/llvm/llvm-project/commit/eb200e584ece7ca8c1f8cac59ca5418956ccf1e4.diff

[clang] c03c58c - Add missing textual header to module map

2021-12-13 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2021-12-13T09:19:22-08:00 New Revision: c03c58c97ab8ac41c84b5269a40c0b35455e URL: https://github.com/llvm/llvm-project/commit/c03c58c97ab8ac41c84b5269a40c0b35455e DIFF: https://github.com/llvm/llvm-project/commit/c03c58c97ab8ac41c84b5269a40c0b35455e.diff

[clang] 915d1c0 - Add missing textual header to module map

2021-12-13 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2021-12-13T09:21:21-08:00 New Revision: 915d1c0b74b5e9462a9ae7cd684a70d1422c7f5a URL: https://github.com/llvm/llvm-project/commit/915d1c0b74b5e9462a9ae7cd684a70d1422c7f5a DIFF: https://github.com/llvm/llvm-project/commit/915d1c0b74b5e9462a9ae7cd684a70d1422c7f5a.diff

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-02 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. Sounds unfortunate, but if you think that's the best choice for unblocking libc++, let's do that. https://github.com/llvm/llvm-project/pull/110767 ___ cfe-commits mailing list cfe-commits@li

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread Adrian Prantl via cfe-commits
@@ -2995,20 +2995,21 @@ llvm::DIType *CGDebugInfo::CreateType(const ObjCInterfaceType *Ty, if (!ID) return nullptr; + auto RuntimeLang = + static_cast(TheCU->getSourceLanguage()); + // Return a forward declaration if this type was imported from a clang module,

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-17 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/120154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-06 Thread Adrian Prantl via cfe-commits
@@ -486,6 +486,8 @@ class CGDebugInfo { void EmitFunctionDecl(GlobalDecl GD, SourceLocation Loc, QualType FnType, llvm::Function *Fn = nullptr); + llvm::DIScope *PickCompositeTypeScope(llvm::DIScope *S, StringRef Identifier); adrian

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-06 Thread Adrian Prantl via cfe-commits
@@ -546,55 +546,75 @@ class MetadataLoader::MetadataLoaderImpl { /// Move local imports from DICompileUnit's 'imports' field to /// DISubprogram's retainedNodes. + /// Move fucntion-local enums from DICompileUnit's enums adrian-prantl wrote: ```suggestio

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-06 Thread Adrian Prantl via cfe-commits
@@ -718,6 +738,29 @@ class MetadataLoader::MetadataLoaderImpl { upgradeCULocals(); } + void cloneLocalTypes() { +for (unsigned I = 0; I < MetadataList.size(); ++I) { adrian-prantl wrote: range-based for? https://github.com/llvm/llvm-project/pull

[clang] [clang][DebugInfo] Emit DW_AT_object_pointer on function definitions with explicit `this` (PR #122897)

2025-01-14 Thread Adrian Prantl via cfe-commits
adrian-prantl wrote: > @dwblaikie @adrian-prantl any thoughts on adjusting the DWARF spec to allow > explicit `this` parameters to be non-artificial but still be valid > `DW_AT_object_pointer`s? I would suggest posting an issue to dwarf-discuss that just turns that into ``` Many languages mak

[clang] [clang][DebugInfo] Emit DW_AT_object_pointer on function definitions with explicit `this` (PR #122897)

2025-01-14 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/122897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PCH] Don't try to create standalone debug-info for types marked nodebug (PR #123253)

2025-01-16 Thread Adrian Prantl via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -std=c++23 -x c++-header -emit-pch -fmodule-format=obj \ +// RUN: -o %t.pch %s \ +// RUN: -mllvm -debug-only=pchcontainer &>%t-pch.ll +// RUN: cat %t-pch.ll | FileCheck %s + adrian-prantl wrote: Don't forget the REQUIRE: a

[clang] [clang][PCH] Don't try to create standalone debug-info for types marked nodebug (PR #123253)

2025-01-16 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. That looks very correct :-) https://github.com/llvm/llvm-project/pull/123253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang][DebugInfo][test] Add tests for C++20 non-type template parameters (PR #127056)

2025-02-13 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/127056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang modules] Setting `DebugCompilationDir` when it is safe to ignore current working directory (PR #128446)

2025-02-25 Thread Adrian Prantl via cfe-commits
@@ -492,8 +492,23 @@ static std::string getModuleContextHash(const ModuleDeps &MD, auto &FSOpts = const_cast(CI.getFileSystemOpts()); if (CWD && !IgnoreCWD) HashBuilder.add(*CWD); - else + else { FSOpts.WorkingDir.clear(); +auto &CGOpts = const_cast(CI.getCo

[clang] [clang] Add a CodeGen option to ignore compilation directories (PR #149897)

2025-07-22 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/149897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6