r278946 - Simplify condition. (NFC)

2016-08-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Aug 17 11:42:15 2016 New Revision: 278946 URL: http://llvm.org/viewvc/llvm-project?rev=278946&view=rev Log: Simplify condition. (NFC) Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST

r278952 - Module debug info: Fix a bug in handling record decls without fields.

2016-08-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Aug 17 13:27:24 2016 New Revision: 278952 URL: http://llvm.org/viewvc/llvm-project?rev=278952&view=rev Log: Module debug info: Fix a bug in handling record decls without fields. The previous condition would erroneously mark all CXXRecordDecls that didn't have any fields a

r279005 - Print the module format in clang -module-file-info.

2016-08-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Aug 17 18:14:00 2016 New Revision: 279005 URL: http://llvm.org/viewvc/llvm-project?rev=279005&view=rev Log: Print the module format in clang -module-file-info. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp cfe/trunk/test/Modules/module_file_info.m Modified

r279004 - Support object-file-wrapped modules in clang -module-file-info.

2016-08-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Aug 17 18:13:53 2016 New Revision: 279004 URL: http://llvm.org/viewvc/llvm-project?rev=279004&view=rev Log: Support object-file-wrapped modules in clang -module-file-info. rdar://problem/24504815 Modified: cfe/trunk/include/clang/Frontend/FrontendActions.h cfe/tr

r279485 - Module debug info: Don't assert when encountering an incomplete definition

2016-08-22 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Aug 22 17:23:58 2016 New Revision: 279485 URL: http://llvm.org/viewvc/llvm-project?rev=279485&view=rev Log: Module debug info: Don't assert when encountering an incomplete definition in isDefinedInClangModule() and assume that the incomplete definition is not defined in th

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

2016-08-22 Thread Adrian Prantl via cfe-commits
> On Apr 26, 2016, at 4:11 PM, Richard Smith wrote: > > On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 25, 2016, at 5:34 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote:

r279489 - Add the second half of the testcase I should have added in 279485.

2016-08-22 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Aug 22 17:30:34 2016 New Revision: 279489 URL: http://llvm.org/viewvc/llvm-project?rev=279489&view=rev Log: Add the second half of the testcase I should have added in 279485. Added: cfe/trunk/test/Modules/ModuleModuleDebugInfo.cpp Added: cfe/trunk/test/Modules/Module

r279491 - Typo.

2016-08-22 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Aug 22 17:38:18 2016 New Revision: 279491 URL: http://llvm.org/viewvc/llvm-project?rev=279491&view=rev Log: Typo. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/t

r279490 - Add comments. NFC

2016-08-22 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Aug 22 17:38:16 2016 New Revision: 279490 URL: http://llvm.org/viewvc/llvm-project?rev=279490&view=rev Log: Add comments. NFC Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe

Re: r279485 - Module debug info: Don't assert when encountering an incomplete definition

2016-08-23 Thread Adrian Prantl via cfe-commits
ind an assertion. (put another way: "we expect > something specific to happen, not just for clang not to assert/crash") > > On Mon, Aug 22, 2016 at 3:32 PM Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Mon Au

r280010 - Fix a bug preventing the cause for a module file-not-found from being displayed

2016-08-29 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Aug 29 15:46:59 2016 New Revision: 280010 URL: http://llvm.org/viewvc/llvm-project?rev=280010&view=rev Log: Fix a bug preventing the cause for a module file-not-found from being displayed Modified: cfe/trunk/lib/Serialization/ASTReader.cpp cfe/trunk/test/Modules/e

r280009 - Fix a bug preventing the cause of a module-out-of-date error from being printed

2016-08-29 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Aug 29 15:46:56 2016 New Revision: 280009 URL: http://llvm.org/viewvc/llvm-project?rev=280009&view=rev Log: Fix a bug preventing the cause of a module-out-of-date error from being printed Modified: cfe/trunk/lib/Serialization/ASTReader.cpp cfe/trunk/test/Modules/e

Re: r279765 - Omit column info for CodeView by default

2016-08-29 Thread Adrian Prantl via cfe-commits
> On Aug 25, 2016, at 11:24 AM, Adrian McCarthy via cfe-commits > wrote: > > Author: amccarth > Date: Thu Aug 25 13:24:35 2016 > New Revision: 279765 > > URL: http://llvm.org/viewvc/llvm-project?rev=279765&view=rev > Log: > Omit column info for CodeView by default > > Clang tracks only start

r281094 - Debug info: Bump the default DWARF version on Darwin to 4.

2016-09-09 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 9 16:10:35 2016 New Revision: 281094 URL: http://llvm.org/viewvc/llvm-project?rev=281094&view=rev Log: Debug info: Bump the default DWARF version on Darwin to 4. This is a spiritual re-commit of r201375 with only a brief delay for upgrading the green dragon builders.

Re: [PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

2016-09-09 Thread Adrian Prantl via cfe-commits
aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:979 @@ -978,4 +978,3 @@ llvm::DIType * -CGDebugInfo::createFieldType(StringRef name, QualType type, SourceLocation loc, - AccessSpecifier AS, uint64_t offsetInBits, -

r297790 - Canonicalize the path provided by -fmodules-cache-path.

2017-03-14 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Mar 14 18:07:49 2017 New Revision: 297790 URL: http://llvm.org/viewvc/llvm-project?rev=297790&view=rev Log: Canonicalize the path provided by -fmodules-cache-path. This fixes lookup mismatches that could happen when the module cache path contained a '/./' component. Di

r297791 - Make a blind attempt to fix this testcase on Windows.

2017-03-14 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Mar 14 18:29:40 2017 New Revision: 297791 URL: http://llvm.org/viewvc/llvm-project?rev=297791&view=rev Log: Make a blind attempt to fix this testcase on Windows. Modified: cfe/trunk/test/Modules/modules-cache-path-canonicalization.m Modified: cfe/trunk/test/Modules/m

Re: r298913 - Added `applyAtomicChanges` function.

2017-03-30 Thread Adrian Prantl via cfe-commits
Note that the green dragon bot doesn't use local submodule visibility, so every #include pulls in the entire clang module that header belongs to. Does this explain what you are seeing? (You should be able to reproduce with cmake -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=0) -- adrian > On Mar 30

Re: [PATCH] [PPC64]: Add support for Swift calling convention

2017-04-12 Thread Adrian Prantl via cfe-commits
Is it possible to add a testcase for this? -- adrian > On Mar 22, 2017, at 5:00 AM, Andrew Jeffery via cfe-commits > wrote: > > Signed-off-by: Andrew Jeffery > --- > lib/Basic/Targets.cpp | 11 +++ > lib/CodeGen/TargetInfo.cpp | 14 -- > 2 files changed, 23 insertions(

r300523 - Debug Info: Remove special-casing of indirect function argument handling.

2017-04-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Apr 17 20:22:01 2017 New Revision: 300523 URL: http://llvm.org/viewvc/llvm-project?rev=300523&view=rev Log: Debug Info: Remove special-casing of indirect function argument handling. LLVM has changed the semantics of dbg.declare for describing function arguments. After thi

Re: [PATCH] D16135: Macro Debug Info support in Clang

2017-02-08 Thread Adrian Prantl via cfe-commits
> On Feb 8, 2017, at 2:31 PM, David Blaikie wrote: > > > > On Wed, Feb 8, 2017 at 2:25 PM Amjad Aboud via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > aaboud added a comment. > > > How much does the build directory grow? > > Is there any noticeable compile time regression? > >

r308397 - Debug Info: Set the MainFileName when generating -gmodules debug info for PCM.

2017-07-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Jul 18 16:58:34 2017 New Revision: 308397 URL: http://llvm.org/viewvc/llvm-project?rev=308397&view=rev Log: Debug Info: Set the MainFileName when generating -gmodules debug info for PCM. Previously it was uninitialized and thus always defaulted to "". This is mostly a cos

r308399 - Update for LLVM IR metadata changes (DIImportedEntity now needs a DIFile).

2017-07-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Jul 18 17:09:58 2017 New Revision: 308399 URL: http://llvm.org/viewvc/llvm-project?rev=308399&view=rev Log: Update for LLVM IR metadata changes (DIImportedEntity now needs a DIFile). https://bugs.llvm.org/show_bug.cgi?id=33822 Differential Revision: https://reviews.llvm

Re: [PATCH v3] [PPC64]: Add support for Swift calling convention

2017-07-19 Thread Adrian Prantl via cfe-commits
> On Jun 21, 2017, at 11:32 PM, Andrew Jeffery wrote: > > For the tests I've extracted the int5 and int8 cases to cater for > different alignments for different platform ABIs. For Linux on POWER the > 5 and 8 element vectors must be naturally aligned with respect to the > total "soft" vector siz

r308938 - Debug Info: Avoid completing class types when a definition is in a module.

2017-07-24 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Jul 24 16:48:51 2017 New Revision: 308938 URL: http://llvm.org/viewvc/llvm-project?rev=308938&view=rev Log: Debug Info: Avoid completing class types when a definition is in a module. This patch adds an early exit to CGDebugInfo::completeClassData() when compiling with -gm

r323986 - Mark fallthrough with LLVM_FALLTHROUGH

2018-02-01 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Feb 1 10:10:20 2018 New Revision: 323986 URL: http://llvm.org/viewvc/llvm-project?rev=323986&view=rev Log: Mark fallthrough with LLVM_FALLTHROUGH Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp URL: http://llvm.

r296388 - PR32042: Create inlined debug info for EmitInlinedInheritingCXXConstructorCall.

2017-02-27 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Feb 27 15:30:05 2017 New Revision: 296388 URL: http://llvm.org/viewvc/llvm-project?rev=296388&view=rev Log: PR32042: Create inlined debug info for EmitInlinedInheritingCXXConstructorCall. When clang emits an inheriting C++ constructor it may inline code during the CodeGen

r296776 - Document that code inlined into a nodebug function also won't get any

2017-03-02 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Mar 2 12:06:51 2017 New Revision: 296776 URL: http://llvm.org/viewvc/llvm-project?rev=296776&view=rev Log: Document that code inlined into a nodebug function also won't get any debug info. Suggested by Paul Robinson in feedback on r296488, thanks! Modified: cfe/trun

Re: [libcxx] r296840 - Work around test failure on 32 bit OS X

2017-03-03 Thread Adrian Prantl via cfe-commits
Does that mean there is a bug in libcxx that should be documented somewhere? -- adrian > On Mar 2, 2017, at 3:18 PM, Eric Fiselier via cfe-commits > wrote: > > Author: ericwf > Date: Thu Mar 2 17:18:40 2017 > New Revision: 296840 > > URL: http://llvm.org/viewvc/llvm-project?rev=296840&view=re

r297162 - Revert "Document that code inlined into a nodebug function also won't get any"

2017-03-07 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Mar 7 11:28:56 2017 New Revision: 297162 URL: http://llvm.org/viewvc/llvm-project?rev=297162&view=rev Log: Revert "Document that code inlined into a nodebug function also won't get any" This reverts commit r296776. This statement is no longer true. Modified: cfe/tru

r287134 - Fix PR31029 by attaching an artificial debug location to msabi thunks.

2016-11-16 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Nov 16 12:49:47 2016 New Revision: 287134 URL: http://llvm.org/viewvc/llvm-project?rev=287134&view=rev Log: Fix PR31029 by attaching an artificial debug location to msabi thunks. This was a latent bug that was recently uncovered by r286400. Added: cfe/trunk/test/CodeG

r287139 - Add the missing FileCheck invocation to this testcase.

2016-11-16 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Nov 16 13:26:11 2016 New Revision: 287139 URL: http://llvm.org/viewvc/llvm-project?rev=287139&view=rev Log: Add the missing FileCheck invocation to this testcase. Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp Modified: cfe/trunk/test/CodeGenCXX/debug

r287141 - Relax testcase.

2016-11-16 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Nov 16 13:31:44 2016 New Revision: 287141 URL: http://llvm.org/viewvc/llvm-project?rev=287141&view=rev Log: Relax testcase. This removes checks that are irrelevant for what is being tested. Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp Modified: cfe/

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-08 Thread Adrian Prantl via cfe-commits
Hi Richard, at this point this is more a heads-up than anything actionable, but I wanted to let you know that I bisected this bot failure (http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2721/consoleFull#10584592348254eaf0-7326-4999-85b0-388101f2d404) of std/input.output/strea

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-09 Thread Adrian Prantl via cfe-commits
> On Dec 8, 2016, at 7:31 PM, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Dec-08, at 19:29, Richard Smith wrote: >> >> On 8 Dec 2016 7:17 pm, "Duncan P. N. Exon Smith via cfe-commits" >> wrote: >> +Eric, Marshall >> >> I haven't looked, but: from the test name, "copy.fail.cpp", I susp

r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

2017-04-28 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Apr 28 17:25:53 2017 New Revision: 301707 URL: http://llvm.org/viewvc/llvm-project?rev=301707&view=rev Log: Adapt to LLVM API change (DINamespace no longer takes line/file info). rdar://problem/17484998 https://reviews.llvm.org/D32648 Modified: cfe/trunk/lib/CodeGen/

Re: r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

2017-05-01 Thread Adrian Prantl via cfe-commits
tches seems to have one extra import on the > PS4 target. Can you take a look? > > Douglas Yung > >> -Original Message- >> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of >> Adrian Prantl via cfe-commits >> Sent: Friday,

r301805 - Relax testcase to fix a PS4 buildbot failure.

2017-05-01 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon May 1 10:49:40 2017 New Revision: 301805 URL: http://llvm.org/viewvc/llvm-project?rev=301805&view=rev Log: Relax testcase to fix a PS4 buildbot failure. Modified: cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-names

r302476 - Update testcase for upstream LLVM changes.

2017-05-08 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon May 8 17:44:00 2017 New Revision: 302476 URL: http://llvm.org/viewvc/llvm-project?rev=302476&view=rev Log: Update testcase for upstream LLVM changes. Modified: cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp Modified: cfe/trunk/test/CodeGenCXX/linetable-vir

r302556 - Build the Apple-style stage2 with modules

2017-05-09 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue May 9 12:27:03 2017 New Revision: 302556 URL: http://llvm.org/viewvc/llvm-project?rev=302556&view=rev Log: Build the Apple-style stage2 with modules Green dragon had a green stage2 modules bot for a long time now[1] and it is time to retire it and make a modules build th

r302577 - Update testcase for upstream LLVM changes (r302469).

2017-05-09 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue May 9 14:47:41 2017 New Revision: 302577 URL: http://llvm.org/viewvc/llvm-project?rev=302577&view=rev Log: Update testcase for upstream LLVM changes (r302469). Modified: cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp Modified: cfe/trunk/test/CodeGenCXX/lin

r302685 - Build the Apple-style stage2 with full debug info

2017-05-10 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed May 10 10:58:22 2017 New Revision: 302685 URL: http://llvm.org/viewvc/llvm-project?rev=302685&view=rev Log: Build the Apple-style stage2 with full debug info Green dragon had a green stage2 modules bot for a long time now[1] and it is time to retire it and make a modules

r302740 - Partially revert r302685 and swith Apple-style full LTO builds to

2017-05-10 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed May 10 17:14:23 2017 New Revision: 302740 URL: http://llvm.org/viewvc/llvm-project?rev=302740&view=rev Log: Partially revert r302685 and swith Apple-style full LTO builds to -gline-tables-only. The memory consumption is apparently still too much for some of the green drago

Re: [PATCH v2] [PPC64]: Add support for Swift calling convention

2017-05-11 Thread Adrian Prantl via cfe-commits
Thanks, with the testcase this LGTM! -- adrian > On May 11, 2017, at 12:07 AM, Andrew Jeffery wrote: > > Ping - does anyone have a moment to take a look? > > Cheers, > > Andrew > > On Thu, 2017-04-27 at 13:52 +0930, Andrew Jeffery wrote: >> For the tests I've extracted the int5 and int8 cases

r302809 - Add a test that local submodule visibility has no effect on debug info

2017-05-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu May 11 11:40:48 2017 New Revision: 302809 URL: http://llvm.org/viewvc/llvm-project?rev=302809&view=rev Log: Add a test that local submodule visibility has no effect on debug info rdar://problem/27876262 Modified: cfe/trunk/test/Modules/DebugInfoSubmoduleImport.c Mod

r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

2017-05-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu May 11 17:59:19 2017 New Revision: 302840 URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev Log: Module Debug Info: Emit namespaced C++ forward decls in the correct module. The AST merges NamespaceDecls, but for module debug info it is important to put a namesp

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

2017-05-11 Thread Adrian Prantl via cfe-commits
> On May 11, 2017, at 4:43 PM, Richard Smith wrote: > > On 11 May 2017 at 15:59, Adrian Prantl via cfe-commits > wrote: > Author: adrian > Date: Thu May 11 17:59:19 2017 > New Revision: 302840 > > URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev &

r302915 - Simplify DINamespace caching in CGDebugInfo

2017-05-12 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri May 12 11:23:53 2017 New Revision: 302915 URL: http://llvm.org/viewvc/llvm-project?rev=302915&view=rev Log: Simplify DINamespace caching in CGDebugInfo This addresses review feedback from r302840. By not canonicalizing namespace decls and using lexical decl context inste

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

2017-05-12 Thread Adrian Prantl via cfe-commits
> On May 11, 2017, at 5:05 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On May 11, 2017, at 4:43 PM, Richard Smith wrote: >> >> I don't think that's quite right; the AST doesn't merge NamespaceDecls. It >> looks like the i

r303222 - Fix scope of namespaced DISubprograms when the function definition is out-of-line.

2017-05-16 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue May 16 18:46:10 2017 New Revision: 303222 URL: http://llvm.org/viewvc/llvm-project?rev=303222&view=rev Log: Fix scope of namespaced DISubprograms when the function definition is out-of-line. This fixes a regression introduced in r302915. Using the lexical decl context is

r284400 - Fix a typo.

2016-10-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Oct 17 12:41:51 2016 New Revision: 284400 URL: http://llvm.org/viewvc/llvm-project?rev=284400&view=rev Log: Fix a typo. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/To

r284416 - Driver/Darwin: Set the DWARF version based on the deployment target.

2016-10-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Oct 17 14:36:18 2016 New Revision: 284416 URL: http://llvm.org/viewvc/llvm-project?rev=284416&view=rev Log: Driver/Darwin: Set the DWARF version based on the deployment target. System utilities such as atos only support DWARF 4 on OS X 10.11+ and iOS 9+. We thus want to e

r284417 - Update testcase for r284416.

2016-10-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Oct 17 14:46:26 2016 New Revision: 284417 URL: http://llvm.org/viewvc/llvm-project?rev=284417&view=rev Log: Update testcase for r284416. Modified: cfe/trunk/test/CodeGen/dwarf-version.c Modified: cfe/trunk/test/CodeGen/dwarf-version.c URL: http://llvm.org/viewvc/llv

r284420 - Improve the CHECK lines in debug-options.c by separating out the check

2016-10-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Oct 17 15:14:23 2016 New Revision: 284420 URL: http://llvm.org/viewvc/llvm-project?rev=284420&view=rev Log: Improve the CHECK lines in debug-options.c by separating out the check for debug info kind and dwarf version. Modified: cfe/trunk/test/Driver/debug-options.c M

Re: r284416 - Driver/Darwin: Set the DWARF version based on the deployment target.

2016-10-17 Thread Adrian Prantl via cfe-commits
s.llvm.org] On Behalf Of >> Adrian Prantl via cfe-commits >> Sent: Monday, October 17, 2016 12:36 PM >> To: cfe-commits@lists.llvm.org >> Subject: r284416 - Driver/Darwin: Set the DWARF version based on the >> deployment target. >> >> Author: adrian >>

r284423 - Explicitly pass an isysroot to avoid the SDKROOT overriding the deployment target.

2016-10-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Oct 17 15:37:56 2016 New Revision: 284423 URL: http://llvm.org/viewvc/llvm-project?rev=284423&view=rev Log: Explicitly pass an isysroot to avoid the SDKROOT overriding the deployment target. This fixes the green dragon builders after r284416. Modified: cfe/trunk/test

[PATCH] D25621: DebugInfo: use uin32_t for alignment

2016-10-18 Thread Adrian Prantl via cfe-commits
aprantl added a comment. This patch is conflating two set of changes: (1) NFC: rename all occurrences of unsigned for alignment purposes in the frontend with uint32_t (2) shrink all debug-info-related alignment variables from uint64_t -> unint32_t. I think this patch should only be doing the ch

[PATCH] D25621: DebugInfo: use uin32_t for alignment

2016-10-19 Thread Adrian Prantl via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, this LGTM! https://reviews.llvm.org/D25621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

2016-10-25 Thread Adrian Prantl via cfe-commits
aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499 case Type::Adjusted: - case Type::Decayed: + case Type::Decayed: { // Decayed and adjusted types use the adjusted type in LLVM and DWARF. -return CreateType( -cast(cast(Ty)->get

[PATCH] D26145: DebugInfo: support for DW_TAG_atomic_type

2016-10-31 Thread Adrian Prantl via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with inline comments addressed. Comment at: test/CodeGen/debug-info-atomic.c:3 + +// CHECK: !DIDerivedType(tag: DW_TAG_const_type +// CHECK: !DIDerivedType(tag: DW_TAG

[PATCH] D26145: DebugInfo: support for DW_TAG_atomic_type

2016-10-31 Thread Adrian Prantl via cfe-commits
aprantl added a comment. One more inline comment. Comment at: test/CodeGen/debug-info-atomic.c:4 +// CHECK: !DIGlobalVariable(name: "i"{{.*}}type: !5, isLocal: false, isDefinition: true) +// CHECK: !5 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !6) +// CHECK: !6 = !DIDe

Re: r285625 - DebugInfo: support for DW_TAG_atomic_type

2016-10-31 Thread Adrian Prantl via cfe-commits
> On Oct 31, 2016, at 12:09 PM, Victor Leschuk via cfe-commits > wrote: > > Author: vleschuk > Date: Mon Oct 31 14:09:47 2016 > New Revision: 285625 > > URL: http://llvm.org/viewvc/llvm-project?rev=285625&view=rev > Log: > DebugInfo: support for DW_TAG_atomic_type > > Mark C11 _Atomic variabl

Re: r285625 - DebugInfo: support for DW_TAG_atomic_type

2016-11-02 Thread Adrian Prantl via cfe-commits
Ping? > On Oct 31, 2016, at 12:41 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 31, 2016, at 12:09 PM, Victor Leschuk via cfe-commits >> wrote: >> >> Author: vleschuk >> Date: Mon Oct 31 14:09:47 2016 >> New Revision: 285625

r285960 - Add debug info support for C++11 inline namespaces.

2016-11-03 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Nov 3 14:42:14 2016 New Revision: 285960 URL: http://llvm.org/viewvc/llvm-project?rev=285960&view=rev Log: Add debug info support for C++11 inline namespaces. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp Mo

r286322 - Emit debug info for global constants whose address is taken exactly once.

2016-11-08 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Nov 8 18:42:03 2016 New Revision: 286322 URL: http://llvm.org/viewvc/llvm-project?rev=286322&view=rev Log: Emit debug info for global constants whose address is taken exactly once. Add a check to the DeclCache before emitting debug info for a GlobalVariable a second time

r286400 - Use an artificial debug location for non-virtual thunks.

2016-11-09 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Nov 9 15:43:51 2016 New Revision: 286400 URL: http://llvm.org/viewvc/llvm-project?rev=286400&view=rev Log: Use an artificial debug location for non-virtual thunks. Thunks are artificial and have no corresponding source location except for the line number on the DISubprogr

r286411 - Relax testcase so it also works on Windows.

2016-11-09 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Nov 9 17:05:16 2016 New Revision: 286411 URL: http://llvm.org/viewvc/llvm-project?rev=286411&view=rev Log: Relax testcase so it also works on Windows. Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp U

r286412 - Remove extra whitespace

2016-11-09 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Nov 9 17:10:44 2016 New Revision: 286412 URL: http://llvm.org/viewvc/llvm-project?rev=286412&view=rev Log: Remove extra whitespace Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp URL: http://llvm.org

Re: r285625 - DebugInfo: support for DW_TAG_atomic_type

2016-11-11 Thread Adrian Prantl via cfe-commits
Ping. > On Nov 2, 2016, at 9:18 AM, Adrian Prantl wrote: > > Ping? > >> On Oct 31, 2016, at 12:41 PM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >>> >>> On Oct 31, 2016, at 12:09 PM, Victor Leschuk

r247049 - Module Debugging: Emit debug type information into clang modules.

2015-09-08 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Sep 8 14:20:27 2015 New Revision: 247049 URL: http://llvm.org/viewvc/llvm-project?rev=247049&view=rev Log: Module Debugging: Emit debug type information into clang modules. When -fmodule-format is set to "obj", emit debug info for all types declared in a module or refere

r247068 - Module Debugging: Emit debug type information into clang ObjC modules.

2015-09-08 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Sep 8 15:41:52 2015 New Revision: 247068 URL: http://llvm.org/viewvc/llvm-project?rev=247068&view=rev Log: Module Debugging: Emit debug type information into clang ObjC modules. When -fmodule-format is set to "obj", emit debug info for all types declared in a module or r

r247081 - Remove unneeded #include.

2015-09-08 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Sep 8 17:06:40 2015 New Revision: 247081 URL: http://llvm.org/viewvc/llvm-project?rev=247081&view=rev Log: Remove unneeded #include. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-pro

Re: r247049 - Module Debugging: Emit debug type information into clang modules.

2015-09-09 Thread Adrian Prantl via cfe-commits
> On Sep 8, 2015, at 8:05 PM, David Blaikie wrote: > > > > On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Tue Sep 8 14:20:27 2015 > New Revision: 247049 > > URL:

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

2015-09-09 Thread Adrian Prantl via cfe-commits
> On Sep 8, 2015, at 3:08 PM, Paul Robinson > wrote: > > probinson added inline comments. > > > Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264 > @@ +3262,4 @@ > + const NamespaceDecl *NSDecl = UD.getNominatedNamespace(); > + if (!NSDecl->isAnonymousNamespace() || > +

r247303 - Debug Info: Remove an unnecessary debug type visitor.

2015-09-10 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Sep 10 12:13:31 2015 New Revision: 247303 URL: http://llvm.org/viewvc/llvm-project?rev=247303&view=rev Log: Debug Info: Remove an unnecessary debug type visitor. Thanks to dblaikie for spotting this. Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp

Re: r247303 - Debug Info: Remove an unnecessary debug type visitor.

2015-09-10 Thread Adrian Prantl via cfe-commits
> On Sep 10, 2015, at 10:19 AM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 10:18 AM, David Blaikie <mailto:dblai...@gmail.com>> wrote: > > > On Thu, Sep 10, 2015 at 10:13 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org&g

r247319 - Add a getDeclContextDescriptor() helper function to CGDebugInfo. (NFC)

2015-09-10 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Sep 10 13:39:45 2015 New Revision: 247319 URL: http://llvm.org/viewvc/llvm-project?rev=247319&view=rev Log: Add a getDeclContextDescriptor() helper function to CGDebugInfo. (NFC) Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h

r247369 - Module Debugging: Emit forward declarations for types that are defined in

2015-09-10 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Sep 10 20:03:26 2015 New Revision: 247369 URL: http://llvm.org/viewvc/llvm-project?rev=247369&view=rev Log: Module Debugging: Emit forward declarations for types that are defined in clang modules, if -dwarf-ext-refs (DebugTypesExtRefs) is specified. Added: cfe/trunk/t

r247368 - Cleanup: Let CGDebugInfo::ModuleRefCache use a TrackingMDNode (NFC).

2015-09-10 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Sep 10 20:03:19 2015 New Revision: 247368 URL: http://llvm.org/viewvc/llvm-project?rev=247368&view=rev Log: Cleanup: Let CGDebugInfo::ModuleRefCache use a TrackingMDNode (NFC). Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h Mo

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

2015-09-11 Thread Adrian Prantl via cfe-commits
> On Sep 10, 2015, at 6:56 PM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie <mailto:dblai...@gmail.com>> wrote: > > > On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>&g

r247432 - Module Debugging: Emit forward declarations for types that are defined in

2015-09-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 11 12:23:08 2015 New Revision: 247432 URL: http://llvm.org/viewvc/llvm-project?rev=247432&view=rev Log: Module Debugging: Emit forward declarations for types that are defined in clang modules, if -dwarf-ext-refs (DebugTypesExtRefs) is specified. This reimplements r247

r247431 - Revert "Module Debugging: Emit forward declarations for types that are defined in"

2015-09-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 11 12:23:03 2015 New Revision: 247431 URL: http://llvm.org/viewvc/llvm-project?rev=247431&view=rev Log: Revert "Module Debugging: Emit forward declarations for types that are defined in" This reverts commit r247369 to facilitate reviewing of the following patch. Rem

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

2015-09-11 Thread Adrian Prantl via cfe-commits
t; >> >> On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie > <mailto:dblai...@gmail.com>> wrote: >> >> >> On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: adrian >

r247445 - Cleanup: Get rid of a bunch of unnecessary invocations of internString()

2015-09-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 11 13:45:02 2015 New Revision: 247445 URL: http://llvm.org/viewvc/llvm-project?rev=247445&view=rev Log: Cleanup: Get rid of a bunch of unnecessary invocations of internString() in CGDebugInfo.cpp: MDString::get() copies its arguments. Modified: cfe/trunk/lib/CodeG

r247447 - Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).

2015-09-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 11 13:54:28 2015 New Revision: 247447 URL: http://llvm.org/viewvc/llvm-project?rev=247447&view=rev Log: Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC). Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebu

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

2015-09-11 Thread Adrian Prantl via cfe-commits
> On Sep 11, 2015, at 11:21 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Fri Sep 11 12:23:08 2015 > New Revision: 247432 > > URL:

r247448 - Remove an unnecessary check. NFC

2015-09-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 11 13:54:31 2015 New Revision: 247448 URL: http://llvm.org/viewvc/llvm-project?rev=247448&view=rev Log: Remove an unnecessary check. NFC Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/l

r247449 - Fix a typo and make this test stricter.

2015-09-11 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 11 13:54:34 2015 New Revision: 247449 URL: http://llvm.org/viewvc/llvm-project?rev=247449&view=rev Log: Fix a typo and make this test stricter. Modified: cfe/trunk/test/Modules/ExtDebugInfo.m Modified: cfe/trunk/test/Modules/ExtDebugInfo.m URL: http://llvm.org/v

r247895 - Fix a typo.

2015-09-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Sep 17 10:58:54 2015 New Revision: 247895 URL: http://llvm.org/viewvc/llvm-project?rev=247895&view=rev Log: Fix a typo. Modified: cfe/trunk/docs/Modules.rst Modified: cfe/trunk/docs/Modules.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/Modules.rst?rev=

r248037 - Debug Info: Use the full module name as a key when caching DIModules.

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 16:06:14 2015 New Revision: 248037 URL: http://llvm.org/viewvc/llvm-project?rev=248037&view=rev Log: Debug Info: Use the full module name as a key when caching DIModules. The signature may not have been computed at the time the module reference is generated (e.g.: i

r248053 - Simplify the interface of PCHContainerGenerator and friends

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 17:10:59 2015 New Revision: 248053 URL: http://llvm.org/viewvc/llvm-project?rev=248053&view=rev Log: Simplify the interface of PCHContainerGenerator and friends by passing in a CompilerInstance instead of all its individual members. NFC. Modified: cfe/trunk/in

r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 18:01:45 2015 New Revision: 248062 URL: http://llvm.org/viewvc/llvm-project?rev=248062&view=rev Log: CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional. We don't want a skeleton CU when generating debug info for the module itself. NFC. Modif

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

2015-09-18 Thread Adrian Prantl via cfe-commits
> On Sep 18, 2015, at 4:01 PM, Adrian Prantl via cfe-commits > wrote: > > Author: adrian > Date: Fri Sep 18 18:01:45 2015 > New Revision: 248062 > > URL: http://llvm.org/viewvc/llvm-project?rev=248062&view=rev > Log: > CGDebugInfo: Make creating a skeleton C

r248068 - Eliminate a redundant check.

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 19:10:25 2015 New Revision: 248068 URL: http://llvm.org/viewvc/llvm-project?rev=248068&view=rev Log: Eliminate a redundant check. Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperati

r248069 - Refactor ASTReader::getSourceDescriptor(const Module &) into a constructor

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 19:10:32 2015 New Revision: 248069 URL: http://llvm.org/viewvc/llvm-project?rev=248069&view=rev Log: Refactor ASTReader::getSourceDescriptor(const Module &) into a constructor of ASTSourceDescriptor. It was effectively a static function. NFC. Modified: cfe/tru

r248070 - Rename ASTSourceDescriptor::ModuleName to FullModuleName for clarity.

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 19:10:37 2015 New Revision: 248070 URL: http://llvm.org/viewvc/llvm-project?rev=248070&view=rev Log: Rename ASTSourceDescriptor::ModuleName to FullModuleName for clarity. Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h cfe/trunk/lib/AST/ExternalAS

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

2015-09-18 Thread Adrian Prantl via cfe-commits
> On Sep 18, 2015, at 5:11 PM, David Blaikie wrote: > > > > On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Fri Sep 18 18:01:45 2015 > New Revision: 248062 > > URL:

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

2015-09-18 Thread Adrian Prantl via cfe-commits
t; >> >> On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: adrian >> Date: Fri Sep 18 18:01:45 2015 >> New Revision: 248062 >> >> URL: http://llvm.org/viewvc/llvm-project

r248077 - Further simplify CGDebugInfo::getOrCreateModuleRef().

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 19:59:22 2015 New Revision: 248077 URL: http://llvm.org/viewvc/llvm-project?rev=248077&view=rev Log: Further simplify CGDebugInfo::getOrCreateModuleRef(). DIBuilder ignoers DICompileUnits that are passed in as scopes anyway. Modified: cfe/trunk/lib/CodeGen/CGDe

r248076 - Use std::move on these arguments.

2015-09-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Sep 18 19:59:19 2015 New Revision: 248076 URL: http://llvm.org/viewvc/llvm-project?rev=248076&view=rev Log: Use std::move on these arguments. Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h URL: htt

<    1   2   3   4   5   6   >