[clang] [Driver][MinGW] Allow using clang driver to link ARM64X PEs. (PR #148064)

2025-07-15 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/148064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add IgnoreExtension to SortIncludes (PR #137840)

2025-07-15 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/137840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move CMake for prepare_builtins to a subdirectory (PR #148815)

2025-07-15 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/148815 This simply makes things better self-contained. >From a426ba39c895ac8eed7ee0bc69310d7ccb681560 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Tue, 15 Jul 2025 10:44:48 +0100 Subject: [PATCH] [libclc] M

[clang-tools-extra] [clang-tidy][NFC] Add mention of running 'clang-tidy' on changes in Contributing.rst (PR #148547)

2025-07-15 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/148547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-15 Thread Andrey Karlov via cfe-commits
https://github.com/negativ updated https://github.com/llvm/llvm-project/pull/146355 >From fc3b77d8c4b5dd264bd746ed997bcea6cddaf389 Mon Sep 17 00:00:00 2001 From: Andrey Karlov Date: Mon, 30 Jun 2025 17:05:41 +0300 Subject: [PATCH 1/8] Initial implementation --- .../bugprone/unchecked-optional

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-15 Thread Andrey Karlov via cfe-commits
https://github.com/negativ updated https://github.com/llvm/llvm-project/pull/146355 >From fc3b77d8c4b5dd264bd746ed997bcea6cddaf389 Mon Sep 17 00:00:00 2001 From: Andrey Karlov Date: Mon, 30 Jun 2025 17:05:41 +0300 Subject: [PATCH 1/8] Initial implementation --- .../bugprone/unchecked-optional

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-15 Thread Andrey Karlov via cfe-commits
@@ -6298,10 +6304,43 @@ static bool isImmediateSinkBlock(const CFGBlock *Blk) { // at least for now, but once we have better support for exceptions, // we'd need to carefully handle the case when the throw is being // immediately caught. - if (llvm::any_of(*Blk, [](const

[clang] [llvm] [Clang][OpenMP] Non-contiguous strided update (PR #144635)

2025-07-15 Thread Amit Tiwari via cfe-commits
https://github.com/amitamd7 ready_for_review https://github.com/llvm/llvm-project/pull/144635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OpenMP] Non-contiguous strided update (PR #144635)

2025-07-15 Thread Amit Tiwari via cfe-commits
amitamd7 wrote: The PR has incorporated the revised changes. Please, have a look. https://github.com/llvm/llvm-project/pull/144635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Make the dataflow analysis generic (PR #148222)

2025-07-15 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/148222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Make the dataflow analysis generic (PR #148222)

2025-07-15 Thread Gábor Horváth via cfe-commits
@@ -596,143 +709,66 @@ struct LifetimeLattice { } }; -// = // -// The Transfer Function -// = // -clas

[clang] [LifetimeSafety] Make the dataflow analysis generic (PR #148222)

2025-07-15 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. Overall looks good to me. One question for the future: sometimes it might be better to run certain analyses side by side in the same worklist rather than running them sequentially after each other. Do you think there are some analysis st

[clang] [clang-format] Allow array alignment on non-rectangular arrays (PR #143781)

2025-07-15 Thread via cfe-commits
mydeveloperday wrote: I couldn't approve this change with the test changing so... we'll just get beaten by people saying "you changed my code" https://github.com/llvm/llvm-project/pull/143781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [KeyInstr][Clang][NFC] Add test for array cookie store (PR #146517)

2025-07-15 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: Ping https://github.com/llvm/llvm-project/pull/146517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-07-15 Thread Ryotaro Kasuga via cfe-commits
https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/135163 >From 79186af3df57357d40ec3b3e4eaf9da978b31ef6 Mon Sep 17 00:00:00 2001 From: Ryotaro Kasuga Date: Fri, 4 Apr 2025 12:32:57 + Subject: [PATCH 1/7] [clang][CodeGen] Fix metadata when vectorization is disab

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-07-15 Thread Jeremy Morse via cfe-commits
jmorse wrote: Well, github has thrown away my review comments again, so I've no idea 🤷 . Phabricator was better. https://github.com/llvm/llvm-project/pull/137991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [WIP] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-07-15 Thread Ryotaro Kasuga via cfe-commits
https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/135163 >From 79186af3df57357d40ec3b3e4eaf9da978b31ef6 Mon Sep 17 00:00:00 2001 From: Ryotaro Kasuga Date: Fri, 4 Apr 2025 12:32:57 + Subject: [PATCH 1/8] [clang][CodeGen] Fix metadata when vectorization is disab

[clang] [CIR] Separate CIR EnumAttr definitions to be includable without the rest of attributes (PR #148850)

2025-07-15 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/148850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Refactor include guards to use a consistent naming (NFC) (PR #148849)

2025-07-15 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko closed https://github.com/llvm/llvm-project/pull/148849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Revise Cygwin ToolChain to call linker directly (PR #147960)

2025-07-15 Thread via cfe-commits
https://github.com/tyan0 updated https://github.com/llvm/llvm-project/pull/147960 >From 1bb281fa82bbec8ed7759eef5ddf5b5f4991770c Mon Sep 17 00:00:00 2001 From: Takashi Yano Date: Thu, 10 Jul 2025 21:55:05 +0900 Subject: [PATCH] [Clang][Driver] Revise Cygwin ToolChain to call linker directly .

[clang] [clang][docs] Add all clang-tools-extra (PR #148622)

2025-07-15 Thread via cfe-commits
@@ -89,14 +89,53 @@ they'll be tracked here. The focus of this documentation is on the scope and features of the tools for other tool developers; each tool should provide its own user-focused documentation. -``clang-tidy`` +``Clang-Doc`` +- + +`Clang-Doc

[clang] 9f79374 - [CIR] Separate CIR EnumAttr definitions to be includable without the rest of attributes (#148850)

2025-07-15 Thread via cfe-commits
Author: Henrich Lauko Date: 2025-07-15T16:18:57+02:00 New Revision: 9f7937401b62d95f2ebe86072d6f277eb9745cd0 URL: https://github.com/llvm/llvm-project/commit/9f7937401b62d95f2ebe86072d6f277eb9745cd0 DIFF: https://github.com/llvm/llvm-project/commit/9f7937401b62d95f2ebe86072d6f277eb9745cd0.diff

[clang] [CIR] Separate CIR EnumAttr definitions to be includable without the rest of attributes (PR #148850)

2025-07-15 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko closed https://github.com/llvm/llvm-project/pull/148850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream unary not for ComplexType (PR #148857)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Upstream unary not for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/148857.diff 5 Files Affected: - (modified) clang/include/c

[clang] [clang][docs] Add all clang-tools-extra (PR #148622)

2025-07-15 Thread via cfe-commits
https://github.com/weirdsmiley updated https://github.com/llvm/llvm-project/pull/148622 >From 4d59ae8faf2d8b61c86d728b43fe0fc7b72563f7 Mon Sep 17 00:00:00 2001 From: Manas Date: Mon, 14 Jul 2025 18:08:36 +0530 Subject: [PATCH] [clang][docs] Add all clang-tools-extra The 'Extra Clang Tools' sec

[clang] [CIR] Upstream unary not for ComplexType (PR #148857)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes Upstream unary not for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/148857.diff 5 Files Affected: - (modified) clang/include

[clang] [Clang][Driver] Revise Cygwin ToolChain to call linker directly (PR #147960)

2025-07-15 Thread via cfe-commits
https://github.com/tyan0 updated https://github.com/llvm/llvm-project/pull/147960 >From 1bb281fa82bbec8ed7759eef5ddf5b5f4991770c Mon Sep 17 00:00:00 2001 From: Takashi Yano Date: Thu, 10 Jul 2025 21:55:05 +0900 Subject: [PATCH] [Clang][Driver] Revise Cygwin ToolChain to call linker directly .

[clang] [CIR] Refactor include guards to use a consistent naming (NFC) (PR #148849)

2025-07-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/148849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add necessary linker flags when -static-pie is enabled in BareMetal Toolchain (PR #147589)

2025-07-15 Thread Peter Smith via cfe-commits
smithp35 wrote: > > I don't think that this should necessarily prevent this patch from landing. > > To some degree users can just not use the option if the toolchain doesn't > > support it. > > The file names for crt files are borrowed from their linux equivalent. > However as already pointed

[clang] [llvm] [ARM] enable FENV_ACCESS pragma support for hard-float targets (PR #137101)

2025-07-15 Thread Erik Enikeev via cfe-commits
https://github.com/Varnike updated https://github.com/llvm/llvm-project/pull/137101 >From 1b3f48acc5a409648fa0ec374c16411df754ce6d Mon Sep 17 00:00:00 2001 From: Erik Enikeev Date: Mon, 9 Jun 2025 12:08:15 -0400 Subject: [PATCH 1/2] Added support for FENV_ACCESS pragma on hard-float ARM platfo

[clang] [CIR] Upstream unary not for ComplexType (PR #148857)

2025-07-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/148857 Upstream unary not for ComplexType https://github.com/llvm/llvm-project/issues/141365 >From 8d328786bdfc80f348fd6c4159ac54c343a28ae9 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 15 Jul 2025 16:1

[clang] [libc] [llvm] [DebugInfo][RemoveDIs] Suppress getNextNonDebugInfoInstruction (PR #144383)

2025-07-15 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse updated https://github.com/llvm/llvm-project/pull/144383 >From 63654fb7cf702a1d0c5fb5f8d526e926ec5a3470 Mon Sep 17 00:00:00 2001 From: Jeremy Morse Date: Fri, 13 Jun 2025 15:39:53 +0100 Subject: [PATCH 1/2] [DebugInfo][RemoveDIs] Suppress getNextNonDebugInfoInstructio

[clang] [CIR] Reformat Ops to use common `CIR_` prefix and definition traits style (PR #148865)

2025-07-15 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/148865 - This adds common CIR_ prefix to all operation disambiguating them when used with other dialects. - Unifies traits style in operation definitions. This mirrors incubator changes from https://github.com/llvm/cla

[clang] [CIR] Reformat Ops to use common `CIR_` prefix and definition traits style (PR #148865)

2025-07-15 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/148865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add IgnoreExtension to SortIncludes (PR #137840)

2025-07-15 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/137840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Reformat Ops to use common `CIR_` prefix and definition traits style (PR #148865)

2025-07-15 Thread Henrich Lauko via cfe-commits
xlauko wrote: * **#148865** https://app.graphite.dev/github/pr/llvm/llvm-project/148865?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/14886

[clang] [CIR] Reformat Ops to use common `CIR_` prefix and definition traits style (PR #148865)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Henrich Lauko (xlauko) Changes - This adds common CIR_ prefix to all operation disambiguating them when used with other dialects. - Unifies traits style in operation definitions. This mirrors incubator changes from https://github.com/ll

[clang] [Clang] FunctionEffects: Make a separate diagnostic group for redeclarations/overrides where effects are implicit. (PR #148690)

2025-07-15 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/148690 >From ea41b2d036ec9f857be107408b3a2b557d377304 Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Mon, 14 Jul 2025 10:44:56 -0700 Subject: [PATCH 1/5] [Clang] FunctionEffects: Make a separate diagnostic group fo

[clang] [CIR] Reformat Ops to use common `CIR_` prefix and definition traits style (PR #148865)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrich Lauko (xlauko) Changes - This adds common CIR_ prefix to all operation disambiguating them when used with other dialects. - Unifies traits style in operation definitions. This mirrors incubator changes from https://github.com/llvm

[clang] [Clang] FunctionEffects: Make a separate diagnostic group for redeclarations/overrides where effects are implicit. (PR #148690)

2025-07-15 Thread Doug Wyatt via cfe-commits
@@ -11529,17 +11529,28 @@ def note_in_evaluating_default_argument : Note< def warn_invalid_add_func_effects : Warning< "attribute '%0' should not be added via type conversion">, InGroup, DefaultIgnore; -def warn_mismatched_func_effect_override : Warning< - "attribute '%0'

[clang] [clang][NFC] Updated incorrect llvm-unreachable message in getOpenMPSimpleClauseType() (PR #148056)

2025-07-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/148056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] FunctionEffects: Make a separate diagnostic group for redeclarations/overrides where effects are implicit. (PR #148690)

2025-07-15 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/148690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] FunctionEffects: Make a separate diagnostic group for redeclarations/overrides where effects are implicit. (PR #148690)

2025-07-15 Thread via cfe-commits
@@ -707,6 +707,12 @@ Improvements to Clang's diagnostics - Improve the diagnostics for placement new expression when const-qualified object was passed as the storage argument. (#GH143708) +- Added a separate diagnostic group `-Wfunction-effect-redeclarations``, for the more

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-15 Thread Andrey Karlov via cfe-commits
https://github.com/negativ updated https://github.com/llvm/llvm-project/pull/146355 >From fc3b77d8c4b5dd264bd746ed997bcea6cddaf389 Mon Sep 17 00:00:00 2001 From: Andrey Karlov Date: Mon, 30 Jun 2025 17:05:41 +0300 Subject: [PATCH 01/10] Initial implementation --- .../bugprone/unchecked-option

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-15 Thread Andrey Karlov via cfe-commits
https://github.com/negativ updated https://github.com/llvm/llvm-project/pull/146355 >From fc3b77d8c4b5dd264bd746ed997bcea6cddaf389 Mon Sep 17 00:00:00 2001 From: Andrey Karlov Date: Mon, 30 Jun 2025 17:05:41 +0300 Subject: [PATCH 01/11] Initial implementation --- .../bugprone/unchecked-option

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-15 Thread Andrey Karlov via cfe-commits
https://github.com/negativ updated https://github.com/llvm/llvm-project/pull/146355 >From fc3b77d8c4b5dd264bd746ed997bcea6cddaf389 Mon Sep 17 00:00:00 2001 From: Andrey Karlov Date: Mon, 30 Jun 2025 17:05:41 +0300 Subject: [PATCH 01/12] Initial implementation --- .../bugprone/unchecked-option

[clang] Add necessary linker flags when -static-pie is enabled in BareMetal Toolchain (PR #147589)

2025-07-15 Thread Garvit Gupta via cfe-commits
@@ -599,11 +599,18 @@ void baremetal::Linker::ConstructJob(Compilation &C, const JobAction &JA, const Driver &D = getToolChain().getDriver(); const llvm::Triple::ArchType Arch = TC.getArch(); const llvm::Triple &Triple = getToolChain().getEffectiveTriple(); + const bool

[clang] [WIP] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-07-15 Thread Ryotaro Kasuga via cfe-commits
@@ -5237,8 +5237,8 @@ width/count of the set of target architectures supported by your application. ... } -Specifying a width/count of 1 disables the optimization, and is equivalent to -``vectorize(disable)`` or ``interleave(disable)``. +Specifying a *non-scalable* widt

[clang] [WIP] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-07-15 Thread Ryotaro Kasuga via cfe-commits
@@ -643,9 +650,7 @@ void LoopInfoStack::push(BasicBlock *Header, clang::ASTContext &Ctx, case LoopHintAttr::Disable: switch (Option) { case LoopHintAttr::Vectorize: -// Disable vectorization by specifying a width of 1. -setVectorizeWidth(1); -

[clang] [libcxx] [Clang] Diagnose forming references to nullptr (PR #143667)

2025-07-15 Thread Corentin Jabot via cfe-commits
cor3ntin wrote: @AaronBallman @philnik777 you have more feedback? https://github.com/llvm/llvm-project/pull/143667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-07-15 Thread Jeremy Morse via cfe-commits
@@ -0,0 +1,160 @@ +# Key Instructions debug info in LLVM and Clang + +Key Instructions is an LLVM feature that reduces the jumpiness of optimized code debug stepping by discriminating the significance of instrucions that make up source language statements. This document explains

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-07-15 Thread Jeremy Morse via cfe-commits
@@ -0,0 +1,160 @@ +# Key Instructions debug info in LLVM and Clang + +Key Instructions is an LLVM feature that reduces the jumpiness of optimized code debug stepping by discriminating the significance of instrucions that make up source language statements. This document explains

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-07-15 Thread Jeremy Morse via cfe-commits
@@ -0,0 +1,160 @@ +# Key Instructions debug info in LLVM and Clang + +Key Instructions is an LLVM feature that reduces the jumpiness of optimized code debug stepping by discriminating the significance of instrucions that make up source language statements. This document explains

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-07-15 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse edited https://github.com/llvm/llvm-project/pull/137991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-07-15 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse commented: Soft LGTM, awaiting views from @jryans too https://github.com/llvm/llvm-project/pull/137991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-query] Allow for trailing comma in matchers (PR #148018)

2025-07-15 Thread Remy Farley via cfe-commits
https://github.com/one-d-wide updated https://github.com/llvm/llvm-project/pull/148018 >From 22e6282b5dbad9c76b036ef379a4c32ae8d9 Mon Sep 17 00:00:00 2001 From: "Remy D. Farley" Date: Tue, 15 Jul 2025 14:51:31 + Subject: [PATCH] [clang-query] Allow for trailing comma in matchers --- c

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-15 Thread Andrey Karlov via cfe-commits
@@ -6298,10 +6308,60 @@ static bool isImmediateSinkBlock(const CFGBlock *Blk) { // at least for now, but once we have better support for exceptions, // we'd need to carefully handle the case when the throw is being // immediately caught. - if (llvm::any_of(*Blk, [](const

[clang] [clang-tools-extra] [clang-query] Allow for trailing comma in matchers (PR #148018)

2025-07-15 Thread Remy Farley via cfe-commits
one-d-wide wrote: Duh, apparently lit's internal cli interpreter, enabled due to [this](https://github.com/llvm/llvm-project/blob/02d3738be92eac38cebfb7b670673abb9538ca76/compiler-rt/test/lit.common.cfg.py#L123-L125) (setting LIT_USE_INTERNAL_SHELL=1 reproduces the error), doesn't even attempt

[clang-tools-extra] [clang-tidy] Speed up `misc-header-include-cycle` (PR #148757)

2025-07-15 Thread via cfe-commits
EugeneZelenko wrote: It may be worth to mention improvements in Release Notes. https://github.com/llvm/llvm-project/pull/148757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d9e21a9 - [PowerPC] Add DMF basic builtins (#145372)

2025-07-15 Thread via cfe-commits
Author: RolandF77 Date: 2025-07-15T13:46:07-04:00 New Revision: d9e21a92a7b1b68bc61771c4a9320f879850ea90 URL: https://github.com/llvm/llvm-project/commit/d9e21a92a7b1b68bc61771c4a9320f879850ea90 DIFF: https://github.com/llvm/llvm-project/commit/d9e21a92a7b1b68bc61771c4a9320f879850ea90.diff LOG

[clang] [PowerPC] Add DMF basic builtins (PR #145372)

2025-07-15 Thread via cfe-commits
https://github.com/RolandF77 closed https://github.com/llvm/llvm-project/pull/145372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DTLTO][TEST] Fix Clang driver test failing on some build bots (PR #148908)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: bd1976bris (bd1976bris) Changes Not all builds name the compiler executable `clang`. For example, the Fuchsia build bots use `llvm` as their single toolchain executable name, as they combine everything together in a busybot-style binary.

[clang] [Clang] [Driver] Canoncalise `-internal-isystem` include paths (PR #148745)

2025-07-15 Thread James Y Knight via cfe-commits
@@ -1370,19 +1370,47 @@ ToolChain::CXXStdlibType ToolChain::GetCXXStdlibType(const ArgList &Args) const{ return *cxxStdlibType; } +static void ResolveAndAddSystemIncludePath(const ArgList &DriverArgs, + ArgStringList &CC1Args, +

[clang] [Clang] [Driver] Canoncalise `-internal-isystem` include paths (PR #148745)

2025-07-15 Thread James Y Knight via cfe-commits
https://github.com/jyknight commented: The plan of applying only to "internal-isystem"-related flags feels reasonable, although more expansive than I had originally proposed (to apply canonicalization only to finding the GCC installation directories). I'll note that this does have the potentia

[clang] [Clang] [Driver] Canoncalise `-internal-isystem` include paths (PR #148745)

2025-07-15 Thread James Y Knight via cfe-commits
@@ -1370,19 +1370,47 @@ ToolChain::CXXStdlibType ToolChain::GetCXXStdlibType(const ArgList &Args) const{ return *cxxStdlibType; } +static void ResolveAndAddSystemIncludePath(const ArgList &DriverArgs, + ArgStringList &CC1Args, +

[clang] [Clang] [Driver] Canoncalise `-internal-isystem` include paths (PR #148745)

2025-07-15 Thread James Y Knight via cfe-commits
https://github.com/jyknight edited https://github.com/llvm/llvm-project/pull/148745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove Native Client support (PR #133661)

2025-07-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-ubuntu-fast` running on `as-builder-4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/20282 Here is th

[clang] [llvm] [WebAssembly] Add support for nonnull_extern_ref type (PR #148935)

2025-07-15 Thread via cfe-commits
badumbatish wrote: one of the blockers is i'm actually not sure how to add the checks to ensure that the nonnull extern refs always stay non-null. --- The check on IsNullExtern should always return fail for non_null_extern ``` bool SemaWasm::BuiltinWasmRefIsNullExtern(CallExpr *TheCall) {

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-07-15 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I don't know that we've had to deal with the underling functionality for anything in libclang getting removed before; we're usually pretty conservative with what we add in the first place. Maybe we should stub out the methods so they always fail? https://github.com/llvm/l

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-07-15 Thread via cfe-commits
Sirraide wrote: > Maybe we should stub out the methods so they always fail? As in make them do nothing essentially (i.e. return `NULL` etc.) or as in report a fatal error and exit? https://github.com/llvm/llvm-project/pull/119269 ___ cfe-commits mail

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-07-15 Thread via cfe-commits
Sirraide wrote: > Return NULL, I guess; that's how the error handling for those methods used to > work. Yeah, I was just looking at what used to be there, and we’d just print that it isn’t enabled and return `NULL`; I guess we can add them back and print ‘ARCMigrate has been removed from Clan

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-07-15 Thread via cfe-commits
Sirraide wrote: > > Return NULL, I guess; that's how the error handling for those methods used > > to work. > > Yeah, I was just looking at what used to be there, and we’d just print that > it isn’t enabled and return `NULL`; I guess we can add them back and print > ‘ARCMigrate has been remov

[clang] [libclang] Fix version for symbol clang_visitCXXMethods (PR #148958)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eli Friedman (efriedma-quic) Changes Happened to spot this while looking at libclang.map for other reasons. clang_visitCXXMethods was added in LLVM 21, not LLVM 20. --- Full diff: https://github.com/llvm/llvm-project/pull/148958.diff 1

[clang] [libclang] Fix version for symbol clang_visitCXXMethods (PR #148958)

2025-07-15 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/148958 Happened to spot this while looking at libclang.map for other reasons. clang_visitCXXMethods was added in LLVM 21, not LLVM 20. >From 3f9e2f11f547201946213e06fe3ec1ea0df45bc3 Mon Sep 17 00:00:00 2001 From

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-07-15 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Return NULL, I guess; that's how the error handling for those methods used to work. https://github.com/llvm/llvm-project/pull/119269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [libclang] Fix version for symbol clang_visitCXXMethods (PR #148958)

2025-07-15 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic milestoned https://github.com/llvm/llvm-project/pull/148958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Reporting Errors for Duplicating Link Declarations in `modulemap`s (PR #148959)

2025-07-15 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu created https://github.com/llvm/llvm-project/pull/148959 This PR teaches the modulemap parsing logic to report errors if the parsing logic sees duplicating link declarations in the same module. Specifically, duplicating link declarations means multiple link declara

[clang] 7f2bcd9 - [CUDA] add wrapper header for libc++'s __utlility/declval.h (#148918)

2025-07-15 Thread via cfe-commits
Author: Artem Belevich Date: 2025-07-15T13:56:22-07:00 New Revision: 7f2bcd97cf4afc94e4badb2f6acd229003ef5912 URL: https://github.com/llvm/llvm-project/commit/7f2bcd97cf4afc94e4badb2f6acd229003ef5912 DIFF: https://github.com/llvm/llvm-project/commit/7f2bcd97cf4afc94e4badb2f6acd229003ef5912.diff

[clang] [clang][Modules] Reporting Errors for Duplicating Link Declarations in `modulemap`s (PR #148959)

2025-07-15 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu edited https://github.com/llvm/llvm-project/pull/148959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Fix version for symbol clang_visitCXXMethods (PR #148958)

2025-07-15 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#148980 https://github.com/llvm/llvm-project/pull/148958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove getDefaultCallingConvention IsBuiltin (PR #145904)

2025-07-15 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/145904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move `ExceptionHandling` from `LangOptions` to `CodeGenOptions` (PR #148982)

2025-07-15 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/148982 This PR removes the command line parsing workaround introduced in https://github.com/llvm/llvm-project/pull/146342 by moving `LangOptions::ExceptionHandling` to `CodeGenOptions` that get parsed even for I

[clang] [llvm] [clang][python][test] Move python binding tests to lit framework (PR #148802)

2025-07-15 Thread Zequan Wu via cfe-commits
ZequanWu wrote: Hi, it might be the cause of a build failure on our bot: ``` == ERROR: test_typekind_spelling (cindex.test_type.TestType) Ensure TypeKind.spelling works. ---

[clang] 66e707e - [NFC] Remove getDefaultCallingConvention IsBuiltin (#145904)

2025-07-15 Thread via cfe-commits
Author: Harald van Dijk Date: 2025-07-15T23:49:52+01:00 New Revision: 66e707ec68d6dc8d8f70083b68daf52559a862c1 URL: https://github.com/llvm/llvm-project/commit/66e707ec68d6dc8d8f70083b68daf52559a862c1 DIFF: https://github.com/llvm/llvm-project/commit/66e707ec68d6dc8d8f70083b68daf52559a862c1.dif

[clang] [CIR] Fix alignment when lowering set/get bitfield operations (PR #148999)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Andres-Salamanca) Changes This PR fixes incorrect alignment when lowering `set` and `getBitField` operations to LLVM IR. The issue occurred because during lowering, the function was being called with an alignment of 0, which caused

[clang] [CIR] Fix alignment when lowering set/get bitfield operations (PR #148999)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: None (Andres-Salamanca) Changes This PR fixes incorrect alignment when lowering `set` and `getBitField` operations to LLVM IR. The issue occurred because during lowering, the function was being called with an alignment of 0, which cause

[clang] [CIR] Fix alignment when lowering set/get bitfield operations (PR #148999)

2025-07-15 Thread via cfe-commits
https://github.com/Andres-Salamanca created https://github.com/llvm/llvm-project/pull/148999 This PR fixes incorrect alignment when lowering `set` and `getBitField` operations to LLVM IR. The issue occurred because during lowering, the function was being called with an alignment of 0, which ca

[clang] Suppress noreturn warning if last statement in a function is a throw (PR #145166)

2025-07-15 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > Just out of curiosity, could implementing this warning to be LTO only solve > this? Anything requiring whole-program analysis sounds like a task to be done > during LTO. IIRC GCC has some warnings that are only made possible by LTO. I don't think this would be the right directi

[clang] [OpenACC][Sema] Implement warning for non-effective 'private' (PR #149004)

2025-07-15 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru approved this pull request. The private variable requirements look correct to me! Thank you! https://github.com/llvm/llvm-project/pull/149004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [Clang] Fix FE crash during CGCoroutine GRO Alloca Emission (PR #148962)

2025-07-15 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/148962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [HIP][CUDA] Support for header file types .hiph, .cuh (fixes 148972) (PR #148973)

2025-07-15 Thread Alex Baretta via cfe-commits
https://github.com/alexbaretta updated https://github.com/llvm/llvm-project/pull/148973 >From 32b3ac0d7545853920aca489df244cb11a97ee57 Mon Sep 17 00:00:00 2001 From: Alex Baretta Date: Tue, 15 Jul 2025 14:45:34 -0700 Subject: [PATCH] [HIP][CUDA] Support for header file types .hiph, .cuh With t

[clang] [clang-tools-extra] [HIP][CUDA] Support for header file types .hiph, .cuh (fixes 148972) (PR #148973)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Alex Baretta (alexbaretta) Changes With this change, clangd interprets .cuh and .hiph extensions as header files for CUDA and HIP respectively. This is necessary to allow clangd to correctly determine the compile command for these

[clang] [clang-tools-extra] [HIP][CUDA] Support for header file types .hiph, .cuh (fixes 148972) (PR #148973)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Baretta (alexbaretta) Changes With this change, clangd interprets .cuh and .hiph extensions as header files for CUDA and HIP respectively. This is necessary to allow clangd to correctly determine the compile command for these header

[clang-tools-extra] [clang-doc] fix ASan complaints from passing RepositoryURL as reference (PR #148923)

2025-07-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM, assuming the complaint is from the optional and not the StringRef. https://github.com/llvm/llvm-project/pull/148923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [clang-tools-extra] [HIP][CUDA] Support for header file types .hiph, .cuh (fixes 148972) (PR #148973)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Alex Baretta (alexbaretta) Changes With this change, clangd interprets .cuh and .hiph extensions as header files for CUDA and HIP respectively. This is necessary to allow clangd to correctly determine the compile command for t

[clang] [clang-tools-extra] [HIP][CUDA] Support for header file types .hiph, .cuh (fixes 148972) (PR #148973)

2025-07-15 Thread Alex Baretta via cfe-commits
https://github.com/alexbaretta created https://github.com/llvm/llvm-project/pull/148973 With this change, clangd interprets .cuh and .hiph extensions as header files for CUDA and HIP respectively. This is necessary to allow clangd to correctly determine the compile command for these header fil

[clang] [clang-tools-extra] [HIP][CUDA] Support for header file types .hiph, .cuh (fixes 148972) (PR #148973)

2025-07-15 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-15 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/144745 >From 9e5cca779abaf4b282d2f17d326d98cb07e8a14c Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Fri, 13 Jun 2025 12:45:34 -0700 Subject: [PATCH] Fix IP2State tables style: revert one change Adjust tests ad

[clang] [CIR] Upstream the basic structure of LoweringPrepare pass (PR #148545)

2025-07-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-clang-x86_64-linux-debian` running on `gribozavr4` while building `clang` at step 2 "checkout". Full details are available at: https://lab.llvm.org/buildbot/#/builders/6/builds/10413 Here is the relevant piece of the

[clang] [NFC][SemaHLSL] Fix typo causing float to double conversion (PR #148941)

2025-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Finn Plummer (inbelic) Changes - it was noted, [here](https://github.com/llvm/llvm-project/pull/145795#discussion_r2208118547), that by accidently not specifying this explicitly as a float it will cause a build warning on MSVC - this co

<    1   2   3   4   5   >