[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

2025-06-19 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/144833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash when doing special member lookup on forward-declared classes (Fixes llvm/llvm-project#144642) (PR #144828)

2025-06-19 Thread Yanzuo Liu via cfe-commits
zwuis wrote: Thank you for the patch! Please add tests in `clang/test/` to make sure this fix actually works. Please add a release note in `clang/docs/ReleaseNotes.rst` so that users can know the improvement. https://github.com/llvm/llvm-project/pull/144828

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-06-19 Thread Tom Honermann via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +// expected-warning@+1{{'sycl_external' attribute ignored}} +[[clang::sycl_external]] void bar() {} + +// expected-warning@+1{{'sycl_external' attribute ignored}} +[[clang::sycl_external]] int a; tah

[clang] [llvm] [InstCombine] remove dead loads, such as memcpy from undef (PR #143958)

2025-06-19 Thread Jameson Nash via cfe-commits
https://github.com/vtjnash updated https://github.com/llvm/llvm-project/pull/143958 >From 450eb079e97f1a20ab2547567d81c176fec06cfb Mon Sep 17 00:00:00 2001 From: Jameson Nash Date: Thu, 12 Jun 2025 18:48:00 + Subject: [PATCH 01/12] [instcombine] remove dead loads, such as memcpy from undef

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-19 Thread via cfe-commits
sivadeilra wrote: My team is interested in fixing / completing the SEH support in LLVM, as well. I think this PR is consistent with that, since it aligns LLVM's behavior with that of MSVC. For an SEH exception that occurs within a function due to a CALL (such as a bogus indirect call), the I

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-19 Thread Sam Elliott via cfe-commits
@@ -190,6 +192,31 @@ insertWaveSizeFeature(StringRef GPU, const Triple &T, StringMap &Features); } // namespace AMDGPU + +struct BasicSubtargetFeatureKV { + const char *Key; ///< K-V key string + unsigned Value; ///< K-V integer value +

[clang] [CIR] Add initial support for bitfields in structs (PR #142041)

2025-06-19 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/142041 >From d6e0ab92adad4110280ac86a2e5f33f5a690b65f Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 29 May 2025 16:17:09 -0500 Subject: [PATCH 1/6] Add initial support for bitfields in structs and

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-06-19 Thread Tom Honermann via cfe-commits
@@ -476,6 +476,41 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLExternalDocs : Documentation { + let Category = DocCatFunction; + let Heading = "sycl_external"; + let Content = [{ +The ``sycl_external`` attribute indicates that a

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-06-19 Thread Tom Honermann via cfe-commits
@@ -476,6 +476,41 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLExternalDocs : Documentation { + let Category = DocCatFunction; + let Heading = "sycl_external"; + let Content = [{ +The ``sycl_external`` attribute indicates that a

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-06-19 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/140282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-06-19 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann requested changes to this pull request. Thanks for addressing most of my earlier comments. I took another quick look today and added a couple more comments. https://github.com/llvm/llvm-project/pull/140282 ___ cfe-commit

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-19 Thread Eli Friedman via cfe-commits
@@ -50,11 +50,11 @@ BUILTIN(__builtin_arm_wfi, "v", "") BUILTIN(__builtin_arm_sev, "v", "") BUILTIN(__builtin_arm_sevl, "v", "") BUILTIN(__builtin_arm_chkfeat, "WUiWUi", "") -TARGET_HEADER_BUILTIN(__yield, "v", "h", ARMACLE_H, ALL_LANGUAGES, "") -TARGET_HEADER_BUILTIN(__wfe,

[clang] [BUG] Fix : #139514 (PR #144956)

2025-06-19 Thread Rahul Samajpati via cfe-commits
https://github.com/RahulXDTT created https://github.com/llvm/llvm-project/pull/144956 Fixes "#139514" Description: This test checks that when formatting a function parameter with a long type name, a pointer, and a const qualifier, clang-format will break the line before the const if needed to

[clang] [BUG] Fix : #139514 (PR #144956)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Rahul Samajpati (RahulXDTT) Changes Fixes "#139514" Description: This test checks that when formatting a function parameter with a long type name, a pointer, and a const qualifier, clang-format will break the line before the const

[clang] [BUG] Fix : #139514 (PR #144956)

2025-06-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [-Wunterminated-string-initialization] Handle C string literals ending with explicit '\0' (PR #143487)

2025-06-19 Thread Eli Friedman via cfe-commits
@@ -260,6 +260,12 @@ static void CheckStringInit(Expr *Str, QualType &DeclT, const ArrayType *AT, diag::ext_initializer_string_for_char_array_too_long) << Str->getSourceRange(); else if (StrLength - 1 == ArrayLen) { + // If the string literal is

[clang] [CodeGen] Use range-based for loops (NFC) (PR #144939)

2025-06-19 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/144939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ObjCARC] Delete empty autoreleasepools with no autoreleases in them (PR #144788)

2025-06-19 Thread via cfe-commits
https://github.com/AZero13 updated https://github.com/llvm/llvm-project/pull/144788 >From dcf0054fbfecdf0bede93de8fe526ac2ecfc246b Mon Sep 17 00:00:00 2001 From: Rose Date: Wed, 18 Jun 2025 16:05:44 -0400 Subject: [PATCH 1/2] [ObjCARC] Delete empty autoreleasepools with no autoreleases in them

[clang] [CIR] Remove redundant operation trait and use AllTypesMatch instead (PR #144950)

2025-06-19 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/144950 This mirrors incubator changes from https://github.com/llvm/clangir/pull/1679 >From f6207dc635fdd9f87000798eb3ddb61eb45190b5 Mon Sep 17 00:00:00 2001 From: xlauko Date: Thu, 19 Jun 2025 22:03:29 +0200 Subject: [

[clang] [CIR] Remove redundant operation trait and use AllTypesMatch instead (PR #144950)

2025-06-19 Thread Henrich Lauko via cfe-commits
xlauko wrote: * **#144950** https://app.graphite.dev/github/pr/llvm/llvm-project/144950?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/14495

[clang] [CIR] Remove redundant operation trait and use AllTypesMatch instead (PR #144950)

2025-06-19 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/144950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Remove redundant operation trait and use AllTypesMatch instead (PR #144950)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clangir Author: Henrich Lauko (xlauko) Changes This mirrors incubator changes from https://github.com/llvm/clangir/pull/1679 --- Full diff: https://github.com/llvm/llvm-project/pull/144950.diff 3 Files Affected: - (modified

[clang] [CIR] Remove redundant operation trait and use AllTypesMatch instead (PR #144950)

2025-06-19 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper approved this pull request. https://github.com/llvm/llvm-project/pull/144950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Initial support for gfx1250 target. (PR #144965)

2025-06-19 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/144965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] DRAFT: [flang][OpenMP] Remove experimental warning (PR #144915)

2025-06-19 Thread via cfe-commits
https://github.com/NimishMishra approved this pull request. LGTM. Thanks a lot https://github.com/llvm/llvm-project/pull/144915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6997465 - [AMDGPU] Initial support for gfx1250 target. (#144965)

2025-06-19 Thread via cfe-commits
Author: Stanislav Mekhanoshin Date: 2025-06-19T22:52:51-07:00 New Revision: 69974658f079cec82a9fc13dd4993ab1e072c811 URL: https://github.com/llvm/llvm-project/commit/69974658f079cec82a9fc13dd4993ab1e072c811 DIFF: https://github.com/llvm/llvm-project/commit/69974658f079cec82a9fc13dd4993ab1e072c8

[clang] [clang] Migrate away from ArrayRef(std::nullopt) (NFC) (PR #144982)

2025-06-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/144982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7cbb141 - [clang] Migrate away from ArrayRef(std::nullopt) (NFC) (#144982)

2025-06-19 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-06-19T23:29:50-07:00 New Revision: 7cbb1411550ef6caab18a9360f1549d6029ffe86 URL: https://github.com/llvm/llvm-project/commit/7cbb1411550ef6caab18a9360f1549d6029ffe86 DIFF: https://github.com/llvm/llvm-project/commit/7cbb1411550ef6caab18a9360f1549d6029ffe86.diff L

[clang] [llvm] [AMDGPU] Initial support for gfx1250 target. (PR #144965)

2025-06-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve2-vla-2stage` running on `linaro-g4-01` while building `clang,llvm` at step 12 "ninja check 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/199/builds/4186 Here is the relevant p

[clang] [clang] Add managarm support (PR #144791)

2025-06-19 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/144791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0f302f3 - [clang] Add managarm support (#144791)

2025-06-19 Thread via cfe-commits
Author: no92 Date: 2025-06-20T02:40:20-04:00 New Revision: 0f302f38b0014a0018031ffb3cb898fdc7d90880 URL: https://github.com/llvm/llvm-project/commit/0f302f38b0014a0018031ffb3cb898fdc7d90880 DIFF: https://github.com/llvm/llvm-project/commit/0f302f38b0014a0018031ffb3cb898fdc7d90880.diff LOG: [cl

[clang] [llvm] Test 142948, please ignore (PR #144873)

2025-06-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/144873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Test 142948 (PR #144873)

2025-06-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/144873 >From e57e53c7e5abdb4c390a04b4ce9084dec9e71dd5 Mon Sep 17 00:00:00 2001 From: Rainer Orth Date: Thu, 5 Jun 2025 13:40:26 +0200 Subject: [PATCH 1/4] [clang][python][test] Move python binding tests to lit fr

[clang] [llvm] [Transforms] Add LifetimeMovePass (PR #144319)

2025-06-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/Transforms/Scalar/LifetimeMove.h

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-19 Thread Joseph Huber via cfe-commits
@@ -417,3 +417,15 @@ void HIPAMDToolChain::checkTargetID( getDriver().Diag(clang::diag::err_drv_bad_target_id) << *PTID.OptionalTargetID; } + +SPIRVAMDToolChain::SPIRVAMDToolChain(const Driver &D, + const llvm::Triple &Triple, +

[clang] 09e794c - [HIP] Emit the CUID value in the module with the new driver (#144570)

2025-06-19 Thread via cfe-commits
Author: Joseph Huber Date: 2025-06-19T07:47:03-05:00 New Revision: 09e794c4bb138e14b3156d7dbdac0164d9c0327b URL: https://github.com/llvm/llvm-project/commit/09e794c4bb138e14b3156d7dbdac0164d9c0327b DIFF: https://github.com/llvm/llvm-project/commit/09e794c4bb138e14b3156d7dbdac0164d9c0327b.diff

[clang] [HIP] Emit the CUID value in the module with the new driver (PR #144570)

2025-06-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/144570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] DRAFT: [flang][OpenMP] Remove experimental warning (PR #144915)

2025-06-19 Thread Pranav Bhandarkar via cfe-commits
@@ -74,6 +74,6 @@ ! CHECK-LD-ANYMD: "{{.*}}ld{{(.exe)?}}" ! CHECK-LD-ANYMD: "-l{{(omp|gomp|iomp5md)}}" ! -! RUN: %flang -fopenmp -c %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-EXPERIMENTAL +! RUN: %flang -fopenmp -fopenmp-version=40 -c %s -### 2>&1 | FileCheck %s --check

[clang] [flang] DRAFT: [flang][OpenMP] Remove experimental warning (PR #144915)

2025-06-19 Thread Pranav Bhandarkar via cfe-commits
https://github.com/bhandarkar-pranav edited https://github.com/llvm/llvm-project/pull/144915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][SPIRV] Reapply "[HLSL][SPIRV] Add vk::constant_id attribute." (PR #144902)

2025-06-19 Thread Steven Perron via cfe-commits
https://github.com/s-perron edited https://github.com/llvm/llvm-project/pull/144902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU][Driver] Add `avail-extern-gv-in-addrspace-to-local` option when ThinTLO is enabled (PR #144914)

2025-06-19 Thread Shilei Tian via cfe-commits
shiltian wrote: > Bit of a hack it seems It is a hack (or workaround). The correct approach would be either to redesign the lowering of LDS, or create another flavor of ThinLTO. Neither of it can be done in a reasonably short amount of time. https://github.com/llvm/llvm-project/pull/144914 __

[clang] [NFC][Clang][AST] Adopt simplified `getTrailingObjects` in AST (PR #144432)

2025-06-19 Thread via cfe-commits
@@ -388,9 +387,7 @@ template class OMPDirectiveListClause : public OMPClause { assert( DK.size() == NumKinds && "Number of directive kinds is not the same as the preallocated buffer"); -std::copy(DK.begin(), DK.end(), - static_cast(this)

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in ASTReader (PR #144438)

2025-06-19 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/144438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Nathan Gauër via cfe-commits
@@ -346,8 +346,9 @@ bool sampledTypeIsSignedInteger(const llvm::Type *HandleType) { if (TET->getTargetExtName() == "spirv.Image") { return false; } - return TET->getTypeParameter(0)->isIntegerTy(); -} + assert(TET->getTargetExtName() == "spirv.SignedImage") { +re

[clang] [flang] DRAFT: [flang][OpenMP] Remove experimental warning (PR #144915)

2025-06-19 Thread Pranav Bhandarkar via cfe-commits
https://github.com/bhandarkar-pranav approved this pull request. LGTM. I have a nit, but too minor to warrant an update to this PR. Only address it if you are planning to push an update to this PR on account of someone else's review with beefier changes requested. https://github.com/llvm/llvm-

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Steven Perron via cfe-commits
@@ -346,8 +346,9 @@ bool sampledTypeIsSignedInteger(const llvm::Type *HandleType) { if (TET->getTargetExtName() == "spirv.Image") { return false; } - return TET->getTypeParameter(0)->isIntegerTy(); -} + assert(TET->getTargetExtName() == "spirv.SignedImage") { +re

[clang-tools-extra] [clang-tidy] Add option to keep virtual in 'modernize-use-override' (PR #144916)

2025-06-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][bytecode] Allocate IntegralAP and Floating types using an allocator (PR #144246)

2025-06-19 Thread David Spickett via cfe-commits
Timm =?utf-8?q?BĂ€der?= , Timm =?utf-8?q?BĂ€der?= Message-ID: In-Reply-To: DavidSpickett wrote: This only reproduces if we build it with clang (19.1.7, but might not be version specific). I added a debug trap in place of the assert and got a better traceback: ``` -- Testing: 1 tests, 1 workers

[clang-tools-extra] [clang-tidy] Add option to keep virtual in 'modernize-use-override' (PR #144916)

2025-06-19 Thread Frank Winklmeier via cfe-commits
https://github.com/fwinkl created https://github.com/llvm/llvm-project/pull/144916 Add a new `AllowVirtual` option to 'modernize-use-override', which does not remove the `virtual` specifier. This is useful because some coding guidelines may suggest to use `virtual ... override` for clarity. Se

[clang-tools-extra] [clang-tidy] Add option to keep virtual in 'modernize-use-override' (PR #144916)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Frank Winklmeier (fwinkl) Changes Add a new `AllowVirtual` option to 'modernize-use-override', which does not remove the `virtual` specifier. This is useful because some coding guidelines may suggest to use `virtual ... override` for

[clang-tools-extra] [clang-tidy] Add option to keep virtual in 'modernize-use-override' (PR #144916)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Frank Winklmeier (fwinkl) Changes Add a new `AllowVirtual` option to 'modernize-use-override', which does not remove the `virtual` specifier. This is useful because some coding guidelines may suggest to use `virtual ... overri

[clang-tools-extra] [clang-tidy] Add option to keep virtual in 'modernize-use-override' (PR #144916)

2025-06-19 Thread Frank Winklmeier via cfe-commits
@@ -226,7 +232,8 @@ void UseOverrideCheck::check(const MatchFinder::MatchResult &Result) { CharSourceRange::getTokenRange(OverrideLoc, OverrideLoc)); } - if (HasVirtual) { + // Remove virtual unless requested otherwise fwinkl wrote: Note that eve

[clang] [Clang][AMDGPU][Driver] Add `avail-extern-gv-in-addrspace-to-local` option when ThinTLO is enabled (PR #144914)

2025-06-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Bit of a hack it seems, but better than it being broken. https://github.com/llvm/llvm-project/pull/144914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] [clang-tidy] Add option to keep virtual in 'modernize-use-override' (PR #144916)

2025-06-19 Thread Frank Winklmeier via cfe-commits
https://github.com/fwinkl edited https://github.com/llvm/llvm-project/pull/144916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Steven Perron via cfe-commits
@@ -341,6 +341,13 @@ class SPIRVInstructionSelector : public InstructionSelector { GIntrinsic &HandleDef, MachineInstr &Pos) const; }; +bool sampledTypeIsSignedInteger(const llvm::Type *HandleType) { + const TargetExtType *TET = cast(HandleTy

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/144774 >From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Wed, 18 Jun 2025 09:19:45 -0400 Subject: [PATCH 1/2] [HLSL][SPRIV] Handle sign RWBuffer correctly MIME-Version:

[clang] 01d648a - [HLSL][SPIRV] Reapply "[HLSL][SPIRV] Add vk::constant_id attribute." (#144902)

2025-06-19 Thread via cfe-commits
Author: Steven Perron Date: 2025-06-19T11:52:55-04:00 New Revision: 01d648a42939c834b6b45677e54088b01c11 URL: https://github.com/llvm/llvm-project/commit/01d648a42939c834b6b45677e54088b01c11 DIFF: https://github.com/llvm/llvm-project/commit/01d648a42939c834b6b45677e54088b01c11.diff

[clang] [HLSL][SPIRV] Reapply "[HLSL][SPIRV] Add vk::constant_id attribute." (PR #144902)

2025-06-19 Thread Steven Perron via cfe-commits
https://github.com/s-perron closed https://github.com/llvm/llvm-project/pull/144902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Declare workitem built-ins in clc, move ptx-nvidiacl workitem built-ins into clc (PR #144333)

2025-06-19 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: Is an issue here perhaps that downstream users may have implemented (e.g.) `get_global_offset` in their toolchains, but after this change they'll suddenly see a definition of this function that they're not expecting? I suppose they would have to implement CLC functions, like

[clang] [clang] NFC: introduce UnsignedOrNone as a replacement for std::optional (PR #134142)

2025-06-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Just noticed that this is not using `std::optional`. If this is good, why don't we put this to `llvm/ADT`? I feel that is a better place. https://github.com/llvm/llvm-project/pull/134142 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang][bytecode] Allocate IntegralAP and Floating types using an allocator (PR #144246)

2025-06-19 Thread David Spickett via cfe-commits
Timm =?utf-8?q?BĂ€der?= , Timm =?utf-8?q?BĂ€der?= Message-ID: In-Reply-To: DavidSpickett wrote: So after the fixup this failed again: https://lab.llvm.org/buildbot/#/builders/154/builds/17588 ``` TEST 'Clang :: AST/ByteCode/intap.cpp' FAILED Exit Code:

[clang] [CIR] Upstream support for builtin_vectorelements (PR #144877)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Add support for `__builtin_vectorelements` Issue https://github.com/llvm/llvm-project/issues/136487 --- Full diff: https://github.com/llvm/llvm-project/pull/144877.diff 3 Files Affected: - (modified) c

[clang] [llvm] Test 142948, please ignore (PR #144873)

2025-06-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum converted_to_draft https://github.com/llvm/llvm-project/pull/144873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for builtin_vectorelements (PR #144877)

2025-06-19 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/144877 Add support for `__builtin_vectorelements` Issue https://github.com/llvm/llvm-project/issues/136487 >From 3f07685e76c5ae3dda8c257cb3ac5b33e63ab9ea Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 19

[clang-tools-extra] [clang-tidy] Improve `readability-function-size`: count class member initializers as statements (PR #131669)

2025-06-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 unassigned https://github.com/llvm/llvm-project/pull/131669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve `readability-function-size`: count class member initializers as statements (PR #131669)

2025-06-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/131669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU][Driver] Add `avail-extern-gv-in-addrspace-to-local` option when ThinTLO is enabled (PR #144914)

2025-06-19 Thread Shilei Tian via cfe-commits
shiltian wrote: * **#144914** https://app.graphite.dev/github/pr/llvm/llvm-project/144914?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/144

[clang] [Clang][AMDGPU][Driver] Add `avail-extern-gv-in-addrspace-to-local` option when ThinTLO is enabled (PR #144914)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Shilei Tian (shiltian) Changes On AMDGPU, we need an extra argument `-avail-extern-gv-in-addrspace-to-local=3` to privatize LDS global variables when ThinLTO is enabled. --- Full diff: https://github.com/llvm/llvm-project/pull/14491

[clang] [Clang][AMDGPU][Driver] Add `avail-extern-gv-in-addrspace-to-local` option when ThinTLO is enabled (PR #144914)

2025-06-19 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/144914 On AMDGPU, we need an extra argument `-avail-extern-gv-in-addrspace-to-local=3` to privatize LDS global variables when ThinLTO is enabled. >From bf7b936421379ae7e043360c6515136660e2e550 Mon Sep 17 00:00:00 2001

[clang] [Clang][AMDGPU][Driver] Add `avail-extern-gv-in-addrspace-to-local` option when ThinTLO is enabled (PR #144914)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shilei Tian (shiltian) Changes On AMDGPU, we need an extra argument `-avail-extern-gv-in-addrspace-to-local=3` to privatize LDS global variables when ThinLTO is enabled. --- Full diff: https://github.com/llvm/llvm-project/pull/144914.diff

[clang] 36af734 - Reapply "[Clang] Enable -fextend-variable-liveness at -Og (#118026)"

2025-06-19 Thread Stephen Tozer via cfe-commits
Author: Stephen Tozer Date: 2025-06-19T16:22:50+01:00 New Revision: 36af7345dfb8e84a1f2971db34089b63321e8467 URL: https://github.com/llvm/llvm-project/commit/36af7345dfb8e84a1f2971db34089b63321e8467 DIFF: https://github.com/llvm/llvm-project/commit/36af7345dfb8e84a1f2971db34089b63321e8467.diff

[clang] [llvm] Ast importer visitors (PR #138838)

2025-06-19 Thread via cfe-commits
https://github.com/ganenkokb-yandex updated https://github.com/llvm/llvm-project/pull/138838 >From 6a4d62ce1c72639d7fe82565744b3e8808dce4c3 Mon Sep 17 00:00:00 2001 From: Evianaive <153540...@qq.com> Date: Tue, 25 Mar 2025 01:54:06 +0800 Subject: [PATCH 01/18] Implement missing visit function -

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-19 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-19 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] DRAFT: [flang][OpenMP] Remove experimental warning (PR #144915)

2025-06-19 Thread Tom Eccles via cfe-commits
https://github.com/tblah created https://github.com/llvm/llvm-project/pull/144915 RFC: https://discourse.llvm.org/t/rfc-removing-the-openmp-experimental-warning-for-llvm-21/86455 Fixes: #110008 There are a handful of open issues still to resolve before this can go out of draft. See the linke

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Nathan Gauër via cfe-commits
@@ -341,6 +341,13 @@ class SPIRVInstructionSelector : public InstructionSelector { GIntrinsic &HandleDef, MachineInstr &Pos) const; }; +bool sampledTypeIsSignedInteger(const llvm::Type *HandleType) { + const TargetExtType *TET = cast(HandleTy

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Nathan Gauër via cfe-commits
Keenuts wrote: This is not supposed to be merged no? https://github.com/llvm/llvm-project/pull/144774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-19 Thread zhijian lin via cfe-commits
@@ -7,5 +7,8 @@ tablegen(LLVM AArch64TargetParserDef.inc -gen-arm-target-def -I ${PROJECT_SOURCE set(LLVM_TARGET_DEFINITIONS ${PROJECT_SOURCE_DIR}/lib/Target/RISCV/RISCV.td) tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def -I ${PROJECT_SOURCE_DIR}/lib/Target/RISCV/

[clang] spec constant (PR #144902)

2025-06-19 Thread Nathan Gauër via cfe-commits
Keenuts wrote: You might want to change the PR title to add the tags etc https://github.com/llvm/llvm-project/pull/144902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Correctly handle lambda-converted function pointers (PR #144906)

2025-06-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: None (flovent) Changes For lambdas that are converted to C function pointers, ``` int (*ret_zero)() = []() { return 0; }; ``` clang will generate conversion method like: ``` CXXConversionDecl implicit used constexpr opera

[clang] spec constant (PR #144902)

2025-06-19 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts approved this pull request. https://github.com/llvm/llvm-project/pull/144902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/144774 >From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Wed, 18 Jun 2025 09:19:45 -0400 Subject: [PATCH] [HLSL][SPRIV] Handle sign RWBuffer correctly MIME-Version: 1.0

[clang] [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (PR #140532)

2025-06-19 Thread Walter J.T.V via cfe-commits
eZWALT wrote: Thank you so much @Meinersbur ! https://github.com/llvm/llvm-project/pull/140532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Correctly handle lambda-converted function pointers (PR #144906)

2025-06-19 Thread via cfe-commits
https://github.com/flovent created https://github.com/llvm/llvm-project/pull/144906 For lambdas that are converted to C function pointers, ``` int (*ret_zero)() = []() { return 0; }; ``` clang will generate conversion method like: ``` CXXConversionDecl implicit used constexpr operator int (*)()

[clang] [Clang] Enable -fextend-variable-liveness at -Og (PR #118026)

2025-06-19 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/118026 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Enable -fextend-variable-liveness at -Og (PR #118026)

2025-06-19 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/118026 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

2025-06-19 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/143792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

2025-06-19 Thread Yaxun Liu via cfe-commits
@@ -743,9 +743,11 @@ void Linux::AddHIPRuntimeLibArgs(const ArgList &Args, Args.MakeArgString(StringRef("-L") + RocmInstallation->getLibPath())); if (Args.hasFlag(options::OPT_frtlib_add_rpath, - options::OPT_fno_rtlib_add_rpath, false)) -CmdArgs.

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-19 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/144745 >From 50c418d4259ac5039d9ab7532afd518a0cfbbc64 Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Mon, 16 Jun 2025 11:09:23 -0700 Subject: [PATCH 1/5] Fix IP2State tables --- .../CodeGenCXX/microsoft-abi-eh-a

[clang] [NFC][Clang][AST] Adopt simplified `getTrailingObjects` in AST (PR #144432)

2025-06-19 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/144432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Allocate IntegralAP and Floating types using an allocator (PR #144246)

2025-06-19 Thread David Spickett via cfe-commits
Timm =?utf-8?q?BĂ€der?= , Timm =?utf-8?q?BĂ€der?= Message-ID: In-Reply-To: DavidSpickett wrote: Short of cross-compiling, a debug build isn't happening. I know so far is that the last thing it attempts to do is construct an APInt with: ``` Bitwidth: 2, val: 0xffe64100 ``` We need to fi

[clang] [NFC][Clang][AST] Adopt simplified `getTrailingObjects` in AST (PR #144432)

2025-06-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/144432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Steven Perron via cfe-commits
https://github.com/s-perron edited https://github.com/llvm/llvm-project/pull/144774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][AST] Adopt simplified `getTrailingObjects` in AST (PR #144432)

2025-06-19 Thread Rahul Joshi via cfe-commits
@@ -388,9 +387,7 @@ template class OMPDirectiveListClause : public OMPClause { assert( DK.size() == NumKinds && "Number of directive kinds is not the same as the preallocated buffer"); -std::copy(DK.begin(), DK.end(), - static_cast(this)

[clang] 5cf7d87 - [NFC][Clang][AST] Adopt simplified `getTrailingObjects` in AST (#144432)

2025-06-19 Thread via cfe-commits
Author: Rahul Joshi Date: 2025-06-19T09:25:04-07:00 New Revision: 5cf7d871b030212d021ffc9356620551f09ad402 URL: https://github.com/llvm/llvm-project/commit/5cf7d871b030212d021ffc9356620551f09ad402 DIFF: https://github.com/llvm/llvm-project/commit/5cf7d871b030212d021ffc9356620551f09ad402.diff L

[clang] c0cc81c - [NFC][Clang] Adopt simplified `getTrailingObjects` in ASTReader (#144438)

2025-06-19 Thread via cfe-commits
Author: Rahul Joshi Date: 2025-06-19T09:25:32-07:00 New Revision: c0cc81cdc03c97473ba771bbc3a2330bd22396bc URL: https://github.com/llvm/llvm-project/commit/c0cc81cdc03c97473ba771bbc3a2330bd22396bc DIFF: https://github.com/llvm/llvm-project/commit/c0cc81cdc03c97473ba771bbc3a2330bd22396bc.diff L

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in ASTReader (PR #144438)

2025-06-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/144438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Add option -msve-streaming-vector-bits= . (PR #144611)

2025-06-19 Thread Eli Friedman via cfe-commits
@@ -1034,9 +1034,16 @@ class TargetInfo : public TransferrableTargetInfo, /// set of primary and secondary targets. virtual llvm::SmallVector getTargetBuiltins() const = 0; + enum class ArmStreamingKind { +NotStreaming, +StreamingCompatible, +Streaming, + };

[clang] [llvm] [HLSL][SPRIV] Handle signed RWBuffer correctly (PR #144774)

2025-06-19 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/144774 >From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Wed, 18 Jun 2025 09:19:45 -0400 Subject: [PATCH 1/3] [HLSL][SPRIV] Handle sign RWBuffer correctly MIME-Version:

[clang] let Neon builtin function accept a const variable (PR #144625)

2025-06-19 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The NEON intrinsics specification (https://developer.arm.com/architectures/instruction-sets/intrinsics/vshl_n_s64) specifically says the argument must be an immediate in the specified range. That's because it's supposed to map to an instruction which encodes the shift am

<    1   2   3   >