[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-18 Thread Alex Voicu via cfe-commits
@@ -9102,6 +9102,15 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); +// __amdgpu_feature_predicate_t can be explicitly cast to the logical op +// type, although this is almost always an error a

[clang] [clang][NFCI] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/144728 None >From da1523ec3b68d3d2a23f502df779c7e3f54320d0 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 18 Jun 2025 08:33:25 -0700 Subject: [PATCH] [clang][NFCI] Use TargetInfo to determine device kernel c

[clang] [clang][headers]Remove unnecessary guard of !defined(__SCE__). (PR #144522)

2025-06-18 Thread Ying Yi via cfe-commits
https://github.com/MaggieYingYi closed https://github.com/llvm/llvm-project/pull/144522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-18 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/139566 >From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Mon, 12 May 2025 07:25:57 -0700 Subject: [PATCH 01/11] [win][clang] Align scalar deleting destructor

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

2025-06-18 Thread Ying Yi via cfe-commits
MaggieYingYi wrote: Thanks @lei137, I am working on fixing the test. https://github.com/llvm/llvm-project/pull/143614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-18 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/139566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-18 Thread Mariya Podchishchaeva via cfe-commits
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl { return getCanonicalDecl()->OperatorDelete; } + const FunctionDecl *getOperatorGlobalDelete() const { +return getCanonicalDecl()->OperatorGlobalDelete; + } + + void setOperatorGlobalDelete(Func

[clang] [flang] [mlir] [flang][flang-driver][mlir][OpenMP] atomic control support (PR #143441)

2025-06-18 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz commented: Please remove 'amdgpu' from variable and function names. These options may be useful for other targets as well. https://github.com/llvm/llvm-project/pull/143441 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-18 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/139566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-18 Thread Aaron Ballman via cfe-commits
@@ -9102,6 +9102,15 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); +// __amdgpu_feature_predicate_t can be explicitly cast to the logical op +// type, although this is almost always an error a

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/AST/DeclCXX.h clang/include/cla

[clang] Fix tests failing on fuchsia clang x86_64 builders (PR #144655)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Garvit Gupta (quic-garvgupt) Changes Fuchsia sets CLANG_DEFAULT_UNWINDLIB to libunwind. As a result, when rtlib is set to libgcc and unwindlib is not explicitly specified, tests using Fuchsia as the default platform will fail. To address

[clang] Fix tests failing on fuchsia clang x86_64 builders (PR #144655)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Garvit Gupta (quic-garvgupt) Changes Fuchsia sets CLANG_DEFAULT_UNWINDLIB to libunwind. As a result, when rtlib is set to libgcc and unwindlib is not explicitly specified, tests using Fuchsia as the default platform will fail. To a

[clang] [clang][headers]Remove unnecessary guard of !defined(__SCE__). (PR #144522)

2025-06-18 Thread Ying Yi via cfe-commits
MaggieYingYi wrote: Thanks @phoebewang. https://github.com/llvm/llvm-project/pull/144522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #144640)

2025-06-18 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: Fix for tests failing on https://lab.llvm.org/buildbot/#/builders/11 - https://github.com/llvm/llvm-project/pull/144655 https://github.com/llvm/llvm-project/pull/144640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-18 Thread Anatoly Trosinenko via cfe-commits
https://github.com/atrosinenko edited https://github.com/llvm/llvm-project/pull/143230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-18 Thread Sirui Mu via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ // CallOp //===--===// +def SE_All : I32EnumAttrCase<"All", 1, "all">; +def SE_Pure : I32EnumAttrCase<"Pure", 2, "pure">; +def SE_Const : I32EnumAttrCase<"

[clang] [Analysis] Avoid some warnings about exit from noreturn function (PR #144408)

2025-06-18 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff updated https://github.com/llvm/llvm-project/pull/144408 >From baedd4867ba8f62b54ea9942d84fadc9a716dc02 Mon Sep 17 00:00:00 2001 From: Serge Pavlov Date: Mon, 16 Jun 2025 18:19:44 +0700 Subject: [PATCH 1/3] [Analysis] Avoid some warnings about exit from noreturn fun

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-18 Thread via cfe-commits
@@ -219,6 +219,11 @@ Changes in existing checks tolerating fix-it breaking compilation when functions is used as pointers to avoid matching usage of functions within the current compilation unit. +- Improved :doc: `bugprone-sizeof-expression EugeneZelenko

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-18 Thread via cfe-commits
@@ -219,6 +219,11 @@ Changes in existing checks tolerating fix-it breaking compilation when functions is used as pointers to avoid matching usage of functions within the current compilation unit. +- Improved :doc: `bugprone-sizeof-expression + ` check by adding ---

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/144745 >From 50c418d4259ac5039d9ab7532afd518a0cfbbc64 Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Mon, 16 Jun 2025 11:09:23 -0700 Subject: [PATCH 1/4] Fix IP2State tables --- .../CodeGenCXX/microsoft-abi-eh-a

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-18 Thread Alex Voicu via cfe-commits
@@ -9102,6 +9102,15 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); +// __amdgpu_feature_predicate_t can be explicitly cast to the logical op +// type, although this is almost always an error a

[clang] [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #121829)

2025-06-18 Thread Petr Hosek via cfe-commits
petrhosek wrote: > > > Do the fuchsia builders actually produce output on a failure? We seem to > > > just get exit code 1, but no indication of what filecheck had problems > > > with. > > > > > > They do; here's a link! Let me know if you have an problems with the Web > > UI; I can paste th

[clang] [CIR] Implement folder for VecSplatOp (PR #143771)

2025-06-18 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/143771 >From 301cfa7c4325c50185b3b6e2665dab467078d9f4 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Wed, 11 Jun 2025 20:50:26 +0200 Subject: [PATCH] [CIR] Implement folder for VecSplatOp --- .../CIR/Dialect/

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

2025-06-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/144583 >From 80cd92fd1ea93a2f1c1b037d3a5354ee94f565f6 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 16 Jun 2025 16:39:15 -0700 Subject: [PATCH 1/3] [CIR] Add support for member initialization from construct

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

2025-06-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/144583 >From 389f3d95239c28415a95696cc7645e3399a5d9ab Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 16 Jun 2025 16:39:15 -0700 Subject: [PATCH 1/2] [CIR] Add support for member initialization from construct

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-18 Thread zhijian lin via cfe-commits
@@ -190,6 +192,31 @@ insertWaveSizeFeature(StringRef GPU, const Triple &T, StringMap &Features); } // namespace AMDGPU + +struct BasicSubtargetFeatureKV { + const char *Key; ///< K-V key string + unsigned Value; ///< K-V integer value +

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-18 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-18 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-18 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-18 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-cleaner] Add POSIX symbol mappings (PR #144748)

2025-06-18 Thread Ildikó Cseri via cfe-commits
cseriildi wrote: Hi @kadircet, We noticed you’ve been involved in this area, so we thought this PR might be of interest to you. https://github.com/llvm/llvm-project/pull/144748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Modules] Record whether VarDecl initializers contain side effects (PR #143739)

2025-06-18 Thread Ben Langmuir via cfe-commits
@@ -1259,6 +1259,7 @@ void ASTDeclWriter::VisitVarDecl(VarDecl *D) { VarDeclBits.addBit(D->isConstexpr()); VarDeclBits.addBit(D->isInitCapture()); VarDeclBits.addBit(D->isPreviousDeclInSameBlockScope()); +VarDeclBits.addBit(D->hasInitWithSideEffects());

[clang] [include-cleaner] Add POSIX symbol mappings (PR #144748)

2025-06-18 Thread Ildikó Cseri via cfe-commits
https://github.com/cseriildi edited https://github.com/llvm/llvm-project/pull/144748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [flang][AArch64] Always link compiler-rt to flang after libgcc (PR #144710)

2025-06-18 Thread David Truby via cfe-commits
DavidTruby wrote: Looks like the pre-commit CI has compiler-rt in LLVM_ENABLE_PROJECTS. I thought that wasn't supported anymore? Anyways I guess I have to add a check that it's not in ENABLE_PROJECTS as well as ENABLE_RUNTIMES https://github.com/llvm/llvm-project/pull/144710 __

[clang] Revert "Add missing intrinsics to cuda headers" (PR #144755)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Artem Belevich (Artem-B) Changes Reverts llvm/llvm-project#143664 as it breaks CUDA compilation. --- Full diff: https://github.com/llvm/llvm-project/pull/144755.diff 1 Files Affected: - (modified) clang/lib/Headers/__clang_cuda_in

[clang] Revert "Add missing intrinsics to cuda headers" (PR #144755)

2025-06-18 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B created https://github.com/llvm/llvm-project/pull/144755 Reverts llvm/llvm-project#143664 as it breaks CUDA compilation. >From 2ed0932a540bb1a692fe442ab590d51674645f6c Mon Sep 17 00:00:00 2001 From: Artem Belevich Date: Wed, 18 Jun 2025 10:06:56 -0700 Subject: [PATCH

[clang] Add missing intrinsics to cuda headers (PR #143664)

2025-06-18 Thread Artem Belevich via cfe-commits
Artem-B wrote: It appears to be breaking CUDA tests: https://lab.llvm.org/buildbot/#/builders/69/builds/22559 I'll revert it for now and we'll try again later. ``` [29/988] Building CXX object External/CUDA/CMakeFiles/math_h-cuda-11.8-c++98-libstdc++-10.dir/math_h.cu.o FAILED: External/CUDA/

[clang-tools-extra] [clang-doc] mangle specialization file names (PR #144617)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) Changes Currently, class template specializations are written to the same file as the template. This presents a problem in JSON since only one JSON object should be written per file. This patch adds a man

[clang] [flang] [llvm] [flang][AArch64] Always link compiler-rt to flang after libgcc (PR #144710)

2025-06-18 Thread David Truby via cfe-commits
@@ -653,6 +653,13 @@ if(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD STREQUAL "all") set(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD ${LLVM_ALL_EXPERIMENTAL_TARGETS}) endif() +if("flang" IN_LIST LLVM_ENABLE_PROJECTS AND + "AArch64" IN_LIST LLVM_TARGETS_TO_BUILD AND + NOT "compiler-rt" IN_

[clang] [clang][NFCI] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Alexey Bader via cfe-commits
@@ -103,11 +103,11 @@ TargetCodeGenInfo::getDependentLibraryOption(llvm::StringRef Lib, Opt += Lib; } -unsigned TargetCodeGenInfo::getOpenCLKernelCallingConv() const { - // OpenCL kernels are called via an explicit runtime API with arguments - // set with clSetKernelArg()

[clang] [clang][NFCI] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-18 Thread Alex Voicu via cfe-commits
@@ -9102,6 +9102,15 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); +// __amdgpu_feature_predicate_t can be explicitly cast to the logical op +// type, although this is almost always an error a

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

2025-06-18 Thread Siu Chi Chan via cfe-commits
https://github.com/scchan updated https://github.com/llvm/llvm-project/pull/143792 >From 9c60ee7b47c3b0f1bea492aafc0413bc73702f1e Mon Sep 17 00:00:00 2001 From: Siu Chi Chan Date: Wed, 11 Jun 2025 17:18:42 -0400 Subject: [PATCH] [HIP] Remove dots in HIP runtime path Remove the dots in the HIP

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

2025-06-18 Thread Siu Chi Chan via cfe-commits
https://github.com/scchan updated https://github.com/llvm/llvm-project/pull/143792 >From 62e627e4b8e68284668ad719d4c717fcd08fad45 Mon Sep 17 00:00:00 2001 From: Siu Chi Chan Date: Wed, 11 Jun 2025 17:18:42 -0400 Subject: [PATCH] [HIP] Remove dots in HIP runtime path Remove the dots in the HIP

[clang] [HLSL][SPIRV] Add vk::constant_id attribute. (PR #143544)

2025-06-18 Thread Steven Perron via cfe-commits
s-perron wrote: https://lab.llvm.org/buildbot/#/builders/24/builds/9606 https://github.com/llvm/llvm-project/pull/143544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [libc++][Clang] Added explanation why is_constructible evaluated to false. Updated the diagnostics checks in libc++ tests. (PR #144220)

2025-06-18 Thread Ross Kirsling via cfe-commits
@@ -1767,7 +1767,8 @@ def note_unsatisfied_trait : Note<"%0 is not %enum_select{" "%TriviallyRelocatable{trivially relocatable}|" "%Replaceable{replaceable}|" - "%TriviallyCopyable{trivially copyable}" + "%TriviallyCopyable{triviall

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

2025-06-18 Thread Siu Chi Chan via cfe-commits
@@ -743,9 +743,12 @@ void Linux::AddHIPRuntimeLibArgs(const ArgList &Args, Args.MakeArgString(StringRef("-L") + RocmInstallation->getLibPath())); if (Args.hasFlag(options::OPT_frtlib_add_rpath, - options::OPT_fno_rtlib_add_rpath, false)) +

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

2025-06-18 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/144746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [Clang][PowerPC] Add __dmr1024 type and DMF integer calculation builtins (PR #142480)

2025-06-18 Thread Maryam Moghadas via cfe-commits
@@ -0,0 +1,94 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -O3 -triple powerpc64le-unknown-unknown -target-cpu future \ +// RUN: -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -O3 -triple powerpc64-ibm-aix -target-cp

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-18 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/143205 >From 52e4413ea1e701dfe0b24cf957a26bb72732f066 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Wed, 21 May 2025 16:06:44 -0700 Subject: [PATCH 1/8] Place holder message for sizeof operator in loops. --

[clang] [CIR] Add initial support for bitfields in structs (PR #142041)

2025-06-18 Thread via cfe-commits
@@ -223,21 +272,114 @@ void CIRRecordLowering::fillOutputFields() { fieldTypes.size() - 1; // A field without storage must be a bitfield. assert(!cir::MissingFeatures::bitfields()); + if (!member.data) +setBitFieldInfo(member.fieldDecl, memb

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-18 Thread Anatoly Trosinenko via cfe-commits
@@ -83,7 +83,13 @@ __llvm_profile_iterate_data(const __llvm_profile_data *Data) { /* This method is only used in value profiler mock testing. */ COMPILER_RT_VISIBILITY void * __llvm_get_function_addr(const __llvm_profile_data *Data) { - return Data->FunctionPointer; + void

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread Eli Friedman via cfe-commits
@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-18 Thread Anatoly Trosinenko via cfe-commits
@@ -61,10 +62,10 @@ struct _LIBCXXABI_HIDDEN __cxa_exception { int propagationCount; #else int handlerSwitchValue; -const unsigned char *actionRecord; -const unsigned char *languageSpecificData; -void *catchTemp; -void *adjustedPtr; +const unsigned c

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-18 Thread Anatoly Trosinenko via cfe-commits
@@ -238,7 +282,20 @@ COMPILER_RT_ABI _Unwind_Reason_Code __gcc_personality_v0( _Unwind_SetGR(context, __builtin_eh_return_data_regno(0), (uintptr_t)exceptionObject); _Unwind_SetGR(context, __builtin_eh_return_data_regno(1), 0); - _Unwind_Set

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread Eli Friedman via cfe-commits
@@ -101,7 +101,8 @@ define void @f5() "frame-pointer"="all" { ; CHECK-NEXT:.seh_endprologue ; CHECK-NEXT:leaq -92(%rbp), %rcx ; CHECK-NEXT:callq external -; CHECK-NEXT:nop +; UEFI does not have SEH, so does not require NOP +; WIN64-NEXT:nop

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread Eli Friedman via cfe-commits
@@ -9,7 +9,6 @@ define i32 @foobar() gc "statepoint-example" personality ptr @__gxx_personality_ ; CHECK-NEXT:.seh_endprologue ; CHECK-NEXT:callq bar ; CHECK-NEXT: .Ltmp0: -; CHECK-NEXT:nop efriedma-quic wrote: This makes the call adjacent to the

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,180 @@ +// RUN: %clang_cl -c --target=x86_64-windows-msvc /EHa -O2 /GS- \ +// RUN: -Xclang=-import-call-optimization \ +// RUN: /clang:-S /clang:-o- %s 2>&1 \ +// RUN: | FileCheck %s efriedma-quic wrote: `// REQUIRES: x86-registered-target` http

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-18 Thread Malavika Samak via cfe-commits
@@ -219,6 +219,11 @@ Changes in existing checks tolerating fix-it breaking compilation when functions is used as pointers to avoid matching usage of functions within the current compilation unit. +- Improved :doc: `bugprone-sizeof-expression malavikasamak

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-18 Thread Anatoly Trosinenko via cfe-commits
@@ -557,7 +596,19 @@ set_registers(_Unwind_Exception* unwind_exception, _Unwind_Context* context, reinterpret_cast(unwind_exception)); _Unwind_SetGR(context, __builtin_eh_return_data_regno(1), static_cast(results.ttypeIndex)); +#if defined(__A

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-18 Thread Anatoly Trosinenko via cfe-commits
@@ -47,10 +47,11 @@ struct _LIBCXXABI_HIDDEN __cxa_exception { // In Wasm, a destructor returns its argument void *(_LIBCXXABI_DTOR_FUNC *exceptionDestructor)(void *); #else -void (_LIBCXXABI_DTOR_FUNC *exceptionDestructor)(void *); +void(_LIBCXXABI_DTOR_FUNC*

[clang] [CIR] Add initial support for bitfields in structs (PR #142041)

2025-06-18 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/142041 >From 8f154d2c1fd9c646966aa07c9a292d253f9e59cc Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 29 May 2025 16:17:09 -0500 Subject: [PATCH 1/6] Add initial support for bitfields in structs and

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread Eli Friedman via cfe-commits
@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (PR #143614)

2025-06-18 Thread Ying Yi via cfe-commits
MaggieYingYi wrote: > I had created #144737 for code review. Fixed the issue. Bot https://lab.llvm.org/buildbot/#/builders/64/builds/4311 build successfully. https://github.com/llvm/llvm-project/pull/143614 ___ cfe-commits mailing list cfe-commits@li

[clang] [lldb] [Clang][PowerPC] Add __dmr1024 type and DMF integer calculation builtins (PR #142480)

2025-06-18 Thread Maryam Moghadas via cfe-commits
https://github.com/maryammo updated https://github.com/llvm/llvm-project/pull/142480 >From 5ef7a4ca7c2a838a6b2100968d5023e0797b2848 Mon Sep 17 00:00:00 2001 From: Maryam Moghadas Date: Mon, 2 Jun 2025 19:54:57 + Subject: [PATCH 1/4] [Clang][PowerPC] Add __dmr type and DMF integer calculati

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread Reid Kleckner via cfe-commits
rnk wrote: > The entries in the IP2State table contain byte offsets within the instruction > stream of the function. The Windows ABI requires that these offsets are > aligned to instruction boundaries; they are not permitted to point to a byte > that is not the first byte of an instruction. >

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

2025-06-18 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/144746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

2025-06-18 Thread Maksim Ivanov via cfe-commits
https://github.com/emaxx-google created https://github.com/llvm/llvm-project/pull/144796 Change the ODR hashing logic to use the depth+index indices instead of template parameter names. This prevents spurious ODR errors in header module builds when the type canonicalization picks up different

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Maksim Ivanov (emaxx-google) Changes Change the ODR hashing logic to use the depth+index indices instead of template parameter names. This prevents spurious ODR errors in header module builds when the type canonicalization picks u

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Maksim Ivanov (emaxx-google) Changes Change the ODR hashing logic to use the depth+index indices instead of template parameter names. This prevents spurious ODR errors in header module builds when the type canonicalization picks up differ

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

2025-06-18 Thread Maksim Ivanov via cfe-commits
@@ -5164,6 +5164,29 @@ namespace A { A::X x; #endif +namespace TemplateDecltypeOperator { + +#if defined(FIRST) || defined(SECOND) +template +T6 func(); +#endif + +#if defined(SECOND) +template +using UnrelatedAlias = decltype(func())(); +#endif + +#if defined(FIRST) || defi

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread via cfe-commits
sivadeilra wrote: @mk No offense intended, of course. I'm happy to change the commit text / comments. What would you suggest? The Windows ABI is vast enough that a lot of it is poorly-documented, or has deeper invariants that are not documented. The requirement that IP2State boundaries alig

[clang] [CIR] Add initial support for bitfields in structs (PR #142041)

2025-06-18 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM once all existing comments are addressed. https://github.com/llvm/llvm-project/pull/142041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [CIR] Implement folder for VecSplatOp (PR #143771)

2025-06-18 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. https://github.com/llvm/llvm-project/pull/143771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread via cfe-commits
@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread via cfe-commits
@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

2025-06-18 Thread Andrew Rogers via cfe-commits
https://github.com/andrurogerz edited https://github.com/llvm/llvm-project/pull/144746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Andrew Rogers (andrurogerz) Changes ## Purpose This patch is one in a series of code-mods that annotate LLVM’s public interface for export. This patch annotates the remaining LLVM interface that was missed in, or modified since, prev

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-globalisel @llvm/pr-subscribers-clang Author: Andrew Rogers (andrurogerz) Changes ## Purpose This patch is one in a series of code-mods that annotate LLVM’s public interface for export. This patch annotates the remaining LLVM interface that was m

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

2025-06-18 Thread Andrew Rogers via cfe-commits
andrurogerz wrote: @compnerd, @vgvassilev other than the annotations for llvm-c and Demangle libraries, which require new annotation macros, this is the bulk of the remaining annotation code-mod. Please review at your convenience, thanks! https://github.com/llvm/llvm-project/pull/144746 __

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

2025-06-18 Thread Andrew Rogers via cfe-commits
https://github.com/andrurogerz ready_for_review https://github.com/llvm/llvm-project/pull/144746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-cleaner] Update generated include mappings (PR #144751)

2025-06-18 Thread Ildikó Cseri via cfe-commits
https://github.com/cseriildi updated https://github.com/llvm/llvm-project/pull/144751 From eabf81f66a57e099139a579d1955195055a6f75b Mon Sep 17 00:00:00 2001 From: Ildiko Cseri Date: Wed, 18 Jun 2025 12:58:34 + Subject: [PATCH] [include-cleaner] Update generated include mappings Update gene

[clang] [include-cleaner] Add POSIX symbol mappings (PR #144748)

2025-06-18 Thread Ildikó Cseri via cfe-commits
https://github.com/cseriildi updated https://github.com/llvm/llvm-project/pull/144748 From c4681dfa8da9ba90418525f32a3d1968366174d2 Mon Sep 17 00:00:00 2001 From: Ildiko Cseri Date: Wed, 18 Jun 2025 12:58:34 + Subject: [PATCH] [include-cleaner] Add POSIX symbol mappings Add POSIX symbol-to

[clang-tools-extra] [clang-doc] mangle specialization file names (PR #144617)

2025-06-18 Thread Erick Velez via cfe-commits
https://github.com/evelez7 ready_for_review https://github.com/llvm/llvm-project/pull/144617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSignature] Plug-in serialization and add full sample testcase (PR #144769)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Finn Plummer (inbelic) Changes This pr extends `dumpRootElements` to invoke the print methods of all `RootElement`s now that they are all implemented. Extends the `RootSignatures-AST.hlsl` testcase to have a root element of each type bei

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-18 Thread Malavika Samak via cfe-commits
@@ -164,6 +164,53 @@ int Test2(MyConstChar* A) { return sum; } +struct A { + int array[10]; +}; + +struct B { + struct A a; +}; + +void loop_access_elements(int num, struct B b) { +struct A arr[10]; +char buf[20]; + +// CHECK-MESSAGES: :[[@LINE+1]]:5: warning:

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/144728 >From da1523ec3b68d3d2a23f502df779c7e3f54320d0 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 18 Jun 2025 08:33:25 -0700 Subject: [PATCH 1/2] [clang][NFCI] Use TargetInfo to determine device kernel cal

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
@@ -103,11 +103,11 @@ TargetCodeGenInfo::getDependentLibraryOption(llvm::StringRef Lib, Opt += Lib; } -unsigned TargetCodeGenInfo::getOpenCLKernelCallingConv() const { - // OpenCL kernels are called via an explicit runtime API with arguments - // set with clSetKernelArg()

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-18 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/143205 >From 52e4413ea1e701dfe0b24cf957a26bb72732f066 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Wed, 21 May 2025 16:06:44 -0700 Subject: [PATCH 1/7] Place holder message for sizeof operator in loops. --

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-18 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks, go for it. This doesn't match the `-gen-x-target-def` pattern used for ARM, AArch64, and RISCV, but it's target-generic, which seems nice. https://github.com/llvm/llvm-project/pull/144594 ___

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread via cfe-commits
sivadeilra wrote: Updated most of the failing integration tests. There are 2 that merit investigation, which I'm doing now. https://github.com/llvm/llvm-project/pull/144745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-18 Thread Aaron Ballman via cfe-commits
@@ -9102,6 +9102,15 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); +// __amdgpu_feature_predicate_t can be explicitly cast to the logical op +// type, although this is almost always an error a

[clang] [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (PR #140532)

2025-06-18 Thread via cfe-commits
github-actions[bot] wrote: @eZWALT Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Alexey Bader via cfe-commits
@@ -103,11 +103,11 @@ TargetCodeGenInfo::getDependentLibraryOption(llvm::StringRef Lib, Opt += Lib; } -unsigned TargetCodeGenInfo::getOpenCLKernelCallingConv() const { - // OpenCL kernels are called via an explicit runtime API with arguments - // set with clSetKernelArg()

[clang] [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (PR #140532)

2025-06-18 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur closed https://github.com/llvm/llvm-project/pull/140532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8c3fbaf - [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (#140532)

2025-06-18 Thread via cfe-commits
Author: Walter J.T.V Date: 2025-06-18T20:52:41+02:00 New Revision: 8c3fbaf0ee7322e948403d2234a7230bd6137c98 URL: https://github.com/llvm/llvm-project/commit/8c3fbaf0ee7322e948403d2234a7230bd6137c98 DIFF: https://github.com/llvm/llvm-project/commit/8c3fbaf0ee7322e948403d2234a7230bd6137c98.diff

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-18 Thread via cfe-commits
sivadeilra wrote: Investigated remaining tests and fixed. https://github.com/llvm/llvm-project/pull/144745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (PR #140532)

2025-06-18 Thread Michael Kruse via cfe-commits
Meinersbur wrote: > Well yes but i don't have enough permissions to merge. I didn't know. Additional changes are find, I just merged it. Thanks for the patch. https://github.com/llvm/llvm-project/pull/140532 ___ cfe-commits mailing list cfe-commits@l

<    1   2   3   4   >