[clang-tools-extra] [clang-reorder-fields] Prevent rewriting unsupported cases (PR #142149)

2025-06-17 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov edited https://github.com/llvm/llvm-project/pull/142149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-reorder-fields] Prevent rewriting unsupported cases (PR #142149)

2025-06-17 Thread Alexander Shaposhnikov via cfe-commits
@@ -50,6 +51,63 @@ static const RecordDecl *findDefinition(StringRef RecordName, return selectFirst("recordDecl", Results); } +static bool isSafeToRewrite(const RecordDecl *Decl, const ASTContext &Context) { + // All following checks expect at least one field declaration.

[clang-tools-extra] [clang-reorder-fields] Prevent rewriting unsupported cases (PR #142149)

2025-06-17 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov edited https://github.com/llvm/llvm-project/pull/142149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Non constant size and offset in DWARF (PR #141106)

2025-06-17 Thread David Blaikie via cfe-commits
@@ -4822,6 +4822,35 @@ struct MDSignedOrMDField : MDEitherFieldImpl { } }; +struct MDUnsignedOrMDField : MDEitherFieldImpl { + MDUnsignedOrMDField(uint64_t Default = 0, bool AllowNull = true) + : ImplTy(MDUnsignedField(Default), MDField(AllowNull)) {} + + MDUnsignedO

[clang] [llvm] Non constant size and offset in DWARF (PR #141106)

2025-06-17 Thread David Blaikie via cfe-commits
@@ -834,8 +834,8 @@ llvm::DIType *CGDebugInfo::CreateType(const BuiltinType *BT) { auto *ISATy = DBuilder.createPointerType(ClassTy, Size); ObjTy = DBuilder.createStructType(TheCU, "objc_object", TheCU->getFile(), 0, - 0, 0, llvm:

[clang] [llvm] Non constant size and offset in DWARF (PR #141106)

2025-06-17 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. https://github.com/llvm/llvm-project/pull/141106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread zhijian lin via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/144594 >From 2d0f536bdc6fc24f09053569a8c84056ffc31e0d Mon Sep 17 00:00:00 2001 From: zhijian lin Date: Thu, 12 Jun 2025 13:38:13 -0400 Subject: [PATCH 1/3] [PowerPC] frontend get target feature from backend with cp

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-17 Thread Alex Voicu via cfe-commits
@@ -9102,6 +9102,15 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); +// __amdgpu_feature_predicate_t can be explicitly cast to the logical op +// type, although this is almost always an error a

[clang] [llvm] Non constant size and offset in DWARF (PR #141106)

2025-06-17 Thread David Blaikie via cfe-commits
@@ -1525,15 +1525,24 @@ Error MetadataLoader::MetadataLoaderImpl::parseOneMetadata( if (Record.size() < 6 || Record.size() > 8) return error("Invalid record"); -IsDistinct = Record[0]; +IsDistinct = Record[0] & 1; +bool SizeIsMetadata = Record[0] & 2;

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Nick Sarnie via cfe-commits
@@ -417,3 +417,17 @@ void HIPAMDToolChain::checkTargetID( getDriver().Diag(clang::diag::err_drv_bad_target_id) << *PTID.OptionalTargetID; } + +SPIRVAMDToolChain::SPIRVAMDToolChain(const Driver &D, + const llvm::Triple &Triple, +

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Joseph Huber via cfe-commits
@@ -417,3 +417,17 @@ void HIPAMDToolChain::checkTargetID( getDriver().Diag(clang::diag::err_drv_bad_target_id) << *PTID.OptionalTargetID; } + +SPIRVAMDToolChain::SPIRVAMDToolChain(const Driver &D, + const llvm::Triple &Triple, +

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Bruno Cardoso Lopes via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ // CallOp //===--===// +def SE_All : I32EnumAttrCase<"All", 1, "all">; +def SE_Pure : I32EnumAttrCase<"Pure", 2, "pure">; +def SE_Const : I32EnumAttrCase<"

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/144576 >From 92db44cf46098f9171b06d0251b632eb1ff6d5e6 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 17 Jun 2025 12:58:14 -0500 Subject: [PATCH] [Clang] Add standalone AMDGPU SPIR-V toolchain Summary: The AMDG

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. https://github.com/llvm/llvm-project/pull/144201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/144576 >From 94ad34a699173fe6b62614874952ca5cfe98f471 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 17 Jun 2025 12:58:14 -0500 Subject: [PATCH] [Clang] Add standalone AMDGPU SPIR-V toolchain Summary: The AMDG

[clang] [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (PR #121830)

2025-06-17 Thread via cfe-commits
Kewen12 wrote: Hi @quic-garvgupt, we are seeing llvm check errors with this PR that breaks our buildbots. Could you please take a look? Thanks! > FAIL: Clang::aarch64-toolchain.c FAIL: Clang::arm-toolchain.c bot: https://lab.llvm.org/buildbot/#/builders/10/builds/7529 https://github.com/llvm/

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Andy Kaylor via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ // CallOp //===--===// +def SE_All : I32EnumAttrCase<"All", 1, "all">; +def SE_Pure : I32EnumAttrCase<"Pure", 2, "pure">; +def SE_Const : I32EnumAttrCase<"

[clang] [CIR] Upstream ComplexRealPtrOp for ComplexType (PR #144235)

2025-06-17 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: > I have concerns about the CIR representation here. I think we should be > aligning our representation of complex operations with the MLIR complex > dialect ... We'll still need to go to the memory representation when it gets > lowered to LLVM IR, but I would like to keep

[clang] [Driver] Add option to force undefined symbols during linking in BareMetal toolchain object. (PR #132807)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/132807 >From 7f26ac995e18f71ec8bccdb5b39be95bf629da19 Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Mon, 24 Mar 2025 06:49:09 -0700 Subject: [PATCH] [Driver] Add option to force udnefined symbols during linki

[clang] [CIR] Handle global string literals as char array initializer (PR #144384)

2025-06-17 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. https://github.com/llvm/llvm-project/pull/144384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for __builtin_assume (PR #144376)

2025-06-17 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. Nice, LGTM https://github.com/llvm/llvm-project/pull/144376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #142166)

2025-06-17 Thread Vladislav Dzhidzhoev via cfe-commits
dzhidzhoev wrote: > How does this work for LTO? (we'd want all inlined instances to refer to a > singular abstract definition) Yeah, looks like that's broken (the abstract > origins are not shared - they're duplicated in every translation unit). But the notion of "abstract" subprogram pops up

[clang] 8cd05b8 - [NFC][HLSL] Move Sema work from `ParseMicrosoftRootSignatureAttributeArgs` (#143184)

2025-06-17 Thread via cfe-commits
Author: Finn Plummer Date: 2025-06-17T11:27:35-07:00 New Revision: 8cd05b88ec623018ca2c68cf2418d2beed026d27 URL: https://github.com/llvm/llvm-project/commit/8cd05b88ec623018ca2c68cf2418d2beed026d27 DIFF: https://github.com/llvm/llvm-project/commit/8cd05b88ec623018ca2c68cf2418d2beed026d27.diff

[clang] [NFC][HLSL] Move Sema work from `ParseMicrosoftRootSignatureAttributeArgs` (PR #143184)

2025-06-17 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/143184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Handle global string literals as char array initializer (PR #144384)

2025-06-17 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/144384 >From 815c01f5041c83c1612f49ee8ccda23c8eca16c8 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Fri, 13 Jun 2025 16:03:08 -0700 Subject: [PATCH 1/2] [CIR] Handle global string literals as char array initiali

[clang] [NFC][HLSL] Move Sema work from `ParseMicrosoftRootSignatureAttributeArgs` (PR #143184)

2025-06-17 Thread Finn Plummer via cfe-commits
inbelic wrote: @AaronBallman Thanks a lot for pointing it out and for the reviews, much appreciated https://github.com/llvm/llvm-project/pull/143184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang-tools-extra] [clang-tidy] Added bugprone-unsequenced-global-accesses check (PR #130421)

2025-06-17 Thread Baranov Victor via cfe-commits
vbvictor wrote: > Should I close this PR, and open a new one when I'm ready with the CSA > checker? To keep everything organized, I'd suggest creating a new branch for CSA checker and close this PR (you can always reopen it later). For the CSA part, you can start by reading [this developer g

[clang] [CIR] Upstream ComplexType builtin_complex (PR #144225)

2025-06-17 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/144225 >From 118f922e28117e31fb584bbaa2d5b9b68a78d009 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 14 Jun 2025 16:21:20 +0200 Subject: [PATCH 1/3] [CIR] Upstream ComplexType builtin_complex --- clang/l

[clang] [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (PR #121830)

2025-06-17 Thread Sam Elliott via cfe-commits
lenary wrote: @kewen12 I think I can see how to fix these tests, I'm just confused because these tests seem to end up requesting both compiler-rt and libgcc. Is that bot configured with a different default unwindlib to normal or something? https://github.com/llvm/llvm-project/pull/121830 _

[clang] [llvm] [PowerPC] frontend get target feature from backend with cpu name (PR #137670)

2025-06-17 Thread zhijian lin via cfe-commits
@@ -8,6 +8,12 @@ if (HAS_WERROR_GLOBAL_CTORS AND NOT LLVM_HAS_NOGLOBAL_CTOR_MUTEX) SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror=global-constructors") endif() +set(LLVM_TARGET_DEFINITIONS ${LLVM_MAIN_SRC_DIR}/lib/Target/PowerPC/PPC.td) + +tablegen(LLVM PPCGenSubtargetInfo

[clang] [llvm] [PowerPC] frontend get target feature from backend with cpu name (PR #137670)

2025-06-17 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/137670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread zhijian lin via cfe-commits
https://github.com/diggerlin created https://github.com/llvm/llvm-project/pull/144594 1. The PR proceeds with a backend target hook to allow front-ends to determine what target features are available in a compilation based on the CPU name. 2. Fix a backend target feature bug that supports HTM

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-tablegen Author: zhijian lin (diggerlin) Changes 1. The PR proceeds with a backend target hook to allow front-ends to determine what target features are available in a compilation based on the CPU name. 2. Fix a backend target feature bug that supports

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread zhijian lin via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/144594 >From 2d0f536bdc6fc24f09053569a8c84056ffc31e0d Mon Sep 17 00:00:00 2001 From: zhijian lin Date: Thu, 12 Jun 2025 13:38:13 -0400 Subject: [PATCH 1/2] [PowerPC] frontend get target feature from backend with cp

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,h,cpp -- llvm/utils/TableGen/Basic/EmitTargetFeature.cpp c

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread zhijian lin via cfe-commits
diggerlin wrote: the EmitTargetFeature.cpp will generated following content, I used PPC target as example: ``` // Autogenerated by TargetFeatureEmitter.cpp #ifdef GET_SUBTARGETFEATURES_ENUM #undef GET_SUBTARGETFEATURES_ENUM namespace llvm { namespace PPC { enum { AIXOS = 0, DeprecatedDST

[clang] [analyzer] Enforce not making overly complicated symbols (PR #144327)

2025-06-17 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > > > How I read this you have mainly 2 concerns: > > > > > > 1. The use of this strong-type makes it tedious the existing APIs to use > > > because one needs to unwrap the value and frequently make an early-return > > > to explicitly handle the case when a symbol-creation fai

[clang] [CIR] Handle global string literals as char array initializer (PR #144384)

2025-06-17 Thread Morris Hafner via cfe-commits
https://github.com/mmha approved this pull request. LGTM, just a request for three more test cases. I'm not sure if they work upstream already. If they don't, let's just skip over them for now. ```c++ char oversized[100] = "123"; char exact[4] = "123"; decltype(auto) returns_literal() { re

[clang] ed07b54 - [CIR][NFCI] Represent Complex RValues As Single Value (#144519)

2025-06-17 Thread via cfe-commits
Author: Morris Hafner Date: 2025-06-17T18:35:49+01:00 New Revision: ed07b54b38c675235b4ce1bfd49e1fff372f6520 URL: https://github.com/llvm/llvm-project/commit/ed07b54b38c675235b4ce1bfd49e1fff372f6520 DIFF: https://github.com/llvm/llvm-project/commit/ed07b54b38c675235b4ce1bfd49e1fff372f6520.diff

[clang] [CIR][NFCI] Represent Complex RValues As Single Value (PR #144519)

2025-06-17 Thread Morris Hafner via cfe-commits
https://github.com/mmha closed https://github.com/llvm/llvm-project/pull/144519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix link order of BareMetal toolchain object (PR #132806)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/132806 >From fa8aad1e9df9b21696fea33de4678a809a13367c Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Mon, 24 Mar 2025 06:17:42 -0700 Subject: [PATCH] [Driver] Fix link order of BareMetal toolchain object The

[clang] [CIR] Handle global string literals as char array initializer (PR #144384)

2025-06-17 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Emit the CUID value in the module with the new driver (PR #144570)

2025-06-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/144570 Summary: This is a weird point of divergence, which is also apparently critical for SPIR-V compilation not failing? Somehow if we don't emit this global than the `llvm.compiler.used` global uses AS(0) which makes

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-17 Thread Aaron Ballman via cfe-commits
@@ -9102,6 +9102,15 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); +// __amdgpu_feature_predicate_t can be explicitly cast to the logical op +// type, although this is almost always an error a

[clang] [llvm] Dump auto (c++11) type Inferences (Issue #17) (PR #144478)

2025-06-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: First off: thank you for the patch and trying to improve Clang! > Is it necessary to have this feature? Clangd already [supports > it](https://clangd.llvm.org/config.html#inlayhints). Also, Clang itself already has the ability to dump information about the AST: https://god

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/144576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 31523de - [Driver] Fix link order of BareMetal toolchain object (#132806)

2025-06-17 Thread via cfe-commits
Author: Garvit Gupta Date: 2025-06-17T23:43:07+05:30 New Revision: 31523de4b000ca254259ae3167d28922e1302648 URL: https://github.com/llvm/llvm-project/commit/31523de4b000ca254259ae3167d28922e1302648 DIFF: https://github.com/llvm/llvm-project/commit/31523de4b000ca254259ae3167d28922e1302648.diff

[clang] [Driver] Fix link order of BareMetal toolchain object (PR #132806)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt closed https://github.com/llvm/llvm-project/pull/132806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add option to force undefined symbols during linking in BareMetal toolchain object. (PR #132807)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt edited https://github.com/llvm/llvm-project/pull/132807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream ComplexType builtin_complex (PR #144225)

2025-06-17 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. I don't have anything else to add besides current reviews, LGTM once it's updated to incorporate the other landed change. https://github.com/llvm/llvm-project/pull/144225 ___ cfe-commits mai

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: > `ToolChain::UnwindLibType ToolChain::GetUnwindLibType( const ArgList &Args) > const { if (unwindLibType) return *unwindLibType; > > const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ); StringRef LibName > = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;` > > If --un

[clang] [LinkerWrapper] Fix 'save-temps' when targeting SPIR-V (PR #144605)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/144605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PAC] Support trivially_relocating polymorphic objects (PR #144420)

2025-06-17 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: If it's not a bitwise copy, it's by definition not a trivial relocation, so I don't think this works. I think you're arguing for some kind of intermediate "non-failing relocation" feature. Are we really reporting polymorphic class types as trivially reloc

[clang] 6fb36db - [LinkerWrapper] Fix 'save-temps' when targeting SPIR-V (#144605)

2025-06-17 Thread via cfe-commits
Author: Joseph Huber Date: 2025-06-17T16:16:37-05:00 New Revision: 6fb36db4818abde56e5da47899dcdaacd8293903 URL: https://github.com/llvm/llvm-project/commit/6fb36db4818abde56e5da47899dcdaacd8293903 DIFF: https://github.com/llvm/llvm-project/commit/6fb36db4818abde56e5da47899dcdaacd8293903.diff

[clang] [LinkerWrapper] Fix 'save-temps' when targeting SPIR-V (PR #144605)

2025-06-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/144605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[RISCV] Remove B and Zbc extension from Andes series cpus." (PR #144402)

2025-06-17 Thread Min-Yih Hsu via cfe-commits
mshockwave wrote: I also noticed that sometimes patches on CPU definitions somehow wasn't picked up by Clang in some of the CIs (usually ARC and SystemZ, IIRC). Even more confusingly, the SHA printed out from those Clangs showed that patch was correctly applied. Perhaps it was linking an old v

[clang] [llvm] [LLVM][IRBuilder] Use NUW arithmetic for Create{ElementCount,TypeSize}. (PR #143532)

2025-06-17 Thread Florian Hahn via cfe-commits
@@ -177,16 +177,16 @@ define void @add_unique_ind32(ptr noalias nocapture %a, i64 %n) { ; CHECK-LABEL: @add_unique_ind32( ; CHECK-NEXT: entry: ; CHECK-NEXT:[[TMP0:%.*]] = call i64 @llvm.vscale.i64() -; CHECK-NEXT:[[TMP1:%.*]] = shl i64 [[TMP0]], 2 +; CHECK-NEXT:[[

[clang] 4c8f434 - [analyzer] Conversion to CheckerFamily: NullabilityChecker (#143735)

2025-06-17 Thread via cfe-commits
Author: Donát Nagy Date: 2025-06-17T11:51:09+02:00 New Revision: 4c8f43440955c93a54b9547421513867bc81788a URL: https://github.com/llvm/llvm-project/commit/4c8f43440955c93a54b9547421513867bc81788a DIFF: https://github.com/llvm/llvm-project/commit/4c8f43440955c93a54b9547421513867bc81788a.diff LO

[clang] 576ced5 - [clang][bytecode] Simplify Block::replacePointer() (#144490)

2025-06-17 Thread via cfe-commits
Author: Timm Baeder Date: 2025-06-17T12:43:39+02:00 New Revision: 576ced56d78b48e658b0a170603388e4802f6311 URL: https://github.com/llvm/llvm-project/commit/576ced56d78b48e658b0a170603388e4802f6311 DIFF: https://github.com/llvm/llvm-project/commit/576ced56d78b48e658b0a170603388e4802f6311.diff L

[clang] 2d336e7 - [analyzer] Avoid contradicting assumption in tainted div-by-0 error node (#144491)

2025-06-17 Thread via cfe-commits
Author: Arseniy Zaostrovnykh Date: 2025-06-17T13:07:44+02:00 New Revision: 2d336e7c5e821383816a9dca080f713747cc9e1e URL: https://github.com/llvm/llvm-project/commit/2d336e7c5e821383816a9dca080f713747cc9e1e DIFF: https://github.com/llvm/llvm-project/commit/2d336e7c5e821383816a9dca080f713747cc9e1

[clang] 6f29837 - Reland: "[Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (#142409)" (#143614)

2025-06-17 Thread via cfe-commits
Author: Ying Yi Date: 2025-06-17T10:54:22+01:00 New Revision: 6f2983765983b9403ae40430da8034d2d1b6e8a4 URL: https://github.com/llvm/llvm-project/commit/6f2983765983b9403ae40430da8034d2d1b6e8a4 DIFF: https://github.com/llvm/llvm-project/commit/6f2983765983b9403ae40430da8034d2d1b6e8a4.diff LOG:

[clang] [Clang][Driver] Warn on complex number range incompatibility with GCC (PR #144468)

2025-06-17 Thread Shunsuke Watanabe via cfe-commits
@@ -520,6 +520,9 @@ def warn_drv_math_errno_enabled_after_veclib: Warning< "math errno enabled by '%0' after it was implicitly disabled by '%1'," " this may limit the utilization of the vector library">, InGroup; +def warn_drv_gcc_incompatible_complex_range_override: Warn

[clang] [llvm] [Clang][OpenMP] Non-contiguous strided update (PR #144635)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amit Tiwari (amitamd7) Changes This patch handles the strided update in the `#pragma omp target update from(data[a:b:c])` directive where 'c' represents the strided access leading to non-contiguous update in the `data` array when the offl

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 updated https://github.com/llvm/llvm-project/pull/140210 >From d1571dd53f157c9d4180c51e709d9bed0ba00136 Mon Sep 17 00:00:00 2001 From: ranapratap55 Date: Fri, 16 May 2025 12:50:09 +0530 Subject: [PATCH 1/2] [WIP][AMDGPU] Support for type inferring image load/stor

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable + +typedef int v8i __attribut

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable ranapratap55

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, return Builder.CreateInsertElement(I0, A, 1); } + case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: { +llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext()); +

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable + +typedef int v8i __attribut

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable + +typedef int v8i __attribut

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, return Builder.CreateInsertElement(I0, A, 1); } + case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: { +llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext()); +

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -635,5 +635,10 @@ TARGET_BUILTIN(__builtin_amdgcn_bitop3_b16, "IUi", "nc", "bitop3-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf16_f32, "V2yV2yfUiIb", "nc", "f32-to-f16bf16-cvt-sr-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_f16_f32, "V2hV2hfUiIb", "nc", "f32-to-

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -635,5 +635,10 @@ TARGET_BUILTIN(__builtin_amdgcn_bitop3_b16, "IUi", "nc", "bitop3-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf16_f32, "V2yV2yfUiIb", "nc", "f32-to-f16bf16-cvt-sr-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_f16_f32, "V2hV2hfUiIb", "nc", "f32-to-

[clang-tools-extra] [clang-tidy] add new check: modernize-use-scoped-lock (PR #126434)

2025-06-17 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/126434 >From 81a21a90e03e4b9cea58d6bcffddf3bde0f82710 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Mon, 3 Mar 2025 09:25:03 +0300 Subject: [PATCH 01/12] [clang-tidy] add scoped-lock-check --- .../clang-tidy/m

[clang] Reland [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #144640)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt edited https://github.com/llvm/llvm-project/pull/144640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #121829)

2025-06-17 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: > > Do the fuchsia builders actually produce output on a failure? We seem to > > just get exit code 1, but no indication of what filecheck had problems with. > > They do; here's a link! Let me know if you have an problems with the Web UI; > I can paste things here if so.

[clang-tools-extra] [clang-tidy] add new check: modernize-use-scoped-lock (PR #126434)

2025-06-17 Thread Baranov Victor via cfe-commits
vbvictor wrote: Rebased + ping @PiotrZSL. I'd merge it at the end of the month if there would be no more reviews. https://github.com/llvm/llvm-project/pull/126434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang][PAC] Support trivially_relocating polymorphic objects (PR #144420)

2025-06-17 Thread Corentin Jabot via cfe-commits
@@ -4467,17 +4467,25 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__builtin_trivially_relocate: case Builtin::BImemmove: case Builtin::BI__builtin_memmove: { +QualType CopiedType = E->getArg(0)->getType()->getPoi

[clang] [llvm] [Clang][OpenMP] Non-contiguous strided update (PR #144635)

2025-06-17 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [Clang][OpenMP] Non-contiguous strided update (PR #144635)

2025-06-17 Thread Amit Tiwari via cfe-commits
https://github.com/amitamd7 created https://github.com/llvm/llvm-project/pull/144635 This patch handles the strided update in the `#pragma omp target update from(data[a:b:c])` directive where 'c' represents the strided access leading to non-contiguous update in the `data` array when the offloa

[clang] [clang][PAC] Support trivially_relocating polymorphic objects (PR #144420)

2025-06-17 Thread Oliver Hunt via cfe-commits
@@ -4467,17 +4467,25 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__builtin_trivially_relocate: case Builtin::BImemmove: case Builtin::BI__builtin_memmove: { +QualType CopiedType = E->getArg(0)->getType()->getPoi

[clang] [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #144640)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt created https://github.com/llvm/llvm-project/pull/144640 This patch introduces enhancements to the Baremetal toolchain to support GCC toolchain detection. - If the --gcc-install-dir or --gcc-toolchain options are provided and point to valid paths, the sysroot is

[clang] [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #144640)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Garvit Gupta (quic-garvgupt) Changes This patch introduces enhancements to the Baremetal toolchain to support GCC toolchain detection. - If the --gcc-install-dir or --gcc-toolchain options are provided and point to valid paths, the s

[clang] [Clang] Fix '-Wformat-overflow' FP when floats had field-width and plus prefix (PR #144274)

2025-06-17 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/144274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, return Builder.CreateInsertElement(I0, A, 1); } + case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: { +llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext()); +

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, return Builder.CreateInsertElement(I0, A, 1); } + case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: { +llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext()); +

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-17 Thread Rana Pratap Reddy via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s ranapratap55 wrote: done. https://github.com/llvm/llvm-pr

[clang] [llvm] Revert "[RISCV] Remove B and Zbc extension from Andes series cpus." (PR #144402)

2025-06-17 Thread Jim Lin via cfe-commits
tclin914 wrote: I've summarized the issue in [#144639](https://github.com/llvm/llvm-project/issues/144639). https://github.com/llvm/llvm-project/pull/144402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [Clang] Fix '-Wformat-overflow' FP when floats had field-width and plus prefix (PR #144274)

2025-06-17 Thread Baranov Victor via cfe-commits
@@ -43,6 +43,11 @@ void call_snprintf(double d, int n, int *ptr) { __builtin_snprintf(node_name, sizeof(node_name), "%pOFn", ptr); // nonkprintf-warning {{'snprintf' will always be truncated; specified size is 6, but format string expands to at least 7}} __builtin_snprintf

[clang] [Clang] Fix '-Wformat-overflow' FP when floats had field-width and plus prefix (PR #144274)

2025-06-17 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/144274 >From 98fc81696400be2ea990d867375530ef3f544b82 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sun, 15 Jun 2025 22:20:54 +0300 Subject: [PATCH 1/3] [Clang] Fix '-Wformat-overflow' FP when floats had field-

[clang] HIPSPV: Unbundle SDL (PR #136412)

2025-06-17 Thread Paulius Velesko via cfe-commits
https://github.com/pvelesko updated https://github.com/llvm/llvm-project/pull/136412 >From fe6a426fc135c7232650b5ebac465ceaa66d7a20 Mon Sep 17 00:00:00 2001 From: Paulius Velesko Date: Sat, 19 Apr 2025 10:02:59 +0300 Subject: [PATCH 1/3] HIPSPV: Unbundle SDL This fixes the issue of rdc linking

[clang] [Clang] Fix '-Wformat-overflow' FP when floats had field-width and plus prefix (PR #144274)

2025-06-17 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/144274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OpenMP] Non-contiguous strided update (PR #144635)

2025-06-17 Thread Amit Tiwari via cfe-commits
https://github.com/amitamd7 converted_to_draft https://github.com/llvm/llvm-project/pull/144635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Register all LLVM targets in AllClangUnitTest main (PR #144428)

2025-06-17 Thread kadir çetinkaya via cfe-commits
@@ -117,6 +117,7 @@ get_property(LINK_LIBS GLOBAL PROPERTY CLANG_UNITTEST_LINK_LIBS) get_property(LLVM_COMPONENTS GLOBAL PROPERTY CLANG_UNITTEST_LLVM_COMPONENTS) add_distinct_clang_unittest(AllClangUnitTests ${SRCS} + AllClangUnitTests.cpp kadircet wrote:

[clang] [clang] Register all LLVM targets in AllClangUnitTest main (PR #144428)

2025-06-17 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks for the quick fix! https://github.com/llvm/llvm-project/pull/144428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] HIPSPV: Unbundle SDL (PR #136412)

2025-06-17 Thread Henry Linjamäki via cfe-commits
@@ -2625,6 +2625,11 @@ void tools::AddStaticDeviceLibs(Compilation *C, const Tool *T, llvm::opt::ArgStringList &CC1Args, StringRef Arch, StringRef Target, bool isBitCodeSDL) { + +

[clang] [clang][PAC] Support trivially_relocating polymorphic objects (PR #144420)

2025-06-17 Thread Oliver Hunt via cfe-commits
ojhunt wrote: > I think we should make a point of implementing this for address-discriminated > `__ptrauth` qualifiers before we release it, because changing the type trait > in a future release will be an ABI break. I had been talking to @cor3ntin and decided we could do it later as this is a

<    1   2   3