@@ -207,13 +207,9 @@ FormatStringConverter::FormatStringConverter(
ArgsOffset(FormatArgOffset + 1), LangOpts(LO) {
assert(ArgsOffset <= NumArgs);
FormatExpr = llvm::dyn_cast(
- Args[FormatArgOffset]->IgnoreImplicitAsWritten());
+ Args[FormatArgOffset]->Ignor
vvuksanovic wrote:
@legrosbuffle
https://github.com/llvm/llvm-project/pull/142150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -50,6 +50,55 @@ static const RecordDecl *findDefinition(StringRef RecordName,
return selectFirst("recordDecl", Results);
}
+static bool isSafeToRewrite(const RecordDecl *Decl, const ASTContext &Context)
{
+ // Don't attempt to rewrite if there is a declaration like 'int
@@ -0,0 +1,16 @@
+// RUN: clang-reorder-fields -record-name ::bar::Foo -fields-order z,y,x %s --
| FileCheck %s
vvuksanovic wrote:
Done.
https://github.com/llvm/llvm-project/pull/142149
___
cfe-commits mailing list
cf
ChuanqiXu9 wrote:
lifetimes are widely used. I don't have a clear idea for position yet.
https://github.com/llvm/llvm-project/pull/14
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
NewSigma wrote:
Prefer make it a general pass
https://github.com/llvm/llvm-project/pull/14
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NewSigma closed
https://github.com/llvm/llvm-project/pull/14
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/143168
>From cc00e6ad5192bbd6059542196fac286e7182d153 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 23 May 2025 14:22:21 -0700
Subject: [PATCH 1/2] [C++20][Modules] Fix false compilation error with
cons
@@ -6781,7 +6781,7 @@ static bool HandleConstructorCall(const Expr *E, const
LValue &This,
// and make sure we've initialized every step along it.
auto IndirectFieldChain = IFD->chain();
for (auto *C : IndirectFieldChain) {
-FD = cast(C);
+FD
https://github.com/lux-QAQ updated
https://github.com/llvm/llvm-project/pull/143142
>From f69abed79fd463004fa93662b757f157121b2f49 Mon Sep 17 00:00:00 2001
From: LUX <1098346...@qq.com>
Date: Fri, 6 Jun 2025 21:17:29 +0800
Subject: [PATCH] [Sema] Fix memory leak in DeductionFailureInfo (#143129)
@@ -1547,6 +1547,38 @@ struct FormatStyle {
bool BeforeWhile;
/// Indent the wrapped braces themselves.
bool IndentBraces;
+/// Indent nested wrapped lambda braces.
HazardyKnusperkeks wrote:
Yeah I can't think of a nice name here... @owenca do
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/143184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4963,12 +4958,9 @@ void
Parser::ParseMicrosoftRootSignatureAttributeArgs(ParsedAttributes &Attrs) {
return;
}
-// Create the Root Signature
-auto *SignatureDecl = HLSLRootSignatureDecl::Create(
-Actions.getASTContext(), /*DeclContext=*/Actions.Cu
@@ -653,6 +654,29 @@ ParsedType Sema::ActOnMSVCUnknownTypeName(const
IdentifierInfo &II,
return CreateParsedType(T, Builder.getTypeSourceInfo(Context, T));
}
+std::pair
+Sema::ActOnStartRootSignatureDecl(StringRef Signature) {
+ auto Hash = llvm::hash_value(Signature);
+
@@ -3619,6 +3619,19 @@ class Sema final : public SemaBase {
SourceLocation NameLoc,
bool IsTemplateTypeArg);
+ /// Computes the unique Root Signature identifier from the given signature,
-
https://github.com/AaronBallman commented:
Thank you for working on this! I think it's heading in the right direction.
https://github.com/llvm/llvm-project/pull/143184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
Author: Un1q32
Date: 2025-06-09T20:56:08+08:00
New Revision: 251a43e19369b833bcf3b6eba7366b70d208668e
URL:
https://github.com/llvm/llvm-project/commit/251a43e19369b833bcf3b6eba7366b70d208668e
DIFF:
https://github.com/llvm/llvm-project/commit/251a43e19369b833bcf3b6eba7366b70d208668e.diff
LOG: [
https://github.com/Lancern created
https://github.com/llvm/llvm-project/pull/143377
This patch updates cir.call operation and allows function calls with aggregate
arguments and return values.
It seems that C++ class support is still at a minimum now. I try to make a call
to a C++ function wit
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/143243
>From 9b6128211ea4a442ecded830c77c60387245bb89 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Sat, 7 Jun 2025 10:24:26 +0200
Subject: [PATCH 1/2] [Clang] Clarify the `[[trivial_abi]]` documentation.
Fixes
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -std=c++11 -fobjc-runtime-has-weak -fobjc-weak -fobjc-arc
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -std=c++11 -fobjc-runtime-has-weak -fobjc-weak -fobjc-arc
-triple x86_64-apple-darwin -fsyntax-only -verify %s
AaronBallman
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/143111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
This also needs a release note in `clang/docs/ReleaseNotes.rst`
https://github.com/llvm/llvm-project/pull/143111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clangir
Author: Sirui Mu (Lancern)
Changes
This patch updates cir.call operation and allows function calls with aggregate
arguments and return values.
It seems that C++ class support is still at a minimum now. I try to make a
@@ -272,6 +273,26 @@ QualType ObjCMessageExpr::getCallReturnType(ASTContext
&Ctx) const {
return Ctx.getReferenceQualifiedType(this);
}
+std::pair
+ObjCMessageExpr::getUnusedResultAttr(ASTContext &Ctx) const {
+ // If the callee is marked nodiscard, return that attribute
+
https://github.com/macurtis-amd updated
https://github.com/llvm/llvm-project/pull/134621
>From d78c113c285b3037e3cc15d2ae3f9769265d0d0e Mon Sep 17 00:00:00 2001
From: Matthew Curtis
Date: Mon, 9 Jun 2025 06:57:35 -0500
Subject: [PATCH 1/2] [clang] Suppress gnu-line-marker when saving temps
Whe
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -std=c++11 -fobjc-runtime-has-weak -fobjc-weak -fobjc-arc
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -std=c++11 -fobjc-runtime-has-weak -fobjc-weak -fobjc-arc
-triple x86_64-apple-darwin -fsyntax-only -verify %s
cor3ntin wro
https://github.com/yxsamliu approved this pull request.
LGTM. Thanks
https://github.com/llvm/llvm-project/pull/142857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide commented:
I’m not sure this is better? Having to manually `delete` these is... not great.
Have you benchmarked whether this improves memory usage or makes Clang faster?
See also this comment by Aaron on the issue you linked:
https://github.com/llvm/llvm-project/iss
https://github.com/bcardosolopes approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/143028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From adae2d22365b1c4f75a5050cce840e3241cc Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/143192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1641,6 +1641,34 @@ LogicalResult cir::VecTernaryOp::verify() {
return success();
}
+//===--===//
+// ComplexCreateOp
+//===--===//
+
+L
https://github.com/bcardosolopes approved this pull request.
LGTM, some nits
https://github.com/llvm/llvm-project/pull/143192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/143111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/17216
Here is the relevant piece of the build lo
@@ -2231,4 +2231,48 @@ def VecTernaryOp : CIR_Op<"vec.ternary",
let hasVerifier = 1;
}
+//===--===//
+// BaseClassAddrOp
+//===--===//
+
+d
https://github.com/kuhar requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/143297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1308,7 +1308,7 @@ getMappedRanges(ArrayRef Indexed,
ArrayRef Lexed) {
return std::nullopt;
}
// Fast check for the special subset case.
- if (std::includes(Indexed.begin(), Indexed.end(), Lexed.begin(),
Lexed.end()))
+ if (llvm::includes(Indexed, Lexed))
---
https://github.com/bcardosolopes approved this pull request.
Great!
https://github.com/llvm/llvm-project/pull/143214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes approved this pull request.
LGTM, with a non-blocking suggestion
https://github.com/llvm/llvm-project/pull/143195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: Rahul Joshi
Date: 2025-06-09T06:25:08-07:00
New Revision: e4060d3beab3b525b49baaa15484e3c595740a2f
URL:
https://github.com/llvm/llvm-project/commit/e4060d3beab3b525b49baaa15484e3c595740a2f
DIFF:
https://github.com/llvm/llvm-project/commit/e4060d3beab3b525b49baaa15484e3c595740a2f.diff
L
https://github.com/bcardosolopes approved this pull request.
https://github.com/llvm/llvm-project/pull/143253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes closed
https://github.com/llvm/llvm-project/pull/143253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -272,6 +273,26 @@ QualType ObjCMessageExpr::getCallReturnType(ASTContext
&Ctx) const {
return Ctx.getReferenceQualifiedType(this);
}
+std::pair
+ObjCMessageExpr::getUnusedResultAttr(ASTContext &Ctx) const {
+ // If the callee is marked nodiscard, return that attribute
+
@@ -1881,6 +1881,19 @@ OutputIt move(R &&Range, OutputIt Out) {
return std::move(adl_begin(Range), adl_end(Range), Out);
}
+/// Provide wrappers to std::includes which take ranges instead of having to
+/// pass begin/end explicitly.
kuhar wrote:
Maybe it wo
@@ -1881,6 +1881,19 @@ OutputIt move(R &&Range, OutputIt Out) {
return std::move(adl_begin(Range), adl_end(Range), Out);
}
+/// Provide wrappers to std::includes which take ranges instead of having to
+/// pass begin/end explicitly.
+template bool includes(R1 &&Range1, R2 &
@@ -1881,6 +1881,19 @@ OutputIt move(R &&Range, OutputIt Out) {
return std::move(adl_begin(Range), adl_end(Range), Out);
}
+/// Provide wrappers to std::includes which take ranges instead of having to
+/// pass begin/end explicitly.
+template bool includes(R1 &&Range1, R2 &
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/143195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/143260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/143253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lux-QAQ wrote:
I ran performance tests by following the LLVM Test Suite Guide and obtained the
following results.
The `results_old` data represents the baseline performance using the
**original, unmodified Clang**. The `results_new` data shows the performance
using the **Clang with my modific
https://github.com/bcardosolopes approved this pull request.
Thanks for this folder, one nit and good to go
https://github.com/llvm/llvm-project/pull/143260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/bcardosolopes approved this pull request.
LGTM, one nit
https://github.com/llvm/llvm-project/pull/143262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes approved this pull request.
https://github.com/llvm/llvm-project/pull/143304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/143262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sirraide wrote:
You might want to get your branch on
https://llvm-compile-time-tracker.com/index.php
CC @nikic
https://github.com/llvm/llvm-project/pull/143142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/143067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> If this were a bug, I suspect it would have been reported. Most likely,
> `dyn_cast_or_null(Entity.getDecl());` is never null, and could be
> replaced by `cast`? Did you try that?
`getDecl()` can definitely return null:
https://github.com/llvm/llvm-project/blob/e4060d3be
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143180
>From de57697e0f9b0f9d4bb5be7ca6be631fe2502484 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Fri, 30 May 2025 12:32:21 -0400
Subject: [PATCH] [HLSL][SPIRV] Add vk::constant_id attribute.
The vk::constant_
cor3ntin wrote:
Feel free to reopen a PR or open issues if you think something is still
missing! We appreciate the efforts you put into this PR, but it ended up being
slightly different from the WG21 solution
https://github.com/llvm/llvm-project/pull/84621
_
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/84621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes approved this pull request.
https://github.com/llvm/llvm-project/pull/143322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/140912
>From f277796a98f81bc3f0c6949adff3ad43eda51d5f Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Wed, 21 May 2025 07:54:02 -0700
Subject: [PATCH 1/4] [clang-tidy][performance-unnecessary-value-param] Avoid
https://github.com/carlocab closed
https://github.com/llvm/llvm-project/pull/141401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1599,6 +1599,14 @@ LogicalResult cir::VecShuffleOp::verify() {
<< " and " << getResult().getType() << " don't match";
}
+ const uint64_t maxValidIndex =
+ getVec1().getType().getSize() + getVec2().getType().getSize() - 1;
+ for (const auto
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/143265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1580,9 +1580,46 @@ OpFoldResult cir::VecExtractOp::fold(FoldAdaptor
adaptor) {
}
//===--===//
-// VecShuffle
+// VecShuffleOp
//===--
eZWALT wrote:
gentle ping @alexey-bataev @Meinersbur ;)
https://github.com/llvm/llvm-project/pull/140532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/143297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4942,18 +4942,13 @@ void
Parser::ParseMicrosoftRootSignatureAttributeArgs(ParsedAttributes &Attrs) {
// Construct our identifier
llvm-beanz wrote:
I suspect the "Microsoft" bit came from the attribute parsing syntax. HLSL
supports "Microsoft"-style att
@@ -77,12 +77,8 @@ void foo() {
// CIR: %[[VEC_F:.*]] = cir.alloca !cir.vector<4 x !s32i>,
!cir.ptr>, ["f", init]
// CIR: %[[VEC_G:.*]] = cir.alloca !cir.vector<4 x !s32i>,
!cir.ptr>, ["g", init]
// CIR: %[[VEC_H:.*]] = cir.alloca !cir.vector<4 x !s32i>,
!cir.ptr>, ["h", ini
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/143250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,81 @@
+#include "CIRGenBuilder.h"
+#include "CIRGenFunction.h"
+
+#include "clang/AST/StmtVisitor.h"
+
+using namespace clang;
+using namespace clang::CIRGen;
+
+namespace {
+class ComplexExprEmitter : public StmtVisitor
{
+ CIRGenFunction &cgf;
+ CIRGenBuilderTy &bu
@@ -1533,6 +1533,17 @@ LogicalResult cir::GetMemberOp::verify() {
// VecCreateOp
//===--===//
+OpFoldResult cir::VecCreateOp::fold(FoldAdaptor adaptor) {
+ auto elements = getElements();
+ if (std::any_of(e
AaronBallman wrote:
> Also, this is ANOTHER bit on function types that we're using for CFI. I'm
> wondering if this is actually a generally useful enough feature to be using
> this much compiler resources.
>
> @AaronBallman ?
I think CFI is pretty important for security posture (it basically
Author: Rahul Joshi
Date: 2025-06-09T06:52:21-07:00
New Revision: 7b5ab28e38a0ba6cb008923b27f7d29f76fd70c4
URL:
https://github.com/llvm/llvm-project/commit/7b5ab28e38a0ba6cb008923b27f7d29f76fd70c4
DIFF:
https://github.com/llvm/llvm-project/commit/7b5ab28e38a0ba6cb008923b27f7d29f76fd70c4.diff
L
https://github.com/Lancern edited
https://github.com/llvm/llvm-project/pull/143377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes approved this pull request.
LGTM, some nits
https://github.com/llvm/llvm-project/pull/143377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo
&funcInfo,
assert(!cir::MissingFeatures::opCallBitcastArg());
cirCallArgs[argNo] = v;
} else {
- assert(!cir::MissingFeatures::opCallAggregateArgs());
- cgm.errorNYI("emitCa
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/143377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -274,6 +274,12 @@ class AggValueSlot {
public:
enum IsZeroed_t { IsNotZeroed, IsZeroed };
+ /// ignored - Returns an aggregate value slot indicating that the aggregate
bcardosolopes wrote:
"ignored - " not necessary
https://github.com/llvm/llvm-project
@@ -0,0 +1,96 @@
+# A smoke test to check that a simple dependency chain for modules can work.
+#
+# FIXME: This fails on the Windows ARM64 build server. Not entirely sure why
as it has been tested on
+#an ARM64 Windows VM and appears to work there.
+# UNSUPPORTED: host=a
401 - 482 of 482 matches
Mail list logo
