llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Baranov Victor (vbvictor)
Changes
Fixed formatting and codestyle issues in `namespace-comment-check`
Follow up to https://github.com/llvm/llvm-project/pull/124265.
---
Full diff: https://github.com/llvm/llvm-project/pull/14330
carlosgalvezp wrote:
Thanks for fixing quickly!
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
@snarang181 I cannot see how this patch would affect a test in the JIT.
Sometimes main is not clean, and sometime there is flake in some tests or under
a sanitizer. We should be good IMO.
https://github.com/llvm/llvm-project/pull/142273
snarang181 wrote:
Sounds good, @ilovepi. I also raised an issue to get commit access and you
might have gotten a notification. It'd be great if you can take a look at that
too :)
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailin
@@ -176,14 +176,10 @@ class StoredDeclsList {
DeclListNode::Decls *Tail = erase_if([Decls](NamedDecl *ND) {
if (ND->isFromASTFile())
return true;
- // FIXME: Can we get rid of this loop completely?
- for (NamedDecl *D : Decls)
-// Only replac
https://github.com/snarang181 updated
https://github.com/llvm/llvm-project/pull/143275
>From c18c91f7f8f4332696dd309a5164c568f32c137b Mon Sep 17 00:00:00 2001
From: Samarth Narang
Date: Sat, 7 Jun 2025 12:21:17 -0400
Subject: [PATCH 1/2] Replace loop with llvm:any_of
---
clang/include/clang/A
snarang181 wrote:
> IIUC the `FIXME` comment means that the time complexity of this part of code
> is not good enough and we can make it faster.
OK. In any case, the usage of `llvm_any_of` seemed better than using an
explicit `for-loop`.
https://github.com/llvm/llvm-project/pull/143275
_
@@ -176,14 +176,10 @@ class StoredDeclsList {
DeclListNode::Decls *Tail = erase_if([Decls](NamedDecl *ND) {
if (ND->isFromASTFile())
return true;
- // FIXME: Can we get rid of this loop completely?
- for (NamedDecl *D : Decls)
-// Only replac
https://github.com/snarang181 updated
https://github.com/llvm/llvm-project/pull/143275
>From c18c91f7f8f4332696dd309a5164c568f32c137b Mon Sep 17 00:00:00 2001
From: Samarth Narang
Date: Sat, 7 Jun 2025 12:21:17 -0400
Subject: [PATCH 1/2] Replace loop with llvm:any_of
---
clang/include/clang/A
@@ -176,14 +176,10 @@ class StoredDeclsList {
DeclListNode::Decls *Tail = erase_if([Decls](NamedDecl *ND) {
if (ND->isFromASTFile())
return true;
- // FIXME: Can we get rid of this loop completely?
- for (NamedDecl *D : Decls)
-// Only replac
@@ -768,35 +768,13 @@ void RVVEmitter::createRVVIntrinsics(
Log2LMULMask |= 1 << (Log2LMUL + 3);
SR.Log2LMULMask = Log2LMULMask;
-
-for (auto RequiredFeature : RequiredFeatures) {
- unsigned RequireExt =
- StringSwitch(RequiredFeature)
-
@@ -177,13 +177,10 @@ class StoredDeclsList {
if (ND->isFromASTFile())
return true;
// FIXME: Can we get rid of this loop completely?
- for (NamedDecl *D : Decls)
-// Only replace the local declaration if the external declaration has
-//
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/143168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Weibo He (NewSigma)
Changes
Lifetime markers determine whether we place alloca on the frame or on the
stack. We can move `lifetime.end` to an optimized position to reduce the
coroutine frame size. I propose finding the suspend point that
https://github.com/NewSigma created
https://github.com/llvm/llvm-project/pull/14
Lifetime markers determine whether we place alloca on the frame or on the
stack. We can move `lifetime.end` to an optimized position to reduce the
coroutine frame size. I propose finding the suspend point that
@@ -177,13 +177,10 @@ class StoredDeclsList {
if (ND->isFromASTFile())
return true;
// FIXME: Can we get rid of this loop completely?
- for (NamedDecl *D : Decls)
-// Only replace the local declaration if the external declaration has
-//
https://github.com/snarang181 updated
https://github.com/llvm/llvm-project/pull/143275
>From c18c91f7f8f4332696dd309a5164c568f32c137b Mon Sep 17 00:00:00 2001
From: Samarth Narang
Date: Sat, 7 Jun 2025 12:21:17 -0400
Subject: [PATCH 1/2] Replace loop with llvm:any_of
---
clang/include/clang/A
https://github.com/snarang181 updated
https://github.com/llvm/llvm-project/pull/143275
>From c18c91f7f8f4332696dd309a5164c568f32c137b Mon Sep 17 00:00:00 2001
From: Samarth Narang
Date: Sat, 7 Jun 2025 12:21:17 -0400
Subject: [PATCH 1/2] Replace loop with llvm:any_of
---
clang/include/clang/A
@@ -177,13 +177,10 @@ class StoredDeclsList {
if (ND->isFromASTFile())
return true;
// FIXME: Can we get rid of this loop completely?
- for (NamedDecl *D : Decls)
-// Only replace the local declaration if the external declaration has
-//
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang/test/CodeGenCoroutines/pr56919.cpp
llvm/lib/Tr
https://github.com/snarang181 updated
https://github.com/llvm/llvm-project/pull/143275
>From c18c91f7f8f4332696dd309a5164c568f32c137b Mon Sep 17 00:00:00 2001
From: Samarth Narang
Date: Sat, 7 Jun 2025 12:21:17 -0400
Subject: [PATCH 1/2] Replace loop with llvm:any_of
---
clang/include/clang/A
Author: Ami-zhang
Date: 2025-06-09T11:15:41+08:00
New Revision: 0ed5d9aff6e72bdaf3f12bc71dbf83a5c116e8fd
URL:
https://github.com/llvm/llvm-project/commit/0ed5d9aff6e72bdaf3f12bc71dbf83a5c116e8fd
DIFF:
https://github.com/llvm/llvm-project/commit/0ed5d9aff6e72bdaf3f12bc71dbf83a5c116e8fd.diff
LOG
https://github.com/Ami-zhang closed
https://github.com/llvm/llvm-project/pull/142548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NewSigma updated
https://github.com/llvm/llvm-project/pull/14
>From 771ff1c9cc7d4b7f95d78d4219288d5c7ca0b83e Mon Sep 17 00:00:00 2001
From: NewSigma
Date: Thu, 5 Jun 2025 21:51:06 +0800
Subject: [PATCH 1/2] Rise lifetime.end to get smaller frame size
---
clang/test/Code
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/143337
None
>From 7db65a4b3ea588766a8cb693dda281f835ed9151 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sun, 8 Jun 2025 17:41:54 -0700
Subject: [PATCH] [DirectoryWatcher] Use llvm::find (NFC)
---
clang/un
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/143337.diff
1 Files Affected:
- (modified) clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp (+3-5)
``diff
diff --git a/cl
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/143337
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/no92 updated https://github.com/llvm/llvm-project/pull/139271
>From 4d64fbec42530f5dfe2e01a7e6e6a83fc7e5d8a2 Mon Sep 17 00:00:00 2001
From: no92
Date: Fri, 6 Sep 2024 21:18:39 +0200
Subject: [PATCH 1/3] [clang] Add managarm OS target
---
clang/lib/Basic/Targets.cpp
no92 wrote:
Added the requested changes and rebased on current main.
https://github.com/llvm/llvm-project/pull/139271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,194 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json
+
+struct Foo;
+
+// This is a nice class.
+// It has some nice methods and fields.
+// @brief This is
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/143314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vbvictor created
https://github.com/llvm/llvm-project/pull/143314
For ease of future developing, I make a series of clang-format patches on all
clang-tidy code.
Typically, all new contributors should follow the existing style, so making it
consistent will give a benefit in i
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Baranov Victor (vbvictor)
Changes
For ease of future developing, I make a series of clang-format patches on all
clang-tidy code.
Typically, all new contributors should follow the existing style, so making it
consistent will gi
https://github.com/no92 updated https://github.com/llvm/llvm-project/pull/139271
>From 4d64fbec42530f5dfe2e01a7e6e6a83fc7e5d8a2 Mon Sep 17 00:00:00 2001
From: no92
Date: Fri, 6 Sep 2024 21:18:39 +0200
Subject: [PATCH 1/3] [clang] Add managarm OS target
---
clang/lib/Basic/Targets.cpp
https://github.com/vbvictor created
https://github.com/llvm/llvm-project/pull/143315
None
>From 52b8b3edae64a301646b63f15dfa46cc9af250b3 Mon Sep 17 00:00:00 2001
From: Baranov Victor
Date: Sun, 8 Jun 2025 19:23:38 +0300
Subject: [PATCH] [clang-tidy][NFC] run clang-format over 'android', 'boost
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-tools-extra
Author: Baranov Victor (vbvictor)
Changes
---
Patch is 29.29 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/143315.diff
28 Files Affected:
- (modified) c
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/143310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/143327
Fix github.com/llvm/llvm-project/issues/65400#issuecomment-2922181979
>From ab36d65d7c0f677b196ac3aa0cf976fb483fad98 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Jun 2025 22:35:14 -0700
Subject: [PATCH]
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fix github.com/llvm/llvm-project/issues/65400#issuecomment-2922181979
---
Full diff: https://github.com/llvm/llvm-project/pull/143327.diff
4 Files Affected:
- (modified) clang/lib/Format/ContinuationInde
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/143327
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank approved this pull request.
LGTM! Can confirm that all `.cpp` and `.h` files in
`clang-tools-extra/clang-tidy` pass under `clang-format` head. Maybe this can
be added to some formatter CI? I'm not familiar with the CI setup.
https://github.com/llvm/llvm-project/pull
vbvictor wrote:
PRs are already checked by git-clang-format but sometimes it needs manual start
by a member. We shouldn't forget about this behavior.
https://github.com/llvm/llvm-project/pull/143324
___
cfe-commits mailing list
cfe-commits@lists.llvm.
nicovank wrote:
You're right -- it's already being run, but only on the changed lines, not the
entire file. Either way, it should cover future diffs minus rare weird edge
cases.
https://github.com/llvm/llvm-project/pull/143324
___
cfe-commits mailing
@@ -223,21 +272,114 @@ void CIRRecordLowering::fillOutputFields() {
fieldTypes.size() - 1;
// A field without storage must be a bitfield.
assert(!cir::MissingFeatures::bitfields());
+ if (!member.data)
+setBitFieldInfo(member.fieldDecl, memb
Author: Kazu Hirata
Date: 2025-06-08T16:18:16-07:00
New Revision: 240ff854adae4278a6f5fb232bf5f76dd9b81c69
URL:
https://github.com/llvm/llvm-project/commit/240ff854adae4278a6f5fb232bf5f76dd9b81c69
DIFF:
https://github.com/llvm/llvm-project/commit/240ff854adae4278a6f5fb232bf5f76dd9b81c69.diff
L
ojhunt wrote:
unused variable errors are likely fallout from refactoring and workaround
removals I did as part of the prep, will do some cleanup/diagnostics work later
this week.
I mostly wanted to get this available to others to see whether they were ok
adopting this rather than rolling thei
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/143317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dongjianqiang2 wrote:
> -mlong-calls is an old-fashioned compiler option. I think it was added before
> linkers knew range extension thunks (aka stubs, veneers, etc).
>
> Can you use -fno-plt instead? It works with both SelectionDAG and GlobalISel.
> You will get GOT-generating code sequence t
https://github.com/fzou1 edited https://github.com/llvm/llvm-project/pull/143124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fzou1 edited https://github.com/llvm/llvm-project/pull/143124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wenju-he created
https://github.com/llvm/llvm-project/pull/143331
NV supports opencl_3d_image_writes according
https://developer.nvidia.com/blog/nvidia-is-now-opencl-3-0-conformant/
This PR allows removing explicit enabling of image extensions via -cl-ext
command line option
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Wenju He (wenju-he)
Changes
NV supports opencl_3d_image_writes according
https://developer.nvidia.com/blog/nvidia-is-now-opencl-3-0-conformant/
This PR allows removing explicit enabling of image extensions via -cl-ext
command line option,
@@ -6781,7 +6781,7 @@ static bool HandleConstructorCall(const Expr *E, const
LValue &This,
// and make sure we've initialized every step along it.
auto IndirectFieldChain = IFD->chain();
for (auto *C : IndirectFieldChain) {
-FD = cast(C);
+FD
https://github.com/ChuanqiXu9 approved this pull request.
https://github.com/llvm/llvm-project/pull/143168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6781,7 +6781,7 @@ static bool HandleConstructorCall(const Expr *E, const
LValue &This,
// and make sure we've initialized every step along it.
auto IndirectFieldChain = IFD->chain();
for (auto *C : IndirectFieldChain) {
-FD = cast(C);
+FD
https://github.com/evelez7 updated
https://github.com/llvm/llvm-project/pull/142483
>From 741dce551684ee5818262ba3f4618ffcfa70a0d6 Mon Sep 17 00:00:00 2001
From: Erick Velez
Date: Mon, 2 Jun 2025 12:53:36 -0700
Subject: [PATCH 1/7] [clang-doc] add a JSON generator
---
clang-tools-extra/clang-
Author: Kazu Hirata
Date: 2025-06-08T22:37:44-07:00
New Revision: e47abec51353848d7ee2e50e8fc3f7b275a11463
URL:
https://github.com/llvm/llvm-project/commit/e47abec51353848d7ee2e50e8fc3f7b275a11463
DIFF:
https://github.com/llvm/llvm-project/commit/e47abec51353848d7ee2e50e8fc3f7b275a11463.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/143337
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
thanks
Do we also want to add some tests?
https://github.com/llvm/llvm-project/pull/143345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/evelez7 updated
https://github.com/llvm/llvm-project/pull/142483
>From 741dce551684ee5818262ba3f4618ffcfa70a0d6 Mon Sep 17 00:00:00 2001
From: Erick Velez
Date: Mon, 2 Jun 2025 12:53:36 -0700
Subject: [PATCH 1/7] [clang-doc] add a JSON generator
---
clang-tools-extra/clang-
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/143345
HeuristicResolver houses the unified implementation.
Fixes https://github.com/llvm/llvm-project/issues/143240
>From 4c65b2a50e8ea0592459c11a775723b5759ef31e Mon Sep 17 00:00:00 2001
From: Nathan Ridge
D
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clang
Author: Nathan Ridge (HighCommander4)
Changes
HeuristicResolver houses the unified implementation.
Fixes https://github.com/llvm/llvm-project/issues/143240
---
Full diff: https://github.com/llvm/llvm-project
@@ -368,6 +368,14 @@ static FunctionProtoTypeLoc getPrototypeLoc(Expr *Fn) {
}
if (auto F = Target.getAs()) {
+// In some edge cases the AST can contain a "trivial" FunctionProtoTypeLoc
HighCommander4 wrote:
Posted https://github.com/llvm/llvm-project
HighCommander4 wrote:
Apologies for not having had a chance to circle back to this sooner.
I read over the discussion of the [original
patch](https://github.com/llvm/llvm-project/pull/67749) that added support for
the `QuotedHeaders` and `AngledHeaders` config keys, and it turns out the
"reso
Author: Nathan Ridge
Date: 2025-06-09T00:33:20-04:00
New Revision: 392bd577e37d795224da6fefc4b621a3f117105e
URL:
https://github.com/llvm/llvm-project/commit/392bd577e37d795224da6fefc4b621a3f117105e
DIFF:
https://github.com/llvm/llvm-project/commit/392bd577e37d795224da6fefc4b621a3f117105e.diff
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/143087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-gcc-ubuntu-no-asserts` running on `doug-worker-6` while
building `clang,llvm` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/202/builds
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang/lib/Sema/SemaOverload.cpp
``
View
101 - 168 of 168 matches
Mail list logo