[clang] [llvm] [AArch64TargetParser]Fix reconstructFromParsedFeatures ignoring negative features (PR #142236)

2025-06-05 Thread Alexandros Lamprineas via cfe-commits
@@ -1831,6 +1831,22 @@ TEST_P(AArch64ExtensionDependenciesBaseCPUTestFixture, } } +TEST(TargetParserTest, testAArch64ReconstructFromParsedFeatures) { + AArch64::ExtensionSet Extensions; + std::vector FeatureOptions = { + "-sve2", "-Baz", "+sve", "+FooBar", "+sve2", "+

[clang] [CIR][NFC] Use `getType()` instead of more verbose `getResult().getType()` (PR #143024)

2025-06-05 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/143024 >From 4e79e49b2e4ea09d202e4c5995194754ae7b5447 Mon Sep 17 00:00:00 2001 From: xlauko Date: Thu, 5 Jun 2025 21:39:49 +0200 Subject: [PATCH] [CIR][NFC] Use `getType()` instead of more verbose `getResult().getType(

[clang] [llvm] [AArch64TargetParser]Fix reconstructFromParsedFeatures ignoring negative features (PR #142236)

2025-06-05 Thread Alexandros Lamprineas via cfe-commits
@@ -60,7 +60,7 @@ uint64_t AArch64::getFMVPriority(ArrayRef Features) { ExtensionSet FeatureBits; for (const StringRef Feature : Features) { std::optional FMV = parseFMVExtension(Feature); -if (!FMV) { +if (!FMV && Feature.starts_with('+')) { l

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-06-05 Thread via cfe-commits
@@ -39,3 +39,10 @@ Options An unsigned integer specifying the number of spaces before the comment closing a namespace definition. Default is `1U`. + +.. option:: AllowOmittingNamespaceComments + + When `true`, the check will accept if no namespace comment is present. +

[clang] [Clang][attr] Add cfi_salt attribute (PR #141846)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Testing seems insufficient, particularly around conversion rules/etc of these types. I would like to see quite a bit more for Sema/inside of templates/how this applies to instantiations of all these things, etc. Also, this is ANOTHER bit on function ty

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr (PR #134188)

2025-06-05 Thread David Rivera via cfe-commits
https://github.com/RiverDave updated https://github.com/llvm/llvm-project/pull/134188 >From daab8b4ccbce1f15758378c8229207a871b40683 Mon Sep 17 00:00:00 2001 From: David Rivera Date: Wed, 2 Apr 2025 21:02:00 -0400 Subject: [PATCH 1/2] [clang-tidy] Improve integer comparison by matching valid e

[clang] [Clang] Fix constant eval of assignment operators with an explicit object parameter (PR #142964)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I'm not particularly comfortable in ExprConstant, so perhaps we should wait for a smarter reviewer, but I didn't see anything that looked wrong to me. https://github.com/llvm/llvm-project/pull/142964 _

[clang] [Clang][NFC] Use move in std::vector local in HandleTranslationUnit (PR #142851)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/142851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add support for -mtune=andes-45-series (PR #142900)

2025-06-05 Thread Sam Elliott via cfe-commits
https://github.com/lenary approved this pull request. https://github.com/llvm/llvm-project/pull/142900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix error that reference to PointerType is ambiguous in clang/lib/Analysis/UnsafeBufferUsage.cpp (PR #142966)

2025-06-05 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/142966 >From f536c944cf6526676e5034471ff238b1ce3b0d13 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Thu, 5 Jun 2025 09:41:54 -0400 Subject: [PATCH] fix error that reference to PointerType is ambiguou

[clang] 702e228 - [clang] Reduce LateInstantiatedAttrVec vector default size. (#142840)

2025-06-05 Thread via cfe-commits
Author: Haojian Wu Date: 2025-06-05T15:14:25+02:00 New Revision: 702e228249906d43687952d9a2f3d2f90d8024c6 URL: https://github.com/llvm/llvm-project/commit/702e228249906d43687952d9a2f3d2f90d8024c6 DIFF: https://github.com/llvm/llvm-project/commit/702e228249906d43687952d9a2f3d2f90d8024c6.diff LO

[clang] Thread Safety Analysis: Very basic capability alias-analysis (PR #142955)

2025-06-05 Thread Marco Elver via cfe-commits
https://github.com/melver created https://github.com/llvm/llvm-project/pull/142955 Add a simple form of alias analysis for capabilities by substituting local pointer variables with their initializers if they are `const` or never reassigned. For example, the analysis will no longer generate fa

[clang] [CIR] Defer emitting function definitions (PR #142862)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/142862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce intra-procedural lifetime analysis in Clang (PR #142313)

2025-06-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for derived class declarations (PR #142823)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/142823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix error that reference to PointerType is ambiguous (PR #142966)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Abhina Sree (abhina-sree) Changes The CI on my PR https://github.com/llvm/llvm-project/pull/138895 is failing with errors like `clang/lib/Analysis/UnsafeBufferUsage.cpp:971:45: error: reference to 'PointerType' is ambiguous` Th

[clang] [CIR] Add support for derived class declarations (PR #142823)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -32,3 +38,16 @@ CompleteC cc; // CIR: cir.global external @cc = #cir.zero : !rec_CompleteC // LLVM: @cc = global %class.CompleteC zeroinitializer // OGCG: @cc = global %class.CompleteC zeroinitializer + +class Base { +public: + int a; +}; + +class Derived : public B

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-06-05 Thread Thorsten Klein via cfe-commits
https://github.com/thorsten-klein updated https://github.com/llvm/llvm-project/pull/124265 >From a6556aebc4f70be5e8be805fd009589fa7e0dc22 Mon Sep 17 00:00:00 2001 From: "Klein, Thorsten (GDE-EDSI1)" Date: Fri, 24 Jan 2025 13:46:24 +0100 Subject: [PATCH] added option AllowNoNamespaceComments for

[clang] [clang-tools-extra] Fix cross-references in Clang attribute reference (PR #142967)

2025-06-05 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert closed https://github.com/llvm/llvm-project/pull/142967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Erich Keane (erichkeane) Changes These ended up not being too much of a change, it just requires that we properly emit a member expression,then use it in the varPtr. I also fixed up the 'name' field to be the expression print, as that w

[clang] Fix an error introduced in #138518 (PR #142988)

2025-06-05 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh updated https://github.com/llvm/llvm-project/pull/142988 >From c7154b0b2bd6457d908bb7fbedc028219f8b5e6d Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Thu, 5 Jun 2025 15:10:39 + Subject: [PATCH 1/3] Fix an error introduced in #138518 --- clang/lib/Sema/

[clang] [C23][N3006] Documented behavior of underspecified object declarations (PR #140911)

2025-06-05 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,113 @@ +// RUN: %clang_cc1 -std=c23 -verify %s + +/* WG14 N3006: Yes + * Underspecified object declarations + */ + +void struct_test(void) { + struct S1 { int x, y; }; // expected-note {{field 'x' has type 'int' here}}

[clang] [C23][N3006] Documented behavior of underspecified object declarations (PR #140911)

2025-06-05 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,113 @@ +// RUN: %clang_cc1 -std=c23 -verify %s + +/* WG14 N3006: Yes + * Underspecified object declarations + */ + +void struct_test(void) { + struct S1 { int x, y; }; // expected-note {{field 'x' has type 'int' here}}

[clang] [llvm] [AArch64] Add support for -mlong-calls code generation (PR #142982)

2025-06-05 Thread Fangrui Song via cfe-commits
MaskRay wrote: -mlong-calls is an old-fashioned compiler option. I think it was added before linkers knew range extension thunks (aka stubs, veneers, etc). Can you use -fno-plt instead? It works with both SelectionDAG and GlobalISel. You will get GOT-generating code sequence that can be optimi

[clang] [llvm] [CodeGen][COFF] Always emit CodeView compiler info when hotpatch option is enabled (PR #142970)

2025-06-05 Thread Daniel Paoliello via cfe-commits
dpaoliello wrote: > MSVC emits this debug section at all times (S_OBJNAME and S_COMPILE3). Can't > we do the same without checking for the `getModuleFlag("ms-hotpatch")` flag? I would much rather do this: we have other internal tooling withing Microsoft that relies on being able to check what

[clang] [clang][CFG] Fix assertion failure in checkIncorrectLogicOperator (PR #142897)

2025-06-05 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -verify -Wunreachable-code %s + +// Previously this test will crash +static void test(__fp16& x) { + if (x != 0 || x != 1.0) { // expected-note{{}} + x = 0.9; +} else + x = 0.8; // expected-warning{{code will never be executed}}

[clang] [clang][CFG] Fix assertion failure in checkIncorrectLogicOperator (PR #142897)

2025-06-05 Thread Balazs Benics via cfe-commits
@@ -1261,6 +1261,28 @@ class CFGBuilder { L2Result.Val.getKind() == APValue::Float) { llvm::APFloat L1 = L1Result.Val.getFloat(); llvm::APFloat L2 = L2Result.Val.getFloat(); + // Note that L1 and L2 do not necessarily have the same type. For example +

[clang] [clang][CFG] Fix assertion failure in checkIncorrectLogicOperator (PR #142897)

2025-06-05 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -verify -Wunreachable-code %s + +// Previously this test will crash +static void test(__fp16& x) { steakhal wrote: I think after adding the `no-crash` tag (as in the analyzer community usually do) this comment would become le

[clang] [clang][CFG] Fix assertion failure in checkIncorrectLogicOperator (PR #142897)

2025-06-05 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/142897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CFG] Fix assertion failure in checkIncorrectLogicOperator (PR #142897)

2025-06-05 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -verify -Wunreachable-code %s + +// Previously this test will crash +static void test(__fp16& x) { + if (x != 0 || x != 1.0) { // expected-note{{}} steakhal wrote: ```suggestion if (x != 0 || x != 1.0) { // expected-note{{}

[clang] [clang][CFG] Fix assertion failure in checkIncorrectLogicOperator (PR #142897)

2025-06-05 Thread Balazs Benics via cfe-commits
@@ -1261,6 +1261,28 @@ class CFGBuilder { L2Result.Val.getKind() == APValue::Float) { llvm::APFloat L1 = L1Result.Val.getFloat(); llvm::APFloat L2 = L2Result.Val.getFloat(); + // Note that L1 and L2 do not necessarily have the same type. For example +

[clang] [clang][CFG] Fix assertion failure in checkIncorrectLogicOperator (PR #142897)

2025-06-05 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: I don't think I have much to say. I never really touched floating-point stuff. I left the comments I had while reading though. https://github.com/llvm/llvm-project/pull/142897 ___ cfe-commits mailing list cfe-comm

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Valentin Clement バレンタイン クレメン via cfe-commits
@@ -226,6 +228,10 @@ class OpenACCClauseCIREmitter final mlir::Location exprLoc = cgf.cgm.getLoc(curVarExpr->getBeginLoc()); llvm::SmallVector bounds; +std::string exprString; +llvm::raw_string_ostream OS(exprString); clementval wrote: Maybe?

[clang] [llvm] [AArch64] Add support for -mlong-calls code generation (PR #142982)

2025-06-05 Thread Peter Smith via cfe-commits
smithp35 wrote: > > My understanding is that this will make all calls to global functions into > > long calls. > > In AArch64 static linkes are required to insert range extension thunks for > > out of range BLs. In the best case this is just another direct branch, at > > worst case for `--pic-

[clang] [clang][Darwin] Simplify deployment version assignment in the Driver (PR #142013)

2025-06-05 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/142013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable fexec-charset option (PR #138895)

2025-06-05 Thread Abhina Sree via cfe-commits
@@ -0,0 +1,36 @@ +//===--- clang/Lex/LiteralConverter.h - Translator for Literals -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -201,6 +201,19 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy { cir::IntType getUInt32Ty() { return typeCache.UInt32Ty; } cir::IntType getUInt64Ty() { return typeCache.UInt64Ty; } + cir::ConstantOp getConstInt(mlir::Location loc, llvm::APSInt intVal); + + cir

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ let hasVerifier = 1; } +//===--===// +// LLVMIntrinsicCallOp +//===--===// + +def LLVM

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ let hasVerifier = 1; } +//===--===// +// LLVMIntrinsicCallOp +//===--===// + +def LLVM

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -38,3 +38,25 @@ mlir::Value CIRGenBuilderTy::getArrayElement(mlir::Location arrayLocBegin, const mlir::Type flatPtrTy = basePtr.getType(); return create(arrayLocEnd, flatPtrTy, basePtr, idx); } + +cir::ConstantOp CIRGenBuilderTy::getConstInt(mlir::Location loc, +

[clang] [llvm] Enable fexec-charset option (PR #138895)

2025-06-05 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/138895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-06-05 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/135383 >From 17013c38835d42a21b16d5e85c1268059555ea7f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 5 Jun 2025 21:51:41 +0300 Subject: [PATCH] [clang-tidy] add support for lambdas in use-trailing-return-ty

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -38,3 +38,25 @@ mlir::Value CIRGenBuilderTy::getArrayElement(mlir::Location arrayLocBegin, const mlir::Type flatPtrTy = basePtr.getType(); return create(arrayLocEnd, flatPtrTy, basePtr, idx); } + +cir::ConstantOp CIRGenBuilderTy::getConstInt(mlir::Location loc, +

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] Enable fexec-charset option (PR #138895)

2025-06-05 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/138895 >From 7c6653b4a05097333ae2b73c6664f18b7acb9edb Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 7 May 2025 11:26:59 -0400 Subject: [PATCH] This patch enables the fexec-charset option to cont

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -47,6 +47,10 @@ class CIRGenFunction : public CIRGenTypeCache { /// is where the next operations will be introduced. CIRGenBuilderTy &builder; + /// Largest vector width used in ths function. Will be used to create a erichkeane wrote: ```suggestion

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -1004,8 +1004,48 @@ static cir::FuncOp emitFunctionDeclPointer(CIRGenModule &cgm, GlobalDecl gd) { return cgm.getAddrOfFunction(gd); } -static CIRGenCallee emitDirectCallee(CIRGenModule &cgm, GlobalDecl gd) { - assert(!cir::MissingFeatures::opCallBuiltinFunc()); +// Det

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -201,6 +201,19 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy { cir::IntType getUInt32Ty() { return typeCache.UInt32Ty; } cir::IntType getUInt64Ty() { return typeCache.UInt64Ty; } + cir::ConstantOp getConstInt(mlir::Location loc, llvm::APSInt intVal); + + cir

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/142981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: There seems to be a LOT of code here that isn't in the tests? The only thing tested is no argument types, and just an int return type, yet there is a ton of builtin code to do a lot more than that. I think this needs a lot more work to make sure we're

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ let hasVerifier = 1; } +//===--===// +// LLVMIntrinsicCallOp +//===--===// + +def LLVM

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -44,16 +44,25 @@ class CIRGenCalleeInfo { class CIRGenCallee { enum class SpecialKind : uintptr_t { Invalid, +Builtin, erichkeane wrote: Line 49 needs to be updated for this. https://github.com/llvm/llvm-project/pull/142981 __

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Fix an error introduced in #138518 (PR #142988)

2025-06-05 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh closed https://github.com/llvm/llvm-project/pull/142988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f532167 - Fix an error introduced in #138518 (#142988)

2025-06-05 Thread via cfe-commits
Author: Alexander Kornienko Date: 2025-06-05T20:57:12+02:00 New Revision: f53216793e15588d65601196b7a0625f73c12cea URL: https://github.com/llvm/llvm-project/commit/f53216793e15588d65601196b7a0625f73c12cea DIFF: https://github.com/llvm/llvm-project/commit/f53216793e15588d65601196b7a0625f73c12cea

[clang] [llvm] Reland "[HLSL][RootSignature] Implement serialization of RootConstants and RootFlags" (PR #143019)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Finn Plummer (inbelic) Changes This relands #141130. The initial commit uncovered that we are missing the correct linking of FrontendHLSL into clang/lib/Parse and clang/lib/unittests/Parse. This change addreses this by linking them accord

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-05 Thread Paul Kirth via cfe-commits
ilovepi wrote: > > This sounds promising. I'm fine w/ adding a field to track this. BTW, what > > does clang do? I'm wondering if we should track more than 1-bit of info > > here. > > As far as I can tell, inside the AST Clang makes use of the `isa<>` > mechanisms (which we could also leverag

[clang] [CIR] Add empty handlers for Using and UsingShadow decls (PR #143032)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/143032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix Microsoft calling convensions preventing function names from being marked TT_StartOfName (PR #143047)

2025-06-05 Thread Ben Dunkin via cfe-commits
https://github.com/bdunkin created https://github.com/llvm/llvm-project/pull/143047 This fixes the `SpaceBeforeParensOptions.AfterFunctionDeclarationName` and `SpaceBeforeParensOptions.AfterFunctionDefinitionName` options not adding spaces when the function has an explicit Microsoft calling co

[clang] [clang-format] Fix Microsoft calling convensions preventing function names from being marked TT_StartOfName (PR #143047)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Ben Dunkin (bdunkin) Changes This fixes the `SpaceBeforeParensOptions.AfterFunctionDeclarationName` and `SpaceBeforeParensOptions.AfterFunctionDefinitionName` options not adding spaces when the function has an explicit Microsoft ca

[clang] [clang-format] Fix Microsoft calling convensions preventing function names from being marked TT_StartOfName (PR #143047)

2025-06-05 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [CIR ] Add DLTI dialect support to module attributes (PR #142241)

2025-06-05 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/4061 Here is the relevant piece

[clang] 6c1ca07 - [CIR] Add decl case for template specialization (#143029)

2025-06-05 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-06-05T16:50:36-07:00 New Revision: 6c1ca07586196c5a693f720d35a9a4be6e76d7d2 URL: https://github.com/llvm/llvm-project/commit/6c1ca07586196c5a693f720d35a9a4be6e76d7d2 DIFF: https://github.com/llvm/llvm-project/commit/6c1ca07586196c5a693f720d35a9a4be6e76d7d2.diff L

[clang] [CIR] Add decl case for template specialization (PR #143029)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/143029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] de3a9ea - [NFC][libclc] Simplify clc_dot and dot implementation (#142922)

2025-06-05 Thread via cfe-commits
Author: Wenju He Date: 2025-06-06T08:09:53+08:00 New Revision: de3a9ea510fecd501b4dd57534cf300d1c9622c9 URL: https://github.com/llvm/llvm-project/commit/de3a9ea510fecd501b4dd57534cf300d1c9622c9 DIFF: https://github.com/llvm/llvm-project/commit/de3a9ea510fecd501b4dd57534cf300d1c9622c9.diff LOG:

[libclc] [NFC][libclc] Simplify clc_dot and dot implementation (PR #142922)

2025-06-05 Thread Wenju He via cfe-commits
https://github.com/wenju-he closed https://github.com/llvm/llvm-project/pull/142922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][attr] Add cfi_salt attribute (PR #141846)

2025-06-05 Thread Bill Wendling via cfe-commits
bwendling wrote: @erichkeane If the Arm attribute code were merged into `ExtraAttributeInfo`, it would save us a bit in `FunctionTypeExtraBitfields`. I can add more testing I suppose, but the tests I have here are a copy of the current CFI tests, which test all of the ways CFI is used. So I'm

[clang-tools-extra] [clang-tidy] Add performance-bool-bitwise-operation check (PR #142324)

2025-06-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c,h -- clang-tools-extra/clang-tidy/performance/BoolBitw

[clang] [Clang] Fix constant eval of assignment operators with an explicit object parameter (PR #142964)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Corentin Jabot (cor3ntin) Changes Fixes #142835 --- Full diff: https://github.com/llvm/llvm-project/pull/142964.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2-1) - (modified) clang/lib/AST/ExprConstant.cpp (+41-23)

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-06-05 Thread Thorsten Klein via cfe-commits
https://github.com/thorsten-klein updated https://github.com/llvm/llvm-project/pull/124265 >From 6bbb691e844e51b40e38958c22678bb066d301f5 Mon Sep 17 00:00:00 2001 From: "Klein, Thorsten (GDE-EDSI1)" Date: Fri, 24 Jan 2025 13:46:24 +0100 Subject: [PATCH] added option AllowNoNamespaceComments for

[clang] Fix error that reference to PointerType is ambiguous in clang/lib/Analysis/UnsafeBufferUsage.cpp (PR #142966)

2025-06-05 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM, but I would also consider dropping the "using namespace llvm" instead. This seems a bit unusual for a file in clang/lib/Analysis. https://github.com/llvm/llvm-project/pull/142966 ___ cfe-commi

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-05 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/142288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce intra-procedural lifetime analysis in Clang (PR #142313)

2025-06-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce intra-procedural lifetime analysis in Clang (PR #142313)

2025-06-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce intra-procedural lifetime analysis in Clang (PR #142313)

2025-06-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce intra-procedural lifetime analysis in Clang (PR #142313)

2025-06-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][COFF] Always emit CodeView compiler info when hotpatch option is enabled (PR #142970)

2025-06-05 Thread Jacek Caban via cfe-commits
https://github.com/cjacek created https://github.com/llvm/llvm-project/pull/142970 MSVC always emits minimal CodeView metadata containing compiler information, even when debug info is otherwise disabled. While this data is typically not meaningful on its own, the linker may use it to detect w

[clang] [clang-tools-extra] Fix cross-references in Clang attribute reference (PR #142967)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! This all looks correct to me, so LG assume precommit CI doesn't find issues with the Sphinx markdown. https://github.com/llvm/llvm-project/pull/142967 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [CodeGen][COFF] Always emit CodeView compiler info when hotpatch option is enabled (PR #142970)

2025-06-05 Thread Jacek Caban via cfe-commits
cjacek wrote: Depends on #142969. https://github.com/llvm/llvm-project/pull/142970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reduce TemplateDeclInstantiator size. (PR #142983)

2025-06-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/142983 This gives us another ~1.85% improvement (1617->1647 for the `instantiation-depth-default.cpp`) on clang's template instantiation depths, No performance regressions have been observed: https://llvm-compile-ti

[clang] [llvm] [AArch64] Add support for -mlong-calls code generation (PR #142982)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-aarch64 Author: dong jianqiang (dongjianqiang2) Changes This patch implements backend support for -mlong-calls on AArch64 targets. When enabled, calls to external functions are lowered to an indirect call via an addre

[clang] [llvm] [AArch64] Add support for -mlong-calls code generation (PR #142982)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: dong jianqiang (dongjianqiang2) Changes This patch implements backend support for -mlong-calls on AArch64 targets. When enabled, calls to external functions are lowered to an indirect call via an address computed using `adrp` and `

[clang] [C23][N3006] Documented behavior of underspecified object declarations (PR #140911)

2025-06-05 Thread Aaron Ballman via cfe-commits
@@ -6501,3 +6501,59 @@ qualifications. Note, Clang does not allow an ``_Atomic`` function type because of explicit constraints against atomically qualified (arrays and) function types. + + +Underspecified Object Declarations in C +=== + +C23

[clang] [clang] Reduce TemplateDeclInstantiator size. (PR #142983)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes This gives us another ~1.85% improvement (1617->1647 for the `instantiation-depth-default.cpp`) on clang's template instantiation depths, No performance regressions have been observed: https://llvm-compile-t

[clang] [Clang] Fix constant eval of assignment operators with an explicit object parameter (PR #142964)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/142964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Global string alignment (PR #142346)

2025-06-05 Thread Dominik Steenken via cfe-commits
https://github.com/dominik-steenken updated https://github.com/llvm/llvm-project/pull/142346 >From ff817c7a1b79596712d24b7cfac9212edcef9280 Mon Sep 17 00:00:00 2001 From: Dominik Steenken Date: Mon, 26 May 2025 14:53:41 +0200 Subject: [PATCH 1/3] Align global strings according to data layout W

[clang] [clang] Reduce TemplateDeclInstantiator size. (PR #142983)

2025-06-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/Sema/Template.h clang/lib/Sema

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-06-05 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From cd8321c18eecd841907969753653548fbe23d76a Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 01/11] [CIR] Upstream global initialization for ComplexType

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr (PR #134188)

2025-06-05 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/134188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [Modules] Fix to correctly handle module dependencies (PR #142828)

2025-06-05 Thread via cfe-commits
fleeting-xx wrote: Added the test but disabled it for `host=aarch64-pc-windows-msvc` instead of `system-windows`. That will disable it specifically for the platform/build server it wasn't working on. https://github.com/llvm/llvm-project/pull/142828 _

[clang] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and older (PR #141401)

2025-06-05 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/141401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Simplify deployment version assignment in the Driver (PR #142013)

2025-06-05 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-06-05 Thread Amr Hesham via cfe-commits
@@ -0,0 +1,41 @@ + +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [flang] [mlir] [flang] Add support for -mrecip[=] (PR #142172)

2025-06-05 Thread Cameron McInally via cfe-commits
mcinally wrote: This PR has been abandoned in hopes of using the more modular solution in #142800. https://github.com/llvm/llvm-project/pull/142172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

<    1   2   3   4   5   6   >