[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Henrich Lauko (xlauko) Changes - Uses getIIntegerAttr builder method instead of explicit attribute and its type creation. - Adds few helper functions `getAlignmentAttr` to build alignment representing mlir::IntegerAttr. - Remo

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrich Lauko (xlauko) Changes - Uses getIIntegerAttr builder method instead of explicit attribute and its type creation. - Adds few helper functions `getAlignmentAttr` to build alignment representing mlir::IntegerAttr. - Remove

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -7867,15 +7865,16 @@ void Sema::checkUnusedDeclAttributes(Declarator &D) { void Sema::DiagnoseUnknownAttribute(const ParsedAttr &AL) { std::string NormalizedFullName = '\'' + AL.getNormalizedFullName() + '\''; + SourceRange NR = AL.getNormalizedRange();

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/141830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][attr] Add cfi_salt attribute (PR #141846)

2025-05-28 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/141846 The new 'cfi_salt' attribute is used to differentiate between two functions with the same type signature. It's applied to the function declaration, function definition, and function typedefs of the function t

[clang] [Clang][attr] Add cfi_salt attribute (PR #141846)

2025-05-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes The new 'cfi_salt' attribute is used to differentiate between two functions with the same type signature. It's applied to the function declaration, function definition, and function typedefs of the functi

[clang] [OpenMP] Fix atomic compare handling with overloaded operators (PR #141142)

2025-05-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/141142 >From f2c18ba64744320a8e2a63938b17137a1b6e74d7 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 22 May 2025 16:21:34 -0500 Subject: [PATCH] [OpenMP] Fix atomic compare handling with overloaded operators

[clang] [OpenMP] Fix atomic compare handling with overloaded operators (PR #141142)

2025-05-28 Thread Joseph Huber via cfe-commits
@@ -12062,32 +12154,56 @@ bool OpenMPAtomicCompareCaptureChecker::checkForm3(IfStmt *S, X = BO->getLHS(); D = BO->getRHS(); - auto *Cond = dyn_cast(S->getCond()); - if (!Cond) { + if (auto *Cond = dyn_cast(S->getCond())) { +C = Cond; +if (Cond->getOpcode() != B

[clang] [OpenMP] Fix atomic compare handling with overloaded operators (PR #141142)

2025-05-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/atomi

[clang] [OpenMP] Fix atomic compare handling with overloaded operators (PR #141142)

2025-05-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/141142 >From 07caec33a1113602f3d6ba79357edeae6b66647c Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 22 May 2025 16:21:34 -0500 Subject: [PATCH] [OpenMP] Fix atomic compare handling with overloaded operators

[clang] [Clang] Remap paths in OpenMP runtime calls (#82541) (PR #141250)

2025-05-28 Thread Dan McGregor via cfe-commits
dankm wrote: If people are good with this, I don't have commit access, so I'd appreciate somebody merging. https://github.com/llvm/llvm-project/pull/141250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [AArch64] Add missing Neon Types (PR #126945)

2025-05-28 Thread David Green via cfe-commits
davemgreen wrote: Patch up in #141850 https://github.com/llvm/llvm-project/pull/126945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][attr] Add cfi_salt attribute (PR #141846)

2025-05-28 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: See #135836 for discussion of why you can't use AttributedType like this. CC @PiJoules https://github.com/llvm/llvm-project/pull/141846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Oleksandr T. via cfe-commits
@@ -7867,15 +7865,16 @@ void Sema::checkUnusedDeclAttributes(Declarator &D) { void Sema::DiagnoseUnknownAttribute(const ParsedAttr &AL) { std::string NormalizedFullName = '\'' + AL.getNormalizedFullName() + '\''; + SourceRange NR = AL.getNormalizedRange();

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -7867,15 +7865,16 @@ void Sema::checkUnusedDeclAttributes(Declarator &D) { void Sema::DiagnoseUnknownAttribute(const ParsedAttr &AL) { std::string NormalizedFullName = '\'' + AL.getNormalizedFullName() + '\''; + SourceRange NR = AL.getNormalizedRange();

[clang] [clang] Add new warning: not eliding copy on return (missed NRVO) (PR #139973)

2025-05-28 Thread Cory Fields via cfe-commits
theuni wrote: Turning this on points out a pretty surprising missed nrvo opportunity: #38674. The warning is helpful for pointing out missed opportunities in user code, but it's not of much use if it's pointing out missed opportunities for clang too :) https://github.com/llvm/llvm-project/pull

[clang] [Clang][attr] Add cfi_salt attribute (PR #141846)

2025-05-28 Thread Bill Wendling via cfe-commits
bwendling wrote: @efriedma-quic Okay, I'm not entirely sure I understand @erichkeane's concerns, but that's fine. Are you suggesting adding the salt information to the `FunctionType` instead? https://github.com/llvm/llvm-project/pull/141846 ___ cfe-c

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/5] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR] Update testds for global vars (PR #141854)

2025-05-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/141854 This change updates a few tests for global variable handling to also check classic codegen output so we can easily verify consistency between the two and will be alerted if the classic codegen changes. This

[clang] b574c81 - [CIR] Defer declarations and tentative definitions (#141700)

2025-05-28 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-05-28T13:53:30-07:00 New Revision: b574c811e83a2f638714153cb2f915c625ac945c URL: https://github.com/llvm/llvm-project/commit/b574c811e83a2f638714153cb2f915c625ac945c DIFF: https://github.com/llvm/llvm-project/commit/b574c811e83a2f638714153cb2f915c625ac945c.diff L

[clang] [CIR] Defer declarations and tentative definitions (PR #141700)

2025-05-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/141700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Update testds for global vars (PR #141854)

2025-05-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes This change updates a few tests for global variable handling to also check classic codegen output so we can easily verify consistency between the two and will be alerted if the classic codegen changes.

[clang] [CIR] Update testds for global vars (PR #141854)

2025-05-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change updates a few tests for global variable handling to also check classic codegen output so we can easily verify consistency between the two and will be alerted if the classic codegen changes. Th

[clang] [CIR] Update tests for global vars (PR #141854)

2025-05-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/141854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -428,13 +422,28 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return OpBuilder::InsertPoint(block, block->begin()); }; - mlir::IntegerAttr getSizeFromCharUnits(mlir::MLIRContext *ctx, - clang::CharUnits size) { -// N

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. what amounts to 2 nits. https://github.com/llvm/llvm-project/pull/141830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/141830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -428,13 +422,28 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return OpBuilder::InsertPoint(block, block->begin()); }; - mlir::IntegerAttr getSizeFromCharUnits(mlir::MLIRContext *ctx, - clang::CharUnits size) { -// N

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -428,13 +422,28 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return OpBuilder::InsertPoint(block, block->begin()); }; - mlir::IntegerAttr getSizeFromCharUnits(mlir::MLIRContext *ctx, - clang::CharUnits size) { -// N

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

2025-05-28 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Update testds for global vars (PR #141854)

2025-05-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/141854 >From 462dc6afb219a4005e72d516e922c1c4ab0179d9 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Wed, 28 May 2025 13:49:25 -0700 Subject: [PATCH] [CIR] Update testds for global vars This change updates a few

[clang] [CIR] Update testds for global vars (PR #141854)

2025-05-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Typo in the title (s/testds/tests/), else lgtm. https://github.com/llvm/llvm-project/pull/141854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

2025-05-28 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/141855 None >From 18e18ca675a38ef6bf34a4450291ed9ebc85eb66 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 28 May 2025 14:00:46 -0700 Subject: [PATCH] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRT

[clang] f20423f - [clang] Rename -Wdeprecated-switch-case to -Wdeprecated-declarations-switch-case (#141779)

2025-05-28 Thread via cfe-commits
Author: Hans Wennborg Date: 2025-05-28T23:03:10+02:00 New Revision: f20423f496e9ceb340a3c11b54d6a7ff7e74f2bc URL: https://github.com/llvm/llvm-project/commit/f20423f496e9ceb340a3c11b54d6a7ff7e74f2bc DIFF: https://github.com/llvm/llvm-project/commit/f20423f496e9ceb340a3c11b54d6a7ff7e74f2bc.diff

[clang] [clang] Rename -Wdeprecated-switch-case to -Wdeprecated-declarations-switch-case (PR #141779)

2025-05-28 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem closed https://github.com/llvm/llvm-project/pull/141779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Andy Kaylor via cfe-commits
@@ -428,13 +422,28 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return OpBuilder::InsertPoint(block, block->begin()); }; - mlir::IntegerAttr getSizeFromCharUnits(mlir::MLIRContext *ctx, - clang::CharUnits size) { -// N

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Andy Kaylor via cfe-commits
@@ -282,22 +282,15 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy { cir::LoadOp createLoad(mlir::Location loc, Address addr, bool isVolatile = false) { -mlir::IntegerAttr align; -uint64_t alignment = addr.getAlignment().getQuantity()

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/141830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SimplifyCFG] Extend jump-threading to allow live local defs (PR #135079)

2025-05-28 Thread via cfe-commits
@@ -3442,10 +3442,28 @@ bool SimplifyCFGOpt::speculativelyExecuteBB(BranchInst *BI, return true; } +typedef SmallPtrSet BlocksSet; LU-JOHN wrote: Changed. https://github.com/llvm/llvm-project/pull/135079 ___ cfe

[clang] [CIR] Streamline creation of mlir::IntegerAttrs using mlir::Builder (PR #141830)

2025-05-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm with a couple of nits https://github.com/llvm/llvm-project/pull/141830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SimplifyCFG] Extend jump-threading to allow live local defs (PR #135079)

2025-05-28 Thread via cfe-commits
@@ -3467,13 +3485,23 @@ static bool blockIsSimpleEnoughToThreadThrough(BasicBlock *BB) { // live outside of the current basic block. for (User *U : I.users()) { Instruction *UI = cast(U); - if (UI->getParent() != BB || isa(UI)) -return false; +

[clang] [ASTWriter] Do not write ObjCCategories if empty. (PR #141841)

2025-05-28 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: This change makes sense to me. I have two questions: 1. Can we add a test that checks that the block is omitted? (maybe via `llvm-bcanalyzer -dump`) 2. Can we make the `explicit-build.cpp` test more robust? (possibly by writing out import signatures) https://github.com/llvm

[clang] 9553514 - [NFCI][ubsan] Precommit tests for -fsanitize-annotate-debug-info (#141814)

2025-05-28 Thread via cfe-commits
Author: Thurston Dang Date: 2025-05-28T14:12:39-07:00 New Revision: 9553514e4a0cdae580930173410b23ccd35c9e4c URL: https://github.com/llvm/llvm-project/commit/9553514e4a0cdae580930173410b23ccd35c9e4c DIFF: https://github.com/llvm/llvm-project/commit/9553514e4a0cdae580930173410b23ccd35c9e4c.diff

[clang] [NFCI][ubsan] Precommit tests for -fsanitize-annotate-debug-info (PR #141814)

2025-05-28 Thread Thurston Dang via cfe-commits
https://github.com/thurstond closed https://github.com/llvm/llvm-project/pull/141814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-28 Thread Paul Kirth via cfe-commits
@@ -49,6 +49,7 @@ using namespace clang::ast_matchers; using namespace clang::tooling; using namespace clang; +static llvm::ExitOnError ExitOnErr; ilovepi wrote: ```suggestion static llvm::ExitOnError ExitOnErr; ``` Nit: newline between using and the declarat

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-28 Thread Paul Kirth via cfe-commits
@@ -371,22 +367,14 @@ Example usage for a project using a compile commands database: sortUsrToInfo(USRToInfo); // Ensure the root output directory exists. - if (std::error_code Err = llvm::sys::fs::create_directories(OutDirectory); - Err != std::error_code()) { -

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Oleksandr T. via cfe-commits
@@ -7867,15 +7865,16 @@ void Sema::checkUnusedDeclAttributes(Declarator &D) { void Sema::DiagnoseUnknownAttribute(const ParsedAttr &AL) { std::string NormalizedFullName = '\'' + AL.getNormalizedFullName() + '\''; + SourceRange NR = AL.getNormalizedRange();

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-28 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > In general, though, I share the same concern as @vsapsai about leaving this > patch reverted for too long. I have a concrete proposal to move forward, #141792. I have checked that the failure we've seen in our infrastructure goes away with both changes applied. Given t

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-28 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao edited https://github.com/llvm/llvm-project/pull/139772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Trying to fix undefined symbol error caused by iterator variable (PR #141507)

2025-05-28 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: To expand on what I mean... For variables which have a strong definition, we usually don't emit them lazily: there's some statement or declaration which is the "definition" point, and we emit the definition as part of visiting that statement or decla

[clang] [llvm] [DirectX] Use resource names when generating DXIL metadata (PR #140635)

2025-05-28 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/140635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-28 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Many thanks for engaging in this discussion and sorry for the delays in my responses too. https://github.com/llvm/llvm-project/pull/138227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-05-28 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Precommit CI found relevant failures; it looks like clang-tools-extra needs some updates as well https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] Reland "Add macro to suppress -Wunnecessary-virtual-specifier" (PR #141091)

2025-05-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux-lnt` running on `systemz-1` while building `clang,llvm` at step 13 "setup lit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/136/builds/4070 Here is the relevant piece of the buil

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-28 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka reopened https://github.com/llvm/llvm-project/pull/139772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [UBSan] Support src:*=sanitize for multiple ignorelists. (PR #141640)

2025-05-28 Thread Vitaly Buka via cfe-commits
@@ -44,13 +44,11 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask, bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName, StringRef Category) const { - unsigned NoSanLine = SSCL->inSectionBlame(Mask, "src", FileN

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

2025-05-28 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex converted_to_draft https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

2025-05-28 Thread Nick Sarnie via cfe-commits
sarnex wrote: Looks like the fix commit broke something again :( https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Preserve CXXParenListInitExpr in TreeTransform. (PR #138518)

2025-05-28 Thread Alexander Kornienko via cfe-commits
alexfh wrote: @cor3ntin thank you for the fix for the assertion failure! The problem described in https://github.com/llvm/llvm-project/pull/138518#issuecomment-2906596143 still remains though. https://github.com/llvm/llvm-project/pull/138518 ___ cfe

[clang] [Clang] Reset ArgPackSubstIndex before rewriting CTAD template parameters (PR #141741)

2025-05-28 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for the quick fix! https://github.com/llvm/llvm-project/pull/141741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-28 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/139772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Handle type compatibility of unnamed records (PR #141783)

2025-05-28 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/141783 >From deeb52c330fc0c1fbdbfe77403c1320d76fa460d Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 28 May 2025 10:51:07 -0400 Subject: [PATCH 1/3] [C23] Handle type compatibility of unnamed records At

[clang] 63385e7 - [clang][modules][deps]Remove -F option from test for clang-scan-deps (#141614)

2025-05-28 Thread via cfe-commits
Author: Jamie Schmeiser Date: 2025-05-28T12:30:45-04:00 New Revision: 63385e7fc94039e1af6a8f21bebf8974f9d4a2a7 URL: https://github.com/llvm/llvm-project/commit/63385e7fc94039e1af6a8f21bebf8974f9d4a2a7 DIFF: https://github.com/llvm/llvm-project/commit/63385e7fc94039e1af6a8f21bebf8974f9d4a2a7.dif

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-05-28 Thread Nick Sarnie via cfe-commits
sarnex wrote: Whoops, thanks! https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules][deps]Remove -F option from test for clang-scan-deps (PR #141614)

2025-05-28 Thread Jamie Schmeiser via cfe-commits
https://github.com/jamieschmeiser closed https://github.com/llvm/llvm-project/pull/141614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Handle type compatibility of unnamed records (PR #141783)

2025-05-28 Thread Aaron Ballman via cfe-commits
@@ -359,3 +359,35 @@ struct alignment { // c17-error {{redefinition of 'alignment'}} \ c23-error {{type 'struct alignment' has a member with an attribute which currently causes the types to be treated as though they are incompatible}} int x; }; + +//

[clang] [C23] Handle type compatibility of unnamed records (PR #141783)

2025-05-28 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/141783 >From deeb52c330fc0c1fbdbfe77403c1320d76fa460d Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 28 May 2025 10:51:07 -0400 Subject: [PATCH 1/4] [C23] Handle type compatibility of unnamed records At

[clang] [llvm] [DirectX] Use resource names when generating DXIL metadata (PR #140635)

2025-05-28 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/140635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-28 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,64 @@ +// RUN: %clang_cc1 %s -verify -Wimplicit-int-conversion +// RUN: %clang_cc1 %s -verify -Wimplicit-int-conversion -Wno-implicit-int-conversion-on-negation -DNO_DIAG + +char test_char(char x) { + return -x; +#ifndef NO_DIAG + // expected-warning@-2 {{implicit co

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-28 Thread Aaron Ballman via cfe-commits
@@ -352,6 +352,9 @@ Improvements to Clang's diagnostics - Now correctly diagnose a tentative definition of an array with static storage duration in pedantic mode in C. (#GH50661) +- Split diagnosis of implicit integer comparison on negation to a new diagnostic group ``-Wimp

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-28 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/139429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-28 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,64 @@ +// RUN: %clang_cc1 %s -verify -Wimplicit-int-conversion +// RUN: %clang_cc1 %s -verify -Wimplicit-int-conversion -Wno-implicit-int-conversion-on-negation -DNO_DIAG AaronBallman wrote: A better approach than using `-D` is to specify a prefix to

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-28 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! https://github.com/llvm/llvm-project/pull/139429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-05-28 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/6] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [llvm] [DirectX] Detect resources with identical overlapping binding (PR #140645)

2025-05-28 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/140645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Handle type compatibility of unnamed records (PR #141783)

2025-05-28 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/141783 >From deeb52c330fc0c1fbdbfe77403c1320d76fa460d Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 28 May 2025 10:51:07 -0400 Subject: [PATCH 1/5] [C23] Handle type compatibility of unnamed records At

[clang] [clang][modules][deps]Remove -F option from test for clang-scan-deps (PR #141614)

2025-05-28 Thread Cyndy Ishida via cfe-commits
cyndyishida wrote: > what is the correct way to enable support for -F in clang tests? @jamieschmeiser can you please answer my question? https://github.com/llvm/llvm-project/pull/141614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [clang][modules][deps]Remove -F option from test for clang-scan-deps (PR #141614)

2025-05-28 Thread Jamie Schmeiser via cfe-commits
jamieschmeiser wrote: I am looking into what is done elsewhere. Not relying on -F, as is now the case here, is one way (which doesn't really answer your question...) https://github.com/llvm/llvm-project/pull/141614 ___ cfe-commits mailing list cfe-co

[libcxx] [libcxxabi] [libunwind] [llvm] [libcxxabi][libunwind] Support for using LLVM libc (PR #134893)

2025-05-28 Thread Petr Hosek via cfe-commits
petrhosek wrote: @ldionne Ping? https://github.com/llvm/llvm-project/pull/134893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

2025-05-28 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer approved this pull request. https://github.com/llvm/llvm-project/pull/134651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [Sema] Fix bug in builtin AS override (PR #138141)

2025-05-28 Thread Jay Foad via cfe-commits
jayfoad wrote: > Thanks. I will wait for #137425 to be resolved, then rebase or convert this > PR as needed. It's merged now so can you rebase? https://github.com/llvm/llvm-project/pull/138141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [C2y] Handle FP-suffixes on prefixed octals (#141230) (PR #141695)

2025-05-28 Thread Naveen Seth Hanig via cfe-commits
@@ -1432,14 +1432,26 @@ void NumericLiteralParser::ParseNumberStartingWithZero(SourceLocation TokLoc) { Diags.Report(TokLoc, DiagId); ++s; DigitsBegin = s; -SawOctalPrefix = true; +radix = 8; naveen-seth wrote: I don't think the octal digi

[clang] [llvm] [HLSL][SPIR-V] Handle SV_Postion builtin in PS (PR #141759)

2025-05-28 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts created https://github.com/llvm/llvm-project/pull/141759 This PR goes on top of #138530 This commit is using the same mechanism as vk::ext_builtin_input to implement the SV_Position semantic input. The HLSL signature is not yet ready for DXIL, hence this commit only i

[libclc] [libclc] Move vload & vstore to CLC library (PR #141755)

2025-05-28 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/141755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I'm really in favor of this direction, this is great, thank you! I have a few suggestions here (and if there is good reason, feel free to ignore the ones re return-type & setting invalid in particular), but this is pretty good for me. https://github.co

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -1842,8 +1842,7 @@ void Parser::ProhibitCXX11Attributes(ParsedAttributes &Attrs, continue; if (AL.getKind() == ParsedAttr::UnknownAttribute) { if (WarnOnUnknownAttrs) -Diag(AL.getLoc(), diag::warn_unknown_attribute_ignored) -<< AL << AL.g

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/141305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -7867,15 +7865,16 @@ void Sema::checkUnusedDeclAttributes(Declarator &D) { void Sema::DiagnoseUnknownAttribute(const ParsedAttr &AL) { std::string NormalizedFullName = '\'' + AL.getNormalizedFullName() + '\''; + SourceRange NR = AL.getNormalizedRange();

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-05-28 Thread Erich Keane via cfe-commits
@@ -672,12 +672,13 @@ static Attr *ProcessStmtAttribute(Sema &S, Stmt *St, const ParsedAttr &A, !(A.existsInTarget(S.Context.getTargetInfo()) || (S.Context.getLangOpts().SYCLIsDevice && Aux && A.existsInTarget(*Aux { -S.Diag(A.getLoc(), A.isRegul

[clang] [clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-28 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu closed https://github.com/llvm/llvm-project/pull/141036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 06ee672 - [clang] Move opt level in clang toolchain to clang::ConstructJob start (#141036)

2025-05-28 Thread via cfe-commits
Author: Omar Ahmed Date: 2025-05-28T07:40:00-06:00 New Revision: 06ee672fc5222009d38fa8334b0b5438645f2a66 URL: https://github.com/llvm/llvm-project/commit/06ee672fc5222009d38fa8334b0b5438645f2a66 DIFF: https://github.com/llvm/llvm-project/commit/06ee672fc5222009d38fa8334b0b5438645f2a66.diff LO

[clang] [llvm] Support the inline asm 'a' constraint on PowerPC (PR #141604)

2025-05-28 Thread Kamau Bridgeman via cfe-commits
kamaub wrote: After discussion with the IBM llvm on power team I will separate the type promotion error test case file into another patch as the error is only exposed by, not caused by this patch. https://github.com/llvm/llvm-project/pull/141604 ___

[clang] [llvm] Support the inline asm 'a' constraint on PowerPC (PR #141604)

2025-05-28 Thread Kamau Bridgeman via cfe-commits
https://github.com/kamaub edited https://github.com/llvm/llvm-project/pull/141604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Trying to fix undefined symbol error caused by iterator variable (PR #141507)

2025-05-28 Thread via cfe-commits
@@ -2969,6 +2969,11 @@ static LValue EmitGlobalVarDeclLValue(CodeGenFunction &CGF, llvm::Value *V = CGF.CGM.GetAddrOfGlobalVar(VD); + if (VD->hasAttr()) { +llvm::GlobalVariable *Var = llvm::dyn_cast(V); +Var->setInitializer(CGF.CGM.EmitNullConstant(E->getType()));

[clang] [llvm] [HLSL][SPIR-V] Handle SV_Postion builtin in PS (PR #141759)

2025-05-28 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts updated https://github.com/llvm/llvm-project/pull/141759 From 085154ddedf3b0789a3908231d04f997e9e66ac4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= Date: Wed, 30 Apr 2025 11:06:55 +0200 Subject: [PATCH 1/8] [HLSL] Implement vk::ext_builtin_input attr

[clang] 857ffa1 - [clang][bytecode] Recursively start lifetimes as well (#141742)

2025-05-28 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-28T16:16:00+02:00 New Revision: 857ffa19156695a36798660326922a3537ab828a URL: https://github.com/llvm/llvm-project/commit/857ffa19156695a36798660326922a3537ab828a DIFF: https://github.com/llvm/llvm-project/commit/857ffa19156695a36798660326922a3537ab828a.diff L

[clang] [clang][bytecode] Recursively start lifetimes as well (PR #141742)

2025-05-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM, AArch64] Don't put BTI at asm goto branch targets (PR #141562)

2025-05-28 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm updated https://github.com/llvm/llvm-project/pull/141562 >From 1be326ffb4350f2818068da1aa4bde2adae41d70 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Wed, 14 May 2025 17:02:21 +0100 Subject: [PATCH 1/3] [ARM,AArch64] Don't put BTI at asm goto branch targets I

[clang] [C23] Handle type compatibility of unnamed records (PR #141783)

2025-05-28 Thread Mariya Podchishchaeva via cfe-commits
@@ -359,3 +359,29 @@ struct alignment { // c17-error {{redefinition of 'alignment'}} \ c23-error {{type 'struct alignment' has a member with an attribute which currently causes the types to be treated as though they are incompatible}} int x; }; + +//

[clang] [llvm] [UBSan] Support src:*=sanitize for multiple ignorelists. (PR #141640)

2025-05-28 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao closed https://github.com/llvm/llvm-project/pull/141640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >