llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balazs Benics (steakhal)
Changes
Resolves
https://github.com/llvm/llvm-project/issues/76208#issuecomment-2830854351
Quoting the docs of `[[clang::flag_enum]]`:
https://clang.llvm.org/docs/AttributeReference.html#flag-enu
@@ -16,6 +16,11 @@
// RUN:-resource-dir=%S/Inputs/resource_dir_with_per_target_subdir\
// RUN: | FileCheck --check-prefix=PRINT-RUNTIME-DIR64-PER-TARGET %s
+// RUN: %clang -print-runtime-dir --target=powerpc-ibm-aix-unknown \
+// RUN:-resource-dir=%S/Input
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134644
>From fece69dc87e3c303aaba742f322377fd361e21ce Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 18:53:31 +0100
Subject: [PATCH 1/3] [KeyInstr][Clang] Do stmt atom
See test comment for
@@ -1242,9 +1242,17 @@ void CodeGenFunction::EmitDoStmt(const DoStmt &S,
// As long as the condition is true, iterate the loop.
if (EmitBoolCondBranch) {
uint64_t BackedgeCount = getProfileCount(S.getBody()) - ParentCount;
-Builder.CreateCondBr(
+auto *I = Build
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// RUN: %clang_cc1 -gkey-instructions -x c %s
-debug-info-kin
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// RUN: %clang_cc1 -gkey-instructions -x c %s
-debug-info-kin
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1242,9 +1242,17 @@ void CodeGenFunction::EmitDoStmt(const DoStmt &S,
// As long as the condition is true, iterate the loop.
if (EmitBoolCondBranch) {
uint64_t BackedgeCount = getProfileCount(S.getBody()) - ParentCount;
-Builder.CreateCondBr(
+auto *I = Build
Author: Orlando Cazalet-Hyams
Date: 2025-05-23T14:31:18+01:00
New Revision: 189d5dad364a402c79901cea2c9cdac03b7c5560
URL:
https://github.com/llvm/llvm-project/commit/189d5dad364a402c79901cea2c9cdac03b7c5560
DIFF:
https://github.com/llvm/llvm-project/commit/189d5dad364a402c79901cea2c9cdac03b7c55
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134651
>From bf3a37df3a82797227e476485f6cf4c0c9a7c912 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 4 Apr 2025 14:36:43 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Store-like builtin atoms
---
clan
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/140971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Erich Keane
Date: 2025-05-23T07:04:46-07:00
New Revision: 23d4756c4bfce06a98c9c03b24752d32760ac22b
URL:
https://github.com/llvm/llvm-project/commit/23d4756c4bfce06a98c9c03b24752d32760ac22b
DIFF:
https://github.com/llvm/llvm-project/commit/23d4756c4bfce06a98c9c03b24752d32760ac22b.diff
L
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,Balazs Benics ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Repl
https://github.com/zibi2 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/141110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/141238
`static_assert(std::is_xx_v);` is a common pattern to check that a type
meets a requirement.
This patch produces diagnostics notes when such assertion fails. The first type
trait for which we provide detailed
https://github.com/Xazax-hun commented:
Should we still warn if we store a negative value or a value >= 2*last member?
https://github.com/llvm/llvm-project/pull/141232
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/141232
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
`static_assert(std::is_xx_v);` is a common pattern to check that
a type meets a requirement.
This patch produces diagnostics notes when such assertion fails. The first type
trait for which we provide d
cor3ntin wrote:
I started to move some logic to SemaTypeTraits.cpp to keep the size of
SemaExprCXX.cpp reasonable
https://github.com/llvm/llvm-project/pull/141238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -1762,6 +1762,29 @@ def err_user_defined_msg_constexpr : Error<
"%sub{subst_user_defined_msg}0 must be produced by a "
"constant expression">;
+// Type traits explanations
+def note_unsatisfied_trait : Note<"%0 is not %enum_select{"
+ "%
@@ -0,0 +1,539 @@
+//===- SemaTypeTraits.cpp - Semantic Analysis for C++ Type Traits
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -5590,69 +5590,8 @@ static bool isTriviallyEqualityComparableType(Sema &S,
QualType Type, SourceLoca
CanonicalType, /*CheckIfTriviallyCopyable=*/false);
}
-static bool IsCXXTriviallyRelocatableType(Sema &S, const CXXRecordDecl *RD) {
- if (std::optional Info =
-
@@ -0,0 +1,539 @@
+//===- SemaTypeTraits.cpp - Semantic Analysis for C++ Type Traits
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/OCHyams closed
https://github.com/llvm/llvm-project/pull/134644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134645
>From 984039ede0eb3626feaeaa74f875165f4c5d91d1 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 18:49:32 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] While stmt atom
See test comment f
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134646
>From 8be98dcf4e19f1971a03ad072336f0e0e9c67a55 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:12:47 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] For stmt atom
This patch is part o
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Orlando Cazalet-Hyams
Date: 2025-05-23T14:42:28+01:00
New Revision: 6bd3543a4d2977cb63f7212594ea0f2ac6e8ab12
URL:
https://github.com/llvm/llvm-project/commit/6bd3543a4d2977cb63f7212594ea0f2ac6e8ab12
DIFF:
https://github.com/llvm/llvm-project/commit/6bd3543a4d2977cb63f7212594ea0f2ac6e8ab
https://github.com/OCHyams closed
https://github.com/llvm/llvm-project/pull/134645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/141232
Resolves
https://github.com/llvm/llvm-project/issues/76208#issuecomment-2830854351
Quoting the docs of `[[clang::flag_enum]]`:
https://clang.llvm.org/docs/AttributeReference.html#flag-enum
> This attribute ca
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,Balazs Benics ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Repl
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,Balazs Benics ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Repl
Author: Daan De Meyer
Date: 2025-05-23T16:40:28+02:00
New Revision: 5ff175233ee578b117ec7fddef3316c6b3160624
URL:
https://github.com/llvm/llvm-project/commit/5ff175233ee578b117ec7fddef3316c6b3160624
DIFF:
https://github.com/llvm/llvm-project/commit/5ff175233ee578b117ec7fddef3316c6b3160624.diff
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/141216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jakeegan updated
https://github.com/llvm/llvm-project/pull/140850
>From 120423abadbfd63dbb50387fb5ce26ff0f3ff257 Mon Sep 17 00:00:00 2001
From: Jake Egan
Date: Wed, 21 May 2025 01:51:00 -0400
Subject: [PATCH 1/5] Handle triple environment component for target runtime
directo
NagyDonat wrote:
> I don't think I have time for this. I'm really sorry. I read the first couple
> paragraphs then gave up. I'm really short of time.
The two commits made sense. And resolved most if not all of my major concerns.
I see, and I understand that this review process became much longe
eZWALT wrote:
> > @alexey-bataev After conducting an examination of the directive handling
> > logic, I can confidently state that the number of generated loops
> > (`NumGeneratedLoops`) does not affect the semantic checks for the majority
> > of transformations. This is because values are usu
alexey-bataev wrote:
What I see in the source code that it is used as a boolean flag. Can we
transform it to bool? There is no need to keep it integer
https://github.com/llvm/llvm-project/pull/140532
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/140971
>From ec6359330368ed72d6e4354afdcf6d0a32f9a2f9 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Tue, 20 May 2025 08:55:39 -0700
Subject: [PATCH 1/2] [OpenACC][CIR] Add lowering for 'copy' array indexes
The ar
Author: Orlando Cazalet-Hyams
Date: 2025-05-23T13:46:37+01:00
New Revision: 123bf5f46c31a016768b7ecd9b164bde5ef881d9
URL:
https://github.com/llvm/llvm-project/commit/123bf5f46c31a016768b7ecd9b164bde5ef881d9
DIFF:
https://github.com/llvm/llvm-project/commit/123bf5f46c31a016768b7ecd9b164bde5ef881
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/117953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134644
>From fece69dc87e3c303aaba742f322377fd361e21ce Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 18:53:31 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Do stmt atom
See test comment for
https://github.com/erichkeane approved this pull request.
Seems reasonable
https://github.com/llvm/llvm-project/pull/141163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134645
>From 984039ede0eb3626feaeaa74f875165f4c5d91d1 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 18:49:32 +0100
Subject: [PATCH 1/3] [KeyInstr][Clang] While stmt atom
See test comment f
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -19,7 +19,7 @@ class UseNullptrCheck : public ClangTidyCheck {
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
// FIXME this should be CPlusPlus11 but that causes test cases to
// erroneously fail.
-return LangOpts.CPlusPlus || Lan
@@ -2901,34 +2907,44 @@ class CallExpr : public Expr {
//
// * An optional of type FPOptionsOverride.
//
- // Note that we store the offset in bytes from the this pointer to the start
- // of the trailing objects. It would be perfectly possible to compute it
- // based
@@ -2901,34 +2907,44 @@ class CallExpr : public Expr {
//
// * An optional of type FPOptionsOverride.
//
- // Note that we store the offset in bytes from the this pointer to the start
- // of the trailing objects. It would be perfectly possible to compute it
- // based
steakhal wrote:
> Should we still warn if we store a negative value or a value >= 2*last member?
I was thinking about this but I chose the simplest way to suppress these.
https://github.com/llvm/llvm-project/pull/141232
___
cfe-commits mailing list
cf
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/141202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
@cor3ntin yep, the second test case I have doesn't seem to be directly related.
It causes crashes to Clang since version 7: https://gcc.godbolt.org/z/6M13c4q3T
https://github.com/llvm/llvm-project/pull/138518
___
cfe-commits mailing list
@@ -44,7 +44,10 @@ internal::Matcher callToGet(const
internal::Matcher &OnClass) {
}
internal::Matcher knownSmartptr() {
- return recordDecl(hasAnyName("::std::unique_ptr", "::std::shared_ptr"));
+ return recordDecl(
+ hasAnyName("::std::unique_ptr", "::std::shared_ptr
https://github.com/kadircet requested changes to this pull request.
thanks a lot for taking a lookg here!
https://github.com/llvm/llvm-project/pull/141092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
alexfh wrote:
I've filed https://github.com/llvm/llvm-project/issues/141242 for the second
report. However
https://github.com/llvm/llvm-project/pull/138518#issuecomment-2903017423 is new
and still needs to be addressed.
https://github.com/llvm/llvm-project/pull/138518
NagyDonat wrote:
Thanks for your understanding – and sorry for stretching this review process
for so long.
I will push and merge the reduced commit on Monday (to be able to follow up its
effect in the CI). I will probably also create a spinoff PR that contains some
minor NFC code quality impr
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang/lib/Sema/SemaTypeTraits.cpp clang/lib/Sema/Sema
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134638
>From fa1c06148d4f79e9464d92ab5c26d9a22c5bf41d Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 13:36:59 +0100
Subject: [PATCH 1/8] [KeyInstr] Complex assignment atoms
This patch is pa
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jmorse approved this pull request.
(LGTM with the braces)
https://github.com/llvm/llvm-project/pull/134641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eZWALT wrote:
> What I see in the source code that it is used as a boolean flag. Can we
> transform it to bool? There is no need to keep it integer
Please could you cite the exact line? I'm not sure if you are refering to the
logic inside checkTransformableLoopNest or not.
https://github.com/
https://github.com/jmorse edited
https://github.com/llvm/llvm-project/pull/134643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,51 @@
+// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank --check-prefixes=CHECK,CHECK-CXX
+
+// RUN: %clang_cc1 -gkey-inst
alexey-bataev wrote:
> > What I see in the source code that it is used as a boolean flag. Can we
> > transform it to bool? There is no need to keep it integer
>
> Please could you cite the exact line? I'm not sure if you are refering to the
> logic inside checkTransformableLoopNest or not.
I
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/141238
>From 19ed57f333a63665f7bc6808d353fe1fa7eea78a Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Wed, 21 May 2025 23:10:36 +0200
Subject: [PATCH] [Clang] Explain why a type trait evaluated to false.
`static_
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Dan McGregor (dankm)
Changes
Apply the debug prefix mapping to the OpenMP location strings.
Fixes https://github.com/llvm/llvm-project/issues/82541
---
Full diff: https://github.com/llvm/llvm-project/pull/141250.diff
1 Files Aff
dankm wrote:
I do need to add tests for this, but wanted to get the general idea up for
comments.
https://github.com/llvm/llvm-project/pull/141250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/dankm created
https://github.com/llvm/llvm-project/pull/141250
Apply the debug prefix mapping to the OpenMP location strings.
Fixes https://github.com/llvm/llvm-project/issues/82541
>From 6a6c63abc2ff2dd594f82a5ad92f01aee5bdd37a Mon Sep 17 00:00:00 2001
From: Dan McGregor
D
@@ -1427,13 +1427,13 @@ OpFoldResult cir::SelectOp::fold(FoldAdaptor adaptor) {
//===--===//
LogicalResult cir::ShiftOp::verify() {
mlir::Operation *op = getOperation();
- mlir::Type resType = getResult().g
https://github.com/dankm updated
https://github.com/llvm/llvm-project/pull/141250
>From 7fdc69f5c55074fa9d647b01f4a370a34c26f966 Mon Sep 17 00:00:00 2001
From: Dan McGregor
Date: Fri, 23 May 2025 10:19:22 -0600
Subject: [PATCH] [Clang] Remap paths in OpenMP runtime calls
Apply the debug prefix
@@ -1917,3 +1917,190 @@ ExprResult Sema::BuildExpressionTrait(ExpressionTrait
ET, SourceLocation KWLoc,
return new (Context)
ExpressionTraitExpr(KWLoc, ET, Queried, Value, RParen, Context.BoolTy);
}
+
+static std::optional StdNameToTypeTrait(StringRef Name) {
+ return
@@ -1917,3 +1917,190 @@ ExprResult Sema::BuildExpressionTrait(ExpressionTrait
ET, SourceLocation KWLoc,
return new (Context)
ExpressionTraitExpr(KWLoc, ET, Queried, Value, RParen, Context.BoolTy);
}
+
+static std::optional StdNameToTypeTrait(StringRef Name) {
+ return
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/141238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir wrote:
> I don't think we can ever get rid of that pattern and we will keep relying on
> Clang supporting this.
> We would need to example I shared above to keep working.
> I think the change we want is to always prioritize modular over textual,
> before we look at non-private vs p
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang/lib/CodeGen/CGOpenMPRuntime.cpp
``
ilovepi wrote:
> Reading files from unit tests is a bit of an anti-pattern: It requires
> putting the absolute path to the tests somewhere (you're doing this with a
> config file here), and it means you easily run tests on a different machine
> than the one you're building on. Could you restru
https://github.com/qinkunbao updated
https://github.com/llvm/llvm-project/pull/140964
>From 534d49d489476ffd1aa8f23d21a02f29d3b823fc Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Wed, 21 May 2025 22:12:13 +
Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/jmorse approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/134643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5748,7 +5752,8 @@ void CodeGenFunction::EmitOMPScanDirective(const
OMPScanDirective &S) {
}
CGM.getOpenMPRuntime().emitReduction(
*this, ParentDir.getEndLoc(), Privates, LHSs, RHSs, ReductionOps,
- {/*WithNowait=*/true, /*SimpleReduction=*/tr
@@ -3943,7 +3946,8 @@ static void emitScanBasedDirective(
PrivScope.Privatize();
CGF.CGM.getOpenMPRuntime().emitReduction(
CGF, S.getEndLoc(), Privates, LHSs, RHSs, ReductionOps,
- {/*WithNowait=*/true, /*SimpleReduction=*/true, OMPD_unknown});
+
@@ -5055,6 +5055,7 @@ void ItaniumCXXABI::emitBeginCatch(CodeGenFunction &CGF,
// Emit the local.
CodeGenFunction::AutoVarEmission var = CGF.EmitAutoVarAlloca(*CatchParam);
+ ApplyAtomGroup Grp(CGF.getDebugInfo());
InitCatchParam(CGF, *CatchParam, var.getObjectAddress(
benlangmuir wrote:
> I don't think we can ever get rid of that pattern and we will keep relying on
> Clang supporting this.
> We would need to example I shared above to keep working.
I don't have a strong opinion on the best path forward here, but I'm not clear
if you're actually willing to
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
Just to try to keep the size of SemaExprCXX.cpp in check.
As discussed in #141238
---
Patch is 147.71 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/141245.diff
4
OCHyams wrote:
Sorry I misunderstood what you were saying. Fixed, this should now have
symmetry with prior patches. Expanded the test coverage. There's 4 binop assign
calls that are instrumented individually which reflects the previous patch's
macro usage. The expanded test coverage identified
https://github.com/erichkeane approved this pull request.
Just a copy&paste refactor that makes a lot of sense. Thanks!
https://github.com/llvm/llvm-project/pull/141245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -1762,6 +1762,29 @@ def err_user_defined_msg_constexpr : Error<
"%sub{subst_user_defined_msg}0 must be produced by a "
"constant expression">;
+// Type traits explanations
+def note_unsatisfied_trait : Note<"%0 is not %enum_select{"
+ "%
Author: Finn Plummer
Date: 2025-05-23T09:01:43-07:00
New Revision: 7549f42a789b9b5c3aebe4e0a4498805542902a1
URL:
https://github.com/llvm/llvm-project/commit/7549f42a789b9b5c3aebe4e0a4498805542902a1
DIFF:
https://github.com/llvm/llvm-project/commit/7549f42a789b9b5c3aebe4e0a4498805542902a1.diff
1 - 100 of 341 matches
Mail list logo