[clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > > @jansvoboda11 I've revered your PR due buildbot failures above (and my > > local build failures with the same error messages). I'm happy to try your > > revised patch to see if it build cleanly. Thanks! > > I already forward-fixed both failures: > [d25f95f](https://g

[clang] 73fda83 - [Clang] Do not put the definition of concept nodes in the Sema library (#141104)

2025-05-22 Thread via cfe-commits
Author: cor3ntin Date: 2025-05-22T21:57:45+02:00 New Revision: 73fda8327539106d2644fd3c566e528564f74562 URL: https://github.com/llvm/llvm-project/commit/73fda8327539106d2644fd3c566e528564f74562 DIFF: https://github.com/llvm/llvm-project/commit/73fda8327539106d2644fd3c566e528564f74562.diff LOG:

[clang] [Clang] Do not put the definition of concept nodes in the Sema library (PR #141104)

2025-05-22 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/141104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > Thanks, I'll fix those ASAP. @jansvoboda11 Please feel free to add me as a reviewer. I am happy to build things with your fix. https://github.com/llvm/llvm-project/pull/139584 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
omarahmed wrote: @tarunprabhu @florianhumblot @alexey-bataev @RKSimon @phoebewang Not sure who to as for review, so please review or if you could mention who is responsible for reviewing this code, Thanks! https://github.com/llvm/llvm-project/pull/141036 ___

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/141131 None >From b57f5b1adb7bb7bd70f8c442d0a0031fa0aeed2a Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 22 May 2025 13:22:18 -0700 Subject: [PATCH] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Jan Svoboda (jansvoboda11) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141131.diff 2 Files Affected: - (modified) clang-tools-extra/clang-tidy/plugin/ClangTidyPlugin.cpp (+3-2) - (modified) clang/inclu

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Jan Svoboda (jansvoboda11) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141131.diff 2 Files Affected: - (modified) clang-tools-extra/clang-tidy/plugin/ClangTidyPlugin.cpp (+3-2) - (modified) clang/include/clan

[clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `clang-tools-extra,clang,lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/10

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/141131 >From b57f5b1adb7bb7bd70f8c442d0a0031fa0aeed2a Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 22 May 2025 13:22:18 -0700 Subject: [PATCH 1/2] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.c

[clang] Include [[clang::require_explicit_initialization]] warnings in system headers (PR #141133)

2025-05-22 Thread via cfe-commits
https://github.com/higher-performance created https://github.com/llvm/llvm-project/pull/141133 Fixes #141103 >From 0bdda2b593167bb7f75bea33da1f3adf4d8b6276 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Thu, 22 May 2025 16:30:29 -0400 Subject: [PATCH] Include [[clang::require_explicit

[clang] Include [[clang::require_explicit_initialization]] warnings in system headers (PR #141133)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (higher-performance) Changes Fixes #141103 --- Full diff: https://github.com/llvm/llvm-project/pull/141133.diff 1 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+2-1) ``diff diff --git a/c

[clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Thanks, I'll fix those ASAP. https://github.com/llvm/llvm-project/pull/139584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: @jansvoboda11 With this PR, I still see: ``` clang/lib/Frontend/LogDiagnosticPrinter.cpp:24:7: error: member initializer 'DiagOpts' does not name a non-static data member or base class 24 | DiagOpts(DiagOpts) {} | ^~ ``` Would you mind

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: I still see: ``` /usr/local/google/home/kazu/dev/llvm/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:163:37: error: no member named 'Retain' in 'clang::DiagnosticOptions' 163 | static void retain(T *obj) { obj->Retain(); } |

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > @jansvoboda11 With this PR, I still see: > > ``` > clang/lib/Frontend/LogDiagnosticPrinter.cpp:24:7: error: member initializer > 'DiagOpts' does not name a non-static data member or base class >24 | DiagOpts(DiagOpts) {} > | ^~ > ``` >

[clang-tools-extra] 656d9ba - [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (#141131)

2025-05-22 Thread via cfe-commits
Author: Jan Svoboda Date: 2025-05-22T13:39:54-07:00 New Revision: 656d9ba9346ad32aeffd5215c2bed43dfa710e16 URL: https://github.com/llvm/llvm-project/commit/656d9ba9346ad32aeffd5215c2bed43dfa710e16 DIFF: https://github.com/llvm/llvm-project/commit/656d9ba9346ad32aeffd5215c2bed43dfa710e16.diff L

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/141131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata approved this pull request. LGTM. I think this PR fixes all non-flang components AFAICT. Thanks! https://github.com/llvm/llvm-project/pull/141131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

2025-05-22 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Thank you too! https://github.com/llvm/llvm-project/pull/141131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFCI][Sanitizer] Convert Matcher::Globs from StringMap to vector. (PR #140964)

2025-05-22 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/140964 >From 534d49d489476ffd1aa8f23d21a02f29d3b823fc Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Wed, 21 May 2025 22:12:13 + Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang] [llvm] [NFCI][Sanitizer] Convert Matcher::Globs from StringMap to vector. (PR #140964)

2025-05-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/lib/Basic/Diagnostic.cpp llvm/include/llvm/Su

[clang] [libcxx] [llvm] Add unnecessary-virtual-specifier to -Wextra (PR #138741)

2025-05-22 Thread Martin Storsjö via cfe-commits
@@ -882,6 +882,11 @@ if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL)) # The LLVM libraries have no stable C++ API, so -Wnoexcept-type is not useful. append("-Wno-noexcept-type" CMAKE_CXX_FLAGS) + # LLVM has a policy of including virtual "ancho

[clang] [Clang][CodeGen] Add metadata for load from reference (PR #98746)

2025-05-22 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,59 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -std=c++11 -O1 -disable-llvm-passes %s -o - | FileCheck %s + +struct alignas(32) F { int x; }; + +struct

[clang] [Clang][CodeGen] Add metadata for load from reference (PR #98746)

2025-05-22 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/98746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add metadata for load from reference (PR #98746)

2025-05-22 Thread Eli Friedman via cfe-commits
@@ -2916,9 +2916,30 @@ CodeGenFunction::EmitLoadOfReference(LValue RefLVal, llvm::LoadInst *Load = Builder.CreateLoad(RefLVal.getAddress(), RefLVal.isVolatile()); CGM.DecorateInstructionWithTBAA(Load, RefLVal.getTBAAInfo()); - return makeNaturalAddressForPointer(Load

[clang] [Clang][CodeGen] Add metadata for load from reference (PR #98746)

2025-05-22 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: So for ubsan, we have checks when you construct a reference, and you think that's sufficient? I guess that's probably fine. At least, I don't think we need to revisit that decision here. (I suspect it might make sense to check references that come

[clang] [Clang][CodeGen] Add metadata for load from reference (PR #98746)

2025-05-22 Thread Eli Friedman via cfe-commits
@@ -20,10 +20,10 @@ void test_add_template() { // CHECK: %call = call noundef <10 x float> @_Z3addIfLj2ELj5EEN8MyMatrixIT_XT0_EXT1_EE8matrix_tERS2_S4_(ptr noundef nonnull align 4 dereferenceable(40) %Mat1, ptr noundef nonnull align 4 dereferenceable(40) %Mat2) //

[clang] Include [[clang::require_explicit_initialization]] warnings in system headers (PR #141133)

2025-05-22 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Testcase? This seems like the sort of thing where we might want to cooperate with the C++ library somehow to get better diagnostics, but getting some diagnostic seems like an improvement. https://github.com/llvm/llvm-project/pull/141133 ___

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/141139 This patch re-enables -ftime-trace support in clang-doc. Initial support in #97644 was reverted, and never relanded. This patch adds back the command line option, and leverages the RAII tracing infrastructure mor

[clang] 0c42aef - [HLSL][RootSignature] Add parsing of Register in params for RootDescriptors (#140148)

2025-05-22 Thread via cfe-commits
Author: Finn Plummer Date: 2025-05-22T14:07:24-07:00 New Revision: 0c42aeff9e2ec4aa41952ef24fd6b56789d3e404 URL: https://github.com/llvm/llvm-project/commit/0c42aeff9e2ec4aa41952ef24fd6b56789d3e404 DIFF: https://github.com/llvm/llvm-project/commit/0c42aeff9e2ec4aa41952ef24fd6b56789d3e404.diff

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#141139** https://app.graphite.dev/github/pr/llvm/llvm-project/141139?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1411

[clang] [llvm] [HLSL][RootSignature] Add parsing of Register in params for RootDescriptors (PR #140148)

2025-05-22 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/140148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) Changes This patch re-enables -ftime-trace support in clang-doc. Initial support in #97644 was reverted, and never relanded. This patch adds back the command line option, and leverages the RAII tracing infra

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: I'm not sure I want to land this before I land the main support for Mustache templates. I think its easier to rebase this patch, than that whole stack. https://github.com/llvm/llvm-project/pull/141139 ___ cfe-comm

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/141139 >From 7f51d821b16e71a8834f7560c25268bd02c264df Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 21 May 2025 09:50:32 -0700 Subject: [PATCH] [clang-doc] Reenable time trace support This patch re-enables -fti

[clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `clang-tools-extra,clang,lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/10

[clang] [llvm] [HLSL][RootSignature] Add parsing of optional parameters for RootDescriptor (PR #140151)

2025-05-22 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/140151 >From 57d166785f06fcdb8e9c9a1b796ec89a9cc91070 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 15 May 2025 20:07:51 + Subject: [PATCH 1/2] [HLSL][RootSignature] Add parsing of optional parameters for

[clang] [llvm] [HLSL][RootSignature] Add parsing of optional parameters for RootDescriptor (PR #140151)

2025-05-22 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/140151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSignature] Add parsing of optional parameters for RootDescriptor (PR #140151)

2025-05-22 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/140151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Erick Velez via cfe-commits
https://github.com/evelez7 updated https://github.com/llvm/llvm-project/pull/140856 >From e25581d28ecda89fe4e550da71e668b6ae749804 Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Tue, 20 May 2025 23:26:02 -0700 Subject: [PATCH 1/2] [clang-doc] fix conversion names of dependent types Fixes #59

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 86dc2be43374138ecea82f0266f8b8ae7ac17f4e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 22, 9:19 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138062). https://github.com/llvm/llvm-project/pull/138062

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138063 >From afa7c63c997dcfee4b50a0b5a4aa0f17b74a0ac1 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:11:39 -0700 Subject: [PATCH] [clang-doc] Extract Info into JSON values Split from #133161. This

[clang-tools-extra] 97dee78 - [clang-doc] Add helpers for Template config (#138062)

2025-05-22 Thread via cfe-commits
Author: Paul Kirth Date: 2025-05-22T14:20:08-07:00 New Revision: 97dee78eb364efab6ddb57bc6580c55971994f41 URL: https://github.com/llvm/llvm-project/commit/97dee78eb364efab6ddb57bc6580c55971994f41 DIFF: https://github.com/llvm/llvm-project/commit/97dee78eb364efab6ddb57bc6580c55971994f41.diff LO

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFCI][Sanitizer] Convert Matcher::Globs from StringMap to vector. (PR #140964)

2025-05-22 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/140964 >From 534d49d489476ffd1aa8f23d21a02f29d3b823fc Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Wed, 21 May 2025 22:12:13 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Fix atomic compare handling with overloaded operators (PR #141142)

2025-05-22 Thread Shilei Tian via cfe-commits
@@ -11762,52 +11762,98 @@ bool OpenMPAtomicCompareChecker::checkCondUpdateStmt(IfStmt *S, X = BO->getLHS(); - auto *Cond = dyn_cast(S->getCond()); - if (!Cond) { -ErrorInfo.Error = ErrorTy::NotABinaryOp; -ErrorInfo.ErrorLoc = ErrorInfo.NoteLoc = S->getCond()->get

[clang] move ASTImporter into separate library (PR #140913)

2025-05-22 Thread Balázs Kéri via cfe-commits
balazske wrote: > > The problem was that nodes like `concepts::TypeRequirement` have > > constructors (and probably other related functions) defined in > > SemaConcepts.cpp. These can not be linked to the AST library, but are > > needed in `ASTImporter` for the new import functions. > > Can y

[clang] ClangFormat: Insert braces & newline for Chromium (PR #140888)

2025-05-22 Thread Victor Vianna via cfe-commits
https://github.com/victorvianna updated https://github.com/llvm/llvm-project/pull/140888 >From 84099188f343220d48b56f164c7f541d8515f629 Mon Sep 17 00:00:00 2001 From: Victor Hugo Vianna Silva Date: Thu, 22 May 2025 10:47:09 +0100 Subject: [PATCH] ClangFormat: Insert braces & newline for Chromiu

[clang] ClangFormat: Insert braces & newline for Chromium (PR #140888)

2025-05-22 Thread Victor Vianna via cfe-commits
https://github.com/victorvianna deleted https://github.com/llvm/llvm-project/pull/140888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ClangFormat: Insert braces & newline for Chromium (PR #140888)

2025-05-22 Thread Victor Vianna via cfe-commits
@@ -1892,6 +1892,9 @@ FormatStyle getChromiumStyle(FormatStyle::LanguageKind Language) { ChromiumStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Preserve; + ChromiumStyle.InsertBraces = true; victorvianna wrote: Done https://github.co

[clang] ClangFormat: Insert braces & newline for Chromium (PR #140888)

2025-05-22 Thread Victor Vianna via cfe-commits
@@ -1892,6 +1892,9 @@ FormatStyle getChromiumStyle(FormatStyle::LanguageKind Language) { ChromiumStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Preserve; + ChromiumStyle.InsertBraces = true; victorvianna wrote: Ack, abandoning then h

[clang] [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (PR #140532)

2025-05-22 Thread Walter J.T.V via cfe-commits
eZWALT wrote: After conducting an examination of the directive handling logic, I can confidently state that the number of generated loops (`NumGeneratedLoops`) does not affect the semantic checks for the majority of transformations. This is because values are usually hardcoded in the `ActOnXXX

[clang] [Clang] Fix a regression introduced by #140576 (PR #140859)

2025-05-22 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/140859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations" (PR #139739)

2025-05-22 Thread Michael Jabbour via cfe-commits
michael-jabbour-sonarsource wrote: Gentle ping :smile: I would also appreciate any opinions on my previous comment, maybe this can help us align on a solution that satisfies all users... https://github.com/llvm/llvm-project/pull/139739 ___ cfe-commit

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation directive and "looprange" clause (PR #139293)

2025-05-22 Thread Walter J.T.V via cfe-commits
https://github.com/eZWALT edited https://github.com/llvm/llvm-project/pull/139293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation directive and "looprange" clause (PR #139293)

2025-05-22 Thread Walter J.T.V via cfe-commits
https://github.com/eZWALT edited https://github.com/llvm/llvm-project/pull/139293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation directive and "looprange" clause (PR #139293)

2025-05-22 Thread Walter J.T.V via cfe-commits
@@ -1480,6 +1493,108 @@ class SemaOpenMP : public SemaBase { SmallVectorImpl &LoopHelpers, Stmt *&Body, SmallVectorImpl> &OriginalInits); + /// @brief Categories of loops encountered during semantic OpenMP loop + /// analysis + /// + /// This enumeration identi

[clang] ClangFormat: Insert braces & newline for Chromium (PR #140888)

2025-05-22 Thread Victor Vianna via cfe-commits
https://github.com/victorvianna closed https://github.com/llvm/llvm-project/pull/140888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ClangFormat: Insert braces & newline for Chromium (PR #140888)

2025-05-22 Thread Victor Vianna via cfe-commits
@@ -5904,7 +5904,7 @@ TEST_F(FormatTest, MacrosWithoutTrailingSemicolon) { getLLVMStyleWithColumns(60)); verifyFormat("VISIT_GL_CALL(GenBuffers, void, (GLsizei n, GLuint* buffers), " - "(n, buffers))", + "(n, buffers))\n",

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -1,15 +1,26 @@ -; REQUIRES: x86, non-root-user -;; Not supported on windows since we use permissions to deny the creation -; UNSUPPORTED: system-windows +;; The output is OS-specific, so this test is limited to Windows. arsenm wrote: Switching a test from "not

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-22 Thread Oliver Hunt via cfe-commits
@@ -105,6 +105,13 @@ def note_replace_abs_function : Note<"use function '%0' instead">; def warn_pointer_abs : Warning< "taking the absolute value of %select{pointer|function|array}0 type %1 is suspicious">, InGroup; + +// Lambda capture diagnostics + +def err_invalid_l

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -744,7 +744,7 @@ template class [[nodiscard]] Expected { /// @deprecated Use reportFatalInternalError() or reportFatalUsageError() /// instead. [[noreturn]] LLVM_ABI void report_fatal_error(Error Err, - bool gen_crash_diag = true

[clang] [CIR] Simplify error emission to return failures directly (PR #141032)

2025-05-22 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/141032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Simplify error emission to return failures directly (PR #141032)

2025-05-22 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/141032 Mirrors incubator changes from https://github.com/llvm/clangir/pull/1634 >From f5755844c4937c1d691b393b4be9d70c1f2a1f88 Mon Sep 17 00:00:00 2001 From: xlauko Date: Thu, 22 May 2025 12:24:14 +0200 Subject: [PATCH

[clang] [CIR] Simplify error emission to return failures directly (PR #141032)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrich Lauko (xlauko) Changes Mirrors incubator changes from https://github.com/llvm/clangir/pull/1634 --- Full diff: https://github.com/llvm/llvm-project/pull/141032.diff 2 Files Affected: - (modified) clang/lib/CIR/Dialect/IR/CIRAttr

[clang] [CIR] Implement `AnyScalarType` constraint (PR #141033)

2025-05-22 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/141033 This mirrors changes from https://github.com/llvm/clangir/pull/1625 >From 5331a40eaa4083d698074d9b5c11d22f9bcf3a59 Mon Sep 17 00:00:00 2001 From: xlauko Date: Thu, 22 May 2025 10:39:55 +0200 Subject: [PATCH] [CI

[clang] [CIR] Implement `AnyScalarType` constraint (PR #141033)

2025-05-22 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/141033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Implement `AnyScalarType` constraint (PR #141033)

2025-05-22 Thread Henrich Lauko via cfe-commits
xlauko wrote: * **#141033** https://app.graphite.dev/github/pr/llvm/llvm-project/141033?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/14103

[clang] [CIR] Implement `AnyScalarType` constraint (PR #141033)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrich Lauko (xlauko) Changes This mirrors incubator changes from https://github.com/llvm/clangir/pull/1625 --- Full diff: https://github.com/llvm/llvm-project/pull/141033.diff 1 Files Affected: - (modified) clang/include/clang/CIR/Dia

[clang] [CIR] Implement `AnyScalarType` constraint (PR #141033)

2025-05-22 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/141033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread Nikita Popov via cfe-commits
@@ -61,11 +61,14 @@ struct ScopedFatalErrorHandler { /// @deprecated Use reportFatalInternalError() or reportFatalUsageError() /// instead. [[noreturn]] LLVM_ABI void report_fatal_error(const char *reason, - bool gen_crash_diag = tru

[clang] [Clang] Move opt level in clang toolchain to beginning (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed created https://github.com/llvm/llvm-project/pull/141036 We currently transfer the opt level from the user clang call to CC1 args at the end of the `ConstructJob` function, this might lead to bugs as `ConstructJob` is a big function and we easily could add a ch

[clang] [Clang] Move opt level in clang toolchain to beginning (PR #141036)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Omar Ahmed (omarahmed) Changes We currently transfer the opt level from the user clang call to CC1 args at the end of the `ConstructJob` function, this might lead to bugs as `ConstructJob` is a big function and we easily could

[clang] 7a3b5d7 - [C] Fix crash-on-invalid due to infinite recursion (#140925)

2025-05-22 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-05-22T06:47:34-04:00 New Revision: 7a3b5d789d5fee6fe9883b6a3cb9d2ede4262276 URL: https://github.com/llvm/llvm-project/commit/7a3b5d789d5fee6fe9883b6a3cb9d2ede4262276 DIFF: https://github.com/llvm/llvm-project/commit/7a3b5d789d5fee6fe9883b6a3cb9d2ede4262276.diff

[clang] [C] Fix crash-on-invalid due to infinite recursion (PR #140925)

2025-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/140925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher created https://github.com/llvm/llvm-project/pull/141037 This patch adds support for the `q` constraint: a general-purpose register except for $r0 and $r1 (for the csrxchg instruction) Link: https://gcc.gnu.org/pipermail/gcc-patches/2025-May/684339.html >From 0cea24ae

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-loongarch Author: hev (heiher) Changes This patch adds support for the `q` constraint: a general-purpose register except for $r0 and $r1 (for the csrxchg instruction) Link: https://gcc.gnu.org/pipermail/gcc-patches/2025-May/684339.html --- Full

[clang] [Sema] Warn about omitting deprecated enumerator in switch (PR #138562)

2025-05-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Thanks Aaron, that's a good example. > > This is a pickle; it doesn't seem like there's an obviously Right > Solution(tm) here. That's the same conclusion I'm coming to. These situations are kind of mutually exclusive. > I think we're agreeing on the first part, that un

[clang] [Sema] Warn about omitting deprecated enumerator in switch (PR #138562)

2025-05-22 Thread Hans Wennborg via cfe-commits
@@ -6009,6 +6009,8 @@ def note_not_found_by_two_phase_lookup : Note<"%0 should be declared prior to th def err_undeclared_use : Error<"use of undeclared %0">; def warn_deprecated : Warning<"%0 is deprecated">, InGroup; +def warn_deprecated_switch_case : Warning<"%0 is depr

[clang] [libcxx] [Clang] Add __builtin_invoke and use it in libc++ (PR #116709)

2025-05-22 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > Thanks for working on that. Do you have any benchmarks? I haven't benchmarked extensively, but as stated in the commit message, The instantiation of `std::format` is ~20ms faster. IMO that's a significant enough speedup on its own that it grants adding a builtin. I've jus

[clang] [Sema] Warn about omitting deprecated enumerator in switch (PR #138562)

2025-05-22 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem updated https://github.com/llvm/llvm-project/pull/138562 >From e221ba3b0f7b08bcfc56bf75f7505265c332637d Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: Mon, 5 May 2025 20:24:15 +0200 Subject: [PATCH 1/8] [Sema] Warn about omitting deprecated enumerator in switch T

[clang] [clang] Use llvm::is_contained (NFC) (PR #140985)

2025-05-22 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/140985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Add __builtin_invoke and use it in libc++ (PR #116709)

2025-05-22 Thread Nikolas Klauser via cfe-commits
@@ -6540,67 +6540,70 @@ ExprResult Sema::ActOnTypeTrait(TypeTrait Kind, SourceLocation KWLoc, return BuildTypeTrait(Kind, KWLoc, ConvertedArgs, RParenLoc); } -static bool EvaluateBinaryTypeTrait(Sema &Self, TypeTrait BTT, const TypeSourceInfo *Lhs, -

[clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu-no-asserts` running on `doug-worker-6` while building `bolt,clang,flang,lld,lldb,mlir,polly` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/bui

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-22 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > And I'm not sure such a use case is worth supporting. > But I understand that is only my own interpretation which can be incorrect. > And I want to believe you have a better use case that doesn't rely on > accessing private headers The code I shared compiles with no er

[clang] [clang] Use llvm::is_contained (NFC) (PR #140985)

2025-05-22 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/140985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7cfeedf - [clang][bytecode] Change diagnostics for self-initialization (#141006)

2025-05-22 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-22T10:31:39+02:00 New Revision: 7cfeedf64addf6d20bdf47a669936ba6e46593d8 URL: https://github.com/llvm/llvm-project/commit/7cfeedf64addf6d20bdf47a669936ba6e46593d8 DIFF: https://github.com/llvm/llvm-project/commit/7cfeedf64addf6d20bdf47a669936ba6e46593d8.diff L

[clang] [clang][bytecode] Change diagnostics for self-initialization (PR #141006)

2025-05-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] move ASTImporter into separate library (PR #140913)

2025-05-22 Thread via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: cor3ntin wrote: > The problem was that nodes like `concepts::TypeRequirement` have constructors > (and probably other related functions) defined in SemaConcepts.cpp. These can > not be linked to the AST library, but are needed in `ASTImporter`

[libclc] 9fa81a4 - [libclc] Move step to the CLC library; add missing half variants (#140936)

2025-05-22 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-05-22T09:54:27+01:00 New Revision: 9fa81a486e317c7201318d710559093b3a5233bb URL: https://github.com/llvm/llvm-project/commit/9fa81a486e317c7201318d710559093b3a5233bb DIFF: https://github.com/llvm/llvm-project/commit/9fa81a486e317c7201318d710559093b3a5233bb.diff

[libclc] [libclc] Move step to the CLC library; add missing half variants (PR #140936)

2025-05-22 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/140936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--precompile` (PR #121046)

2025-05-22 Thread Sharadh Rajaraman via cfe-commits
sharadhr wrote: > xmake dev said he can fix the problem by /clang:-o We [tried this, but it didn't seem to work](https://gitlab.kitware.com/cmake/cmake/-/issues/25731#note_1603818). However, I think that issue has a subtle but important difference: @Arthapz has used [`/clang:-o -clang:`](htt

[clang] [analyzer] Introduce the check::BlockEntrance checker callback (PR #140924)

2025-05-22 Thread Balázs Benics via cfe-commits
https://github.com/balazs-benics-sonarsource updated https://github.com/llvm/llvm-project/pull/140924 From 084d821b62d5de473d32d3506da95fdd7bad1cfe Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Thu, 15 May 2025 17:20:29 +0200 Subject: [PATCH 1/3] [analyzer] Introduce the check::BlockEntran

[clang] [clang][bytecode] Change diagnostics for self-initialization (PR #141006)

2025-05-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/141006 >From 4f64271943f796cd6f4aa41a613d058766d61e6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 22 May 2025 06:52:09 +0200 Subject: [PATCH] [clang][bytecode] Change diagnostics for self-i

[clang] [analyzer] Introduce the check::BlockEntrance checker callback (PR #140924)

2025-05-22 Thread Balázs Benics via cfe-commits
balazs-benics-sonarsource wrote: > What is the relationship of this new callback with the `BranchCondition` > callback which is evaluated in `ProcessBranch` where the checker splits the > execution path into multiple branches? It would be nice if you could document > the difference between the

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--precompile` (PR #121046)

2025-05-22 Thread Arthur Laurent via cfe-commits
Arthapz wrote: > > xmake dev said he can fix the problem by /clang:-o > > We [tried this, but it didn't work when generating multiple output > files](https://gitlab.kitware.com/cmake/cmake/-/issues/25731#note_1603818). > In particular, a `scan-with-pch` test still fails. Perhaps @Arthapz needs

<    1   2   3   4   5   >