[clang] Add sycl_external attribute (PR #140282)

2025-05-19 Thread via cfe-commits
schittir wrote: > Thanks for working on this @schittir! I completed an initial pass of all of > the code, but still need to look more closely at the documentation updates. Thank you for the initial pass review, Tom! https://github.com/llvm/llvm-project/pull/140282

[clang] 7cf2860 - [C++] Fix a crash with __thread and dependent types (#140542)

2025-05-19 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-05-19T11:28:48-04:00 New Revision: 7cf2860cbdc158a04d4a982fa7043cd9e6401e77 URL: https://github.com/llvm/llvm-project/commit/7cf2860cbdc158a04d4a982fa7043cd9e6401e77 DIFF: https://github.com/llvm/llvm-project/commit/7cf2860cbdc158a04d4a982fa7043cd9e6401e77.diff

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/140542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-19 Thread Andrew Rogers via cfe-commits
andrurogerz wrote: Ok, this link error makes sense when building an external project in debug mode against an llvm release build. I didn't realize that was a thing, but it makes sense so my mistake. The issue is that we must only guard `dump` methods (that have definitions outside of the head

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. Do we have the correct current default https://github.com/llvm/llvm-project/pull/137840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/137840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add IndentPPDirectives Leave option (PR #139750)

2025-05-19 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. I approve if @owenca does. https://github.com/llvm/llvm-project/pull/139750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang][bytecode] Do not diagnose volatile reads in CPCE mode (PR #140546)

2025-05-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/140546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add sycl_external attribute (PR #140282)

2025-05-19 Thread via cfe-commits
@@ -12909,6 +12909,9 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { if (D->hasAttr()) return false; + if (LangOpts.SYCLIsDevice && !D->hasAttr()) +return false; schittir wrote: Yes, indeed. I left that one out of this draft because adding t

[clang] clang-format: Add -disable-format option (PR #137617)

2025-05-19 Thread via cfe-commits
https://github.com/mydeveloperday commented: I think this is a slippery slope... I can't support this, I think it goes against the ethos of clang-format. I want to add features that support our users not those that don't want to use clang-format. https://github.com/llvm/llvm-project/pull/13

[clang] d34e28e - addinitional -> additional typo fix

2025-05-19 Thread Benjamin Kramer via cfe-commits
Author: Lucie Tvrznikova Date: 2025-05-19T17:41:33+02:00 New Revision: d34e28eaf97840bd5573dfc3b11a82d795b31b87 URL: https://github.com/llvm/llvm-project/commit/d34e28eaf97840bd5573dfc3b11a82d795b31b87 DIFF: https://github.com/llvm/llvm-project/commit/d34e28eaf97840bd5573dfc3b11a82d795b31b87.di

[clang] clang-format: Add -disable-format option (PR #137617)

2025-05-19 Thread via cfe-commits
mydeveloperday wrote: > then we should upgrade `DisableFormat` to a `struct` with the supported > exceptions as members. that in my view would be a minimum requirement, but honestly I don't like this feature. https://github.com/llvm/llvm-project/pull/137617 ___

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread Daan De Meyer via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-19 Thread Harald van Dijk via cfe-commits
hvdijk wrote: Specifically here, `ScaledNumber` is a class template, that's what is causing it to be emitted in every translation unit that uses `ScaledNumber`, even user code that isn't otherwise using it, and it's being emitted according to the then-current definition of `NDEBUG`. > The iss

[clang] [C] Warn on uninitialized const objects (PR #137166)

2025-05-19 Thread Peter Maydell via cfe-commits
pm215 wrote: Hi -- it looks like this pullreq may be causing a new spurious warning for the case where the const object is a C flexible array member. In that case there's no memory to initialize, but clang now warns anyway. More details in this comment on the associated bug report: https://gi

[clang] [libclang/python] Simplify __eq__ operators (PR #140540)

2025-05-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Why does the diff show that you add `__ne__` operator, even though it's already present? What am I missing? https://github.com/llvm/llvm-project/blob/f3d36b15f6dde7ca2d080279274d5d0f4bfc8c30/clang/bindings/python/clang/cindex.py#L397-L403 https://github.com

[clang] [clang-format] Add --fallback-style to git-clang-format (PR #137609)

2025-05-19 Thread via cfe-commits
mydeveloperday wrote: For those repos that don't have a .clang-format why not just add one with whatever your fallback style is? BasedOnStyle: I know this seems like a reasonable feature but it just causes another set of functionality we have to think about, I don't see the values to people

[clang] [llvm] [mlir] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()` (PR #140289)

2025-05-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/140289 >From 2c36635ea034a0590ba45df05e4ec87eea171654 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 16 May 2025 10:54:33 -0700 Subject: [PATCH] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in Decl/StmtOpenACC (PR #140087)

2025-05-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/140087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C] Warn on uninitialized const objects (PR #137166)

2025-05-19 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hi -- it looks like this pullreq may be causing a new spurious warning for > the case where the const object is a C flexible array member. In that case > there's no memory to initialize, but clang now warns anyway. More details in > this comment on the associated bug repo

[clang] [CodeGen] Add TBAA struct path info for array members (PR #137719)

2025-05-19 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/137719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Add TBAA struct path info for array members (PR #137719)

2025-05-19 Thread John McCall via cfe-commits
@@ -4503,7 +4503,29 @@ LValue CodeGenFunction::EmitArraySubscriptExpr(const ArraySubscriptExpr *E, E->getType(), !getLangOpts().PointerOverflowDefined, SignedIndices, E->getExprLoc(), &arrayType, E->getBase()); EltBaseInfo = ArrayLV.getBaseInfo(); -EltT

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-19 Thread Donát Nagy via cfe-commits
NagyDonat wrote: In commit https://github.com/llvm/llvm-project/pull/139256/commits/13f4a3011e76c5665ca295ef597eb130f356df68 I implemented your suggestion that the debug name of the checker name should be derived from the name fragment of the registration functions (which is called `CLASS` bu

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/140086 From 65d44a4eb9621e49a96f1ac43e5a1bbd6691dc13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 15 May 2025 17:41:16 +0200 Subject: [PATCH 1/2] [clang-tidy] Added check 'bugprone-fu

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
@@ -124,6 +124,11 @@ New checks pointer and store it as class members without handle the copy and move constructors and the assignments. +- New :doc:`bugprone-function-visibility-change + ` check. + + Check function visibility changes in subclasses. bala

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
@@ -0,0 +1,43 @@ +.. title:: clang-tidy - bugprone-function-visibility-change + +bugprone-function-visibility-change +=== + +Check changes in visibility of C++ member functions in subclasses. The check balazske wrote: fixed https:

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
@@ -0,0 +1,74 @@ +//===--- FunctionVisibilityChangeCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -232,3 +238,52 @@ C fC() { } } + +namespace test_system_header { + +struct SysDerived: public sys::Base { +private: + void publicF(); + // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: visibility of function 'publicF' is cha

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -3,10 +3,13 @@ bugprone-function-visibility-change === -Check changes in visibility of C++ member functions in subclasses. The check -detects if a virtual function is overridden with a diffe

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
@@ -0,0 +1,74 @@ +//===--- FunctionVisibilityChangeCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
@@ -0,0 +1,74 @@ +//===--- FunctionVisibilityChangeCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
@@ -0,0 +1,74 @@ +//===--- FunctionVisibilityChangeCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
@@ -0,0 +1,74 @@ +//===--- FunctionVisibilityChangeCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CodeGen] Add TBAA struct path info for array members (PR #137719)

2025-05-19 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: Thanks, those seem like good reasons. https://github.com/llvm/llvm-project/pull/137719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-19 Thread Balázs Kéri via cfe-commits
balazske wrote: The current code is not finished. I want to check for false positives and probably add options to disable check at destructors and operators. https://github.com/llvm/llvm-project/pull/140086 ___ cfe-commits mailing list cfe-commits@lis

[clang] [llvm] [NVPTX] Add errors for incorrect CUDA addrpaces (PR #138706)

2025-05-19 Thread Lewis Crawford via cfe-commits
https://github.com/LewisCrawford updated https://github.com/llvm/llvm-project/pull/138706 >From 8bbb3f88048e8041e79d609c982b11ba75199e0e Mon Sep 17 00:00:00 2001 From: Lewis Crawford Date: Tue, 6 May 2025 15:16:39 + Subject: [PATCH 1/4] [NVPTX] Add errors for incorrect CUDA addrpaces The C

[clang] [CIR] Remove the empty verifier in cir.ifOp (PR #140457)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/140457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add errors for incorrect CUDA addrpaces (PR #138706)

2025-05-19 Thread Lewis Crawford via cfe-commits
@@ -1399,19 +1399,27 @@ void NVPTXAsmPrinter::emitFunctionParamList(const Function *F, raw_ostream &O) { if (PTy) { O << "\t.param .u" << PTySizeInBits << " .ptr"; +bool IsCUDA = static_cast(TM).getDrvInterface() == + NVPTX::CUDA;

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-05-19 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/135383 >From 4a7cdb4a9f4de5503eba1488306e238b7334912a Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 11 Apr 2025 20:26:49 +0300 Subject: [PATCH 1/3] [clang-tidy] add support for lambdas in use-trailing-retu

[clang] [libcxx] [Clang] Add __builtin_common_reference (PR #121199)

2025-05-19 Thread Nikolas Klauser via cfe-commits
@@ -3231,6 +3241,230 @@ static QualType builtinCommonTypeImpl(Sema &S, TemplateName BaseTemplate, } } +static QualType CopyCV(QualType From, QualType To) { + if (From.isConstQualified()) +To.addConst(); + if (From.isVolatileQualified()) +To.addVolatile(); + retur

[clang-tools-extra] Add check 'cppcoreguidelines-use-enum-class' (PR #138282)

2025-05-19 Thread Philipp Jung via cfe-commits
@@ -130,6 +130,11 @@ New checks Finds unintended character output from ``unsigned char`` and ``signed char`` to an ``ostream``. +- New :doc:`cppcoreguidelines-use-enum-class + ` check. + + Finds plain non-class ``enum`` definitions that could use ``enum class``.

[clang] [clang][bytecode] Diagnose failed constexpr assertions differently (PR #140000)

2025-05-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/14 >From e1d5efd0d039ca50bd18cc74cb8e4ccf2b5fbe78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 15 May 2025 06:13:12 +0200 Subject: [PATCH] [clang][bytecode] Diagnose failed constexpr ass

[clang] [libclang/python][NFC] Explain how null cursors are handled in docstring (PR #140499)

2025-05-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/140499 >From 445eacab8a326d3abcca95a31f07c272d0d155e7 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 19 May 2025 09:24:36 +0300 Subject: [PATCH 1/2] [libclang/python][NFC] Explain how null cursors are ha

[clang] bca39f4 - [clang][bytecode] Add a scope to function calls (#140441)

2025-05-19 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-19T11:49:27+02:00 New Revision: bca39f4e8f79c84b66a51a87d7ae8ecc4b0fe436 URL: https://github.com/llvm/llvm-project/commit/bca39f4e8f79c84b66a51a87d7ae8ecc4b0fe436 DIFF: https://github.com/llvm/llvm-project/commit/bca39f4e8f79c84b66a51a87d7ae8ecc4b0fe436.diff L

[libclc] [libclc] Mov erf & erfc to CLC library (PR #140524)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cl -- libclc/clc/include/clc/math/clc_erf.h libclc/clc/inc

[clang] [Clang] Fix a regression introduced by #140073 (PR #140288)

2025-05-19 Thread Alexander Kornienko via cfe-commits
alexfh wrote: This helps with the crashes we've seen so far. Thanks! https://github.com/llvm/llvm-project/pull/140288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Mov erf & erfc to CLC library (PR #140524)

2025-05-19 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/140524 >From 38c1e5e62efa56c8dbca4e087555695ad34fe469 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Mon, 19 May 2025 11:10:08 +0100 Subject: [PATCH 1/2] [libclc] Mov erf & erfc to CLC library This completes

[clang] 59f8af3 - [NFC][Clang] Adopt simplified `getTrailingObjects` in DeclFriend (#140081)

2025-05-19 Thread via cfe-commits
Author: Rahul Joshi Date: 2025-05-19T08:02:23-07:00 New Revision: 59f8af35b6bb15c0794873786cb34c7867be357b URL: https://github.com/llvm/llvm-project/commit/59f8af35b6bb15c0794873786cb34c7867be357b DIFF: https://github.com/llvm/llvm-project/commit/59f8af35b6bb15c0794873786cb34c7867be357b.diff L

[clang] [clang][Sema] Diagnose exceptions only in non-dependent context in discarded `try/catch/throw` blocks (PR #139859)

2025-05-19 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: I feel like this issue is a little too niche to be adding such complexity, maybe just covering those specific uses cases before codegen might be the way to go? https://github.com/llvm/llvm-project/pull/139859 ___ cfe-commits mailing

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-05-19 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/135383 >From 4a7cdb4a9f4de5503eba1488306e238b7334912a Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 11 Apr 2025 20:26:49 +0300 Subject: [PATCH 1/4] [clang-tidy] add support for lambdas in use-trailing-retu

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/140571 Delayed typo correction does not emit a diagnostic until the end of the TU. However, codegen is run on each top-level declaration unless an unrecoverable error occurred. The check for the diagnostic ensures

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Delayed typo correction does not emit a diagnostic until the end of the TU. However, codegen is run on each top-level declaration unless an unrecoverable error occurred. The check for the diagnostic ensu

[clang] b24c33a - [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (#139809)

2025-05-19 Thread via cfe-commits
Author: Thurston Dang Date: 2025-05-19T09:39:26-07:00 New Revision: b24c33a9d745bd2a3009f1d52f31247772e954e5 URL: https://github.com/llvm/llvm-project/commit/b24c33a9d745bd2a3009f1d52f31247772e954e5 DIFF: https://github.com/llvm/llvm-project/commit/b24c33a9d745bd2a3009f1d52f31247772e954e5.diff

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-19 Thread Thurston Dang via cfe-commits
https://github.com/thurstond closed https://github.com/llvm/llvm-project/pull/139809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-05-19 Thread Baranov Victor via cfe-commits
@@ -56,6 +60,13 @@ class UseTrailingReturnTypeCheck : public ClangTidyCheck { SourceRange ReturnTypeCVRange, const FunctionDecl &F, const FriendDecl *Fr, const ASTContext &Ctx, const SourceManager &SM, const Lang

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -1148,6 +1146,35 @@ mlir::Value CIRGenFunction::emitAlloca(StringRef name, mlir::Type ty, return addr; } +// Note: this function also emit constructor calls to support a MSVC extensions +// allowing explicit constructor function call. +RValue CIRGenFunction::emitCXXMembe

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-19 Thread Andrew Rogers via cfe-commits
andrurogerz wrote: @hvdijk thank you for the clear repro steps; I was able to reproduce the issue locally and verify that #140574 fixes it. It is a partial revert of only the `ScaledNumber` source changes; the rest of the changes in this PR do not appear to have the same issue. https://githu

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-05-19 Thread Baranov Victor via cfe-commits
@@ -56,6 +60,13 @@ class UseTrailingReturnTypeCheck : public ClangTidyCheck { SourceRange ReturnTypeCVRange, const FunctionDecl &F, const FriendDecl *Fr, const ASTContext &Ctx, const SourceManager &SM, const Lang

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-05-19 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/135383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-19 Thread Amr Hesham via cfe-commits
@@ -2037,4 +2037,37 @@ def VecExtractOp : CIR_Op<"vec.extract", [Pure, let hasFolder = 1; } + +//===--===// +// VecSplat +//===--===// + +/

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/140571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -109,6 +109,14 @@ struct CallArg { class CallArgList : public llvm::SmallVector { public: void add(RValue rvalue, clang::QualType type) { emplace_back(rvalue, type); } + + /// Add all the arguments from another CallArgList to this one. After doing + /// this, the old Cal

[clang] e3950a0 - [OpenACC] Fix 'vector' checking when inside combined construct

2025-05-19 Thread via cfe-commits
Author: erichkeane Date: 2025-05-19T09:57:22-07:00 New Revision: e3950a049a8f098b8d28a9c89fe3f21f5c0b1682 URL: https://github.com/llvm/llvm-project/commit/e3950a049a8f098b8d28a9c89fe3f21f5c0b1682 DIFF: https://github.com/llvm/llvm-project/commit/e3950a049a8f098b8d28a9c89fe3f21f5c0b1682.diff LO

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -76,11 +77,30 @@ static void appendParameterTypes(const CIRGenTypes &cgt, cgt.getCGModule().errorNYI("appendParameterTypes: hasExtParameterInfos"); } +/// Derives the 'this' type for CIRGen purposes, i.e. ignoring method CVR +/// qualification. Either or both of `rd` and

[libclc] [libclc] Reorganize OpenCL builtins (PR #140557)

2025-05-19 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/140557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/140304 >From a4e63bb357688f7200113d4dc39c83d95d72ce6e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 12 May 2025 08:59:40 -0700 Subject: [PATCH 1/4] [OpenACC][CIR] Implement beginning of 'copy' lowering for c

[clang] [Clang] Functions called in discarded statements should not be instantiated (PR #140576)

2025-05-19 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/140576 Functions referenced in discarded statements could be treated as odr-used because we did not properly set the correct evaluation context in some places. Fixes https://github.com/llvm/llvm-project/issues/140449

[libclc] [libclc] Reorganize OpenCL builtins (PR #140557)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: undef deprecator found issues in your code. :warning: You can test this locally with the following command: ``bash git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD libclc/opencl/include/clc/

[clang] [Clang] Functions called in discarded statements should not be instantiated (PR #140576)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Functions referenced in discarded statements could be treated as odr-used because we did not properly set the correct evaluation context in some places. Fixes https://github.com/llvm/llvm-project/issues/140449

[clang] [Clang] Functions called in discarded statements should not be instantiated (PR #140576)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: cor3ntin (cor3ntin) Changes Functions referenced in discarded statements could be treated as odr-used because we did not properly set the correct evaluation context in some places. Fixes https://github.com/llvm/llvm-project/issues/140

[clang] [Clang] Functions called in discarded statements should not be instantiated (PR #140576)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/140576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Coverage] Fix mapping for do-while loops with terminating statements (PR #139777)

2025-05-19 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu approved this pull request. LGTM. Thanks for fixing it. https://github.com/llvm/llvm-project/pull/139777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C] Do not diagnose flexible array members with -Wdefault-const-init-field-unsafe (PR #140578)

2025-05-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/140578 This addresses post-commit review feedback from someone who discovered that we diagnosed code like the following: ``` struct S { int len; const char fam[]; } s; ``` despite it being invalid to i

[clang] [C] Do not diagnose flexible array members with -Wdefault-const-init-field-unsafe (PR #140578)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes This addresses post-commit review feedback from someone who discovered that we diagnosed code like the following: ``` struct S { int len; const char fam[]; } s; ``` despite it being invalid

[clang] [C] Do not diagnose flexible array members with -Wdefault-const-init-field-unsafe (PR #140578)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/140578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ItaniumMangle] Make sure class types are added to the dictionary of substitution candidates when compiling for older ABIs (PR #138947)

2025-05-19 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: Any other feedback? https://github.com/llvm/llvm-project/pull/138947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()` (PR #140289)

2025-05-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/140289 >From 6425e29aefbcacc2c43b37ed5114906edead Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 16 May 2025 10:54:33 -0700 Subject: [PATCH] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()

[clang] [llvm] [mlir] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()` (PR #140289)

2025-05-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/140289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread Daan De Meyer via cfe-commits
https://github.com/DaanDeMeyer updated https://github.com/llvm/llvm-project/pull/137840 >From bb5eb380a0f71cac0c734443b4fbfa4441f441b2 Mon Sep 17 00:00:00 2001 From: Daan De Meyer Date: Tue, 29 Apr 2025 18:26:36 +0200 Subject: [PATCH] clang-format: Add IgnoreExtension option to SortIncludesOpt

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread Daan De Meyer via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang] f3f63ce - [CIR][LLVMLowering] Upstream binary operators for VectorType (#140099)

2025-05-19 Thread via cfe-commits
Author: Amr Hesham Date: 2025-05-19T19:33:34+02:00 New Revision: f3f63ce50ac776bed53aa0c1163db6d5ed25196d URL: https://github.com/llvm/llvm-project/commit/f3f63ce50ac776bed53aa0c1163db6d5ed25196d DIFF: https://github.com/llvm/llvm-project/commit/f3f63ce50ac776bed53aa0c1163db6d5ed25196d.diff LO

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-19 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/140099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread Daan De Meyer via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang] clang-format: Add -disable-format option (PR #137617)

2025-05-19 Thread Daan De Meyer via cfe-commits
DaanDeMeyer wrote: Right I get a feeling I'll have an easier time getting systemd to fully adapt clang-format than getting this into clang-format so closing https://github.com/llvm/llvm-project/pull/137617 ___ cfe-commits mailing list cfe-commits@list

[clang] clang-format: Add -disable-format option (PR #137617)

2025-05-19 Thread Daan De Meyer via cfe-commits
https://github.com/DaanDeMeyer closed https://github.com/llvm/llvm-project/pull/137617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Bruno Cardoso Lopes via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. > @bcardosolopes : If it is alright, I'd like to just do the OpenACC clause > refactor in a followup patch. I'll work on it 'next', immediately after this > one. I'd originally done the visitor, then realized it needed to be accessed

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/140304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 7a24238 - Reland "[clang][modules] Timestamp-less validation API (#139987)"

2025-05-19 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2025-05-19T10:40:55-07:00 New Revision: 7a242387c950c7060143da6da0e6fb91f36bb458 URL: https://github.com/llvm/llvm-project/commit/7a242387c950c7060143da6da0e6fb91f36bb458 DIFF: https://github.com/llvm/llvm-project/commit/7a242387c950c7060143da6da0e6fb91f36bb458.diff L

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/140290 >From e1e91e88d2857b3a245c09f5c2afbfe37bc66063 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Fri, 2 May 2025 16:58:13 -0700 Subject: [PATCH 1/2] [CIR] Upstream support for C++ member function calls This c

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-19 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,Balazs Benics ,Balazs Benics , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/steakhal edited https

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-19 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,Balazs Benics ,Balazs Benics , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/steakhal commented: T

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-19 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,Balazs Benics ,Balazs Benics , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -115,9 +115,22 @@ cla

[clang] [WIP][analyzer] Refactor `ExplodedGraph::trim()` (PR #139939)

2025-05-19 Thread Balazs Benics via cfe-commits
=?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy ,

[clang] Fix crash with delayed typo correction (PR #140571)

2025-05-19 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Linux precommit CI failure looks to be unrelated. Given that this is an interaction between Sema and CodeGen, I'd like at least one approval from John or Eli before I land. https://github.com/llvm/llvm-project/pull/140571 ___ cfe-

[clang] [Clang] Functions called in discarded statements should not be instantiated (PR #140576)

2025-05-19 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Does it fix https://github.com/llvm/llvm-project/issues/115289? https://github.com/llvm/llvm-project/pull/140576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] db4c94f - [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (#140304)

2025-05-19 Thread via cfe-commits
Author: Erich Keane Date: 2025-05-19T10:40:10-07:00 New Revision: db4c94f96410fd4432f8de9e9b1dec44ca07b6d8 URL: https://github.com/llvm/llvm-project/commit/db4c94f96410fd4432f8de9e9b1dec44ca07b6d8 DIFF: https://github.com/llvm/llvm-project/commit/db4c94f96410fd4432f8de9e9b1dec44ca07b6d8.diff L

<    1   2   3   4   5   6   >