[clang] [libc] [SPIRV][libc] Introduce SPIR-V target for 'libc' (PR #137310)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/lib/Headers/spirvintrin.h libc/benchmarks/gpu

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-05-19 Thread Vyacheslav Levytskyy via cfe-commits
https://github.com/VyacheslavLevytskyy approved this pull request. Thank you @sarnex , among other this would unblock the SPIR-V target for the GPU C library experiments https://github.com/llvm/llvm-project/pull/137310 https://github.com/llvm/llvm-project/pull/137882 ___

[libclc] [libclc] Append file_specific_compile_options after ARG_COMPILE_FLAGS (PR #139871)

2025-05-19 Thread Wenju He via cfe-commits
wenju-he wrote: > Sure, no problem. You can probably request [commit > access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) > by now, though. thanks @frasercrmck I've requested at https://github.com/llvm/llvm-project/issues/140521, please help to review, thank you. ht

[clang] [clang][Sema] Diagnose exceptions only in non-dependent context in discarded `try/catch/throw` blocks (PR #139859)

2025-05-19 Thread Erich Keane via cfe-commits
erichkeane wrote: >What are the use cases for disabling exceptions but still allowing the >constructs in source? e.g., do we want to start disabling the keywords >entirely, and thus they won't appear in the AST? Or do we want them to be a >codegen-only option, at which point they do appear in

[clang] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang] [llvm] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-19 Thread Dmitry Sidorov via cfe-commits
https://github.com/MrSidims updated https://github.com/llvm/llvm-project/pull/140253 >From 67935acd84b032209d45bad22db8e1a9e72c1dcd Mon Sep 17 00:00:00 2001 From: "Sidorov, Dmitry" Date: Fri, 16 May 2025 06:55:10 -0700 Subject: [PATCH 1/2] [Clang] Allow vector and matrix type attributes for su

[clang] 2a277f9 - [clang] Use llvm::is_sorted (NFC) (#140468)

2025-05-19 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-19T06:18:53-07:00 New Revision: 2a277f9ff1c793e25167537b0202f333f8f91f60 URL: https://github.com/llvm/llvm-project/commit/2a277f9ff1c793e25167537b0202f333f8f91f60 DIFF: https://github.com/llvm/llvm-project/commit/2a277f9ff1c793e25167537b0202f333f8f91f60.diff L

[clang] [clang] Use llvm::is_sorted (NFC) (PR #140468)

2025-05-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use *Map::try_emplace (NFC) (PR #140477)

2025-05-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (PR #140532)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clang-tidy] Do not flag strerror in concurrency-mt-unsafe (PR #140520)

2025-05-19 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/140520 The docs of the check state: > Glibc’s list is compiled from GNU web documentation with a search for MT-Safe > tag And strerror fulfills exactly that: https://www.gnu.org/software/libc/manual/html_node/

[clang] [llvm] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/140253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add type annotations for code completion classes (PR #140539)

2025-05-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum created https://github.com/llvm/llvm-project/pull/140539 This fully annotates the code completion classes (CompletionChunk, CompletionString, CodeCompletionResult, CodeCompletionResults and CCRStructure) resolving 59 strict typing errors as the next step towards

[clang] [libclang/python] Add type annotations for code completion classes (PR #140539)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) Changes This fully annotates the code completion classes (CompletionChunk, CompletionString, CodeCompletionResult, CodeCompletionResults and CCRStructure) resolving 59 strict typing errors as the next step to

[clang] [llvm] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-19 Thread Dmitry Sidorov via cfe-commits
@@ -571,6 +571,41 @@ void VectorTest(uint16_t4 first, uint16_t4 second) { // CHECK: %[[ADD:.+]] = add <3 x i16> %[[Shuffle]], %[[Shuffle1]] } +typedef unsigned _BitInt(4) uint4_t4 __attribute__((ext_vector_type(4))); +void VectorTest(uint4_t4 first, uint4_t4 second) { + //

[clang] [llvm] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-19 Thread Dmitry Sidorov via cfe-commits
@@ -571,6 +571,41 @@ void VectorTest(uint16_t4 first, uint16_t4 second) { // CHECK: %[[ADD:.+]] = add <3 x i16> %[[Shuffle]], %[[Shuffle1]] } +typedef unsigned _BitInt(4) uint4_t4 __attribute__((ext_vector_type(4))); +void VectorTest(uint4_t4 first, uint4_t4 second) { + //

[clang] [llvm] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-19 Thread Dmitry Sidorov via cfe-commits
https://github.com/MrSidims edited https://github.com/llvm/llvm-project/pull/140253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Diagnose exceptions only in non-dependent context in discarded `try/catch/throw` blocks (PR #139859)

2025-05-19 Thread via cfe-commits
cor3ntin wrote: In C++26, exceptions are allowed in a constant evaluated context, which is used extensively by reflection and maybe P2300. I also think allowing `try` not to be a keyword in some modes would harm the ecosystem. Here is an interesting scenario ```cpp constexpr void g() { th

[clang] [libclang/python] Add type annotations for code completion classes (PR #140539)

2025-05-19 Thread Jannick Kremer via cfe-commits
@@ -3051,6 +3053,7 @@ def isKindResultType(self): class CompletionString(ClangObject): class Availability: DeinAlptraum wrote: I did not annotate this class because it isn't used. I assume the `availability` property accessing `availabilityKinds` was sup

[clang] [llvm] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-19 Thread Dmitry Sidorov via cfe-commits
MrSidims wrote: > "tests would be a PITA to write, so lets restrict it and let someone who > cares loosen it" Yeah, that is understandable, I pushed the PR without extended tests just to check, if there won't be immediate objections before committing time to write them. Soo... I have extende

[clang] [libclang/python] Add type annotations for code completion classes (PR #140539)

2025-05-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/140539 >From 2d899491a409ede826674d7283df7f594987c355 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Mon, 19 May 2025 22:20:00 +0900 Subject: [PATCH 1/2] [libclang/python] Add type annotations for code compl

[clang] [compiler-rt] [Coverage] Fix mapping for do-while loops with terminating statements (PR #139777)

2025-05-19 Thread Justin Cady via cfe-commits
justincady wrote: Ping. :) https://github.com/llvm/llvm-project/pull/139777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Diagnose exceptions only in non-dependent context in discarded `try/catch/throw` blocks (PR #139859)

2025-05-19 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > In C++26, exceptions are allowed in a constant evaluated context, which is > used extensively by reflection and maybe P2300. Good point. :-/ > I also think allowing `try` not to be a keyword in some modes would harm the > ecosystem. [citation needed] You already cannot

[clang] [libclang/python] Add type annotations for code completion classes (PR #140539)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD clang/bindings/python/clang/cindex.py `` View the diff from dark

[clang] 3252816 - [clang] Use *Map::try_emplace (NFC) (#140477)

2025-05-19 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-19T06:19:53-07:00 New Revision: 325281631a3b5c089dd732d9ca10704431447859 URL: https://github.com/llvm/llvm-project/commit/325281631a3b5c089dd732d9ca10704431447859 DIFF: https://github.com/llvm/llvm-project/commit/325281631a3b5c089dd732d9ca10704431447859.diff L

[clang] [libclang/python] Simplify __eq__ operators (PR #140540)

2025-05-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum created https://github.com/llvm/llvm-project/pull/140540 This allows us to remove a few type: ignores. >From 51df5f4eb979edb7cc761276fe846626641bd6b4 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Mon, 19 May 2025 22:36:05 +0900 Subject: [PATCH] [libclang/p

[clang] [libclang/python] Simplify __eq__ operators (PR #140540)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) Changes This allows us to remove a few type: ignores. --- Full diff: https://github.com/llvm/llvm-project/pull/140540.diff 1 Files Affected: - (modified) clang/bindings/python/clang/cindex.py (+3-9)

[clang] [libclang/python] Simplify __eq__ operators (PR #140540)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD clang/bindings/python/clang/cindex.py `` View the diff from dark

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/140304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use *Map::try_emplace (NFC) (PR #140477)

2025-05-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-b-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/15430 Here is the relevant

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp,h -- clang/test/CIR/CodeGenOpenACC/compute-copy.c cla

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/140304 >From a4e63bb357688f7200113d4dc39c83d95d72ce6e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 12 May 2025 08:59:40 -0700 Subject: [PATCH 1/3] [OpenACC][CIR] Implement beginning of 'copy' lowering for c

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/140304 >From a4e63bb357688f7200113d4dc39c83d95d72ce6e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 12 May 2025 08:59:40 -0700 Subject: [PATCH 1/2] [OpenACC][CIR] Implement beginning of 'copy' lowering for c

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/140542 We were checking whether the initializer is a valid constant expression even if the variable was dependent. Now we delay that checking until after the template has been instantiated. Fixes #140509 >From

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We were checking whether the initializer is a valid constant expression even if the variable was dependent. Now we delay that checking until after the template has been instantiated. Fixes #140509 --

[clang] [libclang/python] Simplify __eq__ operators (PR #140540)

2025-05-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/140540 >From 51df5f4eb979edb7cc761276fe846626641bd6b4 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Mon, 19 May 2025 22:36:05 +0900 Subject: [PATCH 1/2] [libclang/python] Simplfy __eq__ operators This allows

[clang] [libclang/python] Simplify __eq__ operators (PR #140540)

2025-05-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/140540 >From 51df5f4eb979edb7cc761276fe846626641bd6b4 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Mon, 19 May 2025 22:36:05 +0900 Subject: [PATCH 1/3] [libclang/python] Simplfy __eq__ operators This allows

[clang] [libclang/python] Simplify __eq__ operators (PR #140540)

2025-05-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/140540 >From 51df5f4eb979edb7cc761276fe846626641bd6b4 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Mon, 19 May 2025 22:36:05 +0900 Subject: [PATCH 1/4] [libclang/python] Simplfy __eq__ operators This allows

[clang] [Clang] Allow parsing arbitrary order of attributes for declarations (PR #133107)

2025-05-19 Thread kadir çetinkaya via cfe-commits
kadircet wrote: > I think we need to understand what we want before we can make decisions on > what needs changing, though. Are there invariants we want to introduce, like > the source range for the AST node should encompass the source locations > tracked within the AST node? Or are we fine wi

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Aaron Ballman via cfe-commits
@@ -14622,7 +14622,8 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { Diag(var->getLocation(), diag::err_thread_nontrivial_dtor); if (getLangOpts().CPlusPlus11) Diag(var->getLocation(), diag::note_use_thread_local); -} else if (getLangOpts

[clang] [clang-tools-extra] [clang-include-cleaner] Make cleanup attr report expr location (PR #140233)

2025-05-19 Thread kadir çetinkaya via cfe-commits
kadircet wrote: changes in include-cleaner LG, but I am not sure about the canonical way of tracking this location in clang (i.e. if we're going to track an expression within the attribute, do we still need to tract the underlying decl as well? can't we just extract it from expr when needed?)

[clang] [clang-format] Add IndentPPDirectives Leave option (PR #139750)

2025-05-19 Thread Björn Schäpers via cfe-commits
@@ -1142,7 +1144,8 @@ void UnwrappedLineParser::parsePPEndIf() { // If the #endif of a potential include guard is the last thing in the file, // then we found an include guard. if (IncludeGuard == IG_Defined && PPBranchLevel == -1 && Tokens->isEOF() && - Style.Indent

[clang] [flang] [flang][veclib] Adding AMDLIBM target to fveclib (PR #140533)

2025-05-19 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/140533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-19 Thread Harald van Dijk via cfe-commits
hvdijk wrote: This approach causes issues when LLVM is built in release mode (with `-DNDEBUG`) and external projects build against it in debug mode (with `-UNDEBUG`). I appreciate that it does what the comment says should be done, but I think what the comment says is wrong. Specifically, I now

[clang] 4bdd116 - [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (#137425)

2025-05-19 Thread via cfe-commits
Author: Krzysztof Drewniak Date: 2025-05-19T07:15:04-07:00 New Revision: 4bdd116b80670cf74ced3e36def6ca09169ff7ac URL: https://github.com/llvm/llvm-project/commit/4bdd116b80670cf74ced3e36def6ca09169ff7ac DIFF: https://github.com/llvm/llvm-project/commit/4bdd116b80670cf74ced3e36def6ca09169ff7ac.

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-19 Thread Krzysztof Drewniak via cfe-commits
https://github.com/krzysz00 closed https://github.com/llvm/llvm-project/pull/137425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Flang][Driver] Fix target parsing for -fveclib=AMDLIBM option (PR #140544)

2025-05-19 Thread Rohit Aggarwal via cfe-commits
https://github.com/rohitaggarwal007 updated https://github.com/llvm/llvm-project/pull/140544 >From 4769d05876f3d7f4a335c10e51fb20e3c923e270 Mon Sep 17 00:00:00 2001 From: Rohit Aggarwal Date: Mon, 19 May 2025 19:25:52 +0530 Subject: [PATCH] [Clang][Flang][Driver] Fix target parsing for -fvecli

[clang] [Clang][Flang][Driver] Fix target parsing for -fveclib=AMDLIBM option (PR #140544)

2025-05-19 Thread Rohit Aggarwal via cfe-commits
https://github.com/rohitaggarwal007 created https://github.com/llvm/llvm-project/pull/140544 Handle some cases for target parsing for -fveclib=AMDLIBM option >From 4769d05876f3d7f4a335c10e51fb20e3c923e270 Mon Sep 17 00:00:00 2001 From: Rohit Aggarwal Date: Mon, 19 May 2025 19:25:52 +0530 Subje

[clang] [Clang][Flang][Driver] Fix target parsing for -fveclib=AMDLIBM option (PR #140544)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Rohit Aggarwal (rohitaggarwal007) Changes Handle some cases for target parsing for -fveclib=AMDLIBM option --- Full diff: https://github.com/llvm/llvm-project/pull/140544.diff 3 Files Affected: - (modified) clang/lib/Driver/ToolC

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/140542 >From a7aa9409530b5a11811149a612886f3d2f4bc977 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 19 May 2025 09:31:51 -0400 Subject: [PATCH 1/2] [C++] Fix a crash with __thread and dependent types We

[clang] [clang][bytecode] Do not diagnose volatile reads in CPCE mode (PR #140546)

2025-05-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/140546 This matches the diagnostic output of the current interpreter. >From b13e6121e940c96f42febb327f2ee0191e19faaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 19 May 2025 16:14:49 +0200

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Aaron Ballman via cfe-commits
@@ -14622,7 +14622,8 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { Diag(var->getLocation(), diag::err_thread_nontrivial_dtor); if (getLangOpts().CPlusPlus11) Diag(var->getLocation(), diag::note_use_thread_local); -} else if (getLangOpts

[clang] [clang][bytecode] Do not diagnose volatile reads in CPCE mode (PR #140546)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This matches the diagnostic output of the current interpreter. --- Full diff: https://github.com/llvm/llvm-project/pull/140546.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Interp.h (+8-7) -

[clang] [llvm] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-19 Thread Dmitry Sidorov via cfe-commits
https://github.com/MrSidims updated https://github.com/llvm/llvm-project/pull/140253 >From 67935acd84b032209d45bad22db8e1a9e72c1dcd Mon Sep 17 00:00:00 2001 From: "Sidorov, Dmitry" Date: Fri, 16 May 2025 06:55:10 -0700 Subject: [PATCH 1/2] [Clang] Allow vector and matrix type attributes for su

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Erich Keane via cfe-commits
@@ -14608,6 +14608,10 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { std::optional CacheHasConstInit; const Expr *CacheCulprit = nullptr; auto checkConstInit = [&]() mutable { +const Expr *Init = var->getInit(); +if (Init->isInstantiationDependent

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/140542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Aaron Ballman via cfe-commits
@@ -14608,6 +14608,10 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { std::optional CacheHasConstInit; const Expr *CacheCulprit = nullptr; auto checkConstInit = [&]() mutable { +const Expr *Init = var->getInit(); +if (Init->isInstantiationDependent

[clang-tools-extra] [clang-tidy] Do not flag strerror in concurrency-mt-unsafe (PR #140520)

2025-05-19 Thread via cfe-commits
@@ -172,6 +172,10 @@ Changes in existing checks ` check by fixing false positives when a function name is just prefixed with a targeted function name. +- Improved :doc:`concurrency-mt-unsafe + ` check by fixing a false positive + where `strerror` was flagged as MT-unsafe

[clang] [flang] [flang][veclib] Adding AMDLIBM target to fveclib (PR #140533)

2025-05-19 Thread via cfe-commits
NimishMishra wrote: Have approved the workflow runs https://github.com/llvm/llvm-project/pull/140533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode][NFC] Simplify VisitCompoundLiteralExpr (PR #140547)

2025-05-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/140547 None >From ba9bf827b8b599a127247222ef9177bd92df42c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 19 May 2025 16:24:29 +0200 Subject: [PATCH] [clang][bytecode][NFC] Simplify VisitComp

[clang] [clang][bytecode][NFC] Simplify VisitCompoundLiteralExpr (PR #140547)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140547.diff 1 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+3-10) ``diff diff --git a/clang/lib/AST/ByteCode/Compil

[clang] [Clang][CodeGen] Do not emit lifetime intrinsics for coro promise alloca (PR #140548)

2025-05-19 Thread Weibo He via cfe-commits
https://github.com/NewSigma created https://github.com/llvm/llvm-project/pull/140548 Coro promise has same lifetime as coro frame. It do not need explicit lifetime guarding. If we add lifetimes to it, middle end passes may assume promise dead after lifetime.end, leading to mis-optimizations.

[clang] [Clang][CodeGen] Do not emit lifetime intrinsics for coro promise alloca (PR #140548)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Weibo He (NewSigma) Changes Coro promise has same lifetime as coro frame. It do not need explicit lifetime guarding. If we add lifetimes to it, middle end passes may assume promise dead after lifetime.end, leading to mis-optimizations. F

[clang] [Clang][CodeGen] Do not emit lifetime intrinsics for coro promise alloca (PR #140548)

2025-05-19 Thread Weibo He via cfe-commits
NewSigma wrote: Here is a example ``` LLVM define i32 @fn() { entry: %__promise = alloca i32, align 4 %id = call token @llvm.coro.id(i32 16, ptr nonnull %__promise, ptr nonnull @fn, ptr null) %hdl = call ptr @llvm.coro.begin(token %id, ptr null) #14 %promise.addr = call ptr @llvm.coro.p

[clang] [clang][bytecode][NFC] Simplify VisitCompoundLiteralExpr (PR #140547)

2025-05-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/140547 >From 9592150674b5d6b6141d126bf2c291464026 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 19 May 2025 16:24:29 +0200 Subject: [PATCH] [clang][bytecode][NFC] Simplify VisitCompoundLi

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-19 Thread Matt Arsenault via cfe-commits
arsenm wrote: I think we'd be better off omitting the offset from the intrinsic signature https://github.com/llvm/llvm-project/pull/137425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Erich Keane via cfe-commits
@@ -14608,6 +14608,10 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { std::optional CacheHasConstInit; const Expr *CacheCulprit = nullptr; auto checkConstInit = [&]() mutable { +const Expr *Init = var->getInit(); +if (Init->isInstantiationDependent

[clang] [C++] Fix a crash with __thread and dependent types (PR #140542)

2025-05-19 Thread Erich Keane via cfe-commits
@@ -14622,7 +14622,8 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { Diag(var->getLocation(), diag::err_thread_nontrivial_dtor); if (getLangOpts().CPlusPlus11) Diag(var->getLocation(), diag::note_use_thread_local); -} else if (getLangOpts

[clang] [Serialization] Fix lazy template loading (PR #133057)

2025-05-19 Thread Maksim Ivanov via cfe-commits
emaxx-google wrote: > Two observations: > > 1. There is a diamond module structure: Both `4BK.pcm` and `LUM.pcm` depend > on `WI9.pcm` and contain `2OT.h` with different module names (I removed > transitive empty includes). I'm not sure if this is valid... @emaxx-google is > it possible to sh

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Alright, I've done all as requested. Would love a 2nd review/approval from Bruno. @bcardosolopes : If it is alright, I'd like to just do the OpenACC clause refactor in a followup patch. I'll work on it 'next', immediately after this one. I'd origina

[clang-tools-extra] [clang-tidy] Do not flag strerror in concurrency-mt-unsafe (PR #140520)

2025-05-19 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/140520 >From 35769db674fc2ebe7c0dda9ed329806b8b059414 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Mon, 19 May 2025 09:35:30 + Subject: [PATCH 1/2] [clang-tidy] Do not flag strerror i

[clang] [clang-tools-extra] [clang-include-cleaner] Make cleanup attr report expr location (PR #140233)

2025-05-19 Thread Daan De Meyer via cfe-commits
https://github.com/DaanDeMeyer updated https://github.com/llvm/llvm-project/pull/140233 >From 736ab4d98adcdc4ec21639f59f5b1307ce678303 Mon Sep 17 00:00:00 2001 From: Daan De Meyer Date: Fri, 16 May 2025 12:08:47 +0200 Subject: [PATCH] [clang-include-cleaner] Make cleanup attr report expr locat

[clang-tools-extra] [clang-tidy] do not diagnose array types within implicit instantiations of a template (PR #132924)

2025-05-19 Thread St. Muench via cfe-commits
https://github.com/stmuench edited https://github.com/llvm/llvm-project/pull/132924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-19 Thread Harald van Dijk via cfe-commits
hvdijk wrote: Minimal reproducer is ```c++ #include int main() {} ``` Compile and link this without any special options (specifically: without `-DNDEBUG`) against an LLVM release build, and it will now fail. https://github.com/llvm/llvm-project/pull/139938 _

[clang] [Clang] Improve ``-Wtautological-overlap-compare`` diagnostics flag (PR #133653)

2025-05-19 Thread Alexander Kornienko via cfe-commits
alexfh wrote: Also: * https://github.com/bsdjhb/gdb/blob/master/bfd/cpu-tic4x.c#L37 * https://github.com/unicode-org/icu/pull/3497 * https://github.com/KLayout/klayout/blob/master/src/tl/tl/tlUri.cc#L44 and more. Thanks a lot for the improvement! https://github.com/llvm/llvm-project/pull/133653

[clang] [Serialization] Fix lazy template loading (PR #133057)

2025-05-19 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: I can confirm that we routinely rely on the same header being part of multiple modules and results of that being combined in all kinds of ways imaginable. Moreover, the same header can be a modular header in some modules, textual in others and the resulting PCMs may also b

[libunwind] [libunwind] Add CMake option to enable execute-only code generation on AArch64 (PR #140554)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Csanád Hajdú (Il-Capitano) Changes For a full toolchain supporting execute-only code generation the runtime libraries also need to be pre-compiled with it enabled. For libunwind this can now be enabled with the `LIBUNWIND_EXECUTE_ONLY

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in DeclFriend (PR #140081)

2025-05-19 Thread Rahul Joshi via cfe-commits
@@ -90,8 +90,7 @@ class FriendDecl final : Decl(Decl::Friend, DC, L), Friend(Friend), FriendLoc(FriendL), EllipsisLoc(EllipsisLoc), UnsupportedFriend(false), NumTPLists(FriendTypeTPLists.size()) { -for (unsigned i = 0; i < NumTPLists; ++i) - getTr

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-05-19 Thread Abid Qadeer via cfe-commits
https://github.com/abidh created https://github.com/llvm/llvm-project/pull/140556 This PR add functionality to change `flang` command line using environment variable `FCC_OVERRIDE_OPTIONS`. It is quite similar to what `CCC_OVERRIDE_OPTIONS` does for clang. The `FCC_OVERRIDE_OPTIONS` seemed li

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Abid Qadeer (abidh) Changes This PR add functionality to change `flang` command line using environment variable `FCC_OVERRIDE_OPTIONS`. It is quite similar to what `CCC_OVERRIDE_OPTIONS` does for clang. The `FCC_OVERRIDE_OPTIONS`

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in DeclFriend (PR #140081)

2025-05-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/140081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Reorganize OpenCL builtins (PR #140557)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD libclc/utils/gen_convert.py `` View the diff from darker here.

[libunwind] [libunwind] Add CMake option to enable execute-only code generation on AArch64 (PR #140554)

2025-05-19 Thread Csanád Hajdú via cfe-commits
https://github.com/Il-Capitano created https://github.com/llvm/llvm-project/pull/140554 For a full toolchain supporting execute-only code generation the runtime libraries also need to be pre-compiled with it enabled. For libunwind this can now be enabled with the `LIBUNWIND_EXECUTE_ONLY_CODE`

[clang] [Serialization] Fix lazy template loading (PR #133057)

2025-05-19 Thread Maksim Ivanov via cfe-commits
emaxx-google wrote: > I'm not so sure it's about conversion function templates in particular: if > it's really commit > [658d55b](https://github.com/llvm/llvm-project/commit/658d55ba1117a029f37f51a3072585a1fd9fc59f) > causing the problem (@emaxx-google if you happen to have some time, it would

[clang] bb92c80 - [clang][bytecode][NFC] Simplify VisitCompoundLiteralExpr (#140547)

2025-05-19 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-19T17:11:34+02:00 New Revision: bb92c80dbb09e4d958d8c3c6bfc21570916d5f0e URL: https://github.com/llvm/llvm-project/commit/bb92c80dbb09e4d958d8c3c6bfc21570916d5f0e DIFF: https://github.com/llvm/llvm-project/commit/bb92c80dbb09e4d958d8c3c6bfc21570916d5f0e.diff L

[clang] [clang][bytecode][NFC] Simplify VisitCompoundLiteralExpr (PR #140547)

2025-05-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/140547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Reorganize OpenCL builtins (PR #140557)

2025-05-19 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/140557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-19 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/139256 From 3bead14691a29482705c76951eaed176bfbfc996 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Thu, 8 May 2025 18:46:41 +0200 Subject: [PATCH 01/11] [analyzer][NFC] Introduce framework for ch

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-19 Thread Andrew Rogers via cfe-commits
andrurogerz wrote: > This approach causes issues when LLVM is built in release mode (with > -DNDEBUG) and external projects build against it in debug mode (with > -UNDEBUG). I appreciate that it does what the comment says should be done, > but I think what the comment says is wrong. Specifical

[clang] 3b93122 - [clang][bytecode] Do not diagnose volatile reads in CPCE mode (#140546)

2025-05-19 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-19T17:15:37+02:00 New Revision: 3b93122907ec9d7c283398332051943964df8c9a URL: https://github.com/llvm/llvm-project/commit/3b93122907ec9d7c283398332051943964df8c9a DIFF: https://github.com/llvm/llvm-project/commit/3b93122907ec9d7c283398332051943964df8c9a.diff L

[clang] f85d03c - [NFC][Clang] Adopt simplified `getTrailingObjects` in Decl/StmtOpenACC (#140087)

2025-05-19 Thread via cfe-commits
Author: Rahul Joshi Date: 2025-05-19T08:19:27-07:00 New Revision: f85d03c21518fa87239fa4e2d23267d0d5af9cf6 URL: https://github.com/llvm/llvm-project/commit/f85d03c21518fa87239fa4e2d23267d0d5af9cf6 DIFF: https://github.com/llvm/llvm-project/commit/f85d03c21518fa87239fa4e2d23267d0d5af9cf6.diff L

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in Expr.cpp/h (PR #140102)

2025-05-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/140102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 37ece04 - [NFC][Clang] Adopt simplified `getTrailingObjects` in Expr.cpp/h (#140102)

2025-05-19 Thread via cfe-commits
Author: Rahul Joshi Date: 2025-05-19T08:20:30-07:00 New Revision: 37ece04e096b76eef5f3cf7241ea3ff0d212a8ed URL: https://github.com/llvm/llvm-project/commit/37ece04e096b76eef5f3cf7241ea3ff0d212a8ed DIFF: https://github.com/llvm/llvm-project/commit/37ece04e096b76eef5f3cf7241ea3ff0d212a8ed.diff L

[clang] [clang-format] Fix the indent of StartOfName after AttributeMacro (PR #140361)

2025-05-19 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/140361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-05-19 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > The `FCC_OVERRIDE_OPTIONS` seemed like the most obvious name to me but I am > open to other ideas. Thanks Abid. Perhaps `FFC_OVERRIDE_OPTIONS`? It has a similar correspondence to `CCC_OVERRIDE_OPTIONS` as `FCFLAGS` does to `CCFLAGS`. But I don't have a strong opinion on

[clang] [clang-format][NFC] Upgrade SortIncludes option to a struct (PR #140497)

2025-05-19 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/140497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >