llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140229.diff
1 Files Affected:
- (modified) clang/lib/AST/Expr.cpp (+3-3)
``diff
diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr
cor3ntin wrote:
Agreed, this needs a release note
https://github.com/llvm/llvm-project/pull/140179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
clang/lib/Sema/SemaTemplateInstantiate.cpp
clang/t
melver wrote:
Gentle ping - PTAL.
Many thanks!
https://github.com/llvm/llvm-project/pull/137133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1399,19 +1399,27 @@ void NVPTXAsmPrinter::emitFunctionParamList(const
Function *F, raw_ostream &O) {
if (PTy) {
O << "\t.param .u" << PTySizeInBits << " .ptr";
+bool IsCUDA = static_cast(TM).getDrvInterface()
==
+ NVPTX::CUDA;
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140264.diff
8 Files Affected:
- (modified) clang/include/clang/Basic/JsonSupport.h (+1-1)
- (modified) c
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140264.diff
8 Files Affected:
- (modified) clang/include/clang/Basic/JsonSupport.h (+1-1)
- (modified) clang/lib/Basic/Targets/AMDGP
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/140264
None
>From debfd4986c2a075f997b42dbcb0f9414c5f49ec5 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Fri, 16 May 2025 07:40:44 -0700
Subject: [PATCH] [clang] Use llvm::replace (NFC)
---
clang/include/c
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/140263
None
>From 89f75ba264c7a7677be5888909a3dca85b96ca35 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Thu, 15 May 2025 21:28:40 -0700
Subject: [PATCH] [clang-tidy] Use std::binary_search (NFC)
---
.../c
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140263.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
(+3-6)
``di
yxsamliu wrote:
> > > I don't think we should be introducing an additional option that behaves
> > > identically to another option just differing by a warning. This also
> > > isn't really a problem with the language, but the library support. The
> > > actual codegen should work just fine. Is
https://github.com/shiltian approved this pull request.
https://github.com/llvm/llvm-project/pull/140263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kikairoya updated
https://github.com/llvm/llvm-project/pull/140145
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans
balazske wrote:
We should ensure that the code builds with `-DBUILD_SHARED_LIBS=ON` cmake
option. I think this is why I can not build it. I get this error:
```
/usr/bin/ld: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTImporter.cpp.o:
in function `std::conditional, llvm::Expected, llvm::E
@@ -414,7 +414,7 @@ let Class = PropertyTypeCase in {
let Read = [{ node.getUnionValue() }];
}
def : Creator<[{
-return APValue(cast(fieldDecl), std::move(value));
+return APValue(cast_if_present(fieldDecl),
std::move(value));
alexfh wrote:
So
AaronBallman wrote:
> > We're currently inconsistent regarding attributes; sometimes we include the
> > attributes in the range, sometimes we don't. But declaration source ranges
> > are tough to reason about in general because there's many different moving
> > parts.
>
> I totally agree. I w
alexfh wrote:
> I think we need a release note in clang/docs/ReleaseNotes.rst
Which aspect would you like to cover in the release notes? The fix of the
mismatch between AST writer and AST reader or something else? Do you have a
specific wording in mind?
https://github.com/llvm/llvm-project/pu
https://github.com/ranapratap55 edited
https://github.com/llvm/llvm-project/pull/140210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh updated
https://github.com/llvm/llvm-project/pull/140179
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/138139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tgymnich approved this pull request.
https://github.com/llvm/llvm-project/pull/140200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frederick-vs-ja milestoned
https://github.com/llvm/llvm-project/pull/140105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frederick-vs-ja wrote:
/cherry-pick 136f2ba2a7bca015ef831c91fb0db5e5e31b7632
https://github.com/llvm/llvm-project/pull/140105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov approved this pull request.
LGTM
Something like:
* Fixes serialization of constexpr structs containing unions. (#GH140130)
https://github.com/llvm/llvm-project/pull/140179
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/MrSidims edited
https://github.com/llvm/llvm-project/pull/140253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
I don't have a problem with this, but I'd need to see a LOT more tests here.
We have this restriction because it wasn't clear whether the semantics work
correctly for codegen/llvm backends.
So I'd need to see some codegen tests that show that we're doi
https://github.com/aganea edited
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
> > So I'd need to see some codegen tests that show that we're doing the right
> > thing for these, plus some sort of testing that shows that we do the right
> > thing with llvm codegen.
>
> Sure, I'll work on this.
Thanks! This was really just a "tests would be a PITA to w
https://github.com/aganea edited
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea commented:
The patch looks good to me, but I have one last question:
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/aganea edited
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MrSidims wrote:
@erichkeane @AaronBallman please take a look. Limitation that currently clang
has seem to be unreasonable. Currently I'm just removing it, but I'm open to
introducing a flag, that suppresses the error or make this error be a warning.
https://github.com/llvm/llvm-project/pull/14
https://github.com/aganea edited
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,283 @@
+//===-- WindowsHotPatch.cpp - Support for Windows hotpatching
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
hahnjo wrote:
Thanks, the reproducer is indeed useful. The first "bad" commit is the second
`Complete only needed partial specializations`.
I was manually able to further reduce the example (throwing out empty files &
modules, inline through typedefs, etc)
Smaller reproducer
```
//--- 2OT.h
https://github.com/aganea edited
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea edited
https://github.com/llvm/llvm-project/pull/138972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apple-fcloutier requested changes to this pull request.
As I understand your change, it can only trip when -Wformat-nonliteral also
trips. I think that you should implement this as a note/fixit on
-Wformat-nonliteral. You should be able to leverage `checkFormatString`'s value
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Dmitry Sidorov (MrSidims)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140253.diff
4 Files Affected:
- (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+1-2)
- (modified) clang/lib/Sema/SemaType.cpp (+2
@@ -5918,6 +5918,181 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI));
}
+// Diagnosing missing format attributes is implemented in two steps:
+// 1. Detect missing forma
@@ -5918,6 +5918,181 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI));
}
+// Diagnosing missing format attributes is implemented in two steps:
+// 1. Detect missing forma
MrSidims wrote:
> So I'd need to see some codegen tests that show that we're doing the right
> thing for these, plus some sort of testing that shows that we do the right
> thing with llvm codegen.
Sure, I'll work on this.
https://github.com/llvm/llvm-project/pull/140253
__
b-sumner wrote:
> > I don't think we should be introducing an additional option that behaves
> > identically to another option just differing by a warning. This also isn't
> > really a problem with the language, but the library support. The actual
> > codegen should work just fine. Is there so
https://github.com/apple-fcloutier edited
https://github.com/llvm/llvm-project/pull/105479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5918,6 +5918,181 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI));
}
+// Diagnosing missing format attributes is implemented in two steps:
+// 1. Detect missing forma
@@ -0,0 +1,43 @@
+.. title:: clang-tidy - bugprone-function-visibility-change
+
+bugprone-function-visibility-change
+===
+
+Check changes in visibility of C++ member functions in subclasses. The check
EugeneZelenko wrote:
```sugge
@@ -0,0 +1,43 @@
+.. title:: clang-tidy - bugprone-function-visibility-change
+
+bugprone-function-visibility-change
+===
+
+Check changes in visibility of C++ member functions in subclasses. The check
+detects if a virtual function is overridden wi
@@ -124,6 +124,11 @@ New checks
pointer and store it as class members without handle the copy and move
constructors and the assignments.
+- New :doc:`bugprone-function-visibility-change
+ ` check.
+
+ Check function visibility changes in subclasses.
Euge
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/140179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Alexander Kornienko
Date: 2025-05-16T16:29:33+02:00
New Revision: 3aeced73088e08c61999a8d011e28481d959b1bc
URL:
https://github.com/llvm/llvm-project/commit/3aeced73088e08c61999a8d011e28481d959b1bc
DIFF:
https://github.com/llvm/llvm-project/commit/3aeced73088e08c61999a8d011e28481d959b1bc
https://github.com/alexfh updated
https://github.com/llvm/llvm-project/pull/140179
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
Author: Kazu Hirata
Date: 2025-05-16T07:30:46-07:00
New Revision: ab1fea49e252ac40c6c5c84eca59841ac559f932
URL:
https://github.com/llvm/llvm-project/commit/ab1fea49e252ac40c6c5c84eca59841ac559f932
DIFF:
https://github.com/llvm/llvm-project/commit/ab1fea49e252ac40c6c5c84eca59841ac559f932.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/140200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bgra8 wrote:
We have bisected build breakages internally at google at this change.
Ironically the compiler complains about a missing header while before it didn't.
We do not have a reproducer yet.
https://github.com/llvm/llvm-project/pull/138227
___
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
steakhal wrote:
> Thanks for the patches! I originally thought that renaming
> `getTagDescription` -> `getDebugName` wou
@@ -4898,6 +4898,274 @@ void
CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF,
}
}
+void CGOpenMPRuntime::emitPrivateReduction(
+CodeGenFunction &CGF, SourceLocation Loc, const Expr *Privates,
+const Expr *LHSExprs, const Expr *RHSExprs, const Expr
Author: Kazu Hirata
Date: 2025-05-16T07:32:44-07:00
New Revision: 4567c11d284fe404df80fb3293dac3e2aa85b79e
URL:
https://github.com/llvm/llvm-project/commit/4567c11d284fe404df80fb3293dac3e2aa85b79e
DIFF:
https://github.com/llvm/llvm-project/commit/4567c11d284fe404df80fb3293dac3e2aa85b79e.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/140216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4898,6 +4898,274 @@ void
CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF,
}
}
+void CGOpenMPRuntime::emitPrivateReduction(
+CodeGenFunction &CGF, SourceLocation Loc, const Expr *Privates,
+const Expr *LHSExprs, const Expr *RHSExprs, const Expr
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/140211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm wrote:
It's really a library problem, not a codegen issue. The library should still be
emitting the warning. You should be able to write wave64 code unperturbed due
to hip standard library bugs
https://github.com/llvm/llvm-project/pull/140185
___
https://github.com/tarunprabhu commented:
Could you add a test that ensures that the loop-interchange pass is added to
the pipeline. Perhaps something like
[flang/test/Driver/slp-vectorize.f90](https://github.com/llvm/llvm-project/blob/04fde85057cb4da2e560da629df7a52702eac489/flang/test/Driver/
@@ -421,7 +421,8 @@ static void CheckSubscripts(
static void CheckSubscripts(
semantics::SemanticsContext &context, CoarrayRef &ref) {
- const Symbol &coarraySymbol{ref.GetBase().GetLastSymbol()};
+ const auto &base = ref.GetBase();
+ const Symbol &coarraySymbol{base.Ge
arsenm wrote:
I am not ok with this being an error by default.
https://github.com/llvm/llvm-project/pull/140185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
b-sumner wrote:
> I am not ok with this being an error by default.
I think compilation must fail when an unsupported and untested option is
specified. And that includes when the target is SPIR-V.
https://github.com/llvm/llvm-project/pull/140185
___
https://github.com/kikairoya updated
https://github.com/llvm/llvm-project/pull/140145
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans
Author: Kazu Hirata
Date: 2025-05-16T07:32:23-07:00
New Revision: 7d633068870fde2a05596e9efa3b5ff4d9ad7097
URL:
https://github.com/llvm/llvm-project/commit/7d633068870fde2a05596e9efa3b5ff4d9ad7097
DIFF:
https://github.com/llvm/llvm-project/commit/7d633068870fde2a05596e9efa3b5ff4d9ad7097.diff
L
alexfh wrote:
@cor3ntin unfortunately, this fix causes assertion failures elsewhere:
```
assertion failed at clang/lib/AST/ASTContext.cpp:3913 in QualType
clang::ASTContext::getDecayedType(QualType) const: (T->isArrayType() ||
T->isFunctionTy
pe()) && "T does not decay"
@ 0x55637f01d274
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned
BuiltinID,
return Builder.CreateInsertElement(I0, A, 1);
}
+ case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: {
+llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext());
+
@@ -0,0 +1,31 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - |
FileCheck %s
shiltian wrote:
use right triple `amdgcn-amd-amdhsa` pls
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/140182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned
BuiltinID,
return Builder.CreateInsertElement(I0, A, 1);
}
+ case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: {
+llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext());
https://github.com/chandraghale updated
https://github.com/llvm/llvm-project/pull/134709
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
balazske wrote:
I checked the code and it looks difficult to split the `ASTImporter` to a
separate component. The problem is that `ExternalASTSource` is used for AST
related things and uses `ASTImporter` too.
Another way to fix the problem is to move code of classes like
`concepts::TypeRequire
@@ -635,5 +635,10 @@ TARGET_BUILTIN(__builtin_amdgcn_bitop3_b16, "IUi",
"nc", "bitop3-insts")
TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf16_f32, "V2yV2yfUiIb", "nc",
"f32-to-f16bf16-cvt-sr-insts")
TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_f16_f32, "V2hV2hfUiIb", "nc",
"f32-to-
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/140102
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
@@ -5043,16 +5037,18 @@ PseudoObjectExpr::PseudoObjectExpr(QualType type,
ExprValueKind VK,
: Expr(PseudoObjectExprClass, type, VK, OK_Ordinary) {
PseudoObjectExprBits.NumSubExprs = semantics.size() + 1;
PseudoObjectExprBits.ResultIndex = resultIndex + 1;
-
- for (uns
Author: Kazu Hirata
Date: 2025-05-16T09:06:17-07:00
New Revision: 589e7abea570a813ef8a2e8b8f130fd40cd07141
URL:
https://github.com/llvm/llvm-project/commit/589e7abea570a813ef8a2e8b8f130fd40cd07141
DIFF:
https://github.com/llvm/llvm-project/commit/589e7abea570a813ef8a2e8b8f130fd40cd07141.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/140263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-05-16T09:06:31-07:00
New Revision: 9adcb4fe125e5b2bdf894fb35c7d91e10c10e1ea
URL:
https://github.com/llvm/llvm-project/commit/9adcb4fe125e5b2bdf894fb35c7d91e10c10e1ea
DIFF:
https://github.com/llvm/llvm-project/commit/9adcb4fe125e5b2bdf894fb35c7d91e10c10e1ea.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/140264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4898,6 +4898,273 @@ void
CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF,
}
}
+void CGOpenMPRuntime::emitPrivateReduction(
+CodeGenFunction &CGF, SourceLocation Loc, const Expr *Privates,
+const Expr *LHSExprs, const Expr *RHSExprs, const Expr
Author: Andy Kaylor
Date: 2025-05-16T09:08:32-07:00
New Revision: 2f5a24d0c555832ec6e5747cc7bad814ed97cbdc
URL:
https://github.com/llvm/llvm-project/commit/2f5a24d0c555832ec6e5747cc7bad814ed97cbdc
DIFF:
https://github.com/llvm/llvm-project/commit/2f5a24d0c555832ec6e5747cc7bad814ed97cbdc.diff
L
Author: Andy Kaylor
Date: 2025-05-16T09:08:16-07:00
New Revision: fa2263b3097c4e5f361505ce564a246a7f289172
URL:
https://github.com/llvm/llvm-project/commit/fa2263b3097c4e5f361505ce564a246a7f289172
DIFF:
https://github.com/llvm/llvm-project/commit/fa2263b3097c4e5f361505ce564a246a7f289172.diff
L
@@ -4898,6 +4898,274 @@ void
CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF,
}
}
+void CGOpenMPRuntime::emitPrivateReduction(
+CodeGenFunction &CGF, SourceLocation Loc, const Expr *Privates,
+const Expr *LHSExprs, const Expr *RHSExprs, const Expr
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/139787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/140159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5200,6 +5460,18 @@ void CGOpenMPRuntime::emitReduction(CodeGenFunction
&CGF, SourceLocation Loc,
CGF.EmitBranch(DefaultBB);
CGF.EmitBlock(DefaultBB, /*IsFinished=*/true);
+ if (Options.IsPrivateVarReduction) {
+if (LHSExprs.empty() || Privates.empty() || Reductio
https://github.com/andykaylor commented:
Thanks for being proactive about this.
https://github.com/llvm/llvm-project/pull/140177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/140102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
@cor3ntin the reduced test case for the assertion failure above is:
https://gcc.godbolt.org/z/zveexjqW3
```
struct N {
int field;
};
template
struct B {
B(It, T);
template
B(B);
};
template
struct C {
auto g() { return B(0, T{}); }
};
void f() {
using T = decltype(C{
Author: Wenju He
Date: 2025-05-16T10:21:45+01:00
New Revision: d779b8f92b4352b88b8512709ec0fe63f1c03695
URL:
https://github.com/llvm/llvm-project/commit/d779b8f92b4352b88b8512709ec0fe63f1c03695
DIFF:
https://github.com/llvm/llvm-project/commit/d779b8f92b4352b88b8512709ec0fe63f1c03695.diff
LOG:
frasercrmck wrote:
Sure, no problem. You can probably request [commit
access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) by
now, though.
https://github.com/llvm/llvm-project/pull/139871
___
cfe-commits mailing list
cfe-commit
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/139871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/140229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-tools-extra
Author: Daan De Meyer (DaanDeMeyer)
Changes
Instead of reporting the location of the attribute, let's report the location
of the function reference that's passed to the cleanup attribute as the first
argumen
https://github.com/DaanDeMeyer created
https://github.com/llvm/llvm-project/pull/140233
Instead of reporting the location of the attribute, let's report the location
of the function reference that's passed to the cleanup attribute as the first
argument. This is required as the attribute might
https://github.com/kikairoya updated
https://github.com/llvm/llvm-project/pull/140145
>From 827e89b8148e7eaa69bbae342cfb2a59d1b09133 Mon Sep 17 00:00:00 2001
From: kikairoya
Date: Mon, 21 Apr 2025 23:30:13 +0900
Subject: [PATCH 1/2] [Cygwin][MinGW] Internal class in
explicitly-instantiation-de
balazske wrote:
I think that `ASTImporter` must be moved into a new component (directory in
"clang/lib") to fix this problem. `AST` is already dependency of `Sema` so
`Sema` can not be added to `AST` as dependency (but could be added to
`ASTImporter` if it would be a new component and `Sema` w
sjoerdmeijer wrote:
For more context, this is part of our loop-interchange enablement story, see
our RFC here: https://discourse.llvm.org/t/enabling-loop-interchange/82589.
We have fixed all the compile-time issues and loop-interchange issues that we
are aware of, and would like to enable this
301 - 400 of 468 matches
Mail list logo
