[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-16 Thread Yutong Zhu via cfe-commits
@@ -12091,6 +12091,11 @@ void Sema::CheckImplicitConversion(Expr *E, QualType T, SourceLocation CC, if (SourceMgr.isInSystemMacro(CC)) return; +if (const auto *UO = dyn_cast(E)) { + return DiagnoseImpCast(*this, E, T, CC, + diag:

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,45 @@ +//===- CirGenCXXABI.cpp - Interface to C++ ABIs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-16 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/139429 >From 0d2dcde90960b82364c0fa050be2a62b71d9d289 Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Fri, 16 May 2025 09:17:40 -0400 Subject: [PATCH 1/2] Separate implicit int conversion on negation sign to new di

[clang] [PAuth] Use different discriminators for __int128_t / __uint128_t / _BitInt(n) (PR #140276)

2025-05-16 Thread Oliver Hunt via cfe-commits
ojhunt wrote: This looks reasonable to me, but are we able to add a flag on it - we might need to be able to disable it on Darwin as it's technically an ABI change https://github.com/llvm/llvm-project/pull/140276 ___ cfe-commits mailing list cfe-commi

[clang] [clang] Add new warning: not eliding copy on return (missed NRVO) (PR #139973)

2025-05-16 Thread via cfe-commits
github-actions[bot] wrote: @grigorypas Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] [clang] Add new warning: not eliding copy on return (missed NRVO) (PR #139973)

2025-05-16 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/139973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 48587f3 - [clang] Add new warning: not eliding copy on return (missed NRVO) (#139973)

2025-05-16 Thread via cfe-commits
Author: Grigory Pastukhov Date: 2025-05-16T15:47:53-03:00 New Revision: 48587f30d63689816f3d5a1d199dba42ff332247 URL: https://github.com/llvm/llvm-project/commit/48587f30d63689816f3d5a1d199dba42ff332247 DIFF: https://github.com/llvm/llvm-project/commit/48587f30d63689816f3d5a1d199dba42ff332247.d

[clang] [clang][AArch64] Move initialization of ptrauth-* function attrs (PR #140277)

2025-05-16 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt approved this pull request. Looks good, I may start working on moving the preferences into the targetinfo unless you're working on that already https://github.com/llvm/llvm-project/pull/140277 ___ cfe-commits mailing list cfe

[clang] [PAuth] Use different discriminators for __int128_t / __uint128_t / _BitInt(n) (PR #140276)

2025-05-16 Thread Oliver Hunt via cfe-commits
ojhunt wrote: @ahatanak I've discussed this with @asl in discord, I think this is a sensible change my only real concern is the ABI, even though it would in principle require the effected types being used in an ABI exposed way to matter https://github.com/llvm/llvm-project/pull/140276

[clang] [PAuth] Use different discriminators for __int128_t / __uint128_t / _BitInt(n) (PR #140276)

2025-05-16 Thread Oliver Hunt via cfe-commits
@@ -3383,21 +3383,27 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, // Don't bother discriminating based on these types. case Type::Pipe: - case Type::BitInt: case Type::ConstantMatrix: OS << "?"; return; + case Type::BitInt: { +

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread via cfe-commits
jeremyd2019 wrote: I've hacked up llvm-mingw workflow to build and test toolchain and libc++ for mingw at https://github.com/jeremyd2019/llvm-mingw/actions/runs/15075388808, hopefully I got the workflow right and this will be the correct test of af82a52986d549e32a1384630d4a26b8ecfa7687 https:

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-16 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140099 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread via cfe-commits
https://github.com/schittir updated https://github.com/llvm/llvm-project/pull/140282 >From abdbf8905d324f9b935b34bbc97c508ede5ac028 Mon Sep 17 00:00:00 2001 From: "Chittireddy, Sindhu" Date: Fri, 16 May 2025 08:51:06 -0700 Subject: [PATCH 1/2] Add sycl_external attribute --- clang/include/cla

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/138205 >From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Thu, 1 May 2025 14:47:45 -0700 Subject: [PATCH 1/2] [clang][Sema] Don't warn for implicit uses of builtins in sy

[clang] [Basic] Use llvm::erase_if (NFC) (PR #140309)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140309 None >From dd892e582c3671e53911d15f2a3e5d3bec9fca9b Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 15 May 2025 21:28:40 -0700 Subject: [PATCH] [Basic] Use llvm::erase_if (NFC) --- clang/lib/Basi

[clang] [PAuth] Use different discriminators for __int128_t / __uint128_t / _BitInt(n) (PR #140276)

2025-05-16 Thread Anton Korobeynikov via cfe-commits
@@ -3383,21 +3383,27 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, // Don't bother discriminating based on these types. case Type::Pipe: - case Type::BitInt: case Type::ConstantMatrix: OS << "?"; return; + case Type::BitInt: { +

[clang] [llvm] [HLSL] Add resource name argument to resource class constructors (PR #139985)

2025-05-16 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/139985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add resource name argument to resource class constructors (PR #139985)

2025-05-16 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/139985 >From 8776c02d4f296f13f356c34707f4052f057c4538 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 14 May 2025 17:26:10 -0700 Subject: [PATCH] [HLSL] Add resource name argument to resource class constructors

[clang] [Driver] Use llvm::is_contained (NFC) (PR #140310)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140310 None >From 46eaadc24d6874f25e161cecb4a2e782a8c3ea35 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 16 May 2025 14:24:41 -0700 Subject: [PATCH] [Driver] Use llvm::is_contained (NFC) --- clang/lib

[clang] [Driver] Use llvm::is_contained (NFC) (PR #140310)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140310.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/MSVC.cpp (+1-1) ``diff diff --git a/clang/lib/Driver/ToolCh

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya updated https://github.com/llvm/llvm-project/pull/140145 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/2] [Cygwin][MinGW] Internal class in explicitly-instantiation-de

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/140169 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/4] [Cygwin][MinGW] Internal class in explicitly-instantiation-

[clang] [Basic] Use llvm::erase_if (NFC) (PR #140309)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140309.diff 1 Files Affected: - (modified) clang/lib/Basic/Diagnostic.cpp (+1-4) ``diff diff --git a/clang/lib/Basic/Diagnostic.cp

[clang] [Basic] Use llvm::erase_if (NFC) (PR #140309)

2025-05-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/140309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/140169 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/3] [Cygwin][MinGW] Internal class in explicitly-instantiation-

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions ,cpp,h -- clang/lib/Sema/SemaTemplateInstantiate.cpp clang/

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-05-16 Thread via cfe-commits
@@ -1988,7 +1988,7 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { /// Extra information which affects how the function is called, like /// regparm and the calling convention. LLVM_PREFERRED_TYPE(CallingConv) -unsigned ExtInfo : 14; +

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: FYI, note that even if you include clang changes here, those won't be used by the libcxx CI build; the CI uses a prebuilt build of llvm-mingw - see `.github/workflows/libcxx-build-and-test.yaml`. https://github.com/llvm/llvm-project/pull/140169 _

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
jeremyd2019 wrote: I know, I just started with #140145 for my testing, this pr is really meant for testing that no other platform is broken. https://github.com/jeremyd2019/llvm-mingw/actions/runs/15075388808 is running the full test of [af82a52](https://github.com/llvm/llvm-project/pull/1401

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Reid Kleckner via cfe-commits
@@ -1825,6 +1825,11 @@ class Sema final : public SemaBase { /// Set of no-builtin functions listed by \#pragma function. llvm::SmallSetVector MSFunctionNoBuiltins; + /// Map of BuiltinIDs to source locations that have #pragma intrinsic calls + /// that refer to them. +

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: Thanks! https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Nick Sarnie via cfe-commits
@@ -1825,6 +1825,11 @@ class Sema final : public SemaBase { /// Set of no-builtin functions listed by \#pragma function. llvm::SmallSetVector MSFunctionNoBuiltins; + /// Map of BuiltinIDs to source locations that have #pragma intrinsic calls + /// that refer to them. +

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dd4b69f - [Basic] Use llvm::erase_if (NFC) (#140309)

2025-05-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-16T15:07:54-07:00 New Revision: dd4b69f9a837048b19346eff2e9f931a51cc91c9 URL: https://github.com/llvm/llvm-project/commit/dd4b69f9a837048b19346eff2e9f931a51cc91c9 DIFF: https://github.com/llvm/llvm-project/commit/dd4b69f9a837048b19346eff2e9f931a51cc91c9.diff L

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for indirect calls (PR #139748)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -1500,6 +1507,14 @@ static void prepareTypeConverter(mlir::LLVMTypeConverter &converter, converter.addConversion([&](cir::BF16Type type) -> mlir::Type { return mlir::BFloat16Type::get(type.getContext()); }); + converter.addConversion([&](cir::FuncType type) -> mlir

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Justin Bogner (bogner) Changes There were some issues with these ops: - The overload wasn't being specified (`dx.op.dot4AddPacked` vs `dx.op.dot4AddPacked.i32`) - The versioning wasn't correct (These ops were added in SM 6.4) - The

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-spir-v Author: Justin Bogner (bogner) Changes There were some issues with these ops: - The overload wasn't being specified (`dx.op.dot4AddPacked` vs `dx.op.dot4AddPacked.i32`) - The versioning wasn't correct (These ops were added in SM 6.4) - Th

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread Justin Bogner via cfe-commits
https://github.com/bogner created https://github.com/llvm/llvm-project/pull/140315 There were some issues with these ops: - The overload wasn't being specified (`dx.op.dot4AddPacked` vs `dx.op.dot4AddPacked.i32`) - The versioning wasn't correct (These ops were added in SM 6.4) - The argument or

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) Changes There were some issues with these ops: - The overload wasn't being specified (`dx.op.dot4AddPacked` vs `dx.op.dot4AddPacked.i32`) - The versioning wasn't correct (These ops were added in SM 6.4) - T

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -135,4 +135,38 @@ cir.func @vector_insert_element_test() { // CHECK:cir.return // CHECK: } +cir.func @vector_splat_test() { +%0 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["a", init] +%1 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["shl", init] +

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -2037,4 +2037,37 @@ def VecExtractOp : CIR_Op<"vec.extract", [Pure, let hasFolder = 1; } + +//===--===// +// VecSplat +//===--===// + +/

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -2037,4 +2037,37 @@ def VecExtractOp : CIR_Op<"vec.extract", [Pure, let hasFolder = 1; } + +//===--===// +// VecSplat +//===--===// + +/

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM after you address Andy's comments https://github.com/llvm/llvm-project/pull/140099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Basic] Use llvm::erase_if (NFC) (PR #140309)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/140315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 closed https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 reopened https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. Mostly variable naming style comments from me https://github.com/llvm/llvm-project/pull/140304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -0,0 +1,45 @@ +//===- CirGenCXXABI.cpp - Interface to C++ ABIs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/140290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -0,0 +1,45 @@ +//===- CirGenCXXABI.cpp - Interface to C++ ABIs ---===// bcardosolopes wrote: `CIRGenCXXABI.cpp` to match the name of the file? (Or I guess none because this isn't required anymore?) https://github.com/llvm/llvm-projec

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -76,11 +77,30 @@ static void appendParameterTypes(const CIRGenTypes &cgt, cgt.getCGModule().errorNYI("appendParameterTypes: hasExtParameterInfos"); } +/// Derives the 'this' type for CIRGen purposes, i.e. ignoring method CVR +/// qualification. Either or both of `rd` and

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -109,6 +109,14 @@ struct CallArg { class CallArgList : public llvm::SmallVector { public: void add(RValue rvalue, clang::QualType type) { emplace_back(rvalue, type); } + + /// Add all the arguments from another CallArgList to this one. After doing + /// this, the old Cal

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. Some nits / comments, but this LGTM to me: skeleton for member function calls added, errorNYI used for untested paths and some initial support for the more simple cases. https://github.com/llvm/llvm-project/pull/140290 __

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/140304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] Add PreLegalizer pattern matching for `faceforward` (PR #139959)

2025-05-16 Thread Kaitlin Peng via cfe-commits
@@ -0,0 +1,63 @@ +# RUN: llc -verify-machineinstrs -O0 -mtriple spirv-unknown-unknown -run-pass=spirv-prelegalizer-combiner %s -o - | FileCheck %s +# REQUIRES: asserts +--- +name:faceforward_instcombine_float +tracksRegLiveness: true +legalized: true +body:

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -527,6 +709,20 @@ class OpenACCClauseCIREmitter final llvm_unreachable("Unknown construct kind in VisitGangClause"); } } + + void VisitCopyClause(const OpenACCCopyClause &clause) { +if constexpr (isOneOfTypes) { + for (auto Var : clause.getVarList()) --

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/140304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [llvm] [NFC] Run code formatter on Diagnostic.h/cpp ProfileList.cpp SpecialCaseList.cpp (PR #140316)

2025-05-16 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao created https://github.com/llvm/llvm-project/pull/140316 None >From 1a7036aa08fc1842cf953a18b29f4c44e136c808 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Fri, 16 May 2025 23:01:54 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[clang] [llvm] [NFC] Run code formatter on Diagnostic.h/cpp ProfileList.cpp SpecialCaseList.cpp (PR #140316)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Qinkun Bao (qinkunbao) Changes --- Patch is 24.81 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/140316.diff 4 Files Affected: - (modified) clang/include/clang/Basic/Diagnostic.h (+2

[clang] [llvm] [NFC] Run code formatter on Diagnostic.h/cpp ProfileList.cpp SpecialCaseList.cpp (PR #140316)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qinkun Bao (qinkunbao) Changes --- Patch is 24.81 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/140316.diff 4 Files Affected: - (modified) clang/include/clang/Basic/Diagnostic.h (+29-37)

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea approved this pull request. LGTM. Perhaps you might want to wait a few days before commiting, in case others would like to comment. https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lis

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya updated https://github.com/llvm/llvm-project/pull/140145 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/2] [Cygwin][MinGW] Internal class in explicitly-instantiation-de

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/140290 This change adds the support needed to handle a C++ member function call, including arranging the function type with an argument added for the 'this' parameter. It was necessary to introduce the class to han

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change adds the support needed to handle a C++ member function call, including arranging the function type with an argument added for the 'this' parameter. It was necessary to introduce the class to h

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes This change adds the support needed to handle a C++ member function call, including arranging the function type with an argument added for the 'this' parameter. It was necessary to introduce the class to

[clang] [llvm] [mlir] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()` (PR #140289)

2025-05-16 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/140289 >From 95948513fbfad39731abb01f40eab586bbaa26c5 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 16 May 2025 10:54:33 -0700 Subject: [PATCH] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Erich Keane via cfe-commits
@@ -0,0 +1,45 @@ +//===- CirGenCXXABI.cpp - Interface to C++ ABIs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [openmp] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-16 Thread CHANDRA GHALE via cfe-commits
@@ -4898,6 +4898,273 @@ void CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF, } } +void CGOpenMPRuntime::emitPrivateReduction( +CodeGenFunction &CGF, SourceLocation Loc, const Expr *Privates, +const Expr *LHSExprs, const Expr *RHSExprs, const Expr

[clang] [Clang] Fix a regression introduced by #140073 (PR #140288)

2025-05-16 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/140288 Pointer to data member don't decay, assuming they do caused an assertion failure. Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e;

[clang] [Clang] Fix a regression introduced by #140073 (PR #140288)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Pointer to data member don't decay, assuming they do caused an assertion failure. --- Full diff: https://github.com/llvm/llvm-project/pull/140288.diff 2 Files Affected: - (modified) clang/include/clang/Sema/

[clang] [-Wunsafe-buffer-usage] Fix false warnings when const sized array is safely accessed (array [idx %const]) (PR #140113)

2025-05-16 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 approved this pull request. LGTM! (AI comments in this PR aren't very helpful IMO 😅) https://github.com/llvm/llvm-project/pull/140113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] dd4a730 - [NFCI][Sanitizer] Convert SpecialCaseList::Sections from StringMap to vector.

2025-05-16 Thread via cfe-commits
Author: Qinkun Bao Date: 2025-05-16T15:32:54-04:00 New Revision: dd4a73069c289985afc1ccfd0c512e5791ede404 URL: https://github.com/llvm/llvm-project/commit/dd4a73069c289985afc1ccfd0c512e5791ede404 DIFF: https://github.com/llvm/llvm-project/commit/dd4a73069c289985afc1ccfd0c512e5791ede404.diff LO

[clang] [llvm] [NFCI][Sanitizer] Convert SpecialCaseList::Sections from StringMap to vector. (PR #140127)

2025-05-16 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao closed https://github.com/llvm/llvm-project/pull/140127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-16 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: steakhal wrote: > I agree, but unfortunately there is no way to get the class name > automatically in a platform-indepen

[clang] [clang][CGRecordLayout] Remove dependency on isZeroSize (PR #96422)

2025-05-16 Thread John McCall via cfe-commits
rjmccall wrote: The AMDGPU `TargetInfo` is responsible for ensuring that the choices it makes match the ABI. It is inconceivable that just dropping in the converted struct type that Clang IRGen uses as a direct parameter or result type would be a correct way to implement this; even if by chanc

[clang] [HIP] diagnose -mwavefrontsize64 for gfx10+ (PR #140185)

2025-05-16 Thread Matt Arsenault via cfe-commits
arsenm wrote: > > I am not ok with this being an error by default. > > I think compilation must fail when an unsupported and untested option is > specified. And that includes when the target is SPIR-V. I would call it a supported and used option. The unsupported and untested pieces are in the

[clang] [Clang] Fix an assertion in the resolution of perfect matches (PR #140073)

2025-05-16 Thread via cfe-commits
cor3ntin wrote: @Caslyn Expect a fix shortly. Thanks for the repro https://github.com/llvm/llvm-project/pull/140073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Move initialization of ptrauth-* function attrs (PR #140277)

2025-05-16 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss approved this pull request. LGTM. maybe worth to review the attribute handling for the synthetic function's attributes in llvm too. https://github.com/llvm/llvm-project/pull/140277 ___ cfe-commits mailing list cfe

[clang] [llvm] [mlir] [LLVM][TableGen] Rename `ListInit::getValues()` to `getElements()` (PR #140289)

2025-05-16 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/140289 Rename `ListInit::getValues()` to `getElements()` to better match with other `ListInit` members like `getElement`. Rate limit · GitHub body { background-color: #f

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-16 Thread Yutong Zhu via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 %s -verify -Wimplicit-int-conversion +// RUN: %clang_cc1 %s -verify -Wimplicit-int-conversion -Wno-implicit-int-conversion-on-negation -DNO_DIAG + +#ifdef NO_DIAG +unsigned char test_no_diag(unsigned char x) { +return -x; // expected-no-d

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread via cfe-commits
jeremyd2019 wrote: maybe try fixing the formatting complaint and see if the libc++ tests will go further? (have you tested that with the patched clang? this CI uses a pre-existing clang binary, not the one built in another workflow) https://github.com/llvm/llvm-project/pull/140145 __

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Erich Keane via cfe-commits
@@ -0,0 +1,45 @@ +//===- CirGenCXXABI.cpp - Interface to C++ ABIs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [HLSL] Use hidden visibility for external linkage. (PR #140292)

2025-05-16 Thread Steven Perron via cfe-commits
https://github.com/s-perron created https://github.com/llvm/llvm-project/pull/140292 Implements https://github.com/llvm/wg-hlsl/blob/main/proposals/0026-symbol-visibility.md. The change is to stop using the `hlsl.export` attribute. Instead, symbols with "program linkage" in HLSL will have expor

[clang] [llvm] [HLSL] Use hidden visibility for external linkage. (PR #140292)

2025-05-16 Thread Steven Perron via cfe-commits
s-perron wrote: FYI: @pow2clk Here is a possible implementation for https://github.com/llvm/wg-hlsl/blob/main/proposals/0026-symbol-visibility.md. I still need to update tests, but the change seems simple enough. https://github.com/llvm/llvm-project/pull/140292

[clang] [llvm] [HLSL] Use hidden visibility for external linkage. (PR #140292)

2025-05-16 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/140292 >From af7ac509a1bf1baf14d5d50ebe72a5d95ef9 Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Fri, 16 May 2025 14:21:01 -0400 Subject: [PATCH] [HLSL] Use hidden visibility for external linkage. Implements

[clang] [clang] fix constexpr-unknown handling of self-references. (PR #132990)

2025-05-16 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic updated https://github.com/llvm/llvm-project/pull/132990 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[clang] [Clang] Fix a regression introduced by #140073 (PR #140288)

2025-05-16 Thread via cfe-commits
cor3ntin wrote: Landing to fix a regression, feel free to do post-commit reviews https://github.com/llvm/llvm-project/pull/140288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >