[clang] 76ba29b - [NFC] Address bit-field storage sizes to ensure ideal packing (#139825)

2025-05-16 Thread via cfe-commits
Author: Oliver Hunt Date: 2025-05-16T00:02:58-07:00 New Revision: 76ba29bfd8e8aaf5b0267598d18434a0d13945a2 URL: https://github.com/llvm/llvm-project/commit/76ba29bfd8e8aaf5b0267598d18434a0d13945a2 DIFF: https://github.com/llvm/llvm-project/commit/76ba29bfd8e8aaf5b0267598d18434a0d13945a2.diff L

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-16 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/139825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-16 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/138103 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] 17853c3 - [libclang/python][NFC] Refactor wildcard import of `ctypes` (#140191)

2025-05-16 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-16T11:05:10+04:00 New Revision: 17853c3a5f59fff72f2e5071d24a365043219376 URL: https://github.com/llvm/llvm-project/commit/17853c3a5f59fff72f2e5071d24a365043219376 DIFF: https://github.com/llvm/llvm-project/commit/17853c3a5f59fff72f2e5071d24a365043219376.

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-16 Thread Jannick Kremer via cfe-commits
@@ -77,6 +77,8 @@ Clang Frontend Potentially Breaking Changes Clang Python Bindings Potentially Breaking Changes -- +- Calling methods on null-cursors now leads to an exception. +- ``Cursor.from_location`` now returns ``None`` in

[clang] [libclang/python][NFC] Refactor wildcard import of `ctypes` (PR #140191)

2025-05-16 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/140191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-16 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/138103 >From 65ad7a888dafc9992793baee8a1ccc27f1b79fa5 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 1 May 2025 18:37:43 +0900 Subject: [PATCH 01/10] [libclang/python] Add typing annotations for the Curs

[clang] [Driver][Haiku] Add /boot/system/develop/headers/gcc/include header path (PR #140189)

2025-05-16 Thread David CARLIER via cfe-commits
https://github.com/devnexen approved this pull request. https://github.com/llvm/llvm-project/pull/140189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `clang,llvm` at step 6 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/24094 Here is the relevant p

[clang] [Clang] Allow parsing arbitrary order of attributes for declarations (PR #133107)

2025-05-16 Thread kadir çetinkaya via cfe-commits
kadircet wrote: > We're currently inconsistent regarding attributes; sometimes we include the > attributes in the range, sometimes we don't. But declaration source ranges > are tough to reason about in general because there's many different moving > parts. I totally agree. I was asking to cha

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Haojian Wu via cfe-commits
@@ -414,7 +414,7 @@ let Class = PropertyTypeCase in { let Read = [{ node.getUnionValue() }]; } def : Creator<[{ -return APValue(cast(fieldDecl), std::move(value)); +return APValue(cast_if_present(fieldDecl), std::move(value)); hokein wrote: Ad

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/140179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. Thanks for the fix. I think we need a release note in clang/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/140179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Clang] Profile singly-resolved UnresolvedLookupExpr with the declaration (PR #140029)

2025-05-16 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/140029 >From 143a35ef0af10add4a0705ea4ca11856f00dcb83 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 15 May 2025 16:51:51 +0800 Subject: [PATCH] [Clang] Profile singly-resolved UnresolvedLookupExpr with the de

[clang] a23d187 - [Driver][Haiku] Add /boot/system/develop/headers/gcc/include header path (#140189)

2025-05-16 Thread via cfe-commits
Author: Brad Smith Date: 2025-05-16T03:18:19-04:00 New Revision: a23d18726d32172f855d451375df2816b815c191 URL: https://github.com/llvm/llvm-project/commit/a23d18726d32172f855d451375df2816b815c191 DIFF: https://github.com/llvm/llvm-project/commit/a23d18726d32172f855d451375df2816b815c191.diff LO

[clang] [Driver][Haiku] Add /boot/system/develop/headers/gcc/include header path (PR #140189)

2025-05-16 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/140189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::binary_search (NFC) (PR #140216)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140216.diff 6 Files Affected: - (modified) clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h (+1-2) - (modified) clang/lib/Fo

[clang] [clang] Use llvm::binary_search (NFC) (PR #140216)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140216.diff 6 Files Affected: - (modified) clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h (+1-2) - (modified) clang/lib/Format/Fo

[clang] [clang] Use llvm::binary_search (NFC) (PR #140216)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140216 None >From e5e7345a829d06f21277187b63a652d26f619fcb Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 16 May 2025 00:47:21 -0700 Subject: [PATCH] [clang] Use llvm::binary_search (NFC) --- clang/inc

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -635,5 +635,10 @@ TARGET_BUILTIN(__builtin_amdgcn_bitop3_b16, "IUi", "nc", "bitop3-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf16_f32, "V2yV2yfUiIb", "nc", "f32-to-f16bf16-cvt-sr-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_f16_f32, "V2hV2hfUiIb", "nc", "f32-to-

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable + +typedef int v8i __attribut

[clang] [CUDA][HIP] add option -gpuinc (PR #140106)

2025-05-16 Thread Matt Arsenault via cfe-commits
arsenm wrote: I thought we already added a generic -stdinc/nostdinc for this https://github.com/llvm/llvm-project/pull/140106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::binary_search (NFC) (PR #140216)

2025-05-16 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/140216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 82a9cb3 - [libclang/python] Ensure all used library functions are registered (#140015)

2025-05-16 Thread via cfe-commits
Author: Jannick Kremer Date: 2025-05-16T10:03:48+02:00 New Revision: 82a9cb358b4977e06179419b472a5b7657e55963 URL: https://github.com/llvm/llvm-project/commit/82a9cb358b4977e06179419b472a5b7657e55963 DIFF: https://github.com/llvm/llvm-project/commit/82a9cb358b4977e06179419b472a5b7657e55963.diff

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-16 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum closed https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-16 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum closed https://github.com/llvm/llvm-project/pull/138103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid emitting a linker options section in the compiler if it is empty. (PR #139821)

2025-05-16 Thread via cfe-commits
dyung wrote: Hi @pcc, I believe you originally wrote the code that is being modified, would you mind taking a quick look? https://github.com/llvm/llvm-project/pull/139821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [libclang/python] Add a few things to the python api (PR #120590)

2025-05-16 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: I am closing this PR since all changes here have been implemented in other PRs: - Additions to the `File` interface: #130383 - Additions to the `Cursor` interface: #132377 - Type annotations: #138103 https://github.com/llvm/llvm-project/pull/120590 __

[clang] [libclang/python] Add a few things to the python api (PR #120590)

2025-05-16 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum closed https://github.com/llvm/llvm-project/pull/120590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, return Builder.CreateInsertElement(I0, A, 1); } + case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: { +llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext()); +

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable + +typedef int v8i __attribut

[clang-tools-extra] Add check 'cppcoreguidelines-use-enum-class' (PR #138282)

2025-05-16 Thread Philipp Jung via cfe-commits
JungPhilipp wrote: Thanks to everybody for the quick and thorough reviews. I really appreciate the help! Is there anything else to do for me at this point? https://github.com/llvm/llvm-project/pull/138282 ___ cfe-commits mailing list cfe-commits@lists

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable arsenm wrote

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-unknown-unknown %s -emit-llvm -o - | FileCheck %s + +#pragma OPENCL EXTENSION cl_khr_fp64:enable + +typedef int v8i __attribut

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, return Builder.CreateInsertElement(I0, A, 1); } + case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: { +llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext()); +

[clang] [clang] Fix typos in documentation (PR #140211)

2025-05-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/140211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-16 Thread Oliver Hunt via cfe-commits
ojhunt wrote: > LLVM Buildbot has detected a new failure on builder > `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building > `clang,llvm` at step 6 "build-unified-tree". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/2/builds/24094 > > Here is

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Matt Arsenault via cfe-commits
@@ -683,6 +683,30 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, return Builder.CreateInsertElement(I0, A, 1); } + case AMDGPU::BI__builtin_amdgcn_image_load_2d_f32_i32: { +llvm::Type *RetTy = llvm::Type::getFloatTy(Builder.getContext()); +

[clang] c2045f2 - [libclang/python] Add typing annotations for the Cursor class (#138103)

2025-05-16 Thread via cfe-commits
Author: Jannick Kremer Date: 2025-05-16T10:11:03+02:00 New Revision: c2045f24eab06960e0418d7d82856407b19156ad URL: https://github.com/llvm/llvm-project/commit/c2045f24eab06960e0418d7d82856407b19156ad DIFF: https://github.com/llvm/llvm-project/commit/c2045f24eab06960e0418d7d82856407b19156ad.diff

[clang-tools-extra] 38e0f98 - [CLANGD] [NFC] Fix proposed by static analyzer. (#140116)

2025-05-16 Thread via cfe-commits
Author: Zahira Ammarguellat Date: 2025-05-16T07:56:36-04:00 New Revision: 38e0f983ada4cb753bcaafaf8fa9e2f2dfdef2ba URL: https://github.com/llvm/llvm-project/commit/38e0f983ada4cb753bcaafaf8fa9e2f2dfdef2ba DIFF: https://github.com/llvm/llvm-project/commit/38e0f983ada4cb753bcaafaf8fa9e2f2dfdef2ba

[clang-tools-extra] [CLANGD] [NFC] Fix proposed by static analyzer. (PR #140116)

2025-05-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/140116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix HandleLValueBase to deal with references (PR #140105)

2025-05-16 Thread via cfe-commits
llvmbot wrote: Failed to cherry-pick: 136f2ba2a7bca015ef831c91fb0db5e5e31b7632 https://github.com/llvm/llvm-project/actions/runs/15067591667 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-proje

[clang-tools-extra] [CLANGD] [NFC] Fix proposed by static analyzer. (PR #140116)

2025-05-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/140116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Diagnose exceptions only in non-dependent context in discarded `try/catch/throw` blocks (PR #139859)

2025-05-16 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/139859 >From 46a9b0193bb5bdb9a082582f19e7a32ac2a3973d Mon Sep 17 00:00:00 2001 From: Rajveer Date: Wed, 14 May 2025 13:44:31 +0530 Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent context in

[clang] [Clang] Fix parsing of expressions of the form (T())[/*...*/] (PR #140053)

2025-05-16 Thread via cfe-commits
cor3ntin wrote: Copy of a mail I sent to CWG --- This issue comes from an old LLVM issue reported by Richard, which I thought I could fix in a few minutes. I was wrong. Consider the following: ```cpp (S())[]->A; // #1 (S())[]->A {return {};}; //#2 ``` **

[clang] [clang][NFC] Clean up Expr::isTemporaryObject() (PR #140229)

2025-05-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/140229 None >From ed50778c68265d3e77f853b1d0409ef795512c7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 16 May 2025 11:42:53 +0200 Subject: [PATCH] [clang][NFC] Clean up Expr::isTemporaryOb

[clang] [clang][bytecode] Explicitly start variable lifetimes via placement new (PR #140221)

2025-05-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/140221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread via cfe-commits
@@ -414,7 +414,7 @@ let Class = PropertyTypeCase in { let Read = [{ node.getUnionValue() }]; } def : Creator<[{ -return APValue(cast(fieldDecl), std::move(value)); +return APValue(cast_if_present(fieldDecl), std::move(value)); cor3ntin wrote:

[clang] [clang][NFC] Clean up Expr::isTemporaryObject() (PR #140229)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140229.diff 1 Files Affected: - (modified) clang/lib/AST/Expr.cpp (+3-3) ``diff diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread via cfe-commits
cor3ntin wrote: Agreed, this needs a release note https://github.com/llvm/llvm-project/pull/140179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/lib/Sema/SemaTemplateInstantiate.cpp clang/t

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-05-16 Thread Marco Elver via cfe-commits
melver wrote: Gentle ping - PTAL. Many thanks! https://github.com/llvm/llvm-project/pull/137133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add errors for incorrect CUDA addrpaces (PR #138706)

2025-05-16 Thread via cfe-commits
@@ -1399,19 +1399,27 @@ void NVPTXAsmPrinter::emitFunctionParamList(const Function *F, raw_ostream &O) { if (PTy) { O << "\t.param .u" << PTySizeInBits << " .ptr"; +bool IsCUDA = static_cast(TM).getDrvInterface() == + NVPTX::CUDA;

[clang] [clang] Use llvm::replace (NFC) (PR #140264)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140264.diff 8 Files Affected: - (modified) clang/include/clang/Basic/JsonSupport.h (+1-1) - (modified) c

[clang] [clang] Use llvm::replace (NFC) (PR #140264)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140264.diff 8 Files Affected: - (modified) clang/include/clang/Basic/JsonSupport.h (+1-1) - (modified) clang/lib/Basic/Targets/AMDGP

[clang] [clang] Use llvm::replace (NFC) (PR #140264)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140264 None >From debfd4986c2a075f997b42dbcb0f9414c5f49ec5 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 16 May 2025 07:40:44 -0700 Subject: [PATCH] [clang] Use llvm::replace (NFC) --- clang/include/c

[clang-tools-extra] [clang-tidy] Use std::binary_search (NFC) (PR #140263)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140263 None >From 89f75ba264c7a7677be5888909a3dca85b96ca35 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 15 May 2025 21:28:40 -0700 Subject: [PATCH] [clang-tidy] Use std::binary_search (NFC) --- .../c

[clang-tools-extra] [clang-tidy] Use std::binary_search (NFC) (PR #140263)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140263.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp (+3-6) ``di

[clang] [HIP] diagnose -mwavefrontsize64 for gfx10+ (PR #140185)

2025-05-16 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > > I don't think we should be introducing an additional option that behaves > > > identically to another option just differing by a warning. This also > > > isn't really a problem with the language, but the library support. The > > > actual codegen should work just fine. Is

[clang-tools-extra] [clang-tidy] Use std::binary_search (NFC) (PR #140263)

2025-05-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/140263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya updated https://github.com/llvm/llvm-project/pull/140145 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans

[clang] Ast importer visitors (PR #138838)

2025-05-16 Thread Balázs Kéri via cfe-commits
balazske wrote: We should ensure that the code builds with `-DBUILD_SHARED_LIBS=ON` cmake option. I think this is why I can not build it. I get this error: ``` /usr/bin/ld: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTImporter.cpp.o: in function `std::conditional, llvm::Expected, llvm::E

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Alexander Kornienko via cfe-commits
@@ -414,7 +414,7 @@ let Class = PropertyTypeCase in { let Read = [{ node.getUnionValue() }]; } def : Creator<[{ -return APValue(cast(fieldDecl), std::move(value)); +return APValue(cast_if_present(fieldDecl), std::move(value)); alexfh wrote: So

[clang] [Clang] Allow parsing arbitrary order of attributes for declarations (PR #133107)

2025-05-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > We're currently inconsistent regarding attributes; sometimes we include the > > attributes in the range, sometimes we don't. But declaration source ranges > > are tough to reason about in general because there's many different moving > > parts. > > I totally agree. I w

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > I think we need a release note in clang/docs/ReleaseNotes.rst Which aspect would you like to cover in the release notes? The fix of the mismatch between AST writer and AST reader or something else? Do you have a specific wording in mind? https://github.com/llvm/llvm-project/pu

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-05-16 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 edited https://github.com/llvm/llvm-project/pull/140210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh updated https://github.com/llvm/llvm-project/pull/140179 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [llvm] Revert "[clang] Add scoped enum support to `StreamingDiagnostic`" (PR #138139)

2025-05-16 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/138139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Use llvm::replace (NFC) (PR #140200)

2025-05-16 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/140200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix HandleLValueBase to deal with references (PR #140105)

2025-05-16 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja milestoned https://github.com/llvm/llvm-project/pull/140105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix HandleLValueBase to deal with references (PR #140105)

2025-05-16 Thread A. Jiang via cfe-commits
frederick-vs-ja wrote: /cherry-pick 136f2ba2a7bca015ef831c91fb0db5e5e31b7632 https://github.com/llvm/llvm-project/pull/140105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM Something like: * Fixes serialization of constexpr structs containing unions. (#GH140130) https://github.com/llvm/llvm-project/pull/140179 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-16 Thread Dmitry Sidorov via cfe-commits
https://github.com/MrSidims edited https://github.com/llvm/llvm-project/pull/140253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I don't have a problem with this, but I'd need to see a LOT more tests here. We have this restriction because it wasn't clear whether the semantics work correctly for codegen/llvm backends. So I'd need to see some codegen tests that show that we're doi

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-16 Thread Erich Keane via cfe-commits
erichkeane wrote: > > So I'd need to see some codegen tests that show that we're doing the right > > thing for these, plus some sort of testing that shows that we do the right > > thing with llvm codegen. > > Sure, I'll work on this. Thanks! This was really just a "tests would be a PITA to w

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea commented: The patch looks good to me, but I have one last question: https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-16 Thread Dmitry Sidorov via cfe-commits
MrSidims wrote: @erichkeane @AaronBallman please take a look. Limitation that currently clang has seem to be unreasonable. Currently I'm just removing it, but I'm open to introducing a flag, that suppresses the error or make this error be a warning. https://github.com/llvm/llvm-project/pull/14

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
@@ -0,0 +1,283 @@ +//===-- WindowsHotPatch.cpp - Support for Windows hotpatching -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Serialization] Fix lazy template loading (PR #133057)

2025-05-16 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: Thanks, the reproducer is indeed useful. The first "bad" commit is the second `Complete only needed partial specializations`. I was manually able to further reduce the example (throwing out empty files & modules, inline through typedefs, etc) Smaller reproducer ``` //--- 2OT.h

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-16 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2025-05-16 Thread via cfe-commits
https://github.com/apple-fcloutier requested changes to this pull request. As I understand your change, it can only trip when -Wformat-nonliteral also trips. I think that you should implement this as a note/fixit on -Wformat-nonliteral. You should be able to leverage `checkFormatString`'s value

[clang] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dmitry Sidorov (MrSidims) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140253.diff 4 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+1-2) - (modified) clang/lib/Sema/SemaType.cpp (+2

[clang] [clang] Catch missing format attributes (PR #105479)

2025-05-16 Thread via cfe-commits
@@ -5918,6 +5918,181 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// Diagnosing missing format attributes is implemented in two steps: +// 1. Detect missing forma

[clang] [clang] Catch missing format attributes (PR #105479)

2025-05-16 Thread via cfe-commits
@@ -5918,6 +5918,181 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// Diagnosing missing format attributes is implemented in two steps: +// 1. Detect missing forma

[clang] [Clang] Allow vector and matrix type attributes for sub-byte _BitInt (PR #140253)

2025-05-16 Thread Dmitry Sidorov via cfe-commits
MrSidims wrote: > So I'd need to see some codegen tests that show that we're doing the right > thing for these, plus some sort of testing that shows that we do the right > thing with llvm codegen. Sure, I'll work on this. https://github.com/llvm/llvm-project/pull/140253 __

[clang] [HIP] diagnose -mwavefrontsize64 for gfx10+ (PR #140185)

2025-05-16 Thread via cfe-commits
b-sumner wrote: > > I don't think we should be introducing an additional option that behaves > > identically to another option just differing by a warning. This also isn't > > really a problem with the language, but the library support. The actual > > codegen should work just fine. Is there so

[clang] [clang] Catch missing format attributes (PR #105479)

2025-05-16 Thread via cfe-commits
https://github.com/apple-fcloutier edited https://github.com/llvm/llvm-project/pull/105479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2025-05-16 Thread via cfe-commits
@@ -5918,6 +5918,181 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// Diagnosing missing format attributes is implemented in two steps: +// 1. Detect missing forma

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-16 Thread via cfe-commits
@@ -0,0 +1,43 @@ +.. title:: clang-tidy - bugprone-function-visibility-change + +bugprone-function-visibility-change +=== + +Check changes in visibility of C++ member functions in subclasses. The check EugeneZelenko wrote: ```sugge

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-16 Thread via cfe-commits
@@ -0,0 +1,43 @@ +.. title:: clang-tidy - bugprone-function-visibility-change + +bugprone-function-visibility-change +=== + +Check changes in visibility of C++ member functions in subclasses. The check +detects if a virtual function is overridden wi

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-16 Thread via cfe-commits
@@ -124,6 +124,11 @@ New checks pointer and store it as class members without handle the copy and move constructors and the assignments. +- New :doc:`bugprone-function-visibility-change + ` check. + + Check function visibility changes in subclasses. Euge

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/140179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3aeced7 - [clang] Fix assertion failure in constexpr union deserialization (#140179)

2025-05-16 Thread via cfe-commits
Author: Alexander Kornienko Date: 2025-05-16T16:29:33+02:00 New Revision: 3aeced73088e08c61999a8d011e28481d959b1bc URL: https://github.com/llvm/llvm-project/commit/3aeced73088e08c61999a8d011e28481d959b1bc DIFF: https://github.com/llvm/llvm-project/commit/3aeced73088e08c61999a8d011e28481d959b1bc

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-16 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh updated https://github.com/llvm/llvm-project/pull/140179 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang-tools-extra] ab1fea4 - [clang-tools-extra] Use llvm::replace (NFC) (#140200)

2025-05-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-16T07:30:46-07:00 New Revision: ab1fea49e252ac40c6c5c84eca59841ac559f932 URL: https://github.com/llvm/llvm-project/commit/ab1fea49e252ac40c6c5c84eca59841ac559f932 DIFF: https://github.com/llvm/llvm-project/commit/ab1fea49e252ac40c6c5c84eca59841ac559f932.diff L

  1   2   3   4   5   >