[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-13 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-13 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] [Cygwin] Global symbols should be external by default (PR #139797)

2025-05-13 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya created https://github.com/llvm/llvm-project/pull/139797 Behaves as same as both of Clang and GCC targetting MinGW. Required for compatibility for Cygwin-GCC. Divided from https://github.com/llvm/llvm-project/pull/138773 >From 8bb0b61112d68f6cecbc15411f5080c413a4

[clang] [Cygwin] Global symbols should be external by default (PR #139797)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Tomohiro Kashiwada (kikairoya) Changes Behaves as same as both of Clang and GCC targetting MinGW. Required for compatibility for Cygwin-GCC. Divided from https://github.com/llvm/llvm-project/pull/138773 --- Patch is 96.58 KiB,

[clang] [Cygwin] Global symbols should be external by default (PR #139797)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tomohiro Kashiwada (kikairoya) Changes Behaves as same as both of Clang and GCC targetting MinGW. Required for compatibility for Cygwin-GCC. Divided from https://github.com/llvm/llvm-project/pull/138773 --- Patch is 96.58 KiB, truncate

[clang] [Cygwin] RTTI and VTable should be dllexport-ed (PR #139798)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tomohiro Kashiwada (kikairoya) Changes Behaves as same as both of Clang and GCC targetting MinGW. Required for compatibility for Cygwin-GCC. Divided from https://github.com/llvm/llvm-project/pull/138773 --- Full diff: https://github.com

[clang] [Cygwin] RTTI and VTable should be dllexport-ed (PR #139798)

2025-05-13 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya created https://github.com/llvm/llvm-project/pull/139798 Behaves as same as both of Clang and GCC targetting MinGW. Required for compatibility for Cygwin-GCC. Divided from https://github.com/llvm/llvm-project/pull/138773 Rate limit · GitHu

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ashley Coleman (V-FEXrt) Changes Partial implementation of https://github.com/llvm/wg-hlsl/issues/264 Adds several overloads to various intrinsic functions used by MiniEngine --- Full diff: https://github.com/llvm/llvm-project/pull/139800

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt created https://github.com/llvm/llvm-project/pull/139800 Partial implementation of https://github.com/llvm/wg-hlsl/issues/264 Adds several overloads to various intrinsic functions used by MiniEngine Rate limit · GitHub body {

[clang] [Cygwin] Template instantiations should be exported by default (PR #139799)

2025-05-13 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya edited https://github.com/llvm/llvm-project/pull/139799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Compound Literal Statement Constant Expression Assertion Fix (PR #139479)

2025-05-13 Thread via cfe-commits
https://github.com/Mr-Anyone updated https://github.com/llvm/llvm-project/pull/139479 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans

[clang] [Cygwin] Export global symbols, template instantiations, RTTI and VTable are exported correctly (PR #138773)

2025-05-13 Thread Tomohiro Kashiwada via cfe-commits
kikairoya wrote: Thank you. I have divided into separated PRs. They don't have conflict each. https://github.com/llvm/llvm-project/pull/139797 https://github.com/llvm/llvm-project/pull/139798 https://github.com/llvm/llvm-project/pull/139799 https://github.com/llvm/llvm-project/pull/138773 ___

[clang] [llvm] [HLSL][RootSignature] Add metadata generation for descriptor tables (PR #139633)

2025-05-13 Thread via cfe-commits
@@ -160,6 +163,75 @@ void dumpRootElements(raw_ostream &OS, ArrayRef Elements) { OS << "}"; } +static MDString *ClauseTypeToName(LLVMContext &Ctx, ClauseType Type) { + StringRef Name; + switch (Type) { + case ClauseType::CBuffer: +Name = "CBV"; +break; + case Cl

[clang] [llvm] [HLSL][RootSignature] Add metadata generation for descriptor tables (PR #139633)

2025-05-13 Thread via cfe-commits
@@ -160,6 +163,75 @@ void dumpRootElements(raw_ostream &OS, ArrayRef Elements) { OS << "}"; } +static MDString *ClauseTypeToName(LLVMContext &Ctx, ClauseType Type) { + StringRef Name; + switch (Type) { + case ClauseType::CBuffer: +Name = "CBV"; +break; + case Cl

[clang] [CIR] Upstream support for FlattenCFG switch and SwitchFlatOp (PR #139154)

2025-05-13 Thread via cfe-commits
@@ -971,6 +971,52 @@ def SwitchOp : CIR_Op<"switch", }]; } +//===--===// +// SwitchFlatOp +//===--===// + +def SwitchFlatOp : CIR_Op<"switc

[clang] [Cygwin] Template instantiations should be exported by default (PR #139799)

2025-05-13 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya created https://github.com/llvm/llvm-project/pull/139799 Behaves as same as both of Clang and GCC targetting MinGW. Required for compatibility for Cygwin-GCC. https://github.com/llvm/llvm-project/pull/138773 Rate limit · GitHub

[clang] [Cygwin] Template instantiations should be exported by default (PR #139799)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tomohiro Kashiwada (kikairoya) Changes Behaves as same as both of Clang and GCC targetting MinGW. Required for compatibility for Cygwin-GCC. https://github.com/llvm/llvm-project/pull/138773 --- Patch is 51.10 KiB, truncated to 20.00 Ki

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread Sarah Spall via cfe-commits
@@ -179,3 +179,41 @@ half3 test_lerp_half_scalar(half3 x, half3 y, half s) { return lerp(x, y, s); } float3 test_lerp_float_scalar(float3 x, float3 y, float s) { return lerp(x, y, s); } + +// CHECK: define [[FNATTRS]] <2 x float> @_Z23test_lerp_float_scalar1Dv2_ff( +// CHECK

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread Sarah Spall via cfe-commits
@@ -158,6 +158,42 @@ namespace hlsl { return fn((float4)V1, (float4)V2, (float4)V3); \ } +#define _DXC_COMPAT_BINARY_VECTOR_SCALAR_OVERLOADS(fn) \ + template \ + cons

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread Sarah Spall via cfe-commits
@@ -236,6 +257,22 @@ _DXC_COMPAT_UNARY_INTEGER_OVERLOADS(cosh) _DXC_COMPAT_UNARY_DOUBLE_OVERLOADS(degrees) _DXC_COMPAT_UNARY_INTEGER_OVERLOADS(degrees) +//===--===// +// dot builtins overloads +//===--

[clang] [WebAssembly][Clang] Add __builtin_wasm_ref_is_null_extern (PR #139580)

2025-05-13 Thread Hood Chatham via cfe-commits
https://github.com/hoodmane updated https://github.com/llvm/llvm-project/pull/139580 >From 2ca282f0a20088bef15289a8ce5167d1e23595c3 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Fri, 9 May 2025 00:16:26 -0400 Subject: [PATCH 1/3] [Wasm][Clang] Add __builtin_wasm_ref_is_null_extern I also

[clang] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and older (PR #124651)

2025-05-13 Thread via cfe-commits
https://github.com/Un1q32 updated https://github.com/llvm/llvm-project/pull/124651 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-13 Thread Tom Honermann via cfe-commits
@@ -0,0 +1,155 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c++20 -Wconversion %s + +void c8(char8_t); +void c16(char16_t); +void c32(char32_t); + +void test(char8_t u8, char16_t u16, char32_t u32) { +c8(u8); +c8(u16); // expected-warning {{implicit conversion from 'c

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-13 Thread Tom Honermann via cfe-commits
@@ -1567,15 +1568,81 @@ void Sema::checkEnumArithmeticConversions(Expr *LHS, Expr *RHS, } } +static void CheckUnicodeArithmeticConversions(Sema &SemaRef, Expr *LHS, + Expr *RHS, SourceLocation Loc, +

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-13 Thread Tom Honermann via cfe-commits
@@ -11810,6 +11811,46 @@ static void DiagnoseIntInBoolContext(Sema &S, Expr *E) { } } +static void DiagnoseMixedUnicodeImplicitConversion(Sema &S, const Type *Source, + const Type *Target, Expr *E, +

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-13 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann approved this pull request. Thanks @cor3ntin, this looks good to me! https://github.com/llvm/llvm-project/pull/138708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-13 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/138708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][counted_by] Add support for 'counted_by' on struct pointers (PR #137250)

2025-05-13 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/137250 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans

[clang] 9ae3bce - [Clang][counted_by] Add support for 'counted_by' on struct pointers (#137250)

2025-05-13 Thread via cfe-commits
Author: Bill Wendling Date: 2025-05-13T16:01:36-07:00 New Revision: 9ae3bce17543f92ce0237597cc66503d58cce317 URL: https://github.com/llvm/llvm-project/commit/9ae3bce17543f92ce0237597cc66503d58cce317 DIFF: https://github.com/llvm/llvm-project/commit/9ae3bce17543f92ce0237597cc66503d58cce317.diff

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread Ashley Coleman via cfe-commits
@@ -158,6 +158,42 @@ namespace hlsl { return fn((float4)V1, (float4)V2, (float4)V3); \ } +#define _DXC_COMPAT_BINARY_VECTOR_SCALAR_OVERLOADS(fn) \ + template \ + cons

[clang] [Clang][counted_by] Add support for 'counted_by' on struct pointers (PR #137250)

2025-05-13 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/137250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly][Clang] Add __builtin_wasm_ref_is_null_extern (PR #139580)

2025-05-13 Thread Sam Clegg via cfe-commits
https://github.com/sbc100 approved this pull request. https://github.com/llvm/llvm-project/pull/139580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread Ashley Coleman via cfe-commits
@@ -236,6 +257,22 @@ _DXC_COMPAT_UNARY_INTEGER_OVERLOADS(cosh) _DXC_COMPAT_UNARY_DOUBLE_OVERLOADS(degrees) _DXC_COMPAT_UNARY_INTEGER_OVERLOADS(degrees) +//===--===// +// dot builtins overloads +//===--

[clang] [HLSL] Add various overloads for MiniEngine (PR #139800)

2025-05-13 Thread Ashley Coleman via cfe-commits
@@ -179,3 +179,41 @@ half3 test_lerp_half_scalar(half3 x, half3 y, half s) { return lerp(x, y, s); } float3 test_lerp_float_scalar(float3 x, float3 y, float s) { return lerp(x, y, s); } + +// CHECK: define [[FNATTRS]] <2 x float> @_Z23test_lerp_float_scalar1Dv2_ff( +// CHECK

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Thurston Dang (thurstond) Changes This connects the -fsanitize-annotate-debug-info plumbing (https://github.com/llvm/llvm-project/pull/138577) to CFI check codegen. Updates the tests from https://github.com/llvm/llvm-project/pull/139149.

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Thurston Dang (thurstond) Changes This connects the -fsanitize-annotate-debug-info plumbing (https://github.com/llvm/llvm-project/pull/138577) to CFI check codegen. Updates the tests from https://github.com/llvm/llvm-project/pull/

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-13 Thread Thurston Dang via cfe-commits
https://github.com/thurstond created https://github.com/llvm/llvm-project/pull/139809 This connects the -fsanitize-annotate-debug-info plumbing (https://github.com/llvm/llvm-project/pull/138577) to CFI check codegen. Updates the tests from https://github.com/llvm/llvm-project/pull/139149. A s

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-13 Thread Thurston Dang via cfe-commits
https://github.com/thurstond edited https://github.com/llvm/llvm-project/pull/139809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-13 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/139809 >From ead256dfd33d04877766ddb26830f264682e9b48 Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Wed, 7 May 2025 23:33:21 + Subject: [PATCH 1/2] [cfi] Enable -fsanitize-annotate-debug-info functionality

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-13 Thread Florian Mayer via cfe-commits
fmayer wrote: I am not a fan of the change to the function used for array-bounds. https://github.com/llvm/llvm-project/pull/139809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for FlattenCFG switch and SwitchFlatOp (PR #139154)

2025-05-13 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/139154 >From f77464dbe1de51c89fbde5e5decfc2314cd7dba6 Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 8 May 2025 15:39:49 -0500 Subject: [PATCH 1/2] Add support for FlattenCFG switch and introduce

[clang] [CIR] Upstream support for FlattenCFG switch and SwitchFlatOp (PR #139154)

2025-05-13 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/139154 >From f77464dbe1de51c89fbde5e5decfc2314cd7dba6 Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 8 May 2025 15:39:49 -0500 Subject: [PATCH 1/3] Add support for FlattenCFG switch and introduce

[clang] [CIR] Upstream support for FlattenCFG switch and SwitchFlatOp (PR #139154)

2025-05-13 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/139154 >From f77464dbe1de51c89fbde5e5decfc2314cd7dba6 Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 8 May 2025 15:39:49 -0500 Subject: [PATCH 1/4] Add support for FlattenCFG switch and introduce

[clang] [CIR] Upstream support for FlattenCFG switch and SwitchFlatOp (PR #139154)

2025-05-13 Thread via cfe-commits
@@ -171,6 +171,232 @@ class CIRScopeOpFlattening : public mlir::OpRewritePattern { } }; +class CIRSwitchOpFlattening : public mlir::OpRewritePattern { +public: + using OpRewritePattern::OpRewritePattern; + + inline void rewriteYieldOp(mlir::PatternRewriter &rewriter, +

[clang] [Clang] Remove workaround for libstdc++4.7 (PR #139693)

2025-05-13 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. The changes should come with a release note mentioning that we've removed the hack because it's no longer a supported libstdc++ (for the few users still relying on the hack). Otherwise, LGTM! https://github.com/llvm/llvm-project/pull

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-05-13 Thread Jeremy Morse via cfe-commits
jmorse wrote: It sounds like there's agreement that the "before" approach was better/acceptable, i.e. having a CU-level variable that refers by `DW_AT_specification` to a variable in the class type. Doing so would also avoid the customisation for vtable-addresses in the latest patch with the

[clang] [Clang][RISCV] Add preprocessor macros for Zicfilp CFI scheme (PR #109600)

2025-05-13 Thread Ming-Yi Lai via cfe-commits
@@ -238,6 +238,25 @@ void RISCVTargetInfo::getTargetDefines(const LangOptions &Opts, else Builder.defineMacro("__riscv_32e"); } + + if (Opts.CFProtectionBranch) { +auto Scheme = Opts.getCFBranchLabelScheme(); +if (Scheme == CFBranchLabelSchemeKind::Default

[clang] [Clang][RISCV] Add preprocessor macros for Zicfilp CFI scheme (PR #109600)

2025-05-13 Thread Ming-Yi Lai via cfe-commits
https://github.com/mylai-mtk updated https://github.com/llvm/llvm-project/pull/109600 >From 3bb0b659009ade3dcd04d7bbb88b57e7b072fac5 Mon Sep 17 00:00:00 2001 From: Ming-Yi Lai Date: Fri, 10 May 2024 14:16:59 +0800 Subject: [PATCH 1/7] [clang][RISCV] Add Zicfilp CFI scheme preprocessor macros T

[clang] [lld] [llvm] [mlir] [NFC] Use more isa and isa_and_nonnull instead dyn_cast for predicates (PR #137393)

2025-05-13 Thread Longsheng Mou via cfe-commits
https://github.com/CoTinker approved this pull request. https://github.com/llvm/llvm-project/pull/137393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Save ShuffleVectorExpr args as ConstantExpr (PR #139709)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Timm Baeder (tbaederr) Changes The passed indices have to be constant integers anyway, which we verify before creating the ShuffleVectorExpr. Use the value we create there and save the indices using a ConstantExpr instead. This wa

[clang] [Clang] Remove workaround for libstdc++4.7 (PR #139693)

2025-05-13 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > We document libstdc++4.8 as the minimum supported version It took me quite a while to find that documentation, we probably should make this a bit more prominent from the getting started page at some point: https://github.com/llvm/llvm-project/blob/c14acb74423a577e10bbb635

[clang] c14acb7 - [clang][bytecode] Save Immediate bit in Function (#139671)

2025-05-13 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-13T12:56:08+02:00 New Revision: c14acb74423a577e10bbb635109851742e77444f URL: https://github.com/llvm/llvm-project/commit/c14acb74423a577e10bbb635109851742e77444f DIFF: https://github.com/llvm/llvm-project/commit/c14acb74423a577e10bbb635109851742e77444f.diff L

[clang] [clang][bytecode] Save Immediate bit in Function (PR #139671)

2025-05-13 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/139671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [Clang][RISCV] Add preprocessor macros for Zicfilp CFI scheme (PR #109600)

2025-05-13 Thread Ming-Yi Lai via cfe-commits
https://github.com/mylai-mtk updated https://github.com/llvm/llvm-project/pull/109600 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans

[clang] [clang] Save ShuffleVectorExpr args as ConstantExpr (PR #139709)

2025-05-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/139709 The passed indices have to be constant integers anyway, which we verify before creating the ShuffleVectorExpr. Use the value we create there and save the indices using a ConstantExpr instead. This way, we don'

[clang] [clang] Save ShuffleVectorExpr args as ConstantExpr (PR #139709)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The passed indices have to be constant integers anyway, which we verify before creating the ShuffleVectorExpr. Use the value we create there and save the indices using a ConstantExpr instead. This way, we do

[clang] [clang][bytecode][NFC] Delete DynamicAllocator copy/move ctors (PR #139710)

2025-05-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/139710 They should never be needed. Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,S

[clang] [clang][bytecode][NFC] Delete DynamicAllocator copy/move ctors (PR #139710)

2025-05-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes They should never be needed. --- Full diff: https://github.com/llvm/llvm-project/pull/139710.diff 1 Files Affected: - (modified) clang/lib/AST/ByteCode/DynamicAllocator.h (+2) ``diff diff --git

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-13 Thread Donát Nagy via cfe-commits
@@ -3411,12 +3411,12 @@ PathSensitiveBugReporter::generateDiagnosticForConsumerMap( } void BugReporter::EmitBasicReport(const Decl *DeclWithIssue, - const CheckerBase *Checker, StringRef Name, + const CheckerFr

[clang] [clang] Save ShuffleVectorExpr args as ConstantExpr (PR #139709)

2025-05-13 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM but it looks like some unit tests still need updating. https://github.com/llvm/llvm-project/pull/139709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-13 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/139256 From 3bead14691a29482705c76951eaed176bfbfc996 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Thu, 8 May 2025 18:46:41 +0200 Subject: [PATCH 1/2] [analyzer][NFC] Introduce framework for chec

[clang] [C] Add -Wtentative-definition-compat (PR #137967)

2025-05-13 Thread via cfe-commits
asmok-g wrote: Or even simpler: ``` extern const int x; const int x = 0; ``` https://github.com/llvm/llvm-project/pull/137967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-13 Thread Donát Nagy via cfe-commits
@@ -3411,12 +3411,12 @@ PathSensitiveBugReporter::generateDiagnosticForConsumerMap( } void BugReporter::EmitBasicReport(const Decl *DeclWithIssue, - const CheckerBase *Checker, StringRef Name, + const CheckerFr

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-13 Thread Donát Nagy via cfe-commits
@@ -50,11 +50,11 @@ bool CheckerManager::hasPathSensitiveCheckers() const { } void CheckerManager::reportInvalidCheckerOptionValue( -const CheckerBase *C, CheckerPartIdx Idx, StringRef OptionName, +const CheckerFrontend *CP, StringRef OptionName, NagyD

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-05-13 Thread Carlos Alberto Enciso via cfe-commits
https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/130255 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,

[clang] Revert "[Clang][Sema] Handle invalid variable template specialization whose type depends on itself (#134522)" (PR #139539)

2025-05-13 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis closed https://github.com/llvm/llvm-project/pull/139539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-13 Thread Donát Nagy via cfe-commits
@@ -56,11 +54,11 @@ static const Expr *getDenomExpr(const ExplodedNode *N) { void DivZeroChecker::reportBug(StringRef Msg, ProgramStateRef StateZero, CheckerContext &C) const { - if (!isPartEnabled(DivideZeroChecker)) + if (!DivideZeroChecker.i

[clang] [Clang] Remove workaround for libstdc++4.7 (PR #139693)

2025-05-13 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman We previously removed other such hacks, do you think a release > note is still useful > [6ad7e87](https://github.com/llvm/llvm-project/commit/6ad7e87806c0af774cf2f8880694f79259925979) > ? Yeah, I think a release note is still handy, just so users aren't sur

[clang] [OpenCL] No need to check array of struct for kernel arguments (PR #138894)

2025-05-13 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/138894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-13 Thread via cfe-commits
MolecularMatters wrote: > This is very interesting! > > Initially I also assumed this was about Edit&Continue. As users may have the > same idea, I'd suggest adding `DocBrief`s to the new Clang options, and a > comment at the top of llvm/lib/CodeGen/WindowsHotPatch.cpp that explain in > more

[clang] [Clang] Remove workaround for libstdc++4.7 (PR #139693)

2025-05-13 Thread via cfe-commits
cor3ntin wrote: @AaronBallman We previously removed other such hacks, do you think a release note is still useful https://github.com/llvm/llvm-project/commit/6ad7e87806c0af774cf2f8880694f79259925979 ? https://github.com/llvm/llvm-project/pull/139693 ___

[clang] 8aaac80 - [NFC] Use more isa and isa_and_nonnull instead dyn_cast for predicates (#137393)

2025-05-13 Thread via cfe-commits
Author: Max Graey Date: 2025-05-13T22:34:42+08:00 New Revision: 8aaac80ddde6a23527d3caa98ec998ebe402e0d9 URL: https://github.com/llvm/llvm-project/commit/8aaac80ddde6a23527d3caa98ec998ebe402e0d9 DIFF: https://github.com/llvm/llvm-project/commit/8aaac80ddde6a23527d3caa98ec998ebe402e0d9.diff LOG

[clang] [llvm] Revert "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations" (PR #139739)

2025-05-13 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] Revert "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations" (PR #139739)

2025-05-13 Thread via cfe-commits
https://github.com/guillem-bartrina-sonarsource created https://github.com/llvm/llvm-project/pull/139739 This reverts commit 05d613ea931b6de1b46dfe04b8e55285359047f4. Only **one single** test has been added after the reverted patch that makes use of the _functionality_ it introduced. * The mac

[clang] [lld] [llvm] [mlir] [NFC] Use more isa and isa_and_nonnull instead dyn_cast for predicates (PR #137393)

2025-05-13 Thread via cfe-commits
github-actions[bot] wrote: @MaxGraey Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] [lld] [llvm] [mlir] [NFC] Use more isa and isa_and_nonnull instead dyn_cast for predicates (PR #137393)

2025-05-13 Thread Longsheng Mou via cfe-commits
https://github.com/CoTinker closed https://github.com/llvm/llvm-project/pull/137393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C] Add -Wtentative-definition-compat (PR #137967)

2025-05-13 Thread via cfe-commits
asmok-g wrote: Thanks a lot for the quick fix! https://github.com/llvm/llvm-project/pull/137967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer] Document configuration options (PR #135169)

2025-05-13 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,286 @@ +#!/usr/bin/env python3 +# A tool to automatically generate documentation for the config options of the +# clang static analyzer by reading `AnalyzerOptions.def`. + +import argparse +from collections import namedtuple +from enum import Enum, auto +import re +impo

[clang] [flang] [llvm] [openmp] [Flang][OpenMP] Move builtin .mod generation into runtimes (PR #137828)

2025-05-13 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur updated https://github.com/llvm/llvm-project/pull/137828 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] 69ce681 - [Serialization] Use StringRef::substr (NFC) (#139678)

2025-05-13 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-13T07:12:57-07:00 New Revision: 69ce68109a3df221b507eb2308d5984ee7a71e22 URL: https://github.com/llvm/llvm-project/commit/69ce68109a3df221b507eb2308d5984ee7a71e22 DIFF: https://github.com/llvm/llvm-project/commit/69ce68109a3df221b507eb2308d5984ee7a71e22.diff L

[clang] [RISC-V] Allow intrinsics to be used with any pointer type. (PR #139634)

2025-05-13 Thread Luke Lau via cfe-commits
lukel97 wrote: Linking some context here, IIUC the use case for this is for OpenCL where device code would use a non-default address space: https://github.com/llvm/llvm-project/pull/137045#issuecomment-2872208568 https://github.com/llvm/llvm-project/pull/139634 __

[clang] [clang-tools-extra] [Clang] Add builtins that deduplicate and sort types (PR #106730)

2025-05-13 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/106730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISC-V] Allow intrinsics to be used with any pointer type. (PR #139634)

2025-05-13 Thread Luke Lau via cfe-commits
lukel97 wrote: > I don't know how many users are requiring this change, but I do know some > people are developing RVV-based heterogeneous hardware/software. I am happy > to see this and we should make more people be aware of this change, so I > suggest to post it on Discourse as well. I thin

[clang] [Preprocessor] Do not expand macros if the input is already preprocessed (PR #137665)

2025-05-13 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/137665 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-13 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/139256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Disable checking invalid template id in initializer of primary variable template `std::format_kind` with libstdc++ (PR #139560)

2025-05-13 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/139560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Add __builtin_type_pack_dedup template to deduplicate types in template arguments (PR #106730)

2025-05-13 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: I have made quite a bit of progress here, but we also need the deduplication builting urgently to help ease the pain for some of the big compilations that started hitting our infrastructure limits internally. I have created #139730 with the initial and simple version of th

[clang] [Preprocessor] Do not expand macros if the input is already preprocessed (PR #137665)

2025-05-13 Thread Juan Manuel Martinez Caamaño via cfe-commits
jmmartinez wrote: I fixed the `Modules/initializers.cpp` test by moving the preprocessor directives outside of the module contents (the module contents should be already preprocessed and not contain preproc directives). https://github.com/llvm/llvm-project/pull/137665 _

[clang] [C] Add -Wtentative-definition-compat (PR #137967)

2025-05-13 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Is there maybe a quick fix or should we add a revert (to revert to green)? I'm still investigating, so unclear on a quick fix. But to make sure I understand correctly, things *are* green (no bots are failing, right?), this is just a false positive? Or am I missing somethi

[clang] [Clang] Add a builtin for efficient type deduplication (PR #139730)

2025-05-13 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: This is a simple initial version of a builtin in #106730 that does **not** introduce new kind of packs that can be produced by builtins rather than variadic template parameters and instead relies on features already available in C++. This makes the implementation much sim

[clang] [clang-tools-extra] [Clang] Add builtins that deduplicate and sort types (PR #106730)

2025-05-13 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/106730 >From e2d345d490d73f46d969b9a5945d9bfe11e148f9 Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Fri, 23 Aug 2024 17:27:26 +0200 Subject: [PATCH 1/2] [Clang] Add builtins that deduplicate and sort types

[clang] [clang-tools-extra] [Clang] Add builtins that deduplicate and sort types (PR #106730)

2025-05-13 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Note to people reviewing this: please ensure you "hide whitespace" via `git diff -w` or the corresponding setting on GitHub. For your own sanity when looking at changes in `TreeTransform.h`, which are otherwise really complicated to validate. I've deliberately kept the cod

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-13 Thread Donát Nagy via cfe-commits
NagyDonat wrote: I handled all the inline comments. I have one minor architectural question: we should standardize a way to assign a single tag description (that is, identifiers that can be used in debug dumps) to each checker family. The old code automatically used the name of the first chec

[clang] [llvm] Add macro to suppress -Wunnecessary-virtual-specifier (PR #139614)

2025-05-13 Thread Devon Loehr via cfe-commits
DKLoehr wrote: I've only had ad-hoc discussions on the matter, but everyone I've talked to seems to fall in the latter camp. As mentioned in #138741, I didn't see any other project with a similar policy among chromium and all of its dependencies. I'd have no problem if we decided to do away wi

[clang] [Serialization] Use StringRef::substr (NFC) (PR #139678)

2025-05-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] ac583df - [include-cleaner] Use heterogeneous lookups (NFC) (#139685)

2025-05-13 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-13T07:13:25-07:00 New Revision: ac583df03b3c1b2cc3ef7ececbeca697f3449bec URL: https://github.com/llvm/llvm-project/commit/ac583df03b3c1b2cc3ef7ececbeca697f3449bec DIFF: https://github.com/llvm/llvm-project/commit/ac583df03b3c1b2cc3ef7ececbeca697f3449bec.diff L

[clang-tools-extra] [include-cleaner] Use heterogeneous lookups (NFC) (PR #139685)

2025-05-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [NFC] Use more isa and isa_and_nonnull instead dyn_cast for predicates (PR #137393)

2025-05-13 Thread Max Graey via cfe-commits
MaxGraey wrote: Ok, it looks like ci successfully passed https://github.com/llvm/llvm-project/pull/137393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Stop changing DC when instantiating dependent friend specializations (PR #139436)

2025-05-13 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. Perfect, thanks! https://github.com/llvm/llvm-project/pull/139436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-05-13 Thread Feng Zou via cfe-commits
fzou1 wrote: > We should avoid introducing a new cmake config for changes like this. You > could utilize clang config file to specify the option. > > lld change should have been separated Sorry for late reply. The related cmake and LLD changes were reverted. Only a backend pass and option wer

  1   2   3   4   5   6   >