[clang] [clang][Unit Test] Updating Negative Stat Caching Diagnostic Unit Test (PR #138955)

2025-05-08 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu closed https://github.com/llvm/llvm-project/pull/138955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-08 Thread via cfe-commits
@@ -0,0 +1,84 @@ +//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-08 Thread Alexandre Ganea via cfe-commits
@@ -176,6 +176,21 @@ class CallerSym : public SymbolRecord { uint32_t RecordOffset = 0; }; +class HotPatchFuncSym : public SymbolRecord { aganea wrote: Out of curiosity (related to my other questions), historically Windows updates only deliver binaries (DL

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-08 Thread Erich Keane via cfe-commits
@@ -6861,13 +6861,16 @@ ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D, const ParsedAttr &AL, // though they were unknown attributes. if (AL.getKind() == ParsedAttr::UnknownAttribute || !AL.existsInTarget(S.Context.getTargetInfo())) { -S.Diag(AL.getLoc(), -

[clang] [mlir] [OpenACC][CIR] Implement 'gang' lowering for 'loop' (PR #138968)

2025-05-08 Thread Erich Keane via cfe-commits
erichkeane wrote: Linux failure is an unrelated Flang failure. ``` Failed Tests (1): Flang :: Driver/mcmodel.f90 ``` https://github.com/llvm/llvm-project/pull/138968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [clang-tools-extra] [libcxx] [llvm] [www][docs] Remove last mentions of IRC (PR #139076)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes It's the end of an era. The IRC channel was previously where the community gathered to discuss technical topics but is now a ghost town where the primary activity is moderat

[clang] ce7c196 - [Clang] Ignore -fchar8_t in C (#138716)

2025-05-08 Thread via cfe-commits
Author: cor3ntin Date: 2025-05-08T12:15:05+02:00 New Revision: ce7c1963b914931817dd983f488cc0b810187b3a URL: https://github.com/llvm/llvm-project/commit/ce7c1963b914931817dd983f488cc0b810187b3a DIFF: https://github.com/llvm/llvm-project/commit/ce7c1963b914931817dd983f488cc0b810187b3a.diff LOG:

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-08 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,84 @@ +//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-08 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,84 @@ +//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-08 Thread Shilei Tian via cfe-commits
@@ -481,6 +481,9 @@ static cl::opt HasClosedWorldAssumption( cl::desc("Whether has closed-world assumption at link time"), cl::init(false), cl::Hidden); +static cl::opt VerifyTarget("verify-tgt", shiltian wrote: `verify-tgt` is too broad. I'd add an `

[clang] [clang-installapi] Store dylib attributes in the order they are passed on the command line. (PR #139087)

2025-05-08 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida edited https://github.com/llvm/llvm-project/pull/139087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 55517f5 - [HLSL][RootSignature] Add parsing for empty RootConstants (#137999)

2025-05-08 Thread via cfe-commits
Author: Finn Plummer Date: 2025-05-08T08:24:47-07:00 New Revision: 55517f5f4495968d01100aa00d63db7842842270 URL: https://github.com/llvm/llvm-project/commit/55517f5f4495968d01100aa00d63db7842842270 DIFF: https://github.com/llvm/llvm-project/commit/55517f5f4495968d01100aa00d63db7842842270.diff

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-08 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,84 @@ +//===-- llvm/Target/TargetVerifier.h - LLVM IR Target Verifier --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [git-clang-format] add fallback style argument option (PR #137609)

2025-05-08 Thread Andrej Pištek via cfe-commits
https://github.com/apdofficial updated https://github.com/llvm/llvm-project/pull/137609 From 2e82063e9e2c159a7a713ecedbcc0bfbdbf66143 Mon Sep 17 00:00:00 2001 From: Andrej Pistek Date: Mon, 7 Apr 2025 13:37:47 +0200 Subject: [PATCH] [git-clang-format] add fallback style arg --- clang/tools/cl

[clang] FEAT: 1 byte for "true" & "false" (PR #138713)

2025-05-08 Thread SAKSHAM JOSHI via cfe-commits
https://github.com/saksham-joshi closed https://github.com/llvm/llvm-project/pull/138713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] FEAT: 1 byte for "true" & "false" (PR #138713)

2025-05-08 Thread SAKSHAM JOSHI via cfe-commits
saksham-joshi wrote: > > Yeah! you are right that the size depends on the variable, but I never said > > to create a variable. > > Suppose I have two functions performing same process but one is returning > > bool and other one is returning int. > > > > 1. bool fnc1() { return (_Bool)true; } >

[clang-tools-extra] Add flag to specify an alternative to std::forward (PR #138755)

2025-05-08 Thread Dimitrije Dobrota via cfe-commits
DimitrijeDobrota wrote: > LGTM. It looks similar as #138757. could you add a test for both PR. I have the issue where I want to test the `custom_move` and I need check to pass only for `-check-suffix=,MOVEFUNCTION` and fail for everything else, since it still expects `::std::move`. I am not su

[clang] refactor(libclang): add CXS_StringRef (PR #139093)

2025-05-08 Thread via cfe-commits
https://github.com/illusory0x0 created https://github.com/llvm/llvm-project/pull/139093 None From f3a692b7b0e4800277bf7df10e800ccacce98b37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8C=97=E9=9C=B2?= <69190413+illusory...@users.noreply.github.com> Date: Thu, 8 May 2025 23:00:54 +0800 Subject:

[clang] refactor(libclang): add CXS_StringRef (PR #139093)

2025-05-08 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootConstants (PR #137999)

2025-05-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/137999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-08 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/139057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 850d96e - [ObjC] Also enable ARC attachedcall operand bundle for arm64_32. (#138677)

2025-05-08 Thread via cfe-commits
Author: Marina Taylor Date: 2025-05-08T16:48:18+01:00 New Revision: 850d96e63a611c46313a5448cd49197d9295ce5f URL: https://github.com/llvm/llvm-project/commit/850d96e63a611c46313a5448cd49197d9295ce5f DIFF: https://github.com/llvm/llvm-project/commit/850d96e63a611c46313a5448cd49197d9295ce5f.diff

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-08 Thread via cfe-commits
sivadeilra wrote: > Can you provide a more technical insight about how is this gonna be used? > What are the equivalent MSVC flags? Why is it that users (programmers) need > to select specific functions to hotpatch? This PR is intended to allow LLVM-generated code to work with Windows hot-pat

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-08 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai closed https://github.com/llvm/llvm-project/pull/138227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-08 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/138972 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] [clang] Remove "unknown" from availability diags (PR #138610)

2025-05-08 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan approved this pull request. Thanks. LGTM. https://github.com/llvm/llvm-project/pull/138610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove "unknown" from availability diags (PR #138610)

2025-05-08 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/138610 >From d642c83835743409395a2b7a091eac8bf5c948c4 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Mon, 5 May 2025 16:09:00 -0700 Subject: [PATCH 1/2] [clang] Remove "unknown" from availability diags Previous

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-08 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/139057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-08 Thread Alexey Bataev via cfe-commits
@@ -4899,6 +4899,237 @@ void CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF, } } +void CGOpenMPRuntime::emitPrivateReduction( +CodeGenFunction &CGF, SourceLocation Loc, const Expr *Privates, +const Expr *LHSExprs, const Expr *RHSExprs, const Expr

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138592 >From af3e49f1290c61d5856a5ddf600cfd19ef485e25 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Mon, 5 May 2025 23:01:02 +0200 Subject: [PATCH 1/3] [clang][OpenMP] Add error for large expr in collapse ---

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-08 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: > In addition to the collapse clause, the ordered clause also seems to have the > same problem. For example, does your patch also fix the following crash? If > so, you also need tests regarding the ordered clause. > https://godbolt.org/z/96sa5jxff > > ```c++ > void f(void)

[clang] [clang] Remove "unknown" from availability diags (PR #138610)

2025-05-08 Thread Cyndy Ishida via cfe-commits
cyndyishida wrote: > The change looks reasonable but can you add a test? thanks! Open to other suggestions @cor3ntin, but I didn't figure out a way to ensure part of a diagnostic was omitted with cc1's `-verify` so its a driver test that uses `FIleCheck` https://github.com/llvm/llvm-project/p

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-08 Thread via cfe-commits
https://github.com/sivadeilra edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-08 Thread via cfe-commits
https://github.com/jofrn edited https://github.com/llvm/llvm-project/pull/123609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2017831 - [clang][Unit Test] Updating Negative Stat Caching Diagnostic Unit Test (#138955)

2025-05-08 Thread via cfe-commits
Author: Qiongsi Wu Date: 2025-05-08T08:49:11-07:00 New Revision: 2017831d449774e792692aac88721e409ba475e4 URL: https://github.com/llvm/llvm-project/commit/2017831d449774e792692aac88721e409ba475e4 DIFF: https://github.com/llvm/llvm-project/commit/2017831d449774e792692aac88721e409ba475e4.diff LO

[clang] [llvm] [clang] Support ASan on WASI (PR #139014)

2025-05-08 Thread Derek Schuff via cfe-commits
dschuff wrote: This looks good to me, @sbc100 and @sunfishcode might also be interested (presumably the sanitizer runtime will end up alongside wasi-libc in the wasi SDK?) https://github.com/llvm/llvm-project/pull/139014 ___ cfe-commits mailing list

[clang] Fixed issue #128882: don't warn if 1st argument to 'getcwd' is NULL (PR #135720)

2025-05-08 Thread Balázs Kéri via cfe-commits
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) { clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}} clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}} if (errno) {} // no warning - } else if (Path == NULL) {

[clang] [Clang] Detect bit copies that should be relocation. (PR #139104)

2025-05-08 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/139104 We already warn when memcpy/memmove involves a non-trivially-copyable type. Although we only warn when the target (not the source) is not trivially copyable. As we moved to deprecate the old is __is_trivially

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-08 Thread via cfe-commits
@@ -176,6 +176,21 @@ class CallerSym : public SymbolRecord { uint32_t RecordOffset = 0; }; +class HotPatchFuncSym : public SymbolRecord { sivadeilra wrote: Our hot-patch tools read PDBs and then generate metadata that is placed into the final DLL/SYS/EXE,

[clang] [ItaniumMangle] Make sure class types are added to the dictionary of substitution candidates when compiling for older ABIs (PR #138947)

2025-05-08 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: > Given that the mangleCXXRecordDecl function is used outside of the > `MangleVTable` , I think the ABI compatibility logic should be moved to > mangleCXXCtorVTable Could you elaborate on how to separate just the ABI compatibility logic from `mangleCXXRecordDecl`? Wouldn't yo

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-08 Thread Daniel Paoliello via cfe-commits
@@ -0,0 +1,251 @@ +//===-- WindowsHotPatch.cpp - Support for Windows hotpatching -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Update CSymbolMap (PR #139107)

2025-05-08 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis created https://github.com/llvm/llvm-project/pull/139107 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,

[clang] 3bc3b1c - [HLSL][NFC] Rename isImplicit() to hasRegisterStot() on HLSLResourceBindingAttr (#138964)

2025-05-08 Thread via cfe-commits
Author: Helena Kotas Date: 2025-05-08T10:03:21-07:00 New Revision: 3bc3b1c6c0f35bf223c595f8426f6726d64553e7 URL: https://github.com/llvm/llvm-project/commit/3bc3b1c6c0f35bf223c595f8426f6726d64553e7 DIFF: https://github.com/llvm/llvm-project/commit/3bc3b1c6c0f35bf223c595f8426f6726d64553e7.diff

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-08 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/138708 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[clang] [llvm] [aarch64][x86][win] Add compiler support for MSVC's /funcoverride flag (Windows kernel loader replaceable functions) (PR #125320)

2025-05-08 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/125320 >From 0fc8343ec561c5b64957008c40800e8335451b9d Mon Sep 17 00:00:00 2001 From: "Daniel Paoliello (HE/HIM)" Date: Fri, 31 Jan 2025 16:47:23 -0800 Subject: [PATCH] [aarch64][x86][win] Add support for MSVC's /fun

[clang] [HLSL][NFC] Rename isImplicit() to hasRegisterStot() on HLSLResourceBindingAttr (PR #138964)

2025-05-08 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/138964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0beb2f5 - [HLSL][NFC] Stricter Overload Tests (clamp,max,min,pow) (#138993)

2025-05-08 Thread via cfe-commits
Author: Ashley Coleman Date: 2025-05-08T11:20:17-06:00 New Revision: 0beb2f56f6f6eb5aab142334a47228cbbc86c22f URL: https://github.com/llvm/llvm-project/commit/0beb2f56f6f6eb5aab142334a47228cbbc86c22f DIFF: https://github.com/llvm/llvm-project/commit/0beb2f56f6f6eb5aab142334a47228cbbc86c22f.diff

[clang] [HLSL][NFC] Stricter Overload Tests (clamp, max, min, pow) (PR #138993)

2025-05-08 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt closed https://github.com/llvm/llvm-project/pull/138993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][NFC] Stricter Overload Tests (clamp, max, min, pow) (PR #138993)

2025-05-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/138993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 09c80e2 - Reland [Clang] Deprecate `__is_trivially_relocatable` (#139061)

2025-05-08 Thread via cfe-commits
Author: cor3ntin Date: 2025-05-08T19:25:50+02:00 New Revision: 09c80e2944967332c4d889ef19a001ebb4521782 URL: https://github.com/llvm/llvm-project/commit/09c80e2944967332c4d889ef19a001ebb4521782 DIFF: https://github.com/llvm/llvm-project/commit/09c80e2944967332c4d889ef19a001ebb4521782.diff LOG:

[clang] [HIP] fix bundle ID for amdgcnspirv (PR #139112)

2025-05-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/139112 Currently ROCm 6.4.0 only recognize spirv64-amd-amdhsa- in bundle ID. spirv64-amd-amdhsa-unknown causes all HIP apps compiled for amdgcnspirv to fail. Previously we fixed a similar issue for amdgcn-amd-amdhsa-

[clang] [HIP] fix bundle ID for amdgcnspirv (PR #139112)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Currently ROCm 6.4.0 only recognize spirv64-amd-amdhsa- in bundle ID. spirv64-amd-amdhsa-unknown causes all HIP apps compiled for amdgcnspirv to fail. Previously we fixed a similar issue for amdgcn-amd-a

[clang] [HIP] fix bundle ID for amdgcnspirv (PR #139112)

2025-05-08 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j approved this pull request. Good catch, lgtm https://github.com/llvm/llvm-project/pull/139112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows hot-patching (PR #138972)

2025-05-08 Thread via cfe-commits
@@ -0,0 +1,20 @@ +// This verifies that hotpatch function attributes are correctly propagated when compiling directly to OBJ. +// +// RUN: %clang_cl -c --target=x86_64-windows-msvc -O2 /Z7 -fms-hotpatch-functions-file=%S/ms-hotpatch-functions.txt /Fo%t.obj %s si

[clang] [clang] Remove "unknown" from availability diags (PR #138610)

2025-05-08 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida edited https://github.com/llvm/llvm-project/pull/138610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RFC] Do not eat SFINAE diagnostics for explicit template arguments (PR #139066)

2025-05-08 Thread Younan Zhang via cfe-commits
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, diag::note_ovl_candidate_explicit_arg_mismatch_unnamed) << (index + 1); } + +if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost

[clang] [llvm] [AARCH64] Add support for Cortex-A320 (PR #139055)

2025-05-08 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/139055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Allow not forcing validation of user headers (PR #139091)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes Force-validation of user headers was implemented in acb803e8 to deal with files changing during build. The dependency scanner guarantees an immutable file system during single build session, so the valid

[clang] [clang][modules] Allow not forcing validation of user headers (PR #139091)

2025-05-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/139091 Force-validation of user headers was implemented in acb803e8 to deal with files changing during build. The dependency scanner guarantees an immutable file system during single build session, so the validat

[clang] [clang][modules] Allow not forcing validation of user headers (PR #139091)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Jan Svoboda (jansvoboda11) Changes Force-validation of user headers was implemented in acb803e8 to deal with files changing during build. The dependency scanner guarantees an immutable file system during single build session, so t

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-05-08 Thread Ana Pazos via cfe-commits
apazos wrote: This matter was addressed at the RVI Toolchain SIG meeting on 05/08/25. It was concluded that the duplication of implied extensions, such as in the cases of G and Zifencei, and F and Zicsr, can be silently disregarded. Both GCC and LLVM toolchains are consistent with this approac

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/138519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RFC] Do not eat SFINAE diagnostics for explicit template arguments (PR #139066)

2025-05-08 Thread Vlad Serebrennikov via cfe-commits
@@ -985,7 +985,9 @@ namespace cwg354 { // cwg354: 3.1 c++11 int b1 = both<(int*)0>(); // cxx98-error@-1 {{no matching function for call to 'both'}} // cxx98-note@#cwg354-both-int-ptr {{candidate template ignored: invalid explicitly-specified argument for 1st template p

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-05-08 Thread Erich Keane via cfe-commits
@@ -1538,11 +1533,44 @@ def CUDAShared : InheritableAttr { } def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>; -def SYCLKernel : InheritableAttr { - let Spellings = [Clang<"sycl_kernel">]; - let Subjects = SubjectList<[FunctionTmpl]>; - let LangOpts = [SYCLDev

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-05-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-05-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I honestly really like the approach. Those attributes really only differ by spelling and are almost semantically identical, so it makes a lot of sense to do it this way. So I'm happy. The accessors could be cleaned up, otherwise this is a LGTM. https

[clang] [clang-tools-extra] [libcxx] [llvm] [www][docs] Remove last mentions of IRC (PR #139076)

2025-05-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/139076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [www][docs] Remove last mentions of IRC (PR #139076)

2025-05-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/139076 It's the end of an era. The IRC channel was previously where the community gathered to discuss technical topics but is now a ghost town where the primary activity is moderators (me) kickbanning the same in

[clang] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-08 Thread CHANDRA GHALE via cfe-commits
@@ -4899,6 +4899,234 @@ void CGOpenMPRuntime::emitSingleReductionCombiner(CodeGenFunction &CGF, } } +void CGOpenMPRuntime::emitPrivateReduction( +CodeGenFunction &CGF, SourceLocation Loc, ArrayRef Privates, +ArrayRef LHSExprs, ArrayRef RHSExprs, +ArrayRef Reduct

[clang] [Clang][RFC] Do not eat SFINAE diagnostics for explicit template arguments (PR #139066)

2025-05-08 Thread Erich Keane via cfe-commits
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, diag::note_ovl_candidate_explicit_arg_mismatch_unnamed) << (index + 1); } + +if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost

[clang] [clang-installapi] Store dylib attributes in the order they are passed on the command line. (PR #139087)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes With the introduction of tbd-v5 holding rpaths, the order in which attributes are passed to `clang-installapi` must be represented in tbd files. Previously, all of these attributes were stored in a non-d

[clang] [clang-installapi] Store dylib attributes in the order they are passed on the command line. (PR #139087)

2025-05-08 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida edited https://github.com/llvm/llvm-project/pull/139087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 64bb60a - [Modules] Don't fail when an unused textual header is missing. (#138227)

2025-05-08 Thread via cfe-commits
Author: Volodymyr Sapsai Date: 2025-05-08T09:07:33-07:00 New Revision: 64bb60a471a5ddc9c9bec413c65fdab730a1e4b0 URL: https://github.com/llvm/llvm-project/commit/64bb60a471a5ddc9c9bec413c65fdab730a1e4b0 DIFF: https://github.com/llvm/llvm-project/commit/64bb60a471a5ddc9c9bec413c65fdab730a1e4b0.di

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-08 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/138227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] refactor(libclang): add CXS_StringRef (PR #139093)

2025-05-08 Thread via cfe-commits
https://github.com/illusory0x0 updated https://github.com/llvm/llvm-project/pull/139093 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sa

[clang] [Clang][RFC] Do not eat SFINAE diagnostics for explicit template arguments (PR #139066)

2025-05-08 Thread Matheus Izvekov via cfe-commits
@@ -12166,6 +12174,15 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, diag::note_ovl_candidate_explicit_arg_mismatch_unnamed) << (index + 1); } + +if (PartialDiagnosticAt *PDiag = DeductionFailure.getSFINAEDiagnost

[clang] [clang] UEFI default ABI (PR #138364)

2025-05-08 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk closed https://github.com/llvm/llvm-project/pull/138364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Detect bit copies that should be relocation. (PR #139104)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes We already warn when memcpy/memmove involves a non-trivially-copyable type. Although we only warn when the target (not the source) is not trivially copyable. As we moved to deprecate the old is __is_trivially_

[clang] [clang] Remove "unknown" from availability diags (PR #138610)

2025-05-08 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/138610 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sa

[clang] [clang] Remove "unknown" from availability diags (PR #138610)

2025-05-08 Thread Cyndy Ishida via cfe-commits
@@ -709,7 +711,7 @@ static AvailabilityResult CheckAvailability(ASTContext &Context, << EnvName << HintMessage; cyndyishida wrote: no 😅 https://github.com/llvm/llvm-project/pull/138610 ___ cfe-commits ma

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-08 Thread Matheus Izvekov via cfe-commits
@@ -4174,6 +4174,14 @@ PackIndexingType::computeDependence(QualType Pattern, Expr *IndexExpr, return TD; } +void PackIndexingType::Profile(llvm::FoldingSetNodeID &ID, + const ASTContext &Context) { + if (hasSelectedType() && isFullySubstituted

[clang] [Coverage] Support -fprofile-list for cold function coverage (PR #136333)

2025-05-08 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm closed https://github.com/llvm/llvm-project/pull/136333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][NFC] Stricter Overload Tests (clamp, max, min, pow) (PR #138993)

2025-05-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic approved this pull request. https://github.com/llvm/llvm-project/pull/138993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] No long crash on an invalid sizes argument (PR #139118)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We were trying to get type information out of an expression node which contained errors. That causes the type of the expression to be dependent, which the code was not expecting. Now we handle error co

[clang] b836f96 - [Coverage] Support -fprofile-list for cold function coverage (#136333)

2025-05-08 Thread via cfe-commits
Author: Lei Wang Date: 2025-05-08T10:51:38-07:00 New Revision: b836f96b8f51daa76f6387de364603db0fe553a7 URL: https://github.com/llvm/llvm-project/commit/b836f96b8f51daa76f6387de364603db0fe553a7 DIFF: https://github.com/llvm/llvm-project/commit/b836f96b8f51daa76f6387de364603db0fe553a7.diff LOG:

[clang] [HLSL][NFC] Stricter Overload Tests (clamp, max, min, pow) (PR #138993)

2025-05-08 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/21941 Here is the relevant piece of the build lo

[clang] [OpenACC][CIR] Implement basic lowering for combined constructs (PR #139119)

2025-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Erich Keane (erichkeane) Changes Combined constructs are emitted a little oddly, in that they are the only one where there are two operations for a single construct. First, the compute variant is emitted with 'combined(loop)', then the

[clang] [OpenACC][CIR] Implement basic lowering for combined constructs (PR #139119)

2025-05-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/139119 Combined constructs are emitted a little oddly, in that they are the only one where there are two operations for a single construct. First, the compute variant is emitted with 'combined(loop)', then the loop

[clang] [Coverage] Support -fprofile-list for cold function coverage (PR #136333)

2025-05-08 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg approved this pull request. https://github.com/llvm/llvm-project/pull/136333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-05-08 Thread Alex Voicu via cfe-commits
AlexVlx wrote: @erichkeane @AaronBallman if, when you have time, you could please indicate if the new direction is at least generally aligned with what you had in mind, it'd be appreciated! https://github.com/llvm/llvm-project/pull/134016 ___ cfe-com

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-08 Thread via cfe-commits
@@ -19,7 +19,9 @@ // equal(Iter1 first1, Iter1 last1, Iter2 first2, Iter2 last2); // We test the cartesian product, so we sometimes compare differently signed types -// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-sign-compare -Wno-implicit-unicode-conversion +// ADD

[clang] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-08 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Can you add a few runtime tests, some with UDR with classes, several reduction items with the different types, to check that functional part works correctly? You can add it to the libomp right in this patch. Just want to be sure we do not miss anything here https://github

[clang] [OpenACC][CIR] Implement basic lowering for combined constructs (PR #139119)

2025-05-08 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/139119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement basic lowering for combined constructs (PR #139119)

2025-05-08 Thread Razvan Lupusoru via cfe-commits
razvanlupusoru wrote: > in that they are the only one where there are two operations for a single > construct. https://mlir.llvm.org/docs/Dialects/OpenACCDialect/#operation-categories There are other categories where a single construct leads to multiple operations. See description at the link

[clang] [CIR] LLVMIR lowering for cir.call (PR #138873)

2025-05-08 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. Pretty straightforward, LGTM https://github.com/llvm/llvm-project/pull/138873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [mlir] [OpenACC][CIR] Implement 'gang' lowering for 'loop' (PR #138968)

2025-05-08 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LG(ang)TM, some minor suggestion https://github.com/llvm/llvm-project/pull/138968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [mlir] [OpenACC][CIR] Implement 'gang' lowering for 'loop' (PR #138968)

2025-05-08 Thread Bruno Cardoso Lopes via cfe-commits
@@ -424,6 +436,42 @@ class OpenACCClauseCIREmitter final return clauseNotImplemented(clause); } } + + void VisitGangClause(const OpenACCGangClause &clause) { +if constexpr (isOneOfTypes) { + if (clause.getNumExprs() == 0) { +operation.addEmptyGang(

[clang] [mlir] [OpenACC][CIR] Implement 'gang' lowering for 'loop' (PR #138968)

2025-05-08 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/138968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix missing initializer for inline static template member with auto caused by delayed template instantiation. (PR #138122)

2025-05-08 Thread via cfe-commits
https://github.com/dty2 updated https://github.com/llvm/llvm-project/pull/138122 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-serif

[clang] [llvm] [win][x64] Unwind v2 3/n: Add support for emitting unwind v2 information (equivalent to MSVC /d2epilogunwind) (PR #129142)

2025-05-08 Thread Daniel Paoliello via cfe-commits
@@ -7788,6 +7788,10 @@ def import_call_optimization : Flag<["-"], "import-call-optimization">, "by the Windows kernel to enable import call optimization">, MarshallingInfoFlag>; +def epilog_unwind : Flag<["-"], "winx64-eh-unwindv2">, + HelpText<"Enable unwin

<    1   2   3   4   >