[clang] Add unnecessary-virtual-specifier to -Wextra (PR #138741)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Devon Loehr (DKLoehr) Changes Effectively a reland of #133265, though due to discussion there we add the warning to -Wextra instead of turning it on by default. We still need to disable it for LLVM due to our unusual policy of using virtu

[clang] [llvm] Add unnecessary-virtual-specifier to -Wextra (PR #138741)

https://github.com/DKLoehr updated https://github.com/llvm/llvm-project/pull/138741 >From 3fa5eff5f2647185652afd3fc831fe3b11fb Mon Sep 17 00:00:00 2001 From: Devon Loehr Date: Tue, 6 May 2025 17:28:48 + Subject: [PATCH] Add unnecessary-virtual-specifier to -Wextra --- clang/docs/Relea

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

jeremyd2019 wrote: Ping @MaskRay https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add unnecessary-virtual-specifier to -Wextra (PR #138741)

DKLoehr wrote: @zmodem @AaronBallman @Sirraide -- reviewers from previous attempt @philnik777 -- do you think this PR will work with libc++? https://github.com/llvm/llvm-project/pull/138741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [Clang] diagnose unknown attribute namespaces (PR #138519)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/138519 >From 7d376b33f09801be504ec65a2853679dff8b726c Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 5 May 2025 15:30:14 +0300 Subject: [PATCH 1/3] [Clang] diagnose unknown attribute namespaces --- c

[clang] [AMDGPU] Fix gfx1201 check line in the amdgpu-features.cl. NFC. (PR #138743)

https://github.com/rampitec ready_for_review https://github.com/llvm/llvm-project/pull/138743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Fix gfx1201 check line in the amdgpu-features.cl. NFC. (PR #138743)

https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/138743 None >From 5320eff1d30772339622d5dfbde3ae29567e89eb Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 6 May 2025 12:16:24 -0700 Subject: [PATCH] [AMDGPU] Fix gfx1201 check line in the amdgpu-feat

[clang] [AMDGPU] Fix gfx1201 check line in the amdgpu-features.cl. NFC. (PR #138743)

rampitec wrote: * **#138743** https://app.graphite.dev/github/pr/llvm/llvm-project/138743?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/138

[clang] [AMDGPU] Fix gfx1201 check line in the amdgpu-features.cl. NFC. (PR #138743)

llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/138743.diff 1 Files Affected: - (modified) clang/test/CodeGenOpenCL/amdgpu-features.cl (+1-1) ``diff diff --git a/cla

[clang] [AMDGPU] Fix gfx1201 check line in the amdgpu-features.cl. NFC. (PR #138743)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Stanislav Mekhanoshin (rampitec) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/138743.diff 1 Files Affected: - (modified) clang/test/CodeGenOpenCL/amdgpu-features.cl (+1-1) ``diff diff --git a/clang/test/C

[clang] [llvm] Add unnecessary-virtual-specifier to -Wextra (PR #138741)

philnik777 wrote: This should probably work. To make sure you can make a simple change in the `libcxx/` subdirectory to trigger the libc++ pre-commit CI (which should of course be removed again before actually committing). https://github.com/llvm/llvm-project/pull/138741 __

[clang-tools-extra] [Clang-Tidy][NFC] Simplify check cppcoreguidelines-missing-std-forward (PR #138504)

https://github.com/carlosgalvezp approved this pull request. https://github.com/llvm/llvm-project/pull/138504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

AmrDeveloper wrote: > Overall looks good. While here, can you please implement a folder for this > operation? It should kick-in if both idx and input vector are constants. @bcardosolopes I implement it like this snippet ``` OpFoldResult cir::VecExtractOp::fold(FoldAdaptor adaptor) { const au

[clang] [mlir] [OpenACC] Implement tile/collapse lowering (PR #138576)

https://github.com/clementval approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Regroup declarations in `Parser` (PR #138511)

AaronBallman wrote: CC @llvm/clang-vendors https://github.com/llvm/llvm-project/pull/138511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

@@ -4911,8 +4911,8 @@ std::optional Type::getNullability() const { bool Type::canHaveNullability(bool ResultIfUnknown) const { QualType type = getCanonicalTypeInternal(); + // We'll only see canonical types here. efriedma-quic wrote: Actually, maybe move

[clang] [sanitizer] Add plumbing for -fsanitize-annotate-debug-info and partly replace '-mllvm -array-bounds-pseudofn' (PR #138577)

@@ -1228,7 +1228,10 @@ void CodeGenFunction::EmitBoundsCheckImpl(const Expr *E, llvm::Value *Bound, SanitizerScope SanScope(this); llvm::DILocation *CheckDI = Builder.getCurrentDebugLocation(); - if (ClArrayBoundsPseudoFn && CheckDI) { + if ((ClArrayBoundsPseudoFn || --

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

ArtSin wrote: Ping https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Add plumbing for -fsanitize-annotate-debug-info and partly replace '-mllvm -array-bounds-pseudofn' (PR #138577)

https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/138577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/138342 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

@@ -4911,8 +4911,8 @@ std::optional Type::getNullability() const { bool Type::canHaveNullability(bool ResultIfUnknown) const { QualType type = getCanonicalTypeInternal(); + // We'll only see canonical types here. sarnex wrote: done in latest commit, thank

[clang] [AMDGPU] Change -cl-std to CL2.0 in builtins-amdgcn-gfx950.cl. NFC. (PR #138745)

rampitec wrote: > > > Why? This just adds more intermediate IR and makes the output bigger. If > > > anything we should switch any tests unnecessarily using CL2.0 to use CL1.2 > > > > > > It is like that everywhere, and that eliminates huge delta to downstream > > branch. > > Fix the downstr

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

@@ -365,10 +365,15 @@ mlir::Attribute ConstantEmitter::tryEmitPrivateForVarInit(const VarDecl &d) { if (!d.hasLocalStorage()) { QualType ty = cgm.getASTContext().getBaseElementType(d.getType()); if (ty->isRecordType()) - if (d.getInit() && isa(d.getInit())) { -

[clang] 25af0ae - [clang][Index] Add comment about out-of-line defaulted destructor (#138640)

Author: Nathan Ridge Date: 2025-05-06T16:48:04-04:00 New Revision: 25af0ae8efa90610af114dfe0eea8f7f14462cc2 URL: https://github.com/llvm/llvm-project/commit/25af0ae8efa90610af114dfe0eea8f7f14462cc2 DIFF: https://github.com/llvm/llvm-project/commit/25af0ae8efa90610af114dfe0eea8f7f14462cc2.diff

[clang] [clang][Index] Add comment about out-of-line defaulted destructor (PR #138640)

https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/138640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/132510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a63fd59 - [clang-doc] Add regression test for test comments in macros (#132510)

Author: ZhongUncle Date: 2025-05-06T16:00:02-07:00 New Revision: a63fd59d95397d236b03e964287728a35efa296b URL: https://github.com/llvm/llvm-project/commit/a63fd59d95397d236b03e964287728a35efa296b DIFF: https://github.com/llvm/llvm-project/commit/a63fd59d95397d236b03e964287728a35efa296b.diff LO

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/132510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CMake] use CMakePushCheckState (PR #138783)

https://github.com/jeremyd2019 created https://github.com/llvm/llvm-project/pull/138783 The previous approach of using list(REMOVE ...) would remove *all* occurences of the given item, not just the one appended above. Rate limit · GitHub body { b

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

@@ -0,0 +1,109 @@ +//===--- Cygwin.cpp - Cygwin ToolChain Implementations --*- C++ -*-===// MaskRay wrote: In new code, can remove the comments per the updated https://llvm.org/docs/CodingStandards.html#file-headers https://github.com/llvm/llvm-project

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

https://github.com/MaskRay commented: LGTM. But I hope folks more familiar with Windows can take a look. Can you describe the support triples in the description and state why we need the msys ones? (Wow, MSYS and Cygwin... familiar names! I used them back in 2009, but then I made the switch to

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

@@ -2632,6 +2632,27 @@ void Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes( return; } + if (TargetTriple.isWindowsCygwinEnvironment()) { +static const char *const CygwinX86Triples[] = {"i686-pc-cygwin", +

[clang] cf9b4d1 - [Clang] Diagnose invalid function types in dependent contexts (#138731)

Author: cor3ntin Date: 2025-05-06T22:51:04+02:00 New Revision: cf9b4d1e7961214deabd99a9fc3b1d4c9e78a71f URL: https://github.com/llvm/llvm-project/commit/cf9b4d1e7961214deabd99a9fc3b1d4c9e78a71f DIFF: https://github.com/llvm/llvm-project/commit/cf9b4d1e7961214deabd99a9fc3b1d4c9e78a71f.diff LOG:

[clang] [CIR] Add cir-simplify pass (PR #138317)

mmha wrote: @bcardosolopes Adding a test for C++ -> CIR depends on #138003 which adds lowering for `?:`, `&&` and `||`. Since this one's ready to be merged apart from your remark IMO I'd add that test in #138003 https://github.com/llvm/llvm-project/pull/138317 _

[clang] [Clang] Diagnose invalid function types in dependent contexts (PR #138731)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/138731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/138413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

https://github.com/andykaylor approved this pull request. Looks good to me, with a small request. https://github.com/llvm/llvm-project/pull/138413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

@@ -96,3 +96,36 @@ void foo2(vi4 p) {} // OGCG: %[[VEC_A:.*]] = alloca <4 x i32>, align 16 // OGCG: store <4 x i32> %{{.*}}, ptr %[[VEC_A]], align 16 + +void foo3() { + vi4 a = { 1, 2, 3, 4 }; + int e = a[1]; +} andykaylor wrote: Can you add a test where th

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

github-actions[bot] wrote: @ZhongUncle Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] [StaticAnalyzer] Make it a noop when initializing a field of empty record (PR #138594)

https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/138594 >From 4e6f2ce82744322a35614532732281eacb2fe79a Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Mon, 5 May 2025 14:27:48 -0700 Subject: [PATCH 1/2] [StaticAnalyzer] Make it a noop when initializing a field

[clang] [llvm] [HIP][HIPSTDPAR] Re-work allocation interposition for `hipstdpar` (PR #138790)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/138790 The allocation interposition mode had a number of issues, which are primarily addressed in the library component via . However, it is necessary to interpose some add

[clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/137580 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/135836 >From d90d4a95a3205e8eda1ce1bd28e97e2950580b44 Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Wed, 9 Apr 2025 14:21:00 -0700 Subject: [PATCH] [clang] Function type attribute to prevent CFI instrumentation

[clang] [llvm] [HIP][HIPSTDPAR] Re-work allocation interposition for `hipstdpar` (PR #138790)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-transforms Author: Alex Voicu (AlexVlx) Changes The allocation interposition mode had a number of issues, which are primarily addressed in the library component via ;. However,

[clang] [llvm] [HIP][HIPSTDPAR] Re-work allocation interposition for `hipstdpar` (PR #138790)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp -- clang/lib/Frontend/InitPreprocessor.cpp clang/test

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h,c -- clang/test/CodeGen/cfi-unchecked-callee-attribute

[clang] [llvm] [HIP][HIPSTDPAR] Re-work allocation interposition for `hipstdpar` (PR #138790)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/138790 >From 865ff3dff1833607f0d546ab0ebd95b98a8ed71b Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Wed, 7 May 2025 01:25:17 +0100 Subject: [PATCH 1/2] Re-work allocation interposition for `hipstdpar`. --- clang/do

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

PiJoules wrote: Ok rather than making the attr its own AST node, I found it much simpler to make it part of the function type. Rather than adding it to `FunctionTypeExtraBitfields` I instead added it to `ExtInfo`. I did since it looks like if I wanted to add a bit to `FunctionTypeExtraBitfield

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #131838)

@@ -4529,6 +4529,191 @@ void CodeGenFunction::EmitOMPMasterDirective(const OMPMasterDirective &S) { emitMaster(*this, S); } +static Expr *replaceWithNewTraitsOrDirectCall(CapturedDecl *CDecl, + Expr *NewExpr) { + Expr *CurrentCa

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

ilovepi wrote: ### Merge activity * **May 6, 11:12 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138058). https://github.com/llvm/llvm-project/pull/138058

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138058 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Add Mustache template assets (PR #138059)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138059 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 796652d - [clang-doc] Track Descriptions and TypeDeclaration for types (#138058)

Author: Paul Kirth Date: 2025-05-06T20:16:17-07:00 New Revision: 796652dfc198c228b0d917be05ae69073e6c540c URL: https://github.com/llvm/llvm-project/commit/796652dfc198c228b0d917be05ae69073e6c540c DIFF: https://github.com/llvm/llvm-project/commit/796652dfc198c228b0d917be05ae69073e6c540c.diff LO

[clang-tools-extra] [clang-tools-extra] Remove redundant calls to std::unique_ptr::get (NFC) (PR #138774)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/138774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Mustache template assets (PR #138059)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1897023 - [AMDGPU] Fix gfx1201 check line in the amdgpu-features.cl. NFC. (#138743)

Author: Stanislav Mekhanoshin Date: 2025-05-06T17:05:44-07:00 New Revision: 189702326a3a4c9072e346a8197913a4d968cbe3 URL: https://github.com/llvm/llvm-project/commit/189702326a3a4c9072e346a8197913a4d968cbe3 DIFF: https://github.com/llvm/llvm-project/commit/189702326a3a4c9072e346a8197913a4d968cb

[clang] [AMDGPU] Fix gfx1201 check line in the amdgpu-features.cl. NFC. (PR #138743)

https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/138743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Handle invalid variable template specialization whose type depends on itself (PR #134522)

https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/134522 >From ccab3dc1f18ffeda9acb07c0bd5f80f65cc788b9 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Sun, 6 Apr 2025 15:06:56 +0800 Subject: [PATCH 1/4] Handle invalid variable template specialization whose type depend

[clang] [Clang][Sema] Handle invalid variable template specialization whose type depends on itself (PR #134522)

zwuis wrote: Yes. Please help me merge this PR. Thank you for your review! https://github.com/llvm/llvm-project/pull/134522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

cassiebeckley wrote: Done. https://github.com/llvm/llvm-project/pull/134034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Enable pointer overflow check for GCC workaround (PR #137849)

@@ -4169,10 +4169,10 @@ static Value *emitPointerArithmetic(CodeGenFunction &CGF, // The index is not pointer-sized. // The pointer type is not byte-sized. // - if (BinaryOperator::isNullPointerArithmeticExtension(CGF.getContext(), -

[clang] [Clang][CodeGen] Add workaround for old glibc `__PTR_ALIGN` macro (PR #137851)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/137851 >From 5b3a9ed3ed2f258a178e0c17891e2d9ae4f21446 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 6 May 2025 17:47:07 +0800 Subject: [PATCH 1/4] [Clang][CodeGen] Enable pointer overflow check for GCC worka

[clang] 2d81994 - [NFC] Add test from issue 61125

Author: Chuanqi Xu Date: 2025-05-07T14:47:24+08:00 New Revision: 2d81994c4a41b950eed9bdee189cba9d00381b58 URL: https://github.com/llvm/llvm-project/commit/2d81994c4a41b950eed9bdee189cba9d00381b58 DIFF: https://github.com/llvm/llvm-project/commit/2d81994c4a41b950eed9bdee189cba9d00381b58.diff LO

[clang] [llvm] [sancov] Introduce optional callback for stack-depth tracking (PR #138323)

@@ -158,6 +158,7 @@ struct SanitizerCoverageOptions { bool PCTable = false; bool NoPrune = false; bool StackDepth = false; + int StackDepthCallbackMin = 0; kees wrote: Yeah, I wasn't sure if I should keep it with the other StackDepth var. I've moved it

[clang] [sanitizer] Add plumbing for -fsanitize-annotate-debug-info and partly replace '-mllvm -array-bounds-pseudofn' (PR #138577)

thurstond wrote: > Seems like the fsanitize test is failing now Fixed https://github.com/llvm/llvm-project/pull/138577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [sancov] Introduce optional callback for stack-depth tracking (PR #138323)

@@ -1078,22 +1091,65 @@ void ModuleSanitizerCoverage::InjectCoverageAtBlock(Function &F, BasicBlock &BB, Store->setNoSanitizeMetadata(); } if (Options.StackDepth && IsEntryBB && !IsLeafFunc) { -// Check stack depth. If it's the deepest so far, record it. Modu

[clang] [clang-format] Correctly annotate ObjC `* __autoreleasing *` (PR #138799)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/138799 Fix #138484 >From ec9f832cedf7abd4d90d8cf3dca45ee128b922a9 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 6 May 2025 20:13:26 -0700 Subject: [PATCH] [clang-format] Correctly annotate ObjC `* __autoreleasing

[clang] [clang-format] Correctly annotate ObjC `* __autoreleasing *` (PR #138799)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #138484 --- Full diff: https://github.com/llvm/llvm-project/pull/138799.diff 3 Files Affected: - (modified) clang/lib/Format/FormatToken.h (+8) - (modified) clang/lib/Format/TokenAnnotator.cpp (+2-1

[clang-tools-extra] 5d305b6 - [clang-tools-extra] Remove redundant calls to std::unique_ptr::get (NFC) (#138774)

Author: Kazu Hirata Date: 2025-05-06T20:16:54-07:00 New Revision: 5d305b618f3f58a7bbe8340ba88228591d07 URL: https://github.com/llvm/llvm-project/commit/5d305b618f3f58a7bbe8340ba88228591d07 DIFF: https://github.com/llvm/llvm-project/commit/5d305b618f3f58a7bbe8340ba88228591d07.diff L

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

@@ -0,0 +1,109 @@ +//===--- Cygwin.cpp - Cygwin ToolChain Implementations --*- C++ -*-===// jeremyd2019 wrote: Like so? https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing list cfe-commits

[clang] [sanitizer] Add plumbing for -fsanitize-annotate-debug-info and partly replace '-mllvm -array-bounds-pseudofn' (PR #138577)

@@ -1228,7 +1228,10 @@ void CodeGenFunction::EmitBoundsCheckImpl(const Expr *E, llvm::Value *Bound, SanitizerScope SanScope(this); llvm::DILocation *CheckDI = Builder.getCurrentDebugLocation(); - if (ClArrayBoundsPseudoFn && CheckDI) { + if ((ClArrayBoundsPseudoFn || --

[clang] [Clang] Ignore -fchar8_t in C (PR #138716)

@@ -317,6 +317,8 @@ Modified Compiler Flags - The ``-mexecute-only`` and ``-mpure-code`` flags are now accepted for AArch64 targets. (#GH125688) +- The ``-fchar8_t`` flag is no longer consider in non-C++ languages modes. (#GH55373) AaronBallman wrote: ```s

[clang] [Clang] Ignore -fchar8_t in C (PR #138716)

cor3ntin wrote: This is part of the problem, yes. we also do not support char16_t/char32_t as keywords in C and u8 behaves differently. And of course, there is no way to use it with the standard library or... any library? Moreover we have 0 tests for C so I don't think we can claim to support

[clang] [Clang][CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS (PR #138587)

mstorsjo wrote: > If this is right, it should probably be done to other standalone-capable > projects' CMakeLists.txt also (LLD in particular, for my interests). > Actually, it seems there's nothing in LLD that requires _GNU_SOURCE on > Cygwin... Yep, indeed. I guess the main question is who

[clang] [Clang] Ignore -fchar8_t in C (PR #138716)

@@ -5,6 +5,7 @@ // RUN: %clang_cc1 -std=c++17 -verify %s // RUN: %clang_cc1 -std=c++17 -verify %s -fno-char8_t // RUN: %clang_cc1 -std=c++20 -verify %s -fno-char8_t +// RUN: %clang_cc1 -x c -verify %s -fchar8_t cor3ntin wrote: `ShouldParseIf` seems never to di

[clang] [Clang][CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS (PR #138587)

jeremyd2019 wrote: > I agree that the second change, that is using `LLVMConfig.cmake`'s > `LLVM_DEFINITIONS`, should be applied to other projects that support > standalone builds like LLD. Is there a list somewhere or do I just rely on my grep-foo? * bolt * clang * flang * lld * lldb * mlir g

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #131838)

@@ -4529,6 +4529,191 @@ void CodeGenFunction::EmitOMPMasterDirective(const OMPMasterDirective &S) { emitMaster(*this, S); } +static Expr *replaceWithNewTraitsOrDirectCall(CapturedDecl *CDecl, + Expr *NewExpr) { + Expr *CurrentCa

[clang] [Cygwin] Export global symbols, template instantiations, RTTI and VTable are exported correctly (PR #138773)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Tomohiro Kashiwada (kikairoya) Changes MinGW-GCC and MinGW-Clang exports these symbols. Cygwin-GCC also exports them, so Cygwin-Clang should do so. Some of tests have new DAG pattern because i686-cygwin don't use __thiscall but __cdecl fo

[clang] [Cygwin] Export global symbols, template instantiations, RTTI and VTable are exported correctly (PR #138773)

https://github.com/kikairoya created https://github.com/llvm/llvm-project/pull/138773 MinGW-GCC and MinGW-Clang exports these symbols. Cygwin-GCC also exports them, so Cygwin-Clang should do so. Some of tests have new DAG pattern because i686-cygwin don't use __thiscall but __cdecl for member

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -3332,6 +3388,39 @@ checkBuiltinTemplateIdType(Sema &SemaRef, BuiltinTemplateDecl *BTD, } return HasNoTypeMember; } + + case BTK__hlsl_spirv_type: { +assert(Converted.size() == 4); + +if (!Context.getTargetInfo().getTriple().isSPIRV()) { + SemaRef.Di

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -6330,6 +6331,140 @@ class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode { findHandleTypeOnResource(const Type *RT); }; +/// Instances of this class represent operands to a SPIR-V type instruction. +class SpirvOperand { +public: + enum SpirvOpera

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -6165,6 +6254,18 @@ bool UnnamedLocalNoLinkageFinder::VisitHLSLAttributedResourceType( return Visit(T->getWrappedType()); } +bool UnnamedLocalNoLinkageFinder::VisitHLSLInlineSpirvType( +const HLSLInlineSpirvType *T) { + for (auto &Operand : T->getOperands()) { +

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -0,0 +1,28 @@ +//===- hlsl_spirv.h - HLSL definitions for SPIR-V target --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -6330,6 +6331,140 @@ class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode { findHandleTypeOnResource(const Type *RT); }; +/// Instances of this class represent operands to a SPIR-V type instruction. +class SpirvOperand { +public: + enum SpirvOpera

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -6330,6 +6331,140 @@ class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode { findHandleTypeOnResource(const Type *RT); }; +/// Instances of this class represent operands to a SPIR-V type instruction. +class SpirvOperand { +public: + enum SpirvOpera

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

https://github.com/cassiebeckley updated https://github.com/llvm/llvm-project/pull/134034 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -5444,6 +5459,31 @@ QualType ASTContext::getHLSLAttributedResourceType( return QualType(Ty, 0); } + +QualType ASTContext::getHLSLInlineSpirvType(uint32_t Opcode, uint32_t Size, +uint32_t Alignment, +

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -3228,6 +3228,62 @@ static QualType builtinCommonTypeImpl(Sema &S, TemplateName BaseTemplate, } } +static bool isInVkNamespace(const RecordType *RT) { + DeclContext *DC = RT->getDecl()->getDeclContext(); + if (!DC) +return false; + + NamespaceDecl *ND = dyn_cast(D

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -3228,6 +3228,62 @@ static QualType builtinCommonTypeImpl(Sema &S, TemplateName BaseTemplate, } } +static bool isInVkNamespace(const RecordType *RT) { + DeclContext *DC = RT->getDecl()->getDeclContext(); + if (!DC) +return false; + + NamespaceDecl *ND = dyn_cast(D

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -369,14 +369,102 @@ llvm::Type *CommonSPIRTargetCodeGenInfo::getOpenCLType(CodeGenModule &CGM, return nullptr; } +// Gets a spirv.IntegralConstant or spirv.Literal. If IntegralType is present, +// returns an IntegralConstant, otherwise returns a Literal. +static llvm::Ty

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -11763,6 +11804,22 @@ QualType ASTContext::mergeTypes(QualType LHS, QualType RHS, bool OfBlockPointer, return LHS; return {}; } + case Type::HLSLInlineSpirv: +const HLSLInlineSpirvType *LHSTy = LHS->castAs(); +const HLSLInlineSpirvType *RHSTy = RHS->cas

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -1832,6 +1832,48 @@ ExpectedType clang::ASTNodeImporter::VisitHLSLAttributedResourceType( ToWrappedType, ToContainedType, ToAttrs); } +ExpectedType clang::ASTNodeImporter::VisitHLSLInlineSpirvType( +const clang::HLSLInlineSpirvType *T) { + Error Err = Error::suc

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -369,14 +369,102 @@ llvm::Type *CommonSPIRTargetCodeGenInfo::getOpenCLType(CodeGenModule &CGM, return nullptr; } +// Gets a spirv.IntegralConstant or spirv.Literal. If IntegralType is present, +// returns an IntegralConstant, otherwise returns a Literal. +static llvm::Ty

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -877,6 +878,11 @@ bool CodeGenTypes::isZeroInitializable(QualType T) { if (const MemberPointerType *MPT = T->getAs()) return getCXXABI().isZeroInitializable(MPT); + // HLSL Inline SPIR-V types are non-zero-initializable. + if (T->getAs()) { +return false; + } -

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.0-compute %s \ +// RUN: -fsyntax-only -verify + +typedef vk::SpirvType<12, 2, 4, float> InvalidType1; // expected-error {{use of undeclared identifier 'vk'}} +vk::Li

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -0,0 +1,68 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: spirv-unknown-vulkan-compute %s -emit-llvm -disable-llvm-passes \ +// RUN: -o - | FileCheck %s + +template +using Array = vk::SpirvOpaqueType>; + +template +using ArrayBuffer = Array, Size

[clang] [HLSL] Implement `SpirvType` and `SpirvOpaqueType` (PR #134034)

@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.0-compute %s \ +// RUN: -fsyntax-only -verify + +typedef vk::SpirvType<12, 2, 4, float> InvalidType1; // expected-error {{use of undeclared identifier 'vk'}} +vk::Li

<    1   2   3   4   >