[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
@@ -269,6 +269,40 @@ mlir::Operation *CIRGenModule::getGlobalValue(StringRef name) { return mlir::SymbolTable::lookupSymbolIn(theModule, name); } +cir::GlobalOp CIRGenModule::createGlobalOp(CIRGenModule &cgm, + mlir::Location loc, S

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Amr Hesham via cfe-commits
@@ -46,6 +55,14 @@ class ConstantEmitter { ConstantEmitter(const ConstantEmitter &other) = delete; ConstantEmitter &operator=(const ConstantEmitter &other) = delete; + ~ConstantEmitter(); + + /// Try to emit the initiaizer of the given declaration as an abstract

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/137661 >From a52df39baea119a5a7b13dd8d98dd145522f6293 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Thu, 24 Apr 2025 13:30:40 -0700 Subject: [PATCH 1/2] [clang] Remove FEM_Indeterminable Remove FEM_Indeterminable as

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-02 Thread Morris Hafner via cfe-commits
@@ -417,6 +417,19 @@ mlir::Type CIRGenTypes::convertType(QualType type) { break; } + case Type::Enum: { +// TODO(cir): Implement updateCompletedType for enums. +assert(!cir.MissingFeatures::updateCompletedType()); +const EnumDecl *ED = cast(ty)->getDecl(); +

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-02 Thread Morris Hafner via cfe-commits
https://github.com/mmha approved this pull request. LGTM, just two nits https://github.com/llvm/llvm-project/pull/136807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-02 Thread Morris Hafner via cfe-commits
https://github.com/mmha edited https://github.com/llvm/llvm-project/pull/136807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-02 Thread Morris Hafner via cfe-commits
@@ -247,9 +247,35 @@ size_type max_size(void) { // CIR: %3 = cir.cast(integral, %2 : !s32i), !u64i // CIR: %4 = cir.const #cir.int<8> : !u64i // CIR: %5 = cir.binop(div, %3, %4) : !u64i +// CIR: cir.store %5, %0 : !u64i, !cir.ptr +// CIR: %6 = cir.load %0 : !cir.ptr,

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-02 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: this causes a `-Wmicrosoft-goto` warning on ``` $ cat /tmp/a.c void f() { goto l; int i = 0; l: } $ bin/clang-cl /c /tmp/a.c ... /tmp/a.c(2,2): warning: jump from this goto statement to its label is a Microsoft extension [-Wmicrosoft-goto] 2 | goto l;

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
@@ -365,46 +406,108 @@ mlir::Value CIRGenModule::getAddrOfGlobalVar(const VarDecl *d, mlir::Type ty, void CIRGenModule::emitGlobalVarDefinition(const clang::VarDecl *vd, bool isTentative) { const QualType astTy = vd->getType(); - c

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
@@ -118,7 +210,26 @@ class ConstExprEmitter } mlir::Attribute VisitInitListExpr(InitListExpr *ile, QualType t) { -cgm.errorNYI(ile->getBeginLoc(), "ConstExprEmitter::VisitInitListExpr"); +if (ile->isTransparent()) + return Visit(ile->getInit(0), t); + +if

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
@@ -31,6 +31,15 @@ class ConstantEmitter { private: bool abstract = false; + /// Whether non-abstract components of the emitter have been initialized. + bool initializedNonAbstract = false; andykaylor wrote: Yes, these are just for debugging. Wrapping the

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @ojhunt I think there a more than one revert. Can you please read from https://github.com/llvm/llvm-project/issues/137600#issuecomment-2842037532 to see all the reverts that need to be done. Thanks. https://github.com/llvm/llvm-project/pull/137661 __

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
@@ -90,8 +90,100 @@ class ConstExprEmitter } mlir::Attribute VisitCastExpr(CastExpr *e, QualType destType) { -cgm.errorNYI(e->getBeginLoc(), "ConstExprEmitter::VisitCastExpr"); -return {}; +if (const auto *ece = dyn_cast(e)) + cgm.errorNYI(e->getBeginLoc()

[clang] 4fcbdb2 - [CIR] Upstream local initialization for VectorType (#138107)

2025-05-02 Thread via cfe-commits
Author: Amr Hesham Date: 2025-05-02T22:12:03+02:00 New Revision: 4fcbdb2c89a5f7a95e844ea8ff62893447938cd1 URL: https://github.com/llvm/llvm-project/commit/4fcbdb2c89a5f7a95e844ea8ff62893447938cd1 DIFF: https://github.com/llvm/llvm-project/commit/4fcbdb2c89a5f7a95e844ea8ff62893447938cd1.diff LO

[clang] [CIR] Upstream local initialization for VectorType (PR #138107)

2025-05-02 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/138107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread Arthur Eubanks via cfe-commits
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) +if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR + ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread via cfe-commits
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) +if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR + ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
@@ -365,46 +406,108 @@ mlir::Value CIRGenModule::getAddrOfGlobalVar(const VarDecl *d, mlir::Type ty, void CIRGenModule::emitGlobalVarDefinition(const clang::VarDecl *vd, bool isTentative) { const QualType astTy = vd->getType(); - c

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Oliver Hunt via cfe-commits
ojhunt wrote: Two of the fixes were to code that was removed while resolving the merge conflict on the LANG_OPT declaration, I thought with the revert of c2a62af I got all the changes but I'll recheck https://github.com/llvm/llvm-project/pull/137661

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/138119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread via cfe-commits
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) +if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR + ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Two of the fixes were to code that was removed while resolving the merge > conflict on the LANG_OPT declaration, I thought with the revert of > [c2a62af](https://github.com/llvm/llvm-project/commit/c2a62af2a51d58183bcd72ee8a86c37ddd526758) > I got all the changes but I'll rec

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-02 Thread Krzysztof Drewniak via cfe-commits
@@ -2641,6 +2641,28 @@ def int_amdgcn_perm : // GFX9 Intrinsics //===--===// +/// This is a general-purpose intrinsic for all operations that take a pointer +/// a base location in LDS, and a data size and us

[clang] [llvm] [mlir] [ErrorHandling] Add reportFatalInternalError + reportFatalUsageError (NFC) (PR #138251)

2025-05-02 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/138251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [ErrorHandling] Add reportFatalInternalError + reportFatalUsageError (NFC) (PR #138251)

2025-05-02 Thread Mehdi Amini via cfe-commits
@@ -59,22 +59,42 @@ namespace llvm { ~ScopedFatalErrorHandler() { remove_fatal_error_handler(); } }; -/// Reports a serious error, calling any installed error handler. These -/// functions are intended to be used for error conditions which are outside -/// the control of

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Oliver Hunt via cfe-commits
ojhunt wrote: Just waiting on a build (force push was due to me hopelessly screwing up my tree) https://github.com/llvm/llvm-project/pull/137661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [mlir] [ErrorHandling] Add reportFatalInternalError + reportFatalUsageError (NFC) (PR #138251)

2025-05-02 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/138251 >From 114ba17da2f522c5fd5045f5030a44fe13b3af27 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 2 May 2025 12:46:48 +0200 Subject: [PATCH 1/6] [ErrorHandling] Add reportFatalInternalError + reportFatalUsage

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-02 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng updated https://github.com/llvm/llvm-project/pull/138182 >From d5187a940fc0a16325eedb0c67bcf647deb95d8f Mon Sep 17 00:00:00 2001 From: kmpeng Date: Thu, 1 May 2025 11:48:47 -0700 Subject: [PATCH 1/4] ldexp implementation and tests --- .../lib/Headers/hlsl/hlsl_intrin

[clang] 55e3910 - [clang] Remove FEM_Indeterminable (#137661)

2025-05-02 Thread via cfe-commits
Author: Oliver Hunt Date: 2025-05-02T13:05:52-07:00 New Revision: 55e39100dae2a131c7cbcdbbe628c0b82f8c12ca URL: https://github.com/llvm/llvm-project/commit/55e39100dae2a131c7cbcdbbe628c0b82f8c12ca DIFF: https://github.com/llvm/llvm-project/commit/55e39100dae2a131c7cbcdbbe628c0b82f8c12ca.diff L

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/137661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Oliver Hunt via cfe-commits
ojhunt wrote: > @ojhunt In #137600 there are a list of a few temporary PRs that were merged > in to silence the warning. These need to be reverted after this one gets > merged in. Do you want to revert them or you want me to do that? I removed them as part of resolving the merge conflict, and

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-02 Thread Morris Hafner via cfe-commits
https://github.com/mmha edited https://github.com/llvm/llvm-project/pull/136807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][lex] Fix lexing malformed pragma within include directive (PR #138165)

2025-05-02 Thread Stefan Weigl-Bosker via cfe-commits
https://github.com/sweiglbosker updated https://github.com/llvm/llvm-project/pull/138165 >From 08f13cc755539516c2a5606ed0a7dfa20b99bbd3 Mon Sep 17 00:00:00 2001 From: Stefan Weigl-Bosker Date: Thu, 1 May 2025 12:24:17 -0400 Subject: [PATCH] [Lex] fix lexing malformed pragma within include direc

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread Martin Storsjö via cfe-commits
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) +if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR + ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/138222 >From b3ae2d60a178f3c5bb8950804041386a667abc6e Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 29 Apr 2025 15:47:01 -0700 Subject: [PATCH 1/4] [CIR] Refactor global variable emission and initialization

[clang] [clang] Complete the revert of 1a14ef1 (PR #138341)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/138341 When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor. >From f8a05ddf95c4efa963411694f49fa235e59c3d5c Mon Sep

[clang] [Clang][NFC] Capture by ref to avoid copying std::string (PR #138231)

2025-05-02 Thread Shafik Yaghmour via cfe-commits
shafik wrote: > Makes sense, thanks. I just wonder why is BName an owning string? To me it > would make a lot more sense if it was a StringRef owned by the ASTContext. > WDYT? `FD->getASTContext().BuiltinInfo.getName(BId)` returns std::string by value, looking at the API it looks pretty purpo

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread Arthur Eubanks via cfe-commits
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) +if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR + ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/138119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Arthur Eubanks (aeubanks) Changes This was accidentally disabled in #138119 for non-mingw Windows. --- Full diff: https://github.com/llvm/llvm-project/pull/138343.diff 1 Files Affected: - (modified) clang/tools/libclang/CMakeLists.txt (

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

2025-05-02 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/138342 More fixes based on https://github.com/llvm/llvm-project/pull/138036 >From 5540b8d5bc0130b2089c219d49e856ab6817420b Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 2 May 2025 13:39:59 -0700 Subject: [PA

[clang] [clang] Complete the revert of 1a14ef1 (PR #138341)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) Changes When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor. --- Full diff: https://github.com/llvm/llvm-project/p

[clang] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/138343 This was accidentally disabled in #138119 for non-mingw Windows. >From f3e9e6f256bef046b513701a43b369c5c127aac7 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Fri, 2 May 2025 20:39:17 + Subject: [PATC

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-02 Thread Sean Perry via cfe-commits
https://github.com/perry-ca updated https://github.com/llvm/llvm-project/pull/111035 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[clang] [clang] Complete the revert of 1a14ef1 (PR #138341)

2025-05-02 Thread Oliver Hunt via cfe-commits
ojhunt wrote: @zahiraam missed this while reverting :-O https://github.com/llvm/llvm-project/pull/138341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread via cfe-commits
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) +if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR + ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL

[clang] [clang] Complete the revert of 1a14ef1 (PR #138341)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. Looks good. Thanks. https://github.com/llvm/llvm-project/pull/138341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

2025-05-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/AST/Type.cpp clang/lib/CodeGen/CGCall.cpp `

[clang] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread via cfe-commits
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR +if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC)) ---

[clang] [clang][analyzer][NFC] Improve Clang Static Analyzer performance. (PR #138295)

2025-05-02 Thread Balazs Benics via cfe-commits
steakhal wrote: FYI @necto https://github.com/llvm/llvm-project/pull/138295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a9ce60e - [clang] Complete the revert of 1a14ef1 (#138341)

2025-05-02 Thread via cfe-commits
Author: Oliver Hunt Date: 2025-05-02T13:50:24-07:00 New Revision: a9ce60ee885e25cba54c8900605563ff66e067b7 URL: https://github.com/llvm/llvm-project/commit/a9ce60ee885e25cba54c8900605563ff66e067b7 DIFF: https://github.com/llvm/llvm-project/commit/a9ce60ee885e25cba54c8900605563ff66e067b7.diff L

[clang] [clang] Complete the revert of 1a14ef1 (PR #138341)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/138341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

2025-05-02 Thread Reid Kleckner via cfe-commits
rnk wrote: > FWIW, I'm seeing the test failure on Windows x64 with a debug build of > Clang's unit tests as of a fresh fetch of main this morning. Sorry about that! I leaned on the Windows premerge tests to find Windows issues (they did, that was useful), but I'm pretty sure it uses release, n

[clang] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/138343 >From f3e9e6f256bef046b513701a43b369c5c127aac7 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Fri, 2 May 2025 20:39:17 + Subject: [PATCH 1/2] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_

[clang] [cmake] Reenable libclang.dll LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread Arthur Eubanks via cfe-commits
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR +if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC)) ---

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread via cfe-commits
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR +if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC)) ---

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-02 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/27] Update SemaL

[clang] [CIR] Upstream local VectorType with 0 init elemnts (PR #138346)

2025-05-02 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/138346 This change adds local zero initialization for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 >From 821d56db431ec2587eefc18f9f9dab5f5dc48c7e Mon Sep 17 00:00:00 2001 From: AmrDeveloper

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds local zero initialization for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 --- Full diff: https://github.com/llvm/llvm-project/pull/138

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-02 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/138346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 17fdcda - [CIR][NFC] Upstream bulk handling for Decl kinds (#138319)

2025-05-02 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-05-02T14:24:02-07:00 New Revision: 17fdcda3790c669fc3d378cb192d66f3d29da47c URL: https://github.com/llvm/llvm-project/commit/17fdcda3790c669fc3d378cb192d66f3d29da47c DIFF: https://github.com/llvm/llvm-project/commit/17fdcda3790c669fc3d378cb192d66f3d29da47c.diff L

[clang] [CIR][NFC] Upstream bulk handling for Decl kinds (PR #138319)

2025-05-02 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/138319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-02 Thread Krzysztof Drewniak via cfe-commits
@@ -564,6 +564,11 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, llvm::Function *F = CGM.getIntrinsic(IID, {LoadTy}); return Builder.CreateCall(F, {Addr}); } + case AMDGPU::BI__builtin_amdgcn_load_to_lds: { +// Should this have asan instrum

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-02 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/28] Update SemaL

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-02 Thread via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-02 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: Re discussion on the other PR about "why is this even an intrinsic" - since this probably shouldn't just be in @jayfoad's DMs: The reason I disagree with "just pattern-match it" is that you can't get the scheduling you want without a guarantee of the intrinssic Namely, while

[clang] f313b0a - [Clang][NFC] Capture by ref to avoid copying std::string (#138231)

2025-05-02 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2025-05-02T14:31:32-07:00 New Revision: f313b0af15857dada7743af310229b6944fd1c61 URL: https://github.com/llvm/llvm-project/commit/f313b0af15857dada7743af310229b6944fd1c61 DIFF: https://github.com/llvm/llvm-project/commit/f313b0af15857dada7743af310229b6944fd1c61.dif

[clang] [Clang][NFC] Capture by ref to avoid copying std::string (PR #138231)

2025-05-02 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/138231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-02 Thread Erich Keane via cfe-commits
@@ -70,12 +72,15 @@ void foo() { // CIR: %[[VEC_E:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["e", init] // CIR: %[[VEC_F:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["f", init] // CIR: %[[VEC_G:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["g", in

[clang] [Clang][NFC] Adding note on details that are not immediately obvious (PR #138349)

2025-05-02 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/138349 This code was flagged by static analysis. It was a false positive but the reason why this code is valid is subtle and folks refactoring this code in the future could easily miss it. >From 48a5b4a859c78fbc369473

[clang] [Clang][NFC] Adding note on details that are not immediately obvious (PR #138349)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes This code was flagged by static analysis. It was a false positive but the reason why this code is valid is subtle and folks refactoring this code in the future could easily miss it. --- Full diff: https:/

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-02 Thread Amr Hesham via cfe-commits
@@ -70,12 +72,15 @@ void foo() { // CIR: %[[VEC_E:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["e", init] // CIR: %[[VEC_F:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["f", init] // CIR: %[[VEC_G:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["g", in

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-02 Thread Artem Belevich via cfe-commits
Artem-B wrote: OK. This makes sense. > sorry this change is so drawn out :) What matters is that you're making progress, and I appreciate your work on getting this issue sorted out the right way. https://github.com/llvm/llvm-project/pull/138205 _

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-02 Thread Artem Belevich via cfe-commits
@@ -2376,9 +2376,14 @@ NamedDecl *Sema::LazilyCreateBuiltin(IdentifierInfo *II, unsigned ID, return nullptr; } + // Warn for implicit uses of header dependent libraries, + // except in system headers. if (!ForRedeclaration && (Context.BuiltinInfo.isPredefine

[clang] 140c2b6 - [clang][NFC] Convert `Sema::AllowFoldKind` to scoped enum

2025-05-02 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T10:48:08+03:00 New Revision: 140c2b6d081b781b19f50bf1c4fbf4b17bfacdc1 URL: https://github.com/llvm/llvm-project/commit/140c2b6d081b781b19f50bf1c4fbf4b17bfacdc1 DIFF: https://github.com/llvm/llvm-project/commit/140c2b6d081b781b19f50bf1c4fbf4b17bfacdc1.

[clang] [Clang][Cygwin] Remove erroneous _WIN32 define and clean up Cygwin code (PR #138120)

2025-05-02 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/138120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] Remove erroneous _WIN32 define and clean up Cygwin code (PR #138120)

2025-05-02 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/138120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] Remove erroneous _WIN32 define and clean up Cygwin code (PR #138120)

2025-05-02 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. I updated the PR description with the details I wanted to have included in the commit message. https://github.com/llvm/llvm-project/pull/138120 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] abe93fe - [Clang][Cygwin] Remove erroneous _WIN32 define and clean up Cygwin code (#138120)

2025-05-02 Thread via cfe-commits
Author: Mateusz Mikuła Date: 2025-05-02T11:07:15+03:00 New Revision: abe93fe7c88c477343c884036982ddc15f820425 URL: https://github.com/llvm/llvm-project/commit/abe93fe7c88c477343c884036982ddc15f820425 DIFF: https://github.com/llvm/llvm-project/commit/abe93fe7c88c477343c884036982ddc15f820425.diff

[clang] [Clang][Cygwin] don't use -Bsymbolic-functions (PR #138217)

2025-05-02 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

2025-05-02 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Okay, you were right. Keeping this in a single description hurts readability > a lot. > > So I have opened a series of smaller PRs: #138117 #138118 #138119 #138120 > > This branch is equal to the other ones (once they are merged together), so we > can go either way. I think

[clang] db247dd - [clang][NFC] Convert `Sema::ArithConvKind` to scoped enum

2025-05-02 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T11:02:01+03:00 New Revision: db247ddc9d5411ace70b478f7119eb44a43a8e5c URL: https://github.com/llvm/llvm-project/commit/db247ddc9d5411ace70b478f7119eb44a43a8e5c DIFF: https://github.com/llvm/llvm-project/commit/db247ddc9d5411ace70b478f7119eb44a43a8e5c.

[clang] 592243c - [Clang][Cygwin] Fix symbol visibility definition (#138118)

2025-05-02 Thread via cfe-commits
Author: Mateusz Mikuła Date: 2025-05-02T11:01:37+03:00 New Revision: 592243c1cb3ea53b34033132a87b0d14af9d1079 URL: https://github.com/llvm/llvm-project/commit/592243c1cb3ea53b34033132a87b0d14af9d1079 DIFF: https://github.com/llvm/llvm-project/commit/592243c1cb3ea53b34033132a87b0d14af9d1079.diff

[clang] [Clang][Cygwin] Fix symbol visibility definition (PR #138118)

2025-05-02 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/138118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [IR] Do not store Function inside BlockAddress (PR #137958)

2025-05-02 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/137958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [IR] Do not store Function inside BlockAddress (PR #137958)

2025-05-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ml-opt-dev-x86-64` running on `ml-opt-dev-x86-64-b2` while building `clang,llvm,mlir` at step 4 "cmake-configure". Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/17828 Here is the relevan

[clang] [CIR] Refactor floating point type constraints (PR #138112)

2025-05-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/19356 Here is th

[clang] 9bc20fb - [Clang][Cygwin] Disable shared libs on Cygwin by default (#138119)

2025-05-02 Thread via cfe-commits
Author: Mateusz Mikuła Date: 2025-05-02T11:02:11+03:00 New Revision: 9bc20fbbadb18a1c3415d4442066ed35a6bcc175 URL: https://github.com/llvm/llvm-project/commit/9bc20fbbadb18a1c3415d4442066ed35a6bcc175 DIFF: https://github.com/llvm/llvm-project/commit/9bc20fbbadb18a1c3415d4442066ed35a6bcc175.diff

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-02 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/138119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d0dcfd4 - [clang][NFC] Convert `Sema::VarArgKind` to scoped enum

2025-05-02 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T11:24:08+03:00 New Revision: d0dcfd4c68171c3b9b863626c08efa7f38cd0c54 URL: https://github.com/llvm/llvm-project/commit/d0dcfd4c68171c3b9b863626c08efa7f38cd0c54 DIFF: https://github.com/llvm/llvm-project/commit/d0dcfd4c68171c3b9b863626c08efa7f38cd0c54.

[clang] [llvm] [IR] Mark convergence intrins as has-side-effect (PR #134844)

2025-05-02 Thread Nathan Gauër via cfe-commits
Keenuts wrote: Closed in favor of https://github.com/llvm/llvm-project/pull/135794 https://github.com/llvm/llvm-project/pull/134844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [IR] Mark convergence intrins as has-side-effect (PR #134844)

2025-05-02 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts closed https://github.com/llvm/llvm-project/pull/134844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Refactor IntType constraints (PR #138106)

2025-05-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/8689 Here is the releva

[clang] [ARM, AArch64] Fix ABI bugs with over-sized bitfields (PR #126774)

2025-05-02 Thread Oliver Stannard via cfe-commits
ostannard wrote: I'd assumed that this was a sufficiently uncommon edge-case that it wasn't worth a release note, but I'll keep that in mind in future and add release notes for things like this. https://github.com/llvm/llvm-project/pull/126774 ___ cf

[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

2025-05-02 Thread Mateusz Mikuła via cfe-commits
mati865 wrote: Thank you for taking care of it! https://github.com/llvm/llvm-project/pull/134494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

2025-05-02 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 closed https://github.com/llvm/llvm-project/pull/134494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   7   >