@@ -119,6 +119,15 @@ constexpr auto b3 = name1() == name1(); // ref-error
{{must be initialized by a
constexpr auto b4 = name1() == name2();
static_assert(!b4);
+constexpr auto bar(const char *p) { return p + __builtin_strlen(p); }
+constexpr auto b5 = bar(p1) == p1;
+static_
zygoloid wrote:
Yeah. I agree that using the overlap diagnostic only in the case where there's
at least one byte of potential overlap (as this PR does) is best.
https://github.com/llvm/llvm-project/pull/137078
___
cfe-commits mailing list
cfe-commits@
https://github.com/bob-wilson created
https://github.com/llvm/llvm-project/pull/137087
This adds a new filtering option to be used along with the
-header-include-format=json option. The existing "only-direct-system" filtering
option is missing some things:
- It does not show module imports.
-
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Bob Wilson (bob-wilson)
Changes
This adds a new filtering option to be used along with the
-header-include-format=json option. The existing "only-direct-system" filtering
option is missing some things:
- It does not show module imports.
-
@@ -13,20 +13,76 @@
#include "CIRGenCall.h"
#include "CIRGenFunction.h"
+#include "CIRGenFunctionInfo.h"
#include "clang/CIR/MissingFeatures.h"
using namespace clang;
using namespace clang::CIRGen;
-CIRGenFunctionInfo *CIRGenFunctionInfo::create(CanQualType resultType)
@@ -233,6 +233,19 @@ int f8(int *p) {
// OGCG: %[[P2:.*]] = load ptr, ptr %[[P_PTR]], align 8
// OGCG: %[[STAR_P:.*]] = load i32, ptr %[[P2]], align 4
+
+void f9() {}
andykaylor wrote:
It seems like a lot of code was added compared to what is covered by t
jansvoboda11 wrote:
How about `clang/unittests/libclang/LibclangTest.cpp`?
https://github.com/llvm/llvm-project/pull/136773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/136387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -24,100 +26,222 @@
RootSignatureParser::RootSignatureParser(SmallVector &Elements,
bool RootSignatureParser::parse() {
// Iterate as many RootElements as possible
- while (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) {
-// Dispatch onto parser method.
-
@@ -236,6 +278,102 @@ TEST_F(ParseHLSLRootSignatureTest,
InvalidParseUnexpectedEndOfStreamTest) {
// Test correct diagnostic produced - end of stream
Consumer->setExpected(diag::err_expected_after);
+
damyanp wrote:
It's kind of surprising to see all the
https://github.com/hnrklssn closed
https://github.com/llvm/llvm-project/pull/137078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Henrik G. Olsson
Date: 2025-04-23T16:48:46-07:00
New Revision: 93705c3a76e9b00137be84fbc6ef3b4af5fcc031
URL:
https://github.com/llvm/llvm-project/commit/93705c3a76e9b00137be84fbc6ef3b4af5fcc031
DIFF:
https://github.com/llvm/llvm-project/commit/93705c3a76e9b00137be84fbc6ef3b4af5fcc031.di
https://github.com/hnrklssn created
https://github.com/llvm/llvm-project/pull/137088
Reverts llvm/llvm-project#137078
>From 30f38f86a765a24e368083ffbcac9f036e6fc221 Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 23 Apr 2025 16:48:29 -0700
Subject: [PATCH] Revert "[ConstEval] Fix
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
building `clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/144/builds/23465
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Henrik G. Olsson (hnrklssn)
Changes
Reverts llvm/llvm-project#137078
---
Full diff: https://github.com/llvm/llvm-project/pull/137088.diff
3 Files Affected:
- (modified) clang/lib/AST/ExprConstant.cpp (+2-7)
- (modified) clang/test/AST/
@@ -119,6 +119,15 @@ constexpr auto b3 = name1() == name1(); // ref-error
{{must be initialized by a
constexpr auto b4 = name1() == name2();
static_assert(!b4);
+constexpr auto bar(const char *p) { return p + __builtin_strlen(p); }
+constexpr auto b5 = bar(p1) == p1;
+static_
@@ -152,3 +303,105 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo
&funcInfo,
return ret;
}
+
+void CIRGenFunction::emitCallArg(CallArgList &args, const clang::Expr *e,
+ clang::QualType argType) {
+ assert(argType->isReferenceTy
@@ -129,10 +129,10 @@ TEST_F(ParseHLSLRootSignatureTest, ValidParseEmptyTest) {
TEST_F(ParseHLSLRootSignatureTest, ValidParseDTClausesTest) {
const llvm::StringLiteral Source = R"cc(
DescriptorTable(
- CBV(),
- SRV(),
- Sampler(),
- UAV()
+ CBV(b0
@@ -253,3 +253,8 @@ size_type max_size(void) {
// OGCG: define{{.*}} i64 @max_size()
// OGCG: ret i64 2305843009213693951
+
+enum {
+ um = 0,
+ dois = 1,
+};
andykaylor wrote:
It looks like you don't have a newline at the end of the file.
https://github.
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/137068
In an explicit build, the dependency scanner generates invocations with
dependencies to module files to use during compilation. The pcm's passed in the
invocations should match the ones that were imported b
@@ -3311,11 +3312,22 @@ ASTReader::ReadControlBlock(ModuleFile &F,
SignatureBytes.end());
Blob = Blob.substr(ASTFileSignature::size);
+// Use BaseDirectoryAsWritten to ensure we use the same path in the
+
@@ -26,22 +26,14 @@
RootSignatureParser::RootSignatureParser(SmallVector &Elements,
bool RootSignatureParser::parse() {
// Iterate as many RootElements as possible
- while (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) {
-// Dispatch onto parser method.
-
@@ -26,22 +26,14 @@
RootSignatureParser::RootSignatureParser(SmallVector &Elements,
bool RootSignatureParser::parse() {
// Iterate as many RootElements as possible
- while (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) {
-// Dispatch onto parser method.
-
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
In an explicit build, the dependency scanner generates invocations with
dependencies to module files to use during compilation. The pcm's passed in the
invocations should match the ones that were importe
@@ -169,6 +169,47 @@ See the discussion in the section about
:ref:`merging locations` for examples of when the rule for
dropping locations applies.
+.. _NewInstLocations:
+
+Setting locations for new instructions
+--
+
+Whenever a new instru
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?=
Message-ID:
In-Reply-To:
lexi-nadia wrote:
> Maybe the verifier error was pre-existing, but after this change, now we
> crash when previously we silently generated IR
@@ -26,22 +26,14 @@
RootSignatureParser::RootSignatureParser(SmallVector &Elements,
bool RootSignatureParser::parse() {
// Iterate as many RootElements as possible
- while (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) {
-// Dispatch onto parser method.
-
@@ -26,22 +26,14 @@
RootSignatureParser::RootSignatureParser(SmallVector &Elements,
bool RootSignatureParser::parse() {
// Iterate as many RootElements as possible
- while (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) {
-// Dispatch onto parser method.
-
https://github.com/inbelic approved this pull request.
Can use the [NFC] tag as well if you want
https://github.com/llvm/llvm-project/pull/137004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/V-FEXrt approved this pull request.
https://github.com/llvm/llvm-project/pull/136747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3311,11 +3312,22 @@ ASTReader::ReadControlBlock(ModuleFile &F,
SignatureBytes.end());
Blob = Blob.substr(ASTFileSignature::size);
+// Use BaseDirectoryAsWritten to ensure we use the same path in the
+
https://github.com/jzc created https://github.com/llvm/llvm-project/pull/137070
None
>From 924f54246910cad42f97efe1bc3d3bdfec039ecb Mon Sep 17 00:00:00 2001
From: "Cai, Justin"
Date: Mon, 14 Apr 2025 21:30:39 +
Subject: [PATCH] [Clang] Move OffloadArch enum to a generic location and add
in
https://github.com/jzc edited https://github.com/llvm/llvm-project/pull/137070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Justin Cai (jzc)
Changes
Currently, the OffloadArch enum is defined Cuda.h. This PR moves the definition
to a more generic location in OffloadArch.h/cpp and also adds an initial set of
Intel OffloadArch values that will be used in
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/137068
>From bb548cb398714ae77b6fd2f782b172d8b9032a2f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 23 Apr 2025 14:47:17 -0700
Subject: [PATCH] [clang][Modules] Diagnose mismatching pcm dependencies in
ex
@@ -169,6 +169,47 @@ See the discussion in the section about
:ref:`merging locations` for examples of when the rule for
dropping locations applies.
+.. _NewInstLocations:
+
+Setting locations for new instructions
+--
+
+Whenever a new instru
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Justin Cai (jzc)
Changes
Currently, the OffloadArch enum is defined Cuda.h. This PR moves the definition
to a more generic location in OffloadArch.h/cpp and also adds an initial set of
Intel OffloadArch values that will be used in SYCL co
Author: Reid Kleckner
Date: 2025-04-23T22:09:02Z
New Revision: cd826d6e840ed33ad88458c862da5f9fcc6e908c
URL:
https://github.com/llvm/llvm-project/commit/cd826d6e840ed33ad88458c862da5f9fcc6e908c
DIFF:
https://github.com/llvm/llvm-project/commit/cd826d6e840ed33ad88458c862da5f9fcc6e908c.diff
LOG:
modiking wrote:
> Can we please not merge anything without review?
This was a part of https://github.com/llvm/llvm-project/pull/135444 and
reviewed there but for operational purposes I split it out into 2 PRs. I
could've been more clear on this in the description though.
https://github.com/ll
https://github.com/jansvoboda11 approved this pull request.
LGTM, thanks! I left a couple of comments for your consideration, but don't
feel obligated to incorporate them.
https://github.com/llvm/llvm-project/pull/136773
___
cfe-commits mailing list
c
Ankur-0429 wrote:
> I would also want to see tests that show uses of an enum, as well as fixed
> underlying type, scoped enums/etc.
Going to wait to confirm I did the "fixed underlying type" part first.
If you have more specific enum use cases that we should test for, please let me
know.
ht
@@ -1099,7 +1099,13 @@ SanitizerArgs::SanitizerArgs(const ToolChain &TC,
}
} else {
-AsanUseAfterScope = false;
+if (AllAddedKinds & SanitizerKind::KernelAddress) {
vitalybuka wrote:
why just kernel?
https://github.com/llvm/llvm-project/pull/13
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/137097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/137103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2025-04-23T21:28:58-07:00
New Revision: cd92d8db34afd95335697f85a527028fa8309d18
URL:
https://github.com/llvm/llvm-project/commit/cd92d8db34afd95335697f85a527028fa8309d18
DIFF:
https://github.com/llvm/llvm-project/commit/cd92d8db34afd95335697f85a527028fa8309d18.diff
LOG:
@@ -1099,7 +1099,13 @@ SanitizerArgs::SanitizerArgs(const ToolChain &TC,
}
} else {
-AsanUseAfterScope = false;
+if (AllAddedKinds & SanitizerKind::KernelAddress) {
vitalybuka wrote:
I see, there is Asan case already and we need kernel one
ther
Author: Wenju He
Date: 2025-04-24T05:35:16+01:00
New Revision: 77fe6aaeaaf2b16e021675e92e543dafd18bbc0b
URL:
https://github.com/llvm/llvm-project/commit/77fe6aaeaaf2b16e021675e92e543dafd18bbc0b
DIFF:
https://github.com/llvm/llvm-project/commit/77fe6aaeaaf2b16e021675e92e543dafd18bbc0b.diff
LOG:
frasercrmck wrote:
> > I would like to further investigate weak linkage as another means of
> > overriding specific builtins down to a finer granularity. That approach
> > might warrant another method of file discovery.
>
> It would bring unnecessary builds and may increase build time. Filenam
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/135710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vitaly Buka
Date: 2025-04-23T21:13:18-07:00
New Revision: cb8495c0fcf32592c6fcd23429b702dccb57d2eb
URL:
https://github.com/llvm/llvm-project/commit/cb8495c0fcf32592c6fcd23429b702dccb57d2eb
DIFF:
https://github.com/llvm/llvm-project/commit/cb8495c0fcf32592c6fcd23429b702dccb57d2eb.diff
L
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/136386
>From c1a89d6896edd29ff345dd8fdc30cd040f3760f3 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 18 Apr 2025 16:06:18 -0700
Subject: [PATCH 1/2] add md node type filter, and test
---
.../test/CodeGenHL
@@ -101,9 +103,11 @@ T tmain(T argc, T *argv) {
a = 2;
#pragma omp task default(none), private(argc, b) firstprivate(argv) shared(d)
if (argc > 0) final(S::TS > 0) priority(argc) affinity(argc, argv[b:argc],
arr[:], ([argc][sizeof(T)])argv)
foo();
+#ifndef OMP60
-
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/136386
>From c1a89d6896edd29ff345dd8fdc30cd040f3760f3 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 18 Apr 2025 16:06:18 -0700
Subject: [PATCH 1/3] add md node type filter, and test
---
.../test/CodeGenHL
Author: Thurston Dang
Date: 2025-04-23T22:00:11-07:00
New Revision: 31c7997a4acb838c94d5ab40baaf154556532ad9
URL:
https://github.com/llvm/llvm-project/commit/31c7997a4acb838c94d5ab40baaf154556532ad9
DIFF:
https://github.com/llvm/llvm-project/commit/31c7997a4acb838c94d5ab40baaf154556532ad9.diff
https://github.com/thurstond closed
https://github.com/llvm/llvm-project/pull/135438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/130383
>From 1e6ed0266fb849f14d6b952dcd84e277ed70aa58 Mon Sep 17 00:00:00 2001
From: Mathias Stearn
Date: Thu, 19 Dec 2024 16:22:04 +0100
Subject: [PATCH 01/11] [libclang/python] Add equality comparison operators
DeinAlptraum wrote:
@Endilll having merged #135773 and rebased, the issues with file equality for
in-memory files are resolved.
I've reduced this to two tests now, that run on the except same C code except
one of them uses on-disk files and the other one uses in-memory files. This
replicates
https://github.com/Ankur-0429 updated
https://github.com/llvm/llvm-project/pull/136807
>From 44a384b8ad774939c7664c8a476e852f1d4a7341 Mon Sep 17 00:00:00 2001
From: Ankur Ahir
Date: Tue, 22 Apr 2025 20:04:34 -0700
Subject: [PATCH 1/6] Upstream enum support
---
clang/lib/CIR/CodeGen/CIRGenModu
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/135438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 460 of 460 matches
Mail list logo
