[clang] 1b6cbaa - [clang][bytecode] Refine diagnostics for volatile reads (#136857)

2025-04-23 Thread via cfe-commits
Author: Timm Baeder Date: 2025-04-23T18:52:35+02:00 New Revision: 1b6cbaa7b64f54b127d139d653468e213bae007e URL: https://github.com/llvm/llvm-project/commit/1b6cbaa7b64f54b127d139d653468e213bae007e DIFF: https://github.com/llvm/llvm-project/commit/1b6cbaa7b64f54b127d139d653468e213bae007e.diff L

[clang] [clang][bytecode] Refine diagnostics for volatile reads (PR #136857)

2025-04-23 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/136857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ptrauth] add support for options parameter to __ptrauth (PR #136828)

2025-04-23 Thread Oliver Hunt via cfe-commits
ojhunt wrote: @cor3ntin the option selection down stream is a StringSwitch on the authentication mode, and then a sequence of (not large, I think just two) `if (option == constant)` checks to set up specific options. Previous PRs have suggested maps, etc for such conditions, and a map of opti

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-23 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/136842 >From 723976e74398e12252a599e3aabb05ec8f2515ab Mon Sep 17 00:00:00 2001 From: Pengcheng Wang Date: Wed, 23 Apr 2025 18:19:41 +0800 Subject: [PATCH] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` This

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-23 Thread Luke Lau via cfe-commits
@@ -632,6 +632,8 @@ RISC-V Support Qualcomm's `Xqciint` extension to save and restore some GPRs in interrupt service routines. +- `Zicsr` / `Zifencei` are allowed to duplicate with `g` in `-march`. lukel97 wrote: Nit ```suggestion - `Zicsr` / `Zifencei` a

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-23 Thread Luke Lau via cfe-commits
lukel97 wrote: If you're planning on backporting this, should the release notes be added in a separate commit? I'm wondering if you'll end up with issues trying to cherry-pick it otherwise https://github.com/llvm/llvm-project/pull/136842 ___ cfe-comm

[clang] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV-like ABIs (PR #135230)

2025-04-23 Thread Jeremy Morse via cfe-commits
jmorse wrote: > To solve this problem in general, it would probably(?) be best to make SROA > create fragment #dbg_value records if it decomposes an alloca into multiple > IR values but I have no idea how difficult that would be to accomplish. An example of this happening today with C++ struct

[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

2025-04-23 Thread Balázs Benics via cfe-commits
@@ -81,10 +81,6 @@ class FunctionSummariesTy { I->second.MayInline = 0; } - void markReachedMaxBlockCount(const Decl *D) { -markShouldNotInline(D); - } balazs-benics-sonarsource wrote: I'd not mind keeping this if there was more thing to do once a

[clang] [clang][bytecode] Refine diagnostics for volatile reads (PR #136857)

2025-04-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Differentiate between a volarile read via a lvalue-to-rvalue cast of a volatile qualified subexpression and a read from a pointer with a volatile base object. --- Full diff: https://github.com/llvm/llvm-proj

[clang] [llvm] [RISCV] Add support for Ziccamoc (PR #136694)

2025-04-23 Thread via cfe-commits
https://github.com/T-Tie updated https://github.com/llvm/llvm-project/pull/136694 >From c7fabb64f6690de12f9dbffa16ef4d74ed2b3ae9 Mon Sep 17 00:00:00 2001 From: Tie Date: Tue, 22 Apr 2025 12:25:32 + Subject: [PATCH 1/2] Add Support for Ziccamoc --- clang/test/Preprocessor/riscv-target-feat

[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

2025-04-23 Thread Donát Nagy via cfe-commits
@@ -2856,8 +2873,29 @@ void ExprEngine::processBranch( // conflicts with the widen-loop analysis option (which is off by // default). If we intend to support and stabilize the loop widening, // we must ensure that it 'plays nicely' with this logic. - if (

[clang] [mlir] [mlir][acc] Use consistent name for device_num operand (PR #136745)

2025-04-23 Thread Erich Keane via cfe-commits
erichkeane wrote: > I plan on merging this as soon as the 2 pending checks complete :) Despite the above suggestion, I still believe this is a positive change, so still support merging this. https://github.com/llvm/llvm-project/pull/136745 ___ cfe-co

[clang] 5b0cd17 - [Clang][llvm] Implement fp8 FMOP4A intrinsics (#130127)

2025-04-23 Thread via cfe-commits
Author: Virginia Cangelosi Date: 2025-04-23T14:10:13+01:00 New Revision: 5b0cd17c386ecd126c7f0ab514413bab8222b421 URL: https://github.com/llvm/llvm-project/commit/5b0cd17c386ecd126c7f0ab514413bab8222b421 DIFF: https://github.com/llvm/llvm-project/commit/5b0cd17c386ecd126c7f0ab514413bab8222b421.

[clang] [llvm] [RISCV] Add support for Ziccamoc (PR #136694)

2025-04-23 Thread via cfe-commits
T-Tie wrote: > Release notes? Sure. https://github.com/llvm/llvm-project/pull/136694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] capture possible ODR-used var (PR #136645)

2025-04-23 Thread Yaxun Liu via cfe-commits
@@ -1100,3 +1101,49 @@ std::string SemaCUDA::getConfigureFuncName() const { // Legacy CUDA kernel configuration call return "cudaConfigureCall"; } + +// Record any local constexpr variables that are passed one way on the host +// and another on the device. +void SemaCUDA::r

[clang] [llvm] Branch1 (PR #136834)

2025-04-23 Thread via cfe-commits
https://github.com/blazie2004 created https://github.com/llvm/llvm-project/pull/136834 None error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

2025-04-23 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,198 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify=expected,default %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config legacy-inlining-prevention=false -verify=expected,disabled %s + +int get

[clang] [C] Add (new) -Wimplicit-void-ptr-cast to -Wc++-compat (PR #136855)

2025-04-23 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/136855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Update __gcsss intrinsic to match revised ACLE specification (PR #136850)

2025-04-23 Thread via cfe-commits
https://github.com/sivan-shani updated https://github.com/llvm/llvm-project/pull/136850 >From a3cc71ef731e08d9e0963db767e190a231f75260 Mon Sep 17 00:00:00 2001 From: Sivan Shani Date: Wed, 23 Apr 2025 12:39:05 +0100 Subject: [PATCH 1/2] [AArch64] Update __gcsss intrinsic to match revised ACLE

[clang] [clang][deps] Make dependency directives getter thread-safe (PR #136178)

2025-04-23 Thread Cyndy Ishida via cfe-commits
@@ -357,6 +357,32 @@ static void canonicalizeDefines(PreprocessorOptions &PPOpts) { std::swap(PPOpts.Macros, NewMacros); } +class ActualDependencyDirectivesGetter : public DependencyDirectivesGetter { cyndyishida wrote: nit: s/ActualDependencyDirectivesGet

[clang] [clang][deps] Make dependency directives getter thread-safe (PR #136178)

2025-04-23 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida approved this pull request. https://github.com/llvm/llvm-project/pull/136178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Update __gcsss intrinsic to match revised ACLE specification (PR #136850)

2025-04-23 Thread via cfe-commits
sivan-shani wrote: clang/test/CodeGen/AArch64/gcs.c updated https://github.com/llvm/llvm-project/pull/136850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Emit fake uses before musttail calls (PR #136867)

2025-04-23 Thread via cfe-commits
gulfemsavrun wrote: Thanks for the fix, and I verified that it resolves the issue that I reported in https://github.com/llvm/llvm-project/pull/118026#issuecomment-2822881489. https://github.com/llvm/llvm-project/pull/136867 ___ cfe-commits mailing lis

[clang] [clang] Adding an API to create a `CXStringSet` from a Vector of `StringRef`s (PR #136773)

2025-04-23 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/136773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][analyzer] replace Stmt* with ConstCFGElementRef in SymbolConjured (PR #128251)

2025-04-23 Thread Fangyi Zhou via cfe-commits
@@ -114,7 +128,8 @@ class SValExplainer : public FullSValVisitor { std::string VisitSymbolConjured(const SymbolConjured *S) { return "symbol of type '" + S->getType().getAsString() + - "' conjured at statement '" + printStmt(S->getStmt()) + "'"; + "'

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pengcheng Wang (wangpc-pp) Changes This matches GCC and we supported it in LLVM 17/18. Fixes #136803 --- Full diff: https://github.com/llvm/llvm-project/pull/136842.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2)

[libclc] [libclc] Build for OpenCL 3.0 and enable all extensions and features (PR #135733)

2025-04-23 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/135733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Build for OpenCL 3.0 (PR #135733)

2025-04-23 Thread Wenju He via cfe-commits
https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/135733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland [clang] Handle instantiated members to determine visibility (#136128) (PR #136689)

2025-04-23 Thread Andrew Savonichev via cfe-commits
https://github.com/asavonic updated https://github.com/llvm/llvm-project/pull/136689 >From 6689a9cca6ed378f70aa52fc0f110a4fb49c056d Mon Sep 17 00:00:00 2001 From: Andrew Savonichev Date: Mon, 21 Apr 2025 19:45:05 +0900 Subject: [PATCH 1/2] [clang] Fix computeTypeLinkageInfo for non-record membe

[clang] Reland [clang] Handle instantiated members to determine visibility (#136128) (PR #136689)

2025-04-23 Thread Andrew Savonichev via cfe-commits
@@ -4787,8 +4787,10 @@ LinkageInfo LinkageComputer::computeTypeLinkageInfo(const Type *T) { return computeTypeLinkageInfo(cast(T)->getPointeeType()); case Type::MemberPointer: { const auto *MPT = cast(T); -LinkageInfo LV = -getDeclLinkageAndVisibility(MPT

[clang] Reland [clang] Handle instantiated members to determine visibility (#136128) (PR #136689)

2025-04-23 Thread Andrew Savonichev via cfe-commits
@@ -4787,8 +4787,10 @@ LinkageInfo LinkageComputer::computeTypeLinkageInfo(const Type *T) { return computeTypeLinkageInfo(cast(T)->getPointeeType()); case Type::MemberPointer: { const auto *MPT = cast(T); -LinkageInfo LV = -getDeclLinkageAndVisibility(MPT

[clang] 500cccc - Remove spurious semicolon; NFC

2025-04-23 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2025-04-23T07:16:44-04:00 New Revision: 500a0cbcbb547e2a54b25162f20808b45af0 URL: https://github.com/llvm/llvm-project/commit/500a0cbcbb547e2a54b25162f20808b45af0 DIFF: https://github.com/llvm/llvm-project/commit/500a0cbcbb547e2a54b25162f20808b45af0.diff

[clang] Reland [clang] Handle instantiated members to determine visibility (#136128) (PR #136689)

2025-04-23 Thread Andrew Savonichev via cfe-commits
https://github.com/asavonic edited https://github.com/llvm/llvm-project/pull/136689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-23 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/135163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-23 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur commented: Unfortuantely IIRC there is a semantic difference between pragma and metadata: * llvm.loop.vectorize.enable==false disables vectorization AND interleaving (by switching off the entire LoopVectorize pass which does both of thise things) * llvm.loop.vect

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-23 Thread Michael Kruse via cfe-commits
@@ -5237,8 +5237,8 @@ width/count of the set of target architectures supported by your application. ... } -Specifying a width/count of 1 disables the optimization, and is equivalent to -``vectorize(disable)`` or ``interleave(disable)``. Meinersbur wrote

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-23 Thread Ryotaro Kasuga via cfe-commits
@@ -5237,8 +5237,8 @@ width/count of the set of target architectures supported by your application. ... } -Specifying a width/count of 1 disables the optimization, and is equivalent to -``vectorize(disable)`` or ``interleave(disable)``. +Specifying a *non-scalable* widt

[clang] [CIR] Create CIR_TypedAttr common class (PR #136852)

2025-04-23 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/136852 Introduce common base class for attributes with single type parameter. This mirrors incubator changes introduced in https://github.com/llvm/clangir/pull/1583 >From 4dc6ea34144040e52ce5818baab39180ec257616 Mon Se

[clang] [CIR] Create CIR_TypedAttr common class (PR #136852)

2025-04-23 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/136852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Create CIR_TypedAttr common class (PR #136852)

2025-04-23 Thread Henrich Lauko via cfe-commits
xlauko wrote: * **#136852** https://app.graphite.dev/github/pr/llvm/llvm-project/136852?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13685

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-23 Thread Michael Kruse via cfe-commits
@@ -122,35 +130,41 @@ else() get_clang_resource_dir(LIBOMP_HEADERS_INSTALL_PATH SUBDIR include) endif() -# Build host runtime library, after LIBOMPTARGET variables are set since they are needed -# to enable time profiling support in the OpenMP runtime. -add_subdirectory(run

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-23 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur commented: I think using the LLVM_ENABLE_RUNTIMES-machanism is a great idea. Regarding the move back to `openmp/device`, I don't really have an opinion. However, there are some arguments to make: 1. The same arguments apply to `libomptarget` as well 2. Definitions

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-23 Thread Michael Kruse via cfe-commits
@@ -113,6 +113,13 @@ else() set(CMAKE_CXX_EXTENSIONS NO) endif() +# Emit a warning for people who haven't updated their build. +if(NOT "openmp" IN_LIST RUNTIMES_amdgcn-amd-amdhsa_LLVM_ENABLE_RUNTIMES AND + NOT "openmp" IN_LIST RUNTIMES_nvptx64-nvidia-cuda_LLVM_ENABLE_RUNTI

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-23 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/136729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Andes A45/AX45 processor definition (PR #136832)

2025-04-23 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/136832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-04-23 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/lib/Sema/TreeTransform.h clang/test/Parser/cx

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-04-23 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/136836 We made chained comparisons an error. Fold-expressions over a comparison operator produce chained comparisons, so we should be consistent there too. We only emit the warning when instantiating the fold express

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-23 Thread Michał Górny via cfe-commits
mgorny wrote: Honestly, I am thoroughly confused about all that openmp ↔ offload moving. But if these don't share much code with the current `openmp`, perhaps the cleanest approach would be to make it entirely separate? https://github.com/llvm/llvm-project/pull/136729

[clang] [clang] Adding an API to create a `CXStringSet` from a Vector of `StringRef`s (PR #136773)

2025-04-23 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu updated https://github.com/llvm/llvm-project/pull/136773 >From 7f39ebcc34fe3f40c2554ff7fa93baca5b4634a0 Mon Sep 17 00:00:00 2001 From: Qiongsi Wu Date: Tue, 22 Apr 2025 14:17:15 -0700 Subject: [PATCH 1/4] Adding CXStringSet *createSet that takes a vector of StringR

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-23 Thread Aaron Ballman via cfe-commits
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN) set(bolt_doxygen_qhp_cust_filter_attrs "") endif() - option(LLVM_DOXYGEN_SVG AaronBallman wrote: Will removing the option be disruptive (particularly to downstreams)? Do we need a deprecation period before w

[clang] [HLSL] Put tests for compatibility overloads for 'clamp', 'isinf', 'min', and 'max' in own files (PR #137004)

2025-04-23 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/137004 Put tests for compatibility overloads for 'clamp', 'isinf', 'min', and 'max' in own files which guarantee hlsl version 202x. Closes #133277 >From d0051512fc864c250a3734ac4df0ba09072669ef Mon Sep 17 00:00:00 2001

[clang] [HLSL] Put tests for compatibility overloads for 'clamp', 'isinf', 'min', and 'max' in own files (PR #137004)

2025-04-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sarah Spall (spall) Changes Put tests for compatibility overloads for 'clamp', 'isinf', 'min', and 'max' in own files which guarantee hlsl version 202x. Closes #133277 --- Patch is 30.88 KiB, truncated to 20.00 KiB below, full version:

[clang] [HLSL] Put tests for compatibility overloads for 'clamp', 'isinf', 'min', and 'max' in own files (PR #137004)

2025-04-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Sarah Spall (spall) Changes Put tests for compatibility overloads for 'clamp', 'isinf', 'min', and 'max' in own files which guarantee hlsl version 202x. Closes #133277 --- Patch is 30.88 KiB, truncated to 20.00 KiB below, full version:

[clang] [clang][ptrauth] add support for options parameter to __ptrauth (PR #136828)

2025-04-23 Thread Oliver Hunt via cfe-commits
@@ -8374,20 +8376,212 @@ static void HandlePtrAuthQualifier(ASTContext &Ctx, QualType &T, IsInvalid |= !S.checkPointerAuthDiscriminatorArg( ExtraDiscriminatorArg, Sema::PADAK_ExtraDiscPtrAuth, ExtraDiscriminator); - if (IsInvalid) { -Attr.setInvalid(); -retur

[clang] 71ce9e2 - Control analysis-based diagnostics with #pragma (#136323)

2025-04-23 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-04-23T06:55:10-04:00 New Revision: 71ce9e26aec00e4af27a69ccfab8ca1773ed7018 URL: https://github.com/llvm/llvm-project/commit/71ce9e26aec00e4af27a69ccfab8ca1773ed7018 DIFF: https://github.com/llvm/llvm-project/commit/71ce9e26aec00e4af27a69ccfab8ca1773ed7018.diff

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-04-23 Thread via cfe-commits
@@ -8058,6 +8059,54 @@ bool Sema::CheckNonDependentConversions( } } + // A heuristic & speculative workaround for bug + // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99599 that manifests after + // CWG2369. cor3ntin wrote: I think that we should si

[clang] Control analysis-based diagnostics with #pragma (PR #136323)

2025-04-23 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/136323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Pengcheng Wang (wangpc-pp) Changes This matches GCC and we supported it in LLVM 17/18. Fixes #136803 --- Full diff: https://github.com/llvm/llvm-project/pull/136842.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-23 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/136843 Despite our attempt (build-docs.sh) to build the documentation with SVG, it still uses PNG https://llvm.org/doxygen/classllvm_1_1StringRef.html, and that renders terribly on any high dpi display. SVG leads to

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Despite our attempt (build-docs.sh) to build the documentation with SVG, it still uses PNG https://llvm.org/doxygen/classllvm_1_1StringRef.html, and that renders terribly on any high dpi display. SVG leads to s

[libclc] [libclc] Build for OpenCL 3.0 and enable all extensions and features (PR #135733)

2025-04-23 Thread Wenju He via cfe-commits
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/135733 >From 64d7bfdceb5a0a6fbf34bb15cd7d6cbeb9214881 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Mon, 14 Apr 2025 19:20:25 -0700 Subject: [PATCH 1/6] [libclc] Set OpenCL version to 3.0 This PR is cherry-pick of ht

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-04-23 Thread Younan Zhang via cfe-commits
@@ -8058,6 +8059,54 @@ bool Sema::CheckNonDependentConversions( } } + // A heuristic & speculative workaround for bug + // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99599 that manifests after + // CWG2369. zyn0217 wrote: Yes, I'll look into that;

[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

2025-04-23 Thread Balázs Benics via cfe-commits
@@ -0,0 +1,198 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify=expected,default %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config legacy-inlining-prevention=false -verify=expected,disabled %s + +int get

[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

2025-04-23 Thread Balázs Benics via cfe-commits
@@ -2856,8 +2873,29 @@ void ExprEngine::processBranch( // conflicts with the widen-loop analysis option (which is off by // default). If we intend to support and stabilize the loop widening, // we must ensure that it 'plays nicely' with this logic. - if (

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-04-23 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/136836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Fix condition in combineBackendCompile when using -no-integrated-cpp (PR #136853)

2025-04-23 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/136853 When using -no-integrated-cpp, before, the driver won't collapse actions when the input was not llvm-ir or it would collapse them too aggressively with -save-temps The original code was checking the action t

[clang] Reland [clang] Handle instantiated members to determine visibility (#136128) (PR #136689)

2025-04-23 Thread Erich Keane via cfe-commits
@@ -4787,8 +4787,10 @@ LinkageInfo LinkageComputer::computeTypeLinkageInfo(const Type *T) { return computeTypeLinkageInfo(cast(T)->getPointeeType()); case Type::MemberPointer: { const auto *MPT = cast(T); -LinkageInfo LV = -getDeclLinkageAndVisibility(MPT

[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

2025-04-23 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/136720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add check 'bugprone-invalid-enum-default-initialization' (PR #136823)

2025-04-23 Thread via cfe-commits
https://github.com/EugeneZelenko edited https://github.com/llvm/llvm-project/pull/136823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Re-enable compiler warning (PR #136872)

2025-04-23 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/136872 libclc is now clean of code that triggers the bitwise-conditional-parentheses warning, so we can finally remove the workaround. >From 1811e6ee0fb4c3af60a245418816b1e5a63163b2 Mon Sep 17 00:00:00 2001 From:

[libclc] [libclc] Fix unguarded use of image types (PR #136871)

2025-04-23 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: CC @wenju-he https://github.com/llvm/llvm-project/pull/136871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix unguarded use of image types (PR #136871)

2025-04-23 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/136871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Re-enable compiler warning (PR #136872)

2025-04-23 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/136872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

2025-04-23 Thread Donát Nagy via cfe-commits
@@ -81,10 +81,6 @@ class FunctionSummariesTy { I->second.MayInline = 0; } - void markReachedMaxBlockCount(const Decl *D) { -markShouldNotInline(D); - } NagyDonat wrote: I agree that it's OK to write code like ```c++ if () markReachedConditionX(A

[clang-tools-extra] [clang-tidy] Add check 'bugprone-invalid-enum-default-initialization' (PR #136823)

2025-04-23 Thread via cfe-commits
@@ -0,0 +1,114 @@ +//===--- InvalidEnumDefaultInitializationCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add check 'bugprone-invalid-enum-default-initialization' (PR #136823)

2025-04-23 Thread via cfe-commits
@@ -0,0 +1,50 @@ +.. title:: clang-tidy - bugprone-invalid-enum-default-initialization + +bugprone-invalid-enum-default-initialization + + +Detect default initialization (to 0) of variables with `enum` type where EugeneZ

[clang-tools-extra] [clang-tidy] Add check 'bugprone-invalid-enum-default-initialization' (PR #136823)

2025-04-23 Thread via cfe-commits
https://github.com/EugeneZelenko commented: Please add Release Notes entry. https://github.com/llvm/llvm-project/pull/136823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix unguarded use of image types (PR #136871)

2025-04-23 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/136871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] 806d59e - [libclc] Fix unguarded use of image types (#136871)

2025-04-23 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-04-23T15:54:48+01:00 New Revision: 806d59eecd16dc35473638fd73ea0be8e59c6275 URL: https://github.com/llvm/llvm-project/commit/806d59eecd16dc35473638fd73ea0be8e59c6275 DIFF: https://github.com/llvm/llvm-project/commit/806d59eecd16dc35473638fd73ea0be8e59c6275.diff

[clang] [AArch64] Update __gcsss intrinsic to match revised ACLE specification (PR #136850)

2025-04-23 Thread via cfe-commits
https://github.com/sivan-shani updated https://github.com/llvm/llvm-project/pull/136850 >From a3cc71ef731e08d9e0963db767e190a231f75260 Mon Sep 17 00:00:00 2001 From: Sivan Shani Date: Wed, 23 Apr 2025 12:39:05 +0100 Subject: [PATCH] [AArch64] Update __gcsss intrinsic to match revised ACLE spec

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-04-23 Thread via cfe-commits
@@ -7138,6 +7138,11 @@ def warn_consecutive_comparison : Warning< "chained comparison 'X %0 Y %1 Z' does not behave the same as a mathematical expression">, InGroup, DefaultError; +def warn_comparison_in_fold_expression : Warning< + "comparison in fold expression would e

[libclc] [libclc] Build for OpenCL 3.0 (PR #135733)

2025-04-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-windows` running on `premerge-windows-1` while building `libclc` at step 5 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/9454 Here is the relevant p

[libclc] [libclc] Re-enable compiler warning (PR #136872)

2025-04-23 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/136872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] 6c56160 - [libclc] Re-enable compiler warning (#136872)

2025-04-23 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-04-23T15:59:15+01:00 New Revision: 6c561604336497cbeebc90f9066a9f474458a38d URL: https://github.com/llvm/llvm-project/commit/6c561604336497cbeebc90f9066a9f474458a38d DIFF: https://github.com/llvm/llvm-project/commit/6c561604336497cbeebc90f9066a9f474458a38d.diff

[clang] Control analysis-based diagnostics with #pragma (PR #136323)

2025-04-23 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > FYI this introduces some overhead: > > https://llvm-compile-time-tracker.com/compare.php?from=2a9f77f6bd48d757b2d45aadcb6cf76ef4b4ef32&to=71ce9e26aec00e4af27a69ccfab8ca1773ed7018&stat=instructions:u > > About 0.3% on clang files. > > Thank you for the notification! Shoo

[clang] [libclang/C++] Fix clang_File_isEqual for in-memory files (PR #135773)

2025-04-23 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you for the fix! https://github.com/llvm/llvm-project/pull/135773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[libclc] 8292e05 - [libclc] Build for OpenCL 3.0 (#135733)

2025-04-23 Thread via cfe-commits
Author: Wenju He Date: 2025-04-23T13:15:47+01:00 New Revision: 8292e050e62f69ae9aea68fafd011152eede7e4d URL: https://github.com/llvm/llvm-project/commit/8292e050e62f69ae9aea68fafd011152eede7e4d DIFF: https://github.com/llvm/llvm-project/commit/8292e050e62f69ae9aea68fafd011152eede7e4d.diff LOG:

[clang] [llvm] [Clang][llvm] Implement fp8 FMOP4A intrinsics (PR #130127)

2025-04-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang,llvm` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16500 Here is the relevant piece o

[libclc] [libclc] Build for OpenCL 3.0 (PR #135733)

2025-04-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `libclc` at step 6 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/29653 Here is the relevant

[clang-tools-extra] [clang-tidy] Add check 'bugprone-invalid-enum-default-initialization' (PR #136823)

2025-04-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: I wonder if behavior of this check should be an extension to [optin.core.EnumCastOutOfRange](https://clang.llvm.org/docs/analyzer/checkers.html#optin-core-enumcastoutofrange). Sure, we don't have `static_cast` here but it's still considered as "cast out of range"? https://gith

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-04-23 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/136836 >From 8d70f4bb100ad0dec57947ce0999a7f837d2646e Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 23 Apr 2025 11:50:10 +0200 Subject: [PATCH 1/2] [Clang] Warning as error for fold expressions over compar

[clang] [Clang][AArch64] Add fp8 variants for untyped NEON intrinsics (PR #128019)

2025-04-23 Thread via cfe-commits
Lukacma wrote: > For my education can you explain why the fp8 variants are broken out into > their own definitions. Taking VREV64_MF8 as an example, it looks like you > should be able to add the new type strings to the current definition? That's a good question. Its been a while since I implem

[libclc] [libclc] Build for OpenCL 3.0 (PR #135733)

2025-04-23 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. https://github.com/llvm/llvm-project/pull/135733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move fmin & fmax to CLC library (PR #134218)

2025-04-23 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: ping https://github.com/llvm/llvm-project/pull/134218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

2025-04-23 Thread Juan Manuel Martinez Caamaño via cfe-commits
@@ -0,0 +1,35 @@ +// libstdc++ uses the non-constexpr function std::__glibcxx_assert_fail() +// to trigger compilation errors when the __glibcxx_assert(cond) macro +// is used in a constexpr context. +// Compilation fails when using code from the libstdc++ (such as std::array) on

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-23 Thread Ryotaro Kasuga via cfe-commits
kasuga-fj wrote: > Unfortuantely IIRC there is a semantic difference between pragma and metadata: > >- llvm.loop.vectorize.enable==false disables vectorization AND > interleaving (by switching off the entire LoopVectorize pass which does both > of thise things) >- llvm.loop.vectorize.wi

[clang] [clang][SPIR-V] Addrspace of opencl_global should always be 1 (PR #136753)

2025-04-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nick Sarnie (sarnex) Changes This fixes a CUDA SPIR-V regression introduced in https://github.com/llvm/llvm-project/pull/134399. --- Full diff: https://github.com/llvm/llvm-project/pull/136753.diff 2 Files Affected: - (modified) clang

[clang] [clang][SPIR-V] Addrspace of opencl_global should always be 1 (PR #136753)

2025-04-23 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/136753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland [clang] Handle instantiated members to determine visibility (#136128) (PR #136689)

2025-04-23 Thread Andrew Savonichev via cfe-commits
@@ -4787,8 +4787,10 @@ LinkageInfo LinkageComputer::computeTypeLinkageInfo(const Type *T) { return computeTypeLinkageInfo(cast(T)->getPointeeType()); case Type::MemberPointer: { const auto *MPT = cast(T); -LinkageInfo LV = -getDeclLinkageAndVisibility(MPT

[clang] [clang-format] Correctly identify include guards (PR #137112)

2025-04-23 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/137112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >