[clang] [Clang] disallow use of attributes before extern template declarations (PR #136328)

2025-04-21 Thread Aaron Ballman via cfe-commits
@@ -1049,6 +1049,7 @@ Parser::ParseExternalDeclaration(ParsedAttributes &Attrs, case tok::kw_extern: if (getLangOpts().CPlusPlus && NextToken().is(tok::kw_template)) { + ProhibitAttributes(Attrs); AaronBallman wrote: Thanks! So yeah. we're agreed,

[clang] [CLANG] Enable alignas after GNU attributes (PR #133107)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -24,7 +24,7 @@ int templateFunction(T value) __attribute__((annotate("works"))); // CHECK: ClassDecl=Test:3:7 (Definition) Extent=[3:1 - 17:2] // CHECK-NEXT: CXXAccessSpecifier=:4:1 (Definition) Extent=[4:1 - 4:8] -// CHECK-NEXT: CXXMethod=aMethod:5:51 Extent=[5:3 - 5:60]

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -654,6 +654,25 @@ cir::VectorType::getABIAlignment(const ::mlir::DataLayout &dataLayout, return llvm::NextPowerOf2(dataLayout.getTypeSizeInBits(*this)); } +mlir::LogicalResult cir::VectorType::verify( +llvm::function_ref emitError, +mlir::Type eltType, uint64_t s

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -654,6 +654,25 @@ cir::VectorType::getABIAlignment(const ::mlir::DataLayout &dataLayout, return llvm::NextPowerOf2(dataLayout.getTypeSizeInBits(*this)); } +mlir::LogicalResult cir::VectorType::verify( +llvm::function_ref emitError, +mlir::Type eltType, uint64_t s

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/13451 Here is the relevant

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/29445 Here is

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/23949 Here is the rel

[clang] [llvm] [RISCV] Add Andes XAndesperf (Andes Performance) extension. (PR #135110)

2025-04-21 Thread Craig Topper via cfe-commits
@@ -0,0 +1,56 @@ +# XAndesPerf - Andes Performance Extension +# RUN: not llvm-mc -triple riscv32 -mattr=+xandesperf < %s 2>&1 \ +# RUN: | FileCheck %s +# RUN: not llvm-mc -triple riscv64 -mattr=+xandesperf < %s 2>&1 \ +# RUN: | FileCheck %s -check-prefix=CHECK-64 + +# Out

[clang] [Clang] Fix crash when -header-include-filtering is not specified (PR #136232)

2025-04-21 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I think so. Even if this gets diagnosed more clearly by the driver, users can bypass that using `-Xclang`. Even for me as a Clang developer this message would be confusing, especially in more complex scenarios (e.g. with response files involved). https://github.com/llvm/ll

[clang] [clang] Do not share ownership of `HeaderSearchOptions` (PR #132984)

2025-04-21 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I'm going to land this later this week unless tagged people have objections. https://github.com/llvm/llvm-project/pull/132984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] 5133b43 - Enable `-m32`, `-maix32` and `-maix64` for Flang on AIX. (#136202)

2025-04-21 Thread via cfe-commits
Author: Daniel Chen Date: 2025-04-21T12:05:48-04:00 New Revision: 5133b432bc89f66547f6aab9a935f0a29f3b4572 URL: https://github.com/llvm/llvm-project/commit/5133b432bc89f66547f6aab9a935f0a29f3b4572 DIFF: https://github.com/llvm/llvm-project/commit/5133b432bc89f66547f6aab9a935f0a29f3b4572.diff L

[clang] [flang] Enable `-m32`, `-maix32` and `-maix64` for Flang on AIX. (PR #136202)

2025-04-21 Thread Daniel Chen via cfe-commits
https://github.com/DanielCChen closed https://github.com/llvm/llvm-project/pull/136202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tide] added `AllowedTypes` option to `readability-qualified-auto` check (PR #136571)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) Changes Added `AllowedTypes` option to `readability-qualified-auto` check Fixes https://github.com/llvm/llvm-project/issues/63461. --- Full diff: https://github.com/llvm/llvm-project/pull/136571.diff

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread Sarah Spall via cfe-commits
https://github.com/spall closed https://github.com/llvm/llvm-project/pull/134174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/25265 Here is the r

[clang] Revert "[Fuchsia] Disable PIC" (PR #136617)

2025-04-21 Thread via cfe-commits
https://github.com/gulfemsavrun created https://github.com/llvm/llvm-project/pull/136617 Reverts llvm/llvm-project#136376 because it broke Fuchsia Clang toolchain builders. >From 61475ffa75fd202f8cd3d3ffdf547919b9f13f0d Mon Sep 17 00:00:00 2001 From: gulfemsavrun Date: Mon, 21 Apr 2025 14:33:

[clang] a27f7ac - Revert "[Fuchsia] Disable PIC" (#136617)

2025-04-21 Thread via cfe-commits
Author: gulfemsavrun Date: 2025-04-21T14:34:43-07:00 New Revision: a27f7ac5c4e44b495f52e8d77b68a164dd833fda URL: https://github.com/llvm/llvm-project/commit/a27f7ac5c4e44b495f52e8d77b68a164dd833fda DIFF: https://github.com/llvm/llvm-project/commit/a27f7ac5c4e44b495f52e8d77b68a164dd833fda.diff

[clang] Revert "[Fuchsia] Disable PIC" (PR #136617)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (gulfemsavrun) Changes Reverts llvm/llvm-project#136376 because it broke Fuchsia Clang toolchain builders. --- Full diff: https://github.com/llvm/llvm-project/pull/136617.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuch

[clang] Revert "[Fuchsia] Disable PIC" (PR #136617)

2025-04-21 Thread via cfe-commits
https://github.com/gulfemsavrun closed https://github.com/llvm/llvm-project/pull/136617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/136383 >From 17800eddb70a74cf3966d64ab7bc5ad5508f8bb0 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Fri, 18 Apr 2025 15:02:22 -0700 Subject: [PATCH 1/2] [CIR] Upstream support for accessing structure members Thi

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp,h -- clang/include/clang/CIR/Dialect/Builder/CIRBaseBu

[clang] Revert "[Fuchsia] Disable PIC" (PR #136617)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16394 Here is the relevant piece of the

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread John McCall via cfe-commits
rjmccall wrote: It's fine to make these operators look up and use the `size_t` / `ptrdiff_t` typedefs if they're available and have the right type. We would need to apply an allowlist to the attributes on the typedef, too — it would be quite abusive, but someone could use an `aligned` attribut

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/136383 >From 17800eddb70a74cf3966d64ab7bc5ad5508f8bb0 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Fri, 18 Apr 2025 15:02:22 -0700 Subject: [PATCH 1/3] [CIR] Upstream support for accessing structure members Thi

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Richard Smith via cfe-commits
zygoloid wrote: Another possibility would be to add a new kind of type sugar for these cases that has the same canonical type but knows that it should print as `size_t` / `ptrdiff_t` etc. That'd allow you to produce an identical AST regardless of whether the typedefs are included, which seems

[clang] [CLANG][MS-STRUCT] bitfield padding warning presents padding to exact bit count (PR #136062)

2025-04-21 Thread Theo de Magalhaes via cfe-commits
=?utf-8?q?Théo?= de Magalhaes Message-ID: In-Reply-To: https://github.com/theomagellan updated https://github.com/llvm/llvm-project/pull/136062 >From 842f0fbed0043ad0aa1679d8a30bc13d64eb25cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20de=20Magalhaes?= Date: Thu, 17 Apr 2025 01:45:12

[clang] de0153d - [clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms (#128222)

2025-04-21 Thread via cfe-commits
Author: Nick Sarnie Date: 2025-04-21T22:09:49Z New Revision: de0153da325b21340747d8a064906a8c1c2f95ea URL: https://github.com/llvm/llvm-project/commit/de0153da325b21340747d8a064906a8c1c2f95ea DIFF: https://github.com/llvm/llvm-project/commit/de0153da325b21340747d8a064906a8c1c2f95ea.diff LOG: [

[clang] [clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms (PR #128222)

2025-04-21 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/128222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms (PR #128222)

2025-04-21 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/128222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Amr Hesham via cfe-commits
@@ -1419,6 +1419,48 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
https://github.com/YexuanXiao updated https://github.com/llvm/llvm-project/pull/136542 >From b9cc91971469dcf19bb926f6f53ae5a57d1109c3 Mon Sep 17 00:00:00 2001 From: YexuanXiao Date: Mon, 21 Apr 2025 14:28:33 +0800 Subject: [PATCH 1/6] [Clang] Make the result type of sizeof/pointer subtraction/

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
https://github.com/YexuanXiao updated https://github.com/llvm/llvm-project/pull/136542 >From b9cc91971469dcf19bb926f6f53ae5a57d1109c3 Mon Sep 17 00:00:00 2001 From: YexuanXiao Date: Mon, 21 Apr 2025 14:28:33 +0800 Subject: [PATCH 1/7] [Clang] Make the result type of sizeof/pointer subtraction/

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
YexuanXiao wrote: > Thank you for this! > > I'd like to better understand the need for the changes because I have a few > concerns. One concern is about compile time performance. But also, this means > downstream consumers of the AST are going to have to react because they used > to be able t

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-21 Thread Aaron Ballman via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: AaronBallman wrote: > IMO this kind of flag requires an RFC. +1, this sort of extension requires an RFC. Please be sure to mention how the RFC addresses our [usual criteria](https://clang.llvm.org/get_involve

[clang] [Clang] disallow use of attributes before extern template declarations (PR #136328)

2025-04-21 Thread Aaron Ballman via cfe-commits
@@ -1049,6 +1049,7 @@ Parser::ParseExternalDeclaration(ParsedAttributes &Attrs, case tok::kw_extern: if (getLangOpts().CPlusPlus && NextToken().is(tok::kw_template)) { + ProhibitAttributes(Attrs); AaronBallman wrote: I think it's reasonable to reje

[clang] [clang][driver] Suppress gnu-line-marker when saving temps (PR #134621)

2025-04-21 Thread via cfe-commits
https://github.com/macurtis-amd updated https://github.com/llvm/llvm-project/pull/134621 >From 9d38a08bc91273d961fa1bd855d212b09249d826 Mon Sep 17 00:00:00 2001 From: Matthew Curtis Date: Fri, 18 Apr 2025 12:46:23 -0500 Subject: [PATCH 1/2] [clang] Suppress gnu-line-marker when saving temps Wh

[clang] [clang][driver] Suppress gnu-line-marker when saving temps (PR #134621)

2025-04-21 Thread via cfe-commits
@@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -std=c99 -fsyntax-only -pedantic %s 2>&1 | grep 'warning: this style of line directive is a GNU extension' macurtis-amd wrote: Updated test to use FileCheck. https://github.com/llvm/llvm-project/pull/134621 __

[clang] [flang] Enable `-m32`, `-maix32` and `-maix64` for Flang on AIX. (PR #136202)

2025-04-21 Thread Kelvin Li via cfe-commits
https://github.com/kkwli approved this pull request. LG https://github.com/llvm/llvm-project/pull/136202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > Thank you for this! > > > I'd like to better understand the need for the changes because I have a > > > few concerns. One concern is about compile time performance. But also, > > > this means downstream consumers of the AST are going to have to react > > > because the

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot11` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/10195 Here is the re

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Hi, this turned a few bots red. Can this be fixed forward or should we revert in the meantime? Let me know if you need help with the bot setup / build config. Thanks! https://github.com/llvm/llvm-project/pull/134174 ___ cfe-commits mailin

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread Sarah Spall via cfe-commits
spall wrote: > Hi, this turned a few bots red. Can this be fixed forward or should we revert > in the meantime? Let me know if you need help with the bot setup / build > config. Thanks! It can be reverted https://github.com/llvm/llvm-project/pull/134174 ___

[clang] f0a59c4 - Revert "[HLSL] Make it possible to assign an array from a cbuffer" (#136576)

2025-04-21 Thread via cfe-commits
Author: Sarah Spall Date: 2025-04-21T09:29:22-07:00 New Revision: f0a59c49aaa951a25bea57cf753a8eb1735fd810 URL: https://github.com/llvm/llvm-project/commit/f0a59c49aaa951a25bea57cf753a8eb1735fd810 DIFF: https://github.com/llvm/llvm-project/commit/f0a59c49aaa951a25bea57cf753a8eb1735fd810.diff L

[clang] Revert "[HLSL] Make it possible to assign an array from a cbuffer" (PR #136576)

2025-04-21 Thread Sarah Spall via cfe-commits
https://github.com/spall closed https://github.com/llvm/llvm-project/pull/136576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[HLSL] Make it possible to assign an array from a cbuffer" (PR #136576)

2025-04-21 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/136576 Reverts llvm/llvm-project#134174 Revert due to test error breaking a lot of bots. >From e35cf35feff443c6dd9fbc0b5ab00efa8e282fa0 Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Mon, 21 Apr 2025 09:27:45 -0700 Su

[clang] Revert "[HLSL] Make it possible to assign an array from a cbuffer" (PR #136576)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Sarah Spall (spall) Changes Reverts llvm/llvm-project#134174 Revert due to test error breaking a lot of bots. --- Full diff: https://github.com/llvm/llvm-project/pull/136576.diff 3 Files Affected: - (modified) clang/lib/Sema/SemaExprCXX.

[clang] [clang] Enable making `CompilerInstance` VFS thread-safe (PR #135737)

2025-04-21 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Ping. https://github.com/llvm/llvm-project/pull/135737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-ubsan` running on `sanitizer-buildbot9` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/85/builds/7901 Here is the relev

[clang] [llvm] [RISCV] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread Craig Topper via cfe-commits
@@ -183,6 +183,8 @@ def FeatureStdExtZilsd def HasStdExtZilsd : Predicate<"Subtarget->hasStdExtZilsd()">, AssemblerPredicate<(all_of FeatureStdExtZilsd), "'Zilsd' (Load/Store pair instructions)">; +def FeatureStd

[clang] [llvm] [RISCV] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread Craig Topper via cfe-commits
@@ -482,6 +482,14 @@ def : SysReg<"sctrdepth", 0x15f>; def : SysReg<"vsctrctl", 0x24e>; def : SysReg<"mctrctl", 0x34e>; +//===--- +// Cycle and Instret privilege mode filtering (Smcntrpmf) topperc wrote: Capitalize

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -1419,6 +1419,48 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] 0900661 - [clang] Enable making `CompilerInstance` VFS thread-safe (#135737)

2025-04-21 Thread via cfe-commits
Author: Jan Svoboda Date: 2025-04-21T11:09:23-07:00 New Revision: 09006611151c7f85862a9da8da34872c456c2c37 URL: https://github.com/llvm/llvm-project/commit/09006611151c7f85862a9da8da34872c456c2c37 DIFF: https://github.com/llvm/llvm-project/commit/09006611151c7f85862a9da8da34872c456c2c37.diff L

[clang] [clang] Enable making `CompilerInstance` VFS thread-safe (PR #135737)

2025-04-21 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/135737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136426 >From 91a6937c7b937daceef426c877703d4d0cfeae76 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 14:22:45 +0200 Subject: [PATCH 1/3] [CIR] Upstream StackSave and StackRestoreOp --- clang/

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix AS of globals and set the default AS to 4 (PR #135251)

2025-04-21 Thread Nick Sarnie via cfe-commits
sarnex wrote: @jhuber6 @AlexVlx Ping again on this one, it also fixes a regression in CUDA SPIRV, thanks! https://github.com/llvm/llvm-project/pull/135251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix addrspace of global constants (PR #134399)

2025-04-21 Thread Nick Sarnie via cfe-commits
sarnex wrote: This will be fixed by my existing PR https://github.com/llvm/llvm-project/pull/135251 I will add that test case and add you guys as reviewers, thanks and sorry for the trouble. https://github.com/llvm/llvm-project/pull/134399 ___ cfe-c

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix AS of globals and set the default AS to 4 (PR #135251)

2025-04-21 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/135251 >From 675dde092c16a779d858f6082d0aab19acae3a1e Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 9 Apr 2025 08:42:49 -0700 Subject: [PATCH 1/2] [clang][OpenMP][SPIR-V] Fix addrspace of globals Signed-off-

[clang] [CIR][NFC] Fix an unused variable warning (PR #136431)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes closed https://github.com/llvm/llvm-project/pull/136431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. The PR looks good overall, it adds the operation, tests for parsing/printing + LLVM lowering, leaving CIRGen to support to be done incrementally. LGTM once the operation names are used consistently. https://github.com/llvm/llvm-proje

[clang] [CIR][NFC] Fix an unused variable warning (PR #136431)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/136431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0ae9dac - [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (#136578)

2025-04-21 Thread via cfe-commits
Author: Erich Keane Date: 2025-04-21T11:51:26-07:00 New Revision: 0ae9dac262afccea1e1a2e02520f737ab38b286c URL: https://github.com/llvm/llvm-project/commit/0ae9dac262afccea1e1a2e02520f737ab38b286c DIFF: https://github.com/llvm/llvm-project/commit/0ae9dac262afccea1e1a2e02520f737ab38b286c.diff L

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/136578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/136578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. This looks good. I had one question about something that made me nervous but is probably OK, and a nit that isn't really related to this PR. https://github.com/llvm/llvm-project/pull/136578 ___

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -109,14 +126,15 @@ class OpenACCClauseCIREmitter final } void VisitDeviceTypeClause(const OpenACCDeviceTypeClause &clause) { +lastDeviceTypeClause = &clause; andykaylor wrote: What's the lifetime of this object? Who owns it? https://github.com/llv

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -109,14 +126,15 @@ class OpenACCClauseCIREmitter final } void VisitDeviceTypeClause(const OpenACCDeviceTypeClause &clause) { +lastDeviceTypeClause = &clause; if constexpr (isOneOfTypes) { llvm::SmallVector deviceTypes; std::optional existingDevice

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136488 >From 5d07a639dc6c933f6f171e501e4ec20d731553e3 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject: [PATCH 1/4] [CIR] Upstream initial support for fixed size VectorType

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -109,14 +126,15 @@ class OpenACCClauseCIREmitter final } void VisitDeviceTypeClause(const OpenACCDeviceTypeClause &clause) { +lastDeviceTypeClause = &clause; erichkeane wrote: Its owned by the AST, so its lifetime lasts until the AST is destroyed,

[clang] [CIR] Introduce type aliases for records (PR #136387)

2025-04-21 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > ALSO, I see no tests that contain `ty_anon`, can you write some? We don't actually generate anon records (either upstream or in the incubator). I think we should just make them illegal. Anonymous structs in the source are given a name in CIR (`anon.`) https://github.com/ll

[clang] 846986f - [Fuchsia] Disable PIC (#136376)

2025-04-21 Thread via cfe-commits
Author: Petr Hosek Date: 2025-04-21T11:04:47-07:00 New Revision: 846986f35b5a7baa498db7c61ae15dd9b2dee797 URL: https://github.com/llvm/llvm-project/commit/846986f35b5a7baa498db7c61ae15dd9b2dee797 DIFF: https://github.com/llvm/llvm-project/commit/846986f35b5a7baa498db7c61ae15dd9b2dee797.diff LO

[clang] [Fuchsia] Disable PIC (PR #136376)

2025-04-21 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/136376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/136578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Boolean in a RawBuffer should be i32 and Boolean vector in a RawBuffer should be (PR #135848)

2025-04-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/135848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -530,7 +567,7 @@ def CIRRecordType : Type< //===--===// def CIR_AnyType : AnyTypeOf<[ - CIR_VoidType, CIR_BoolType, CIR_ArrayType, CIR_IntType, CIR_AnyFloat, + CIR_VoidType, CIR_BoolType, CIR_ArrayType,

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -637,6 +637,41 @@ ArrayType::getABIAlignment(const ::mlir::DataLayout &dataLayout, return dataLayout.getTypeABIAlignment(getEltType()); } +//===--===// +// VectorType Definitions +//===--

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -307,6 +307,26 @@ def CIR_ArrayType : CIR_Type<"Array", "array", }]; } +//===--===// +// VectorType (fixed size) +//===--===// + +def CI

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -307,6 +307,26 @@ def CIR_ArrayType : CIR_Type<"Array", "array", }]; } +//===--===// +// VectorType (fixed size) +//===--===// + +def CI

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/136488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136488 >From 5d07a639dc6c933f6f171e501e4ec20d731553e3 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject: [PATCH 1/5] [CIR] Upstream initial support for fixed size VectorType

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136488 >From 5d07a639dc6c933f6f171e501e4ec20d731553e3 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject: [PATCH 1/6] [CIR] Upstream initial support for fixed size VectorType

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -309,6 +309,37 @@ RecordType::computeStructAlignment(const mlir::DataLayout &dataLayout) const { return recordAlignment; } +uint64_t RecordType::getElementOffset(const ::mlir::DataLayout &dataLayout, + unsigned idx) const { + assert(

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-21 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/136436 From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 20 Apr 2025 00:24:46 +0200 Subject: [PATCH 1/4] [clang] add -fimplicit-constexpr

[clang] [Fuchsia] Disable PIC (PR #136376)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/8393 Here is the releva

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -109,14 +126,15 @@ class OpenACCClauseCIREmitter final } void VisitDeviceTypeClause(const OpenACCDeviceTypeClause &clause) { +lastDeviceTypeClause = &clause; if constexpr (isOneOfTypes) { llvm::SmallVector deviceTypes; std::optional existingDevice

[clang] 4b98955 - Fix capitalization re review from 0ae9dac

2025-04-21 Thread via cfe-commits
Author: erichkeane Date: 2025-04-21T11:58:53-07:00 New Revision: 4b98955680e0aad33cad0e810f1daaa8bc7c0a23 URL: https://github.com/llvm/llvm-project/commit/4b98955680e0aad33cad0e810f1daaa8bc7c0a23 DIFF: https://github.com/llvm/llvm-project/commit/4b98955680e0aad33cad0e810f1daaa8bc7c0a23.diff LO

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -309,6 +309,37 @@ RecordType::computeStructAlignment(const mlir::DataLayout &dataLayout) const { return recordAlignment; } +uint64_t RecordType::getElementOffset(const ::mlir::DataLayout &dataLayout, + unsigned idx) const { + assert(

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-21 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: Sirraide wrote: An RFC has been posted on Discourse: https://discourse.llvm.org/t/rfc-fimplicit-constexpr/85963 https://github.com/llvm/llvm-project/pull/136436 __

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -1419,6 +1419,50 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp andykaylor wrote: ```suggestion // StackSaveOp & St

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -1419,6 +1419,50 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/136426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,19 @@ +// RUN: cir-opt %s -cir-to-llvm -o - | FileCheck %s -check-prefix=MLIR andykaylor wrote: Can you also add a RUN line to lower this to LLVM IR? https://github.com/llvm/llvm-project/pull/136426 ___ cfe-

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -1419,6 +1419,50 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. Looks good, with a couple of minor requests. https://github.com/llvm/llvm-project/pull/136426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -1419,6 +1419,50 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] b7c521b - [OpenACC][CIR] Lowering for 'vector_length' on compute constructs

2025-04-21 Thread via cfe-commits
Author: erichkeane Date: 2025-04-21T12:47:47-07:00 New Revision: b7c521b922f8b81544ecb0ccff2847644cac3107 URL: https://github.com/llvm/llvm-project/commit/b7c521b922f8b81544ecb0ccff2847644cac3107 DIFF: https://github.com/llvm/llvm-project/commit/b7c521b922f8b81544ecb0ccff2847644cac3107.diff LO

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-21 Thread Michele Scandale via cfe-commits
https://github.com/michele-scandale updated https://github.com/llvm/llvm-project/pull/136038 >From 359e31eece5b7ddf4a62074a67947c31f4538ed1 Mon Sep 17 00:00:00 2001 From: Michele Scandale Date: Mon, 21 Apr 2025 12:47:10 -0700 Subject: [PATCH] [clang] Rework `hasBooleanRepresentation`. This is

[clang] [clang] Enable making `CompilerInstance` diagnostics thread-safe (PR #136601)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes The `DiagnosticConsumer` interface is not thread-safe. To enable thread-safety of `CompilerInstance` objects cloned from the same parent, this PR allows passing an explicit `DiagnosticConsumer` to `clone

[clang] [clang] Enable making `CompilerInstance` diagnostics thread-safe (PR #136601)

2025-04-21 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/136601 The `DiagnosticConsumer` interface is not thread-safe. To enable thread-safety of `CompilerInstance` objects cloned from the same parent, this PR allows passing an explicit `DiagnosticConsumer` to `cloneFo

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136426 >From 91a6937c7b937daceef426c877703d4d0cfeae76 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 14:22:45 +0200 Subject: [PATCH 1/4] [CIR] Upstream StackSave and StackRestoreOp --- clang/

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Andy Kaylor via cfe-commits
@@ -637,6 +637,42 @@ ArrayType::getABIAlignment(const ::mlir::DataLayout &dataLayout, return dataLayout.getTypeABIAlignment(getEltType()); } +//===--===// +// VectorType Definitions +//===--

<    1   2   3   4   >