[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Balazs Benics via cfe-commits
@@ -194,30 +187,28 @@ void BuiltinFunctionChecker::handleOverflowBuiltin(const CallEvent &Call, SVal RetVal = SVB.evalBinOp(State, Op, Arg1, Arg2, ResultType); auto [Overflow, NotOverflow] = checkOverflow(C, RetValMax, ResultType); - if (NotOverflow) { -ProgramStateR

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal requested changes to this pull request. The tests and functionality looks correct to me. I noticed you promptly fixed the linked issue. You shouldn't need to feel pressured for a fix right away. I appreciate your swiftness and enthausiesm. https://github.com/llvm/llv

[clang] [clang][bytecode] Fix bos/bdos with non-zero offset applied (PR #136482)

2025-04-20 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/136482 Compute the offset from the record layout. Unfortunately, not all the test cases from the current interpreter work. >From b12d6d5ca1bbea0f674b2bd136c1261cb15b6e75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=2

[clang] [clang][bytecode] Fix bos/bdos with non-zero offset applied (PR #136482)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Compute the offset from the record layout. Unfortunately, not all the test cases from the current interpreter work. --- Full diff: https://github.com/llvm/llvm-project/pull/136482.diff 2 Files Affected: -

[clang] [clang-tools-extra] Reapply 19c708c "FunctionDecl::getFunctionTypeLoc: ignore function type attributes (#118420)" (PR #136484)

2025-04-20 Thread Owen Anderson via cfe-commits
https://github.com/resistor created https://github.com/llvm/llvm-project/pull/136484 Avoid using PreservesMost in the testcase as it is not supported on all targets. Original PR #118290. - Co-authored-by: v01dxyz Co-authored-by: Owen Anderson >From 74b5c5db64638641aa21435bb529d143

[clang] [clang-tools-extra] Reapply 19c708c "FunctionDecl::getFunctionTypeLoc: ignore function type attributes (#118420)" (PR #136484)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Owen Anderson (resistor) Changes Avoid using PreservesMost in the testcase as it is not supported on all targets. Original PR #118290. --- Full diff: https://github.com/llvm/llvm-project/pull/136484.diff 3 Files Affected:

[clang] [clang-tools-extra] Reapply 19c708c "FunctionDecl::getFunctionTypeLoc: ignore function type attributes (#118420)" (PR #136484)

2025-04-20 Thread Owen Anderson via cfe-commits
https://github.com/resistor edited https://github.com/llvm/llvm-project/pull/136484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Reapply 19c708c "FunctionDecl::getFunctionTypeLoc: ignore function type attributes (#118420)" (PR #136484)

2025-04-20 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Pavel Skripkin via cfe-commits
@@ -194,30 +187,28 @@ void BuiltinFunctionChecker::handleOverflowBuiltin(const CallEvent &Call, SVal RetVal = SVB.evalBinOp(State, Op, Arg1, Arg2, ResultType); auto [Overflow, NotOverflow] = checkOverflow(C, RetValMax, ResultType); - if (NotOverflow) { -ProgramStateR

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Pavel Skripkin via cfe-commits
@@ -121,30 +120,24 @@ class BuiltinFunctionChecker : public Checker { } // namespace -const NoteTag *BuiltinFunctionChecker::createBuiltinNoOverflowNoteTag( -CheckerContext &C, bool BothFeasible, SVal Arg1, SVal Arg2, -SVal Result) const { - return C.getNoteTag([Res

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: > I noticed you promptly fixed the linked issue. You shouldn't need to feel > pressured for a fix right away. I just feel bad when introduce bugs and want to fix them asap. Thanks for review! https://github.com/llvm/llvm-project/pull/136345 _

[clang] [clang-format] Fix a bug in lexing C++ UDL ending in $ (PR #136476)

2025-04-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/136476 None >From 1507898f4b68d6644aae1449eb8e7fec2b903283 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 20 Apr 2025 00:47:22 -0700 Subject: [PATCH] [clang-format] Fix a bug in lexing C++ UDL ending in $ --- cla

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-20 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/136436 From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 20 Apr 2025 00:24:46 +0200 Subject: [PATCH 1/3] [clang] add -fimplicit-constexpr

[clang] [clang] Handle instantiated members to determine visibility (PR #136128)

2025-04-20 Thread Andrew Savonichev via cfe-commits
asavonic wrote: Thanks a lot @jplehr and @DKLoehr for helping with reproducers, and @erichkeane for taking care of the revert. The compiler trips on `LinkageComputer::computeTypeLinkageInfo` for `case Type::MemberPointer`, where only `CXXRecord` is expected, it seems. We get a `FunctionProtoTy

[clang] [clang-format] Fix a bug in lexing C++ UDL ending in $ (PR #136476)

2025-04-20 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/136476 >From e6374fe18fa7b4147d7e7dafe668728034fea946 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 20 Apr 2025 00:47:22 -0700 Subject: [PATCH] [clang-format] Fix a bug in lexing C++ UDL ending in $ --- clang/lib

[clang] [clang-format] Fix a bug in lexing C++ UDL ending in $ (PR #136476)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136476.diff 3 Files Affected: - (modified) clang/lib/Format/FormatTokenLexer.cpp (+26) - (modified) clang/lib/Format/FormatTokenLexer.h (+1) -

[clang] [clang-format] Fix a bug in lexing C++ UDL ending in $ (PR #136476)

2025-04-20 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/136476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Start implementing __builtin_{,dynamic}_object_size (PR #136478)

2025-04-20 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/136478 None >From 7cb63cec52f7404c93cc578069cf7065d318248c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 19 Apr 2025 17:29:16 +0200 Subject: [PATCH] [clang][bytecode] Start implementing __b

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-20 Thread Hana Dusíková via cfe-commits
@@ -779,6 +779,9 @@ static void InitializeCPlusPlusFeatureTestMacros(const LangOptions &LangOpts, // TODO: Final number? Builder.defineMacro("__cpp_type_aware_allocators", "202500L"); + + if (LangOpts.ImplicitConstexpr) // same value as GCC +Builder.defineMacro("__cp

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds the initial support for VectorType Issue #136487 --- Full diff: https://github.com/llvm/llvm-project/pull/136488.diff 10 Files Affected: - (modified) clang/include/clang/CIR/Dialect/Bu

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-20 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/136488 This change adds the initial support for VectorType Issue #136487 >From 93859a7c91bf5f9fb674811c1dbec271b8d3f72c Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject:

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-20 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136488 >From 160d1717b56e56fa0a83d4b346308b0125deb6db Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject: [PATCH] [CIR] Upstream initial support for fixed size VectorType --

[clang] 060f955 - [clang][analyzer] Fix error path of builtin overflow (#136345)

2025-04-20 Thread via cfe-commits
Author: Pavel Skripkin Date: 2025-04-20T16:14:41+02:00 New Revision: 060f9556a2f6ef4669f1c2cd8c4a4d76748a440f URL: https://github.com/llvm/llvm-project/commit/060f9556a2f6ef4669f1c2cd8c4a4d76748a440f DIFF: https://github.com/llvm/llvm-project/commit/060f9556a2f6ef4669f1c2cd8c4a4d76748a440f.diff

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/136345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/16498 Her

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/136345 >From bcc3a8d0654d7a92183fb5b010892740c593e012 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 18 Apr 2025 22:01:02 +0300 Subject: [PATCH 1/3] [clang][Analyzer] Fix error path of builtin overflow ---

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-20 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136488 >From 5d07a639dc6c933f6f171e501e4ec20d731553e3 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject: [PATCH] [CIR] Upstream initial support for fixed size VectorType --

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/136345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve `bugprone-exception-escape`: add stacktrace of escaped exception (PR #134375)

2025-04-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/134375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-20 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping:) https://github.com/llvm/llvm-project/pull/135383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM, thanks. FYI we usually ping once a week. https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/136041 >From 5dc9d55eb04d94c01dba0364b51a509f975e542a Mon Sep 17 00:00:00 2001 From: Fangyi Zhou Date: Thu, 17 Apr 2025 23:02:37 +0100 Subject: [PATCH 1/2] [clang][analyzer] Handle CXXParenInitListExpr alongside Init

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,19 @@ +// RUN: %clang_analyze_cc1 -std=c++20 -analyzer-checker=core -verify %s + +// expected-no-diagnostics + +template +struct overload : public F... +{ + using F::operator()...; +}; + +template +overload(F&&...) -> overload; + +int main() +{ + const auto l = overlo

[clang] 461168a - [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (#136041)

2025-04-20 Thread via cfe-commits
Author: Fangyi Zhou Date: 2025-04-20T17:32:42+02:00 New Revision: 461168a3d3bb1e75ff41d351a5cc506e103da5d6 URL: https://github.com/llvm/llvm-project/commit/461168a3d3bb1e75ff41d351a5cc506e103da5d6 DIFF: https://github.com/llvm/llvm-project/commit/461168a3d3bb1e75ff41d351a5cc506e103da5d6.diff L

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread via cfe-commits
github-actions[bot] wrote: @fangyi-zhou Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2