[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-04-15 Thread marius doerner via cfe-commits
mariusdr wrote: > LGTM - sorry for the delayed response. > > Will you need me to merge that for you (once the merge conflict is resolved)? Yes, thanks! https://github.com/llvm/llvm-project/pull/133574 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [CodeComplete] Don't drop ArrayToPointerDecay when doing member completion (PR #134951)

2025-04-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16064 Here is the relevant piece of the

[clang] [CLANG-CL] ignores Wpadded (PR #134426)

2025-04-15 Thread Devon Loehr via cfe-commits
=?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes ,Theo

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes This is our first attempt at lowering a clause that is an 'operand' in the OpenACC operand, so it does quite a bit of refactoring. My previous plans on how to emit the clauses was not viable, so we instea

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Erich Keane (erichkeane) Changes This is our first attempt at lowering a clause that is an 'operand' in the OpenACC operand, so it does quite a bit of refactoring. My previous plans on how to emit the clauses was not viable, so we inst

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Andy Kaylor via cfe-commits
@@ -18,9 +18,12 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create() { - // For now we just create an empty CIRGenFunctionInfo. - CIRGenFunctionInfo *fi = new CIRGenFunctionInfo(); +CIRGenFunctionInfo *CIRGenFunctionInfo:

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Valentin Clement バレンタイン クレメン via cfe-commits
@@ -89,64 +95,70 @@ class OpenACCClauseCIREmitter final } void VisitDeviceTypeClause(const OpenACCDeviceTypeClause &clause) { +if constexpr (isOneOfTypes) { + llvm::SmallVector deviceTypes; + std::optional existingDeviceTypes = + operation.getDeviceT

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/135851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream initial support for complete record types (PR #135844)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -0,0 +1,212 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -18,9 +18,12 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create() { - // For now we just create an empty CIRGenFunctionInfo. - CIRGenFunctionInfo *fi = new CIRGenFunctionInfo(); +CIRGenFunctionInfo *CIRGenFunctionInfo:

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -0,0 +1,92 @@ +//==-- ABIArgInfo.h - Abstract info regarding ABI-specific arguments ---==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -303,14 +305,23 @@ const CIRGenFunctionInfo &CIRGenTypes::arrangeCIRFunctionInfo() { assert(!cir::MissingFeatures::opCallCallConv()); // Construction the function info. We co-allocate the ArgInfos. - fi = CIRGenFunctionInfo::create(); + fi = CIRGenFunctionInfo::creat

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -303,14 +305,23 @@ const CIRGenFunctionInfo &CIRGenTypes::arrangeCIRFunctionInfo() { assert(!cir::MissingFeatures::opCallCallConv()); // Construction the function info. We co-allocate the ArgInfos. - fi = CIRGenFunctionInfo::create(); + fi = CIRGenFunctionInfo::creat

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I have some concerns with how the `CIRGenFunctionInfo` objects are being created, then turned into a reference/never deleted. https://github.com/llvm/llvm-project/pull/135552 ___ cfe-commits mailing list cfe-

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -32,46 +32,52 @@ constexpr bool isOneOfTypes = template constexpr bool isOneOfTypes = std::is_same_v; +template class OpenACCClauseCIREmitter final -: public OpenACCClauseVisitor { - CIRGenModule &cgm; +: public OpenACCClauseVisitor> { + OpTy &operation; + CIR

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -89,64 +95,70 @@ class OpenACCClauseCIREmitter final } void VisitDeviceTypeClause(const OpenACCDeviceTypeClause &clause) { +if constexpr (isOneOfTypes) { + llvm::SmallVector deviceTypes; + std::optional existingDeviceTypes = + operation.getDeviceT

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -32,46 +32,52 @@ constexpr bool isOneOfTypes = template constexpr bool isOneOfTypes = std::is_same_v; +template erichkeane wrote: We end up needing to template-ize this, since the visitor handler functions are not needing to `if-constexpr` instead of ju

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -89,64 +95,70 @@ class OpenACCClauseCIREmitter final } void VisitDeviceTypeClause(const OpenACCDeviceTypeClause &clause) { +if constexpr (isOneOfTypes) { + llvm::SmallVector deviceTypes; + std::optional existingDeviceTypes = + operation.getDeviceT

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -430,6 +430,11 @@ class OpenACCSelfClause final } bool isConditionExprClause() const { return HasConditionExpr.has_value(); } + bool isVarListClause() const { return !isConditionExprClause(); } + bool isEmptySelfClause() const { +return (isConditionExprClause() &&

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -158,24 +170,27 @@ mlir::LogicalResult CIRGenFunction::emitOpenACCOpAssociatedStmt( llvm::SmallVector retTy; llvm::SmallVector operands; - - // Clause-emitter must be here because it might modify operands. - OpenACCClauseCIREmitter clauseEmitter(getCIRGenModule(), di

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
erichkeane wrote: +Razvan/Valentin for review of the OpenACC-IR. https://github.com/llvm/llvm-project/pull/135851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #133173)

2025-04-15 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: we're seeing the following after this patch: ``` /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm/llvm/lib/Support/ProgramStack.cpp:67:34: error: this directive must appear between .cfi_startproc and .cfi_endproc directives 67 | "add x29, x0, #0x10\n\t"

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Vitaly Buka via cfe-commits
@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions( std::string llvm::getUniqueModuleId(Module *M) { MD5 Md5; - bool ExportsSymbols = false; - auto AddGlobal = [&](GlobalValue &GV) { -if (GV.isDeclaration() || GV.getName().starts_with("llvm.") || -!GV.h

[clang] [CIR] Upstream initial support for complete record types (PR #135844)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -0,0 +1,212 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [NVPTX] Cleanup and document nvvm.fabs intrinsics, adding f16 support (PR #135644)

2025-04-15 Thread Alex MacLean via cfe-commits
@@ -411,6 +412,13 @@ static Instruction *convertNvvmIntrinsicToLlvm(InstCombiner &IC, } return nullptr; } + case SPC_Fabs: { +if (!II->getType()->isDoubleTy()) + return nullptr; +auto *Fabs = Intrinsic::getOrInsertDeclaration( +II->getModule(),

[clang] [llvm] [RISCV] Fix xmipscmov extension name (PR #135647)

2025-04-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang,llvm` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16079 Here is the relevant piece o

[clang] [llvm] [NVPTX] Cleanup and document nvvm.fabs intrinsics, adding f16 support (PR #135644)

2025-04-15 Thread Alex MacLean via cfe-commits
@@ -1034,6 +1034,10 @@ Value *CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned BuiltinID, case NVPTX::BI__nvvm_fmin_xorsign_abs_f16x2: return MakeHalfType(Intrinsic::nvvm_fmin_xorsign_abs_f16x2, BuiltinID, E, *this); + case NVPTX::BI__nvvm_abs_bf16

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Peter Collingbourne via cfe-commits
@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions( std::string llvm::getUniqueModuleId(Module *M) { MD5 Md5; - bool ExportsSymbols = false; - auto AddGlobal = [&](GlobalValue &GV) { -if (GV.isDeclaration() || GV.getName().starts_with("llvm.") || -!GV.h

[clang] [llvm] [Offload][SYCL] Refactor OffloadKind implementation (PR #135809)

2025-04-15 Thread Arvind Sudarsanam via cfe-commits
https://github.com/asudarsa updated https://github.com/llvm/llvm-project/pull/135809 >From ec072a0ef5b699c58dd2ac404c90a5078f4a774a Mon Sep 17 00:00:00 2001 From: Arvind Sudarsanam Date: Tue, 15 Apr 2025 09:27:27 -0700 Subject: [PATCH 1/3] [Offload][SYCL] Refactor OffloadKind implementation Si

[clang] [clang][Dependency Scanning] Adding an API to Diagnose Invalid Negative Stat Cache Entries (PR #135703)

2025-04-15 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu updated https://github.com/llvm/llvm-project/pull/135703 >From d4b1210c16b4fccc6faa9445bee457a1e330a025 Mon Sep 17 00:00:00 2001 From: Qiongsi Wu Date: Mon, 14 Apr 2025 16:49:07 -0700 Subject: [PATCH 1/3] Initial commit. --- .../DependencyScanningFilesystem.h

[clang] [NFC][Clang] Introduce type aliases to replace use of auto in clang/lib/CodeGen/CGCall.cpp. (PR #135861)

2025-04-15 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann created https://github.com/llvm/llvm-project/pull/135861 `CGCall.cpp` declares several functions with a return type that is an explicitly spelled out specialization of `SmallVector`. Previously, `auto` was used in several places to avoid repeating the long type n

[clang] [NFC][Clang] Introduce type aliases to replace use of auto in clang/lib/CodeGen/CGCall.cpp. (PR #135861)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Honermann (tahonermann) Changes `CGCall.cpp` declares several functions with a return type that is an explicitly spelled out specialization of `SmallVector`. Previously, `auto` was used in several places to avoid repeating the long ty

[clang] [NFC][Clang] Introduce type aliases to replace use of auto in clang/lib/CodeGen/CGCall.cpp. (PR #135861)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Tom Honermann (tahonermann) Changes `CGCall.cpp` declares several functions with a return type that is an explicitly spelled out specialization of `SmallVector`. Previously, `auto` was used in several places to avoid repeating the

[clang] [clang][Dependency Scanning] Adding an API to Diagnose Invalid Negative Stat Cache Entries (PR #135703)

2025-04-15 Thread Qiongsi Wu via cfe-commits
@@ -108,6 +108,31 @@ DependencyScanningFilesystemSharedCache::getShardForUID( return CacheShards[Hash % NumShards]; } +void DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths( +llvm::raw_ostream &OS, llvm::vfs::FileSystem &UnderlyingFS) const { + /

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-04-15 Thread Tom Honermann via cfe-commits
@@ -732,6 +732,16 @@ CodeGenTypes::arrangeBuiltinFunctionDeclaration(CanQualType resultType, RequiredArgs::All); } +const CGFunctionInfo & +CodeGenTypes::arrangeSYCLKernelCallerDeclaration(QualType resultType, +

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Vitaly Buka via cfe-commits
@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions( std::string llvm::getUniqueModuleId(Module *M) { MD5 Md5; - bool ExportsSymbols = false; - auto AddGlobal = [&](GlobalValue &GV) { -if (GV.isDeclaration() || GV.getName().starts_with("llvm.") || -!GV.h

[clang] [HLSL] Don't invoke `dxv` from `clang-dxc` for text output (PR #135876)

2025-04-15 Thread Justin Bogner via cfe-commits
https://github.com/bogner created https://github.com/llvm/llvm-project/pull/135876 Running `clang-dxc` with textual output was emitting various spurious warnings (if `dxv` wasn't on your path) or errors (if it was). Avoid these by not attempting to run this tool when it doesn't make sense to d

[clang] [Fuchsia] Not building llvm-mt when LIBXML2 is not enabled. (PR #135877)

2025-04-15 Thread via cfe-commits
https://github.com/zeroomega created https://github.com/llvm/llvm-project/pull/135877 This patch prevents including llvm-mt to LLVM_TOOLCHAIN_TOOLS when LIBXML2 is not explicitly enabled. >From 91c8f62bf432a296d29a2445c93738b5c4c85f63 Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Tue, 15 Apr

[clang] [HLSL] Don't invoke `dxv` from `clang-dxc` for text output (PR #135876)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Justin Bogner (bogner) Changes Running `clang-dxc` with textual output was emitting various spurious warnings (if `dxv` wasn't on your path) or errors (if it was). Avoid these by not attempting to run this tool when it doesn't make

[clang] [HLSL] Don't invoke `dxv` from `clang-dxc` for text output (PR #135876)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Justin Bogner (bogner) Changes Running `clang-dxc` with textual output was emitting various spurious warnings (if `dxv` wasn't on your path) or errors (if it was). Avoid these by not attempting to run this tool when it doesn't make sense

[clang] [Fuchsia] Not building llvm-mt when LIBXML2 is not enabled. (PR #135877)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haowei (zeroomega) Changes This patch prevents including llvm-mt to LLVM_TOOLCHAIN_TOOLS when LIBXML2 is not explicitly enabled. --- Full diff: https://github.com/llvm/llvm-project/pull/135877.diff 1 Files Affected: - (modified) clang/

[clang] af63e1b - [OpenACC][CIR] Implement 'self' lowering on compute constructs (#135851)

2025-04-15 Thread via cfe-commits
Author: Erich Keane Date: 2025-04-15T15:52:04-07:00 New Revision: af63e1b505453de3e6a281d1b72e62fa8d396b23 URL: https://github.com/llvm/llvm-project/commit/af63e1b505453de3e6a281d1b72e62fa8d396b23 DIFF: https://github.com/llvm/llvm-project/commit/af63e1b505453de3e6a281d1b72e62fa8d396b23.diff L

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/135851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-hlsl Author: Kaitlin Peng (kmpeng) Changes Resolves #99114. There will be a follow-up PR on pattern matching later. Tasks completed: - Implement `faceforward` in `hlsl_intrinsics.h`/`hlsl_int

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-spir-v Author: Kaitlin Peng (kmpeng) Changes Resolves #99114. There will be a follow-up PR on pattern matching later. Tasks completed: - Implement `faceforward` in `hlsl_intrinsics.h`/`hlsl_intrinsic_helpers.h` - Implement `faceforward` SPIR-V t

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kaitlin Peng (kmpeng) Changes Resolves #99114. There will be a follow-up PR on pattern matching later. Tasks completed: - Implement `faceforward` in `hlsl_intrinsics.h`/`hlsl_intrinsic_helpers.h` - Implement `faceforward` SPIR-V ta

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space. (PR #135444)

2025-04-15 Thread Alex MacLean via cfe-commits
@@ -982,8 +982,9 @@ void NVPTXDAGToDAGISel::SelectAddrSpaceCast(SDNode *N) { case ADDRESS_SPACE_SHARED: Opc = TM.is64Bit() ? NVPTX::cvta_shared_64 : NVPTX::cvta_shared; break; -case ADDRESS_SPACE_DSHARED: - Opc = TM.is64Bit() ? NVPTX::cvta_dshared_64 :

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add the support for RetainPtrArc (PR #135532)

2025-04-15 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/135532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-15 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng created https://github.com/llvm/llvm-project/pull/135878 Resolves #99114. There will be a follow-up PR on pattern matching later. Tasks completed: - Implement `faceforward` in `hlsl_intrinsics.h`/`hlsl_intrinsic_helpers.h` - Implement `faceforward` SPIR-V target builti

[clang] [llvm] [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #133173)

2025-04-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-with-thin-lto-ubuntu` running on `as-worker-92` while building `clang,llvm` at step 6 "build-stage1-compiler". Full details are available at: https://lab.llvm.org/buildbot/#/builders/127/builds/3025 Here is the releva

[clang] [llvm] LowerTypeTests: Fix quadratic complexity. (PR #135875)

2025-04-15 Thread Peter Collingbourne via cfe-commits
https://github.com/pcc edited https://github.com/llvm/llvm-project/pull/135875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] LowerTypeTests: Fix quadratic complexity. (PR #135875)

2025-04-15 Thread Peter Collingbourne via cfe-commits
https://github.com/pcc closed https://github.com/llvm/llvm-project/pull/135875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream initial support for complete record types (PR #135844)

2025-04-15 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/135844 >From 6ffd93ef63e068b73f451af0a05cc471d5cca9fb Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 15 Apr 2025 12:08:37 -0700 Subject: [PATCH 1/3] [CIR] Upstream initial support for complete record types T

[clang] [HLSL] Don't invoke `dxv` from `clang-dxc` for text output (PR #135876)

2025-04-15 Thread Damyan Pepper via cfe-commits
@@ -309,6 +309,9 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch, } bool HLSLToolChain::requiresValidation(DerivedArgList &Args) const { + if (!Args.hasArg(options::OPT_dxc_Fo)) +return false; damyanp wrote: Doesn't this

[clang] 2d98bdc - Revert "[llvm][clang] Allocate a new stack instead of spawning a new … (#135865)

2025-04-15 Thread via cfe-commits
Author: Daniel Thornburgh Date: 2025-04-15T14:46:55-07:00 New Revision: 2d98bdc12c291523c3543ceaf1c526e25dcaedc6 URL: https://github.com/llvm/llvm-project/commit/2d98bdc12c291523c3543ceaf1c526e25dcaedc6 DIFF: https://github.com/llvm/llvm-project/commit/2d98bdc12c291523c3543ceaf1c526e25dcaedc6.d

[clang] [llvm] Revert "[llvm][clang] Allocate a new stack instead of spawning a new … (PR #135865)

2025-04-15 Thread Daniel Thornburgh via cfe-commits
https://github.com/mysterymath closed https://github.com/llvm/llvm-project/pull/135865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[llvm][clang] Allocate a new stack instead of spawning a new … (PR #135865)

2025-04-15 Thread Daniel Thornburgh via cfe-commits
https://github.com/mysterymath created https://github.com/llvm/llvm-project/pull/135865 …thread to get more stack space (#133173)" This change breaks the Clang build on Mac AArch64. This reverts commit d0c973a7a0149db3b71767d4c5a20a31e6a8ed5b. This reverts commit 429a84f8a4bf559f43f50072747ef

[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (apple-fcloutier) Changes I [asked on the forums](https://discourse.llvm.org/t/should-attribute-format-checking-try-to-const-evaluate-strings/85854/4) and people were generally supportive of the idea, so: Clang's -Wformat checker ca

[clang] [CIR] Upstream initial support for complete record types (PR #135844)

2025-04-15 Thread Andy Kaylor via cfe-commits
@@ -126,6 +130,12 @@ void CIRRecordLowering::lower() { return; } + if (isa(recordDecl)) { +cirGenTypes.getCGModule().errorNYI(recordDecl->getSourceRange(), andykaylor wrote: Eventually, yes. We aren't handling CXXRecordDecl in the code that gets he

[clang] [llvm] [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #133173)

2025-04-15 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: > we're seeing the following after this patch: > > ``` > /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm/llvm/lib/Support/ProgramStack.cpp:67:34: > error: this directive must appear between .cfi_startproc and .cfi_endproc > directives >67 | "add x29,

[clang] [CIR] Upstream initial support for complete record types (PR #135844)

2025-04-15 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > still 1 comment request, else LGTM. Comment request? Am I still missing something? https://github.com/llvm/llvm-project/pull/135844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [llvm] Revert "[llvm][clang] Allocate a new stack instead of spawning a new … (PR #135865)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-support Author: Daniel Thornburgh (mysterymath) Changes …thread to get more stack space (#133173)" This change breaks the Clang build on Mac AArch64. This reverts commit d0c973a7a0149db3b71767d4c5a20a31e6a8ed5b. This rev

[clang] [llvm] Revert "[llvm][clang] Allocate a new stack instead of spawning a new … (PR #135865)

2025-04-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/Basic/Stack.h clang/lib/Basic/S

[clang] Silence -Wcast-function-type warnings on idiomatic Windows code (PR #135660)

2025-04-15 Thread Tom Stellard via cfe-commits
tstellar wrote: @AaronBallman Were you able to manually cherry-pick this one? https://github.com/llvm/llvm-project/pull/135660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-04-15 Thread Eli Friedman via cfe-commits
@@ -5087,6 +5087,19 @@ Decl *Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, assert(EllipsisLoc.isInvalid() && "Friend ellipsis but not friend-specified?"); + if (DS.isExportSpecified()) { +VisibilityAttr *existingAttr = TagD->getAttr(); +if

[clang] [llvm] [RISCV] Add MC layer support for XSfmm*. (PR #133031)

2025-04-15 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/133031 >From bb123ff9401b517d877de4ed6fd9ea61edf49dbb Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Tue, 18 Mar 2025 20:53:19 -0700 Subject: [PATCH 1/4] [RISCV] Add MC layer support for XSfmm*. This adds assembler

[clang] [Clang] enhance loop analysis to handle variable changes inside lambdas (PR #135573)

2025-04-15 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/135573 >From ab01bebfa99f635d80c234e19bf3aa73977ce149 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Apr 2025 01:08:55 +0300 Subject: [PATCH] [Clang] enhance loop analysis to handle variable changes

[clang] [Clang,debuginfo] added vtt parameter in destructor DISubroutineType (PR #130674)

2025-04-15 Thread via cfe-commits
Markus =?utf-8?q?Gschoßmann?= , Markus =?utf-8?q?Gschoßmann?= , Markus =?utf-8?q?Gschoßmann?= , Markus =?utf-8?q?Gschoßmann?= Message-ID: In-Reply-To: mgschossmann wrote: Thanks for your approval. As I do not have write permissions, can you please merge the PR for me? https://github.com/llvm

[clang] [llvm] [NVPTX] Cleanup and document nvvm.fabs intrinsics, adding f16 support (PR #135644)

2025-04-15 Thread Artem Belevich via cfe-commits
@@ -1034,6 +1034,10 @@ Value *CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned BuiltinID, case NVPTX::BI__nvvm_fmin_xorsign_abs_f16x2: return MakeHalfType(Intrinsic::nvvm_fmin_xorsign_abs_f16x2, BuiltinID, E, *this); + case NVPTX::BI__nvvm_abs_bf16

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space. (PR #135444)

2025-04-15 Thread via cfe-commits
@@ -4704,6 +4754,43 @@ void llvm::UpgradeIntrinsicCall(CallBase *CI, Function *NewFn) { CI->eraseFromParent(); return; } + case Intrinsic::nvvm_mapa_shared_cluster: { +// Create a new call with the correct address space. +NewCall = +Builder.CreateCal

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space. (PR #135444)

2025-04-15 Thread via cfe-commits
@@ -982,8 +982,9 @@ void NVPTXDAGToDAGISel::SelectAddrSpaceCast(SDNode *N) { case ADDRESS_SPACE_SHARED: Opc = TM.is64Bit() ? NVPTX::cvta_shared_64 : NVPTX::cvta_shared; break; -case ADDRESS_SPACE_DSHARED: - Opc = TM.is64Bit() ? NVPTX::cvta_dshared_64 :

[clang] [Clang][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -1216,6 +1352,24 @@ class Sema; return ConversionSequenceList(Conversions, NumConversions); } +/// Provide storage for any Expr* arg that must be preserved +/// until deferred template candidates are deduced. +/// Typically this should be used for reve

[clang] [OpenACC][CIR] Implement 'self' lowering on compute constructs (PR #135851)

2025-04-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/135851 >From 3ad13136ba9357873792392b61d14f5b131a472a Mon Sep 17 00:00:00 2001 From: erichkeane Date: Tue, 15 Apr 2025 10:59:38 -0700 Subject: [PATCH 1/3] [OpenACC][CIR] Implement 'self' lowering on compute constru

[clang] [CIR] Upstream initial support for complete record types (PR #135844)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -0,0 +1,212 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #133173)

2025-04-15 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I'm guessing that a stage2 build of clang would probably repro the issue, perhaps this was tested against older clangs that didn't warn on this. https://github.com/llvm/llvm-project/pull/133173 ___ cfe-commits mailing list cfe-commits@

[clang] [CIR] Upstream initial support for complete record types (PR #135844)

2025-04-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Still OK, see the request on line 46 of CIRGenRecordLayoutBuilder.cpp for the comment request previously mentioned. https://github.com/llvm/llvm-project/pull/135844 ___ cfe-commits mailing list

[clang] [Modules] Fix the inconsistency of which `Decl` should be serialized for an identifier. (PR #135887)

2025-04-15 Thread Volodymyr Sapsai via cfe-commits
@@ -224,6 +224,7 @@ class ASTWriter : public ASTDeserializationListener, /// discovery) and start at 2. 1 is reserved for the translation /// unit, while 0 is reserved for NULL. llvm::DenseMap DeclIDs; + // TMP: ^ DeclIDs type for reference vsapsai wrote

[clang] [Fuchsia] Not building llvm-mt when LIBXML2 is not enabled. (PR #135877)

2025-04-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/14550 Here is the relevant piece of the build lo

[clang] [Modules] Fix the inconsistency of which `Decl` should be serialized for an identifier. (PR #135887)

2025-04-15 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: cc @zygoloid as he has touched this code 10 years ago. https://github.com/llvm/llvm-project/pull/135887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [driver] return in `addArchSpecificRPath` for AIX and also get the triple without the OS on AIX in `getArchSpecificLibPaths`. (PR #134520)

2025-04-15 Thread Daniel Chen via cfe-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/134520 >From 1f6eecb06d72acdd5c26d61cac5e88fd7df57005 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Sat, 5 Apr 2025 23:24:09 -0400 Subject: [PATCH 1/2] [driver] return in addArchSpecificRPath for AIX and also g

[clang] [Modules] Fix the inconsistency of which `Decl` should be serialized for an identifier. (PR #135887)

2025-04-15 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai created https://github.com/llvm/llvm-project/pull/135887 Fixes the assertion failure > Assertion failed: (DeclIDs.contains(D) && "Declaration not emitted!"), > function getDeclID, file ASTWriter.cpp, line 6873. We prepare to serialize a `Decl` by adding it to `DeclID

[clang] [Modules] Fix the inconsistency of which `Decl` should be serialized for an identifier. (PR #135887)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Volodymyr Sapsai (vsapsai) Changes Fixes the assertion failure > Assertion failed: (DeclIDs.contains(D) && "Declaration not emitted!"), function getDeclID, file ASTWriter.cpp, line 6873. We prepare to se

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space. (PR #135444)

2025-04-15 Thread via cfe-commits
@@ -0,0 +1,258 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc < %s -o - -mcpu=sm_90 -march=nvptx64 -mattr=+ptx80 | FileCheck %s +; RUN: %if ptxas-12.0 %{ llc < %s -mtriple=nvptx64 -mcpu=sm_90 -mattr=+ptx80| %pt

<    2   3   4   5   6   7