https://github.com/rnk approved this pull request.
Thanks, looks good.
https://github.com/llvm/llvm-project/pull/133173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny wrote:
Closed in favor of #134362.
https://github.com/llvm/llvm-project/pull/127345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/134769
>From 7fe930def5714c196d003e94bafdb4639cea3a43 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 7 Apr 2025 22:44:20 -0300
Subject: [PATCH] [clang] consistently quote expressions in diagnostics
This ch
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/134769
>From e2c40042553845125914e544e696d7e21b553e7d Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 7 Apr 2025 22:44:20 -0300
Subject: [PATCH] [clang] consistently quote expressions in diagnostics
This ch
matts1 wrote:
> The issue is that if we allow the preprocessor's state to differ across
> modules, then the resulting compiled units can be arbitrary (and subtly
> incompatible).
>
> I wonder if a possible solution is to record which macros are used (ie, are
> expanded or appear in `#ifdef` /
@@ -1117,16 +1205,27 @@ class Sema;
SmallVector Candidates;
llvm::SmallPtrSet Functions;
-// Allocator for ConversionSequenceLists. We store the first few of these
+DeferredTemplateOverloadCandidate *FirstDeferredCandidate;
+unsigned DeferredCandidatesCount
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/131477
From d3da72bf61ae8268a25e5331acefe895c783905a Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Sat, 15 Mar 2025 22:37:07 +0100
Subject: [PATCH 1/2] [Clang][Sema] Fix -Whigher-precision-for-complex-division
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics
- Now correctly diagnose a tentative definition of an array with static
storage duration in pedantic mode in C. (#GH50661)
+- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns
when the divisor i
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - |
FileCheck %s
+// RUN: %clang_cc1 %s -triple "spir-unknown-unknown"
-fno-delete-null-pointer-checks -emit-llvm -o - | FileCheck %s
efriedma-quic wrote:
I don't see any optimi
https://github.com/AaronBallman approved this pull request.
LGTM, thank you for the cleanup! The behavioral changes all seem defensible to
me. Should those have a release note?
https://github.com/llvm/llvm-project/pull/135561
___
cfe-commits mailing l
cor3ntin wrote:
@Sterling-Augustine Oliver is looking into it. Given it's a relatively large
patch, I'd rather wait a day until reverting to avoid churn. Will that work for
you?
https://github.com/llvm/llvm-project/pull/113510
___
cfe-commits mailing
@@ -485,6 +485,39 @@ ABIArgInfo AArch64ABIInfo::classifyArgumentType(QualType
Ty, bool IsVariadicFn,
}
Size = llvm::alignTo(Size, Alignment);
+// If the Aggregate is made up of pointers, use an array of pointers for
the
+// coerced type. This prevents having
@@ -14794,9 +14803,36 @@ void
ASTContext::getFunctionFeatureMap(llvm::StringMap &FeatureMap,
}
}
-static SYCLKernelInfo BuildSYCLKernelInfo(CanQualType KernelNameType,
+static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context,
+
vsapsai wrote:
By the way, looked at the other tests in Modules directory and think that the
test should start with "macro-" for consistency. Probably something like
"macro-identifier-hiding.c" as we have "macro-hiding.cpp" already.
https://github.com/llvm/ll
@@ -3871,7 +3874,8 @@ class ASTIdentifierTableTrait {
if (isInterestingIdentifier(II, MacroOffset)) {
DataLen += 2; // 2 bytes for builtin ID
DataLen += 2; // 2 bytes for flags
- if (MacroOffset)
+ if (MacroOffset || (II->hasMacroDefinition() &&
+
Sterling-Augustine wrote:
Thanks from this side too. Appreciate the speed.
https://github.com/llvm/llvm-project/pull/135686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaronpuchert wrote:
I think it's obscure enough to not need to be mentioned. Since I went with the
less intrusive variant of downgrading an error to warning, it should not break
anyone's code.
I'd be open to add `ErrorDiag` on all thread safety attributes, but I'd do so
in a separate change i
@@ -2419,6 +2422,9 @@ namespace {
// declarations it needs.
++NumIdentifierLookupHits;
Found = *Pos;
+ if (Trait.hasMoreInformationInDependencies())
+// Look for the identifier in extra modules as they contain more info.
+return false;
---
https://github.com/mysterymath approved this pull request.
https://github.com/llvm/llvm-project/pull/135514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oliver Hunt (ojhunt)
Changes
The P2719 implementation refactored diagnostics for cleanup delete, and as part
of that I attempted to fix handling of inaccessible cleanup operator delete.
Alas the new branch was incorrect as it was performi
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/135647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2,7 +2,6 @@
// RUN: not %clang_cc1 %s -o - -S -triple=amdgcn-amd-amdhsa 2>&1 | FileCheck %s
void test_amdgcn_fence_failure() {
-
- // CHECK: error: Unsupported atomic synchronization scope
+ // CHECK: error: :0:0: in function _Z25test_amdgcn_fence_failurev
void (): Unsu
https://github.com/shiltian created
https://github.com/llvm/llvm-project/pull/135690
None
>From c1fd5f3f3493b4e5b553438f023fde77d721199b Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Mon, 14 Apr 2025 18:46:45 -0400
Subject: [PATCH] [Clang] Forward two linker options to `lld` when ThinLTO is
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/135690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Shilei Tian (shiltian)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/135690.diff
2 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Clang.cpp (+10-1)
- (modified) clang/test
https://github.com/Sterling-Augustine approved this pull request.
https://github.com/llvm/llvm-project/pull/135686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jeremyd2019 updated
https://github.com/llvm/llvm-project/pull/135691
>From 7bb8bc392d2ea0a0deabb69117da3305ac3137af Mon Sep 17 00:00:00 2001
From: Jeremy Drake
Date: Mon, 14 Apr 2025 10:37:59 -0700
Subject: [PATCH] [Clang] [Driver] add a Cygwin ToolChain
Add a new Cygwin too
https://github.com/AlexVlx created
https://github.com/llvm/llvm-project/pull/135697
This test needs the amdgpu target, and its absence wreaked havoc with some of
the bots, therefore we now require it.
>From a988ecf63dc79d226c2f7aa1430f65d08256888b Mon Sep 17 00:00:00 2001
From: Alex Voicu
Dat
@@ -350,20 +350,87 @@ void func7() {
// OGCG: %[[ARR:.*]] = alloca [1 x ptr], align 8
// OGCG: call void @llvm.memset.p0.i64(ptr align 8 %[[ARR]], i8 0, i64 8, i1
false)
-void func8(int p[10]) {}
-// CIR: cir.func @func8(%arg0: !cir.ptr
-// CIR: cir.alloca !cir.ptr, !cir.ptr>
Author: Peter Collingbourne
Date: 2025-04-14T19:50:37-07:00
New Revision: 984ec70b61cb57b00e622a21b259aaf11775c5f0
URL:
https://github.com/llvm/llvm-project/commit/984ec70b61cb57b00e622a21b259aaf11775c5f0
DIFF:
https://github.com/llvm/llvm-project/commit/984ec70b61cb57b00e622a21b259aaf11775c5f0
https://github.com/efriedma-quic approved this pull request.
https://github.com/llvm/llvm-project/pull/135602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kito-cheng approved this pull request.
LGTM :)
https://github.com/llvm/llvm-project/pull/132481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/135687
None
>From d105489358661b0cd38b447592ff3e69a5641a7c Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 14 Apr 2025 15:01:45 -0700
Subject: [PATCH] [clang][tests] Add missing FileCheck check, NFC
---
c
yingopq wrote:
Ping.
https://github.com/llvm/llvm-project/pull/132679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ojhunt created
https://github.com/llvm/llvm-project/pull/135686
The P2719 implementation refactored diagnostics for cleanup delete, and as part
of that I attempted to fix handling of inaccessible cleanup operator delete.
Alas the new branch was incorrect as it was performing
efriedma-quic wrote:
I'm not really sure how to go about reducing a testcase in that case; it's not
something I've ever run into myself. Please post on Discourse
(https://discourse.llvm.org/); maybe someone else has some ideas.
https://github.com/llvm/llvm-project/pull/135643
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/135473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `flang-x86_64-windows`
running on `minipc-ryzen-win` while building `clang` at step 6
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/166/builds/994
Here is the relevant piece of
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/135737
The `llvm::vfs::FileSystem` interface makes no promises around thread-safety.
To enable making `CompilerInstance` thread-safe, this PR allows passing an
explicit VFS to `cloneForModuleCompile()`. This will
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
The `llvm::vfs::FileSystem` interface makes no promises around thread-safety.
To enable making `CompilerInstance` thread-safe, this PR allows passing an
explicit VFS to `cloneForModuleCompile()`. This wi
efriedma-quic wrote:
Also, if you're okay with publicly posting your code, it's fine to file a bug
with an unreduced testcase.
https://github.com/llvm/llvm-project/pull/135643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
macurtis-amd wrote:
> I don't, but I wonder what's the GCC behavior. It seems to suppress the
> diagnostic when processing a .i file.
Diagnostic seems to be suppressed by
[-fpreprocessed](https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html#index-fpreprocessed),
which is implicit if y
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
NB: This only fixes the crash introduced in Clang 19; we still accept this code
even though we shouldn’t:
```c++
struct S {
friend int f() { return 3; }
friend int f() = delete;
};
```
I tried figuring out a
@@ -3615,6 +3618,23 @@ static void emitCheckHandlerCall(CodeGenFunction &CGF,
.addAttribute(llvm::Attribute::NoUnwind);
}
B.addUWTableAttr(llvm::UWTableKind::Default);
+ // Add more precise attributes to recoverable ubsan handlers for better
+ // optimizations.
+
@@ -14794,9 +14803,36 @@ void
ASTContext::getFunctionFeatureMap(llvm::StringMap &FeatureMap,
}
}
-static SYCLKernelInfo BuildSYCLKernelInfo(CanQualType KernelNameType,
+static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context,
+
@@ -57,6 +57,7 @@
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/Path.h"
#include "llvm/Support/Process.h"
+#include "llvm/Support/ThreadPool.h"
yxsamliu wrote:
will remove
https://github.com/llvm/llvm-project/pull/135229
@@ -143,6 +143,32 @@ if (LLVM_ENABLE_SPHINX)
gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs
../include/clang/Basic/Diagnostic.td "${docs_targets}")
gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs
../include/clang/Driver/ClangOptionDocs.td
https://github.com/farzonl closed
https://github.com/llvm/llvm-project/pull/135655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shiltian wrote:
* **#135690** https://app.graphite.dev/github/pr/llvm/llvm-project/135690?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/135
https://github.com/mizvekov approved this pull request.
LGTM as well.
https://github.com/llvm/llvm-project/pull/134038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wenju-he created
https://github.com/llvm/llvm-project/pull/135710
llvm-diff shows this PR has no changes to amdgcn--amdhsa.bc.
Motivation is that in our downstream the same category of target built-ins,
e.g. math, are organized in several different folders. For example, in t
https://github.com/andykaylor approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/135493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Shilei Tian
Date: 2025-04-14T20:57:20-04:00
New Revision: f4ff209e4384d8073f36fb7da9916b33f1140edf
URL:
https://github.com/llvm/llvm-project/commit/f4ff209e4384d8073f36fb7da9916b33f1140edf
DIFF:
https://github.com/llvm/llvm-project/commit/f4ff209e4384d8073f36fb7da9916b33f1140edf.diff
L
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/134769
>From 7a777961125a31a8e721f2f78354a3b21c0a06b2 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 7 Apr 2025 22:44:20 -0300
Subject: [PATCH] [clang] consistently quote expressions in diagnostics
This ch
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
Sirraide wrote:
> Sorry about that. This PR had become so stale that there merge conflicts and
> the easiest way to fix it was to squash because the conflicts were with
> things I later removed.
I see, yeah, it happens; that’s unfortunate...
https://github.com/llvm/llvm-project/pull/106321
_
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sean McBride (seanm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/135720.diff
1 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
(-1)
``diff
diff --git a/clan
Author: Younan Zhang
Date: 2025-04-15T09:16:55+08:00
New Revision: 83344da69145a648aad3e0cd88eab4aaf60b2142
URL:
https://github.com/llvm/llvm-project/commit/83344da69145a648aad3e0cd88eab4aaf60b2142
DIFF:
https://github.com/llvm/llvm-project/commit/83344da69145a648aad3e0cd88eab4aaf60b2142.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/134038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/135229
>From 5c2283b01ac6a58e41df4260aecc01bcf463a0a9 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 10 Apr 2025 14:14:47 -0400
Subject: [PATCH] [Clang] add option --offload-jobs=N
for specifying number
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - |
FileCheck %s
+// RUN: %clang_cc1 %s -triple "spir-unknown-unknown"
-fno-delete-null-pointer-checks -emit-llvm -o - | FileCheck %s
dtcxzyw wrote:
The default optimization lev
401 - 461 of 461 matches
Mail list logo
