[clang] [sanitizer][CFI] Add support to build CFI with sanitize-coverage (PR #131296)

2025-04-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/131296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread via cfe-commits
@@ -5464,7 +5464,7 @@ FunctionDecl::Create(ASTContext &C, DeclContext *DC, SourceLocation StartLoc, FunctionDecl *FunctionDecl::CreateDeserialized(ASTContext &C, GlobalDeclID ID) { return new (C, ID) FunctionDecl( Function, C, nullptr, SourceLocation(), DeclarationNam

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread via cfe-commits
@@ -78,6 +78,22 @@ class UnresolvedSetImpl; class VarTemplateDecl; enum class ImplicitParamKind; +// Holds a constraint expression along with a pack expansion index, if +// expanded. +struct AssociatedConstraint { + const Expr *ConstraintExpr = nullptr; + int ArgumentPackSub

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread via cfe-commits
@@ -3571,7 +3571,7 @@ bool FunctionDecl::isMemberLikeConstrainedFriend() const { // If these friends don't have constraints, they aren't constrained, and // thus don't fall under temp.friend p9. Else the simple presence of a // constraint makes them unique. -ret

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread via cfe-commits
https://github.com/cor3ntin commented: That makes sense to me https://github.com/llvm/llvm-project/pull/133190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/133190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread via cfe-commits
@@ -373,6 +373,8 @@ Bug Fixes to C++ Support - Improved fix for an issue with pack expansions of type constraints, where this now also works if the constraint has non-type or template template parameters. (#GH131798) +- Fix crash when evaluating trailing requires clause o

[clang] [Clang] Fix dependent local class instantiation bugs (PR #134038)

2025-04-02 Thread Younan Zhang via cfe-commits
@@ -4264,7 +4264,8 @@ Sema::InstantiateClassMembers(SourceLocation PointOfInstantiation, if (FunctionDecl *Pattern = Function->getInstantiatedFromMemberFunction()) { -if (Function->isIneligibleOrNotSelected()) +if (!Instantiation->getDeclCo

[clang] [Clang] Fix dependent local class instantiation bugs (PR #134038)

2025-04-02 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > This once again looks like an attempt at hacking around our lack of delayed > lambda body instantiation... And this one has some pretty sizable negatives > as far as I can see. I'm not sure I really like this direction. Yeah, admittedly this is another workaround of not havin

[clang] [Clang] Fix dependent local class instantiation bugs (PR #134038)

2025-04-02 Thread Erich Keane via cfe-commits
erichkeane wrote: > > This once again looks like an attempt at hacking around our lack of delayed > > lambda body instantiation... And this one has some pretty sizable negatives > > as far as I can see. I'm not sure I really like this direction. > > Yeah, admittedly this is another workaround

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Tarun Prabhu via cfe-commits
@@ -6974,6 +7019,22 @@ defm loop_versioning : BoolOptionWithoutMarshalling<"f", "version-loops-for-stri PosFlag, NegFlag>; +defm stack_repack_arrays +: BoolOptionWithoutMarshalling< + "f", "stack-repack-arrays", + PosFlag, + NegFlag< +

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,24 @@ +! Test forwarding just the forwarding of -f[no-]stack-repack-arrays options: tarunprabhu wrote: ```suggestion ! Test forwarding of -f[no-]stack-repack-arrays options: ``` https://github.com/llvm/llvm-project/pull/134002

[clang] [flang] [flang] Complete alignment of -x language modes with gfortran (PR #133775)

2025-04-02 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu approved this pull request. Thanks for the changes, David. :-) https://github.com/llvm/llvm-project/pull/133775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [Clang] Fix dependent local class instantiation bugs (PR #134038)

2025-04-02 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > I wouldn't be able to convince you to start work on the delayed lambda body > instantiation instead, would I ? :-P AFAIK @LYP951018 is already working on this region. Though I haven't test that patch with it yet 🥲 https://github.com/llvm/llvm-project/pull/134038

[clang] [Clang] Fix dependent local class instantiation bugs (PR #134038)

2025-04-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/134038 >From a670287721da08e54e2908e9abe52ad86a92769b Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 2 Apr 2025 14:44:40 +0800 Subject: [PATCH 1/2] [Clang] Fix dependent local class instantiation bugs --- cla

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,24 @@ +! Test forwarding just the forwarding of -f[no-]repack-arrays options: tarunprabhu wrote: ```suggestion ! Test forwarding of -f[no-]repack-arrays options: ``` https://github.com/llvm/llvm-project/pull/134002

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,27 @@ +! Test forwarding just the forwarding of -frepack-arrays-contiguity options: tarunprabhu wrote: ```suggestion ! Test forwarding of -frepack-arrays-contiguity options: ``` https://github.com/llvm/llvm-project/pull/134002

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 14335be - [Clang][NFC] Minor constraint satisfaction checking cleanup (#134059)

2025-04-02 Thread via cfe-commits
Author: cor3ntin Date: 2025-04-02T13:49:48+02:00 New Revision: 14335be0780d369f4aa2403ee986bac3d436872f URL: https://github.com/llvm/llvm-project/commit/14335be0780d369f4aa2403ee986bac3d436872f DIFF: https://github.com/llvm/llvm-project/commit/14335be0780d369f4aa2403ee986bac3d436872f.diff LOG:

[clang] [Clang][NFC] Minor constraint satisfaction checking cleanup (PR #134059)

2025-04-02 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/134059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][BPF] Add tests for btf_type_tag c2x-style attributes (PR #133666)

2025-04-02 Thread via cfe-commits
https://github.com/eddyz87 approved this pull request. https://github.com/llvm/llvm-project/pull/133666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Tom Eccles via cfe-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/134002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Tom Eccles via cfe-commits
@@ -1687,6 +1700,7 @@ void CompilerInvocation::setLoweringOptions() { const Fortran::common::LangOptions &langOptions = getLangOpts(); loweringOpts.setIntegerWrapAround(langOptions.getSignedOverflowBehavior() == Fortran::common::LangOptio

[clang] [Clang] [NFC] Introduce a helper for emitting compatibility diagnostics (PR #132348)

2025-04-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-key-instructions` running on `sie-linux-worker5` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/208/builds/14 Here is

[clang] [modules] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-04-02 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: > LGTM. > > But I didn't recognize you didn't update `MultiplexExternalSemaSource`. Every > time we add new interface to `ExternalASTSource`, we need to update > `MultiplexExternalSemaSource` too. Oh, thanks for the good catch! Fixed now. https://github.com/llvm/llvm-projec

[clang] Reapply "[Clang] [NFC] Introduce a helper for emitting compatibility diagnostics (#132348)" (PR #134043)

2025-04-02 Thread via cfe-commits
Sirraide wrote: > LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running > on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/18/builds/13872 > > Here is the relevant piece o

[libclc] [libclc] Move native_(exp10|powr|tan) to CLC library (PR #134080)

2025-04-02 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/134080 These are the three remaining native builtins not yet ported. There are elementwise versions of exp10 and tan which correspond to the intrinsics, which may be preferable to the current versions which route

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-04-02 Thread Alex Voicu via cfe-commits
@@ -585,6 +597,23 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, llvm::Value *Env = EmitScalarExpr(E->getArg(0)); return Builder.CreateCall(F, {Env}); } + case AMDGPU::BI__builtin_amdgcn_processor_is: { +assert(CGM.getTriple().isSPIRV() &&

[clang] [llvm] [ARM][Clang] Make `+nosimd` functional for AArch32 Targets (PR #130623)

2025-04-02 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 edited https://github.com/llvm/llvm-project/pull/130623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Support NOWAIT with optional argument (PR #128742)

2025-04-02 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm requested changes to this pull request. Please put this under 6.0 version guard. Otherwise, LGTM for now. https://github.com/llvm/llvm-project/pull/128742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [llvm] [Clang] [OpenMP] Support NOWAIT with optional argument (PR #128742)

2025-04-02 Thread Michael Klemm via cfe-commits
@@ -7,13 +7,13 @@ void foo() { int main(int argc, char **argv) { int i; - #pragma omp target parallel for simd nowait( // expected-warning {{extra tokens at the end of '#pragma omp target parallel for simd' are ignored}} + #pragma omp target parallel for simd nowait( //

[clang] [llvm] [Clang] [OpenMP] Support NOWAIT with optional argument (PR #128742)

2025-04-02 Thread Michael Klemm via cfe-commits
@@ -11530,6 +11530,8 @@ def note_omp_nested_teams_construct_here : Note< "nested teams construct here">; def note_omp_nested_statement_here : Note< "%select{statement|directive}0 outside teams construct here">; +def err_omp_nowait_with_arg_unsupported : Error< + "'nowait'

[clang] [llvm] [Clang] [OpenMP] Support NOWAIT with optional argument (PR #128742)

2025-04-02 Thread Michael Klemm via cfe-commits
@@ -7,13 +7,12 @@ void foo() { int main(int argc, char **argv) { int i; -#pragma omp target teams distribute nowait( // expected-warning {{extra tokens at the end of '#pragma omp target teams distribute' are ignored}} - for (i = 0; i < argc; ++i) foo(); -#pragma omp target

[clang] [llvm] [PowerPC] Enable indiviual crbits tracking at -O2 (PR #133617)

2025-04-02 Thread Amy Kwan via cfe-commits
@@ -1,8 +1,8 @@ ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 3 ; RUN: llc -verify-machineinstrs -mcpu=pwr7 < %s | FileCheck %s -; RUN: llc -verify-machineinstrs -O1 -mcpu=pwr7 < %s | FileCheck %s +; RUN: llc -verify-machinein

[clang] [llvm] [PowerPC] Enable indiviual crbits tracking at -O2 (PR #133617)

2025-04-02 Thread Amy Kwan via cfe-commits
@@ -43,63 +43,6 @@ // CHECK-CRBITS: "-target-feature" "+crbits" -// RUN: %clang -target powerpc64le-unknown-linux-gnu -mcpu=pwr10 -emit-llvm \ -// RUN: -S %s -o - | FileCheck %s --check-prefix=HAS-CRBITS -// RUN: %clang -target powerpc64le-unknown-linux-gnu -mcpu=pwr10 -mcr

[clang] fixed clang frontend crash with friend class declaration and overload == (PR #133878)

2025-04-02 Thread Ankur Ahir via cfe-commits
https://github.com/Ankur-0429 updated https://github.com/llvm/llvm-project/pull/133878 >From 289f8630dccf916b8cf7cc43758bae60df036c5d Mon Sep 17 00:00:00 2001 From: Ankur Ahir Date: Wed, 2 Apr 2025 00:53:33 -0700 Subject: [PATCH] clang frontend crash with friend class declaration and overloade

[clang] [clang] Fix overload resolution ranking of inherited constructors (PR #132830)

2025-04-02 Thread via cfe-commits
https://github.com/offsetof updated https://github.com/llvm/llvm-project/pull/132830 >From e458a6b79f560e803bdce414ea35f147ee4ce39d Mon Sep 17 00:00:00 2001 From: offsetof Date: Mon, 24 Mar 2025 21:06:44 + Subject: [PATCH 1/5] [clang] Fix overload resolution ranking of inherited constructo

[clang] Bypass alignment option based on architecture features instead of command-line flags (PR #134099)

2025-04-02 Thread Simi Pallipurath via cfe-commits
https://github.com/simpal01 edited https://github.com/llvm/llvm-project/pull/134099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bypass alignment option based on architecture features instead of command-line flags (PR #134099)

2025-04-02 Thread Simi Pallipurath via cfe-commits
https://github.com/simpal01 edited https://github.com/llvm/llvm-project/pull/134099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add clang driver changes to support MTI RISC-V (PR #134065)

2025-04-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/

[clang] Hlsl dst function (PR #133828)

2025-04-02 Thread Damyan Pepper via cfe-commits
@@ -35,6 +35,12 @@ length_vec_impl(vector X) { #endif } +template +constexpr vector dst_impl(vector src0, vector src1) { + vector dest = {1, src0[1] * src1[1], src0[2], src1[3]}; + return dest; +} damyanp wrote: Coding conventions: ```suggestion constexpr

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: All done with the comments here. https://github.com/llvm/llvm-project/pull/133190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-04-02 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/133190 >From 4a6c03876d9f106df9913aeb66d484afc362454f Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 26 Mar 2025 18:38:34 -0300 Subject: [PATCH] [clang] support pack expansions for trailing requires clauses

[clang] [clang] Implement CWG2815 (PR #132778)

2025-04-02 Thread via cfe-commits
https://github.com/offsetof updated https://github.com/llvm/llvm-project/pull/132778 >From 0aa1e7b83888bde7112327fba7db9bdcb71c43d9 Mon Sep 17 00:00:00 2001 From: offsetof Date: Mon, 24 Mar 2025 16:28:28 + Subject: [PATCH 1/4] [clang] Implement CWG2815 CWG2815 "Overload resolution for refe

[clang] Bypass alignment option based on architecture features instead of command-line flags (PR #134099)

2025-04-02 Thread Simi Pallipurath via cfe-commits
https://github.com/simpal01 edited https://github.com/llvm/llvm-project/pull/134099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move lgamma, lgamma_r & tgamma to CLC library (PR #134053)

2025-04-02 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/134053 Also enable half-precision variants of tgamma, which were previously missing. Note that unlike recent work, these builtins are not vectorized as part of this commit. Ultimately all three call into lgamma_r,

[clang] [Clang][Driver] Override complex number calculation method by -fno-fa… (PR #132680)

2025-04-02 Thread Fangrui Song via cfe-commits
@@ -2997,6 +2997,7 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, LangOptions::ComplexRangeKind Range = LangOptions::ComplexRangeKind::CX_None; std::string ComplexRangeStr = ""; std::string GccRangeComplexOption = ""; + std::string LastC

[clang] [Clang][Driver] Override complex number calculation method by -fno-fa… (PR #132680)

2025-04-02 Thread Fangrui Song via cfe-commits
@@ -3148,6 +3158,7 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, ComplexArithmeticStr(RangeVal)); } } + LastComplexRangeOption = "-fcomplex-arithmetic"; MaskRay wrote: `Arg:

[clang] [llvm] [Coverage] Improve performance of propagating Counter of Expansions (PR #122589)

2025-04-02 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/122589 >From e5fbf846113591b0abff151d91b01a5dd40abef1 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Sat, 11 Jan 2025 18:42:10 +0900 Subject: [PATCH 1/6] [Coverage] Improve performance of propagating Counter of

[clang] [modules] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-04-02 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: LGTM. But I didn't recognize you didn't update `MultiplexExternalSemaSource`. Every time we add new interface to `ExternalASTSource`, we need to update `MultiplexExternalSemaSource` too. https://github.com/llvm/llvm-project/pull/132214

[clang] [Clang][NFC] Minor constraint satisfaction checking cleanup (PR #134059)

2025-04-02 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/134059 We had a weird, incorrect, "ConstraintEvaluator" object that was not useful for anything, so I removed that. I also changed the CheckConstraintSatisfaction overload that just took an Expr* as this did not mak

[clang] [llvm] Add clang driver changes to support MTI RISC-V (PR #134065)

2025-04-02 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro updated https://github.com/llvm/llvm-project/pull/134065 >From 513b1ae05ed6049586a23acab6c0a2f7dbb48454 Mon Sep 17 00:00:00 2001 From: Djordje Todorovic Date: Wed, 26 Mar 2025 09:24:29 +0100 Subject: [PATCH 1/2] [clang][RISCV] Set default CPU for vendor --- clang/

[clang] [sanitizer][CFI] Add support to build CFI with sanitize-coverage (PR #131296)

2025-04-02 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag approved this pull request. https://github.com/llvm/llvm-project/pull/131296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-04-02 Thread Erich Keane via cfe-commits
@@ -4920,6 +4920,116 @@ If no address spaces names are provided, all address spaces are fenced. __builtin_amdgcn_fence(__ATOMIC_SEQ_CST, "workgroup", "local") __builtin_amdgcn_fence(__ATOMIC_SEQ_CST, "workgroup", "local", "global") +__builtin_amdgcn_processor_is and __bui

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

2025-04-02 Thread Lucas Duarte Prates via cfe-commits
pratlucas wrote: Thanks for picking this up @asb ! Unfortunately I still couldn't find the time to investigate the root cause of the issue in our downstream runs. I'll keep you posted in case we find any more details on this. https://github.com/llvm/llvm-project/pull/122629 ___

[clang] Reland [Clang][Cmake] fix libtool duplicate member name warnings (PR #133850)

2025-04-02 Thread Nikita Popov via cfe-commits
nikic wrote: Could you please provide some more detail on why the special DirectX handling is necessary? The commit message says something about "DirectX use of CodeGenModule as input to getHLSLType" being the reason, but I don't get why that is relevant. https://github.com/llvm/llvm-project/

[clang-tools-extra] [clang-tidy] Detect string literals in macros in modernize-raw-string… (PR #133636)

2025-04-02 Thread Richard Thomson via cfe-commits
@@ -58,7 +58,7 @@ bool containsEscapedCharacters(const MatchFinder::MatchResult &Result, *Result.SourceManager, Result.Context->getLangOpts()); StringRef Text = Lexer::getSourceText(CharRange, *Result.SourceManager, Result.Contex

[clang] [llvm] Revert "Enable unnecessary-virtual-specifier by default" (PR #134105)

2025-04-02 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/134105 Reverts llvm/llvm-project#133265 This causes the whole libc++ CI to fail, since we're not building against a compiler built from current trunk. >From adbf46d2b5b226452eee71825dd26b4414617f7d Mon Sep 17 00:0

[clang-tools-extra] [clang-tidy] Detect string literals in macros in modernize-raw-string… (PR #133636)

2025-04-02 Thread Richard Thomson via cfe-commits
https://github.com/LegalizeAdulthood edited https://github.com/llvm/llvm-project/pull/133636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "Enable unnecessary-virtual-specifier by default" (PR #134105)

2025-04-02 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: I think we need some better transition story here. Maybe don't enable the warning by default for time until we've had time to update the libc++ containers? https://github.com/llvm/llvm-project/pull/134105 ___ cfe-commits mailing lis

[clang] [CodeGen] Don't include CGDebugInfo.h in CodeGenFunction.h (NFC) (PR #134100)

2025-04-02 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. https://github.com/llvm/llvm-project/pull/134100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "Enable unnecessary-virtual-specifier by default" (PR #134105)

2025-04-02 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: CC @DKLoehr @AaronBallman @zmodem - I'm landing this now, since this halts basically all libc++ development. https://github.com/llvm/llvm-project/pull/134105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] Revert "[Clang] [NFC] Introduce a helper for emitting compatibility diagnostics" (PR #134036)

2025-04-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/2743 Here is the relevant piece

[clang] [flang] [llvm] [flang-rt] Pass the whole path of libflang_rt.runtime.a to linker on AIX (PR #131041)

2025-04-02 Thread Daniel Chen via cfe-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131041 >From 8e94a94094fd3ecfe3554f4e7c1812d8c79ea07d Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Wed, 12 Mar 2025 18:23:14 -0400 Subject: [PATCH 01/14] [flang-rt] Pass the whole path of libflang_rt.runtime.a

[clang] [flang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

2025-04-02 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/132048 From 5f039ef32105132a7edf6203eb0b7825d4b8b503 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/6] [AMDGPU] Add "lds-bu

[clang] [flang] [llvm] [flang-rt] Pass the whole path of libflang_rt.runtime.a to linker on AIX (PR #131041)

2025-04-02 Thread Daniel Chen via cfe-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131041 >From aecfa9e83dd29f7c4a3276633caf70553e2ca1cc Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Wed, 12 Mar 2025 18:23:14 -0400 Subject: [PATCH 01/14] [flang-rt] Pass the whole path of libflang_rt.runtime.a

[clang] [llvm] Revert "Enable unnecessary-virtual-specifier by default" (PR #134105)

2025-04-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Nikolas Klauser (philnik777) Changes Reverts llvm/llvm-project#133265 This causes the whole libc++ CI to fail, since we're not building against a compiler built from current trunk. --- Full diff: https://github.com/llvm

[clang] [flang] [flang][OpenMP] Upstream first part of `do concurrent` mapping (PR #126026)

2025-04-02 Thread Steve Scalpone via cfe-commits
sscalpone wrote: @ergawy Nice work! Thanks! https://github.com/llvm/llvm-project/pull/126026 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add SPIR-V to some OpenMP clang tests (PR #133503)

2025-04-02 Thread Nick Sarnie via cfe-commits
sarnex wrote: Yeah we definitely need that to be done. I believe @JonChesterfield's proposal was the most recent development. https://github.com/llvm/llvm-project/pull/133503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [llvm] [PowerPC] Enable indiviual crbits tracking at -O2 (PR #133617)

2025-04-02 Thread Maryam Moghadas via cfe-commits
https://github.com/maryammo edited https://github.com/llvm/llvm-project/pull/133617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Added driver options for arrays repacking. (PR #134002)

2025-04-02 Thread Slava Zakharin via cfe-commits
https://github.com/vzakhari updated https://github.com/llvm/llvm-project/pull/134002 >From b936044f9a77cb717d74248cad5021b5d997d407 Mon Sep 17 00:00:00 2001 From: Slava Zakharin Date: Tue, 1 Apr 2025 15:55:30 -0700 Subject: [PATCH 1/3] [flang] Added driver options for arrays repacking. Added o

[clang] Reapply "[Clang] [NFC] Introduce a helper for emitting compatibility diagnostics (#132348)" (PR #134043)

2025-04-02 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/134043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

2025-04-02 Thread Harmen Stoppels via cfe-commits
haampie wrote: @yxsamliu can you land this? I cannot https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fixed clang frontend crash with friend class declaration and overload == (PR #133878)

2025-04-02 Thread Ankur Ahir via cfe-commits
Ankur-0429 wrote: @zyn0217 changes were made :) https://github.com/llvm/llvm-project/pull/133878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] [NFC] Introduce a helper for emitting compatibility diagnostics (#132348)" (PR #134043)

2025-04-02 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/134043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] [NFC] Introduce a helper for emitting compatibility diagnostics (#132348)" (PR #134043)

2025-04-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/13872 Here is the relevant piece of the build lo

[clang] [modules] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-04-02 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin edited https://github.com/llvm/llvm-project/pull/132214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-04-02 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/133426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move sinh, cosh & tanh to the CLC library (PR #134063)

2025-04-02 Thread Fraser Cormack via cfe-commits
@@ -0,0 +1,201 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Reapply "[Clang] [NFC] Introduce a helper for emitting compatibility diagnostics (#132348)" (PR #134043)

2025-04-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-02` while building `clang` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/6630 Here is the relevant piece of the bui

[clang] [flang] [flang][OpenMP] Handle "loop-local values" in `do concurrent` nests (PR #127635)

2025-04-02 Thread Kareem Ergawy via cfe-commits
https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/127635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL][SPIR-V Backend][clang-sycl-linker] Add SPIR-V backend support inside clang-sycl-linker (PR #133967)

2025-04-02 Thread Vyacheslav Levytskyy via cfe-commits
https://github.com/VyacheslavLevytskyy approved this pull request. https://github.com/llvm/llvm-project/pull/133967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Allow casting from a null pointer constant to nullptr_t (PR #133742)

2025-04-02 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/133742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

2025-04-02 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Precommit CI failure on Linux appears to be unrelated, so landing the changes (I'll watch the bots in case it was related somehow). https://github.com/llvm/llvm-project/pull/132116 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] a0b75b9 - [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (#132116)

2025-04-02 Thread via cfe-commits
Author: Lyle Dean Date: 2025-04-02T07:31:42-04:00 New Revision: a0b75b9d990d834a814f1585a21705da558e43d3 URL: https://github.com/llvm/llvm-project/commit/a0b75b9d990d834a814f1585a21705da558e43d3 DIFF: https://github.com/llvm/llvm-project/commit/a0b75b9d990d834a814f1585a21705da558e43d3.diff LOG

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

2025-04-02 Thread via cfe-commits
github-actions[bot] wrote: @lyledean1 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang] [Clang] Instantiate local constexpr functions eagerly (PR #95660)

2025-04-02 Thread Younan Zhang via cfe-commits
zyn0217 wrote: It's still broken, and I haven’t figured out an approach to fix the regression. I do recall that we were planning to wire up Sema and the constant evaluator, so this patch might end up being completely superseded if that gets implemented. https://github.com/llvm/llvm-project/pul

[clang] [sanitizer][CFI] Add support to build CFI with sanitize-coverage (PR #131296)

2025-04-02 Thread Maxim Zhukov via cfe-commits
Mephistophiles wrote: @chestnykh unfortunately, I don't have the rights to merge this PR https://github.com/llvm/llvm-project/pull/131296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-04-02 Thread Alex Voicu via cfe-commits
@@ -4920,6 +4920,116 @@ If no address spaces names are provided, all address spaces are fenced. __builtin_amdgcn_fence(__ATOMIC_SEQ_CST, "workgroup", "local") __builtin_amdgcn_fence(__ATOMIC_SEQ_CST, "workgroup", "local", "global") +__builtin_amdgcn_processor_is and __bui

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-04-02 Thread Yaxun Liu via cfe-commits
@@ -585,6 +597,23 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, llvm::Value *Env = EmitScalarExpr(E->getArg(0)); return Builder.CreateCall(F, {Env}); } + case AMDGPU::BI__builtin_amdgcn_processor_is: { +assert(CGM.getTriple().isSPIRV() &&

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-04-02 Thread Alex Voicu via cfe-commits
@@ -585,6 +597,23 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, llvm::Value *Env = EmitScalarExpr(E->getArg(0)); return Builder.CreateCall(F, {Env}); } + case AMDGPU::BI__builtin_amdgcn_processor_is: { +assert(CGM.getTriple().isSPIRV() &&

[clang] fixed clang frontend crash with friend class declaration and overload == (PR #133878)

2025-04-02 Thread Ankur Ahir via cfe-commits
https://github.com/Ankur-0429 updated https://github.com/llvm/llvm-project/pull/133878 >From 289f8630dccf916b8cf7cc43758bae60df036c5d Mon Sep 17 00:00:00 2001 From: Ankur Ahir Date: Wed, 2 Apr 2025 00:53:33 -0700 Subject: [PATCH 1/4] clang frontend crash with friend class declaration and overl

[clang] [flang] [llvm] [AMDGPU] Use a target feature to enable __builtin_amdgcn_global_load_lds on gfx9/10 (PR #133055)

2025-04-02 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/133055 From 5f039ef32105132a7edf6203eb0b7825d4b8b503 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/5] [AMDGPU] Add "lds-bu

[clang] Refine multilib selection to handle alignment based on architecture features. (PR #134099)

2025-04-02 Thread Simi Pallipurath via cfe-commits
https://github.com/simpal01 created https://github.com/llvm/llvm-project/pull/134099 Update the multilib selection logic to bypass the alignment option based on each architecture’s feature set, rather than relying on command-line options. Previously, alignment option was bypassed only when -mn

[clang] [CodeGen] Don't include CGDebugInfo.h in CodeGenFunction.h (NFC) (PR #134100)

2025-04-02 Thread Nikita Popov via cfe-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/134100 This is an expensive header, only include it where needed. Move some functions out of line to achieve that. This reduces time to build clang by ~0.5% in terms of instructions retired. >From 86e11b2dc91f87c858b41

[clang] [Arm] Add more -mtp=cp15 tests (PR #134098)

2025-04-02 Thread Vladi Krapp via cfe-commits
https://github.com/VladiKrapp-Arm created https://github.com/llvm/llvm-project/pull/134098 This patch systematically covers all -mtp=cp15 behaviour options for better code coverage. >From c412ba5ea6df192a5b18d50f030758cf5847c181 Mon Sep 17 00:00:00 2001 From: Vladi Krapp Date: Tue, 25 Mar 202

[clang] [Arm] Add more -mtp=cp15 tests (PR #134098)

2025-04-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vladi Krapp (VladiKrapp-Arm) Changes This patch systematically covers all -mtp=cp15 behaviour options for better code coverage. --- Full diff: https://github.com/llvm/llvm-project/pull/134098.diff 1 Files Affected: - (modified) clang/t

[clang] fixed clang frontend crash with friend class declaration and overload == (PR #133878)

2025-04-02 Thread Ankur Ahir via cfe-commits
https://github.com/Ankur-0429 updated https://github.com/llvm/llvm-project/pull/133878 >From 289f8630dccf916b8cf7cc43758bae60df036c5d Mon Sep 17 00:00:00 2001 From: Ankur Ahir Date: Wed, 2 Apr 2025 00:53:33 -0700 Subject: [PATCH 1/4] clang frontend crash with friend class declaration and overl

[clang] [CodeGen] Don't include CGDebugInfo.h in CodeGenFunction.h (NFC) (PR #134100)

2025-04-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Nikita Popov (nikic) Changes This is an expensive header, only include it where needed. Move some functions out of line to achieve that. This reduces time to build clang by ~0.5% in terms of instructions retired. --- Full diff: h

[clang] [Arm] Add more -mtp=cp15 tests (PR #134098)

2025-04-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Vladi Krapp (VladiKrapp-Arm) Changes This patch systematically covers all -mtp=cp15 behaviour options for better code coverage. --- Full diff: https://github.com/llvm/llvm-project/pull/134098.diff 1 Files Affected: - (modified)

<    1   2   3   4   >