@@ -386,13 +386,22 @@ llvm::Type *CommonSPIRTargetCodeGenInfo::getHLSLType(
if (ContainedTy.isNull())
return nullptr;
-assert(!ResAttrs.RawBuffer &&
- "Raw buffers handles are not implemented for SPIR-V yet");
assert(!ResAttrs.IsROV &&
llvmbot wrote:
@llvm/pr-subscribers-hlsl
@llvm/pr-subscribers-clang-codegen
Author: Steven Perron (s-perron)
Changes
This PR adds the target type for main storage for HLSL raw buffer types.
It does not handle the counter variables that are associated with those
buffers.
This is implementi
jhuber6 wrote:
> > Why does this only cause warnings when it makes dependency files?
>
> Because `--offloading-compress` is parsed by offload bundler and offload
> wrapper actions when creating job actions. There is no action to parse them
> in the compilation that only generates dependency fi
@@ -0,0 +1,304 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+
+// REQUIRES: aarch64-registered-target
+// RUN: %clang_cc1 -triple aarch64 -target-feature +bf16 -target-feature
+sme-mop4 -target-feature +sme-f16f16 -target-feature +sme-i16i64
https://github.com/steakhal commented:
LGTM, thanks.
https://github.com/llvm/llvm-project/pull/133381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -511,13 +511,9 @@ SVal StoreManager::getLValueElement(QualType elementType,
NonLoc Offset,
// Only allow non-integer offsets if the base region has no offset itself.
// FIXME: This is a somewhat arbitrary restriction. We should be using
// SValBuilder here to add the
https://github.com/steakhal deleted
https://github.com/llvm/llvm-project/pull/133381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,146 @@
+//===- LValueElementTest.cpp ---===//
steakhal wrote:
+1
https://github.com/llvm/llvm-project/pull/133381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
yxsamliu wrote:
> > > Why does this only cause warnings when it makes dependency files?
> >
> >
> > Because `--offloading-compress` is parsed by offload bundler and offload
> > wrapper actions when creating job actions. There is no action to parse them
> > in the compilation that only generat
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/133381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -305,6 +320,38 @@ void UseEmplaceCheck::registerMatchers(MatchFinder
*Finder) {
this);
}
+const Expr *unwrapInnerExpression(const Expr *E) {
vbvictor wrote:
This function should be made `static` to restrict visibility
https://github.com/llvm/llvm-p
Sirraide wrote:
Hmm, @erichkeane probably knows *where* this needs to be parsed then; I might
take another look at this myself later (because I’m not sure either off the top
of my head), but I’m rather busy today unfortunately...
https://github.com/llvm/llvm-project/pull/133107
___
ilya-biryukov wrote:
The small-scale benchmarks we had show 10% improvement in CPU and 23%
improvement in memory usage for some compilations!
We did hit one compiler error that does not reproduce without modules, however:
```error: use of overloaded operator '=' is ambiguous```
We're in the pr
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,
Juan Manuel Martinez =?utf-8?q?Caamaño?=
Message-ID:
In-Reply-To:
@@ -0,0 +1,45 @@
+; RUN: split-file %s %t
+;
+; RUN: not --crash llc -mtriple=amdgcn -mcpu=gfx1100 %t/struct.ll 2>&1 |
FileCheck --ignore-case %s
+; RUN: not --crash ll
https://github.com/AaronBallman commented:
Thanks for the additional test coverage! It looks like precommit CI found some
issues with your tests that should be addressed:
https://buildkite.com/llvm-project/github-pull-requests/builds/162502#0195d9e8-2c29-426e-9be0-afda7efd7d93
https://github.c
@@ -102,6 +126,11 @@ void test_unspecified_array_length() {
static_assert(_Countof(**x) == 3);
}
+void test_completed_array() {
+ int a[] = {1, 2, errno};
AaronBallman wrote:
Best not to use `errno` here, just replace with `3`.
https://github.com/llvm/llv
@@ -9332,11 +9332,22 @@ void LinkerWrapper::ConstructJob(Compilation &C, const
JobAction &JA,
// Add the linker arguments to be forwarded by the wrapper.
CmdArgs.push_back(Args.MakeArgString(Twine("--linker-path=") +
LinkCommand->getE
Author: Qiu Chaofan
Date: 2025-03-29T01:54:14+08:00
New Revision: b3f01a6aa45b00240cec1c64286b85d7ba87e2af
URL:
https://github.com/llvm/llvm-project/commit/b3f01a6aa45b00240cec1c64286b85d7ba87e2af
DIFF:
https://github.com/llvm/llvm-project/commit/b3f01a6aa45b00240cec1c64286b85d7ba87e2af.diff
L
https://github.com/ecnelises closed
https://github.com/llvm/llvm-project/pull/131608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jansvoboda11 wrote:
> Are you planning to do the same for LangOpts and HSOpts? What's the ultimate
> goal here?
Yes, I'd like to do this for all options. The immediate goal is for
`CompilerInvocation` to be the only class responsible for managing lifetimes of
the underlying `Options` objects.
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/132027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu created
https://github.com/llvm/llvm-project/pull/133500
https://github.com/llvm/llvm-project/pull/102040/files#diff-125f472e690aa3d973bc42aa3c5d580226c5c47661551aca2889f960681aa64dR2477
added 1 bit to `RecordDecl`'s serialization format, but did not increment its
vbvictor wrote:
@carlosgalvezp, when all checks are passed, could you merge this please, thank
you.
https://github.com/llvm/llvm-project/pull/133436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/vbvictor commented:
Few nits.
Thought, I'm not very familiar this kind of AST-matchers and PR needs review
from someone else.
https://github.com/llvm/llvm-project/pull/131969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
vgvassilev wrote:
> The small-scale benchmarks we had show 10% improvement in CPU and 23%
> improvement in memory usage for some compilations!
That's very good news. I think we can further reduce these times. IIRC, we
still deserialize declarations that we do not need. One of the places to loo
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/132214
>From 91e057bf990e2c454b897982ed0b4e823bb3faba Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 20 Mar 2025 06:51:46 -0700
Subject: [PATCH 1/7] [clang] Fix for regression #130917
Changes in #111992
vbvictor wrote:
@PiotrZSL, could you please merge this PR when you have time, thank you.
https://github.com/llvm/llvm-project/pull/132573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/Keenuts created
https://github.com/llvm/llvm-project/pull/133464
In SPIR-V, private global variables have the Private storage class. This PR
adds a new address space which allows frontend to emit variable with this
storage class when targeting this backend.
This is covered
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nathan Gauër (Keenuts)
Changes
In SPIR-V, private global variables have the Private storage class. This PR
adds a new address space which allows frontend to emit variable with this
storage class when targeting this backend.
This is cover
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Nathan Gauër (Keenuts)
Changes
In SPIR-V, private global variables have the Private storage class. This PR
adds a new address space which allows frontend to emit variable with this
storage class when targeting this backend.
Thi
llvmbot wrote:
@llvm/pr-subscribers-backend-webassembly
Author: Nathan Gauër (Keenuts)
Changes
In SPIR-V, private global variables have the Private storage class. This PR
adds a new address space which allows frontend to emit variable with this
storage class when targeting this backend.
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Justin Cady (justincady)
Changes
In cases where a terminating statement exists within the try or catch
block the coverage mapping can be incorrect. Coverage reports display
lines following the last catch block as uncovered, when the
Keenuts wrote:
> Is there a reason we can't do this in Sema? It would probably be ideal to
> have the AST represent the address spaces of values accurately.
Hello! So I didn't recalled the details on why, so I made another PR which
implements this in sema (https://github.com/llvm/llvm-project/
https://github.com/Keenuts edited
https://github.com/llvm/llvm-project/pull/133464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-modules
Author: Naveen Seth Hanig (naveen-seth)
Changes
When using -fmodule-file== with incorrect
inputs, the compiler crashes in two scenarios:
1. A module is mapped to the right BMI file but one of
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Nathan Gauër (Keenuts)
Changes
In SPIR-V, private global variables have the Private storage class. This PR
adds a new address space which allows frontend to emit variable with this
storage class when targeting this backend.
This
https://github.com/justincady created
https://github.com/llvm/llvm-project/pull/133463
In cases where a terminating statement exists within the try or catch
block the coverage mapping can be incorrect. Coverage reports display
lines following the last catch block as uncovered, when the lines hav
https://github.com/naveen-seth reopened
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,78 @@
+// RUN: %clang_cc1 -finclude-default-header -fnative-half-type -triple \
+// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o
- | \
+// RUN: FileCheck %s --check-prefixes=CHECK,CHECK-DXIL
+// RUN: %clang_cc1 -finclude-default-header
https://github.com/V-FEXrt edited
https://github.com/llvm/llvm-project/pull/131237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic commented:
Addressed review comments. We now reject g3() and g5(), the cases that
involved using a local variable in a constexpr function in its own initializer.
https://github.com/llvm/llvm-project/pull/132990
___
cf
https://github.com/ayushpareek2003 created
https://github.com/llvm/llvm-project/pull/133526
Both Unix (./, ../) and Windows (.\, ..\) path formats are handled properly
>From 7c70f0c2bf45b34c1134820a21ec169777bce7bf Mon Sep 17 00:00:00 2001
From: Ayush Pareek
Date: Sat, 29 Mar 2025 03:25:39 +05
@@ -759,6 +761,84 @@ def BrCondOp : CIR_Op<"brcond",
}];
}
+//===--===//
+// While & DoWhileOp
+//===--===//
+
+class WhileOpBase : CIR_Op
vbvictor wrote:
@PiotrZSL, Ping
https://github.com/llvm/llvm-project/pull/126434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM, assuming CI passes.
https://github.com/llvm/llvm-project/pull/131280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 539ef5eee2c26b93923ed7872c6f847ff54c71ae
faa91ba78a7b27e9122a962dd235d02018e50aca --e
https://github.com/nico approved this pull request.
https://github.com/llvm/llvm-project/pull/133511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lenary updated
https://github.com/llvm/llvm-project/pull/132721
>From 12e1667575a3b506c5758bd976134e11ccb77f5c Mon Sep 17 00:00:00 2001
From: Harsh Chandel
Date: Mon, 24 Mar 2025 16:15:20 +0530
Subject: [PATCH 1/3] [RISCV] Add Qualcomm uC Xqciio (External Input Output)
exten
https://github.com/lenary closed
https://github.com/llvm/llvm-project/pull/132721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: quic_hchandel
Date: 2025-03-28T19:47:29-07:00
New Revision: edef028029c4785dfe23c06731de4fc9f34d5cd5
URL:
https://github.com/llvm/llvm-project/commit/edef028029c4785dfe23c06731de4fc9f34d5cd5
DIFF:
https://github.com/llvm/llvm-project/commit/edef028029c4785dfe23c06731de4fc9f34d5cd5.diff
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/133550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-03-28T19:55:32-07:00
New Revision: d3c10a3897ccd060090ca273de4cedb91cd2d605
URL:
https://github.com/llvm/llvm-project/commit/d3c10a3897ccd060090ca273de4cedb91cd2d605
DIFF:
https://github.com/llvm/llvm-project/commit/d3c10a3897ccd060090ca273de4cedb91cd2d605.diff
L
https://github.com/qinkunbao created
https://github.com/llvm/llvm-project/pull/133558
None
>From b70f73142fbf0b6060bc3c632767606bfd745f0b Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Sat, 29 Mar 2025 03:00:38 +
Subject: [PATCH] Fix some typos under clang
---
clang/docs/BoundsSafety.rs
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qinkun Bao (qinkunbao)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/133558.diff
11 Files Affected:
- (modified) clang/docs/BoundsSafety.rst (+2-2)
- (modified) clang/docs/ConstantInterpreter.rst (+1-1)
- (modified
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Qinkun Bao (qinkunbao)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/133558.diff
11 Files Affected:
- (modified) clang/docs/BoundsSafety.rst (+2-2)
- (modified) clang/docs/ConstantInterpreter.rst (+1-1)
- (modified)
https://github.com/zeule updated
https://github.com/llvm/llvm-project/pull/131605
>From 849636c372580082b8c67d7d66728788d284ebee Mon Sep 17 00:00:00 2001
From: Eugene Shalygin
Date: Mon, 17 Mar 2025 11:23:35 +0100
Subject: [PATCH] [clang-format] option to control bin-packing keyworded
paramete
llvmbot wrote:
@llvm/pr-subscribers-pgo
Author: Ethan Luis McDonough (EthanLuisMcDonough)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/133522.diff
5 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Clang.cpp (+3-1)
- (added) clang/test/Driver/cuda-no-pgo-o
jyknight wrote:
I now see there's two different parts of the problem to worry about:
First case: A redeclaration in a _different_ scope. This always defines a new
distinct type. This was valid before C23, and is still valid regardless of
whether the type is compatible. (In contrast with functi
Author: Kaitlin Peng
Date: 2025-03-29T00:47:25-04:00
New Revision: 40c1d50024f8f0306b8601559d69663ae3d2d9bb
URL:
https://github.com/llvm/llvm-project/commit/40c1d50024f8f0306b8601559d69663ae3d2d9bb
DIFF:
https://github.com/llvm/llvm-project/commit/40c1d50024f8f0306b8601559d69663ae3d2d9bb.diff
https://github.com/farzonl closed
https://github.com/llvm/llvm-project/pull/132288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc edited
https://github.com/llvm/llvm-project/pull/133031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/133508
>From 6234f442adfebaaf73328d2c09ee443facc848b0 Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Thu, 27 Mar 2025 09:26:31 -0500
Subject: [PATCH 1/4] [HLSL] Handle incomplete array types
This refactors the
https://github.com/bcardosolopes approved this pull request.
I don't have anything else to add, LGTM!
https://github.com/llvm/llvm-project/pull/132974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -710,6 +710,89 @@ class ScalarExprEmitter : public
StmtVisitor {
HANDLEBINOP(Xor)
HANDLEBINOP(Or)
#undef HANDLEBINOP
+
+ mlir::Value emitCmp(const BinaryOperator *e) {
+mlir::Value result;
+QualType lhsTy = e->getLHS()->getType();
+QualType rhsTy = e->getRH
https://github.com/lenary updated
https://github.com/llvm/llvm-project/pull/132721
>From 12e1667575a3b506c5758bd976134e11ccb77f5c Mon Sep 17 00:00:00 2001
From: Harsh Chandel
Date: Mon, 24 Mar 2025 16:15:20 +0530
Subject: [PATCH 1/4] [RISCV] Add Qualcomm uC Xqciio (External Input Output)
exten
https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/133550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hulxv wrote:
It works without problems now😄
https://github.com/llvm/llvm-project/pull/131280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hulxv updated
https://github.com/llvm/llvm-project/pull/131280
>From bf9bd4156cb7f652c9cf0477f537e5c58b470448 Mon Sep 17 00:00:00 2001
From: hulxv
Date: Fri, 14 Mar 2025 07:39:15 +0200
Subject: [PATCH 01/17] [clang-doc] [feat] add `--repository-line-prefix`
argument (fix #59
@@ -401,7 +401,7 @@ def tblockaddress: SDNode<"ISD::TargetBlockAddress",
SDTPtrLeaf, [],
def add: SDNode<"ISD::ADD" , SDTIntBinOp ,
[SDNPCommutative, SDNPAssociative]>;
-def ptradd : SDNode<"ISD::ADD" , SDTPtrAddOp, []>;
+def
@@ -10918,7 +11083,44 @@ bool
OverloadCandidate::NotValidBecauseConstraintExprHasError() const {
OverloadingResult
OverloadCandidateSet::BestViableFunction(Sema &S, SourceLocation Loc,
iterator &Best) {
+
+ bool TwoPhaseResolution =
+
https://github.com/alejandro-colomar edited
https://github.com/llvm/llvm-project/pull/13
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?=
Message-ID:
In-Reply-To:
topperc wrote:
This should be two different PRs. One for clang and one for the RISCV backend.
The reviewers for each area are different.
https://github.com/llvm/llvm-pro
https://github.com/DenisGZM updated
https://github.com/llvm/llvm-project/pull/133107
>From c46eda67cd7434dcce5c1f29125a940dc4ff64ba Mon Sep 17 00:00:00 2001
From: Denis Gerasimov
Date: Wed, 26 Mar 2025 18:29:38 +0300
Subject: [PATCH 1/2] [CLANG] Enable alignas after GNU attributes
---
clang/l
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/133456
Cmake automatically generates dependency files with all compilation options
provided by users. When users use `--offload-compress` for HIP compilation, it
causes warnings when cmake generates dependency files.
https://github.com/yxsamliu edited
https://github.com/llvm/llvm-project/pull/133456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Cmake automatically generates dependency files with all compilation options
provided by users. When users use `--offload-compress` for HIP compilation, it
causes warnings when cmake generates depe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Cmake automatically generates dependency files with all compilation options
provided by users. When users use `--offload-compress` for HIP compilation, it
causes warnings when cmake generates dependency
@@ -71,12 +72,12 @@ def try_run(args, raise_error=True):
# This class represents the appearance of a message prefix in a file.
class MessagePrefix:
-def __init__(self, label):
+def __init__(self, label: str):
EugeneZelenko wrote:
```suggestion
def
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/133451
>From fdab7da3d6dd98bcc7961625f01bea0a6eb07388 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 28 Mar 2025 06:28:32 -0700
Subject: [PATCH 1/3] Revert "Revert "[MS][clang] Add support for vec
@@ -7976,6 +7976,8 @@ void
CodeGenModule::requireVectorDestructorDefinition(const CXXRecordDecl *RD) {
auto *NewFn = llvm::Function::Create(
cast(VDEntry->getValueType()),
llvm::Function::ExternalLinkage, VDName, &getModule());
+SetFunctionAttributes(Ve
https://github.com/efriedma-quic approved this pull request.
LGTM.
(I'll merge once the premerge checks come back.)
https://github.com/llvm/llvm-project/pull/126481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
@@ -7976,6 +7976,8 @@ void
CodeGenModule::requireVectorDestructorDefinition(const CXXRecordDecl *RD) {
auto *NewFn = llvm::Function::Create(
cast(VDEntry->getValueType()),
llvm::Function::ExternalLinkage, VDName, &getModule());
+SetFunctionAttributes(Ve
https://github.com/zmodem approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/133265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zmodem approved this pull request.
I didn't look at the original patch, but the fix and test update lgtm.
https://github.com/llvm/llvm-project/pull/133451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 8e94a94094fd3ecfe3554f4e7c1812d8c79ea07d Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/12] [flang-rt] Pass the whole path of libflang_rt.runtime.a
janagor wrote:
Ahh, I see, thanks for info. I will close this this PR and split into two
different PR's.
https://github.com/llvm/llvm-project/pull/133406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/janagor closed
https://github.com/llvm/llvm-project/pull/133406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/133451
Whereas it is UB in terms of the standard to delete an array of objects
via pointer whose static type doesn't match its dynamic type, MSVC
supports an extension allowing to do it.
Aside from array deletion not
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-clang-modules
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Whereas it is UB in terms of the standard to delete an array of objects
via pointer whose static type doesn't match its dynamic type, MSVC
supports an extensio
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Whereas it is UB in terms of the standard to delete an array of objects
via pointer whose static type doesn't match its dynamic type, MSVC
supports an extension allowing to do it.
Aside from
@@ -8747,28 +8752,32 @@ Value *CodeGenFunction::EmitCommonNeonBuiltinExpr(
return Builder.CreateBitCast(Result, ResultType, NameHint);
}
-Value *CodeGenFunction::EmitAArch64CompareBuiltinExpr(
-Value *Op, llvm::Type *Ty, const CmpInst::Predicate Fp,
-const CmpInst::P
Midar wrote:
Thanks for merging! Is there a way to get this into 20.1.2?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/132848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
Good catch! Changes LGTM with a minor change to the diagnostic to quote the
construct.
If we wanted to improve the diagnostic wording further, it might help to say
"is a Clang extension" so the user understands why the diagnostic is b
@@ -7031,10 +7031,10 @@ def err_offsetof_incomplete_type : Error<
def err_offsetof_record_type : Error<
"offsetof requires struct, union, or class type, %0 invalid">;
def err_offsetof_array_type : Error<"offsetof requires array type, %0
invalid">;
-def ext_offsetof_non_pod_t
@@ -7031,10 +7031,10 @@ def err_offsetof_incomplete_type : Error<
def err_offsetof_record_type : Error<
"offsetof requires struct, union, or class type, %0 invalid">;
def err_offsetof_array_type : Error<"offsetof requires array type, %0
invalid">;
-def ext_offsetof_non_pod_t
201 - 300 of 455 matches
Mail list logo
