[clang] [Clang][CodeGen][UBSan] Add more precise attributes to recoverable ubsan handlers (PR #130990)

2025-03-28 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/130990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Optimize Module Dependency Handling for Efficient Memory Usage (PR #132638)

2025-03-28 Thread Ayush Pareek via cfe-commits
ayushpareek2003 wrote: @Bigcheese sir please have a look https://github.com/llvm/llvm-project/pull/132638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Format] Use a range constructor of DenseSet (NFC) (PR #133382)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/133382.diff 1 Files Affected: - (modified) clang/lib/Format/MacroCallReconstructor.cpp (+3-3) ``diff diff --git a/clang/lib

[libclc] 0a74cbf - [libclc] Pass -fapprox-func when compiling 'native' builtins (#133119)

2025-03-28 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-03-28T08:22:19Z New Revision: 0a74cbfac462dfbf446e1f560e987619f93194ac URL: https://github.com/llvm/llvm-project/commit/0a74cbfac462dfbf446e1f560e987619f93194ac DIFF: https://github.com/llvm/llvm-project/commit/0a74cbfac462dfbf446e1f560e987619f93194ac.diff LOG

[clang] [PATCH] [clang][frontend] Fix serialization for CXXConstructorDecl (refs llvm#132794) (PR #133077)

2025-03-28 Thread Paul Schwabauer via cfe-commits
https://github.com/koplas edited https://github.com/llvm/llvm-project/pull/133077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Pass -fapprox-func when compiling 'native' builtins (PR #133119)

2025-03-28 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/133119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PATCH] [clang][frontend] Fix serialization for CXXConstructorDecl (refs llvm#132794) (PR #133077)

2025-03-28 Thread Paul Schwabauer via cfe-commits
koplas wrote: @shafik, I updated the commit message based on the feedback of @cor3ntin. I have now updated the title and description to reflect the new commit message, to avoid further confusion. https://github.com/llvm/llvm-project/pull/133077 ___ c

[clang] [WIP] Fix the crash when dump the deserialized decl (PR #133395)

2025-03-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/133395 None >From 4095be6747a5d6f3cd619c644490c4170ab44d89 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 28 Mar 2025 09:32:50 +0100 Subject: [PATCH] [WIP] Fix the crash when dump the deserialized decl --- .../

[clang] [WIP] Fix the crash when dump the deserialized decl (PR #133395)

2025-03-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 420c056f853d9d5475fc98407ea99b67a11841eb 4095be6747a5d6f3cd619c644490c4170ab44d89 --e

[clang] Unknown array lvalue element (PR #133381)

2025-03-28 Thread via cfe-commits
https://github.com/T-Gruber updated https://github.com/llvm/llvm-project/pull/133381 >From 241c95a956a440b9a118654baad55fb253d2413c Mon Sep 17 00:00:00 2001 From: T-Gruber Date: Fri, 28 Mar 2025 07:37:59 +0100 Subject: [PATCH 1/5] Remove early return for UnknownVal --- clang/lib/StaticAnalyze

[clang] [RISCV] Implement Clang Builtins for XCVmac Extension in CV32E40P (PR #110623)

2025-03-28 Thread via cfe-commits
https://github.com/realqhc updated https://github.com/llvm/llvm-project/pull/110623 >From da8b2fc0b5815f5870efe650ba5d585ec14e1a08 Mon Sep 17 00:00:00 2001 From: Qihan Cai Date: Tue, 1 Oct 2024 12:14:15 +1000 Subject: [PATCH 1/4] [RISCV] Implement Clang Builtins for XCVmac Extension in CV32E40

[clang] [clang] fix constexpr-unknown handling of self-references. (PR #132990)

2025-03-28 Thread via cfe-commits
@@ -177,3 +177,50 @@ namespace extern_reference_used_as_unknown { int y; constinit int& g = (x,y); // expected-warning {{left operand of comma operator has no effect}} } + +namespace uninit_reference_used { + int y; + constexpr int &r = r; // expected-error {{must be ini

[clang] 1318a7b - Reland [MIPS] Define SubTargetFeature for i6500 cpu (#132907) (#133366)

2025-03-28 Thread via cfe-commits
Author: Mallikarjuna Gouda Date: 2025-03-28T09:49:38+01:00 New Revision: 1318a7bb098ff055533d7b3fe2f5d9201f3d79a6 URL: https://github.com/llvm/llvm-project/commit/1318a7bb098ff055533d7b3fe2f5d9201f3d79a6 DIFF: https://github.com/llvm/llvm-project/commit/1318a7bb098ff055533d7b3fe2f5d9201f3d79a6.

[clang] [llvm] Reland [MIPS] Define SubTargetFeature for i6500 cpu (#132907) (PR #133366)

2025-03-28 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro approved this pull request. https://github.com/llvm/llvm-project/pull/133366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland [MIPS] Define SubTargetFeature for i6500 cpu (#132907) (PR #133366)

2025-03-28 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro closed https://github.com/llvm/llvm-project/pull/133366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [flang] [libc] [libcxx] [llvm] [Clang][AMDGPU] Remove special handling for COV4 libraries (PR #132870)

2025-03-28 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. Thanks, Joseph! LGTM. https://github.com/llvm/llvm-project/pull/132870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move pow, powr & pown to the CLC library (PR #133294)

2025-03-28 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/133294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PATCH] [clang][frontend] Fix serialization for CXXConstructorDecl (refs llvm#132794) (PR #133077)

2025-03-28 Thread Paul Schwabauer via cfe-commits
https://github.com/koplas edited https://github.com/llvm/llvm-project/pull/133077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/133395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/133395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes This fixes crashes with `-dump-deserialized-decls`. The `DeserializedDeclsDumper` implementation has two issues: 1. The `DelegatingDeserializationListener` does not fully implement all interfaces. As a result

[clang] [RFC][clang] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-03-28 Thread Chuanqi Xu via cfe-commits
@@ -1390,7 +1390,19 @@ class ASTReader /// predefines buffer may contain additional definitions. std::string SuggestedPredefines; - llvm::DenseMap DefinitionSource; + struct DefinitionSourceFlags { ChuanqiXu9 wrote: ```suggestion struct DefinitionSour

[clang] [RFC][clang] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-03-28 Thread Chuanqi Xu via cfe-commits
@@ -1390,7 +1390,19 @@ class ASTReader /// predefines buffer may contain additional definitions. std::string SuggestedPredefines; - llvm::DenseMap DefinitionSource; + struct DefinitionSourceFlags { +ExtKind HasExternalDefinitions : 2; + +/// Indicates if given fu

[clang] [Serialization] Fix lazy template loading (PR #133057)

2025-03-28 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > > > While I may not able to look into them in detail recently, it may be > > > > helpful to split this into seperate patches to review and to land. > > > > > > > > > I initially considered this, but @vgvassilev said in > > > [root-project/root#17722 > > > (comment)](htt

[clang] [WIP] Fix the crash when dump the deserialized decl (PR #133395)

2025-03-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/133395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Haojian Wu (hokein) Changes This fixes crashes with `-dump-deserialized-decls`. The `DeserializedDeclsDumper` implementation has two issues: 1. The `DelegatingDeserializationListener` does not fully implement all interfaces. As

[clang] [Serialization] Fix lazy template loading (PR #133057)

2025-03-28 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > > > > > While I may not able to look into them in detail recently, it may be > > > > > helpful to split this into seperate patches to review and to land. > > > > > > > > > > > > I initially considered this, but @vgvassilev said in > > > > [root-project/root#17722 > > > >

[clang] [RFC][clang] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-03-28 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: LGTM generally. Some other personal suggestion to the title, it might be better to add `[modules]` to the title. Since my mail filter will highlight these mails with the tag : ) This might be why I missed you last ping. https://github.com/llvm/llvm-project/pull/132214 __

[clang] [CIR] Upstream SelectOp and ShiftOp (PR #133405)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Morris Hafner (mmha) Changes Since SelectOp will only generated by a future pass that transforms a TernaryOp this only includes the lowering bits. This patch also improves the testing of the existing binary operators. --- Patch is 28.28

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo approved this pull request. Thank you @hokein! https://github.com/llvm/llvm-project/pull/133395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream SelectOp and ShiftOp (PR #133405)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Morris Hafner (mmha) Changes Since SelectOp will only generated by a future pass that transforms a TernaryOp this only includes the lowering bits. This patch also improves the testing of the existing binary operators. --- Patch is 28.

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes It turns out trailing objects are uninitialized and APValue assignment operator requires a fully initialized object. --- Full diff: https://github.com/llvm/llvm-project/pull/132091.diff 3 Files Affected: - (m

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/131237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [modules] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-03-28 Thread Dmitry Polukhin via cfe-commits
@@ -1390,7 +1390,19 @@ class ASTReader /// predefines buffer may contain additional definitions. std::string SuggestedPredefines; - llvm::DenseMap DefinitionSource; + struct DefinitionSourceFlags { dmpolukhin wrote: Done https://github.com/llvm/llvm-pr

[clang] [modules] Handle friend function that was a definition but became only a declaration during AST deserialization (PR #132214)

2025-03-28 Thread Dmitry Polukhin via cfe-commits
@@ -1390,7 +1390,19 @@ class ASTReader /// predefines buffer may contain additional definitions. std::string SuggestedPredefines; - llvm::DenseMap DefinitionSource; + struct DefinitionSourceFlags { +ExtKind HasExternalDefinitions : 2; + +/// Indicates if given fu

[clang] [Clang][WIP][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-03-28 Thread Younan Zhang via cfe-commits
@@ -10905,6 +10983,93 @@ bool OverloadCandidate::NotValidBecauseConstraintExprHasError() const { ->Satisfaction.ContainsErrors; } +void OverloadCandidateSet::AddNonDeducedTemplateCandidate( +FunctionTemplateDecl *FunctionTemplate, DeclAccessPair FoundDecl, +

[clang] [Clang][WIP][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-03-28 Thread Younan Zhang via cfe-commits
@@ -10918,7 +11083,44 @@ bool OverloadCandidate::NotValidBecauseConstraintExprHasError() const { OverloadingResult OverloadCandidateSet::BestViableFunction(Sema &S, SourceLocation Loc, iterator &Best) { + + bool TwoPhaseResolution = +

[clang] [Clang][WIP][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-03-28 Thread Younan Zhang via cfe-commits
@@ -10918,7 +11083,44 @@ bool OverloadCandidate::NotValidBecauseConstraintExprHasError() const { OverloadingResult OverloadCandidateSet::BestViableFunction(Sema &S, SourceLocation Loc, iterator &Best) { + + bool TwoPhaseResolution = +

[clang] [Clang][WIP][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-03-28 Thread Younan Zhang via cfe-commits
@@ -10975,9 +11176,8 @@ OverloadCandidateSet::BestViableFunction(Sema &S, SourceLocation Loc, if (Best == end()) return OR_No_Viable_Function; + llvm::SmallVector PendingBest; llvm::SmallVector EquivalentCands; - - llvm::SmallVector PendingBest; zy

[clang] [llvm] [mlir] [MLIR][OpenMP] Add codegen for teams reductions (PR #133310)

2025-03-28 Thread Jan Leyonberg via cfe-commits
https://github.com/jsjodin updated https://github.com/llvm/llvm-project/pull/133310 >From 50fefbb31f4de7352c241c48fe5382785daaef21 Mon Sep 17 00:00:00 2001 From: Jan Leyonberg Date: Sun, 23 Mar 2025 09:56:51 -0400 Subject: [PATCH 01/10] Initial modifications to support reductions in flang. ---

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread Ilya Biryukov via cfe-commits
@@ -57,6 +59,8 @@ class ASTDeserializationListener { /// A module import was read from the AST file. virtual void ModuleImportRead(serialization::SubmoduleID ID, SourceLocation ImportLoc) {} + /// The deserialization of the AST file was fini

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread Ilya Biryukov via cfe-commits
@@ -103,15 +120,30 @@ class DeserializedDeclsDumper : public DelegatingDeserializationListener { : DelegatingDeserializationListener(Previous, DeletePrevious) {} void DeclRead(GlobalDeclID ID, const Decl *D) override { -llvm::outs() << "PCH DECL: " << D->getDeclKi

[clang] [clang] Implement some missing interfaces for DelegatingDeserializationListener (PR #133424)

2025-03-28 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

2025-03-28 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > I'm happy to split the patch. I agree that (2) requires more thought and > careful consideration. I'm not sure I'll have time to finish it before my > leave, so I might have to leave it to you. But I can take care of (1). Yeah, I feel it makes sense to abandon this until

[clang] c4bc1b1 - [clang] Update Mach-O ptrauth driver defaults (#132834)

2025-03-28 Thread via cfe-commits
Author: Nico Weber Date: 2025-03-28T08:34:25-04:00 New Revision: c4bc1b1d8177961c50c7a197bfb97b5226e749ff URL: https://github.com/llvm/llvm-project/commit/c4bc1b1d8177961c50c7a197bfb97b5226e749ff DIFF: https://github.com/llvm/llvm-project/commit/c4bc1b1d8177961c50c7a197bfb97b5226e749ff.diff LO

[clang] [clang] Update Mach-O ptrauth driver defaults (PR #132834)

2025-03-28 Thread Nico Weber via cfe-commits
nico wrote: Thanks! I'm feeling reasonably confident about this one and it's been a few days, so I'll hit the button :) https://github.com/llvm/llvm-project/pull/132834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [clang] Update Mach-O ptrauth driver defaults (PR #132834)

2025-03-28 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/132834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 772173f - [Clang][AMDGPU] Remove special handling for COV4 libraries (#132870)

2025-03-28 Thread via cfe-commits
Author: Joseph Huber Date: 2025-03-28T07:35:16-05:00 New Revision: 772173f54868eef6e1a4d40ab93b0ee6c04b1aca URL: https://github.com/llvm/llvm-project/commit/772173f54868eef6e1a4d40ab93b0ee6c04b1aca DIFF: https://github.com/llvm/llvm-project/commit/772173f54868eef6e1a4d40ab93b0ee6c04b1aca.diff

[clang-tools-extra] [clang-tidy][NFC] improve documentation for `bugprone-argument-comment` check (PR #133436)

2025-03-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/133436 Improve docs for `bugprone-argument-comment` check by writing explicitly default values for options. Before this change, it was unclear what values are default. >From 916062c02019d805f94f494e9ded33c0f40462e2 M

[clang] [analyzer] Fix format attribute handling in GenericTaintChecker (PR #132765)

2025-03-28 Thread LLVM Continuous Integration via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla-2stage` running on `linaro-g3-01` while building `clang` at step 12 "ninja check 2". Full details are available at: https://lab

[clang] [compiler-rt] [flang] [libc] [libcxx] [llvm] [Clang][AMDGPU] Remove special handling for COV4 libraries (PR #132870)

2025-03-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/132870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] improve documentation for `bugprone-argument-comment` check (PR #133436)

2025-03-28 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] [feat] add --repository-line-prefix argument (PR #131280)

2025-03-28 Thread Mohamed Emad via cfe-commits
hulxv wrote: @ilovepi Ping https://github.com/llvm/llvm-project/pull/131280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [PGO][Offload] Allow PGO flags to be used on GPU targets (PR #94268)

2025-03-28 Thread Artem Belevich via cfe-commits
Artem-B wrote: @jhuber6 @jdoerfert I propose reverting the change, unless it can be quickly fixed forward so it does not affect CUDA/NVPTX. https://github.com/llvm/llvm-project/pull/94268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] [clang-doc] Allow setting a base directory for hosted pages (PR #132482)

2025-03-28 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **Mar 28, 3:48 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/132482). https://github.com/llvm/llvm-project/pull/132482

[clang-tools-extra] [clang-doc] Allow setting a base directory for hosted pages (PR #132482)

2025-03-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/132482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [PGO][Offload] Allow PGO flags to be used on GPU targets (PR #94268)

2025-03-28 Thread Ethan Luis McDonough via cfe-commits
EthanLuisMcDonough wrote: Thank you all for making me aware of this. I'll look into fixing this as soon as possible. https://github.com/llvm/llvm-project/pull/94268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [NFC] [dataflow] generalize smart pointer caching (PR #133350)

2025-03-28 Thread Florian Mayer via cfe-commits
https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/133350 >From 8ece858e76fad0962b2567f03bf80bcaf2828348 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Thu, 27 Mar 2025 18:25:23 -0700 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang-tools-extra] d4dc571 - [clang-doc] Allow setting a base directory for hosted pages (#132482)

2025-03-28 Thread via cfe-commits
Author: Paul Kirth Date: 2025-03-28T12:49:43-07:00 New Revision: d4dc5712c47dab5f5dcfc329db8121059b591fb1 URL: https://github.com/llvm/llvm-project/commit/d4dc5712c47dab5f5dcfc329db8121059b591fb1 DIFF: https://github.com/llvm/llvm-project/commit/d4dc5712c47dab5f5dcfc329db8121059b591fb1.diff LO

[clang] [alpha.webkit.RawPtrRefMemberChecker] The checker doesn't warn Objective-C types in ivars. (PR #132833)

2025-03-28 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/132833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SPIR-V] Fix convergence tokens for dtor (PR #133469)

2025-03-28 Thread Steven Perron via cfe-commits
https://github.com/s-perron edited https://github.com/llvm/llvm-project/pull/133469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][NFC] Use method builder to create default resource constructor (PR #131384)

2025-03-28 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/131384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Do not share ownership of `PreprocessorOptions` (PR #133467)

2025-03-28 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. Sounds great, thanks for explaining! https://github.com/llvm/llvm-project/pull/133467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-03-28 Thread Theo de Magalhaes via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes Message-ID: In-Reply-To: https://github.c

[clang] [HLSL] Handle incomplete array types (PR #133508)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chris B (llvm-beanz) Changes This refactors the initialization list transformation code to handle incomplete array types. Fixes #132958 --- Full diff: https://github.com/llvm/llvm-project/pull/133508.diff 3 Files Affected: - (modified

[clang] [NFC] [dataflow] generalize smart pointer caching (PR #133350)

2025-03-28 Thread Florian Mayer via cfe-commits
@@ -23,12 +24,27 @@ using ast_matchers::pointerType; using ast_matchers::referenceType; using ast_matchers::returns; -bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, - bool &HasValue) { +CanQualType getLikeReturnType(QualType

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-03-28 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,34 @@ +// Fixes #59819. The underlying problem was fixed in https://reviews.llvm.org/D142560, but this patch adds a proper regression test. ilovepi wrote: ```suggestion // Regression test for https://github.com/llvm/llvm-project/issues/59819 ``` htt

[clang] [clang] Automatically add the `returns_twice` attribute to certain functions even if `-fno-builtin` is set (PR #133511)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alan Zhao (alanzhao1) Changes Certain functions require the `returns_twice` attribute in order to produce correct codegen. However, `-fno-builtin` removes all knowledge of functions that require this attribute, so this PR modifies Clang t

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-03-28 Thread Paul Kirth via cfe-commits
ilovepi wrote: > I just have submitted a GSoC proposal, can you give me some advices? This is a review thread for this feature. Please ask for feedback on the discourse thread. Typically you'd share a draft of your proposal w/ both prospective mentors over email (e.g. share a google doc or equ

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. This looks, good. really minor nit needs to be addressed then merge. https://github.com/llvm/llvm-project/pull/132288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang-format] add option to control bin-packing keyworded parameters (PR #131605)

2025-03-28 Thread Eugene Shalygin via cfe-commits
zeule wrote: Thank you, @HazardyKnusperkeks ! https://github.com/llvm/llvm-project/pull/131605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] [feat] add --repository-line-prefix argument (PR #131280)

2025-03-28 Thread Paul Kirth via cfe-commits
ilovepi wrote: If the premerge checks pass, then I'll land this. https://github.com/llvm/llvm-project/pull/131280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-03-28 Thread Sean Perry via cfe-commits
@@ -5087,6 +5087,19 @@ Decl *Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, assert(EllipsisLoc.isInvalid() && "Friend ellipsis but not friend-specified?"); + if (DS.isExportSpecified()) { +VisibilityAttr *existingAttr = TagD->getAttr(); +if

[clang] [clang] fix constexpr-unknown handling of self-references. (PR #132990)

2025-03-28 Thread Shafik Yaghmour via cfe-commits
@@ -177,3 +177,50 @@ namespace extern_reference_used_as_unknown { int y; constinit int& g = (x,y); // expected-warning {{left operand of comma operator has no effect}} } + +namespace uninit_reference_used { + int y; + constexpr int &r = r; // expected-error {{must be ini

[clang] [compiler-rt] [llvm] [PGO][Offload] Allow PGO flags to be used on GPU targets (PR #94268)

2025-03-28 Thread Artem Belevich via cfe-commits
Artem-B wrote: The crash is blocking our compiler updates. If nothing depends on this change yet, it would be great to revert the patch and re-land it once it's fixed. https://github.com/llvm/llvm-project/pull/94268 ___ cfe-commits mailing list cfe-co

[clang] [HLSL][RootSignature] Make Root Signature lexer keywords case-insensitive (PR #132967)

2025-03-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/132967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [IRBuilder] Add new overload for CreateIntrinsic (PR #131942)

2025-03-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/131942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add WaveReadLaneAt unsigned integer overloads (PR #133520)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Sarah Spall (spall) Changes Add WaveReadLaneAt unsigned integer overloads 2nd argument of WaveReadLaneAt should be a uint32_t and not an int32_t add tests Closes #133473 --- Full diff: https://github.com/llvm/llvm-project/pull/13352

[clang] [HLSL] Add WaveReadLaneAt unsigned integer overloads (PR #133520)

2025-03-28 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/133520 Add WaveReadLaneAt unsigned integer overloads 2nd argument of WaveReadLaneAt should be a uint32_t and not an int32_t add tests Closes #133473 >From 69d23f1ba200ceab78d1c108b629875b108689c0 Mon Sep 17 00:00:00 200

[clang] Optimize Module Dependency Handling for Efficient Memory Usage (PR #132638)

2025-03-28 Thread Ayush Pareek via cfe-commits
https://github.com/ayushpareek2003 updated https://github.com/llvm/llvm-project/pull/132638 >From ba67caab088be29018c17bfe47e3064db357788d Mon Sep 17 00:00:00 2001 From: Ayush Pareek Date: Mon, 24 Mar 2025 03:33:31 +0530 Subject: [PATCH] Optimize Module Dependency Handling for Efficient Memory

[clang] [HLSL] Add WaveReadLaneAt unsigned integer overloads (PR #133520)

2025-03-28 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/133520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [PGO][Offload] Allow PGO flags to be used on GPU targets (PR #94268)

2025-03-28 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > The crash is blocking our compiler updates. If nothing depends on this change > yet, it would be great to revert the patch and re-land it once it's fixed. Go ahead and revert it, but I think there were some follow-up patches. Also the `pgo1.c` and `pgo2.c` tests were flaky so

[clang] [compiler-rt] [llvm] [PGO][Offload] Allow PGO flags to be used on GPU targets (PR #94268)

2025-03-28 Thread Ethan Luis McDonough via cfe-commits
EthanLuisMcDonough wrote: This patch should disable PGO on nvidia targets: https://github.com/llvm/llvm-project/pull/133522. I'll merge it after I'm done running some tests https://github.com/llvm/llvm-project/pull/94268 ___ cfe-commits mailing list

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-28 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng updated https://github.com/llvm/llvm-project/pull/132288 >From 1d28510653b39fcabe45ad37197674bdd0217add Mon Sep 17 00:00:00 2001 From: kmpeng Date: Tue, 18 Mar 2025 13:25:10 -0700 Subject: [PATCH 01/11] create int_spv_smoothstep intrinsic, create smoothstep lowering &

[clang] [llvm] [PGO][Offload] Disable PGO on NVPTX (PR #133522)

2025-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Ethan Luis McDonough (EthanLuisMcDonough) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/133522.diff 5 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+3-1) - (added) clang/test/Driver/cuda

[clang] [HLSL][RootSignature] Make Root Signature lexer keywords case-insensitive (PR #132967)

2025-03-28 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/132967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 83c4cb3 - [HLSL][RootSignature] Make Root Signature lexer keywords case-insensitive (#132967)

2025-03-28 Thread via cfe-commits
Author: Finn Plummer Date: 2025-03-28T14:27:24-07:00 New Revision: 83c4cb36aaa41cc58f8d9fed5cb364e46e5c7db5 URL: https://github.com/llvm/llvm-project/commit/83c4cb36aaa41cc58f8d9fed5cb364e46e5c7db5 DIFF: https://github.com/llvm/llvm-project/commit/83c4cb36aaa41cc58f8d9fed5cb364e46e5c7db5.diff

[clang] [llvm] [PGO][Offload] Disable PGO on NVPTX (PR #133522)

2025-03-28 Thread Artem Belevich via cfe-commits
@@ -6397,7 +6397,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.AddLastArg(CmdArgs, options::OPT_fconvergent_functions, options::OPT_fno_convergent_functions); - addPGOAndCoverageFlags(TC, C, JA, Output, Args, SanitizeArgs, CmdArg

[clang] [llvm] [PGO][Offload] Disable PGO on NVPTX (PR #133522)

2025-03-28 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM with a comment nit. https://github.com/llvm/llvm-project/pull/133522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add SPIR-V target type for RWStructuredBuffers (PR #133468)

2025-03-28 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/133468 >From 7838678ca8ec5870cd8df81b109f9e1b30699f4e Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Fri, 24 Jan 2025 13:04:29 -0500 Subject: [PATCH 1/2] [HLSL] Add SPIR-V target type for RWStructuredBuffers This

[clang] [HIP] Claim `--offload-compress` for `-M` (PR #133456)

2025-03-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Didn't notice the indentation, LGTM. https://github.com/llvm/llvm-project/pull/133456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [Clang][SPIR-V] Fix convergence tokens for dtor (PR #133469)

2025-03-28 Thread Steven Perron via cfe-commits
https://github.com/s-perron commented: The changes look correct, but I want to double check that they are complete. https://github.com/llvm/llvm-project/pull/133469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [Clang][SPIR-V] Fix convergence tokens for dtor (PR #133469)

2025-03-28 Thread Steven Perron via cfe-commits
@@ -57,22 +58,37 @@ void main(unsigned GI : SV_GroupIndex) { // CHECK: define void @main() // CHECK-NEXT: entry: // Verify destructor is emitted -// NOINLINE-NEXT: call void @_GLOBAL__sub_I_GlobalDestructors.hlsl() -// NOINLINE-NEXT: %0 = call i32 @llvm.dx.flattened.th

[clang] b0bb86e - [HLSL][NFC] Use method builder to create default resource constructor (#131384)

2025-03-28 Thread via cfe-commits
Author: Helena Kotas Date: 2025-03-28T12:04:03-07:00 New Revision: b0bb86e239b2b09476ca58976094cc645ea9194f URL: https://github.com/llvm/llvm-project/commit/b0bb86e239b2b09476ca58976094cc645ea9194f DIFF: https://github.com/llvm/llvm-project/commit/b0bb86e239b2b09476ca58976094cc645ea9194f.diff

[clang] [NFC] [dataflow] generalize smart pointer caching (PR #133350)

2025-03-28 Thread Jan Voung via cfe-commits
@@ -23,12 +24,27 @@ using ast_matchers::pointerType; using ast_matchers::referenceType; using ast_matchers::returns; -bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, - bool &HasValue) { +CanQualType getLikeReturnType(QualType

[clang-tools-extra] [clang-tidy] Switch misc-confusable-identifiers check to a faster algorithm. (PR #130369)

2025-03-28 Thread Richard Smith via cfe-commits
zygoloid wrote: Ping. https://github.com/llvm/llvm-project/pull/130369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-03-28 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,34 @@ +// Fixes #59819. The underlying problem was fixed in https://reviews.llvm.org/D142560, but this patch adds a proper regression test. +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileChec

[clang] [NFC] [dataflow] generalize smart pointer caching (PR #133350)

2025-03-28 Thread Florian Mayer via cfe-commits
@@ -164,16 +161,19 @@ ast_matchers::StatementMatcher isPointerLikeOperatorArrow() { ofClass(pointerClass(); } -ast_matchers::StatementMatcher isSmartPointerLikeValueMethodCall() { +ast_matchers::StatementMatcher +isSmartPointerLikeValueMethodCal

[clang-tools-extra] [clang-doc] [feat] add --repository-line-prefix argument (PR #131280)

2025-03-28 Thread Paul Kirth via cfe-commits
ilovepi wrote: The branch has conflicts that need to be resolved. While its not a problem, we typically wait for 1 week between reviews to "ping" a reviewer. https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted https://github.com/llvm/llvm-project/pull/131280 ___

[clang-tools-extra] [clang-doc] [feat] add --repository-line-prefix argument (PR #131280)

2025-03-28 Thread Mohamed Emad via cfe-commits
hulxv wrote: > While its not a problem, we typically wait for 1 week between reviews to > "ping" a reviewer. > https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted Ok, I am sorry for that https://github.com/llvm/llvm-project/pull/131280 __

  1   2   3   4   5   >