[clang-tools-extra] [clang-doc][fix] crashes when generating HTML without `--repository` (PR #131698)

2025-03-25 Thread Mohamed Emad via cfe-commits
https://github.com/hulxv closed https://github.com/llvm/llvm-project/pull/131698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Implement WG14 N3037 (PR #132939)

2025-03-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: A lot of nits https://github.com/llvm/llvm-project/pull/132939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Remove failing binop test (PR #133001)

2025-03-25 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/133001 When CIR binop support was commited, it accidentally included a test for functionality that was removed during the review process (cir.binop.overflow). This test, of course, fails. This change removes the f

[clang] [CIR] Remove failing binop test (PR #133001)

2025-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes When CIR binop support was commited, it accidentally included a test for functionality that was removed during the review process (cir.binop.overflow). This test, of course, fails. This change removes the

[clang] [clang] Implement CWG2815 (PR #132778)

2025-03-25 Thread via cfe-commits
@@ -5229,10 +5229,23 @@ TryReferenceInit(Sema &S, Expr *Init, QualType DeclType, S.CompareReferenceRelationship(DeclLoc, T1, T2, &RefConv); auto SetAsReferenceBinding = [&](bool BindsDirectly) { +// C++2c [over.ics.ref] p1: cor3ntin wrote: Maybe

[clang] [CIR] [Upstream local initialization for ArrayType (PR #132974)

2025-03-25 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/132974 This change adds local initialization for ArrayType Issue #130197 >From 4dc1e77299c71b8f01fb73f7fba5f14e0fbe3edd Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri, 21 Mar 2025 21:07:11 +0100 Subject:

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-25 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng updated https://github.com/llvm/llvm-project/pull/132288 >From 0a5da660c5aae053d87d556e59f98c121d916b79 Mon Sep 17 00:00:00 2001 From: kmpeng Date: Tue, 18 Mar 2025 13:25:10 -0700 Subject: [PATCH 1/7] create int_spv_smoothstep intrinsic, create smoothstep lowering & m

[clang] [clang-tools-extra] [clang] Consistently use "load" to refer to populating clang::ModuleMap (PR #132970)

2025-03-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang-tools-extra,clang` at step 4 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/13948 Here is t

[clang] [Clang] Introduce __builtin_is_modifiable_lvalue() (PR #132524)

2025-03-25 Thread Kees Cook via cfe-commits
kees wrote: Thanks for all the feedback! I'll continue working on this next week (I'm OoO this week). https://github.com/llvm/llvm-project/pull/132524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-25 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh updated https://github.com/llvm/llvm-project/pull/132883 >From d8ffb5acbd79869476c91433f85488f3088e38fd Mon Sep 17 00:00:00 2001 From: Austin Schuh Date: Mon, 24 Mar 2025 21:42:35 -0700 Subject: [PATCH 1/2] Add support for CUDA surfaces This adds support for all

[clang] [libclang/python] Change all global variables to CAPS (PR #132930)

2025-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/132930.diff 7 Files Affected: - (modified) clang/bindings/python/clang/cindex.py (+5-5) - (modified) clang/bindings/python/tests/cindex/tes

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-03-25 Thread Aaron Ballman via cfe-commits
@@ -4456,6 +4456,12 @@ void Parser::ParseDeclarationSpecifiers( isInvalid = DS.setFunctionSpecNoreturn(Loc, PrevSpec, DiagID); break; +case tok::kw__Export: + // If we find kw__Export, it is being applied to a var or function + // This will be handled

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-03-25 Thread Tom Tromey via cfe-commits
tromey wrote: > > The link from the class to the specific vtable even seems mildly incorrect, > > in that during object construction the vtable will go through several > > different values, not just one. > > Not sure I follow this - the object is only of the type, in some sense, when > it is

[clang] [llvm] [MIPS] Define SubTargetFeature for i6500 cpu (PR #132907)

2025-03-25 Thread Mallikarjuna Gouda via cfe-commits
@@ -0,0 +1,6 @@ +// RUN: %clang --target=mips64-linux-gnu -mcpu=i6400 -o %t -c %s 2>&1 | FileCheck --allow-empty %s +// CHECK-NOT: {{.*}} is not a recognized feature for this target + mgoudar wrote: thank you for the review. I have removed extra line. https://g

[clang] [clang-format] Fix a regression on annotating template angles (PR #132885)

2025-03-25 Thread Björn Schäpers via cfe-commits
@@ -720,8 +720,9 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) { Tokens = annotate("return A < B != A > B;"); ASSERT_EQ(Tokens.size(), 10u) << Tokens; - EXPECT_TOKEN(Tokens[2], tok::less, TT_BinaryOperator); - EXPECT_TOKEN(Tokens[6], tok::greater, T

[clang-tools-extra] [clang-tidy] Add check bugprone-misleading-setter-of-reference (PR #132242)

2025-03-25 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,58 @@ +//===--- MisleadingSetterOfReferenceCheck.cpp - clang-tidy-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add check bugprone-misleading-setter-of-reference (PR #132242)

2025-03-25 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: Overall looks good to me; see inline comments for minor inline suggestions. https://github.com/llvm/llvm-project/pull/132242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [clang-tidy] Add check bugprone-misleading-setter-of-reference (PR #132242)

2025-03-25 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,42 @@ +.. title:: clang-tidy - bugprone-misleading-setter-of-reference + +bugprone-misleading-setter-of-reference +=== + +Finds setter-like functions that take a pointer parameter and set a (non-const) +reference with the pointed valu

[clang-tools-extra] [clang-tidy] Add check bugprone-misleading-setter-of-reference (PR #132242)

2025-03-25 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/132242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [llvm] [Clang][AMDGPU] Remove special handling for COV4 libraries (PR #132870)

2025-03-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/132870 >From 93fc26d67f0f0dc94fef853a129753d3a991ef6e Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Mar 2025 22:36:04 -0500 Subject: [PATCH] [Clang][AMDGPU] Remove special handling for COV4 libraries Summa

[clang] [clang] Fix crash on invalid `std::initializer_list` template-id (PR #132284)

2025-03-25 Thread via cfe-commits
cor3ntin wrote: @ojhunt as a fyi :) https://github.com/llvm/llvm-project/pull/132284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

2025-03-25 Thread Kajetan Puchalski via cfe-commits
https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/3] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [clang] Fix crash on invalid `std::initializer_list` template-id (PR #132284)

2025-03-25 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks! Will you need me to merge that for you? https://github.com/llvm/llvm-project/pull/132284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [libclang/python] Change all global variables to CAPS (PR #132930)

2025-03-25 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum created https://github.com/llvm/llvm-project/pull/132930 None >From f12efcc1c80f35f73934b90df7d4aaff8d2b0235 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Tue, 25 Mar 2025 21:58:31 +0900 Subject: [PATCH] [libclang/python] Change all global variables to CAP

[libclc] [libclc] Move asinpi/acospi/atanpi to the CLC library (PR #132918)

2025-03-25 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/132918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-03-25 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,5 @@ +// REQUIRES: systemz-registered-target AaronBallman wrote: Yes, there should be. As well as potentially confusing uses of `_Export` as in `int _Export x, y;`. https://github.com/llvm/llvm-project/pull/111035

[clang] [clang] Implement CWG2803 and CWG2958 (PR #132779)

2025-03-25 Thread via cfe-commits
https://github.com/offsetof updated https://github.com/llvm/llvm-project/pull/132779 >From 6c5441fd1e22e93de3a6c681842fe19f6e96fa62 Mon Sep 17 00:00:00 2001 From: offsetof Date: Mon, 24 Mar 2025 16:30:15 + Subject: [PATCH 1/2] [clang] Implement CWG2803 and CWG2958 CWG2803 "Overload resolut

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

2025-03-25 Thread Kajetan Puchalski via cfe-commits
https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/2] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[libclc] 3013458 - [libclc] Move asinpi/acospi/atanpi to the CLC library (#132918)

2025-03-25 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-03-25T13:31:53Z New Revision: 3013458a7901d2ec8c92ec1854c7a9354701f4c7 URL: https://github.com/llvm/llvm-project/commit/3013458a7901d2ec8c92ec1854c7a9354701f4c7 DIFF: https://github.com/llvm/llvm-project/commit/3013458a7901d2ec8c92ec1854c7a9354701f4c7.diff LOG

[libclc] [libclc] Move asinpi/acospi/atanpi to the CLC library (PR #132918)

2025-03-25 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/132918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CWG2815 (PR #132778)

2025-03-25 Thread via cfe-commits
@@ -47,6 +47,28 @@ void f() { #endif } // namespace cwg2813 +namespace cwg2815 { // cwg2815: 21 +#if __cpp_noexcept_function_type >= 201510 +int arg() noexcept; + +int f(int (&)() noexcept); +void f(int (&)()); +int i = f(arg); + +int g(int (*)() noexcept); +void g(int (&)());

[clang] [clang] Implement CWG2815 (PR #132778)

2025-03-25 Thread via cfe-commits
@@ -110,12 +110,16 @@ Resolutions to C++ Defect Reports two releases. The improvements to template template parameter matching implemented in the previous release, as described in P3310 and P3579, made this flag unnecessary. +- Implemented |CWG2815|_ cor

[clang] [Clang] Check PP presence when printing stats (PR #131608)

2025-03-25 Thread via cfe-commits
cor3ntin wrote: This change needs a release note. Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change, and referencing any Github issue this change fixes. Thanks! https://github.com/llvm/llvm-project/pull/131608 ___

[clang] 5105ecc - [clang] Refine handling of C++20 aggregate initialization (#131320)

2025-03-25 Thread via cfe-commits
Author: offsetof Date: 2025-03-25T15:30:16+01:00 New Revision: 5105ecc413757999ea0aec238ed54ae39dbf005d URL: https://github.com/llvm/llvm-project/commit/5105ecc413757999ea0aec238ed54ae39dbf005d DIFF: https://github.com/llvm/llvm-project/commit/5105ecc413757999ea0aec238ed54ae39dbf005d.diff LOG:

[clang] [clang] ASTContex: fix getCommonSugaredType for array types (PR #132559)

2025-03-25 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/132559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refine handling of C++20 aggregate initialization (PR #131320)

2025-03-25 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/131320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-03-25 Thread Carlos Alberto Enciso via cfe-commits
CarlosAlbertoEnciso wrote: > Though I haven't thought seriously about the representation - truly off the > cuff, take with a grain of salt, etc, the static member that is the vtable > seems sort of reasonable to me. > > Not sure why it'd be necessary to make that vtable global variable "global

[clang] [CIR] Add binary operators (PR #132420)

2025-03-25 Thread Morris Hafner via cfe-commits
@@ -200,7 +200,7 @@ class ASTContext : public RefCountedBase { mutable llvm::ContextualFoldingSet ConstantArrayTypes; mutable llvm::FoldingSet IncompleteArrayTypes; - mutable std::vector VariableArrayTypes; + mutable std::vector VariableArrayTypes;

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

2025-03-25 Thread Kajetan Puchalski via cfe-commits
https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/3] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [compiler-rt] [libc] [libcxx] [llvm] [Clang][AMDGPU] Remove special handling for COV4 libraries (PR #132870)

2025-03-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/132870 >From 09c8fbf137fc975029fa9dee89af0d52ac2876b5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Mar 2025 22:36:04 -0500 Subject: [PATCH] [Clang][AMDGPU] Remove special handling for COV4 libraries Summa

[clang] [Clang] Implement CWG2517 Useless restriction on use of parameter in constraint-expression (PR #132919)

2025-03-25 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > CC @mizvekov since it was suggested this is related to > https://github.com/llvm/llvm-project/issues/126550 and it looked like based > on the conversation there, there was some existing work going on. I think the crash I presented is independent of this DR. (This DR makes that

[clang] [compiler-rt] [llvm] [FMV][AArch64] Add feature CSSC and detect on linux platform. (PR #132727)

2025-03-25 Thread via cfe-commits
@@ -33,7 +33,7 @@ enum CPUFeatures { FEAT_FP, FEAT_SIMD, FEAT_CRC, - RESERVED_FEAT_SHA1, // previously used and now ABI legacy + FEAT_CSSC, Wilco1 wrote: Thanks, noted. https://github.com/llvm/llvm-project/pull/132727 _

[clang] [C23] Implement WG14 N3037 (PR #132939)

2025-03-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/132939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Change all global variables to CAPS (PR #132930)

2025-03-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/7661 Here is the releva

[clang] [NFC][Static Analyzer] Rename and discuss about `NotNullConstraint` & `NotNullBufferConstraint` (PR #131374)

2025-03-25 Thread Balázs Kéri via cfe-commits
@@ -1165,7 +1165,7 @@ ProgramStateRef StdLibraryFunctionsChecker::NotNullConstraint::apply( return State->assume(L, CannotBeNull); } -void StdLibraryFunctionsChecker::NotNullConstraint::describe( +void StdLibraryFunctionsChecker::NullnessConstraint::describe( Descripti

[clang] [compiler-rt] [PGO][Offload] Hide GPU entrypoint on Darwin (PR #132966)

2025-03-25 Thread Joseph Huber via cfe-commits
@@ -1273,6 +1273,7 @@ COMPILER_RT_VISIBILITY int __llvm_profile_set_file_object(FILE *File, return 0; } +#ifdef COMPILER_RT_GPU_ENTRYPOINT jhuber6 wrote: Can't we just use `__APPLE__`? https://github.com/llvm/llvm-project/pull/132966 _

[clang] [clang-format] Allow `Language: Cpp` for C files (PR #133033)

2025-03-25 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/133033 Fix #132832 >From d03c3420218eed7c2db3a5c17abb6a0b3efbba87 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 25 Mar 2025 21:45:00 -0700 Subject: [PATCH] [clang-format] Allow `Language: Cpp` for C files Fix #13

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

2025-03-25 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 edited https://github.com/llvm/llvm-project/pull/133037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

2025-03-25 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 edited https://github.com/llvm/llvm-project/pull/133037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

2025-03-25 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 updated https://github.com/llvm/llvm-project/pull/133037 >From dfe49e826705a5e9371e17e66e40c31602beea8e Mon Sep 17 00:00:00 2001 From: anutosh491 Date: Wed, 26 Mar 2025 10:33:37 +0530 Subject: [PATCH 1/2] Implement LoadDynamicLibrary for clang-repl wasm use cases

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

2025-03-25 Thread Anutosh Bhat via cfe-commits
anutosh491 wrote: For anyone concerned, Such a feature would be tested out in downstream projects like [cppinterop](https://github.com/compiler-research/CppInterOp) and [xeus-cpp](https://github.com/compiler-research/xeus-cpp) as currently llvm doesn't have a concrete structure to test clang-

[clang] [AMDGPU][clang] provide device implementation for __builtin_logb and … (PR #129347)

2025-03-25 Thread via cfe-commits
https://github.com/choikwa updated https://github.com/llvm/llvm-project/pull/129347 >From 54076ba363db12cd04aefe58b385834a5fb986c2 Mon Sep 17 00:00:00 2001 From: Kevin Choi Date: Fri, 28 Feb 2025 16:52:03 -0600 Subject: [PATCH] [AMDGPU][clang] provide device implementation for __builtin_logb a

[clang] [llvm] [RISCV] Implement the implications of C extension (PR #132259)

2025-03-25 Thread Sam Elliott via cfe-commits
https://github.com/lenary commented: I commented about the predicates (before i saw the other comments). I thought they'd be ok to do in a follow-up, but you should just to the refactoring now as it won't quite be NFC as I expected. https://github.com/llvm/llvm-project/pull/132259

[clang] [NFC][Driver][HIP] Fix mixing `amdgcnspirv` and `gfxXXX` via `--offload-arch` (PR #133024)

2025-03-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Seems in line with the weird workarounds we already use. https://github.com/llvm/llvm-project/pull/133024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [C23] Implement WG14 N3037 (PR #132939)

2025-03-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Second round of comments, I may make a third go around but I wouldn't wait for me. https://github.com/llvm/llvm-project/pull/132939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [C23] Implement WG14 N3037 (PR #132939)

2025-03-25 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,472 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c23 -pedantic -Wall -Wno-comment -verify=both,c23 %s +// RUN: %clang_cc1 -fsyntax-only -std=c17 -pedantic -Wall -Wno-comment -Wno-c23-extensions -verify=both,c17 %s + +/* WG14 N3037: + * Improved tag compatibility + * + *

[clang] [C23] Implement WG14 N3037 (PR #132939)

2025-03-25 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,472 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c23 -pedantic -Wall -Wno-comment -verify=both,c23 %s +// RUN: %clang_cc1 -fsyntax-only -std=c17 -pedantic -Wall -Wno-comment -Wno-c23-extensions -verify=both,c17 %s + +/* WG14 N3037: + * Improved tag compatibility + * + *

[clang] [Docs] Document freestanding requirements (PR #132232)

2025-03-25 Thread A. Jiang via cfe-commits
@@ -534,11 +534,6 @@ C23 implementation status Clang 16 - - String functions for freestanding implementations - https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2524.htm";>N2524 - No - frederick-vs-ja wrote: I found that

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
@@ -2001,3 +1932,260 @@ NormalizedConstraint::getFoldExpandedConstraint() const { "getFoldExpandedConstraint called on non-fold-expanded constraint."); return cast(Constraint); } + +// +// +// Subsumption ---

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
@@ -2001,3 +1932,260 @@ NormalizedConstraint::getFoldExpandedConstraint() const { "getFoldExpandedConstraint called on non-fold-expanded constraint."); return cast(Constraint); } + +// +// +// Subsumption ---

[clang] [llvm] [RISCV][WIP] Add assembler support for Zvma (PR #132965)

2025-03-25 Thread via cfe-commits
https://github.com/SpriteOvO closed https://github.com/llvm/llvm-project/pull/132965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
@@ -2001,3 +1932,260 @@ NormalizedConstraint::getFoldExpandedConstraint() const { "getFoldExpandedConstraint called on non-fold-expanded constraint."); return cast(Constraint); } + +// +// +// Subsumption ---

[clang] [llvm] [RISCV][WIP] Add assembler support for Zvma (PR #132965)

2025-03-25 Thread Jiuyang Liu via cfe-commits
sequencer wrote: Appreciate your work! https://github.com/llvm/llvm-project/pull/132965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Make RequiredExtensions for intrinsics scalable to more than 32 extensions. NFC (PR #132895)

2025-03-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/13969 Here is the relevant piece o

[clang] [llvm] [HLSL] Add SPIR-V target type for StructuredBuffers (PR #132027)

2025-03-25 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/132027 >From 78348586c0b237db689b669fcf4352e6b42898a1 Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Wed, 12 Feb 2025 15:45:32 -0500 Subject: [PATCH 1/3] [HLSL] Use hlsl_device address space for getpointer. We ad

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
https://github.com/MagentaTreehouse edited https://github.com/llvm/llvm-project/pull/132849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
@@ -2001,3 +1932,260 @@ NormalizedConstraint::getFoldExpandedConstraint() const { "getFoldExpandedConstraint called on non-fold-expanded constraint."); return cast(Constraint); } + +// +// +// Subsumption ---

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
https://github.com/MagentaTreehouse commented: Some comments on map lookup, plus other minor suggestions. https://github.com/llvm/llvm-project/pull/132849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
@@ -2001,3 +1932,260 @@ NormalizedConstraint::getFoldExpandedConstraint() const { "getFoldExpandedConstraint called on non-fold-expanded constraint."); return cast(Constraint); } + +// +// +// Subsumption ---

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/133035 >From fb9260dd796ae687a000beb550198d155b772625 Mon Sep 17 00:00:00 2001 From: changkhothuychung Date: Wed, 26 Mar 2025 00:55:26 -0400 Subject: [PATCH 1/3] initial commit --- clang/lib/Sema/SemaOverlo

[clang] [Clang] Improve subsumption. (PR #132849)

2025-03-25 Thread via cfe-commits
@@ -2001,3 +1932,260 @@ NormalizedConstraint::getFoldExpandedConstraint() const { "getFoldExpandedConstraint called on non-fold-expanded constraint."); return cast(Constraint); } + +// +// +// Subsumption ---

[clang] [libclang/python] Change all global variables to CAPS (PR #132930)

2025-03-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/14935 Here is the relevant piece of the

[clang] [clang] fix constexpr-unknown handling of self-references. (PR #132990)

2025-03-25 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/132990 Usually, in constant evaluation, references which are local to the evaluation have to be initialized before they're accessed. However, there's one funny special case: the initializer of a reference can r

[clang] [RISCV] Make RequiredExtensions for intrinsics scalable to more than 32 extensions. NFC (PR #132895)

2025-03-25 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/132895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] [Upstream local initialization for ArrayType (PR #132974)

2025-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds local initialization for ArrayType Issue #130197 --- Patch is 59.03 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/132974.diff 25 Files A

[clang] 1752d52 - [RISCV] Make RequiredExtensions for intrinsics scalable to more than 32 extensions. NFC (#132895)

2025-03-25 Thread via cfe-commits
Author: Craig Topper Date: 2025-03-25T20:46:01-07:00 New Revision: 1752d5292c1472cdfecbf3bfeea5040d09cfaa28 URL: https://github.com/llvm/llvm-project/commit/1752d5292c1472cdfecbf3bfeea5040d09cfaa28 DIFF: https://github.com/llvm/llvm-project/commit/1752d5292c1472cdfecbf3bfeea5040d09cfaa28.diff

[clang] [clang-format] Allow `Language: Cpp` for C files (PR #133033)

2025-03-25 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/133033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nhat Nguyen (changkhothuychung) Changes fix #132600 --- Full diff: https://github.com/llvm/llvm-project/pull/133035.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaOverload.cpp (+1-1) ``diff diff --git a/clang/lib/Se

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/133035 >From fb9260dd796ae687a000beb550198d155b772625 Mon Sep 17 00:00:00 2001 From: changkhothuychung Date: Wed, 26 Mar 2025 00:55:26 -0400 Subject: [PATCH 1/4] initial commit --- clang/lib/Sema/SemaOverlo

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung ready_for_review https://github.com/llvm/llvm-project/pull/133035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/133035 >From fb9260dd796ae687a000beb550198d155b772625 Mon Sep 17 00:00:00 2001 From: changkhothuychung Date: Wed, 26 Mar 2025 00:55:26 -0400 Subject: [PATCH 1/5] initial commit --- clang/lib/Sema/SemaOverlo

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
changkhothuychung wrote: the failing test in clang/test/SemaCXX/copy-assignment.cpp seems like to be another clang bug - https://godbolt.org/z/79bWMscx9 https://github.com/llvm/llvm-project/pull/133035 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

2025-03-25 Thread Vassil Vassilev via cfe-commits
@@ -711,6 +712,14 @@ llvm::Error Interpreter::Undo(unsigned N) { } llvm::Error Interpreter::LoadDynamicLibrary(const char *name) { +#ifdef __EMSCRIPTEN__ + void *handle = dlopen(name, RTLD_NOW | RTLD_GLOBAL); + if (!handle) { +llvm::errs() << dlerror() << '\n'; +retu

[clang] [compiler-rt] [PGO][Offload] Hide GPU entrypoint on Darwin (PR #132966)

2025-03-25 Thread Ethan Luis McDonough via cfe-commits
@@ -1273,6 +1273,7 @@ COMPILER_RT_VISIBILITY int __llvm_profile_set_file_object(FILE *File, return 0; } +#ifdef COMPILER_RT_GPU_ENTRYPOINT EthanLuisMcDonough wrote: My reasoning was that it would give us more configuration power if we had a macro that was

[clang] [clang][ExtractAPI] fix a couple crashes when used via libclang (PR #132297)

2025-03-25 Thread via cfe-commits
@@ -175,28 +175,30 @@ class ExtractAPIVisitorBase : public RecursiveASTVisitor { SmallVector getBases(const CXXRecordDecl *Decl) { // FIXME: store AccessSpecifier given by inheritance SmallVector Bases; -for (const auto &BaseSpecifier : Decl->bases()) { - //

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Tom Honermann (tahonermann) Changes A function declared with the `sycl_kernel_entry_point` attribute, sometimes called a SYCL kernel entry point function, specifies a pattern from which the parameters and body of an offload entry

[clang] [Clang] Implement CWG2517 Useless restriction on use of parameter in constraint-expression (PR #132919)

2025-03-25 Thread Imad Aldij via cfe-commits
https://github.com/imdj updated https://github.com/llvm/llvm-project/pull/132919 >From 7905577616743f5158560a4b337148ef9cd25f1e Mon Sep 17 00:00:00 2001 From: Imad Aldij Date: Tue, 25 Mar 2025 14:50:55 +0200 Subject: [PATCH 1/6] [Clang] Implement CWG2517 Useless restriction on use of parameter

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-03-25 Thread marius doerner via cfe-commits
mariusdr wrote: > Thanks. Will you need me to merge that for you? Yes, please https://github.com/llvm/llvm-project/pull/132460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Correctly handle structured bindings captured by lambda (PR #132579)

2025-03-25 Thread via cfe-commits
flovent wrote: > In this case the proper fix would be to make sure, every declaration is > correctly looked up from a lambda. As i can know, lambdas can only capture variables in program, which seems can only comes from `VarDecl` or `BindingDecl`, so i think we don't need to handle other decl

[clang] [AMDGPU][clang] provide device implementation for __builtin_logb and … (PR #129347)

2025-03-25 Thread via cfe-commits
https://github.com/choikwa updated https://github.com/llvm/llvm-project/pull/129347 >From 00827e0ebb8853dfc886e1d6226136ddbdb6e0a4 Mon Sep 17 00:00:00 2001 From: Kevin Choi Date: Fri, 28 Feb 2025 16:52:03 -0600 Subject: [PATCH] [AMDGPU][clang] provide device implementation for __builtin_logb a

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung created https://github.com/llvm/llvm-project/pull/133035 fix #132600 >From fb9260dd796ae687a000beb550198d155b772625 Mon Sep 17 00:00:00 2001 From: changkhothuychung Date: Wed, 26 Mar 2025 00:55:26 -0400 Subject: [PATCH] initial commit --- clang/lib/Sema/

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung converted_to_draft https://github.com/llvm/llvm-project/pull/133035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Implement WG14 N3037 (PR #132939)

2025-03-25 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,472 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c23 -pedantic -Wall -Wno-comment -verify=both,c23 %s +// RUN: %clang_cc1 -fsyntax-only -std=c17 -pedantic -Wall -Wno-comment -Wno-c23-extensions -verify=both,c17 %s + +/* WG14 N3037: + * Improved tag compatibility + * + *

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-03-25 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann created https://github.com/llvm/llvm-project/pull/133030 A function declared with the `sycl_kernel_entry_point` attribute, sometimes called a SYCL kernel entry point function, specifies a pattern from which the parameters and body of an offload entry point functi

[clang] [Clang] Check PP presence when printing stats (PR #131608)

2025-03-25 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises edited https://github.com/llvm/llvm-project/pull/131608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow `Language: Cpp` for C files (PR #133033)

2025-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #132832 --- Full diff: https://github.com/llvm/llvm-project/pull/133033.diff 2 Files Affected: - (modified) clang/lib/Format/Format.cpp (+10-3) - (modified) clang/unittests/Format/ConfigParseTest.cp

[clang] [Clang] Check PP presence when printing stats (PR #131608)

2025-03-25 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/131608 >From 60b1e16b7b297095a50ed8db644b787e35f8eab0 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Mon, 17 Mar 2025 20:49:02 +0800 Subject: [PATCH 1/2] [Clang] Check PP presence when printing stats --- clang/li

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-03-25 Thread Urvi Rav via cfe-commits
https://github.com/ravurvi20 updated https://github.com/llvm/llvm-project/pull/128640 >From 6ebd5991788608fbd104ea9c23230912044462d3 Mon Sep 17 00:00:00 2001 From: Urvi Rav Date: Tue, 25 Feb 2025 00:49:07 -0600 Subject: [PATCH] default clause replaced by otherwise clause for metadirective ---

[clang] [clang]: fix overload resolution in case of converting const value reference to an rvalue reference. (PR #133035)

2025-03-25 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/133035 >From fb9260dd796ae687a000beb550198d155b772625 Mon Sep 17 00:00:00 2001 From: changkhothuychung Date: Wed, 26 Mar 2025 00:55:26 -0400 Subject: [PATCH 1/2] initial commit --- clang/lib/Sema/SemaOverlo

[clang] [clang-tools-extra] [clang] improve class type sugar preservation in pointers to members (PR #130537)

2025-03-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang-tools-extra,clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/149

<    1   2   3   4   5   6   >