[clang] [NFC][clang] Split clang/lib/CodeGen/CGBuiltin.cpp into target-specific files (PR #132252)

2025-03-24 Thread Jonathan Thackray via cfe-commits
@@ -0,0 +1,107 @@ +//===-- CGBuiltin.h - Emit LLVM Code for builtins -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [CIR] Emit allocas into the proper lexical scope (PR #132468)

2025-03-24 Thread Morris Hafner via cfe-commits
https://github.com/mmha approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/132468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Emit allocas into the proper lexical scope (PR #132468)

2025-03-24 Thread Morris Hafner via cfe-commits
@@ -44,3 +44,100 @@ void l0() { // OGCG: br label %[[FOR_COND:.*]] // OGCG: [[FOR_COND]]: // OGCG: br label %[[FOR_COND]] + +void l1() { + for (int i = 0; ; ) { + } +} + +// CIR: cir.func @l1 +// CIR-NEXT: cir.scope { +// CIR-NEXT: %[[I:.*]] = cir.alloca !s32i,

[clang] [CIR] Emit allocas into the proper lexical scope (PR #132468)

2025-03-24 Thread Morris Hafner via cfe-commits
@@ -293,7 +294,8 @@ void CIRGenFunction::startFunction(GlobalDecl gd, QualType returnType, mlir::Value addrVal = emitAlloca(cast(paramVar)->getName(), - convertType(paramVar->getType()), paramLoc, alignment); + convertType(param

[clang] [CIR] Emit allocas into the proper lexical scope (PR #132468)

2025-03-24 Thread Morris Hafner via cfe-commits
@@ -0,0 +1,81 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang] [NFC] Introduce a helper for emitting compatibility diagnostics (PR #132348)

2025-03-24 Thread Aaron Ballman via cfe-commits
@@ -178,6 +191,11 @@ multiclass CXXCompat< "CXX98Compat", "CXXPre"#std_ver#"Compat"))>, DefaultIgnore; + +def : CompatWarningId< AaronBallman wrote: Should we have another la

[clang] [CIR] Emit allocas into the proper lexical scope (PR #132468)

2025-03-24 Thread Morris Hafner via cfe-commits
https://github.com/mmha edited https://github.com/llvm/llvm-project/pull/132468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-24 Thread via cfe-commits
@@ -1681,7 +1681,7 @@ std::optional Sema::GetDecompositionElementCount(QualType T, llvm::APSInt TupleSize(Ctx.getTypeSize(Ctx.getSizeType())); switch (isTupleLike(*this, Loc, T, TupleSize)) { case IsTupleLike::Error: -return {}; +return std::nullopt;

[clang] [llvm] [RISCV] Add Qualcomm uC Xqciio (External Input Output) extension (PR #132721)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: quic_hchandel (hchandel) Changes This extension adds two external input output instructions for a non-memory-mapped device. The current spec can be found at: https://github.com/quic/riscv-unified-db/releases/tag/Xqci-0.7.0 This patch adds

[clang] [llvm] [RISCV] Add Qualcomm uC Xqciio (External Input Output) extension (PR #132721)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc @llvm/pr-subscribers-clang-driver Author: quic_hchandel (hchandel) Changes This extension adds two external input output instructions for a non-memory-mapped device. The current spec can be found at: https://github.com/quic/riscv-unified-db/releases/

[clang] [clang] ``noconvergent`` does not affect calls to convergent functions (PR #132701)

2025-03-24 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Only convergent is an attribute in LLVM IR, and there is no equivalent of > clang::noconvergent. There should be (and I still have a patch somewhere to add it) https://github.com/llvm/llvm-project/pull/132701 ___ cfe-commits mailing l

[clang] [clang-tools-extra] [clang] Concepts: support pack expansions for type constraints (PR #132626)

2025-03-24 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > The patch looks good overall, but as you've suggested that this is > incomplete, I think we want to go over it again after the cache part gets > adapted. My intention is to leave the main branch in a better state, not necessarily to finish everything here in one go. I think

[clang] [clang] ``noconvergent`` does not affect calls to convergent functions (PR #132701)

2025-03-24 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/132701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Qualcomm uC Xqciio (External Input Output) extension (PR #132721)

2025-03-24 Thread via cfe-commits
https://github.com/hchandel edited https://github.com/llvm/llvm-project/pull/132721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement __builtin_{wcscmp, wcsncmp} (PR #132723)

2025-03-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/132723 None >From 483bb2ce006f980e781ce8756f43cc87683f522c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 24 Mar 2025 13:15:33 +0100 Subject: [PATCH] [clang][bytecode] Implement __builtin_{wc

[clang] [clang-tools-extra] [clang] Concepts: support pack expansions for type constraints (PR #132626)

2025-03-24 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/132626 >From 17bbac4d1f447a448168de629f44d8c227d468e5 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 22 Mar 2025 17:29:16 -0300 Subject: [PATCH 1/3] Revert "[Clang] Distinguish expanding-pack-in-place cases

[clang] [clang-tools-extra] [clang][AST][clang-tidy] Do not set a reduced traversal scope in ASTM… (PR #132725)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Carlos Galvez (carlosgalvezp) Changes …atchFinder This was introduced here with the purpose of speed up clang-tidy, making it not process system headers: https://github.com/llvm/llvm-project/commit/e4a8969e56572371201863594b3

[clang] [clang] Implement address sanitizer on AIX (1/n) (PR #129925)

2025-03-24 Thread Jake Egan via cfe-commits
https://github.com/jakeegan edited https://github.com/llvm/llvm-project/pull/129925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Check PP presence when printing stats (PR #131608)

2025-03-24 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises edited https://github.com/llvm/llvm-project/pull/131608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement address sanitizer on AIX (1/n) (PR #129925)

2025-03-24 Thread Jake Egan via cfe-commits
https://github.com/jakeegan edited https://github.com/llvm/llvm-project/pull/129925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

2025-03-24 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: So, the body of the destructor is not the problem. I commented out all new additions to body emission of the destructor and it still crashes. What makes the difference is the alias emission. I commented out alias emission and it started passing with "_E" destructor always emitt

[clang] [clang-tools-extra] [clang] Concepts: support pack expansions for type constraints (PR #132626)

2025-03-24 Thread via cfe-commits
@@ -70,7 +70,14 @@ struct alignas(ConstraintAlignment) AtomicConstraint { // We do not actually substitute the parameter mappings into the // constraint expressions, therefore the constraint expressions are // the originals, and comparing them will suffice. -if

[clang] [clang-tools-extra] [clang][AST][clang-tidy] Do not set a reduced traversal scope in ASTM… (PR #132725)

2025-03-24 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: @kadircet Are you able to test this PR and confirm it fixes the regressions you encountered? https://github.com/llvm/llvm-project/pull/132725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [CIR] Add binary operators (PR #132420)

2025-03-24 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/132420 >From 594005c964b5c1e6605dc8ac170f1b43aa018bea Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 21 Mar 2025 17:55:00 +0100 Subject: [PATCH 1/2] [CIR] Add binary operators This patch adds upstreams support fo

[clang] [CIR] Add binary operators (PR #132420)

2025-03-24 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/132420 >From 594005c964b5c1e6605dc8ac170f1b43aa018bea Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 21 Mar 2025 17:55:00 +0100 Subject: [PATCH 1/3] [CIR] Add binary operators This patch adds upstreams support fo

[clang] [CIR] Add binary operators (PR #132420)

2025-03-24 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/132420 >From 594005c964b5c1e6605dc8ac170f1b43aa018bea Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 21 Mar 2025 17:55:00 +0100 Subject: [PATCH 1/4] [CIR] Add binary operators This patch adds upstreams support fo

[clang] [clang-tools-extra] [clang] Concepts: support pack expansions for type constraints (PR #132626)

2025-03-24 Thread Younan Zhang via cfe-commits
@@ -3239,61 +3162,11 @@ bool Sema::SubstTypeConstraint( TC->getTemplateArgsAsWritten(); if (!EvaluateConstraints) { -bool ShouldExpandExplicitTemplateArgs = -TemplArgInfo && ArgumentPackSubstitutionIndex != -1 && -llvm::any_of(TemplArgInfo->argument

[clang] [clang][analyzer] Fix InvalidatedIterator crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread via cfe-commits
@@ -0,0 +1,21 @@ +// RUN: %clang_analyze_cc1 -std=c++23 %s -verify -analyzer-checker=alpha.cplusplus.InvalidatedIterator -analyzer-config aggressive-binary-operation-simplification=true + +// expected-no-diagnostics + +class ExplicitThis { + int f = 0; +public: + ExplicitThis(

[clang] [clang][analyzer] Fix InvalidatedIterator crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread via cfe-commits
https://github.com/flovent updated https://github.com/llvm/llvm-project/pull/132581 >From 67ebfb00f7104e63b4a1464f6b015ba8bdea4cc6 Mon Sep 17 00:00:00 2001 From: flovent Date: Sun, 23 Mar 2025 11:02:53 +0800 Subject: [PATCH 1/3] [clang][analyzer] Fix crash caused by overload operator member fu

[clang] [Driver] Search for compiler-rt libraries in sysroot/lib if not found in the resource directory (PR #132443)

2025-03-24 Thread Kostiantyn Lazukin via cfe-commits
https://github.com/Sunday111 updated https://github.com/llvm/llvm-project/pull/132443 >From 1ffc0c0396da03080267ad5b05c118cf85f680a6 Mon Sep 17 00:00:00 2001 From: Kostiantyn Lazukin Date: Thu, 20 Mar 2025 16:54:06 + Subject: [PATCH] [Driver] Search for compiler-rt libraries in sysroot/lib

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-03-24 Thread Carlos Alberto Enciso via cfe-commits
CarlosAlbertoEnciso wrote: @Michael137, @dwblaikie, @labath, @tromey Thanks very much for your valuable feedback. Is there any additional points about the current patch that you would like to address? Thanks https://github.com/llvm/llvm-project/pull/130255

[clang] [clang][analyzer] Fix crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread Balazs Benics via cfe-commits
@@ -157,8 +157,11 @@ void ContainerModeling::checkPostCall(const CallEvent &Call, if (Func->isOverloadedOperator()) { const auto Op = Func->getOverloadedOperator(); if (Op == OO_Equal) { - // Overloaded 'operator=' must be a non-static member function. - co

[clang] [clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-24 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Ok! Will fix sometime today. I think this topic needs some more careful iteration and we should unblock. Worth noting is that even though a lot of warnings still remain the performance gain was still significant, i.e. going from 10 seconds (baseline) to 3 seconds (proposa

[clang] [NFC] [ASTMatchers] Share code of `forEachArgumentWithParamType` with UnsafeBufferUsage (PR #132387)

2025-03-24 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > I'm currently dealing with downstream conflicts with your previous patch. > Please do not merge this PR this week, otherwise it may slow down our CI. > Thanks! Sure! There is no urgency in landing this. Please let me know when it'd be a good time to land this. @AaronBa

[clang] [clang][bytecode] Diagnose integral source/dest in memcpy (PR #132715)

2025-03-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/132715 Like the current interpreter does. >From 698d310421651db1320d3a60fd7fa9a44c25627e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 24 Mar 2025 12:05:57 +0100 Subject: [PATCH] [clang][byt

[clang] [clang][bytecode] Diagnose integral source/dest in memcpy (PR #132715)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Like the current interpreter does. --- Full diff: https://github.com/llvm/llvm-project/pull/132715.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+11) - (modified) clang/tes

[libclc] 63b5692 - [libclc] Relicense gen_convert.py (#132213)

2025-03-24 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-03-24T11:10:07Z New Revision: 63b5692bacd941f1b6b9010b70db4bcc327469b9 URL: https://github.com/llvm/llvm-project/commit/63b5692bacd941f1b6b9010b70db4bcc327469b9 DIFF: https://github.com/llvm/llvm-project/commit/63b5692bacd941f1b6b9010b70db4bcc327469b9.diff LOG

[clang] [NFC][FMV][AArch64] Tidy up codegen tests. (PR #132273)

2025-03-24 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Cool, thanks Tomas https://github.com/llvm/llvm-project/pull/132273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Search for compiler-rt libraries in sysroot/lib if not found in the resource directory (PR #132443)

2025-03-24 Thread Kostiantyn Lazukin via cfe-commits
https://github.com/Sunday111 updated https://github.com/llvm/llvm-project/pull/132443 >From f233c06d21d14b62f7f31cf2901b329ecb215d97 Mon Sep 17 00:00:00 2001 From: Kostiantyn Lazukin Date: Thu, 20 Mar 2025 16:54:06 + Subject: [PATCH] [Driver] Search for compiler-rt libraries in sysroot/lib

[clang] [clang][bytecode] Add Descriptor::getDataType() (PR #132681)

2025-03-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/132681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Mips] Fix clang compile error when -march=p5600 with -mmsa (PR #132679)

2025-03-24 Thread via cfe-commits
https://github.com/yingopq updated https://github.com/llvm/llvm-project/pull/132679 >From 1d02feddb4749841e74c398257a0242d4c2f8f98 Mon Sep 17 00:00:00 2001 From: Ying Huang Date: Sun, 23 Mar 2025 23:26:08 -0400 Subject: [PATCH] [Mips] Fix clang compile error when -march=p5600 with -mmsa When -

[clang] [clang][analyzer] Fix InvalidatedIterator crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/132581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-cv-qualifiers diagnostic for cv-qualified base classes (PR #132116)

2025-03-24 Thread Lyle Dean via cfe-commits
@@ -497,6 +497,7 @@ def GNUImaginaryConstant : DiagGroup<"gnu-imaginary-constant">; def IgnoredGCH : DiagGroup<"ignored-gch">; def IgnoredReferenceQualifiers : DiagGroup<"ignored-reference-qualifiers">; def IgnoredQualifiers : DiagGroup<"ignored-qualifiers", [IgnoredReference

[clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-03-24 Thread Paul Kirth via cfe-commits
ilovepi wrote: The test output isn't appropriate for the commit body, so please remove that. I also see many files were changed in this PR that aren't related. Many of them seem to be changes to the line endings in files. Please double check your editor and git settings to be sure they follow

[clang] [clang-format] add option to control bin-packing keyworded parameters (PR #131605)

2025-03-24 Thread via cfe-commits
@@ -1,3 +1,4 @@ Strings +FunctionDeclarationWithKeywordes mydeveloperday wrote: spelling? https://github.com/llvm/llvm-project/pull/131605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [clang][analyzer] Fix crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/132581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Relicense gen_convert.py (PR #132213)

2025-03-24 Thread Kristof Beyls via cfe-commits
https://github.com/kbeyls approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/132213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement __builtin_wcschr (PR #132708)

2025-03-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/132708 This is already almost implemented, just need to enable support for it. >From 2355ce241b16a4b0d9839f010b90f338ba416a4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 24 Mar 2025 11:38:

[clang] [clang][bytecode] Implement __builtin_wcschr (PR #132708)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This is already almost implemented, just need to enable support for it. --- Full diff: https://github.com/llvm/llvm-project/pull/132708.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuil

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-24 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > Can you add a reproducer? I'm not sure I can do better than the test I've added. My colleague caught this by accidentally getting an assertion failure when using this API downstream. The test illustrates how it got used and I'm not sure if `clang-format` binary or any ot

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-24 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/131299 >From 1acb9b0717c0f55e59abca104bbb710375a67610 Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Fri, 14 Mar 2025 10:53:09 +0100 Subject: [PATCH 1/3] [Format] Do not crash on non-null terminated strings

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-24 Thread Ilya Biryukov via cfe-commits
@@ -29096,6 +29096,17 @@ TEST_F(FormatTest, BreakBeforeClassName) { "ArenaSafeUniquePtr {};"); } +TEST_F(FormatTest, DoesNotCrashOnNonNullTerminatedStringRefs) { + llvm::StringRef TwoLines = "namespace foo {}\n" ilya-biryukov wrote: Done.

[clang] [llvm] [AArch64] Add initial support for -mcpu=olympus. (PR #132368)

2025-03-24 Thread David Green via cfe-commits
@@ -288,6 +288,7 @@ StringRef sys::detail::getHostCPUNameForARM(StringRef ProcCpuinfoContent) { if (Implementer == "0x4e") { // NVIDIA Corporation return StringSwitch(Part) .Case("0x004", "carmel") +.Case("0x10", "olympus") davemgreen wro

[clang] [clang][analyzer] Fix crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,21 @@ +// RUN: %clang_analyze_cc1 -std=c++23 %s -verify -analyzer-checker=alpha.cplusplus.InvalidatedIterator -analyzer-config aggressive-binary-operation-simplification=true + +// expected-no-diagnostics + +class ExplicitThis { + int f = 0; +public: + ExplicitThis(

[clang] [clang][analyzer] Fix crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. I have not much to say. It's an alpha checker, that is known for crashing. One less crash wouldn't change the situation by much but would certainly push the needle to the right direction. https://github.com/llvm/llvm-project/pull/132581 __

[clang] [NFC][clang] Remove superfluous header files after refactor in #132252 (PR #132495)

2025-03-24 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm approved this pull request. LGTM. Does this actually fix the build time regression from the previous patch? https://github.com/llvm/llvm-project/pull/132495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-24 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: I'd prefer to go ahead with this and continue the discussion once that PR landed. This would unbreak the checks/resolve the backward compatibility issues while providing some of the benefits (even if the perf gain is smaller). At least we will be in a state that does not break

[libclc] [libclc] Add license headers to files missing them (PR #132239)

2025-03-24 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/132239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Fix crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread Gábor Horváth via cfe-commits
@@ -157,8 +157,11 @@ void ContainerModeling::checkPostCall(const CallEvent &Call, if (Func->isOverloadedOperator()) { const auto Op = Func->getOverloadedOperator(); if (Op == OO_Equal) { - // Overloaded 'operator=' must be a non-static member function. - co

[clang] [clang][analyzer] Fix crash caused by overload operator member function with explicit this (PR #132581)

2025-03-24 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/132581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] link_bc target should depends on target builtins.link.clc-arch_suffix (PR #132338)

2025-03-24 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/132338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add initial support for -mcpu=olympus. (PR #132368)

2025-03-24 Thread David Green via cfe-commits
@@ -872,6 +883,16 @@ def ProcessorFeatures { list Carmel = [HasV8_2aOps, FeatureNEON, FeatureSHA2, FeatureAES, FeatureFullFP16, FeatureCRC, FeatureLSE, FeatureRAS, FeatureRDM, FeatureFPARMv8]; + li

[clang] [Clang] Fix the assertion condition after b8d1f3d6 (PR #132669)

2025-03-24 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/132669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cc5f829 - [clang][scan-build] Treat --use-cc and --use-c++ as shell commands (#131932)

2025-03-24 Thread via cfe-commits
Author: Florian Ragwitz Date: 2025-03-24T11:09:03+01:00 New Revision: cc5f8293b320d1c6c4d0552cfab481332c83723e URL: https://github.com/llvm/llvm-project/commit/cc5f8293b320d1c6c4d0552cfab481332c83723e DIFF: https://github.com/llvm/llvm-project/commit/cc5f8293b320d1c6c4d0552cfab481332c83723e.dif

[libclc] 735d7c1 - [libclc] link_bc target should depends on target builtins.link.clc-arch_suffix (#132338)

2025-03-24 Thread via cfe-commits
Author: Wenju He Date: 2025-03-24T10:09:19Z New Revision: 735d7c153947fd3f1adfb3cda9d29a8359870db0 URL: https://github.com/llvm/llvm-project/commit/735d7c153947fd3f1adfb3cda9d29a8359870db0 DIFF: https://github.com/llvm/llvm-project/commit/735d7c153947fd3f1adfb3cda9d29a8359870db0.diff LOG: [lib

[clang] [clang][scan-build] Treat --use-cc and --use-c++ as shell commands (PR #131932)

2025-03-24 Thread via cfe-commits
github-actions[bot] wrote: @rafl Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, yo

[clang] [clang][scan-build] Treat --use-cc and --use-c++ as shell commands (PR #131932)

2025-03-24 Thread Balázs Benics via cfe-commits
https://github.com/balazs-benics-sonarsource closed https://github.com/llvm/llvm-project/pull/131932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Skip opt command if opt_flags is empty (PR #130882)

2025-03-24 Thread Fraser Cormack via cfe-commits
@@ -342,22 +342,32 @@ function(add_libclc_builtin_set) set( builtins_opt_lib_tgt builtins.opt.${ARG_ARCH_SUFFIX} ) - # Add opt target - add_custom_command( OUTPUT ${builtins_opt_lib_tgt}.bc -COMMAND ${opt_exe} ${ARG_OPT_FLAGS} -o ${builtins_opt_lib_tgt}.bc - ${bu

[libclc] [libclc] link_bc target should depends on target builtins.link.clc-arch_suffix (PR #132338)

2025-03-24 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/132338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-24 Thread Ilya Biryukov via cfe-commits
@@ -29096,6 +29096,17 @@ TEST_F(FormatTest, BreakBeforeClassName) { "ArenaSafeUniquePtr {};"); } +TEST_F(FormatTest, DoesNotCrashOnNonNullTerminatedStringRefs) { + llvm::StringRef TwoLines = "namespace foo {}\n" + "namespace bar

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-24 Thread via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.2-library %s -fnative-half-type -emit-llvm -O1 -o - | FileCheck %s + +// CHECK: define {{.*}}test_ints{{.*}}(i16 {{.*}} [[VAL:%.*]]){{.*}} +// CHECK-NOT: bitcast +// CHECK: ret i16

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-03-24 Thread Tom Tromey via cfe-commits
tromey wrote: > Given the _vtable$ artificial member: use the DW_AT_containing_type to find > the vtable global variable. It seems to me that this attribute should refer to a type and not a variable. https://github.com/llvm/llvm-project/pull/130255 _

[clang] c7f14f6 - [clang][bytecode] Implement __builtin_wcschr (#132708)

2025-03-24 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-24T12:28:23+01:00 New Revision: c7f14f601f36f8fdabb9182e253add18a471308f URL: https://github.com/llvm/llvm-project/commit/c7f14f601f36f8fdabb9182e253add18a471308f DIFF: https://github.com/llvm/llvm-project/commit/c7f14f601f36f8fdabb9182e253add18a471308f.diff L

[clang] [clang][bytecode] Implement __builtin_wcschr (PR #132708)

2025-03-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/132708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][FMV][AArch64] Tidy up codegen tests. (PR #132273)

2025-03-24 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm approved this pull request. I can't check 100% we are not missing anything important, but if you are confident then go for it. https://github.com/llvm/llvm-project/pull/132273 ___ cfe-commits mailing list cfe-commits@l

[clang] [llvm] [AArch64] Add initial support for -mcpu=olympus. (PR #132368)

2025-03-24 Thread Ricardo Jesus via cfe-commits
https://github.com/rj-jesus updated https://github.com/llvm/llvm-project/pull/132368 >From b9725e115876f26311edd408b9d4521ae8a03ebd Mon Sep 17 00:00:00 2001 From: Ricardo Jesus Date: Wed, 4 Dec 2024 05:42:38 -0800 Subject: [PATCH 1/2] [AArch64] Add initial support for -mcpu=olympus. This patch

[clang-tools-extra] 76b999d - [clang-tidy] Avoid repeated map lookups (NFC) (#132656)

2025-03-24 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-03-24T00:13:21-07:00 New Revision: 76b999d70f71dd4339de60f1616c02051f51e001 URL: https://github.com/llvm/llvm-project/commit/76b999d70f71dd4339de60f1616c02051f51e001 DIFF: https://github.com/llvm/llvm-project/commit/76b999d70f71dd4339de60f1616c02051f51e001.diff L

[clang] [Mips] Fix clang compile error when -march=p5600 with -mmsa (PR #132679)

2025-03-24 Thread via cfe-commits
https://github.com/yingopq edited https://github.com/llvm/llvm-project/pull/132679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][RISCV] Fix RUN line and rename test name for pr129995 (PR #132676)

2025-03-24 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. https://github.com/llvm/llvm-project/pull/132676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC] Initial implementation of P2719 (PR #113510)

2025-03-24 Thread Oliver Hunt via cfe-commits
@@ -3134,6 +3134,31 @@ bool Type::isStdByteType() const { return false; } +bool Type::isDestroyingDeleteT() const { + auto *RD = getAsCXXRecordDecl(); + return RD && RD->isInStdNamespace() && RD->getIdentifier() && + RD->getIdentifier()->isStr("destroying_delete_t"

[clang] [llvm] [ARM] Adding diagnostics for mcmodel=tiny when used in invalid targets (PR #125643)

2025-03-24 Thread via cfe-commits
ShashwathiNavada wrote: ping @cor3ntin @hstk30-hw https://github.com/llvm/llvm-project/pull/125643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Adding diagnostics for mcmodel=tiny when used in invalid targets (PR #125643)

2025-03-24 Thread via cfe-commits
hstk30-hw wrote: Hi, these is a pending review suggestion. Just put the test cast to exist test file, maybe like clang/test/Driver/mcmodel.c PLS https://github.com/llvm/llvm-project/pull/125643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

2025-03-24 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-24 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh edited https://github.com/llvm/llvm-project/pull/132883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] ``noconvergent`` does not affect calls to convergent functions (PR #132701)

2025-03-24 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra closed https://github.com/llvm/llvm-project/pull/132701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] Improve diagnostics for expansion length mismatch" (PR #121044)

2025-03-24 Thread Matheus Izvekov via cfe-commits
@@ -749,132 +759,124 @@ ExprResult Sema::CheckPackExpansion(Expr *Pattern, SourceLocation EllipsisLoc, PackExpansionExpr(Context.DependentTy, Pattern, EllipsisLoc, NumExpansions); } +static bool IsUnexpandedPackExpansion(const TemplateArgument &TA) { + if (!TA.isPackExp

<    1   2   3   4   5