[clang] [CIR] Upstream initial support for CIR flattening (PR #130648)

2025-03-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. 1 nit, else LGTM. https://github.com/llvm/llvm-project/pull/130648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] emit -Wunused-variable warning for unused structured bindings without the [[maybe_unused]] attribute (PR #127061)

2025-03-11 Thread Oleksandr T. via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++2c -Wunused %s + +namespace GH125810 { +struct S { + int a, b; +}; + +void t(S s) { + auto &[_, _] = s; + auto &[a1, _] = s; // expected-warning {{unused variable '[a1, _]'}} a-tarasyuk wrote:

[clang] [Clang] Add __builtin_elementwise_exp10 in the same fashion as exp/exp2 (PR #130746)

2025-03-11 Thread Matt Arsenault via cfe-commits
Juan Manuel Martinez =?utf-8?q?Caama=C3=B1o?= Message-ID: In-Reply-To: https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/130746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [Clang] Add __builtin_elementwise_exp10 in the same fashion as exp/exp2 (PR #130746)

2025-03-11 Thread Matt Arsenault via cfe-commits
Juan Manuel Martinez =?utf-8?q?Caama=C3=B1o?= Message-ID: In-Reply-To: https://github.com/arsenm commented: Add to release notes? https://github.com/llvm/llvm-project/pull/130746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [Clang][NFC] update_cc_test_checks over strictfp-elementwise-bulitins.cpp (PR #130747)

2025-03-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/130747 From c017072c34203a25f4f179dc70e4adc27094c5dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Mon, 10 Mar 2025 15:40:00 +0100 Subject: [PATCH] [Clang][NFC] Rename and

[clang] [llvm] Add support for template as type parameter (PR #127654)

2025-03-11 Thread via cfe-commits
ykhatav wrote: > 0x0042: DW_TAG_structure_type > DW_AT_calling_convention(DW_CC_pass_by_value) > DW_AT_name ("other") > DW_AT_byte_size (0x08) > DW_AT_decl_file ("") > DW_AT_decl_line (6) > > 0x000

[clang] [Clang][NFC] Rename and update_cc_test_checks over strictfp-elementwise-builtins.cpp (PR #130747)

2025-03-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/130747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb397ab - Reland "[clang] Lower modf builtin using `llvm.modf` intrinsic" (#130761)

2025-03-11 Thread via cfe-commits
Author: Benjamin Maxwell Date: 2025-03-11T14:55:33Z New Revision: fb397ab1e5f32e179094580174f42115961b7790 URL: https://github.com/llvm/llvm-project/commit/fb397ab1e5f32e179094580174f42115961b7790 DIFF: https://github.com/llvm/llvm-project/commit/fb397ab1e5f32e179094580174f42115961b7790.diff L

[clang] disable unary, vector mask (PR #130400)

2025-03-11 Thread via cfe-commits
wsehjk wrote: In the `builtinshufflevetor2.c` test ```c++ // CHECK-LABEL: define {{.*}}void @clang_shufflevector_v_v( void clang_shufflevector_v_v( float4* A, float4 x, uint4 mask ) { // CHECK: [[MASK:%.*]] = and <4 x i32> {{%.*}}, splat (i32 3) // CHECK: [[I:%.*]] = extractelement <4 x i32> [[MA

[libclc] [libclc] Fix commands in compile_to_bc are executed sequentially (PR #130755)

2025-03-11 Thread Wenju He via cfe-commits
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/130755 >From 1f8b5bfbfea6b562e9cae088256e8e5dddf0a335 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Tue, 11 Mar 2025 04:24:36 -0700 Subject: [PATCH 1/2] [libclc] Fix commands in compile_to_bc are executed sequentiall

[clang] [NFC][analyzer] Remove CheckerNameRef::getName() (PR #130780)

2025-03-11 Thread Balazs Benics via cfe-commits
steakhal wrote: > I have no strong feelings about the implicit/explicit question. I am also not > sure we need this lightweight wrapper type. I also fail to see the benefit of this strong-type. https://github.com/llvm/llvm-project/pull/130780 ___ cfe

[clang] Reland "[clang] Lower modf builtin using `llvm.modf` intrinsic" (PR #130761)

2025-03-11 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue closed https://github.com/llvm/llvm-project/pull/130761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] support pointee mutation check in misc-const-correctness (PR #130494)

2025-03-11 Thread via cfe-commits
@@ -110,6 +110,13 @@ Options // No warning int const& ref = i; +.. option:: AnalyzePointers + + Enable or disable the analysis of pointers variables, like + ``int *ptr = &i;``. For specific checks, see options + `WarnPointersAsValues` and `WarnPointersAsPointers`.

[clang] [clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/128150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [AstMatcher]`templateArgumentCountIs` support `FunctionDecl` (PR #130416)

2025-03-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 83ec179 - [Clang][NFC] Rename and update_cc_test_checks over strictfp-elementwise-builtins.cpp (#130747)

2025-03-11 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2025-03-11T17:16:32+01:00 New Revision: 83ec179fc8b44ae23a0bfe51073d5ce75155639e URL: https://github.com/llvm/llvm-project/commit/83ec179fc8b44ae23a0bfe51073d5ce75155639e DIFF: https://github.com/llvm/llvm-project/commit/83ec179fc8b44ae23a0bfe51073d5ce

[clang] [Clang][NFC] Rename and update_cc_test_checks over strictfp-elementwise-builtins.cpp (PR #130747)

2025-03-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/130747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __builtin_elementwise_exp10 in the same fashion as exp/exp2 (PR #130746)

2025-03-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/130746 From 5c4c285df2d39e93c80b11396511b7d238b281b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Mon, 10 Mar 2025 15:35:27 +0100 Subject: [PATCH] [Clang] Add __builtin_el

[clang] [flang] [flang] Add support for -f[no-]verbose-asm (PR #130788)

2025-03-11 Thread Kajetan Puchalski via cfe-commits
mrkajetanp wrote: I tested it, working as expected for me. Very nice! https://github.com/llvm/llvm-project/pull/130788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] emit -Wunused-variable warning for unused structured bindings without the [[maybe_unused]] attribute (PR #127061)

2025-03-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/127061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] emit -Wunused-variable warning for unused structured bindings without the [[maybe_unused]] attribute (PR #127061)

2025-03-11 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++2c -Wunused %s + +namespace GH125810 { +struct S { + int a, b; +}; + +void t(S s) { + auto &[_, _] = s; + auto &[a1, _] = s; // expected-warning {{unused variable '[a1, _]'}} AaronBallman wrote:

[clang] [Clang] emit -Wunused-variable warning for unused structured bindings without the [[maybe_unused]] attribute (PR #127061)

2025-03-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/127061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix darwin-related tests' REQUIRES annotation (PR #130138)

2025-03-11 Thread Lucas Duarte Prates via cfe-commits
pratlucas wrote: For context, we're observing this issue as part of our CI builds for the [arm/arm-toolchain](https://github.com/arm/arm-toolchain) project. Looking into it in more detail, I believe I didn't express myself correctly when I wrote "When no darwin targets are included in the buil

[clang] [Clang] Add __builtin_elementwise_exp10 in the same fashion as exp/exp2 (PR #130746)

2025-03-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/130746 From 43431642d278011477387ae6bfb2913103aca1ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Mon, 10 Mar 2025 15:35:27 +0100 Subject: [PATCH] [Clang] Add __builtin_el

[clang] [clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-11 Thread Carlos Galvez via cfe-commits
@@ -449,6 +453,7 @@ ClangTidyASTConsumerFactory::createASTConsumer( } std::vector> Consumers; + carlosgalvezp wrote: Nope, fixed! https://github.com/llvm/llvm-project/pull/128150 ___ cfe-commits mailing list cf

[clang] [clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-11 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/128150 >From 3207b26f41bc85955616dceb35dd65d66f6b9b6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Thu, 20 Feb 2025 12:37:15 + Subject: [PATCH] [clang-tidy] Avoid processing declarati

[clang] [Clang] Allow devirtualization involving array subscripts with constant indices when the pointee type is known (PR #130528)

2025-03-11 Thread via cfe-commits
https://github.com/AZero13 converted_to_draft https://github.com/llvm/llvm-project/pull/130528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix unsupported types always being equal (PR #129502)

2025-03-11 Thread Jan Voung via cfe-commits
jvoung wrote: Sorry for the delay! I ran a few more tests and the downstream null analysis over a corpus of code with a small change to the patch. The small tweak (below) seems to pass the tests and your fix helps cover more code, as expected =) (e.g., analyze both branches when there is an `i

[clang] [Clang] Add __builtin_elementwise_exp10 in the same fashion as exp/exp2 (PR #130746)

2025-03-11 Thread Francis Visoiu Mistrih via cfe-commits
Juan Manuel Martinez =?utf-8?q?Caama=C3=B1o?= Message-ID: In-Reply-To: https://github.com/francisvm approved this pull request. https://github.com/llvm/llvm-project/pull/130746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [profile] runtime counter relocation is needed on windows-msvc targets (PR #127858)

2025-03-11 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Thanks for the very thorough explanation! > Note if we miss a condition/configuration then it doesn't break the feature > there, it just would > [fail](https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/profile/InstrProfilingFile.c#L662) > at runtime if you try ena

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl ready_for_review https://github.com/llvm/llvm-project/pull/130724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer] Remove CheckerNameRef::getName() (PR #130780)

2025-03-11 Thread Donát Nagy via cfe-commits
NagyDonat wrote: I agree that removing `CheckerNameRef` might be a good step in the future. Right now I'm keeping it because the removal commit would touch 23 files, but maybe I will do it in the future. https://github.com/llvm/llvm-project/pull/130780 _

[clang] a71c9d8 - [NFC][analyzer] Remove CheckerNameRef::getName() (#130780)

2025-03-11 Thread via cfe-commits
Author: Donát Nagy Date: 2025-03-11T16:33:10+01:00 New Revision: a71c9d8438622013eddf04cf4c81ab0f22a83055 URL: https://github.com/llvm/llvm-project/commit/a71c9d8438622013eddf04cf4c81ab0f22a83055 DIFF: https://github.com/llvm/llvm-project/commit/a71c9d8438622013eddf04cf4c81ab0f22a83055.diff LO

[clang] [NFC][analyzer] Remove CheckerNameRef::getName() (PR #130780)

2025-03-11 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/130780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Sarah Spall via cfe-commits
https://github.com/spall commented: Looks mostly good to me, a couple of questions though which applied to most of the templates in the code, but I only commented on the first instances I saw. 1. Do you need to check T is arithmetic if you're also checking its half? Wont' the half check suffice

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Sarah Spall via cfe-commits
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/130724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Sarah Spall via cfe-commits
@@ -89,23 +89,31 @@ void asuint(double4, out uint4, out uint4); /// \param X The X input value. /// \param Y The Y input value. +template _HLSL_16BIT_AVAILABILITY(shadermodel, 6.2) -const inline half distance(half X, half Y) { +const inline __detail::enable_if_t<__detail::is

[clang] [clang] Fix darwin-related tests' REQUIRES annotation (PR #130138)

2025-03-11 Thread Lucas Duarte Prates via cfe-commits
pratlucas wrote: > Maybe pass a platform for the failing tests so there is no need for > system-darwin or target for REQUIRES Do you mean by adding a `--target` option to the tests? I think this would also be a valid solution, but I can't tell if this would go against the original intent of t

[clang-tools-extra] [clang-tidy][NFC]clean ConstCorrectnessCheck (PR #130493)

2025-03-11 Thread Carlos Galvez via cfe-commits
@@ -136,16 +136,14 @@ void ConstCorrectnessCheck::check(const MatchFinder::MatchResult &Result) { return; VariableCategory VC = VariableCategory::Value; - if (Variable->getType()->isReferenceType()) + const QualType VT = Variable->getType(); + if (VT->isReferenceType

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Sarah Spall via cfe-commits
@@ -45,6 +45,10 @@ template struct is_arithmetic { static const bool Value = __is_arithmetic(T); }; +template +using HLSL_FIXED_VECTOR = +vector<__detail::enable_if_t<(N > 1 && N <= 4), T>, N>; spall wrote: should the enable_if_t not go around the ent

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Sarah Spall via cfe-commits
@@ -89,23 +89,31 @@ void asuint(double4, out uint4, out uint4); /// \param X The X input value. /// \param Y The Y input value. +template _HLSL_16BIT_AVAILABILITY(shadermodel, 6.2) -const inline half distance(half X, half Y) { +const inline __detail::enable_if_t<__detail::is

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcibi (Branch Immediate) extension (PR #130779)

2025-03-11 Thread Craig Topper via cfe-commits
@@ -397,6 +446,25 @@ let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in { } // hasSideEffects = 0, mayLoad = 0, mayStore = 0 } // Predicates = [HasVendorXqcia, IsRV32] +let Predicates = [HasVendorXqcibi, IsRV32] in { +let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in { --

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Farzon Lotfi via cfe-commits
@@ -45,6 +45,10 @@ template struct is_arithmetic { static const bool Value = __is_arithmetic(T); }; +template +using HLSL_FIXED_VECTOR = +vector<__detail::enable_if_t<(N > 1 && N <= 4), T>, N>; farzonl wrote: i tried that, but if you do `__detail::ena

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Farzon Lotfi via cfe-commits
@@ -89,23 +89,31 @@ void asuint(double4, out uint4, out uint4); /// \param X The X input value. /// \param Y The Y input value. +template _HLSL_16BIT_AVAILABILITY(shadermodel, 6.2) -const inline half distance(half X, half Y) { +const inline __detail::enable_if_t<__detail::is

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Sarah Spall via cfe-commits
@@ -89,23 +89,31 @@ void asuint(double4, out uint4, out uint4); /// \param X The X input value. /// \param Y The Y input value. +template _HLSL_16BIT_AVAILABILITY(shadermodel, 6.2) -const inline half distance(half X, half Y) { +const inline __detail::enable_if_t<__detail::is

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Farzon Lotfi via cfe-commits
@@ -89,23 +89,31 @@ void asuint(double4, out uint4, out uint4); /// \param X The X input value. /// \param Y The Y input value. +template _HLSL_16BIT_AVAILABILITY(shadermodel, 6.2) -const inline half distance(half X, half Y) { +const inline __detail::enable_if_t<__detail::is

[clang] [Clang] add additional tests for -Wshift-bool (PR #130339)

2025-03-11 Thread Oleksandr T. via cfe-commits
@@ -0,0 +1,24 @@ +// RUN: %clang_cc1 -fsyntax-only -Wshift-bool -verify %s + +void t() { + int x = 10; + int y = 1; + + int a = y << x; + int b = y >> x; + + int c = 0 << x; + int d = 0 >> x; + + int e = y << 1; + int f = y >> 1; + + int g = y << -1; // expected-warning {

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Sarah Spall via cfe-commits
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/130724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add bounds checks for the hlsl vector arguments and return types (PR #130724)

2025-03-11 Thread Farzon Lotfi via cfe-commits
@@ -89,23 +89,31 @@ void asuint(double4, out uint4, out uint4); /// \param X The X input value. /// \param Y The Y input value. +template _HLSL_16BIT_AVAILABILITY(shadermodel, 6.2) -const inline half distance(half X, half Y) { +const inline __detail::enable_if_t<__detail::is

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2025-03-11 Thread Aaron Ballman via cfe-commits
@@ -6519,6 +6519,13 @@ def warn_signed_bitfield_enum_conversion : Warning< InGroup, DefaultIgnore; def note_change_bitfield_sign : Note< "consider making the bit-field type %select{unsigned|signed}0">; +def warn_ms_bitfield_mismatched_storage_packing : Warning< + "bit-fiel

[clang] Reland Fix amdgpu-arch for dll name on Windows (PR #130624)

2025-03-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Yaxun (Sam) Liu (yxsamliu) Changes Reload aba3005a after fixing build failure. Recently HIP runtime changed dll name to amdhip64_n.dll on Windows, where n is ROCm major version number. Fix amdgpu-arch to search for amdhip64_n.dl

[clang] [CIR] Upstream basic support for ArrayType (PR #130502)

2025-03-11 Thread Andy Kaylor via cfe-commits
@@ -166,6 +166,9 @@ static LogicalResult checkConstantTypes(mlir::Operation *op, mlir::Type opType, return success(); } + if (mlir::isa(opType)) andykaylor wrote: I don't see this in the incubator implementation of this function. Why is this here? h

[clang] [CIR] Upstream basic support for ArrayType (PR #130502)

2025-03-11 Thread Amr Hesham via cfe-commits
@@ -202,6 +202,18 @@ mlir::Type CIRGenTypes::convertType(QualType type) { break; } + case Type::ConstantArray: { +const ConstantArrayType *arrTy = cast(ty); +mlir::Type elemTy = convertTypeForMem(arrTy->getElementType()); + +// FIXME: In LLVM, "lower arrays

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-11 Thread via cfe-commits
cor3ntin wrote: @shafik can you merge once you are happy? https://github.com/llvm/llvm-project/pull/128866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] make semantic matching case insensitive (PR #129773)

2025-03-11 Thread Chris B via cfe-commits
llvm-beanz wrote: > > nit: is there a way to check that the spelling is consistent in the error > > messages? Asking since I am no familiar with this part of the code. > > I'm not sure I understand what you mean. I think the point (and my earlier comment) is to use the spelling as it is writt

[clang] [clang-tools-extra] [clang] improve class type sugar preservation in pointers to members (PR #130537)

2025-03-11 Thread Erich Keane via cfe-commits
@@ -13461,13 +13486,112 @@ static ElaboratedTypeKeyword getCommonTypeKeyword(const T *X, const T *Y) { : ElaboratedTypeKeyword::None; } +static NestedNameSpecifier *getCommonNNS(ASTContext &Ctx, +

[clang] [llvm] [Support] Return `LockFileManager` errors right away (PR #130627)

2025-03-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c40f0fe4348bb9304b95bd317665bf1cb2bdcc85 88b5bbd1303480dc40db3ea76d0f831a69ff1957 --e

[clang] [llvm] [Support] Return `LockFileManager` errors right away (PR #130627)

2025-03-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Jan Svoboda (jansvoboda11) Changes This patch removes some internal state out of `LockFileManager` by moving the locking code from the constructor into new member function `tryLock()` which returns the e

[clang] [clang][DependencyScanning] Track modules that resolve from sysroot. (PR #130634)

2025-03-11 Thread Cyndy Ishida via cfe-commits
cyndyishida wrote: > but I'm concerned that this does not guarantee the resulting command line > only refers to inputs in the sysroot. Imagine that we run this without the > header search and VFS pruning optimizations - the command line will likely > refer to unused project-specific source/bui

[clang] [Clang] Implement P0963R3 "Structured binding declaration as a condition" (PR #130228)

2025-03-11 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM, sans a few nitty nits. Thanks! https://github.com/llvm/llvm-project/pull/130228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [llvm] [ARM][Clang] Make `+nosimd` functional for AArch32 Targets (PR #130623)

2025-03-11 Thread David Spickett via cfe-commits
DavidSpickett wrote: > used to emable or disable enable https://github.com/llvm/llvm-project/pull/130623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c40f0fe - Revert "Reland "[clang] Lower modf builtin using `llvm.modf` intrinsic" (#129885)"

2025-03-11 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2025-03-10T16:35:03+01:00 New Revision: c40f0fe4348bb9304b95bd317665bf1cb2bdcc85 URL: https://github.com/llvm/llvm-project/commit/c40f0fe4348bb9304b95bd317665bf1cb2bdcc85 DIFF: https://github.com/llvm/llvm-project/commit/c40f0fe4348bb9304b95bd317665bf1cb2bdcc85.diff

[clang] C89 doesn't have `math.h` functions (PR #129979)

2025-03-11 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/129979 >From e9c7869550d9fd1eba4d4d42ee644540e6b6d445 Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Tue, 4 Mar 2025 22:30:34 -0500 Subject: [PATCH 01/10] a

[clang] [clang][Sema] Propagate qualifiers during derived-to-base conversion (PR #127824)

2025-03-11 Thread Antonio Frighetto via cfe-commits
https://github.com/antoniofrighetto updated https://github.com/llvm/llvm-project/pull/127824 >From 47fc0c9fb963cef24a32078bc52232e69a93c211 Mon Sep 17 00:00:00 2001 From: Antonio Frighetto Date: Wed, 19 Feb 2025 16:47:18 +0100 Subject: [PATCH] [clang][Sema] Propagate qualifiers during derived-t

[clang-tools-extra] [clang-tidy][NFC] clean ReleaseNotes.rst (PR #130626)

2025-03-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) Changes 1. Fixed ordering to be alphabetical 2. Made lines no more than 80 characters long 3. Fixed typos --- Full diff: https://github.com/llvm/llvm-project/pull/130626.diff 1 Files Affected: - (mo

[clang-tools-extra] [clang-tidy][NFC] clean ReleaseNotes.rst (PR #130626)

2025-03-11 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/130626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Support] Return `LockFileManager` errors right away (PR #130627)

2025-03-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/130627 >From 88b5bbd1303480dc40db3ea76d0f831a69ff1957 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Sat, 8 Mar 2025 21:51:51 -0800 Subject: [PATCH 1/2] [Support] Return `LockFileManager` errors right away ---

[clang] c35092c - [ARM] Fix HW thread pointer functionality (#130027)

2025-03-11 Thread via cfe-commits
Author: Austin Date: 2025-03-10T14:18:11Z New Revision: c35092c7f1b3f190e88c3dd70056a1596a3a8fc6 URL: https://github.com/llvm/llvm-project/commit/c35092c7f1b3f190e88c3dd70056a1596a3a8fc6 DIFF: https://github.com/llvm/llvm-project/commit/c35092c7f1b3f190e88c3dd70056a1596a3a8fc6.diff LOG: [ARM]

[clang] [clang][SPIR-V] Use the SPIR-V backend by default (PR #129545)

2025-03-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. LG from the clang driver side. I'll let the SPIR-V experts determine the rest. https://github.com/llvm/llvm-project/pull/129545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [flang] [flang/clang] Adding use of Clang's diagnostics in Flang (PR #130593)

2025-03-11 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > In general, we aim to only depend on libClangDriver and move it to LLVM so > that Flang need not depend on Clang or its libraries. If this patch increases > the dependency on Clang it might not be acceptable. Agreed. 👍 @JDPailleux: It may a good idea to extract the diagnost

[clang] [clang][NFC] Clean up Expr::EvaluateAsConstantExpr (PR #130498)

2025-03-11 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/130498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reapply "[AArch64][SVE] Improve fixed-length addressing modes. (#130263)" (PR #130625)

2025-03-11 Thread Ricardo Jesus via cfe-commits
https://github.com/rj-jesus created https://github.com/llvm/llvm-project/pull/130625 This restores commit f01e760c08365426de95f02dc2c2dc670eb47352. The original patch from #129732 exposed what seems to be a bug in `SelectAddrModeIndexedSVE`. Currently, the offset returned by `SelectAddrModeIn

[clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

2025-03-11 Thread Nikita Popov via cfe-commits
nikic wrote: Yes, reverting the change did recover the regression. Did you test exactly the change that was landed? It's also possible that it interacted with something that landed in the meantime... https://github.com/llvm/llvm-project/pull/126088 _

[clang] [llvm] AMDGPU: Move enqueued block handling into clang (PR #128519)

2025-03-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: ### Merge activity * **Mar 10, 8:52 AM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/128519). https://github.com/llvm/llvm-project/pull/128519 _

[clang] [flang] [flang] Align `-x` language modes with `gfortran` (PR #130268)

2025-03-11 Thread David Truby via cfe-commits
=?utf-8?q?Iñaki?= Amatria Barral Message-ID: In-Reply-To: https://github.com/DavidTruby edited https://github.com/llvm/llvm-project/pull/130268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [clang][AMDGPU] Enable module splitting by default (PR #128509)

2025-03-11 Thread Shilei Tian via cfe-commits
shiltian wrote: I'm okay with this change, but did you run a PSDB or even a full testing cycle? https://github.com/llvm/llvm-project/pull/128509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-11 Thread Farzon Lotfi via cfe-commits
@@ -97,6 +97,31 @@ constexpr vector reflect_vec_impl(vector I, vector N) { #endif } +template +constexpr enable_if_t::value || is_same::value, T> farzonl wrote: move these changes to `clang/lib/Headers/hlsl/hlsl_intrinsic_helpers.h`. After @llvm-beanz cha

[clang] [Clang] Allow devirtualization involving array subscripts with constant indices when the pointee type is known (PR #130528)

2025-03-11 Thread via cfe-commits
https://github.com/AZero13 updated https://github.com/llvm/llvm-project/pull/130528 >From 6edb96aeb19db0cae71ce35481eb7c009b94cb3b Mon Sep 17 00:00:00 2001 From: Rose Date: Sun, 9 Mar 2025 20:05:38 -0400 Subject: [PATCH] [Clang] Allow devirtualization involving array subscripts with constant i

[clang] [Clang] Implement P0963R3 "Structured binding declaration as a condition" (PR #130228)

2025-03-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/130228 >From 295b8173b6913d9014c5786eb4af0112384afa65 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 7 Mar 2025 11:38:11 +0800 Subject: [PATCH 1/9] [Clang] Implement P0963R3 "Structured binding declaration as

[clang] [clang][analyzer] Add support for C++23 container methods releated to iterator in ContainerModeling (PR #129719)

2025-03-11 Thread via cfe-commits
flovent wrote: @NagyDonat Hi, sorry to bother, can you review this PR? i don't have access to request review and i see that the last commit of this checker is submitted by you. https://github.com/llvm/llvm-project/pull/129719 ___ cfe-commits mailing

[clang] [clang][bytecode] Fix builtin_memcmp buffer sizes for pointers (PR #130570)

2025-03-11 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/130570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Handle indexes (PR #130528)

2025-03-11 Thread via cfe-commits
https://github.com/AZero13 reopened https://github.com/llvm/llvm-project/pull/130528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] improve class type sugar preservation in pointers to members (PR #130537)

2025-03-11 Thread Matheus Izvekov via cfe-commits
@@ -10033,15 +10040,24 @@ class Sema final : public SemaBase { bool InOverloadResolution, QualType &ConvertedType); + enum class CheckMemberPointerConversionResult { mizvekov wrote: Right but

[clang] 7d8da04 - [OpenACC] Implement 'nohost' construct AST/Sema

2025-03-11 Thread via cfe-commits
Author: erichkeane Date: 2025-03-06T12:50:49-08:00 New Revision: 7d8da04c26bffd9da4461eef181df39c46292fa3 URL: https://github.com/llvm/llvm-project/commit/7d8da04c26bffd9da4461eef181df39c46292fa3 DIFF: https://github.com/llvm/llvm-project/commit/7d8da04c26bffd9da4461eef181df39c46292fa3.diff LO

[clang] Forbid co_await and co_yield in invalid expr contexts (PR #130455)

2025-03-11 Thread via cfe-commits
NewSigma wrote: Yes, please. Thank you! https://github.com/llvm/llvm-project/pull/130455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream basic support for ArrayType (PR #130502)

2025-03-11 Thread Andy Kaylor via cfe-commits
@@ -369,6 +369,22 @@ BoolType::getABIAlignment(const ::mlir::DataLayout &dataLayout, return 1; } +//===--===// +// Definitions +//===--==

[clang] Reland "[clang] Lower modf builtin using `llvm.modf` intrinsic" (PR #129885)

2025-03-11 Thread Hans Wennborg via cfe-commits
zmodem wrote: This broke code using `modff` on 32-bit x86 Windows, where the runtime library doesn't provide any `modff` symbol, rather it's implemented inline in `math.h` (which calls `modf`): ``` >type \src\temp\a.c #include #include float foo(float f) { float i; return modff(f, &i);

[clang] [CIR] Upstream basic support for ArrayType (PR #130502)

2025-03-11 Thread Bruno Cardoso Lopes via cfe-commits
@@ -280,6 +280,25 @@ def CIR_BoolType : }]; } +//===--===// +// ArrayType +//===--===// + +def CIR_ArrayType : CIR_Type<"Array", "array", +

[clang] [llvm] [Support] Return `LockFileManager` errors right away (PR #130627)

2025-03-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/130627 This patch removes some internal state out of `LockFileManager` by moving the locking code from the constructor into new member function `tryLock()` which returns the errors right away. This simplifies and

[clang] [clang-tools-extra] [clang] improve class type sugar preservation in pointers to members (PR #130537)

2025-03-11 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: A dependent PR had been merged meanwhile, and this was not rebased. While this patch is still big, you might have been seeing way more stuff than was actually in the PR. I just rebased, but have not addressed any comments yet. https://github.com/llvm/llvm-project/pull/130537 _

[clang] [llvm] [MIPS] Add MIPS i6400 and i6500 processors (PR #130587)

2025-03-11 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro requested changes to this pull request. Thanks for working on this. https://github.com/llvm/llvm-project/pull/130587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [Clang] Implement P0963R3 "Structured binding declaration as a condition" (PR #130228)

2025-03-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/130228 >From 295b8173b6913d9014c5786eb4af0112384afa65 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 7 Mar 2025 11:38:11 +0800 Subject: [PATCH 01/10] [Clang] Implement P0963R3 "Structured binding declaration a

[clang-tools-extra] [clang-tidy] Add check on constexpr & static values in modernize-use-default-member-init (PR #129425)

2025-03-11 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: @RiverDave Unless you want this to be merged using github generated private email, change your email privacy settings. https://github.com/llvm/llvm-project/pull/129425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [Clang] add additional tests for -Wshift-bool (PR #130339)

2025-03-11 Thread Aaron Ballman via cfe-commits
@@ -22,4 +23,6 @@ void t() { if ((y << 1) != 0) { } if ((y >> 1) != 0) { } // expected-warning {{right shifting a 'bool' implicitly converts it to 'int'}} + + bool k = (x < z) >> 1; // expected-warning {{right shifting a 'bool' implicitly converts it to 'int'}}

[clang] C89 doesn't have `math.h` functions (PR #129979)

2025-03-11 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/129979 >From e9c7869550d9fd1eba4d4d42ee644540e6b6d445 Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Tue, 4 Mar 2025 22:30:34 -0500 Subject: [PATCH 1/9] add

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-03-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-dylib` running on `bolt-worker` while building `llvm` at step 5 "build-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/119/builds/4858 Here is the relevant piece of the build

[clang] a1a6a83 - [clang] fix matching of nested template template parameters (#130447)

2025-03-11 Thread via cfe-commits
Author: Matheus Izvekov Date: 2025-03-10T10:08:43-03:00 New Revision: a1a6a839763079b54d8910599549b9e6d4dd5fe6 URL: https://github.com/llvm/llvm-project/commit/a1a6a839763079b54d8910599549b9e6d4dd5fe6 DIFF: https://github.com/llvm/llvm-project/commit/a1a6a839763079b54d8910599549b9e6d4dd5fe6.dif

[clang] Reland "[clang] Lower modf builtin using `llvm.modf` intrinsic" (PR #130761)

2025-03-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Benjamin Maxwell (MacDue) Changes Reverts https://github.com/llvm/llvm-project/commit/c40f0fe4348bb9304b95bd317665bf1cb2bdcc85 Original description: This updates the existing modf[f|l] builtin to be lowered via the llvm.modf.* intrinsic

[clang] [ARM] mtp = auto using hard point while arch supports thumb2 and hardtp (PR #130027)

2025-03-11 Thread Vladi Krapp via cfe-commits
https://github.com/VladiKrapp-Arm closed https://github.com/llvm/llvm-project/pull/130027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM][Clang] Make `+nosimd` functional for AArch32 Targets (PR #130623)

2025-03-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jack Styles (Stylie777) Changes `+simd` and `+nosimd` are used to emable or disable NEON Instructions when compiling for AArch32 Targets. However, up until now, using these has not been possible. To enable this, these options are mapped to

<    1   2   3   4   5   6   7   >