[clang] [Clang] Treat constexpr-unknown value as invalid in `evaluateValue` (PR #128409)

2025-02-24 Thread Eli Friedman via cfe-commits
@@ -3628,8 +3628,6 @@ static bool evaluateVarDeclInit(EvalInfo &Info, const Expr *E, if (AllowConstexprUnknown) { if (!Result) Result = &Info.CurrentCall->createConstexprUnknownAPValues(VD, Base); -else - Result->setConstexprUnknown(); efr

[clang] [Clang][CodeGen] Bail out on constexpr unknown values in ConstantEmitter (PR #127525)

2025-02-24 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I'm worried this is just scratching the surface... it looks like there's a whole class of issues involving constexpr-unknown leaking out of constant evaluation, and this is just addressing one specific case. If we can't take https://github.com/llvm/llvm-project/pull/12840

[clang] [spirv][amdgpu] Set atomic size in the clang target info (PR #128569)

2025-02-24 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/128569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [lld] [llvm] Ugly example of building libc to spirv (PR #128585)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libc Author: Jon Chesterfield (JonChesterfield) Changes Hopefully we can do better before landing. Posting for discussion. Didn't learn a huge amount. spirv rejects the clang::amdgpu_kernel annotation and I can't work out how that's supposed to be spel

[clang] [libc] [lld] [llvm] Ugly example of building libc to spirv (PR #128585)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld Author: Jon Chesterfield (JonChesterfield) Changes Hopefully we can do better before landing. Posting for discussion. Didn't learn a huge amount. spirv rejects the clang::amdgpu_kernel annotation and I can't work out how that's supposed to be spell

[clang] [Wunsafe-buffer-usage] Turn off unsafe-buffer warning for methods annotated with clang::unsafe_buffer_usage attribute (PR #125671)

2025-02-24 Thread Malavika Samak via cfe-commits
@@ -245,3 +243,56 @@ struct AggregateViaDefaultInit { void testAggregateViaDefaultInit() { AggregateViaDefaultInit A; }; + +struct A { + int arr[2]; + + [[clang::unsafe_buffer_usage]] + int *ptr; +}; + +namespace std{ + template class span { + + T *elements; + + pu

[clang] [PAC] Add support for __ptrauth type qualifier (PR #100830)

2025-02-24 Thread Akira Hatanaka via cfe-commits
@@ -104,6 +104,7 @@ FEATURE(thread_sanitizer, LangOpts.Sanitize.has(SanitizerKind::Thread)) FEATURE(dataflow_sanitizer, LangOpts.Sanitize.has(SanitizerKind::DataFlow)) FEATURE(scudo, LangOpts.Sanitize.hasOneOf(SanitizerKind::Scudo)) FEATURE(ptrauth_intrinsics, LangOpts.Pointer

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-24 Thread Bruno Cardoso Lopes via cfe-commits
@@ -2958,8 +2958,13 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; -def emit_core_mlir : Flag<["-"]

[clang] [llvm] workflows/release-binaries: Enable Windows x86 builds (PR #128274)

2025-02-24 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/128274 >From 29b82de7c0ac1cd008a5ddc79c42f5cd492694a7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 22 Feb 2025 03:08:24 + Subject: [PATCH 1/3] workflows/release-binaries: Enable Windows x86 builds ---

[clang] [CIR] Add cir-opt tool to exercise CIR dialect parsing (PR #128254)

2025-02-24 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/128254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-24 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM once remaining comments from others are addressed. https://github.com/llvm/llvm-project/pull/127835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] 9fac59a - [HLSL] Allow arrays to be returned by value in HLSL (#127896)

2025-02-24 Thread via cfe-commits
Author: Sarah Spall Date: 2025-02-24T11:51:01-08:00 New Revision: 9fac59a0db7c7adaa354a47df385cd35d761ec77 URL: https://github.com/llvm/llvm-project/commit/9fac59a0db7c7adaa354a47df385cd35d761ec77 DIFF: https://github.com/llvm/llvm-project/commit/9fac59a0db7c7adaa354a47df385cd35d761ec77.diff L

[clang] [HLSL] Make memory representation of boolean vectors in HLSL, vectors of i32. Add support for boolean swizzling. (PR #123977)

2025-02-24 Thread Eli Friedman via cfe-commits
@@ -1984,6 +1984,15 @@ llvm::Constant *ConstantEmitter::emitForMemory(CodeGenModule &CGM, return Res; } + // In HLSL bool vectors are stored in memory as a vector of i32 + if (destType->isExtVectorBoolType() && CGM.getContext().getLangOpts().HLSL) { e

[clang] [Clang][analyzer] replace Stmt* with ConstCFGElementRef in SymbolConjured (PR #128251)

2025-02-24 Thread Fangyi Zhou via cfe-commits
@@ -27,7 +27,8 @@ namespace ento { /// by the loop body in any iteration. ProgramStateRef getWidenedLoopState(ProgramStateRef PrevState, const LocationContext *LCtx, -unsigned BlockCount, const Stmt *LoopSt

[clang] 8ce17c1 - [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (#128392)

2025-02-24 Thread via cfe-commits
Author: Nathan Ridge Date: 2025-02-24T15:05:14-05:00 New Revision: 8ce17c15577d223e14b62f9198d4b2ae9856b9fb URL: https://github.com/llvm/llvm-project/commit/8ce17c15577d223e14b62f9198d4b2ae9856b9fb DIFF: https://github.com/llvm/llvm-project/commit/8ce17c15577d223e14b62f9198d4b2ae9856b9fb.diff

[clang] [spirv][amdgpu] Set atomic size in the clang target info (PR #128569)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jon Chesterfield (JonChesterfield) Changes Problem identified by Joseph. The openmp device runtime uses __scoped_atomic_load_n and similar which presently hit ``` error: large atomic operation may incur significant performance pena

[clang] [Clang][analyzer] replace Stmt* with ConstCFGElementRef in SymbolConjured (PR #128251)

2025-02-24 Thread Fangyi Zhou via cfe-commits
@@ -171,19 +172,11 @@ class SValBuilder { // Forwarding methods to SymbolManager. - const SymbolConjured* conjureSymbol(const Stmt *stmt, - const LocationContext *LCtx, - QualType type, -

[clang] [libc] [lld] [llvm] Ugly example of building libc to spirv (PR #128585)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jon Chesterfield (JonChesterfield) Changes Hopefully we can do better before landing. Posting for discussion. Didn't learn a huge amount. spirv rejects the clang::amdgpu_kernel annotation and I can't work out how that's supposed to be spe

[clang] [Clang] Treat constexpr-unknown value as invalid in `evaluateValue` (PR #128409)

2025-02-24 Thread Eli Friedman via cfe-commits
@@ -122,9 +122,9 @@ namespace CaseStatements { } extern int &Recurse1; -int &Recurse2 = Recurse1; // expected-note {{declared here}} +int &Recurse2 = Recurse1; // pre-cxx23-note {{declared here}} efriedma-quic wrote: I'd guess you just need to generate a note

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

2025-02-24 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/3] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] Exclude RedirectingFileSystem with null OverlayFileDir in VFSUsage (PR #128267)

2025-02-24 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. Hmm, I think this is fine, although it would be nice if there was a tighter connection between the `-ivfsoverlay` options and this. I don't think that needs to happen here though. https://github.com/llvm/llvm-project/pull/128267

[clang] [profile] runtime counter relocation is needed on windows-msvc targets (PR #127858)

2025-02-24 Thread Wael Yehia via cfe-commits
https://github.com/w2yehia closed https://github.com/llvm/llvm-project/pull/127858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d6ec32c - [profile] runtime counter relocation is needed on windows-msvc targets (#127858)

2025-02-24 Thread via cfe-commits
Author: Wael Yehia Date: 2025-02-24T17:17:14-05:00 New Revision: d6ec32c8f25975ae31ec9ca7e67d942adadc3898 URL: https://github.com/llvm/llvm-project/commit/d6ec32c8f25975ae31ec9ca7e67d942adadc3898 DIFF: https://github.com/llvm/llvm-project/commit/d6ec32c8f25975ae31ec9ca7e67d942adadc3898.diff LO

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

2025-02-24 Thread Ryosuke Niwa via cfe-commits
@@ -117,6 +127,9 @@ bool tryToFindPtrOrigin( E = call->getArg(0); continue; } + +if (safeGetName(callee) == "__builtin___CFStringMakeConstantString") rniwa wrote: This is for CFSTR. https://github.com/llvm/llvm-project/pull

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

2025-02-24 Thread Ryosuke Niwa via cfe-commits
@@ -28,6 +29,15 @@ bool tryToFindPtrOrigin( std::function isSafePtrType, std::function callback) { while (E) { +if (auto *DRE = dyn_cast(E)) { + auto *ValDecl = DRE->getDecl(); + auto QT = ValDecl->getType(); + auto ValName = ValDecl->getName(); +

[clang] [llvm] [Hexagon] Set the default compilation target to V68 (PR #125239)

2025-02-24 Thread Ikhlas Ajbar via cfe-commits
https://github.com/iajbar milestoned https://github.com/llvm/llvm-project/pull/125239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-24 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt updated https://github.com/llvm/llvm-project/pull/128086 >From bebfc20fac6b27d02bca9af328d0568018672c71 Mon Sep 17 00:00:00 2001 From: Ashley Coleman Date: Thu, 20 Feb 2025 16:16:16 -0700 Subject: [PATCH 1/4] [hlsl][Sema] Fix Struct Size Calculation containing 16 and

[clang] [HLSL] Implement default constant buffer $Globals (2nd attempt) (PR #128589)

2025-02-24 Thread Helena Kotas via cfe-commits
https://github.com/hekota created https://github.com/llvm/llvm-project/pull/128589 All variable declarations in the global scope that are not resources, static or empty are implicitly added to implicit constant buffer `$Globals`. They are created in `hlsl_constant` address space and collected

[clang] [HLSL] Implement default constant buffer $Globals (2nd attempt) (PR #128589)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Helena Kotas (hekota) Changes All variable declarations in the global scope that are not resources, static or empty are implicitly added to implicit constant buffer `$Globals`. They are created in `hlsl_constant` address space and

[clang] [HLSL] Implement default constant buffer $Globals (2nd attempt) (PR #128589)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-hlsl Author: Helena Kotas (hekota) Changes All variable declarations in the global scope that are not resources, static or empty are implicitly added to implicit constant buffer `$Globals`. They are created in `hlsl_constant`

[clang] Generalize creduce-clang-crash.py script to look for cvise (PR #128592)

2025-02-24 Thread Reid Kleckner via cfe-commits
https://github.com/rnk created https://github.com/llvm/llvm-project/pull/128592 cvise reimplements creduce in Python and bundles clang-delta and other tools. In my experience, it is generally a more robust reduction tool that is better maintained. I renamed the script to make it tool-neutral, w

[clang] [libc] [lld] [llvm] Ugly example of building libc to spirv (PR #128585)

2025-02-24 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > @JonChesterfield even if you distinguish spirv64 from amdgpu in cmake clang > doesn't make that distinction. A common pattern for spriv64 is to return null > if its not AMDGPU. General question, what's the expected way to access things like thread IDs and such from SPIR-V? Th

[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

2025-02-24 Thread Henrik G. Olsson via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q

[clang] c710118 - [clang] Implement __attribute__((format_matches)) (#116708)

2025-02-24 Thread via cfe-commits
Author: apple-fcloutier Date: 2025-02-24T18:58:59-08:00 New Revision: c7101188fb3f17176e9152b1d733da6d7199d317 URL: https://github.com/llvm/llvm-project/commit/c7101188fb3f17176e9152b1d733da6d7199d317 DIFF: https://github.com/llvm/llvm-project/commit/c7101188fb3f17176e9152b1d733da6d7199d317.dif

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-24 Thread Helena Kotas via cfe-commits
https://github.com/hekota approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/128086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-24 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang,llvm` at step 4 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/6567 Here is the relevant pi

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

2025-02-24 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/5] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

2025-02-24 Thread Shafik Yaghmour via cfe-commits
=?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Cloutier , =?utf-8?q?F=C3=A9lix?= Clou

[clang] Exclude RedirectingFileSystem with null OverlayFileDir in VFSUsage (PR #128267)

2025-02-24 Thread Hiroshi Yamauchi via cfe-commits
@@ -149,11 +149,16 @@ std::vector HeaderSearch::collectVFSUsageAndClear() const { llvm::vfs::FileSystem &RootFS = FileMgr.getVirtualFileSystem(); // TODO: This only works if the `RedirectingFileSystem`s were all created by - // `createVFSFromOverlayFiles`. + //

[clang] Exclude RedirectingFileSystem with null OverlayFileDir in VFSUsage (PR #128267)

2025-02-24 Thread Hiroshi Yamauchi via cfe-commits
https://github.com/hjyamauchi updated https://github.com/llvm/llvm-project/pull/128267 >From a36305e0feb4558045e2168d96ef6d941f48a427 Mon Sep 17 00:00:00 2001 From: Hiroshi Yamauchi Date: Fri, 21 Feb 2025 17:43:30 -0800 Subject: [PATCH] Exclude RedirectingFileSystem with null OverlayFileDir in

[clang] [CIR] Add cir-opt tool to exercise CIR dialect parsing (PR #128254)

2025-02-24 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux` running on `systemz-1` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/42/builds/3422 Here is the relevant piece of the build log f

[clang] [libc] [lld] [llvm] Ugly example of building libc to spirv (PR #128585)

2025-02-24 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @JonChesterfield even if you distinguish spirv64 from amdgpu in cmake clang doesn't make that distinction. A common pattern for spriv64 is to return null if its not AMDGPU. `clang/lib/CodeGen/CGBuiltin.cpp` ``` case llvm::Triple::spirv64: if (CGF->getTarget().getTriple().ge

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-24 Thread via cfe-commits
@@ -535,6 +535,21 @@ void tools::gnutools::Linker::ConstructJob(Compilation &C, const JobAction &JA, D.getLTOMode() == LTOK_Thin); } + // Forward the DTLTO options to the linker. We add these unconditionally, + // rather than in addLTOOptions() as it is

[clang] Remove xbegin and _xend (PR #126952)

2025-02-24 Thread Mike Hommey via cfe-commits
glandium wrote: Should this be uplifted to release/20.x? Cc: @tstellar https://github.com/llvm/llvm-project/pull/126952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clangd][WIP] Add doxygen parsing for Hover (PR #127451)

2025-02-24 Thread via cfe-commits
tcottin wrote: closing this in favor of #128591 https://github.com/llvm/llvm-project/pull/127451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clangd][WIP] Add doxygen parsing for Hover (PR #127451)

2025-02-24 Thread via cfe-commits
https://github.com/tcottin closed https://github.com/llvm/llvm-project/pull/127451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 305d273 - Reland "[HLSL] Implement the reflect HLSL function" (#125599)

2025-02-24 Thread via cfe-commits
Author: Deric Cheung Date: 2025-02-24T16:46:59-08:00 New Revision: 305d2738944f77f8defefe79217120bb8aafab75 URL: https://github.com/llvm/llvm-project/commit/305d2738944f77f8defefe79217120bb8aafab75 DIFF: https://github.com/llvm/llvm-project/commit/305d2738944f77f8defefe79217120bb8aafab75.diff

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-24 Thread Deric Cheung via cfe-commits
https://github.com/Icohedron closed https://github.com/llvm/llvm-project/pull/125599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-24 Thread via cfe-commits
@@ -2142,3 +2190,326 @@ std::vector lto::generateModulesOrdering(ArrayRef R) { }); return ModulesOrdering; } + +namespace { +// For this out-of-process backend no codegen is done when invoked for each +// task. Instead we generate the required information (e.g. the summary

[clang] [llvm] [memprof] Add memprof options as a clang frontend flag (PR #128615)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ellis Hoag (ellishg) Changes Add the clang frontend flag `-fmemory-profile-runtime-default-options` to support the `-memprof-runtime-default-options` LLVM flag introduced in https://github.com/llvm/llvm-project/pull/118874. This enables

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

2025-02-24 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/6] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] [llvm] [HLSL] [DXIL] Implement the AddUint64 HLSL function and the UAddc DXIL op (PR #127137)

2025-02-24 Thread Deric Cheung via cfe-commits
https://github.com/Icohedron updated https://github.com/llvm/llvm-project/pull/127137 >From 4fae5642c6e8e305cdc687b4968ba5eabaa44b50 Mon Sep 17 00:00:00 2001 From: Icohedron Date: Mon, 27 Jan 2025 11:18:09 -0800 Subject: [PATCH 1/8] Add the AddUint64 HLSL builtin function - Defines the AddUint

[clang] [clang-tools-extra] [llvm] [clangd][WIP] Add doxygen parsing using standalone doxygen parser (PR #128591)

2025-02-24 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [CIR] Upstream type `bool` (PR #128601)

2025-02-24 Thread David Olsen via cfe-commits
https://github.com/dkolsen-pgi created https://github.com/llvm/llvm-project/pull/128601 Support the type `bool` and the literals `true` and `false`. Add the type `cir::BoolType` and the attribute `cir::BoolAttr` to ClangIR. Add code in all the necessary places in ClangIR CodeGen to handle and

[clang] [CIR] Upstream type `bool` (PR #128601)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Olsen (dkolsen-pgi) Changes Support the type `bool` and the literals `true` and `false`. Add the type `cir::BoolType` and the attribute `cir::BoolAttr` to ClangIR. Add code in all the necessary places in ClangIR CodeGen to handle a

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-24 Thread Ashley Coleman via cfe-commits
V-FEXrt wrote: @tex3d @hekota Okay PTAL when you have a moment! https://github.com/llvm/llvm-project/pull/128086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clangd][WIP] Add doxygen parsing using standalone doxygen parser (PR #128591)

2025-02-24 Thread via cfe-commits
https://github.com/tcottin created https://github.com/llvm/llvm-project/pull/128591 Continue the work on #78491 and #127451 to fix clangd/clangd#529. In #78491 the work to use the clang doxygen parser without having the ASTContext available was started. This allows to parse doxygen comments f

[clang] Generalize creduce-clang-crash.py script to look for cvise (PR #128592)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Reid Kleckner (rnk) Changes cvise reimplements creduce in Python and bundles clang-delta and other tools. In my experience, it is generally a more robust reduction tool that is better maintained. I renamed the script to make it tool-neutr

[clang] [llvm] Reapply "Reland "[HLSL] Implement the `reflect` HLSL function"" (#124046) (PR #128386)

2025-02-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/128386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement default constant buffer $Globals (2nd attempt) (PR #128589)

2025-02-24 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/128589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the implementation of it is known (PR #85465)

2025-02-24 Thread via cfe-commits
AZero13 wrote: > We can remove the null check when we prove `ID` is never null. Are you sure it is never null? https://github.com/llvm/llvm-project/pull/85465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-24 Thread Tex Riddell via cfe-commits
https://github.com/tex3d approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/128086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve -Wsign-compare diagnostic (PR #128614)

2025-02-24 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Improve -Wsign-compare diagnostic (PR #128614)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (halbi2) Changes The cv-qualifiers are not relevant to the comparison result so one should not print them. --- Full diff: https://github.com/llvm/llvm-project/pull/128614.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaChec

[clang] [clang] Improve -Wsign-compare diagnostic (PR #128614)

2025-02-24 Thread via cfe-commits
https://github.com/halbi2 created https://github.com/llvm/llvm-project/pull/128614 The cv-qualifiers are not relevant to the comparison result so one should not print them. >From 5137e7f1892e4b61d1e496372e82f63b944b8124 Mon Sep 17 00:00:00 2001 From: halbi2 Date: Mon, 24 Feb 2025 19:54:09 -05

[clang] [llvm] [memprof] Add memprof options as a clang frontend flag (PR #128615)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Ellis Hoag (ellishg) Changes Add the clang frontend flag `-fmemory-profile-runtime-default-options` to support the `-memprof-runtime-default-options` LLVM flag introduced in https://github.com/llvm/llvm-project/pull/118874. Thi

[clang] [llvm] [memprof] Add memprof options as a clang frontend flag (PR #128615)

2025-02-24 Thread Ellis Hoag via cfe-commits
ellishg wrote: CC @SharonXSharon https://github.com/llvm/llvm-project/pull/128615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [memprof] Add memprof options as a clang frontend flag (PR #128615)

2025-02-24 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg created https://github.com/llvm/llvm-project/pull/128615 Add the clang frontend flag `-fmemory-profile-runtime-default-options` to support the `-memprof-runtime-default-options` LLVM flag introduced in https://github.com/llvm/llvm-project/pull/118874. This enables u

[clang] [llvm] [memprof] Add memprof options as a clang frontend flag (PR #128615)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Ellis Hoag (ellishg) Changes Add the clang frontend flag `-fmemory-profile-runtime-default-options` to support the `-memprof-runtime-default-options` LLVM flag introduced in https://github.com/llvm/llvm-project/pull/118874. This e

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-24 Thread Tex Riddell via cfe-commits
@@ -172,6 +172,23 @@ Decl *SemaHLSL::ActOnStartBuffer(Scope *BufferScope, bool CBuffer, return Result; } +static unsigned calculateLegacyCbufferFieldAlign(const ASTContext &Context, + QualType T) { + // Arrays and Structs are

[clang] [clang][Sema] Simplify err_init_conversion_failed diagnostic message for const variables (PR #82109)

2025-02-24 Thread via cfe-commits
halbi2 wrote: Hello, I made patch #128614 that fixes a similar diagnostic with `-Wsign-compare`. But my patch is much simpler. I simply remove the cv qualifiers before printing. Why would such an approach not be appropriate in this case as well? https://github.com/llvm/llvm-project/pull/82109

[clang] [clang][bytecode] Handle non-primitive array index expressions (PR #128479)

2025-02-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/128479 By rejecting them instead of asserting in `classifyPrim()`. >From 5fc1574ccca3303b936f7fba0a0e8e1a0707a6df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 24 Feb 2025 09:05:17 +0100 Sub

[clang] [clang][bytecode] Handle non-primitive array index expressions (PR #128479)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes By rejecting them instead of asserting in `classifyPrim()`. --- Full diff: https://github.com/llvm/llvm-project/pull/128479.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+6-3) -

[clang] [Clang] Handle instantiating captures in addInstantiatedCapturesToScope() (PR #128478)

2025-02-24 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/128478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle instantiating captures in addInstantiatedCapturesToScope() (PR #128478)

2025-02-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes `addInstantiatedCapturesToScope()` might be called when transforming a lambda body. In this situation, it would look into all the lambda's parents and figure out all the instantiated captures. However, the i

[clang] [Clang][AArch64] Add support for SHF_AARCH64_PURECODE ELF section flag (2/3) (PR #125688)

2025-02-24 Thread Csanád Hajdú via cfe-commits
Il-Capitano wrote: @smithp35 @davemgreen @paulwalker-arm @jh7370 Pinging to ask for more reviews on this, please. https://github.com/llvm/llvm-project/pull/125688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-02-24 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: I am not a native English speaker, just a personal feeling. I prefer `AllowOmittingNamespaceComments` since it is clearer then `AllowNoNamespaceComments`. https://github.com/llvm/llvm-project/pull/124265 ___ cfe-commits mailing lis

[clang] [clang][NFC] Avoid potential null dereferences (PR #127017)

2025-02-24 Thread Balazs Benics via cfe-commits
steakhal wrote: @schittir Could you please revert the Static Analyzer part? It seems a user tripped on it at #128427 https://github.com/llvm/llvm-project/pull/127017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] 19a39e9 - [clang][bytecode] Handle non-primitive array index expressions (#128479)

2025-02-24 Thread via cfe-commits
Author: Timm Baeder Date: 2025-02-24T09:36:48+01:00 New Revision: 19a39e98ffdd93dce98557d07cff40cc1799f568 URL: https://github.com/llvm/llvm-project/commit/19a39e98ffdd93dce98557d07cff40cc1799f568 DIFF: https://github.com/llvm/llvm-project/commit/19a39e98ffdd93dce98557d07cff40cc1799f568.diff L

[clang] [clang][bytecode] Handle non-primitive array index expressions (PR #128479)

2025-02-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/128479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Updating to include gcc-toolsets 13 and 14 (PR #128438)

2025-02-24 Thread Nikita Popov via cfe-commits
nikic wrote: @MaskRay We already do that, with the following content in the config file: ``` %if %{defined gts_version} %global cfg_file_content %{cfg_file_content} --gcc-install-dir=/opt/rh/gcc-toolset-%{gts_version}/root/%{_exec_prefix}/lib/gcc/%{_target_cpu}-redhat-linux/%{gts_version} %endif

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-02-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/124265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-02-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 commented: Could you organize test. It looks like copy from other tests and have some noise which has nothing to do with the function of the current PR. Also, please rebase to main since release note is cleared https://github.com/llvm/llvm-project/pull/124265 ___

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilia (Large Immediate Arithmetic) extension (PR #124706)

2025-02-24 Thread via cfe-commits
https://github.com/hchandel updated https://github.com/llvm/llvm-project/pull/124706 >From 81d1b6240cfaedb521d4f0efd54744114577f455 Mon Sep 17 00:00:00 2001 From: Harsh Chandel Date: Fri, 24 Jan 2025 16:43:12 +0530 Subject: [PATCH 1/5] [RISCV] Add Qualcomm uC Xqcilia (Large Immediate Arithmeti

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2025-02-24 Thread Vassil Vassilev via cfe-commits
@@ -2639,6 +2628,19 @@ void Sema::MergeTypedefNameDecl(Scope *S, TypedefNameDecl *New, notePreviousDefinition(Old, New->getLocation()); } +void Sema::CleanupMergedEnum(Scope *S, Decl *New) { vgvassilev wrote: I realize that `Sema::ActOnDuplicateDefinition`

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2025-02-24 Thread Vassil Vassilev via cfe-commits
@@ -2551,18 +2551,7 @@ void Sema::MergeTypedefNameDecl(Scope *S, TypedefNameDecl *New, // Make the old tag definition visible. makeMergedDefinitionVisible(Hidden); - // If this was an unscoped enumeration, yank all of its enumerators - // out of the scop

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilia (Large Immediate Arithmetic) extension (PR #124706)

2025-02-24 Thread via cfe-commits
https://github.com/hchandel updated https://github.com/llvm/llvm-project/pull/124706 >From 81d1b6240cfaedb521d4f0efd54744114577f455 Mon Sep 17 00:00:00 2001 From: Harsh Chandel Date: Fri, 24 Jan 2025 16:43:12 +0530 Subject: [PATCH 1/6] [RISCV] Add Qualcomm uC Xqcilia (Large Immediate Arithmeti

[libclc] [libclc] Fix int<->float conversion builtins (PR #126905)

2025-02-24 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/126905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] 6c2d418 - [libclc] Fix int<->float conversion builtins (#126905)

2025-02-24 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-02-24T09:28:51Z New Revision: 6c2d418027be6906733972256e379a844f88fc06 URL: https://github.com/llvm/llvm-project/commit/6c2d418027be6906733972256e379a844f88fc06 DIFF: https://github.com/llvm/llvm-project/commit/6c2d418027be6906733972256e379a844f88fc06.diff LOG

[libclc] [libclc] Move fma to the CLC library (PR #126052)

2025-02-24 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/126052 >From 18d67915671a081540abde18b1b6c009ac094a27 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Tue, 28 Jan 2025 12:19:23 + Subject: [PATCH 1/2] [libclc] Move fma to the CLC library This builtin is a

[libunwind] [libunwind][X86-64] Handle Linux sigreturn trampoline when DWARF info is missing (PR #103473)

2025-02-24 Thread David Spickett via cfe-commits
DavidSpickett wrote: Can someone from @llvm/reviewers-libcxx help with the FreeBSD failure? Seems unrelated. https://github.com/llvm/llvm-project/pull/103473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[libclc] [libclc] Move fma to the CLC library (PR #126052)

2025-02-24 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: > > FYI @rjodinchr this breaks downstream clspv testing. > > ``` > > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) #2 > > # | Unsupported llvm intrinsic > > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > > ``` > > > > > >

[clang] [Clang][AArch64] Add support for SHF_AARCH64_PURECODE ELF section flag (2/3) (PR #125688)

2025-02-24 Thread James Henderson via cfe-commits
=?utf-8?q?Csanád_Hajdú?= Message-ID: In-Reply-To: jh7370 wrote: > @smithp35 @davemgreen @paulwalker-arm @jh7370 Pinging to ask for more reviews > on this, please. Sorry, this part is outside my realm of knowledge. https://github.com/llvm/llvm-project/pull/125688

[libclc] [libclc] Move fma to the CLC library (PR #126052)

2025-02-24 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: > > > FYI @rjodinchr this breaks downstream clspv testing. > > > ``` > > > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) > > > #2 > > > # | Unsupported llvm intrinsic > > > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > > > ``` >

[clang-tools-extra] [clang-tidy] Add new check bugprone-unintended-char-ostream-output (PR #127720)

2025-02-24 Thread Carlos Galvez via cfe-commits
@@ -0,0 +1,45 @@ +.. title:: clang-tidy - bugprone-unintended-char-ostream-output + +bugprone-unintended-char-ostream-output +=== + +Finds unintended character output from ``unsigned char`` and ``signed char`` to an +``ostream``. + +Normally, w

[clang] [Clang] Implement the core language parts of P2786 - Trivial relocation (PR #127636)

2025-02-24 Thread A. Jiang via cfe-commits
@@ -1826,6 +1827,12 @@ The following type trait primitives are supported by Clang. Those traits marked functionally equivalent to copying the underlying bytes and then dropping the source object on the floor. This is true of trivial types and types which were made trivia

[libclc] e7ad07f - [libclc] Move fma to the CLC library (#126052)

2025-02-24 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-02-24T10:10:51Z New Revision: e7ad07ffb846a9812d9567b8d4b680045dce5b28 URL: https://github.com/llvm/llvm-project/commit/e7ad07ffb846a9812d9567b8d4b680045dce5b28 DIFF: https://github.com/llvm/llvm-project/commit/e7ad07ffb846a9812d9567b8d4b680045dce5b28.diff LOG

[libclc] [libclc] Move fma to the CLC library (PR #126052)

2025-02-24 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/126052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add AllowFalseEvaluated flag to clang-tidy noexcept-move-constructor check (PR #126897)

2025-02-24 Thread Dmitry Nechitaev via cfe-commits
@@ -110,6 +110,12 @@ Changes in existing checks ` check by providing additional examples and fixing some macro related false positives. +- Improved :doc:`performance-noexcept-move-constructor + ` check by adding + a new (off-by-default) option `AllowFalseEvaluated`, whic

[clang] clang/OpenCL: Fix assertion on call to function with addrspace argument (PR #115093)

2025-02-24 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/115093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >